Re: [Mesa-dev] [Mesa-stable] [PATCH 04/15] glsl: Add preprocessor error condition for #else directive

2014-06-11 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: #if 0 #else garbage #endif The Khronos test contains two tokens after #else. I'm not sure if that is the difference or not. Khronos is testing many different cases. Failing case tests: #if 1 #else garbage #endif It is the #if 1 that causes the

Re: [Mesa-dev] [PATCH 02/15] glsl: Do not allow undefining the built-in macros

2014-06-11 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: Following changes in above code will also fix the GL_ES macro case: - || strcmp(__VERSION__, $3) == 0) + || strcmp(__VERSION__, $3) == 0 + || (parser-is_gles strcmp(GL_ES, $3) == 0)) Great. Do

Re: [Mesa-dev] [Mesa-stable] [PATCH 04/15] glsl: Add preprocessor error condition for #else directive

2014-06-11 Thread Carl Worth
Carl Worth cwo...@cworth.org writes: I'll poke around at the existing code to see why the garbage after #else is caught with #if 0, but not with #if 1. The difference is fairly straightforward, but it's going to be tricky to fix. Currently, the parser has a production for HASH_ELSE and NEWLINE

Re: [Mesa-dev] [Mesa-stable] [PATCH] Check for NULL native_window into eglCreateWindowSurface()

2014-06-06 Thread Carl Worth
Sinclair Yeh sinclair@intel.com writes: This fix adds a check and sets EGL_BAD_NATIVE_WINDOW Cc: 10.1 10.2 mesa-sta...@lists.freedesktop.org From what I can tell, the function being modified by this patch doesn't actually exist in 10.1, so I'm passing on this patch for the 10.1 branch.

Re: [Mesa-dev] [PATCH 1/2] mesa/main: Make get_hash.c values constant.

2014-06-06 Thread Carl Worth
Ian Romanick i...@freedesktop.org writes: Series is Reviewed-by: Ian Romanick ian.d.roman...@intel.com Cc: 10.1 10.2 mesa-sta...@lists.freedesktop.org This hunk: + /* ARB_vertex_array_bgra */ + case GL_COLOR_ARRAY_SIZE: + array = ctx-Array.VAO-VertexAttrib[VERT_ATTRIB_COLOR0]; +

[Mesa-dev] Mesa 10.1.5

2014-06-06 Thread Carl Worth
/crash in ast_declarator_list::hir() Carl Worth (6): docs: Add md5sums for 10.1.4 release Merge remote-tracking branch 'origin/10.1' into 10.1 cherry-ignore: Ignore two commits. Ignore a patch that is not needed for the 10.1 branch. Update version to 10.1.5 Add

[Mesa-dev] Mesa 10.1.4

2014-05-20 Thread Carl Worth
-gallium-llvm make -j6 make install I have also verified that I pushed the tag. -Carl -- carl.d.wo...@intel.com Changes from 10.1.3 to 10.1.4: Brian Paul (1): mesa: fix double-freeing of dispatch tables inside glBegin/End. Carl Worth (4): docs: Add MD5 sums for 10.1.3 cherry

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: Make sure the 'shader' member is always initialized

2014-05-16 Thread Carl Worth
Michel Dänzer mic...@daenzer.net writes: I pushed my fix as 2bab95973d8ad3a84f62670143d6f26c230d9582, but it sounds like Roland's fix isn't really stable material anyway, so it might be best to ignore both for now. OK. I've added both of these to the ignore list. Thanks for the guidance.

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: Make sure the 'shader' member is always initialized

2014-05-15 Thread Carl Worth
Michel Dänzer mic...@daenzer.net writes: Carl, this patch fixes a bug in commit 3e817e7e56806d8adb8f16c35136045c29908944; please hold off on backporting that to the 10.1 branch without this fix. Thanks for the heads-up. Our usual pattern here is to squash both commits into a single commit on

Re: [Mesa-dev] [Mesa-stable] A candidate branch for the next stable release

2014-05-14 Thread Carl Worth
Chia-I Wu olva...@gmail.com writes: I'd like to nominate this commit on master for 10.1.4 commit 9245206cbfaaa4e18c1f3715eebb5f281070d772 Author: Eric Anholt e...@anholt.net Date: Fri Feb 14 16:06:31 2014 -0800 i965/vs: Use samplers for UBOs in the VS like we do for non-UBO

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50: fix setting of texture ms info to be per-stage

2014-05-13 Thread Carl Worth
Ilia Mirkin imir...@alum.mit.edu writes: Cc: 10.1 10.2 mesa-sta...@lists.freedesktop.org ... /* Sample position pairs for the current output MS level */ -#define NV50_CB_AUX_SAMPLE_OFFSET 0x980 +#define NV50_CB_AUX_SAMPLE_OFFSET 0x300 #define NV50_CB_AUX_SAMPLE_OFFSET_SIZE (4 * 8 * 2) -/*

[Mesa-dev] Mesa 10.1.3

2014-05-09 Thread Carl Worth
have also verified that I pushed the tag. -Carl -- carl.d.wo...@intel.com Changes from 10.1.2 to 10.1.3 Carl Worth (4): docs: Add MD5 sums for Mesa 10.1.2 get-pick-list.sh: Require explicit 10.1 for nominating stable patches VERSION: Update to 10.1.3 docs: Add release

Re: [Mesa-dev] Mesa 10.1.2

2014-05-09 Thread Carl Worth
Thomas Hellstrom thellst...@vmware.com writes: The reason it was CC'd stable was that it appeared to fix a rendering problem that we were seeing, but I should definitely have tested this more thoroughly. :( No worries. It happens to all of us at times. An unfortunate situation but the sooner

[Mesa-dev] Mesa 10.1.2

2014-05-05 Thread Carl Worth
swrast_texture_image::ImageSlices array if needed Carl Worth (5): docs: Add the MD5 sums for the 10.1.1 release tar files. cherry-ignore: Ignore a patch causing a regression cherry-ignore: Drop an ignored patch now that piglit has been updated. Update VERSION to 10.1.2 docs: Add notes

Re: [Mesa-dev] [Mesa-announce] Mesa 10.2 release candidate 1

2014-05-05 Thread Carl Worth
Ian Romanick i...@freedesktop.org writes: Mesa 10.2 release candidate 1 is now available for testing. The current plan of record is to have an additional release candidate each Friday until the 10.2 release on Friday, May 28th. With the 10.2 branch open now, I'd like to remind everyone that

Re: [Mesa-dev] [Mesa-stable] A candidate branch for the next stable release

2014-05-02 Thread Carl Worth
Emil Velikov emil.l.veli...@gmail.com writes: Had some trivial nitpick with it earlier, which is not a reason for the patch to not go in as is. Pushed to master - commit 625bdd64e5ea3327d4459b1ff8dab89129d0 Thanks for the review and push! mesa: Remove redundant if checks in

[Mesa-dev] A candidate branch for the next stable release

2014-05-01 Thread Carl Worth
I've recently pushed an update to the 10.1 branch. I anticipate making a release from this branch tomorrow. The state of this branch is summarized here: http://cworth.org/~cworth/mesa-stable-queue/ As always, please let me know if I have missed something that should be picked over to

Re: [Mesa-dev] A candidate branch for the next stable release

2014-05-01 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: Today morning, I've pushed a series of patches marked for stable releases. It would be nice to pick them as well. Sorry for the last minute commits. No problem. I'll pick these all and push as quick as I can so we can still have 24 hours before I cut

Re: [Mesa-dev] [Mesa-stable] [PATCH V4 3/4] glsl: Link error if fs defines conflicting qualifiers for gl_FragCoord

2014-05-01 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: This patch causes the shader link to fail if we have multiple fragment shaders with conflicting layout qualifiers for gl_FragCoord. Anuj, This one has a non-trivial conflict on the 10.1 branch. Can you either recommend skipping this one or else provide

Re: [Mesa-dev] [Mesa-stable] A candidate branch for the next stable release

2014-05-01 Thread Carl Worth
Carl Worth cwo...@cworth.org writes: * There are 23 patches that have been sent to the mesa-stable mailing list, but have not yet been merged to master. The oldest of these is from February 20 (10 weeks ago!). With the recent updates, I'm happy to say that this list is now down

Re: [Mesa-dev] [PATCH] swrast: Fix vertex color in _swsetup_Translate()

2014-05-01 Thread Carl Worth
Ville Syrjälä ville.syrj...@linux.intel.com writes: but I guess 10.1 is the only still active stable branch? Yes. I'm performing releases based on the preceding major release. And I continue these through one overlap of a stable release on the new major release. That is, the last release I'll

Re: [Mesa-dev] [Mesa-stable] A candidate branch for the next stable release

2014-05-01 Thread Carl Worth
Carl Worth cwo...@cworth.org writes: At this point, I'm just waiting for Anuj to backport two patches, then I'll test and push out the latest state as reflected here: Anuj gave me the updated patches, and testing looks good. I've pushed out this state now: http://cworth.org/~cworth

Re: [Mesa-dev] [PATCH] swrast: Add glBlitFramebuffer to commands affected by conditional rendering

2014-04-23 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: + /* Page 679 of OpenGL 4.4 spec says: +*Added BlitFramebuffer to commands affected by conditional rendering in +* section 10.10 (Bug 9562). +*/ + if (!_mesa_check_conditional_render(ctx)) + return; /* Do not blit */ +

Re: [Mesa-dev] [PATCH] swrast: Add glBlitFramebuffer to commands affected by conditional rendering

2014-04-23 Thread Carl Worth
Carl Worth cwo...@cworth.org writes: After I picked this to the 10.1 branch and tested I found the following piglit regression: ... So I'm moving this patch off of the applied queue and onto a new rejected queue as can be seen here: Actually, I replied to the wrong email here. The patch I

Re: [Mesa-dev] [PATCH] swrast: Add glBlitFramebuffer to commands affected by conditional rendering

2014-04-23 Thread Carl Worth
Carl Worth cwo...@cworth.org writes: After I picked this to the 10.1 branch and tested I found the following piglit regression: $ ~/src/piglit/bin/nv_conditional_render-blitframebuffer -auto Probe color at (0,16) Expected: 0.00 1.00 0.00 0.00

[Mesa-dev] New, web-based, live view of stable-branch queue

2014-04-22 Thread Carl Worth
I'm now publishing a web page that categorizes the patches that have been nominated for the stable branch. Check it out: http://cworth.org/~cworth/mesa-stable-queue/ (I've also added a link to this page from the mesa-stable mailing list description page so that you can

Re: [Mesa-dev] [PATCH V3 03/10] mesa: Add error condition for integer formats in glGetTexImage()

2014-04-21 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: OpenGL 4.0 spec, page 306 suggests an INVALID_OPERATION in glGetTexImage if : format is one of the integer formats in table 3.3 and the internal format of the texture image is not integer, or format is not one of the integer formats in

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] i965: Put an assertion to check valid varying_to_slot[varying]

2014-04-21 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: decl |= buffer SO_DECL_OUTPUT_BUFFER_SLOT_SHIFT; + assert(vue_map-varying_to_slot[varying] = 0); decl |= vue_map-varying_to_slot[varying] I have the same question here as in my previous message to another patch. Could this new

Re: [Mesa-dev] [Mesa-stable] [PATCH V3 03/10] mesa: Add error condition for integer formats in glGetTexImage()

2014-04-21 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: Previously it would fail with an error like: implementation error: bad format in _mesa_pack_rgba_span Now it'll throw out a genuine GL error. Perfect, thanks. With that, I'll happily pick the patch over to 10.1. -Carl -- carl.d.wo...@intel.com

[Mesa-dev] Mesa 10.1.1

2014-04-18 Thread Carl Worth
LIST_INITHEAD(dirty_buffers) earlier in svga_context_create() Carl Worth (4): cherry-ignore: Ignore a few patches glsl: Allow explicit binding on atomics again Update VERSION to 10.1.1 docs: Add release notes for 10.1.1 Chia-I Wu (1): i965/vec4: fix record clearing

[Mesa-dev] Mesa 10.0.5

2014-04-18 Thread Carl Worth
in cso_set_sampler_views() svga: replace sampler assertion with conditional svga: move LIST_INITHEAD(dirty_buffers) earlier in svga_context_create() Carl Worth (4): docs: Add md5sums for the 10.0.4 release. Ignore patches which don't apply. Update version to 10.0.5 docs: Add

Re: [Mesa-dev] [Mesa-stable] Old, outstanding patches nominated for the stable branch

2014-04-17 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: Patch is present on master: commit 6bd2472a8b9a969d06dc110bd30ccd8daf713959 Thanks. And that's in 10.1 already as well. Sorry I'd missed it. I've pushed few more patches which I was holding back to push along with many others still under review.

Re: [Mesa-dev] [PATCH] glsl: Allow explicit binding on atomics again

2014-04-17 Thread Carl Worth
Chris Forbes chr...@ijw.co.nz writes: As of 943b2d52bf5, layout(binding) on an atomic would fail the assertion here. Signed-off-by: Chris Forbes chr...@ijw.co.nz Cc: Ian Romanick ian.d.roman...@intel.com Tested-by: Carl Worth cwo...@cworth.org (That is, on my Intel laptop this patch fixes

Re: [Mesa-dev] [PATCH] mesa: add missing DebugMessageControl types

2014-04-16 Thread Carl Worth
Timothy Arceri t_arc...@yahoo.com.au writes: After a quite look the new series doesnt apply cleanly to 10.1 as there have been a number of cleanups in between. I don't think I will get around to rebasing in time for the stable release but I don't think its a big deal if this fix doesn't go in.

Re: [Mesa-dev] Mesa 10.1.1 is imminent

2014-04-16 Thread Carl Worth
Eric Anholt e...@anholt.net writes: So, I'd be happy to have it cherry-picked to 10.1. Yeah, that's my conclusion, too. OK. Consensus all around. I'll land that (and some other recent fixes), do one last round of testing and push 10.1.1 out. I'll be doing 10.0.5 at the same time. I pushed the

[Mesa-dev] Old, outstanding patches nominated for the stable branch

2014-04-16 Thread Carl Worth
Hi folks, Here are patches that were nominated for the stable branch over one month ago, but have apparently not yet landed on master. Maybe some of these have been neglected or missed in the review process? nv30: report the correct max varying limit (Jan 29, Ilia Mirkin) mesa: Fix error

Re: [Mesa-dev] Old, outstanding patches nominated for the stable branch

2014-04-16 Thread Carl Worth
Ilia Mirkin imir...@alum.mit.edu writes: nv30: report the correct max varying limit (Jan 29, Ilia Mirkin) I believe this one should have been superceded with commit 356aff3a5c08be (nv30: report 8 maximum inputs), also tagged for stable. Thanks for letting me know. And that one is in place

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/7] linker: Fold set_uniform_binding into call site

2014-04-16 Thread Carl Worth
Ian Romanick i...@freedesktop.org writes: variable. That's never passed to set_uniform_binding, and it's easier to just remove the function (especially for later patches in the series) than to add another parameter. Hi Ian, I should have looked closer at this commit when I was reviewing it

[Mesa-dev] Mesa 10.1.1 is imminent

2014-04-15 Thread Carl Worth
Hi folks, I've been through all of my email backlog to the mesa-stable@ list and just pushed out a few additional fixes to the 10.1 branch, (perhaps with a bit less testing than I would normally do before pushing). I'll give this some additional, real testing and let it sit overnight for anyone

Re: [Mesa-dev] [Mesa-stable] [PATCH] haiku: Fix build through scons corrections and viewport fixes

2014-04-15 Thread Carl Worth
Alexander von Gluck IV kallis...@unixzen.com writes: I'd like to get this into the 10.1.x branch as all of the changes are build fixes to issues present in 10.1.0 (even the pthread change, seems pthread support is a requirement now as without it Mesa won't build) Hi Alexander, I did just pick

Re: [Mesa-dev] [PATCH] mesa: add missing DebugMessageControl types

2014-04-15 Thread Carl Worth
Timothy Arceri t_arc...@yahoo.com.au writes: Forgot to CC stable. This should apply to both 10 branches. Hi Timothy, The specific patch you were referring to didn't get applied. But a very similar version did appear later (which I didn't find in my email archives). See below. Shall I pick this

Re: [Mesa-dev] Preparing for 10.1.1

2014-04-14 Thread Carl Worth
Dylan Baker baker.dyla...@gmail.com writes: Carl, the 10.1 branch does not currently build for r600, I get the following message: Thanks for testing, Dylan! As part of my standard list of release steps, I do generally do a build of all drivers. I guess I just need to get in the habit of doing

Re: [Mesa-dev] [PATCH 1/3] radeonsi: move translate_colorswap to common code

2014-04-14 Thread Carl Worth
Marek Olšák mar...@gmail.com writes: The patch is probably not necessary. The same applies to patch 2. Thanks. I've dropped both, and this seems to have fixed the build problem I had introduced. I also just force-pushed this new 10.1 branch without the cherry-picked commit that was causing the

[Mesa-dev] Preparing for 10.1.1

2014-04-11 Thread Carl Worth
I'm (finally) getting around to putting together a new stable release. I apologize it's so late. I've just pushed about 66 patches to the 10.1 branch. This includes almost everything currently on master that was nominated for the stable branch. There are a handful of patches which I didn't

Re: [Mesa-dev] [PATCH 1/3] radeonsi: move translate_colorswap to common code

2014-04-11 Thread Carl Worth
Marek Olšák mar...@gmail.com writes: On Mon, Mar 3, 2014 at 4:19 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Sun, Mar 2, 2014 at 8:25 PM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com Also translate the Y__X swizzle. For the series: Reviewed-by: Alex

[Mesa-dev] Mesa 10.0.4

2014-03-12 Thread Carl Worth
format conversion in glGetTexImage softpipe: use 64-bit arithmetic in softpipe_resource_layout() Carl Worth (5): docs: Add md5sums for 10.0.3 release main: Avoid double-free of shader Label get-pick-list: Update to only find patches nominated for the 10.0 branch Update

[Mesa-dev] [PATCH] main: Avoid double-free of shader Label

2014-02-13 Thread Carl Worth
As documented, the _mesa_free_shader_program_data function: Frees all the data that hangs off a shader program object, but not the object itself. This means that this function may be called multiple times on the same object, (and has been observed to). Meanwhile, the shProg-Label

Re: [Mesa-dev] [PATCH] main: Avoid double-free of shader Label

2014-02-13 Thread Carl Worth
Brian Paul bri...@vmware.com writes: Reviewed-by: Brian Paul bri...@vmware.com Probably a candidate for the stable branches too, right? Sure. Good point. I'll be sure to add the note to the commit message so that the stable maintainer doesn't miss this, (I here that guy can need some hand

Re: [Mesa-dev] [PATCH 4/4] glsl: Change locations from yylloc to appropriate tokens positions.

2014-02-06 Thread Carl Worth
Sir Anthony anth...@adsorbtion.org writes: This is tough question, I thought about it some time and concluded that some function class must include body range, otherwise there will be no easy way to get function end Good. That's all I wanted to hear, that you had intentionally thought about

Re: [Mesa-dev] [PATCH 4/4] glsl: Change locations from yylloc to appropriate tokens positions.

2014-02-05 Thread Carl Worth
this issue to see if this is what you actually intended in this case. Regardless of whether you restrict the range in this case, the entire series is: Reviewed-by: Carl Worth cwo...@cworth.org -Carl -- carl.d.wo...@intel.com pgpah60_m9n5b.pgp Description: PGP signature

Re: [Mesa-dev] [PATCH 2/4] glsl: Extend ast location structure to hande end token position.

2014-02-05 Thread Carl Worth
Sir Anthony anth...@adsorbtion.org writes: + unsigned first_line; /** Line number within the source string. */ + unsigned first_column;/** Column in the line. */ + unsigned last_line; /** Line number within the source string. */ + unsigned last_column;

Re: [Mesa-dev] [PATCH] glcpp: Do not remove spaces to preserve locations.

2014-02-05 Thread Carl Worth
! This commit message and the patch match much better than the previous version. And thanks for updating the test suite as well. Reviewed-by: Carl Worth cwo...@cworth.org -Carl pgpph5cZLYl_s.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] [PATCH] glsl-compiler: ast: Precise locations positions.

2014-02-04 Thread Carl Worth
Sir Anthony anth...@adsorbtion.org writes: 1. Change locations setup in glsl_parser.yy from yylloc to appropriate token locations. 2. Addition of two fields in ast_node location to hold end position of token. 3. Addition of ast_node method to setup range locations (for aggregate tokens).

Re: [Mesa-dev] Stable 10.0 branch updated for imminent release

2014-02-03 Thread Carl Worth
Matt Turner matts...@gmail.com writes: We definitely want to apply glx: Update glxext.h to revision 24777. in time for the next 10.0 release. It fixes a really annoying problem with the GL headers that make distributions lives awful. Thanks. I'm glad I asked people to point out anything I

Re: [Mesa-dev] Stable 10.0 branch updated for imminent release

2014-02-03 Thread Carl Worth
Matt Turner matts...@gmail.com writes: Another couple 10.0.3 requests - fcefdc9a595c5 (see https://bugs.freedesktop.org/show_bug.cgi?id=73900) - 1cdeeef6c400 (see https://bugs.freedesktop.org/show_bug.cgi?id=73902) Thanks. Applied. -Carl -- carl.d.wo...@intel.com pgpYvofdRNcq8.pgp

[Mesa-dev] Mesa 10.0.3

2014-02-03 Thread Carl Worth
' interpolation qualifier in case of persample shading Brian Paul (3): mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query st/mesa: fix glReadBuffer(GL_NONE) segfault draw: fix incorrect vertex size computation in LLVM drawing code Carl Worth (6): Add md5sums

Re: [Mesa-dev] [PATCH] configure: Enable large file support for the 32-bit platforms

2014-01-31 Thread Carl Worth
Lauri Kasanen c...@gmx.com writes: 32-bit use is on the increase due to Steam; avoid any surprises and make Mesa LFS-aware. ... AC_PROG_MKDIR_P +AC_SYS_LARGEFILE Hi Lauri, Can you describe a bit more what failure modes you encounter without AC_SYS_LARGEFILE in place? I just haven't dealt

Re: [Mesa-dev] [PATCH] glsl: Expand non-expr non-swizzle scalar rvalues in vectorizing.

2014-01-31 Thread Carl Worth
Matt Turner matts...@gmail.com writes: --- src/glsl/opt_vectorize.cpp | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) Hi Matt, I'm missing the rest of your commit message besides the one-line summary. I think the discipline of always typing _something_ there is

Re: [Mesa-dev] [PATCH] i965: Ignore 'centroid' interpolation qualifier in case of persample shading

2014-01-31 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: I missed this change in commit f5cfb4a. It fixes the incorrect rendering caused in Dolphin Emulator. It's too late for my review to change anything, but since I was recently adding this commit (and the previous one being touched-up here) to my ignore

Re: [Mesa-dev] [PATCH 3/3] i965: Use brw_bo_map[_gtt]() in intel_miptree_map_raw().

2014-01-31 Thread Carl Worth
to decide. In the meantime, for the series: Reviewed-by: Carl Worth cwo...@cworth.org -Carl -- carl.d.wo...@intel.com pgp4uGBxWxbae.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] glsl: Fix continue statements in do-while loops.

2014-01-31 Thread Carl Worth
. For the series: Acked-by: Carl Worth cwo...@cworth.org That is, I find the concept of the patch description totally sound. I've read the patch itself closely, and it appears to agree with the description. But given my relative lack of familiarity with the dependent functions I'm not good enough

[Mesa-dev] Stable 10.0 branch updated for imminent release

2014-01-31 Thread Carl Worth
' interpolation qualifier in case of persample shading Brian Paul (3): [*] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query st/mesa: fix glReadBuffer(GL_NONE) segfault [*] draw: fix incorrect vertex size computation in LLVM drawing code Carl Worth (4): Add

Re: [Mesa-dev] [PATCH] glcpp: Reject #version after the version has been resolved.

2014-01-30 Thread Carl Worth
: Reviewed-by: Carl Worth cwo...@cworth.org -Carl -- carl.d.wo...@intel.com pgprLcG_fpZUy.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] glcpp: Allow integer expression for #line directive.

2014-01-29 Thread Carl Worth
Matt Turner matts...@gmail.com writes: -| LINE_EXPANDED integer_constant integer_constant NEWLINE { +| LINE_EXPANDED expression integer_constant NEWLINE { shouldn't this should be LINE_EXPANDED expression expression NEWLINE Yes. Thanks for the catch. I'll expand the testing and

[Mesa-dev] [PATCH 2/2] glcpp: Add make check test for comment-parsing bug

2014-01-29 Thread Carl Worth
This is the innocent-looking but killer test case to verify the bug fixed in the preceding commit. --- src/glsl/glcpp/tests/121-comment-bug-72686.c | 2 ++ src/glsl/glcpp/tests/121-comment-bug-72686.c.expected | 3 +++ 2 files changed, 5 insertions(+) create mode 100644

[Mesa-dev] [PATCH 1/2] glcpp: Don't enter lexer's NEWLINE_CATCHUP start state for single-line comments

2014-01-29 Thread Carl Worth
In commit 6005e9cb28 a new start state of NEWLINE_CATCHUP was added to the lexer. This start state is used whenever the lexer is emitting a NEWLINE token to emit additional NEWLINE tokens for any newline characters that were skipped by an immediately preceding multi-line comment. However, that

Re: [Mesa-dev] [PATCH 1/2] glcpp: Allow integer expression for #line directive.

2014-01-29 Thread Carl Worth
Carl Worth cwo...@cworth.org writes: Matt Turner matts...@gmail.com writes: LINE_EXPANDED expression expression NEWLINE Yes. Thanks for the catch. I'll expand the testing and follow up with a new set of patches. Except that that's totally bogus. We can't parse two adjacent expressions

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/5] glcpp: Set extension defines after resolving the GLSL version.

2014-01-28 Thread Carl Worth
Matt Turner matts...@gmail.com writes: Unless there are objections, I think we should probably skip this patch going to the stable branches. Thanks, Matt. I've updated my .cherry-ignore file so that I won't accidentally pick this one over to the stable branch. To everyone, Matt's protocol here

Re: [Mesa-dev] [PATCH 1/2] mesa: Ensure that transform feedback refers to the correct program.

2014-01-28 Thread Carl Worth
Paul Berry stereotype...@gmail.com writes: Previous to this patch, the _mesa_{Begin,Resume}TransformFeedback functions were using ctx-Shader.CurrentProgram[MESA_SHADER_VERTEX] I see that this commit was nominated for the stable branch when it was committed. However, it appears to depend at

[Mesa-dev] [PATCH 2/2] glcpp: Add testing for #line with integer expression.

2014-01-28 Thread Carl Worth
This was enabled in the previous commit. Now add a test for make check to ensure it works. --- src/glsl/glcpp/tests/120-hash-line-expression.c | 8 src/glsl/glcpp/tests/120-hash-line-expression.c.expected | 9 + 2 files changed, 17 insertions(+) create mode 100644

[Mesa-dev] [PATCH 1/2] glcpp: Allow integer expression for #line directive.

2014-01-28 Thread Carl Worth
The GLSL specification explicitly allows for an in integer expression here, not just a literal integer. The specification says: #line must have, after macro substitution, one of the following forms: #line line #line line source-string-number where

Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-27 Thread Carl Worth
that this segmentation-fault has been there with a late #version suggestions that we haven't had any piglit test for this case. Presumably we should emit a warning that the late #version is being ignored? Regardless, Reviewed-by: Carl Worth cwo...@cworth.org -Carl -- carl.d.wo...@intel.com pgpuUfXf1fD1_.pgp

Re: [Mesa-dev] [PATCH 1/2] glcpp: Check version_resolved in the proper place.

2014-01-27 Thread Carl Worth
Ian Romanick i...@freedesktop.org writes: (The first is should be if). That's in patch #2. :) Yeah, that's what I get for reviewing patches in the order they arrive on the list... :-) -Carl pgpWgJ3mrTEsx.pgp Description: PGP signature ___ mesa-dev

Re: [Mesa-dev] [PATCH] glcpp: Check version_resolved in the proper place.

2014-01-25 Thread Carl Worth
Matt Turner matts...@gmail.com writes: The check was in the wrong place, ... I don't doubt that the change here is good and correct, but I think there's likely some additional renaming that can be applied: + if (parser-version_resolved) + return; +

[Mesa-dev] Mesa 10.0.2

2014-01-09 Thread Carl Worth
in glBeginConditionalRender() Carl Worth (3): docs: Add md5sums for the 10.0.1 release. Update version to 10.0.2 docs: Add release notes for 10.0.2 release. Chad Versace (1): i965/gen6: Fix HiZ hang in WebGL Google Maps Erik Faye-Lund (1): glcpp: error on multiple #else/#elif directives

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: implement missing glGet(GL_RGBA_SIGNED_COMPONENTS_EXT) query

2014-01-09 Thread Carl Worth
Ian Romanick i...@freedesktop.org writes: There are fixes on top of this fix. When they get picked over to the stable branch, I think at least this and the one from 050961.html should get squashed together. http://lists.freedesktop.org/archives/mesa-dev/2014-January/050961.html

[Mesa-dev] Plans for 10.0.3 release

2014-01-09 Thread Carl Worth
Hi folks, I just released Mesa 10.0.2 (a bit late) and followed it by immediately working through my queue of commits nominated for the stable branch, which I've just pushed out. Since the code for 10.0.2 was done and pushed a week ago, my current plan is to release 10.0.2 just one week from

Re: [Mesa-dev] [PATCH v2] glcpp: error on multiple #else/#elif directives

2014-01-02 Thread Carl Worth
Erik Faye-Lund kusmab...@gmail.com writes: Here's a resend of an older patch (original 1379968503-30246-1-git-send-email-kusmab...@gmail.com), this time with a better commit message, and a similar treatment for elif-after-else. Thanks for the commit, Erik. I've just pushed this out with the

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] glsl: Fix inconsistent assumptions about ir_loop::counter.

2014-01-02 Thread Carl Worth
Paul Berry stereotype...@gmail.com writes: Note: this change is just invasive enough that it probably shouldn't be picked over to stable before the 10.0 release. But I recommend picking it over to stable after the 10.0 release. It didn't happen before 10.0.1, but I've cherry-picked this over

[Mesa-dev] [PATCH 1/2] glcpp: Add a more descriptive comment for the SKIP state manipulation

2013-12-19 Thread Carl Worth
Two things make this code confusing: 1. The uncharacteristic manipulation of lexer start state outside of flex rules. 2. The confusing semantics of the skip_stack (including the lexing_if override and the SKIP_NO_SKIP state). This new comment is intended to

[Mesa-dev] [PATCH 2/2] glcpp: Replace multi-line comment with a space (even as part of macro definition)

2013-12-19 Thread Carl Worth
The preprocessor has always replaced multi-line comments with a single space character, (as required by the specification), but as of commit bd55ba568b301d0f764cd1ca015e84e1ae932c8b the lexer also emitted a NEWLINE token for each newline within the comment, (in order to preserve line numbers).

Re: [Mesa-dev] [PATCH 2/2] glcpp: Replace multi-line comment with a space (even as part of macro definition)

2013-12-19 Thread Carl Worth
Carl Worth cwo...@cworth.org writes: Given those considerations, and given that the SKIP-state manipulation already involves a code block at the top of the lexer function, before any rules, it seems best to me to go with the implementation here which adds a similar pre-rule code block

Re: [Mesa-dev] [PATCH][9.2] st/xorg: Handle new DamageUnregister API which has only one argument

2013-12-12 Thread Carl Worth
Chí-Thanh Christopher Nguyễn chith...@gentoo.org writes: This fixes building against the new API in X server 1.15 Taken from xf86-video-modesetting beca4dfb0e4d11d3729214967a1fe56ee5669831 from Keith Packard Thanks. I've cherry-picked this over to 9.2. If no issues are found in testing, this

[Mesa-dev] Mesa 10.0.1

2013-12-12 Thread Carl Worth
the regression that Mesa 10.0 could not be loaded by any released version of the X server. Axel Davy (2): egl/wayland: Flush the wl_display at the end of SwapBuffers Enable throttling in SwapBuffers Carl Worth (3): docs: Add release notes for 10.0.1 Makefile: Add bin/test-driver

[Mesa-dev] Mesa 9.2.5

2013-12-12 Thread Carl Worth
Mesa 9.2.5 has been released. Mesa 9.2.5 is a bug fix release which fixes bugs fixed since the 9.2.4 release, (see below for a list of changes). The tag in the git repository for Mesa 9.2.5 is 'mesa-9.2.5'. Mesa 9.2.5 is available for download at ftp://freedesktop.org/pub/mesa/9.2.5/ md5sums:

Re: [Mesa-dev] Nesa-dev now integrated with patchwork

2013-12-10 Thread Carl Worth
Paul Berry stereotype...@gmail.com writes: I just pushed some patches to piglit and mesa, and the script seems to be working well now. Thanks for all your hard work on this, Carl! Cool! When I saw the subject of your mail, I was afraid something wasn't working again. I'm glad to know it's all

Re: [Mesa-dev] Nesa-dev now integrated with patchwork

2013-12-05 Thread Carl Worth
Carl Worth cwo...@cworth.org writes: So, you should all expect to see these hook messages now: remote: I: patch #PATCHWORK_ID updated using rev GIT_COMMIT. ... remote: E: failed to find patch for rev GIT_COMMIT. For anyone who has pushed patches for the past couple of days, you

Re: [Mesa-dev] Nesa-dev now integrated with patchwork

2013-12-03 Thread Carl Worth
Carl Worth cwo...@cworth.org writes: When a branch is pushed to the master git repo, a git hook will automatically search for the patch in the database, and if it is found, ... At least, that was my intention. I had a couple of permissions problem with the git hook, so it hasn't actually

[Mesa-dev] Mesa 9.2.4

2013-11-28 Thread Carl Worth
) With these two criteria met, we're fairly confident that these changes are note likely to introduce any regressions. Brian Paul (1): st/mesa: fix GL_FEEDBACK mode inverted Y coordinate bug Carl Worth (4): docs: Add MD5 sums for the 9.2.3 release Merge branch '9.2-freedreno' of git

[Mesa-dev] Nesa-dev now integrated with patchwork

2013-11-27 Thread Carl Worth
For those of you who don't know, freedesktop.org runs an instance of Patchwork to aid in tracking patches that are in need of review. We've just finished getting it integrated with the Mesa-dev list. Here's a brief run-down of what Patchwork provides for us. Automatic flow of patches in Patchwork

[Mesa-dev] Mesa 9.2.3

2013-11-13 Thread Carl Worth
Mesa 9.2.3 has been released. Mesa 9.2.3 is a bug fix release which fixes bugs fixed since the 9.2.2 release. The tag in the git repository for Mesa 9.2.3 is 'mesa-9.2.3'. Mesa 9.2.3 is available for download at ftp://freedesktop.org/pub/mesa/9.2.3/ md5sums: 66e9a33a414f801e1c33398bf627d56b

Re: [Mesa-dev] [PATCH] Remove error when calling glGenQueries/glDeleteQueries while a query is active

2013-10-30 Thread Carl Worth
Kenneth Graunke kenn...@whitecape.org writes: Would you mind adding the mesa: prefix to the commit title? I wouldn't mind at all. Thanks for the reminder. Only, I did happen to push out that commit before I got your message. :-P -ASSERT(!q-Active); /* should be caught earlier */

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: fix blitting the last 2 mipmap levels of compressed textures

2013-10-28 Thread Carl Worth
Carl Worth cwo...@cworth.org writes: If someone could rebase this against 9.2 and email the result to mesa-stable, I would be more than happy to merge it. Last ping from me on this one. If a new patch appears in the next day or two, this could get in to 9.2.3 Otherwise, not having heard

Re: [Mesa-dev] [PATCH 2/9] i965: Fix texture buffer rendering after a whole buffer replacement.

2013-10-28 Thread Carl Worth
Eric Anholt e...@anholt.net writes: Fixes the new piglit GL_ARB_texture_buffer_object/data-sync Cc: 9.2 mesa-sta...@lists.freedesktop.org Hi Eric, I recently pushed this out to the 9.2 branch. But I also noticed that my testing didn't include the new test mentioned above. Do you expect to be

Re: [Mesa-dev] [PATCH] i965: Do not set bilinear_filter flag in case of multisample blits

2013-10-28 Thread Carl Worth
Anuj Phogat anuj.pho...@gmail.com writes: Setting bilinear_filter flag in case of multisample blits with GL_LINEAR filter causes incorrect behavior in translate_dst_to_src() function. This broke Modern Warfare (1, 2 and 3) on SNB, IVB and HSW. ... Cc: mesa-sta...@lists.freedesktop.org Hi

Re: [Mesa-dev] [PATCH] Remove error when calling glGenQueries/glDeleteQueries while a query is active

2013-10-28 Thread Carl Worth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 There is nothing in the OpenGL specification which prevents the user from calling glGenQueries to generate a new query object while another object is active. Neither is there anything in the Mesa implementation which prevents this. So remove the

[Mesa-dev] Mesa 9.2.2

2013-10-18 Thread Carl Worth
Mesa 9.2.2 has been released. Mesa 9.2.2 is a bug fix release which fixes bugs fixed since the 9.2.1 release. The tag in the git repository for Mesa 9.2.2 is 'mesa-9.2.2'. Mesa 9.2.2 is available for download at ftp://freedesktop.org/pub/mesa/9.2.2/ md5sums: df801a975045150790e10e2ccf32193f

[Mesa-dev] [PATCH] Remove error when calling glGenQueries/glDeleteQueries while a query is active

2013-10-17 Thread Carl Worth
There is nothing in the OpenGL specification which prevents the user from calling glGenQueries to generate a new query object while another object is active. Neither is there anything in the Mesa implementation which prevents this. So remove the INVALID_OPERATION errors in this case. Similarly,

Re: [Mesa-dev] [PATCH] Remove error when calling glGenQueries/glDeleteQueries while a query is active

2013-10-17 Thread Carl Worth
, it is explicitly allowed by the OpenGL specification to delete an active query, so remove the assertion for that case and be sure to call the driver's EndQuery hook. CC: mesa-sta...@lists.freedesktop.org --- Brian Paul bri...@vmware.com writes: On 10/17/2013 12:14 PM, Carl Worth wrote: But from

Re: [Mesa-dev] [Bug 69437] Composite Bypass no longer works

2013-10-14 Thread Carl Worth
bugzilla-dae...@freedesktop.org writes: --- Comment #2 from Kristian Høgsberg k...@bitplanet.net --- Happy I waited to push this, I came up with a much better fix: commit 360a141f24a9d00891665b7fedb77ffb116944ca Author: Kristian Høgsberg k...@bitplanet.net ... Cc: 9.2

<    1   2   3   4   5   >