Re: [Mesa-dev] [PATCH V2] mesa: Permanently enable features supported by target CPU at compile time.

2014-11-21 Thread Siavash Eliasi
. Would be nice to get your patch in as long as it does not break stuff :) -Emil Hello Emil, David Heidelberg kindly tested the patch on his machines and it was okay. Please consider pushing the patch upstream if it looks good to you guys too. Best regards, Siavash Eliasi. On 11/15/2014 08:58

Re: [Mesa-dev] [PATCH] mesa: Fix _mesa_uint_array_min_max linker error.

2014-11-15 Thread Siavash Eliasi
On 11/15/2014 01:20 AM, Timothy Arceri wrote: On Fri, 2014-11-14 at 22:14 +0330, Siavash Eliasi wrote: You are right. Any suggestions on how to fix this build failure? Using this would fix it but the optimisation would be disabled on clang. Not sure how many people are concerned about

Re: [Mesa-dev] [PATCH 1/2] configure.ac: roll up a program for the sse4.1 check

2014-11-15 Thread Siavash Eliasi
/ And a small improvement to your patch, I think including smmintrin.h or the all-in-one alternative immintrin.h should be enough. Best regards, Siavash Eliasi. On 11/15/2014 08:34 PM, Emil Velikov wrote: So when checking/building sse code we have three possibilities: 1 Old compiler, throws an error

[Mesa-dev] [PATCH] mesa/main: Fix tmp_row memory leak in texstore_rgba_integer.

2014-11-15 Thread Siavash Eliasi
--- src/mesa/main/texstore.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/texstore.c b/src/mesa/main/texstore.c index f913e42..f858cef 100644 --- a/src/mesa/main/texstore.c +++ b/src/mesa/main/texstore.c @@ -1667,8 +1667,10 @@

[Mesa-dev] [PATCH] mesa: Fix _mesa_uint_array_min_max linker error.

2014-11-14 Thread Siavash Eliasi
Fixes build process failure when providing -mno-sse4.1 CFLAGS: vbo_exec_array.c:(.text+0x9bb): undefined reference to `_mesa_uint_array_min_max' Similar bug: https://bugs.freedesktop.org/show_bug.cgi?id=71547 --- src/mesa/vbo/vbo_exec_array.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH V2] mesa: Permanently enable features supported by target CPU at compile time.

2014-11-14 Thread Siavash Eliasi
On 11/10/2014 04:28 AM, Emil Velikov wrote: On 09/11/14 04:37, Siavash Eliasi wrote: On 11/08/2014 09:55 PM, Emil Velikov wrote: [...] Can you confirm that it does not cause issues with interesting setups such as https://bugs.freedesktop.org/show_bug.cgi?id=71547 Challenge accepted! What my

Re: [Mesa-dev] [PATCH] mesa: Fix _mesa_uint_array_min_max linker error.

2014-11-14 Thread Siavash Eliasi
You are right. Any suggestions on how to fix this build failure? On 11/14/2014 10:10 PM, Ilia Mirkin wrote: And disables the optimization unless you're building with a -march that has sse4.1... thus defeating the purpose of doing it this way. On Fri, Nov 14, 2014 at 1:23 PM, Siavash Eliasi

[Mesa-dev] [PATCH V2] mesa: Permanently enable features supported by target CPU at compile time.

2014-11-08 Thread Siavash Eliasi
This will remove the need for unnecessary runtime checks for CPU features if already supported by target CPU, resulting in smaller and less branchy code. V2: - Removed the SSSE3 related part for the not yet merged patch. - Avoiding redefinition of macros. --- src/mesa/x86/common_x86_features.h |

Re: [Mesa-dev] [PATCH 2/3] mesa: helper macros to enable per function optimisations

2014-11-08 Thread Siavash Eliasi
I rather to not use compiler specific hacks in mesa. If it was a personal pet project it would make sense. Best regards, Siavash Eliasi. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] mesa: helper macros to enable per function optimisations

2014-11-08 Thread Siavash Eliasi
I know that's a time saver for developer (gcc function multi versioning), however I still do prefer the approach (my own ^^ ) which works on all setups regardless of hardware and compiler (well, any sane compiler ICC, GCC, Clang,...). Best regards, Siavash Eliasi

Re: [Mesa-dev] [PATCH V2] mesa: Permanently enable features supported by target CPU at compile time.

2014-11-08 Thread Siavash Eliasi
to turn this pieces of code: #ifdef USE_SSE if (cpu_has_sse) { /* SSE code path */ } else #endif { /* C fallback */ } into this: /* SSE code path */ by using compile time information by target CPU. Best regards, Siavash Eliasi. ___ mesa-dev mailing list

[Mesa-dev] Require micro-benchmarks for performance optimization oriented patches

2014-11-07 Thread Siavash Eliasi
. Best regards, Siavash Eliasi. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH V5] mesa: add SSE optimisation for glDrawElements

2014-11-07 Thread Siavash Eliasi
On 11/07/2014 03:14 PM, Steven Newbury wrote: On Thu, 2014-11-06 at 21:00 -0800, Matt Turner wrote: On Thu, Nov 6, 2014 at 8:56 PM, Siavash Eliasi siavashser...@gmail.com wrote: Then I do recommend removing the if (cpu_has_sse4_1) from this patch and similar places, because

Re: [Mesa-dev] [PATCH V5] mesa: add SSE optimisation for glDrawElements

2014-11-07 Thread Siavash Eliasi
to these patches: [Mesa-dev] [PATCH 2/2] i965: add runtime check for SSSE3 rgba8_copy http://lists.freedesktop.org/archives/mesa-dev/2014-November/070256.html Best regards, Siavash Eliasi. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH V5] mesa: add SSE optimisation for glDrawElements

2014-11-07 Thread Siavash Eliasi
On 11/07/2014 07:31 PM, Ian Romanick wrote: On 11/07/2014 06:09 AM, Siavash Eliasi wrote: On 11/07/2014 03:14 PM, Steven Newbury wrote: On Thu, 2014-11-06 at 21:00 -0800, Matt Turner wrote: On Thu, Nov 6, 2014 at 8:56 PM, Siavash Eliasi siavashser...@gmail.com wrote: Then I do recommend

Re: [Mesa-dev] Require micro-benchmarks for performance optimization oriented patches

2014-11-07 Thread Siavash Eliasi
Sounds okay to me, thanks! Best regards, Siavash Eliasi. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Require micro-benchmarks for performance optimization oriented patches

2014-11-07 Thread Siavash Eliasi
On 11/07/2014 10:56 PM, Matt Turner wrote: On Fri, Nov 7, 2014 at 12:31 AM, Siavash Eliasi siavashser...@gmail.com wrote: Being more strict about pushing and quality assurance of these kind of patches will save hours of bisecting and hair-pulling to find the root cause of performance degrades

[Mesa-dev] [PATCH] mesa: Permanently enable features supported by target CPU at compile time.

2014-11-07 Thread Siavash Eliasi
This will remove the need for unnecessary runtime checks for CPU features if already supported by target CPU, resulting in smaller and less branchy code. --- src/mesa/x86/common_x86_features.h | 25 + 1 file changed, 25 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] mesa: Permanently enable features supported by target CPU at compile time.

2014-11-07 Thread Siavash Eliasi
On 11/08/2014 10:30 AM, Matt Turner wrote: On Fri, Nov 7, 2014 at 10:43 PM, Siavash Eliasi siavashser...@gmail.com wrote: This will remove the need for unnecessary runtime checks for CPU features if already supported by target CPU, resulting in smaller and less branchy code. --- src/mesa/x86

Re: [Mesa-dev] [PATCH V5] mesa: add SSE optimisation for glDrawElements

2014-11-06 Thread Siavash Eliasi
is a compile time check and requires the target machine to be SSE 4.1 capable already. Best regards, Siavash Eliasi. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3][RFC v2] mesa/main/x86: Add sse2 streaming clamping

2014-11-04 Thread Siavash Eliasi
as a bonus), because nothing compute intensive is happening there. You can also use prefetching (_mm_prefetch) there to improve performance by reading data ahead from memory. Best regards, Siavash Eliasi. ___ mesa-dev mailing list mesa-dev

[Mesa-dev] [PATCH 3/3] glx/apple: Fixed glx context memory leak in case of failure.

2014-02-10 Thread Siavash Eliasi
--- src/glx/apple/apple_glx_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glx/apple/apple_glx_context.c b/src/glx/apple/apple_glx_context.c index 0bb25b4..8a6ded2 100644 --- a/src/glx/apple/apple_glx_context.c +++ b/src/glx/apple/apple_glx_context.c @@ -142,6 +142,7 @@

[Mesa-dev] [PATCH 2/3] gbm/dri: Fixed buffer object memory leak in case of failure.

2014-02-10 Thread Siavash Eliasi
--- src/gbm/backends/dri/gbm_dri.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index e013980..db4e074 100644 --- a/src/gbm/backends/dri/gbm_dri.c +++ b/src/gbm/backends/dri/gbm_dri.c @@ -609,7 +609,7

[Mesa-dev] [PATCH 1/3] r300g/tests: Added missing fclose for FILE resource.

2014-02-10 Thread Siavash Eliasi
--- src/gallium/drivers/r300/compiler/tests/rc_test_helpers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/r300/compiler/tests/rc_test_helpers.c b/src/gallium/drivers/r300/compiler/tests/rc_test_helpers.c index b4e30d8..239a762 100644 ---

Re: [Mesa-dev] [PATCH] Bad free in _mesa_delete_buffer_object

2014-01-31 Thread Siavash Eliasi
didn't noticed any crashes. However other platforms do require special treatment ( eg _aligned_malloc and _aligned_free on MS Windows), so _mesa_align_free should have been called to handle those cases. Best regards, Siavash Eliasi. On 01/31/2014 02:38 PM, Colin Harrison wrote: Hi, I can

Re: [Mesa-dev] [PATCH] Bad free in _mesa_delete_buffer_object

2014-01-31 Thread Siavash Eliasi
Hello, on which OS is this happening? On 01/31/2014 02:38 PM, Colin Harrison wrote: Hi, I can get a crash without this change (now _mesa_align_malloc is being used for buffer object data) --- ./src/mesa/main/save_bufferobj.c2014-01-29 17:23:22.387706584 + +++

[Mesa-dev] [PATCH] mesa: Removed unnecessary check for NULL pointer when freeing memory block using _mesa_align_free.

2014-01-30 Thread Siavash Eliasi
Note that it is OK to pass NULL pointers to this function since this commit: mesa: modified _mesa_align_free() to accept NULL pointer http://cgit.freedesktop.org/mesa/mesa/commit/?id=f0cc59d68a9f5231e8e2111393a1834858820735 --- src/mesa/main/bufferobj.c | 3 +-- 1 file changed, 1 insertion(+), 2

[Mesa-dev] [PATCH] r600g: Removed unnecessary positivity check for unsigned int variable.

2013-12-12 Thread Siavash Eliasi
--- src/gallium/drivers/r600/r600_asm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/drivers/r600/r600_asm.c index 86f79e2..c5922a8 100644 --- a/src/gallium/drivers/r600/r600_asm.c +++ b/src/gallium/drivers/r600/r600_asm.c

[Mesa-dev] [PATCH V2] Modified _mesa_align_free to have consistent behavior when dealing with NULL memory address.

2013-12-03 Thread Siavash Eliasi
Revision 2: - Avoiding compile error on MSVC and possible warnings on other compilers. - Added comment regards passing NULL pointer being safe. --- src/mesa/main/imports.c| 14 +- src/mesa/math/m_matrix.c | 13 +

Re: [Mesa-dev] [PATCH] Modified _mesa_align_free to have consistent behavior when dealing with NULL memory address.

2013-12-03 Thread Siavash Eliasi
On 12/03/2013 09:48 PM, Brian Paul wrote: On 11/26/2013 10:59 PM, Siavash Eliasi wrote: --- src/mesa/main/imports.c| 7 +-- src/mesa/math/m_matrix.c | 13 + src/mesa/program/prog_parameter.c | 3 +-- src/mesa/state_tracker

[Mesa-dev] [PATCH 05/17] i915g: Modified i915_buffer_create to use memory allocation alignment of 64 instead of 16.

2013-12-02 Thread Siavash Eliasi
--- src/gallium/drivers/i915/i915_resource_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/i915/i915_resource_buffer.c b/src/gallium/drivers/i915/i915_resource_buffer.c index 80ec43a..fd29524 100644 ---

[Mesa-dev] [PATCH 06/17] i915g: Modified i915g to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-12-02 Thread Siavash Eliasi
Revision 2: - Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly. --- src/gallium/drivers/i915/i915_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c index

Re: [Mesa-dev] [PATCH V2 05/17] i915: Modified i915_buffer_create to use memory allocation alignment of 64 instead of 16.

2013-12-02 Thread Siavash Eliasi
Thank you for reviewing these patches, changes to commit messages are done: http://lists.freedesktop.org/archives/mesa-dev/2013-December/049581.html http://lists.freedesktop.org/archives/mesa-dev/2013-December/049582.html Best regards, Siavash Eliasi. On 12/03/2013 06:36 AM, Stéphane

Re: [Mesa-dev] [PATCH V2 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-12-02 Thread Siavash Eliasi
Hi again, it's about one week these patches are receiving feedback and they (v2) look fine to reviewers. May I send a v3 for final review? Best regards, Siavash Eliasi. On 11/28/2013 12:26 PM, Siavash Eliasi wrote: Hello, this is V2 series of patches to accomplish *Enable

[Mesa-dev] [PATCH V2 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-28 Thread Siavash Eliasi
Hello, this is V2 series of patches to accomplish *Enable ARB_map_buffer_alignment in all drivers* newbie project suggested by Ian Romanick. Revision 2: - Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly. - Fixed memory leak. Best regards, Siavash Eliasi

[Mesa-dev] [PATCH V2 02/17] softpipe: Modified softpipe to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-28 Thread Siavash Eliasi
Revision 2: - Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly. --- src/gallium/drivers/softpipe/sp_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c

[Mesa-dev] [PATCH V2 01/17] softpipe: Modified allocation routine to use alignment of 64 instead of 16.

2013-11-28 Thread Siavash Eliasi
--- src/gallium/drivers/softpipe/sp_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_texture.c b/src/gallium/drivers/softpipe/sp_texture.c index 370f2b4..fb20748 100644 --- a/src/gallium/drivers/softpipe/sp_texture.c +++

[Mesa-dev] [PATCH V2 10/17] mesa: Modified _mesa_init_constants to set ctx-Const.MinMapBufferAlignment to 64.

2013-11-28 Thread Siavash Eliasi
--- src/mesa/main/context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 87a4a35..9c516a2 100644 --- a/src/mesa/main/context.c +++ b/src/mesa/main/context.c @@ -586,6 +586,7 @@ _mesa_init_constants(struct gl_context *ctx)

[Mesa-dev] [PATCH V2 04/17] llvmpipe: Modified llvmpipe to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-28 Thread Siavash Eliasi
Revision 2: - Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly. --- src/gallium/drivers/llvmpipe/lp_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH V2 05/17] i915: Modified i915_buffer_create to use memory allocation alignment of 64 instead of 16.

2013-11-28 Thread Siavash Eliasi
--- src/gallium/drivers/i915/i915_resource_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/i915/i915_resource_buffer.c b/src/gallium/drivers/i915/i915_resource_buffer.c index 80ec43a..fd29524 100644 ---

[Mesa-dev] [PATCH V2 07/17] svga: Modified svga to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-28 Thread Siavash Eliasi
Revision 2: - Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly. --- src/gallium/drivers/svga/svga_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index

[Mesa-dev] [PATCH V2 12/17] radeon: Modified radeonBufferData to pass ctx-Const.MinMapBufferAlignment as the alignment value to radeon_bo_open.

2013-11-28 Thread Siavash Eliasi
--- src/mesa/drivers/dri/radeon/radeon_buffer_objects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_buffer_objects.c b/src/mesa/drivers/dri/radeon/radeon_buffer_objects.c index 40a16c3..ba7ab37 100644 ---

[Mesa-dev] [PATCH V2 15/17] i965: Modified brw_initialize_context_constants to set ctx-Const.MinMapBufferAlignment to 4096.

2013-11-28 Thread Siavash Eliasi
--- src/mesa/drivers/dri/i965/brw_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 6e09077..679ec0e 100644 --- a/src/mesa/drivers/dri/i965/brw_context.c +++

[Mesa-dev] [PATCH V2 09/17] mesa: Modified Mesa state tracker to unconditionally enable ARB_map_buffer_alignment.

2013-11-28 Thread Siavash Eliasi
--- src/mesa/state_tracker/st_extensions.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index e8d0902..4707447 100644 --- a/src/mesa/state_tracker/st_extensions.c +++

[Mesa-dev] [PATCH V2 06/17] i915: Modified i915g to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-28 Thread Siavash Eliasi
Revision 2: - Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly. --- src/gallium/drivers/i915/i915_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c index

[Mesa-dev] [PATCH V2 03/17] llvmpipe: Modified allocation routines to use alignment of 64 instead of 16.

2013-11-28 Thread Siavash Eliasi
--- src/gallium/drivers/llvmpipe/lp_texture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_texture.c b/src/gallium/drivers/llvmpipe/lp_texture.c index 0088b6a..d1ebeda 100644 --- a/src/gallium/drivers/llvmpipe/lp_texture.c +++

[Mesa-dev] [PATCH V2 11/17] mesa: Modified _mesa_buffer_data to use _mesa_align_malloc.

2013-11-28 Thread Siavash Eliasi
Revision 2: - Fixed memory leak. --- src/mesa/main/bufferobj.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index b27f592..111bea3 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -416,9

[Mesa-dev] [PATCH V2 16/17] mesa: Modified extensions table to use o(dummy_true) instead of o(ARB_map_buffer_alignment).

2013-11-28 Thread Siavash Eliasi
--- src/mesa/main/extensions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 104618c..6f73694 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -107,7 +107,7 @@ static const struct

[Mesa-dev] [PATCH V2 13/17] nouveau: Modified nouveau_bufferobj_data to pass ctx-Const.MinMapBufferAlignment as the alignment value to nouveau_bo_new.

2013-11-28 Thread Siavash Eliasi
--- src/mesa/drivers/dri/nouveau/nouveau_bufferobj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/nouveau/nouveau_bufferobj.c b/src/mesa/drivers/dri/nouveau/nouveau_bufferobj.c index 717c0b8..dc16585 100644 ---

[Mesa-dev] [PATCH V2 17/17] mesa: Deleted gl_extensions::ARB_map_buffer_alignment and all of its use cases.

2013-11-28 Thread Siavash Eliasi
--- src/mesa/main/get.c| 1 - src/mesa/main/get_hash_params.py | 2 +- src/mesa/main/mtypes.h | 1 - src/mesa/state_tracker/st_extensions.c | 2 -- 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c

[Mesa-dev] [PATCH 01/17] softpipe: Modified allocation routine to use alignment of 64 instead of 16.

2013-11-28 Thread Siavash Eliasi
Revision 2: - Changed allocation alignment in softpipe_displaytarget_layout. --- src/gallium/drivers/softpipe/sp_texture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_texture.c b/src/gallium/drivers/softpipe/sp_texture.c index

[Mesa-dev] [PATCH 03/17] llvmpipe: Modified allocation routines to use alignment of 64 instead of 16.

2013-11-28 Thread Siavash Eliasi
Revision 2: - Changed allocation alignment of llvmpipe_displaytarget_layout. --- src/gallium/drivers/llvmpipe/lp_texture.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_texture.c b/src/gallium/drivers/llvmpipe/lp_texture.c index

[Mesa-dev] [PATCH 17/17] mesa: Deleted gl_extensions::ARB_map_buffer_alignment and all of its use cases.

2013-11-28 Thread Siavash Eliasi
Revision 2: - Making GL_ARB_map_buffer_alignment a desktop OpenGL extension only. --- src/mesa/main/get.c| 1 - src/mesa/main/get_hash_params.py | 2 +- src/mesa/main/mtypes.h | 1 - src/mesa/state_tracker/st_extensions.c | 2 -- 4 files changed, 1

Re: [Mesa-dev] [PATCH] Fixed memory leak.

2013-11-27 Thread Siavash Eliasi
::ARB_map_buffer_alignment and all of its use cases. http://lists.freedesktop.org/archives/mesa-dev/2013-November/049047.html Regards, Siavash Eliasi. On 11/26/2013 10:26 PM, Alex Deucher wrote: On Tue, Nov 26, 2013 at 1:22 PM, Siavash Eliasi siavashser...@gmail.com wrote: In general, when you fix problems

[Mesa-dev] [PATCH] Fixed memory leak.

2013-11-26 Thread Siavash Eliasi
--- src/mesa/main/bufferobj.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 5581a5d..e68d96d 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -420,6 +420,8 @@ _mesa_buffer_data( struct gl_context *ctx,

Re: [Mesa-dev] [PATCH 11/17] Modified _mesa_buffer_data to use _mesa_align_malloc.

2013-11-26 Thread Siavash Eliasi
Fixed memory leak, thanks for the heads up! http://lists.freedesktop.org/archives/mesa-dev/2013-November/049178.html Best Regards, Siavash Eliasi. On 11/26/2013 01:14 AM, Aaron Watry wrote: On Sun, Nov 24, 2013 at 11:36 PM, Siavash Eliasi siavashser...@gmail.com wrote: --- src/mesa/main

Re: [Mesa-dev] [PATCH 11/17] Modified _mesa_buffer_data to use _mesa_align_malloc.

2013-11-26 Thread Siavash Eliasi
is NULL, a data store of the specified size is still created, but its contents remain uninitialized and thus undefined. Best regards, Siavash Eliasi. On 11/26/2013 09:34 AM, Siavash Eliasi wrote: Yes I think you are right, I guess *_mesa_align_realloc* is the correct function which should be used

[Mesa-dev] [PATCH] Modified _mesa_align_free to have consistent behavior

2013-11-26 Thread Siavash Eliasi
free(). Best Regards, Siavash Eliasi. Siavash Eliasi (1): Modified _mesa_align_free to have consistent behavior when dealing with NULL memory address. src/mesa/main/imports.c| 7 +-- src/mesa/math/m_matrix.c | 13 + src/mesa/program

[Mesa-dev] [PATCH] Modified _mesa_align_free to have consistent behavior when dealing with NULL memory address.

2013-11-26 Thread Siavash Eliasi
--- src/mesa/main/imports.c| 7 +-- src/mesa/math/m_matrix.c | 13 + src/mesa/program/prog_parameter.c | 3 +-- src/mesa/state_tracker/st_cb_texture.c | 6 ++ src/mesa/swrast/s_texture.c| 7 +++ src/mesa/tnl/t_vertex.c

Re: [Mesa-dev] [PATCH 02/17] Modified softpipe to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-25 Thread Siavash Eliasi
Hello, thanks for reviewing these patches! There is a patch to address these issues: http://lists.freedesktop.org/archives/mesa-dev/2013-November/049057.html Best Regards, Siavash Eliasi. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH 11/17] Modified _mesa_buffer_data to use _mesa_align_malloc.

2013-11-25 Thread Siavash Eliasi
Yes I think you are right, I guess *_mesa_align_realloc* is the correct function which should be used here. What do you think Ian? Best regards, Siavash Eliasi. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org

[Mesa-dev] [PATCH 02/17] Modified softpipe to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index 47ef20e..022b5bf 100644 --- a/src/gallium/drivers/softpipe/sp_screen.c +++

[Mesa-dev] [PATCH 04/17] Modified llvmpipe to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/llvmpipe/lp_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c index f61df98..8be1779 100644 --- a/src/gallium/drivers/llvmpipe/lp_screen.c +++

[Mesa-dev] [PATCH 01/17] Modified allocation routine to use alignment of 64 instead of 16.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/softpipe/sp_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_texture.c b/src/gallium/drivers/softpipe/sp_texture.c index 370f2b4..fb20748 100644 --- a/src/gallium/drivers/softpipe/sp_texture.c +++

[Mesa-dev] [PATCH 03/17] Modified allocation routines to use alignment of 64 instead of 16.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/llvmpipe/lp_texture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_texture.c b/src/gallium/drivers/llvmpipe/lp_texture.c index 0088b6a..d1ebeda 100644 --- a/src/gallium/drivers/llvmpipe/lp_texture.c +++

[Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Siavash Eliasi
Hello, this is a series of patches to accomplish *Enable ARB_map_buffer_alignment in all drivers* newbie project suggested by Ian Romanick. *Note* that I don't have write access, please merge them upstream after review process. Best Regards, Siavash Eliasi. Siavash Eliasi (17): Modified

[Mesa-dev] [PATCH 08/17] Modified ilo to return 4096 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/ilo/ilo_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/ilo/ilo_screen.c b/src/gallium/drivers/ilo/ilo_screen.c index a345b70..466b21c 100644 --- a/src/gallium/drivers/ilo/ilo_screen.c +++

[Mesa-dev] [PATCH 05/17] Modified i915_buffer_create to use memory allocation alignment of 64 instead of 16.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/i915/i915_resource_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/i915/i915_resource_buffer.c b/src/gallium/drivers/i915/i915_resource_buffer.c index 80ec43a..fd29524 100644 ---

[Mesa-dev] [PATCH 07/17] Modified svga to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/svga/svga_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index c16be16..9e67aa0 100644 --- a/src/gallium/drivers/svga/svga_screen.c +++ b/src/gallium/drivers/svga/svga_screen.c

[Mesa-dev] [PATCH 17/17] Deleted gl_extensions::ARB_map_buffer_alignment and all of its use cases.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/main/get.c| 1 - src/mesa/main/get_hash_params.py | 2 +- src/mesa/main/mtypes.h | 1 - src/mesa/state_tracker/st_extensions.c | 2 -- 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c

[Mesa-dev] [PATCH 06/17] Modified i915g to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/i915/i915_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c index 77607d0..3bc6ecf 100644 --- a/src/gallium/drivers/i915/i915_screen.c +++ b/src/gallium/drivers/i915/i915_screen.c

[Mesa-dev] [PATCH 09/17] Modified Mesa state tracker to unconditionally enable ARB_map_buffer_alignment.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/state_tracker/st_extensions.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index e8d0902..4707447 100644 --- a/src/mesa/state_tracker/st_extensions.c +++

[Mesa-dev] [PATCH 12/17] Modified radeonBufferData to pass ctx-Const.MinMapBufferAlignment as the alignment value to radeon_bo_open.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/drivers/dri/radeon/radeon_buffer_objects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_buffer_objects.c b/src/mesa/drivers/dri/radeon/radeon_buffer_objects.c index 40a16c3..ba7ab37 100644 ---

[Mesa-dev] [PATCH 14/17] Modified i915 intel_bufferobj_data to use _mesa_align_malloc instead of malloc.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/drivers/dri/i915/intel_buffer_objects.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i915/intel_buffer_objects.c b/src/mesa/drivers/dri/i915/intel_buffer_objects.c index bc58c70..4fbf954 100644 ---

[Mesa-dev] [PATCH 16/17] Modified extensions table to use o(dummy_true) instead of o(ARB_map_buffer_alignment).

2013-11-24 Thread Siavash Eliasi
--- src/mesa/main/extensions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 104618c..6f73694 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -107,7 +107,7 @@ static const struct

[Mesa-dev] [PATCH 11/17] Modified _mesa_buffer_data to use _mesa_align_malloc.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/main/bufferobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index b27f592..5581a5d 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -416,9 +416,9 @@ _mesa_buffer_data( struct

[Mesa-dev] [PATCH 15/17] Modified brw_initialize_context_constants to set ctx-Const.MinMapBufferAlignment to 4096.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/drivers/dri/i965/brw_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 6e09077..679ec0e 100644 --- a/src/mesa/drivers/dri/i965/brw_context.c +++

[Mesa-dev] [PATCH 13/17] Modified nouveau_bufferobj_data to pass ctx-Const.MinMapBufferAlignment as the alignment value to nouveau_bo_new.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/drivers/dri/nouveau/nouveau_bufferobj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/nouveau/nouveau_bufferobj.c b/src/mesa/drivers/dri/nouveau/nouveau_bufferobj.c index 717c0b8..dc16585 100644 ---

[Mesa-dev] [PATCH] Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly.

2013-11-24 Thread Siavash Eliasi
Thanks to Timothy Arceri for pointing that out! --- src/gallium/drivers/i915/i915_screen.c | 4 ++-- src/gallium/drivers/llvmpipe/lp_screen.c | 4 ++-- src/gallium/drivers/softpipe/sp_screen.c | 1 + src/gallium/drivers/svga/svga_screen.c | 4 ++-- 4 files changed, 7 insertions(+), 6

[Mesa-dev] [PATCH] Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly.

2013-11-24 Thread Siavash Eliasi
Thanks to Timothy Arceri for pointing that out! --- src/gallium/drivers/i915/i915_screen.c | 4 ++-- src/gallium/drivers/llvmpipe/lp_screen.c | 4 ++-- src/gallium/drivers/softpipe/sp_screen.c | 1 + src/gallium/drivers/svga/svga_screen.c | 4 ++-- 4 files changed, 7 insertions(+), 6

Re: [Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Siavash Eliasi
On 11/25/2013 10:50 AM, Chris Forbes wrote: Ah, I see you have a follow-up that fixes this already. Looks good, sorry for the noise. -- Chris I'm pretty new here and I'm not used to mailing lists, sorry if patches aren't showing up in correct place. Should I send all of patches again (and

[Mesa-dev] hw_gl_select branch status

2013-06-03 Thread Siavash Eliasi
Hello dear mesa developers, What is current status of hw_gl_select branch? Is there any reason keeping it back from being merged into the master branch? Best regards, Siavash Eliasi. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] hw_gl_select branch status

2013-06-03 Thread Siavash Eliasi
On 06/03/2013 08:11 PM, Brian Paul wrote: On Mon, Jun 3, 2013 at 7:26 AM, Alex Deucher alexdeuc...@gmail.com mailto:alexdeuc...@gmail.com wrote: On Mon, Jun 3, 2013 at 3:22 AM, Siavash Eliasi siavashser...@gmail.com mailto:siavashser...@gmail.com wrote: Hello dear mesa developers