Re: [Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions

2018-11-08 Thread Emil Velikov
On Fri, 2 Nov 2018 at 16:06, Erik Faye-Lund wrote: > > On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote: > > On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund > > wrote: > > > EXT_shader_implicit_conversions is a useful extension that adds > > > implicit > > > conversions to OpenGL ES 3.1. Since

Re: [Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions

2018-11-06 Thread Emil Velikov
On Fri, 2 Nov 2018 at 16:06, Erik Faye-Lund wrote: > > On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote: > > On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund > > wrote: > > > EXT_shader_implicit_conversions is a useful extension that adds > > > implicit > > > conversions to OpenGL ES 3.1. Since

Re: [Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions

2018-11-02 Thread Erik Faye-Lund
On Fri, 2018-11-02 at 15:40 +, Emil Velikov wrote: > On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund > wrote: > > EXT_shader_implicit_conversions is a useful extension that adds > > implicit > > conversions to OpenGL ES 3.1. Since it's tested excensively in > > dEQP, and > > Mesa already has

Re: [Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions

2018-11-02 Thread Emil Velikov
On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund wrote: > > EXT_shader_implicit_conversions is a useful extension that adds implicit > conversions to OpenGL ES 3.1. Since it's tested excensively in dEQP, and > Mesa already has support for implicit conversions, it seems reasonable to > allow for the

Re: [Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions

2018-10-31 Thread Tapani Pälli
LGTM, series is: Reviewed-by: Tapani Pälli On 10/30/18 7:11 PM, Erik Faye-Lund wrote: EXT_shader_implicit_conversions is a useful extension that adds implicit conversions to OpenGL ES 3.1. Since it's tested excensively in dEQP, and Mesa already has support for implicit conversions, it seems

[Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions

2018-10-30 Thread Erik Faye-Lund
EXT_shader_implicit_conversions is a useful extension that adds implicit conversions to OpenGL ES 3.1. Since it's tested excensively in dEQP, and Mesa already has support for implicit conversions, it seems reasonable to allow for the extension. This ended up mostly as code-cleanups anyway. While