[Mesa-dev] [PATCH 12/13] mesa/main: fix validation of GL_TIMESTAMP

ly valid on desktop GL in the first place. But if this gets added to a future version of ES, this should be a step in the right direction. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/queryobj.c b/src/m

[Mesa-dev] [PATCH 08/13] mesa/main: fix validation of GL_TIME_ELAPSED

by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index 2f178bbf483..e4185073e3b 100644 --- a/src/mesa/main/queryobj.c +++ b/src/mesa/main/queryob

[Mesa-dev] [PATCH 11/13] mesa/main: fix validation of ARB_query_buffer_object

on ES 3 into errors, as required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index d22432930d0..01a5504575d 100644 --- a/src/mesa/main/queryob

[Mesa-dev] [PATCH 09/13] mesa/main: fix validation of transform-feedback queries

TEN into an error on ES 2, as well as usage of GL_PRIMITIVES_GENERATED on ES 3, both as required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c in

[Mesa-dev] [PATCH 13/13] mesa/main: remove overly strict query-validation

The rules encoded in this code also applies to OpenGL ES 3.0 and up, but the per-enum validation has already been taught about these rules. So let's get rid of this duplicate, narrow version of the validation. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 14

[Mesa-dev] [PATCH v2] mesa: expose NV_conditional_render on GLES

The extension spec has been updated to include GLES 2 support, so let's enable it there. Signed-off-by: Erik Faye-Lund --- Here's a V2 of this patch. The only difference is that this also expose the extension on ES2. The piglit patches has also been updated: https://patchwork.freed

Re: [Mesa-dev] [PATCH 00/13] query validation fixes

On Thu, 2018-11-08 at 08:47 +0200, Tapani Pälli wrote: > FYI there's a whole lot of tests that start to fail when this series > running on Intel CI. It includes dEQP but also Piglit tests, can you > do > Intel CI run or do you want me to send you results? If you mean mesa-ci.01.org, then I have

Re: [Mesa-dev] [PATCH 00/13] query validation fixes

On Thu, 2018-11-08 at 10:47 +0200, Tapani Pälli wrote: > On 11/8/18 10:44 AM, Erik Faye-Lund wrote: > > On Thu, 2018-11-08 at 08:47 +0200, Tapani Pälli wrote: > > > FYI there's a whole lot of tests that start to fail when this > > > series > > > runni

Re: [Mesa-dev] [PATCH 00/13] query validation fixes

On Thu, 2018-11-08 at 09:54 +0100, Erik Faye-Lund wrote: > On Thu, 2018-11-08 at 10:47 +0200, Tapani Pälli wrote: > > On 11/8/18 10:44 AM, Erik Faye-Lund wrote: > > > On Thu, 2018-11-08 at 08:47 +0200, Tapani Pälli wrote: > > > > FYI there's a whole lot of

Re: [Mesa-dev] [PATCH 08/13] mesa/main: fix validation of GL_TIME_ELAPSED

On Thu, 2018-11-08 at 11:40 +0200, Tapani Pälli wrote: > > On 11/7/18 5:58 PM, Erik Faye-Lund wrote: > > ctx->Extensions.EXT_timer_query is set based on the driver- > > capabilities, not based on the context type. We need to check > > against > > _mesa_has_EXT_t

Re: [Mesa-dev] [PATCH 00/13] query validation fixes

On Thu, 2018-11-08 at 10:47 +0200, Tapani Pälli wrote: > On 11/8/18 10:44 AM, Erik Faye-Lund wrote: > > On Thu, 2018-11-08 at 08:47 +0200, Tapani Pälli wrote: > > > FYI there's a whole lot of tests that start to fail when this > > > series > > > runni

Re: [Mesa-dev] [PATCH 00/13] query validation fixes

On Thu, 2018-11-08 at 13:43 +0200, Tapani Pälli wrote: > > On 11/8/18 1:02 PM, Tapani Pälli wrote: > > > > On 11/8/18 11:53 AM, Erik Faye-Lund wrote: > > > On Thu, 2018-11-08 at 10:47 +0200, Tapani Pälli wrote: > > > > On 11/8/18 10:44 AM, Erik Faye-Lund wr

[Mesa-dev] [PATCH v2 02/13] mesa/main: correct year for EXT_occlusion_query_boolean

According to the extension spec, this was initially released in 2011, so let's set this to the correct value. The value of 2001 could be a copy-paste mistake, as ARB_occlusion_query which this is based on was released then. Signed-off-by: Erik Faye-Lund --- src/mesa/main/extensions_table.

[Mesa-dev] [PATCH v2 12/13] mesa/main: fix validation of GL_TIMESTAMP

his shouln't have any functional effect, as this entry-point is only valid on desktop GL, or on GLES with EXT_disjoint_timer_query in the first place. But if this gets added to the core of a future version of ES, this should be a step in the right direction. Signed-off-by: Erik Faye-Lund ---

[Mesa-dev] [PATCH v2 01/13] mesa/main: correct requirement for EXT_occlusion_query_boolean

ranteed by either ARB_occlusion_query nor ARB_occlusion_query2. But it should be trivial to implement for any driver supporting ARB_occlusion_query2, as it can simply be implemented as GL_ANY_SAMPLES_PASSED. Signed-off-by: Erik Faye-Lund --- src/mesa/main/extensions_table.h | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH v2 10/13] mesa/main: fix validation of transform-feedback overflow queries

of GL_TRANSFORM_FEEDBACK_STREAM_OVERFLOW and GL_TRANSFORM_FEEDBACK_OVERFLOW into errors on ES 3, as required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c in

[Mesa-dev] [PATCH v2 00/13] query validation fixes

e intel-ci system :) Erik Faye-Lund (13): mesa/main: correct requirement for EXT_occlusion_query_boolean mesa/main: correct year for EXT_occlusion_query_boolean mesa/main: use non-prefixed enums for consistency mesa/main: simplify pipeline-statistics query validation mesa/main: fix val

[Mesa-dev] [PATCH v2 05/13] mesa/main: fix validation of GL_SAMPLES_PASSED

as ARB_occlusion_query isn't available in core contexts. This turns usage of GL_SAMPLES_PASSED into an error on ES 3, as is required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/queryobj.c b/src/m

[Mesa-dev] [PATCH v2 11/13] mesa/main: fix validation of ARB_query_buffer_object

on ES 3 into errors, as required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index 45db43139a4..c86b9ec065b 100644 --- a/src/mesa/main/queryob

[Mesa-dev] [PATCH v2 09/13] mesa/main: fix validation of transform-feedback queries

rns usage of GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN into an error on ES 2, as well as usage of GL_PRIMITIVES_GENERATED on ES 3, both as required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/m

[Mesa-dev] [PATCH v2 13/13] mesa/main: remove overly strict query-validation

The rules encoded in this code also applies to OpenGL ES 3.0 and up, but the per-enum validation has already been taught about these rules. So let's get rid of this duplicate, narrow version of the validation. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 14

[Mesa-dev] [PATCH v2 04/13] mesa/main: simplify pipeline-statistics query validation

The _mesa_has_ARB_pipeline_statistics_query(ctx)-helper will already check the GLES-version according to the extension-table, so if this extension would ever be back-ported to ES, we only need to update the table to support this. This shouln't have any functional effect. Signed-off-by: Erik

[Mesa-dev] [PATCH v2 06/13] mesa/main: fix validation of GL_ANY_SAMPLES_PASSED

his behavior. This shouldn't cause any functional change, as all drivers that support ARB_occlusion_query2 should in practice enable either ARB_occlusion_query2 or EXT_occlusion_query_boolean under all APIs that export this symbol. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c |

[Mesa-dev] [PATCH v2 03/13] mesa/main: use non-prefixed enums for consistency

These enums all have the same values as their non-prefixed versions, and there's several aliases for some of them. So let's switch to the non-prefixed versions for simplicity. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 66 --

[Mesa-dev] [PATCH v2 08/13] mesa/main: fix validation of GL_TIME_ELAPSED

ame functionality for ES. This turns usage of GL_TIME_ELAPSED into an error on ES 3, as is required by the spec. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c in

[Mesa-dev] [PATCH v2 07/13] mesa/main: fix validation of GL_ANY_SAMPLES_PASSED_CONSERVATIVE

his behavior. This shouldn't cause any functional change, as all drivers that support ES3_compatibility should in practice enable either ES3_compatibility or EXT_occlusion_query_boolean under all APIs that export this symbol. Signed-off-by: Erik Faye-Lund --- src/mesa/main/queryobj.c | 4

[Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

It seems I missed some details when exposing NV_conditional_render on GLES; this fixes up "make check". Fixes: 5213be9fab7 ("mesa: expose NV_conditional_render on GLES") Signed-off-by: Erik Faye-Lund --- Caught by the Intel CI system. Sorry about this! src/m

Re: [Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

t's possible. I don't really know what makes this appear in the ABI, though. If someone can explain, I'd be happy to fix things up. Anyway, I pushed the test-fixes for now; the ABI change seems to already have happened. > On Fri, Nov 9, 2018 at 10:20 AM Erik Faye-Lund &g

Re: [Mesa-dev] [PATCH] mesa/main: fixup make check after NV_conditional_render for gles

On Fri, 2018-11-09 at 11:17 -0500, Ilia Mirkin wrote: > On Fri, Nov 9, 2018 at 10:51 AM Erik Faye-Lund > wrote: > > On Fri, 2018-11-09 at 10:44 -0500, Ilia Mirkin wrote: > > > Errr ... why are these being added to the ABI now? Extensions are > > > generally not added

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker wrote: > Which has the same behavior. Does it? I'm not so sure... IROUND_POS seems to round to nearest integer depending on the FPU rounding mode, _mesa_roundevenf rounds to the nearest *even* value regardless of the FPU rounding mode, no? I'm not su

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote: > Quoting Erik Faye-Lund (2018-11-12 04:51:47) > > On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker wrote: > > > Which has the same behavior. > > > > Does it? I'm not so sure... IROUND_POS seems to round to n

Re: [Mesa-dev] [PATCH v3] virgl: Add command and flags to initiate debugging on the host (v2)

> v3: Only request host logging if the host actually understands the > command > > Signed-off-by: Gert Wollny Looks good to me! Reviewed-by: Erik Faye-Lund > --- > The corresponding virglrenderer patches can be found in this MR: > https://gitlab.freedesktop.org/virgl/vi

Re: [Mesa-dev] [PATCH 11/22] nir: simplify get_io_offset() parameters

Herbst Reviewed-by: Erik Faye-Lund > --- > src/compiler/nir/nir_lower_io.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/src/compiler/nir/nir_lower_io.c > b/src/compiler/nir/nir_lower_io.c > index b3595bb19d5..2a6c284de2b 100644 >

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

On Tue, 2018-11-13 at 09:00 -0800, Dylan Baker wrote: > Quoting Erik Faye-Lund (2018-11-13 01:34:53) > > On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote: > > > Quoting Erik Faye-Lund (2018-11-12 04:51:47) > > > > On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker

Re: [Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

On Tue, 2018-11-13 at 22:13 +, Roland Scheidegger wrote: > Am 13.11.18 um 18:00 schrieb Dylan Baker: > > Quoting Erik Faye-Lund (2018-11-13 01:34:53) > > > On Mon, 2018-11-12 at 09:22 -0800, Dylan Baker wrote: > > > > Quoting Erik Faye-Lund (2018-11-12 04:51:47) &

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

On Tue, 2018-11-13 at 19:07 -0500, Ilia Mirkin wrote: > On Tue, Nov 13, 2018 at 6:50 PM Rob Clark > wrote: > > On Tue, Nov 13, 2018 at 6:19 PM Eric Anholt > > wrote: > > > Rob Clark writes: > > > > > > > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt > > > > wrote: > > > > > Rob Clark writes: >

Re: [Mesa-dev] [PATCH] mesa/st: swap order of clear() and clear_with_quad()

On Tue, 2018-11-13 at 21:53 -0500, Marek Olšák wrote: > > > On Tue, Nov 13, 2018, 6:00 PM Rob Clark > On Tue, Nov 13, 2018 at 5:25 PM Eric Anholt > > wrote: > > > > > > Rob Clark writes: > > > > > > > If we can't clear all the buffers with pctx->clear() (say, for > > example, > > > > because o

[Mesa-dev] [PATCH 2/3] mesa: verify MaxVertexAttribStride for GL 4.4

The OpenGL 4.4 specification, table Table 23.55 ("Implementation Dependent Values"), defines the minimum-maximum value for MAX_VERTEX_ATTRIB_STRIDE to be 2048. So we shouldn't enable OpenGL 4.4 on implementations where this isn't the case. Let's add a check for this.

[Mesa-dev] [PATCH 3/3] mesa: verify MaxVertexAttribStride for GLES 3.1

The OpenGL 3.1 specification, table Table 20.41 ("Implementation Dependent Values"), defines the minimum-maximum value for MAX_VERTEX_ATTRIB_STRIDE to be 2048. So we shouldn't enable OpenGL ES 3.1 on implementations where this isn't the case. Let's add a check for this

[Mesa-dev] [PATCH 1/3] r600: report incorrect max-vertex-attrib for GL 4.4

2048. Any applications using 2048 are already broken anyway. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/r600/r600_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index bc5660d6d1..2518032

[Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

avoid exposing a too high spec version in virgl and then get dEQP failures when running on old hardware. The virgl specific bits are being sent separately, because they depend on some other not-yet-upstream things ATM. Thoughts? Erik Faye-Lund (3): r600: report incorrect max-vertex-attrib

Re: [Mesa-dev] [PATCH 0/3] verify max vertex attrib stride

On 06. juli 2018 18:43, Roland Scheidegger wrote: Am 06.07.2018 um 12:03 schrieb Erik Faye-Lund: OpenGL 4.4 and OpenGL ES 3.1 both require the maximum vertex attrib stride to be at least 2048. If this isn't the case, we shouldn't expose these API versions. Unfortunately, the r600 d

Re: [Mesa-dev] [PATCH V2] Check if the window is non-NULL before setting swap interval.

On Thu, Jul 5, 2018 at 7:02 PM Emil Velikov wrote: > > On 5 July 2018 at 17:17, Eric Engestrom wrote: > > On Thursday, 2018-07-05 14:43:02 +0100, Emil Velikov wrote: > >> On 5 July 2018 at 10:53, Eric Engestrom wrote: > >> > On Monday, 2018-07-02 14:12:44 +0530, samiuddi wrote: > >> >> This fixe

Re: [Mesa-dev] [RFC PATCH] mesa/st: don't prematurely optimize for render targets when on virgl

On 10. juli 2018 15:42, Gert Wollny wrote: For three component textures virgl faces the problem that the host driver may report that these can not be used as a render target, and when the client requests such a texture a four-componet texture will be choosen even if only a sampler view was reques

Re: [Mesa-dev] [RFC PATCH] mesa/st: don't prematurely optimize for render targets when on virgl

On 10. juli 2018 16:23, Gert Wollny wrote: Am Dienstag, den 10.07.2018, 16:01 +0200 schrieb Erik Faye-Lund: On 10. juli 2018 15:42, Gert Wollny wrote: For three component textures virgl faces the problem that the host driver may report that these can not be used as a render target, and when

Re: [Mesa-dev] [PATCH v2 25/49] docs/meson.html: fix numerous issues spotted by xmllint

On 11. juli 2018 01:17, Dylan Baker wrote: --- docs/meson.html | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) This is a HTML-document, not an XML document or XHTML. What xmllint thinks should be irrelevant. diff --git a/docs/meson.html b/docs/meson.html index b64ca2ec35e..d4b

Re: [Mesa-dev] [PATCH v2 41/49] meosn: don't build gallium trivial tests on windows

Typo in the subject, "meosn" -> "meson". On 11. juli 2018 01:18, Dylan Baker wrote: They require the pipe-loaders, which require xmlconfig, which doesn't build with msvc. --- src/gallium/tests/meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/tes

Re: [Mesa-dev] How to apply patches to upstream mesa 9.0.3

On 11. juli 2018 10:22, Thella Shyam Kumar wrote: Hi All, We are using an x86 based platform and we are needing changes in mesa 9.0.3 which is coming with AOSP 7.1.2r36 If we want the changes in mesa in AOSP, our understanding is that these changes should be upstreamed in freedesktop.org

Re: [Mesa-dev] [PATCH] mesa/virgl: Fix off-by-one and copy-paste error in multisample position evaluation

ng an off-by-one... perhaps adjust the commit message a bit? bits = vs->caps.caps.v2.msaa_sample_positions[4 + (index >> 2)] >> (8 * (index & 3)); } out_value[0] = ((bits >> 4) & 0xf) / 16.0f; Reviewed-by: Erik Faye-Lund _

[Mesa-dev] [PATCH 0/3] virgl: synchronize virgl_hw.h with virglrenderer

w cap that currently exists in master (VIRGL_CAP_SET_MIN_SAMPLES), for two reasons: reasons: 1. It wasn't yet in master when I generated this patch-set 2. I'm about to send out a patch-set that adds it (and respects it) separately. Erik Faye-Lund (3): virgl: move bind-flags to vi

[Mesa-dev] [PATCH 3/3] virgl: update virgl_hw.h from virglrenderer

This just makes sure we're currently up-to-date with what virglrenderer has. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_hw.h | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_hw.h b/src/gallium/dr

[Mesa-dev] [PATCH 1/3] virgl: move bind-flags to virgl_winsys.h

virglrenderer's virgl_hw.h doesn't contain these, and it's the virgl winsys that cares about these, so let's move them there. This reduces the diff between the two different versions of virgl_hw.h, and should make it easier to upgrade the file in the future. Signed-of

[Mesa-dev] [PATCH 2/3] virgl: rename msaa_sample_positions -> sample_locations

This matches what this field is called in virglrenderer's copy of this. While we're at it, fixup the indentation. This reduces the diff between the two different versions of virgl_hw.h, and should make it easier to upgrade the file in the future. Signed-off-by: Erik Faye-Lund --- s

Re: [Mesa-dev] [PATCH] mesa/virgl: Fix off-by-one and copy-paste error in multisample position evaluation

Just a heads-up, this patch conflicts with this one: https://patchwork.freedesktop.org/patch/239169/ Your were sent out first, so I'll be happy to rebase mine when this has landed... On 13. juli 2018 14:46, Gert Wollny wrote: Fixes: 91f48cdfe5c817158c533a8f67c60e9aabbe4479 virgl: Add

[Mesa-dev] [PATCH] virgl: implement set_min_samples

This allows us to implement glMinSampleShading correctly, which up until now just got ignored. Signed-off-by: Erik Faye-Lund --- This implements the mesa-side of VIRGL_CCMD_SET_MIN_SAMPLES, which is already in the master-branch of virglre... src/gallium/drivers/virgl/virgl_context.c | 12

Re: [Mesa-dev] [PATCH 1/3] virgl: move bind-flags to virgl_winsys.h

On 16. juli 2018 13:34, Gert Wollny wrote: Am Montag, den 16.07.2018, 12:23 +0200 schrieb Erik Faye-Lund: virglrenderer's virgl_hw.h doesn't contain these, and it's the virgl winsys that cares about these, so let's move them there. This reduces the diff between the two d

[Mesa-dev] [PATCH] virgl: remove unused stride-arguments

The IOCTLs doesn't pass this along, so computing them in the first place is kinda pointless. Signed-off-by: Erik Faye-Lund --- This is just a cleanup I noticed based on some discussion with Gert. A question is, what code here expects this stride to be respected? The call-sites in v

[Mesa-dev] [PATCH] gles: report maximum vertex-attrib stride to guest

Similar to e387116, we also need to report this for GLES hosts. Signed-off-by: Erik Faye-Lund --- Without this, there's no chance for GLES hosts to get GLES3.1 support. src/vrend_renderer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vrend_renderer.c b/src/vrend_rende

Re: [Mesa-dev] [PATCH] gles: report maximum vertex-attrib stride to guest

Sorry, send wrong. Please ignore. On 19. juli 2018 17:58, Erik Faye-Lund wrote: Similar to e387116, we also need to report this for GLES hosts. Signed-off-by: Erik Faye-Lund --- Without this, there's no chance for GLES hosts to get GLES3.1 support. src/vrend_renderer.c | 3 +++ 1

[Mesa-dev] [PATCH] forward precise-flag if supported

EQP-GLES31.functional.tessellation.common_edge.triangles_fractional_odd_spacing_precise Signed-off-by: Erik Faye-Lund --- This matches this virglrenderer-series, which has been merged upstrea: https://patchwork.freedesktop.org/series/46361/ src/gallium/drivers/virgl/virgl_hw.h | 1 + src/gallium/dri

Re: [Mesa-dev] [PATCH] virgl: remove unused stride-arguments

On Jul 23, 2018 22:05, Dave Airlie wrote:On 20 July 2018 at 13:39, Gurchetan Singh wrote: > Reviewed-by: Gurchetan Singh > On Wed, Jul 18, 2018 at 4:06 AM Erik Faye-Lund > wrote: >> >> The IOCTLs doesn't pass this along, so computing them in the first &

[Mesa-dev] [PATCH] gallium: initialize ureg_dst::Invariant bit

When this bit was added, it seems the some initialization code was omitted by mistake. Since stack-variables have kinda random contents, and we don't zero initialize the whole struct in these code-paths, we end up getting random-ish values for this bit. Spotted by Coverity in the following CIDs:

[Mesa-dev] [PATCH v2 1/2] virgl: rename msaa_sample_positions -> sample_locations

This matches what this field is called in virglrenderer's copy of this. While we're at it, fixup the indentation. This reduces the diff between the two different versions of virgl_hw.h, and should make it easier to upgrade the file in the future. --- src/gallium/drivers/virgl/virgl_context.c | 8

[Mesa-dev] [PATCH v2 0/2] virgl: synchronize virgl_hw.h with virglrenderer

ed on master - Dropped "virgl: move bind-flags to virgl_winsys.h" as discussed in review. - Updated "virgl: update virgl_hw.h from virglrenderer" to the latest master from virglrenderer. Erik Faye-Lund (2): virgl: rename msaa_sample_positions -> sample_locations v

[Mesa-dev] [PATCH v2 2/2] virgl: update virgl_hw.h from virglrenderer

This just makes sure we're currently up-to-date with what virglrenderer has. --- src/gallium/drivers/virgl/virgl_hw.h | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_hw.h b/src/gallium/drivers/virgl/virgl_hw.h index 0

Re: [Mesa-dev] [PATCH] meson: use correct keyword to fix a meson warning

On 02. aug. 2018 15:58, Jon Turney wrote: With a sufficently recent meson, the following warning is produced: WARNING: Passed invalid keyword argument "extra_args". WARNING: This will become a hard error in the future. It seems that compiler.links(args:) is meant here. Signed-off-by: Jon Turne

[Mesa-dev] [PATCH] i965: do not emit empty sampler state

If called with an empty size, brw_emit_buffer_surface_state asserts. And since doing a zero-size upload is really just a lot of work for no gain, let's just avoid the call in the first place. Signed-off-by: Erik Faye-Lund --- This fixes an assert that triggers for me when running dEQP-G

[Mesa-dev] [PATCH] glsl_to_tgsi: plumb image writable through to driver

. Signed-off-by: Erik Faye-Lund --- This patch is needed for this patch-series in virglrenderer to work properly: https://patchwork.freedesktop.org/series/47775/ src/mesa/state_tracker/st_glsl_to_tgsi.cpp| 19 ++- .../state_tracker/st_glsl_to_tgsi_private.h | 1 + 2 files

Re: [Mesa-dev] [PATCH v2 0/2] virgl: synchronize virgl_hw.h with virglrenderer

Ping? On 27. juli 2018 09:18, Erik Faye-Lund wrote: Here's a few patches to get the delta between our copy of virgl_hw.h and the copy in the virglrenderer repository as small as possible. The goal is to make it easier to track this file in the future by simply copying the new version o

Re: [Mesa-dev] [PATCH] virgl: add ARB_shader_clock support

Reviewed-by: Erik Faye-Lund On 06. aug. 2018 22:23, Dave Airlie wrote: From: Dave Airlie --- src/gallium/drivers/virgl/virgl_hw.h | 1 + src/gallium/drivers/virgl/virgl_screen.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl

Re: [Mesa-dev] [PATCH] i965: do not emit empty sampler state

On 06. aug. 2018 16:15, Lionel Landwerlin wrote: Hey Erik, I don't think this is right, because by not filling out_offset, you're leaving it at 0 which makes the entry in the binding table point to a dynamic state base address. I would emit the null surface instead. Hmm, good point. I'll r

[Mesa-dev] [PATCH v2] i965: do not emit empty surface state

If called with an empty size, brw_emit_buffer_surface_state asserts. We already have a dedicated helper for uploading nothing, so let's use that instead. Signed-off-by: Erik Faye-Lund --- Here's an updated patch. v2: call emit_null_surface_state to ensure out_offset is initialized

[Mesa-dev] [PATCH] mesa/st/glsl_to_tgsi: fixup copy-paste mistake

lit arrays whose elements are only accessed directly") Signed-off-by: Erik Faye-Lund --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp i

Re: [Mesa-dev] [PATCH] virgl: bump 3D texture limit to 2048, as GL4.1 requires

On Tue, Aug 14, 2018 at 5:47 AM, Gurchetan Singh wrote: This is virgl analogue to cf6dad. Fixes: dEQP-GLES31.functional.image_load_store.3d.atomic.* Example test cases: dEQP-GLES31.functional.image_load_store.3d.atomic.add_r32ui_return_value dEQP-GLES31.functional.image_load_store.3

[Mesa-dev] [PATCH 2/2] virgl: report actual max-texture sizes

Instead of doing conservative guesses, we should report the max levels based on the max sizes we get from GL on the host. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_hw.h | 3 +++ src/gallium/drivers/virgl/virgl_screen.c | 7 +++ 2 files changed, 10 insertions

[Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

tracts computes max-size by doing by 2^(n-1), which means this should be 256 cubed, not 512 cubed. The other comments are correct. Signed-off-by: Erik Faye-Lund --- src/gallium/drivers/virgl/virgl_screen.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/galliu

Re: [Mesa-dev] [PATCH 2/2] virgl: report actual max-texture sizes

I forgot to mention, this patch depends on a virglrenderer MR that hasn't been merged yet. So it shouldn't be merged before the MR has landed. https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/25 On Tue, Aug 14, 2018 at 3:02 PM, Erik Faye-Lund wrote: Instea

Re: [Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

What are you referring to, exactly? In OpenGL, texture size-limits are per axis, not in total... On Tue, Aug 14, 2018 at 5:43 PM, Marek Olšák wrote: You could have a 3d or cube texture where 1 or 2 dimensions are 16k. Marek On Tue, Aug 14, 2018, 9:02 AM Erik Faye-Lund wrote: These macro

Re: [Mesa-dev] [PATCH 1/2] virgl: do not use SP_MAX_TEXTURE_*_LEVELS defines

ue, Aug 14, 2018, 11:57 AM Erik Faye-Lund wrote: What are you referring to, exactly? In OpenGL, texture size-limits are per axis, not in total... On Tue, Aug 14, 2018 at 5:43 PM, Marek Olšák wrote: You could have a 3d or cube texture where 1 or 2 dimensions are 16k. Marek On Tue, Aug 14,

Re: [Mesa-dev] [PATCH v2] i965: do not emit empty surface state

12:11 AM, Lionel Landwerlin wrote: Hey Erik, Out of curiosity, what app/test managed to run into this assert? We could have some test added :) Thanks, - Lionel On 08/08/18 09:34, Lionel Landwerlin wrote: On 07/08/18 20:31, Erik Faye-Lund wrote: If called with an empty size, brw_emit_buffer_surface_s

[Mesa-dev] docs: consistent language

TLDR; I'm proposing to standardize on US English in our public-facing documentation. I proposed an MR a while back that changed the only occurrence of the UK English spelling "optimisation" for the US English spelling "optimization", which is already used 34 times in the docs. I've done similar ch

Re: [Mesa-dev] docs: consistent language

On Tue, 2021-03-16 at 10:06 +, Daniel Stone wrote: > On Mon, 15 Mar 2021 at 20:54, Jason Ekstrand > wrote: > > Three comments: > > > >  1. +1 > >  2. Khronos has generally standardized on American English in their > > specs so I guess that provides some sort of prior art or something. > >  3.

Re: [Mesa-dev] docs: consistent language

just want to resolve which of the forks in the road we follow trying to clean things up ;) On Mon, 2021-03-15 at 13:44 +0100, Erik Faye-Lund wrote: > TLDR; I'm proposing to standardize on US English in our public-facing > documentation. > > I proposed an MR a while back that

Re: [Mesa-dev] docs: consistent language

On Mon, 2021-03-15 at 10:54 -0700, Ian Romanick wrote: > > If anyone doesn't feel comfortable speaking out publicly about this, > please feel free to contact Erik or me privately. Just thought I'd mention; I've gotten a vote against the proposal through other channels. Because I haven't gotten ex

Re: [Mesa-dev] docs: consistent language

On Mon, 2021-03-15 at 13:44 +0100, Erik Faye-Lund wrote: > TLDR; I'm proposing to standardize on US English in our public-facing > documentation. > > I proposed an MR a while back that changed the only occurrence of the > UK English spelling "optimisation&quo

Re: [Mesa-dev] docs: consistent language

On Fri, 2021-03-26 at 18:22 +0100, Erik Faye-Lund wrote: > On Mon, 2021-03-15 at 13:44 +0100, Erik Faye-Lund wrote: > > TLDR; I'm proposing to standardize on US English in our public- > > facing > > documentation. > > > > I proposed an MR a while back that

Re: Question

pecific itch at the moment. Windows support in Zink is happening slowly, driven by those who need it. -- Erik Faye-Lund Principal Engineer Collabora Ltd. Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, United Kingdom Registered in England & Wales, no. 5513718

Converting mesa/demos to Meson

ld-buildsystems Thoughts? Objections? -- Erik Faye-Lund Principal Engineer Collabora Ltd. Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, United Kingdom Registered in England & Wales, no. 5513718

Re: Converting mesa/demos to Meson

OK, so I think enough time has passed. I have heard a few voices in support, and no voices against, so my plan is to go ahead and merge this early next week (probably Monday), if I don't hear anyone speak up soon. On Wed, 2022-05-04 at 18:38 +0200, Erik Faye-Lund wrote: > Because we'

[ANNOUNCE] mesa-demos 8.5.0

warnings Dave Airlie (1): glad: regenerate glad files from glad upstream Eric Engestrom (1): gitlab-ci: add cmake & autotools builds Erik Faye-Lund (128): wglgears: do not include unistd.h on MSVC wglgears: change window-title wglgears: make usage and error-handling

Re: Converting mesa/demos to Meson

https://gitlab.freedesktop.org/mesa/demos/-/merge_requests/74 If I don't hear any objections in a few weeks, I plan on merging that change. On Fri, 2022-05-13 at 11:14 +0200, Erik Faye-Lund wrote: > OK, so I think enough time has passed. I have heard a few voices in > support, and no voice

Re: Zink MR signoff tags

s and robust discussion with Erik, we've > > decided that > >    zink will no longer require any rb/ab/etb tags to be applied to > > patches in > >    MRs. > >    Following in Turnip's footsteps, any MR that receives sufficient > > reviewage > >    in gi

Re: Beginner to driver dev, looking for advice

Hi, and welcome to the community! In case you're not already familiar, we have #dri-devel on OFTC, as mentioned here: https://docs.mesa3d.org/lists.html#irc This is where most day-to-day communication happens, as well as on our project on gitlab.fdo. There's also some technical docs on docs.mes

[ANNOUNCE] mesa-demos 9.0.0

always not-null. Erik Faye-Lund (97): meson: disable annoying msvc-warnings meson: suppress a few msvc warnings meson: suppress more annoying warnings wglutil.c: clean up size-wrangling glinfo_common.c: add int-casts glinfo_common.c: do not shadow variable i

Re: [ANNOUNCE] mesa-demos 9.0.0

ly releasing .tar.xz files. All of this seems to warrant a new major release, so here we are. There's also a bunch of bugs fixed, many related to the still-quite-new Meson build system. So this seems like a good time to upgrade! On Wed, 2023-03-22 at 16:12 +0100, Erik Faye-Lund wrote: > A

Re: time for amber2 branch?

On Wed, 2024-06-19 at 10:33 -0400, Mike Blumenkrantz wrote: > In looking at the gallium tree, I'm wondering if it isn't time for a > second amber branch to prune some of the drivers that cause pain when > doing big tree updates: > > * nv30 > * r300 > * r600 > * lima > * virgl > * tegra > * ??? >

Re: [Mesa-dev] [PATCH 03/65] glsl: Add initial functions to implement an on-disk cache

On Fri, Apr 29, 2016 at 3:33 PM, Timothy Arceri wrote: > +/* Create a directory named 'path' if it does not already exist. > + * > + * Returns: 0 if path already exists as a directory or if created. > + * -1 in all other cases. > + */ > +static int > +mkdir_if_needed(char *path) > +{ > +

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

On Wed, May 18, 2016 at 10:12 AM, Daniel Stone wrote: > Hi, > > On 18 May 2016 at 00:00, Ian Romanick wrote: >> On 05/17/2016 09:59 AM, Ben Widawsky wrote: >>> I think you misstated this. It's not invalid to have any other value. It's >>> invalid to not have one of the 3 values, which I suppose i

Re: [Mesa-dev] [PATCH] egl: Add OpenGL_ES to API string regardless of GLES version

On Wed, May 18, 2016 at 1:01 PM, Emil Velikov wrote: > On 18 May 2016 at 09:27, Erik Faye-Lund wrote: >> On Wed, May 18, 2016 at 10:12 AM, Daniel Stone wrote: >>> Hi, >>> >>> On 18 May 2016 at 00:00, Ian Romanick wrote: >>>> On 05/17/2016

Re: [Mesa-dev] [PATCH 00/18] [RFC] Pointer specific data structures

On Wed, Apr 11, 2018 at 8:48 PM, Thomas Helland wrote: > This series came about when I saw a talk online, while simultaneously > being annoyd about the needless waste of memory in our set as reported > by pahole. I have previously made some patches that changed our hash > table from a reprobing on

<    2   3   4   5   6   7   8   >