From: Chad Versace chad.vers...@linux.intel.com
When appropriate, replace each check `hiz_mt != NULL` with either a call
to intel_miptree_slice_has_hiz() or intel_renderbuffer_has_hiz(). No
behavioral change.
This prepares for selectively enabling hiz on individual miptree slices
for Haswell.
From: Chad Versace chad.vers...@linux.intel.com
After recent refactorings, the field is written but no longer read.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
src/mesa/drivers/dri/i965/brw_context.h| 1 -
src/mesa/drivers/dri/i965/brw_misc_state.c | 2 --
2 files changed,
From: Chad Versace chad.vers...@linux.intel.com
Enable hiz by setting intel_context::has_hiz. However, to work around
a hardware bug, we selectively enable hiz for only nicely aligned miptree
slices.
No Piglit regressions on Haswell 0x0d26 rev07 when based atop
mesa-master-97e40a5.
Improves
insertions(+), 3 deletions(-)
These seem okay to me. All four are:
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 04/09/2013 03:51 PM, Kenneth Graunke wrote:
From: Chad Versace chad.vers...@linux.intel.com
The hardware docs and the simulator require that the rectangle primitive
emitted during fast depth clears and hiz resolves must be aligned to 8x4
pixels.
Signed-off-by: Chad Versace chad.vers
On 04/09/2013 03:55 PM, Eric Anholt wrote:
Matt Turner matts...@gmail.com writes:
I believe that prog can only be NULL for ARB programs. Neither
brw_fs_fp.cpp nor brw_vec4_vp.cpp call fail(), but not NULL checking
prog is obviously fragile.
(shader != NULL) = (prog != NULL), so if you want
On 04/09/2013 10:49 PM, Chad Versace wrote:
On 04/09/2013 04:15 PM, Eric Anholt wrote:
Kenneth Graunke kenn...@whitecape.org writes:
From: Chad Versace chad.vers...@linux.intel.com
Enable hiz by setting intel_context::has_hiz. However, to work around
a hardware bug, we selectively enable
We need know this in order to decide what tiling mode to use.
Cc: Eric Anholt e...@anholt.net
Cc: Paul Berry stereotype...@gmail.com
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/intel/intel_context.c | 17 +
src/mesa/drivers/dri/intel
conflict resolution.
Cc: Eric Anholt e...@anholt.net
Cc: Paul Berry stereotype...@gmail.com
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/mesa/drivers/dri/intel
On 04/09/2013 03:11 PM, Paul Berry wrote:
This patch just creates the derived class; later patches will migrate
VS-specific functions and data structures from the base class into the
derived class.
Reviewed-by: Jordan Justen jordan.l.jus...@intel.com
Reviewed-by: Eric Anholt e...@anholt.net
---
On 04/09/2013 03:11 PM, Paul Berry wrote:
This patch makes the following vec4_visitor functions virtual, since
they will need to be implemented differently for vertex and geometry
shaders. Some of the functions are renamed to reflect their generic
purpose, rather than their VS-specific
on
git://github.com/stereotype441/mesa.git to point to v2 of the series.
You can ignore my comments on patch 8.
Other than my small comments on patch 9 (which you're free to take or
leave), this series is:
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
It'd also be nice to see
On 04/09/2013 09:01 PM, Paul Berry wrote:
The comment above glsl_type::name claimed that it could sometimes be
NULL. This was wrong--it is never NULL. Many error handling paths
would segfault if it were.
Fix the comment and add assertions to validate that it really is never
NULL.
---
This reduces the nesting level slightly, and in my opinion, makes it a
bit easier to follow.
Cc: Paul Berry stereotype...@gmail.com
Cc: Chad Versace chad.vers...@linux.intel.com
Cc: Eric Anholt e...@anholt.net
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/intel
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 28 --
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/intel/intel_mipmap_tree.c
b/src/mesa/drivers/dri/intel/intel_mipmap_tree.c
index
not to implement the similar GL_INTEL_performance_queries
extension because Intel has not bothered to publish a specification in
the OpenGL registry.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mapi/glapi/gen/Makefile.am | 1 +
src/mapi/glapi/gen/gl_API.xml| 2 +
src/mapi/glapi/gen
Ironlake's counters are always enabled; userspace can simply send a
MI_REPROT_PERF_COUNT packet to take a snapshot of them. This makes it
easy to implement.
The counters are documented in the source code for the intel-gpu-tools
intel_perf_counters utility.
Signed-off-by: Kenneth Graunke kenn
not to implement the similar GL_INTEL_performance_queries
extension because Intel has not bothered to publish a specification in
the OpenGL registry.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mapi/glapi/gen/AMD_performance_monitor.xml | 87
src/mapi/glapi/gen/Makefile.am
On 04/12/2013 10:55 AM, Eric Anholt wrote:
Kenneth Graunke kenn...@whitecape.org writes:
This provides an interface for applications (and OpenGL-based tools) to
access GPU performance counters. Since the exact performance counters
available vary between vendors and hardware generations
;
assert(reg.hstride = 0 reg.hstride Elements(hstride_for_reg));
Both patches are:
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 04/16/2013 09:58 AM, Matt Turner wrote:
On Tue, Apr 16, 2013 at 9:45 AM, Chia-I Wu olva...@gmail.com wrote:
If there is no objection, I'd like to merge it in a day or two.
My only objection is over adding a driver that is explicitly a toy,
the confusion it will cause users, and the
;
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 04/16/2013 10:35 AM, Michael Karcher wrote:
Am Dienstag, den 16.04.2013, 10:23 -0700 schrieb Matt Turner:
waste. It wasn't uncommon for a user to waste a nontrivial amount of
someone's time in #intel-gfx only to discover that they were trying to
use the (old) i965g driver that no one
+ sizeof(ralloc_header));
+ if (unlikely(block == NULL))
+ return NULL;
ralloc_header *info = (ralloc_header *) block;
ralloc_header *parent = ctx != NULL ? get_header(ctx) : NULL;
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa
On 04/17/2013 01:59 PM, Dave Airlie wrote:
Hi,
I put a 3Ghz Core2 Q35 box i found in the office to good use (so much
nicer than a pineview atom).
http://people.freedesktop.org/~airlied/piglit/i915c/
is a full run with i915c forced to advertise GL2.0 using the stub
occlusion query hack in
(+), 18 deletions(-)
Patch 1 is:
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
I haven't had a chance to look at patch 2 yet.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 04/16/2013 05:21 PM, Eric Anholt wrote:
The next commit introduces what is apparently our first one, which tripped
over this in glReadPixels.
---
src/mesa/drivers/dri/intel/intel_blit.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
Commit message here
This code is copied from _mesa_init_shader_state().
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/glsl/standalone_scaffolding.cpp | 12
1 file changed, 12 insertions(+)
diff --git a/src/glsl/standalone_scaffolding.cpp
b/src/glsl/standalone_scaffolding.cpp
index
We can't include shaderobj.h from the standalone utilities, so we
unfortunately have to copy this function.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/glsl/standalone_scaffolding.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/glsl
Shader stage only, as it's
currently only used for fixed-function vertex programs. That will
change soon, and I wanted to preserve the existing behavior.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/r200/r200_context.c | 2 +-
src/mesa/drivers/dri/radeon
worked on.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/glsl/glsl_parser_extras.cpp| 4 +++-
src/glsl/ir_optimization.h | 3 ++-
src/glsl/linker.cpp| 2 +-
src/glsl/main.cpp | 4 +++-
src/mesa/drivers/dri
the scalar backend
can't use DP4 and does have MAD support.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_context.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
b/src/mesa/drivers/dri/i965/brw_context.c
index
another boolean flag for this purpose.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/glsl/Makefile.sources | 1 +
src/glsl/glsl_parser_extras.cpp | 4 ++
src/glsl/ir_optimization.h | 1 +
src/glsl/opt_flip_matrices.cpp | 122
On 04/19/2013 11:07 AM, Marek Olšák wrote:
It depends on what you need the sw fallback for. Stippling and
smoothing is accelerated. Maybe emulating fragment shaders with too
many instructions?
Marek
Yeah - it needs to correctly fall back to software for shaders that
exceed instruction
insertions(+), 3 deletions(-)
Looks nice to me, but I'm guessing this only shows up through
ARB_debug_output? It'd be nice to get this via printf when an
environment variable is set.
For both:
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev
The code doesn't set brw-query.obj to NULL, it sets query-bo to NULL.
---
src/mesa/drivers/dri/i965/brw_queryobj.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_queryobj.c
b/src/mesa/drivers/dri/i965/brw_queryobj.c
index 194725c..81e975a
On 04/20/2013 07:21 PM, Matt Turner wrote:
Probably a copy-n-paste mistake.
---
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 04/19/2013 12:35 PM, Jordan Justen wrote:
An interface block member may specify the type:
in {
in vec4 in_var_with_qualifier;
};
When specified with the member, it must match the same
type as interface block type.
It can also omit the qualifier:
uniform {
vec4
On 04/19/2013 12:35 PM, Jordan Justen wrote:
Previously uniform blocks allowed for the 'uniform' keyword
to be used with members of a uniform blocks. With interface
blocks 'in' can be used on 'in' interface block members and
'out' can be used on 'out' interface block members.
The
On 04/19/2013 12:35 PM, Jordan Justen wrote:
For interface blocks, there are three separate namespaces for
uniform, input and output blocks.
http://knowyourmeme.com/photos/2109
There are?
Similarly, for your next patch:
Uniform/interface blocks are a separate namespace from types.
They are?
On 04/19/2013 12:35 PM, Jordan Justen wrote:
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
---
src/glsl/ast_to_hir.cpp |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
I was reviewing some patches and saw more new files that said IN NO EVENT
SHALL BRIAN PAUL BE LIABLE but were...not authored by Brian. People
keep doing that by accident, and a lot of those files have been altered
by other people by now anyway.
This series does the sed job to replace BRIAN PAUL
See previous commit for the rationale. These weren't caught by the
automatic conversion due to the OR IBM addition.
Cc: Brian Paul bri...@vmware.com
---
src/mesa/main/arrayobj.c | 2 +-
src/mesa/main/arrayobj.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
The previous commit introduced extra words, breaking the formatting.
This text transformation was done automatically via the following shell
command:
$ git grep 'THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES
OR OTHER LIABILITY' | sed 's/:.*$//' | xargs -I {} sh -c 'vim -e -s
Cc: Brian Paul bri...@vmware.com
---
docs/license.html | 7 ---
src/mapi/glapi/gen/mesadef.py | 7 ---
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/docs/license.html b/docs/license.html
index d872cad..80bb604 100644
--- a/docs/license.html
+++
On 04/12/2013 11:21 AM, Eric Anholt wrote:
Kenneth Graunke kenn...@whitecape.org writes:
Ironlake's counters are always enabled; userspace can simply send a
MI_REPROT_PERF_COUNT packet to take a snapshot of them. This makes it
easy to implement.
The counters are documented in the source code
On 04/12/2013 01:16 PM, Eric Anholt wrote:
Kenneth Graunke kenn...@whitecape.org writes:
Ironlake's counters are always enabled; userspace can simply send a
MI_REPROT_PERF_COUNT packet to take a snapshot of them. This makes it
easy to implement.
The counters are documented in the source code
On 04/13/2013 11:07 AM, Christoph Bumiller wrote:
On 12.04.2013 21:14, Kenneth Graunke wrote:
This provides an interface for applications (and OpenGL-based tools) to
access GPU performance counters. Since the exact performance counters
available vary between vendors and hardware generations
We accidentally set MESA_FORMAT_ETC2_RGB8_PUNCHTHROUGH_ALPHA1 twice,
rather than setting the RGB8 and SRGB8 formats.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/main/format_unpack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/main/format_unpack.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c
index feba386..94dd106 100644
--- a/src/mesa/main/format_unpack.c
+++ b/src
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/main/format_unpack.c | 253 ++
1 file changed, 253 insertions(+)
diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c
index 94dd106..279bad8 100644
--- a/src/mesa/main
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/main/format_unpack.c | 327 ++
1 file changed, 327 insertions(+)
diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c
index 279bad8..b1cf7be 100644
--- a/src/mesa/main
On 04/22/2013 09:17 PM, Ian Romanick wrote:
On 04/23/2013 02:39 AM, Kenneth Graunke wrote:
Otherwise, the table could be full of uninitialized garbage. That means
the NULL check at the bottom might not happen, so we wouldn't get the
_mesa_problem, and we'd then return garbage.
format_pack.c
---
src/mesa/Android.libmesa_dricore.mk | 4
src/mesa/main/version.c | 3 +++
2 files changed, 7 insertions(+)
Seems useful. I can do this in the kernel, so why not Mesa?
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa
10
#define BRW_MATH_FUNCTION_INT_DIV_QUOTIENT_AND_REMAINDER 11
Nope, they never have. Both patches are:
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http
-mapping of my tree.
Patches 1-6 are:
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
I'll try and look at the rest of them soon...
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
requires 2.6.39. If this is just for
compatibility with old kernels (especially pre-2.6), it should go.
Acked-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman
On 04/23/2013 12:23 PM, Brian Paul wrote:
---
src/mesa/main/context.h | 11 +++
src/mesa/main/dlist.c |4 ++--
src/mesa/vbo/vbo_save_api.c |3 +--
3 files changed, 14 insertions(+), 4 deletions(-)
Definitely nicer!
Both are:
Reviewed-by: Kenneth Graunke kenn
On 04/19/2013 10:54 AM, Eric Anholt wrote:
Removes 75/78 state-dependent recompiles in GLB2.7 (the remaining 3 are
due to FBO-rendering size predictions).
AFAICT ClampColor is not deprecated in OpenGL Core. It doesn't exist in
ES, though.
If you change it to _mesa_is_desktop_gl(ctx), you
On 04/23/2013 09:15 PM, Jordan Justen wrote:
On Tue, Apr 23, 2013 at 5:41 PM, Kenneth Graunke kenn...@whitecape.org wrote:
On 04/19/2013 10:54 AM, Eric Anholt wrote:
Removes 75/78 state-dependent recompiles in GLB2.7 (the remaining 3 are
due to FBO-rendering size predictions).
AFAICT
(fs_inst
*next_block_header)
}
}
+ if (unlikely(INTEL_DEBUG DEBUG_WM) post_reg_alloc) {
+ printf(fs%d estimated execution time: %d cycles\n,
+ v-dispatch_width, time);
+ }
+
assert(instructions_to_schedule == 0);
}
This patch is:
Reviewed-by: Kenneth
);
- } else if (ir-as_return() || ir-as_call()) {
+ } else if (ir-as_jump() || ir-as_call()) {
callback(leader, ir, data);
leader = NULL;
} else if ((ir_function = ir-as_function())) {
That was a lot easier than I feared! Nice work.
Both patches are:
Reviewed-by: Kenneth
. fs_reg::is_valid_3src?
Either way, this is
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
lowering code and use the BFE and
BFI2 instructions directly.
---
These patches should go before my ARB_gpu_shader5 series, and allow me to
drop
[PATCH 07/16] glsl: Add bitfieldInsert-to-bfm/bitops lowering pass.
[PATCH 08/16] glsl: Add BFE-to-bitops lowering pass.
Both are:
Reviewed-by: Kenneth
files changed, 6 insertions(+), 8 deletions(-)
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
the cracks.
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
authors
- Glad to see ARB_color_buffer_float dropped too!
All three are:
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
anything on this hardware --
+ * there is no multisampling.
+ */
+ barycoord_mode = BRW_WM_PERSPECTIVE_PIXEL_BARYCENTRIC;
}
return emit(FS_OPCODE_LINTERP, attr,
this-delta_x[barycoord_mode],
Awesome. Thanks so much for finding this!
Reviewed-by: Kenneth
don't suspect these are introduced by this patch.
Since this is for the stable branch, please verify that there are no
piglit regressions. I kind of hope we might get another r-b too.
Here, have another r-b :)
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
Looks reasonable to me
: {
+ const int c = op[1]-value.i[0];
Shouldn't we bounds check 'c' here? Otherwise you could walk off the
end of the array and crash. Undefined behavior is fine (pick some
random element), but crashing is bad.
Otherwise patch 1 looks good...
Reviewed-by: Kenneth Graunke kenn
On 04/08/2013 03:24 PM, Ian Romanick wrote:
From: Ian Romanick ian.d.roman...@intel.com
Lower ir_binop_vector_extract with a constant index to a swizzle. This
is exactly like ir_dereference_array of a vector with a constant index.
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
---
On 04/08/2013 03:24 PM, Ian Romanick wrote:
From: Ian Romanick ian.d.roman...@intel.com
Use a first function that extract the vector being indexed and the index
from the deref. Call the second function that does the real work.
Coming patches will add a new ir_expression for variable indexing
.
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/intel/intel_tex_validate.c | 37
src/mesa/drivers/dri/radeon/radeon_texture.c| 13 ++---
src/mesa/main/texcompress.c |2 +-
src/mesa/main/texcompress.h
-mapping of my tree.
Fantastic work as always - this cleaned up a lot of stuff across the
board! I reviewed everything as well as I could - the changes to
nouveau and radeon looked okay, but I'm obviously not the best qualified
to review those.
For the series:
Reviewed-by: Kenneth Graunke kenn
?
+gl_format
+_mesa_get_render_format(struct gl_context *ctx, gl_format format)
+{
+ if (ctx-Color.sRGBEnabled)
+ return format;
+ else
+ return _mesa_get_srgb_format_linear(format);
+}
This is much more succinct and likely to not break.
Reviewed-by: Kenneth Graunke kenn
=
gen6_blorp_emit_binding_table(brw, params,
wm_surf_offset_renderbuffer,
Nitpicking aside, this looks good.
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http
anyway, it should be fine.
This also makes is_control_flow() available in the VS.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 45
src/mesa/drivers/dri/i965/brw_fs.h | 3 ---
src/mesa/drivers/dri/i965
On 04/23/2013 04:56 PM, Eric Anholt wrote:
While this doesn't have the detail that the FS scheduler does, and is
ignorant of dependency control, it's still good for a 0.60% +/- 0.15%
performance improvement on GLBenchmark 2.7 (n=45/47, outliers removed)
---
On 04/29/2013 06:20 PM, Eric Anholt wrote:
Kenneth Graunke kenn...@whitecape.org writes:
On 04/23/2013 04:56 PM, Eric Anholt wrote:
While this doesn't have the detail that the FS scheduler does, and is
ignorant of dependency control, it's still good for a 0.60% +/- 0.15%
performance
On 04/29/2013 10:24 AM, Eric Anholt wrote:
Daniel Vetter dan...@ffwll.ch writes:
On Thu, Apr 25, 2013 at 03:41:01PM -0700, Eric Anholt wrote:
Improves GLB2.7 trex performance 1.01985% +/- 0.721366% on my IVB (n=10)
and by 3.38771% +/- 0.584241% (n=15) on my HSW, due to a 32x32 ARGB
Romanick i...@freedesktop.org
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
---
src/glsl/ast_to_hir.cpp | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 2638411..e595110 100644
--- a/src/glsl/ast_to_hir.cpp
On 02/25/2013 11:55 AM, Eric Anholt wrote:
Kenneth Graunke kenn...@whitecape.org writes:
The shadow comparitor needs to be loaded into the Z component of the
last DWord.
Fixes es3conform's shadow_execution_vert and oglconform's
shadow-grad advanced.textureGrad.1D tests on Haswell.
NOTE
On 02/25/2013 11:51 AM, Eric Anholt wrote:
Kenneth Graunke kenn...@whitecape.org writes:
GLSL provides gradients for the 'r' coordinate (face ID), while our
hardware apparently ignores them. Sadly, this means that sample_d and
sample_d_c appear to be unsuitable for OpenGL, and need
On 04/21/2013 04:08 PM, Todd Previte wrote:
Initial work on the implementation of GL_ARB_shading_language_420pack.
The patch adds the functionality from this extension which allows
for C-style array initialization for GLSL. The extension enable bits
and extension definition are also included in
-by: Kenneth Graunke kenn...@whitecape.org
diff --git a/src/glsl/Makefile.sources b/src/glsl/Makefile.sources
index c294aa4..86ae43e 100644
--- a/src/glsl/Makefile.sources
+++ b/src/glsl/Makefile.sources
@@ -62,6 +62,7 @@ LIBGLSL_FILES = \
$(GLSL_SRCDIR)/lower_mat_op_to_vec.cpp
1 file changed, 36 insertions(+)
Wow.
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 05/01/2013 09:25 PM, Jordan Justen wrote:
On Wed, May 1, 2013 at 9:13 PM, Matt Turner matts...@gmail.com wrote:
On Wed, May 1, 2013 at 8:41 PM, Jordan Justen jljus...@gmail.com wrote:
On Tue, Apr 30, 2013 at 10:01 AM, Jordan Justen jljus...@gmail.com wrote:
On Tue, Apr 30, 2013 at 9:57 AM,
On 04/30/2013 12:56 PM, Eric Anholt wrote:
There was some comment about trying to avoid marking resolves in
updownsample, but if the downsample is never actually rendered to, then
the required resolve tracked in the downsample will never be executed, so
who cares?
---
awkward having the core Mesa code rely on driver hooks setting up the
renderbuffer wrapper.
For the series (assuming this nouveau thing gets fixed):
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
- rb-Width = ti-Width;
- rb-Height = ti-Height;
nouveau_surface_ref
(gl_DepthRangeParameters));
For some reason, I thought state-Const.MaxFragmentUniformComponents got
initialized to different values based on whether ctx-API was GLES or
not. But it doesn't, and that wouldn't even work in the case of
ARB_ES?_compatibility.
So, looks good to me.
Reviewed-by: Kenneth Graunke
-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 05/02/2013 02:13 AM, Chris Wilson wrote:
On Wed, May 01, 2013 at 04:28:08PM -0700, Eric Anholt wrote:
The GPU apparently goes looking for constants even though there are no
shader stages enabled, and gets stuck because we haven't told it there are
no constants to collect. If any other user
On 05/02/2013 01:08 PM, Paul Berry wrote:
On 2 May 2013 12:54, Chris Wilson ch...@chris-wilson.co.uk
mailto:ch...@chris-wilson.co.uk wrote:
On Thu, May 02, 2013 at 09:07:08AM -0700, Eric Anholt wrote:
Chris Wilson ch...@chris-wilson.co.uk
mailto:ch...@chris-wilson.co.uk writes:
)
+ ra_set_allocate_round_robin(brw-vs.regs);
ralloc_free(brw-vs.classes);
brw-vs.classes = ralloc_array(brw, int, class_count + 1);
Thanks for doing this!
For the series:
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev
depth_clear_value;
switch (mt-format) {
case MESA_FORMAT_Z32_FLOAT_X24S8:
Would be worth regression testing on Gen6.
Really glad to see this working.
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
___
mesa-dev mailing list
mesa-dev
in affected programs: 16550 - 16422 (-0.77%)
---
src/glsl/opt_if_simplification.cpp | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
What a strange occurrance :) Obvious improvement though.
Reviewed-by: Kenneth Graunke kenn...@whitecape.org
On 05/03/2013 10:44 AM, Gregory Hainaut wrote:
V2:
* Rename object
* Formatting improvement
---
src/mesa/main/pipelineobj.c | 77 +++
1 file changed, 77 insertions(+)
diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c
index
On 05/04/2013 02:32 PM, gregory hainaut wrote:
On Sat, 04 May 2013 12:37:05 -0700
Kenneth Graunke kenn...@whitecape.org wrote:
On 05/03/2013 10:44 AM, Gregory Hainaut wrote:
V2:
* Rename object
* Formatting improvement
---
src/mesa/main/pipelineobj.c | 77
701 - 800 of 8470 matches
Mail list logo