Re: ModemManager: symbol lookup error: ModemManager: undefined symbol: mm_kernel_event_properties_get_type

On 06/04/17 21:26, Jan Graczyk wrote: > I have used ./configure --with-qmi=yes than make and make install and I have > run ModemManager with a command ModemManager --debug. Am I missing any other > option in ./configure? Thank you for your help. If you are not using --prefix=/somewhere in

Re: [PATCH] iface-modem-simple: port register_in_3gpp_or_cdma_network to use GTask

On 04/04/17 08:37, Ben Chan wrote: > --- > src/mm-iface-modem-simple.c | 59 > ++--- > 1 file changed, 34 insertions(+), 25 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-simple.c b/src/mm-iface-modem-simple.c > index

Re: ModemManager: symbol lookup error: ModemManager: undefined symbol: mm_kernel_event_properties_get_type

On 06/04/17 21:14, Jan Graczyk wrote: > I am using Quectel UC20 mini PCIe modem on my development board and running > ModemManager on it. Since ModemManager is using by default baud rate set to > 57600 I have decided to move to the latest version of ModemManager (1.7.0) > since there is a

Re: [PATCH] bearer-list: port mm_bearer_list_disconnect_all_bearers to use GTask

On 04/04/17 08:37, Ben Chan wrote: > --- > src/mm-bearer-list.c | 40 +--- > 1 file changed, 21 insertions(+), 19 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-bearer-list.c b/src/mm-bearer-list.c > index e021e34a..9ad98aeb 100644 > ---

Re: ModemManager: symbol lookup error: ModemManager: undefined symbol: mm_kernel_event_properties_get_type

On Fri, Apr 7, 2017 at 12:14 AM, Jan Graczyk wrote: > I found no qmi wwan device present in /dev directory even though the > qmi_wwan.ko module is inserted. I am running Linux version 4.1.15 and I have > mini PCie Quectel UC20 modem module installed on my development board. Is

Re: [PATCH] call-list: port mm_call_list_delete_call to use GTask

On 06/04/17 21:54, Ben Chan wrote: > --- > src/mm-call-list.c | 55 > +++--- > 1 file changed, 19 insertions(+), 36 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-call-list.c b/src/mm-call-list.c > index fae66035..1cc1f543

Re: [PATCH] sms-list: port mm_sms_list_delete_sms to use GTask

On 06/04/17 21:42, Ben Chan wrote: > --- > src/mm-sms-list.c | 70 > +-- > 1 file changed, 27 insertions(+), 43 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-sms-list.c b/src/mm-sms-list.c > index 7819b3ad..22c2cd9a

Re: [PATCH] port-mbim: port mm_port_mbim_{open,close} to use GTask

Hey Ben, See some comments below. On 06/04/17 22:46, Ben Chan wrote: > --- > src/mm-port-mbim.c | 130 > + > 1 file changed, 50 insertions(+), 80 deletions(-) > > diff --git a/src/mm-port-mbim.c b/src/mm-port-mbim.c > index

Re: [PATCH 2/2] port-qmi: port mm_port_qmi_allocate_client to use GTask

Hey Ben, See comments below. On 06/04/17 22:41, Ben Chan wrote: > --- > src/mm-port-qmi.c | 51 ++- > 1 file changed, 26 insertions(+), 25 deletions(-) > > diff --git a/src/mm-port-qmi.c b/src/mm-port-qmi.c > index c6ae0615..2baeea7c 100644 > ---

Re: [PATCH 1/2] auth: port authorize to use GTask

On 06/04/17 21:38, Ben Chan wrote: > --- > src/mm-auth-provider.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-auth-provider.c b/src/mm-auth-provider.c > index 4ef56234..4d8766c0 100644 > --- a/src/mm-auth-provider.c

Re: [PATCH v2] telit: unsupported CSIM lock should not skip loading unlock retries

On 10/04/17 12:25, Carlo Lobrano wrote: > Some modems do not support CSIM lock/unlock, but they do support > querying SIM unlock retries through +CSIM command. > > If CSIM lock returns with "unsupported command" do not propagate > the error and continue with the other CSIM queries instead,

Re: MC7455 location support

On Thu, Apr 13, 2017 at 8:30 PM, Dan Williams wrote: >> > also, if you have ModemManager debug logs, that would be great to >> > see >> > too so we can make sure things are being set up correctly. >> >> Attached. Also output of mmcli -m 0 in separate file. > > Thanks. This shows

Re: [PATCH v3] telit: unsupported CSIM lock should not skip loading unlock retries

On Thu, Apr 13, 2017 at 6:09 PM, Dan Williams wrote: >> > This thread turns out to be relevant to the latest in my battle >> > with Cinterion modules. Their EHS5 doesn't support AT^SPIC, but it >> > turns out it does support the CSIM commands used by the telit >> > plugin -

Re: [review] dcbw/qcdm-cleanups

Hey Dan, On 10/04/17 17:50, Dan Williams wrote: > Port some stuff over to GTask, clean up some QCDM stuff, and also make > sure QCDM code opens the port when it needs to instead of assuming > there's a port already open. That's necessary for Huawei DDSETEX voice > support. > I've reviewed

Re: [PATCH 1/3] iface-modem-signal: port mm_modem_iface_signal_disable to use GTask

On 13/04/17 03:52, Ben Chan wrote: > --- > src/mm-iface-modem-signal.c | 15 +-- > 1 file changed, 5 insertions(+), 10 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-signal.c b/src/mm-iface-modem-signal.c > index dbf11515..fdfdc7e0 100644 > ---

[PATCH] core: prefer g_task_return_error_if_cancelled() than custom errors

When the GCancellable is added to the GTask, we can use a single method call to check for the task being cancelled, and complete it right away if so. This patch also clears up the logic in the Novatel plugin, where the code was trying to return "TRUE" when the task was cancelled, but wouldn't

Re: [PATCH 2/3] iface-modem-signal: port mm_iface_modem_signal_enable to use GTask

On 13/04/17 03:52, Ben Chan wrote: > --- > src/mm-iface-modem-signal.c | 16 ++-- > 1 file changed, 6 insertions(+), 10 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-iface-modem-signal.c b/src/mm-iface-modem-signal.c > index fdfdc7e0..f8348831 100644 > ---

Re: [PATCH v3] telit: unsupported CSIM lock should not skip loading unlock retries

On 13/04/17 11:53, Carlo Lobrano wrote: > Some modems do not support CSIM lock/unlock, but they do support > querying SIM unlock retries through +CSIM command. > > If CSIM lock returns with "unsupported command" do not propagate > the error and continue with the other CSIM queries instead,

Re: [PATCH] telit: add error_code recognition to +CSIM parser

On Tue, Apr 18, 2017 at 5:20 PM, Colin Helliwell wrote: > To keep things simple for now, these logs are with an unlocked SIM. This is > with my modified Cinterion plugin, which I've chucked the +CSIM's into. > > EHS5: > Doesn't support ^SPIC at all. > But

Re: [PATCH v2] broadband-bearer: once connected, set flow control settings

On Tue, Apr 18, 2017 at 4:58 PM, Dan Williams wrote: >> > > I made the flow control setting a readable property in the Modem >> > > object, and a RW property in the Bearer object. The property is >> > > inherited by the bearer object when it is created, i.e. in >> > >

Re: [PATCH] telit: add error_code recognition to +CSIM parser

On Tue, Apr 18, 2017 at 6:01 PM, Dan Williams wrote: >> > * 6300 - Verification failed >> > * 6983 - Authentication method blocked >> > * 6984 - Reference data invalidated >> > * 6A86 - Incorrect parameters >> > * 6A88 - Reference data not found >> >> From a quick online search

Re: [PATCH 3/8] wavecom: ignore custom flow control handling

On 25/03/17 19:32, Aleksander Morgado wrote: > The generic modem object already supports querying for the supported > methods and setting the best one found. > --- This has been merged to git master. > plugins/wavecom/mm-broadband-modem-wavecom.c | 27 -

Re: [PATCH 5/8] port-serial: new internal method to run tcsetattr()

On 25/03/17 19:32, Aleksander Morgado wrote: > The method takes care of looping if EAGAIN errors happen, as well as > checking whether all attributes were set or not. > --- This has been merged to git master. > src/mm-port-se

Re: [PATCH 6/8] port-serial: new method to explicitly set flow control settings

On 25/03/17 19:32, Aleksander Morgado wrote: > --- > src/mm-port-serial.c | 50 ++ > src/mm-port-serial.h | 5 + > 2 files changed, 55 insertions(+) > This has been merged to git master. > diff --git a/src/mm-port-seri

Re: [PATCH 1/8] helpers: new parser for AT+IFC=?

On 25/03/17 19:32, Aleksander Morgado wrote: > Instead of having the parser return separate list of supported flow > controls for TE and TA, we simplify it by only returning those > settings that apply to both TE and TA. > > This logic isn't perfect either, though, as some se

Re: [PATCH 2/8] broadband-modem: query supported flow control modes before setting

On 25/03/17 19:32, Aleksander Morgado wrote: > Instead of assuming XON/XOFF is supported, we query the supported flow > control modes, and then we set the best one based on that, preferring > hardware flow control over software flow control. > --- This has been merged to git master.

Re: [PATCH] core: prefer g_task_return_error_if_cancelled() than custom errors

On 15/04/17 23:26, Aleksander Morgado wrote: > When the GCancellable is added to the GTask, we can use a single > method call to check for the task being cancelled, and complete it > right away if so. > > This patch also clears up the logic in the Novatel plugin, where the &g

Re: [PATCH v2] broadband-bearer: once connected, set flow control settings

On 09/04/17 14:14, Aleksander Morgado wrote: > During modem initialization we detected the flow control settings > supported by the modem, and selected the best one to use from them, > notifying it to the device via AT+IFC. The device was therefore > instructed to use that flow con

Re: Telit HE910 not connecting with Modem Manager 1.6.4

Hey Salvador, On Thu, Mar 9, 2017 at 4:39 PM, Penalva, Salvador wrote: > > root@ccimx6ulsbc:~# mmcli -m 0 > > > > /org/freedesktop/ModemManager1/Modem/0 (device id > '6cb907e9b25fd81d9b144d3346b48cc89f489910') > > - > > Hardware |

Re: [PATCH] device: add null check on `self->priv->modem' in clear_modem

On Fri, Mar 3, 2017 at 7:29 PM, Ben Chan wrote: > clear_modem() can be invoked from set_property() and dispose(), where > `self->priv->modem' may be NULL. This patch adds a null check on the > modem object to make sure we don't run g_object_run_dispose() on a null > modem

Re: Cinterion 'simstatus'

On Wed, Mar 8, 2017 at 9:29 PM, Reinhard Speyerer wrote: >> I'll look for a command which can achieve the same test - perhaps the >> function could switch over to the alternative if it gets an >> 'unsupported' error? (My modems give a "+CME ERROR: 22") > > Maybe AT^SSET would be

[PATCH] iface-modem: improve network registration checks for LTE devices

If a device reports "LTE" in the list of current capabilities, we'll set EPS network supported by default. This will enable CEREG registration checks for AT based devices. If a device reports only "LTE" in the list of current capabilities, we disable all the other network support flags (e.g. will

Fix reporting capabilities in 4G-only devices

Hey Dan and everyone, The following two patches try to fix the capabilities reporting for 4G-only modems, which were mistakenly being set as also GSM/UMTS as soon as +GCAP was used to probe for capabilities. The first patch is a new AT+WS46=? parser, which returns the full list of

[PATCH 2/2] broadband-modem: fix capabilities in 4G-only devices

The +CGSM capability is saying that the modem is a 3GPP modem, but that doesn't necessarily mean it's a GSM/UMTS modem, it could be a LTE-only device. We did add the GSM_UMTS capability when +CGSM was found, so now we'll check if the device only reports 4G-only mode, and remove the capability if

[PATCH] telit: support RS232 modems

Adding the vendor string match allows us to support RS232 devices in the Telit plugin: the USB vendor id check may now be ignored and instead we probe for the vendor string via AT commands, which works even if the device is behind a USB<->RS232 adapter.

Re: ModemManager and ppp

On Fri, Mar 10, 2017 at 5:24 PM, Tom Hayward wrote: > I'm a new user of ModemManager and trying to understand the scope of > the software. > > I've used ModemManager successfully with a cdc-wdm modem. It created a > wwan0 interface where I could use a dhcp client and then

Re: ModemManager and ppp

On Fri, Mar 10, 2017 at 7:25 PM, Tom Hayward wrote: > On Fri, Mar 10, 2017 at 9:25 AM, Tom Hayward wrote: >> It sounds like I could improve my process by ditching the chatscript, >> using --simple-connect, then adding a new utility to communicate

[PATCH] kernel-device: device-specific properties in either port or physdev

There are 2 main types of udev properties: device-specific and port-specific. The port-specific properties are set independently per port (e.g. port type hints set per interface number for a given vid:pid). The device-specific properties apply to all ports in the device. Some of these properties

[PATCH] serial: allow specifying baudrate to use via udev tags

A new 'ID_MM_TTY_BAUDRATE' per-port udev tag is introduced, which allows specifying the baudrate that will be used when opening a specific serial port. E.g.: ACTION!="add|change|move", GOTO="mm_my_modem_end" DEVPATH=="/devices/pci:00/:00:1d.0/usb1/1-1/1-1.3/*",

[PATCH] telit: don't ignore AT ports without an explicit port type hint tag

The telit plugin is based on two main ways of checking the purpose of each port: udev tags flagging specific interfaces (with info taken from Windows .inf drivers), or otherwise using AT#PORTCFG? to query the modem about that information. If none of those applies, the port is ignored by default.

Re: Cinterion 'simstatus'

On Wed, Mar 8, 2017 at 1:45 PM, Colin Helliwell wrote: > I'll look for a command which can achieve the same test - perhaps the > function could switch over to the alternative if it gets an 'unsupported' > error? (My modems give a "+CME ERROR: 22") That would be

Re: 'port forced close' after failed ppp

On Tue, Mar 7, 2017 at 3:46 PM, Colin Helliwell wrote: >> > > Mar 7 10:05:25 wg2 daemon.debug pppd[944]: sent [IPCP ConfReq id=0x1 >> > > ] >> > > Mar 7 10:05:25 wg2 daemon.info ModemManager[896]: [141125.484324] >> > > [src/mm-port-serial.c:1294]

Re: [PATCH] cinterion: improve ^SCFG=? response parser to handle EHS5 format

On Tue, Mar 7, 2017 at 6:39 PM, Colin Helliwell <colin.helliw...@ln-systems.com> wrote: > >> On 07 March 2017 at 16:44 Aleksander Morgado <aleksan...@aleksander.es> >> wrote: >> >> Two main changes in the regex: >> >> * Ignore double quote

Re: [PATCH v2 2/2] kernel-device: use device sysfs if physdev sysfs isn't available

On Thu, Mar 2, 2017 at 7:31 PM, Ben Chan wrote: > I saw a few self->priv->device check in mm-kernel-device-udev.c, so I was > wondering if there are cases where self->priv->device may be NULL. I'd keep > the check here for now as I haven't ruled out that possibility. I

Re: [PATCH v4] kernel-device: use device sysfs if physdev sysfs isn't available

On 03/03/17 03:57, Ben Chan wrote: > find_device_by_physdev_uid() expects a non-NULL UID of the physical > device. However, mm_kernel_device_get_physdev_uid() could potentially > return NULL on MMKernelDeviceUdev if find_physical_gudevdevice() in > mm-kernel-device-udev.c fails to find the

Re: [PATCH 8/8] broadband-bearer: once connected, set flow control settings

On Sat, Apr 1, 2017 at 5:57 AM, Dan Williams wrote: >> +MMFlowControl >> +mm_broadband_modem_get_connected_flow_control (MMBroadbandModem >> *self) >> +{ >> +return self->priv->modem_flow_control; >> +} > > This part is kinda icky; and mm-broadband-bearer has no other case of

Re: [PATCH] base-call: remove unnecessary string duplications

On 08/04/17 03:16, Ben Chan wrote: > --- > src/mm-base-call.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > Pushed to git master, thanks! > diff --git a/src/mm-base-call.c b/src/mm-base-call.c > index 6ce85d0d..606d24f2 100644 > --- a/src/mm-base-call.c > +++

Re: [PATCH 2/2] port-qmi: port mm_port_qmi_allocate_client to use GTask

On 07/04/17 18:25, Ben Chan wrote: >>> typedef struct { >>> -MMPortQmi *self; >>> -GSimpleAsyncResult *result; >>> ServiceInfo *info; >>> } AllocateClientContext; >>> >> I believe we could remove the AllocateClientContext struct all together >> and just pass the ServiceInfo as task

Re: Failed to find primary AT port

On Thu, Apr 6, 2017 at 12:39 AM, Jan Graczyk wrote: > Thank you for your response. I have looked into ModemManager version 1.6.4 > and this patch you are mentioning in your e-mail does not reflect the line > number in src/mm-base-modem.c: > > @@ -219,6 +219,12 @@

Re: Signal quality

On Tue, Mar 21, 2017 at 5:04 PM, José wrote: > ModemManager reports look like this: > > Status | lock: 'none' > | unlock retries: 'sim-pin (3), sim-pin2 (3), sim-puk (10), sim-puk2 (10)' > | state: 'connected' > | power state: 'on' > | access tech: 'hsdpa' > | signal quality:

Re: cinterion: modification to fetching unlock retries

On Tue, Apr 18, 2017 at 9:59 AM, Carlo Lobrano wrote: > the examples in the docs do not show quoted strings, but I just gave a try > with a couple of modems and I saw no problems. Ok, so maybe we should really move the logic to the parent MMBroadbandModem object and have all

Re: MC7455 location support

On Mon, Apr 17, 2017 at 9:03 PM, Dan Williams wrote: > "version" is the QMI service version that this command first appeared > in, and I'd guess Start appeared in v1.0 of QMI_SVC_LOC. "since" is > the libqmi version that this message was first defined in, so we'll use > "1.19"

Re: [PATCH v2] broadband-bearer: once connected, set flow control settings

On Mon, Apr 17, 2017 at 6:54 PM, Dan Williams wrote: >> I made the flow control setting a readable property in the Modem >> object, and a RW property in the Bearer object. The property is >> inherited by the bearer object when it is created, i.e. in >> mm_broadband_bearer_new()

Re: [review] dcbw/huawei-voice

On Mon, Apr 17, 2017 at 7:08 PM, Dan Williams wrote: > > Reworked the audio format stuff and added mmcli support. > > Removed the 'blocked' stuff and started using 'connected' instead. > > Now the larger change: call state handling in mm-base-call.c. I > removed most of the base

Re: cinterion: modification to fetching unlock retries

On Tue, Apr 18, 2017 at 10:48 AM, Carlo Lobrano wrote: > Consider that we can move the "FeatureSupport" logic to the parent, too. If > Cinterion do not support CSIM lock Yeah, that's why I said CSIM=1/CSIM=0 it's optional in the Telit plugin. -- Aleksander

Re: [PATCH v4] telit: add error_code recognition to +CSIM parser

On 19/04/17 10:00, Carlo Lobrano wrote: > - Refactored mm_telit_parse_csim_response in order to correctly > recognize the following +CSIM error codes: > * 6300 - Verification failed > * 6983 - Authentication method blocked > * 6984 - Reference data invalidated > * 6A86 -

Re: [PATCH v3] telit-plugin: ignore QSS when SIM-ME interface is locked

On 28/07/17 15:57, Carlo Lobrano wrote: > With some modems, the lock/unlock of the SIM-ME interface with +CSIM=1/0 > command is followed by #QSS unsolicited messages. With the current > implementation, this messages are mistaken for SIM swap events and so the > modem is first dropped and then

Re: [PATCH] sim hot swap: improved error management

On 25/07/17 09:03, Carlo Lobrano wrote: > Currently, when SIM hot swap fails in either mm-iface or plugin, the > ModemManager still opens ports context and prints a message saying that > SIM hot swap is supported and that it's waiting for SIM insertion, > instead of clearly saying that SIM hot

Re: Handling QSS unsolicited in power state transitions

On 01/08/17 10:04, Carlo Lobrano wrote: > last week I was working to handle a behavior that most of the Telit modem > have, that is, they emit *#QSS* unsolicited in consequence of *+CFUN* > commands. Most of the times, the modems are already in *+CFUN=1* at the > start so we did not notice it in

Re: ATZ in enabling_modem_init() step

On 27/07/17 11:15, Tim Small wrote: >>> I wonder if issuing ATZ is the right thing to do here at all? >>> >>> It's trying to reset the modem to a well-known state, but ATZ doesn't do >>> that - it loads the default user defined profile - which could be >>> anything that the user or another piece

Re: [PATCH] libmm-glib,firmware: fix unique_id checks

On 03/08/17 06:53, Ben Chan wrote: > The following checks in mm_modem_firmware_select() and > mm_modem_firmware_select_sync() could result in a NULL pointer > dereference if `unique_id' is NULL: > > g_return_if_fail (unique_id != NULL || unique_id[0] == '\0') > g_return_val_if_fail (unique_id

Re: [PATCH 4/5] plugin-manager: remove unused variable

On 03/08/17 06:53, Ben Chan wrote: > --- > src/mm-plugin-manager.c | 4 > 1 file changed, 4 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-plugin-manager.c b/src/mm-plugin-manager.c > index 47d162fb..65ccbebf 100644 > --- a/src/mm-plugin-manager.c > +++

Re: [PATCH 2/5] broadband-modem: remove unused variables

On 03/08/17 06:53, Ben Chan wrote: > --- > src/mm-broadband-modem.c | 12 > 1 file changed, 12 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-broadband-modem.c b/src/mm-broadband-modem.c > index eb127b58..2bfc3382 100644 > --- a/src/mm-broadband-modem.c > +++

Re: [PATCH 3/5] call-list: remove unused variables

On 03/08/17 06:53, Ben Chan wrote: > --- > src/mm-call-list.c | 15 +-- > 1 file changed, 5 insertions(+), 10 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-call-list.c b/src/mm-call-list.c > index 9457bb2b..3ca46bcc 100644 > --- a/src/mm-call-list.c > +++

Re: [PATCH] novatel: avoid calling qcdm_result_unref on NULL QcdmResult

On 03/08/17 06:53, Ben Chan wrote: > --- > plugins/novatel/mm-broadband-modem-novatel.c | 1 - > 1 file changed, 1 deletion(-) > Pushed to git master, thanks. > diff --git a/plugins/novatel/mm-broadband-modem-novatel.c > b/plugins/novatel/mm-broadband-modem-novatel.c > index

Re: [PATCH] sms-part-cdma: add missing break statements in cause_code_to_delivery_state

On 03/08/17 06:53, Ben Chan wrote: > This patch fixes cause_code_to_delivery_state() by adding two missing > break statements for the case ERROR_CLASS_TEMPORARY and > ERROR_CLASS_PERMANENT in the `switch (error_class)` statement. Without > the break statements, the switch always falls through to

Re: [PATCH] broadband-modem-mbim: remove unused variable

On 03/08/17 09:58, Ben Chan wrote: > --- > src/mm-broadband-modem-mbim.c | 2 -- > 1 file changed, 2 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-broadband-modem-mbim.c b/src/mm-broadband-modem-mbim.c > index 7f5d2fc8..815f5455 100644 > --- a/src/mm-broadband-modem-mbim.c

Re: [PATCH] huawei: ensure MMBearerConnectResult populated into GSimpleAsyncResult

On 02/08/17 02:01, Ben Chan wrote: > During the CONNECT_3GPP_CONTEXT_STEP_LAST step, > connect_3gpp_context_step() conditionally creates and populates a > MMBearerConnectResult object into the GSimpleAsyncResult object when the > ipv4_config field of the Connect3gppContext struct is set. That

Re: [PATCH] altair-lte: don't use send-delay=0

On 02/08/17 07:16, Ben Chan wrote: > As observed on some modems, send-delay=0 seems to break port probing. > --- > plugins/altair/mm-plugin-altair-lte.c | 1 - > 1 file changed, 1 deletion(-) > But the port probing with send delay 0 here should only happen when the Altair LTE modem is the one

Re: Sending SMS in PDU mode fails.

On 03/08/17 11:04, José wrote: > I am using the 3G XBee Cellular (uses U-Blox SARA-U200 modem) and > ModemManager from master (d41d717112e6a183a0df510c210e80a86fc11060). > > I am trying to send an SMS with the following commands: > > $ mmcli -m 0 --messaging-create-sms="text='Hello

Re: [PATCH] altair-lte: don't use send-delay=0

On Thu, Aug 3, 2017 at 4:24 PM, Ben Chan <benc...@chromium.org> wrote: > > > On Aug 3, 2017 3:35 AM, "Aleksander Morgado" <aleksan...@aleksander.es> > wrote: > > On 02/08/17 07:16, Ben Chan wrote: >> As observed on some modems, send-delay=0 seems to br

Re: ModemManager and Iridium 9522b

Hey > > I am trying to get my Iridium 9522b modem recognized using mmcli. It is > connected on /dev/ttyUSB2 with 19200, 8, N, 1. I can successfully > communicate via AT commands through pyserial or minicom, so I'm confident > that it is functioning. > > Below are the scan and list outputs from

Re: Custom AT command support in ModemManager

Hey, On Wed, Aug 16, 2017 at 1:36 AM, Jose, Shijo wrote: > Moving thread (MBIM_CID_DEVICE_SERVICE_SUBSCRIBE_LIST support) form > libmbim-devel list. > Thanks >>> Is there way to send AT commands to the modem via MM? >>>I tired - >>> mmcli -m 0 --command="E0" >>> error:

Re: Samsung GT-B3730 mobile broadband device

On Sun, Aug 13, 2017 at 4:09 PM, Germano Massullo <germano.massu...@gmail.com> wrote: > Il 13/08/2017 16:05, Aleksander Morgado ha scritto: >> I'm assuming there is some other AT command we can use to check for >> the PIN status. Germano, maybe you can try to investigate that

Re: [PATCH] broadband-modem-mbim: explicitly remove notification handler on unref

>> When we remove the last object reference, make sure the notification >> handler is also removed, or we may end up using an already freed >> object. >> >> https://retrace.fedoraproject.org/faf/reports/1815001/ > > Good catch; any time we connect a signal somewhere in an object, we > should

Re: [PATCH v2] charset: fix mm_charset_get_encoded_len

On 12/08/17 00:17, Ben Chan wrote: > The while loop in mm_charset_get_encoded_len() iterates through each > valid UTF-8 encoded character in the given NULL-terminated UTF-8 string. > It uses g_utf8_find_next_char() to find the position of the next > character. In case, g_utf8_find_next_char()

Re: [PATCH v2] mm-broadband-modem-mbim: reprobe on mbim-proxy death

Hey Eric, On 04/08/17 19:15, Eric Caruso wrote: > In case mbim-proxy crashes, ModemManager needs to be able to > recognize this and respawn the proxy so we don't lose access > to the modem. Do this by subscribing to the device removal > signal on MbimDevice and reprobing the modem when we lose

Re: [PATCH] kernel-device: avoid potential NULL dereference

On 12/08/17 09:08, Ben Chan wrote: > The patch fixes get_device_ids() in mm-kernel-device-udev.c to avoid > potential NULL dereferences of the 'vendor' argument. It also rearranges > the code such that the 'vendor' argument is updated only when the > function returns TRUE, just like how the

[PATCH] charset: only update length if char conversion succeeded

The methods that convert from a gunichar to a specific encoding may update the output 'clen' value unconditionally, regardless of whether the conversion is going to be successful or not. Avoid that by updating the length only if the conversion was successful. --- Hey, Looks like we're updating

Re: [review] https://github.com/cbchan/ModemManager/tree/sim-mbim-unlock-retries

Hey > It really is unfortunate that the MBIM_CID_PIN query only reports the > information of the "currently applicable" PIN type, although the truth > is that that's the only useful one. Yes, indeed. It would have been much better if MBIM_CID_PIN query could take a PIN

Re: Making disconnection more robust

On Fri, Aug 11, 2017 at 1:05 PM, Tim Small wrote: > A couple more questions... > > What should the code do if a return to AT command mode fails? Currently > the code just continues to try and use a port which is still in data > mode - issuing AT commands on it... > Yeah, not

Re: Making disconnection more robust

On Fri, Aug 11, 2017 at 3:58 PM, Tim Small <t...@seoss.co.uk> wrote: > On 11/08/17 14:09, Aleksander Morgado wrote: >> I'd suggest we try to move >> that modem to "Failed" state instead, as we really lost the control >> port; and let the applications

Re: [PATCH] broadband-modem-mbim: explicitly remove notification handler on unref

On Fri, Aug 11, 2017 at 5:04 PM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > When we remove the last object reference, make sure the notification > handler is also removed, or we may end up using an already freed > object. > > https://retrace.fedoraproject.or

Re: Custom AT command support in ModemManager

On Thu, Aug 17, 2017 at 2:45 AM, Jose, Shijo wrote: >>> I just realized you're working with a MBIM modem. So the "No AT port >>> available to run command" may actually mean there is no AT port >>> detected in the modem. Are you able to see a TTY listed in the >>>

Re: [PATCH 3/5] telit: remove unnecessary NULL checks for g_free / g_match_info_free

On 12/07/17 10:03, Ben Chan wrote: > g_free() and g_match_info_free() already check if the given pointer is > NULL and does nothing on a NULL pointer. > --- > plugins/telit/mm-modem-helpers-telit.c | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > Pushed to git master,

Re: [PATCH 2/5] telit: fix memory leak in mm_telit_get_4g_mm_bands

On 12/07/17 10:03, Ben Chan wrote: > --- > plugins/telit/mm-modem-helpers-telit.c | 1 + > 1 file changed, 1 insertion(+) > Pushed to git master, thanks! > diff --git a/plugins/telit/mm-modem-helpers-telit.c > b/plugins/telit/mm-modem-helpers-telit.c > index 39e0d1bd..d0e50ab3 100644 > ---

Re: [PATCH v3] mm-broadband-modem-mbim: support SIM hot swapping

On 11/07/17 19:58, Eric Caruso wrote: > If an MBIM modem supports unsolicited notifications for > subscriber ready status, we can use it to detect when SIM cards > have been removed and reinserted. Upon detection we should re- > probe the modem so that we can configure it for the new SIM. > ---

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem-mbim

On 11/07/17 19:38, Ben Chan wrote: > This branch contains a series of patches that port MMBroadbandModemMbim to > use GTask: > > https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-modem-mbim > Pushed to git master, thanks. I also included a follow up

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem-mbim

On 11/07/17 19:38, Ben Chan wrote: > This branch contains a series of patches that port MMBroadbandModemMbim to > use GTask: > > https://github.com/linux-mobile-broadband/ModemManager/compare/master...cbchan:gtask-broadband-modem-mbim > Pushed to git master, thanks. I also included a follow up

Re: [PATCH] ublox: fix memory leaks in unit tests

On 12/07/17 10:02, Ben Chan wrote: > --- > plugins/ublox/tests/test-modem-helpers-ublox.c | 1 + > 1 file changed, 1 insertion(+) > Pushed to git master, thanks. > diff --git a/plugins/ublox/tests/test-modem-helpers-ublox.c > b/plugins/ublox/tests/test-modem-helpers-ublox.c > index

Re: [PATCH] broadband-modem: rename load_power_state for consistency

On 14/07/17 09:36, Ben Chan wrote: > All MMIfaceModem functions implemented by MMBroadbandModem, except > load_power_state, are prefixed with 'modem_'. For consistency, this > patch renames load_power_state{,_finish} to > modem_load_power_state{,_finish}. > --- Pushed to git master, thanks. >

Re: Timout error: Can't send SMS

On Fri, Jul 14, 2017 at 2:05 PM, Daniel Westhoff wrote: > 2017-07-14 11:58:55Z carpc@mars1:~$ sudo mmcli -m 0 > --messaging-create-sms="text='Hello world from > MARS1',smsc='+49171076',number='+49XXX'" > Successfully created new SMS: >

Re: Can't set SUPL server

On Fri, Jul 14, 2017 at 1:56 PM, Daniel Westhoff wrote: > 2017-07-14 11:38:01Z carpc@mars1:~$ sudo mmcli -v -m 0 > --location-set-supl-server="supl.google.com" > [14 Jul 2017, 11:47:15] [Debug] ModemManager process found at ':1.2' > [14 Jul 2017, 11:47:15] [Debug] Assuming

Re: Can't set SUPL server

On Fri, Jul 14, 2017 at 9:48 PM, Daniel Westhoff wrote: > thx for for the fast response. I tried to set SUPL server with debug mode > enabled as described on the Debugging website. > > The log files of ModemManager and NetworkManager are attached in a ZIP file.

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem

On Mon, Jul 17, 2017 at 8:49 AM, Ben Chan wrote: > Just realized there may be an issue with changes to some of those > MMIfaceModem3gpp / MMIfaecModemCdma functions implemented by > MMBroadbandModem. Several plugins have code that chains up parent's > function like this: > >

Re: [review] https://github.com/cbchan/ModemManager/tree/gtask-broadband-modem

On Mon, Jul 17, 2017 at 10:02 AM, Aleksander Morgado <aleksan...@aleksander.es> wrote: >> What you included here as a >> snippet is a huge bug actually. > > Well, not that huge really... the only issue is that we're setting the > GSimpleAsyncResult result tw

github mirror repositories

Hey everyone, We now have github repos for all ModemManager, libqmi and libmbim: https://github.com/linux-mobile-broadband/ModemManager https://github.com/linux-mobile-broadband/libqmi https://github.com/linux-mobile-broadband/libmbim These aren't really real mirrors yet, they aren't

Re: github mirror repositories

On Tue, Jul 11, 2017 at 12:23 PM, Neal Gompa wrote: >> We now have github repos for all ModemManager, libqmi and libmbim: >> >> https://github.com/linux-mobile-broadband/ModemManager >> https://github.com/linux-mobile-broadband/libqmi >>

Re: [PATCH v2] mm-broadband-modem-mbim: support SIM hot swapping

Hey Eric, Looks very good to me, just some minor coding style issues, see below. Also, I wouldn't mind debug logs when inserting the sim and removing the sim, for future reference. On Tue, Jul 11, 2017 at 3:09 AM, Eric Caruso wrote: > If an MBIM modem supports unsolicited

Re: [PATCH] bearer-qmi: replace g_new + memcpy with g_memdup

On 10/07/17 20:20, Ben Chan wrote: > --- > src/mm-bearer-qmi.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > Pushed to git master, thanks. > diff --git a/src/mm-bearer-qmi.c b/src/mm-bearer-qmi.c > index 4d532274..c687db60 100644 > --- a/src/mm-bearer-qmi.c > +++

<    1   2   3   4   5   6   7   8   9   10   >