Re: AIM/mp2 Apache::compat bug?

2004-11-29 Thread Stas Bekman
Geoffrey Young wrote: what _does_ need to happen, though, is for Apache::compat to redefine filename() so that it behaves like mp1 did. I just don't have the tuits at the moment. Right, but there are issues with doing that: 1) that should probably be overridable and not loaded by default: http://

Re: AIM/mp2 Apache::compat bug?

2004-11-26 Thread Geoffrey Young
>> what _does_ need to happen, though, is for Apache::compat to redefine >> filename() so that it behaves like mp1 did. I just don't have the >> tuits at >> the moment. > > > Right, but there are issues with doing that: > > 1) that should probably be overridable and not loaded by default: > ht

Re: AIM/mp2 Apache::compat bug?

2004-11-24 Thread Stas Bekman
Geoffrey Young wrote: I'd like the option argument, because I'm sure people will run into this many times. well, as we're starting to discuss over on dev@, since you commented here, let's just finish it here rather than speading it all over. I'm not really in favor of an optional argument. if y

Re: AIM/mp2 Apache::compat bug?

2004-11-24 Thread Geoffrey Young
>> > I'd like the option argument, because I'm sure people will run into this > many times. well, as we're starting to discuss over on dev@, I'm not really in favor of an optional argument. if you know that you need to pass the additional argument, then you know enough to make the APR::Finfo::sta

Re: AIM/mp2 Apache::compat bug?

2004-11-24 Thread Tom Schindl
Stas Bekman wrote: That's really a question to httpd developers, mod_perl just provides the perl API for the Apache C API. Granted we could do that behind the scenes, but it's not always the desired behavior so I'm not sure we should. May be an option argument could be passed to do the work?

Re: AIM/mp2 Apache::compat bug?

2004-11-23 Thread Stas Bekman
Malcolm J Harwood wrote: On Tuesday 23 November 2004 11:56 am, Stas Bekman wrote: with mp2 you need to update the stat info yourself each time you update $r->filename. something like this: $r->filename($newfile); $r->finfo(APR::Finfo::stat($newfile, APR::FINFO_NORM, $r->pool)); I've updated the d

Re: AIM/mp2 Apache::compat bug?

2004-11-23 Thread Geoffrey Young
Malcolm J Harwood wrote: > On Tuesday 23 November 2004 11:56 am, Stas Bekman wrote: > > with mp2 you need to update the stat info yourself each time you update $r->filename. something like this: $r->filename($newfile); $r->finfo(APR::Finfo::stat($newfile, APR::FINFO_NORM,

Re: AIM/mp2 Apache::compat bug?

2004-11-23 Thread Malcolm J Harwood
On Tuesday 23 November 2004 11:56 am, Stas Bekman wrote: > >> with mp2 you need to update the stat info yourself each time you update > >> $r->filename. something like this: > >> > >> $r->filename($newfile); > >> $r->finfo(APR::Finfo::stat($newfile, APR::FINFO_NORM, $r->pool)); > I've updated t

Re: AIM/mp2 Apache::compat bug?

2004-11-23 Thread Stas Bekman
RobertCZ wrote: [...] with mp2 you need to update the stat info yourself each time you update $r->filename. something like this: $r->filename($newfile); $r->finfo(APR::Finfo::stat($newfile, APR::FINFO_NORM, $r->pool)); Yes, you're answering exactly the question I was trying to ask ;-) Thank a

Re: AIM/mp2 Apache::compat bug?

2004-11-23 Thread Geoffrey Young
RobertCZ wrote: > RobertCZ wrote: > >> I'm playing with Apache::ImageMagick under mod_perl 2 and >> Apache::compat (mainly because AIM needs Apache::File which is not >> supported under mp2). AIM/mp2 returns the correct modified file but >> with wrong file size (size of the original file, not th

Re: AIM/mp2 Apache::compat bug?

2004-11-23 Thread RobertCZ
RobertCZ wrote: I'm playing with Apache::ImageMagick under mod_perl 2 and Apache::compat (mainly because AIM needs Apache::File which is not supported under mp2). AIM/mp2 returns the correct modified file but with wrong file size (size of the original file, not the modified one). It does work u