[Mscore-developer] While we're on the subject of SVG issues...

2016-04-22 Thread Sideways Skullfinger
https://musescore.org/en/node/100781 This is a less clear-cut issue raised initially by @lasconic a few months ago. I posted the forum topic above in order to gain consensus before attempting a fix. Not much of a response on the website, so I'm mentioning it here to see if there can be agreem

Re: [Mscore-developer] SysStaff::distanceUp() and ::distanceDown() gone for good?

2016-04-22 Thread Sideways Skullfinger
Using text diff for SVG test cases is an excellent idea. Fully automatable if you're into that. That's a lot of stuff out there in the vtests directory. If the PNG tests cover all the different types of graphical elements then that's a good start. I think the main thing to check is that all

Re: [Mscore-developer] SysStaff::distanceUp() and ::distanceDown() gone for good?

2016-04-22 Thread Sideways Skullfinger
The personal sense of urgency is my own code, not merged with the master, that suddenly didn't compile because of the upgrades I was forced to make due to circumstances beyond my control. Absolutely nothing to do with the current master itself. I have an SVG animation project that uses MuseSc

Re: [Mscore-developer] SysStaff::distanceUp() and ::distanceDown() gone for good?

2016-04-22 Thread Marc Sabatella
Sorry if my response came off as critical - it was not meant that way. You wrote of your "personal sense of urgency about this question (and possibly future questions)", which I interpreted to mean, you were anticipating needing to make further changes in the near future and realized you wouldn't

Re: [Mscore-developer] What to tackle? Questions regarding implode, built-in tools, plugins

2016-04-22 Thread freixas
Hi, Marc, I thought I might hear from you... Sure, I'll start a discussion elsewhere. I can clear up the empty measure confusion. I am not imploding empty measures and expecting content. I am imploding measures in which voice 1 in the top staff is empty and the other voices (or staffs) are not.

Re: [Mscore-developer] SysStaff::distanceUp() and ::distanceDown() gone for good?

2016-04-22 Thread Lasconic
All the SVG fixes I'm aware of are already merged in the 2.0.4 branch. We don't have any SVG tests suite, but it's a good idea, we could modify the vtests to render SVG too (or instead of PNG?) (If you don't know what the vtests are, check the vtests directory and http://vtest.musescore.org/index.

Re: [Mscore-developer] SysStaff::distanceUp() and ::distanceDown() gone for good?

2016-04-22 Thread Sideways Skullfinger
Predicting future SVG Export issues is not an easy task. The recent spate of fixes were simply regression tests that had not taken place until recently. If there is a set of SVG test cases, these newly fixed issues should be added. If you have other features that you want to make sure functi

Re: [Mscore-developer] SysStaff::distanceUp() and ::distanceDown() gone for good?

2016-04-22 Thread Marc Sabatella
Well, I was thinking of https://musescore.org/en/node/105436, https://musescore.org/en/node/105471, and https://musescore.org/en/node/107081, which I guess are already fixed for 2.0.4 branch. I guess maybe the last of these is the same as https://musescore.org/en/node/107126, but if not, then that

Re: [Mscore-developer] What to tackle? Questions regarding implode, built-in tools, plugins

2016-04-22 Thread Marc Sabatella
As the author of the implode tool, I can address some of this: Implode is internal for several reasons. It was originally a plugin (which I also wrote), but a) the framework was too limited at the time (might be better now?) to do a good job of it, and b) having it only as a plugin means it is on

Re: [Mscore-developer] SysStaff::distanceUp() and ::distanceDown() gone for good?

2016-04-22 Thread Lasconic
Which issues are you talking about in particular? lasconic 2016-04-22 19:09 GMT+02:00 Marc Sabatella : > I seems like many of these issues are serious enough to want fixed on the > 2.0.4 branch, so maybe focus first on building, developing, and testinh > there? Then worry about restructuring for

Re: [Mscore-developer] SysStaff::distanceUp() and ::distanceDown() gone for good?

2016-04-22 Thread Marc Sabatella
I seems like many of these issues are serious enough to want fixed on the 2.0.4 branch, so maybe focus first on building, developing, and testinh there? Then worry about restructuring for master later? Unless werner or lasconic advise otherwise... On Fri, Apr 22, 2016 at 10:26 AM Sideways Skullfing

[Mscore-developer] What to tackle? Questions regarding implode, built-in tools, plugins

2016-04-22 Thread freixas
I just managed to clone, compile and run MuseScore on my PC. So I'm ready to start contributing, right? My initial thought was to tackle something simple: like "Implode". In looking into Implode, it seems like it's just one of many potential algorithm for combining multiple voices (or staves) in

Re: [Mscore-developer] SysStaff::distanceUp() and ::distanceDown() gone for good?

2016-04-22 Thread Sideways Skullfinger
Thank you for the detailed information. I'll be changing my code today. Like Michael Corleone, "Just when I thought I was out... they pull me back in." I was very comfortable in my Qt 5.4 environment, but exactly 1 day before the master switched to 5.6, I was notified of some issues with cod

Re: [Mscore-developer] SysStaff::distanceUp() and ::distanceDown() gone for good?

2016-04-22 Thread Werner Schweer
_distanceUp and _distanceDown are gone and will not come back. The staff distance is now calculated in System->layout2() and the system distance in Score->collectPage() which calls layoutPage(). The distance between systems can be determined by looking at system->pos().y(). SysStaff->_distanceUp