Version 4 of my patch to add DSF support to the DSDIFF
decoder plugin.
This time I have taken a different approach and created a new
read_metadata function specific for reading DSF files. This saves an
indent (and for me a lot of indent nightmares) and also useful for
splitting the DSF and DFF dec
At 2012-04-25 00:03:00 +0200, Jonathan Neuschäfer wrote:
> On Mon, Apr 23, 2012 at 07:16:49PM +0200, Jurgen Kramer wrote:
> > Please show me how I can check myself. It is getting a bit tiresome to
> > hear about wrong tabs/indents.
> >
> > Jurgen
>
> If you use Vim, this little snippet will highl
On Mon, Apr 23, 2012 at 07:16:49PM +0200, Jurgen Kramer wrote:
> Please show me how I can check myself. It is getting a bit tiresome to
> hear about wrong tabs/indents.
>
> Jurgen
If you use Vim, this little snippet will highlight all trailing white
space:
> au Syntax *
> \ syn match Extra
Attached patch is a *pre* version of v4 of the patch to add support for
DSF files. Fixing the white space warnings was fairly easy after
switching editors and using the supplied git commands.
I changed the struct comments, hopefully now correct (modeled after a
version of a supported doxygen style
On 2012/04/21 13:29, Jurgen Kramer wrote:
> - Adhered to max 80 colom width
This is not doxygen syntax, and is barely readable. Please use
doxygen syntax for documenting struct attributes.
> - Fixed indents (hopefully correctly)
What did you fix? Indentation dsdiff_read_metadata() is still al
On Mon, 2012-04-23 at 19:09 +0200, Max Kellermann wrote:
> On 2012/04/21 13:29, Jurgen Kramer wrote:
> > - Adhered to max 80 colom width
>
> This is not doxygen syntax, and is barely readable. Please use
> doxygen syntax for documenting struct attributes.
>
> > - Fixed indents (hopefully correc
On 2012/04/21 19:21, Jonathan Neuschäfer wrote:
> On Sat, Apr 21, 2012 at 01:29:37PM +0200, Jurgen Kramer wrote:
> > +struct dsdiff_header_dsf {
> > + struct dsdiff_id id;/* "DSD " */
> > + uint32_t size_low, size_high; /* DSD chunk size, including id = 28 */
> > + uint32_t fsi
On Sat, Apr 21, 2012 at 01:29:37PM +0200, Jurgen Kramer wrote:
> +struct dsdiff_header_dsf {
> + struct dsdiff_id id;/* "DSD " */
> + uint32_t size_low, size_high; /* DSD chunk size, including id = 28 */
> + uint32_t fsize_low, fsize_high; /* Total file size */
> + uin
Attached is version 3 of the patch which adds support for
DSF files to the DSDIFF decoder. It can be used in
conjunction with DSD2PCM and DSD-over-USB.
This version should address the concerns with v2.
Changes from v2 patch:
- Adhered to max 80 colom width
- Fixed indents (hopefully correctly)
-
On 2012/04/19 19:49, Jurgen Kramer wrote:
> struct dsdiff_metadata {
> unsigned sample_rate, channels;
> + bool fileisdff;
> + uint32_t bitreverse;
This should be a bool, uint32_t is an odd choice.
> + uint64_t chunk_size;
> };
>
> static bool lsbitfirst;
>
> +struct dsd
Attached is version 2 of the patch which adds support for
DSF files to the DSDIFF decoder. It can be used in
conjunction with DSD2PCM and DSD-over-USB.
Changes from v1 patch:
- Removed currently unused variables
- Removed warning messages
- Included update to doc/user.xml
As agreed upon with Max
On 2012/04/19 17:50, Jurgen Kramer wrote:
> Alright, can you live with a 2 step approach?
> 1. Start with adding DSF to current DSDIFF decoder
> 2. Create common library for DSF and DSDIFF and update DSDIFF decoder to
> use it.
Yes.
---
On Thu, 2012-04-19 at 17:49 +0200, Max Kellermann wrote:
> On 2012/04/19 17:41, Jurgen Kramer wrote:
> > I do not mind putting DSF file format support in a separate decoder
> > plugin. Having two separate decoders would probably yield better
> > readable and therefore better maintainable code.
> >
On 2012/04/19 17:41, Jurgen Kramer wrote:
> I do not mind putting DSF file format support in a separate decoder
> plugin. Having two separate decoders would probably yield better
> readable and therefore better maintainable code.
>
> On the other hand it would mean a bit of duplicated code and ef
On Thu, 2012-04-19 at 01:21 +0200, Max Kellermann wrote:
> On 2012/04/14 17:05, Jurgen Kramer wrote:
> > Attached patch adds support for DSF files to the DSDIFF decoder. It can
> > be used in conjunction with DSD2PCM and DSD-over-USB.
>
> This looks like this supports a different file format and
On 2012/04/14 17:05, Jurgen Kramer wrote:
> Attached patch adds support for DSF files to the DSDIFF decoder. It can
> be used in conjunction with DSD2PCM and DSD-over-USB.
This looks like this supports a different file format and should live
in another decoder plugin. Is there an advantage in im
Attached patch adds support for DSF files to the DSDIFF decoder. It can
be used in conjunction with DSD2PCM and DSD-over-USB.
Further planned enhancements:
- song time for both DSF and DFF files
- Implement rewind/fast forward
- Add support for DSF native tags and ID3 tags
To test this with an re
17 matches
Mail list logo
