[Musicpd-dev-team] icy support for httpd output

2009-04-06 Thread Hagen Schink
Hello, I attached a first proposal for a patch that adds icy metadata support for mpds httpd output. Here are some explanations on how the patch works: httpd_output_plugin.c - httpd_output_tag(): builds an icy metadata string and sends a struct page to the clients httpd_client.c -

Re: [Musicpd-dev-team] icy support for httpd output

2009-04-06 Thread Max Kellermann
Keep the mailing list on Cc, so others can participate in the discussion. On 2009/04/06 13:49, Hagen Schink hagen.sch...@st.ovgu.de wrote: On Mon, 6 Apr 2009 11:44:51 +0200 Max Kellermann m...@duempel.org wrote: Here's some criticism about formal stuff: - tab width is 8 characters.

Re: [Musicpd-dev-team] icy support for httpd output

2009-04-06 Thread Max Kellermann
On 2009/04/06 10:29, Hagen Schink hagen.sch...@st.ovgu.de wrote: I attached a first proposal for a patch that adds icy metadata support for mpds httpd output. Hello Hagen, I had a first glance at your patch. This seriously looks like a bunch of good work! I havn't tested your code yet, I