On 2009/04/06 10:29, Hagen Schink <hagen.sch...@st.ovgu.de> wrote: > I attached a first proposal for a patch that adds icy metadata > support for mpds httpd output.
Hello Hagen, I had a first glance at your patch. This seriously looks like a bunch of good work! I havn't tested your code yet, I will send a detailed review later. Here's some criticism about formal stuff: - tab width is 8 characters. Looks like your editor assumes a non-standard '4' which breaks indentation - watch out for whitespace-only changes, and spaces at the end of a line - do you think it's possible to move the icy-metadata specific code to a separate library? This would simplify testing, because we could run your code in an isolated (unit test) program, without all the httpd stuff. See http://git.musicpd.org/account-policy.html if you want to publish your work on our git server. Max ------------------------------------------------------------------------------ _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
