Keep the mailing list on Cc, so others can participate in the discussion. On 2009/04/06 13:49, Hagen Schink <hagen.sch...@st.ovgu.de> wrote: > On Mon, 6 Apr 2009 11:44:51 +0200 > Max Kellermann <m...@duempel.org> wrote: > > > Here's some criticism about formal stuff: > > > > - tab width is 8 characters. Looks like your editor assumes a > > non-standard '4' which breaks indentation > > > > - watch out for whitespace-only changes, and spaces at the end of a > > line > > Ok, I'll change that immediately. > > > - do you think it's possible to move the icy-metadata specific code to > > a separate library? This would simplify testing, because we could > > run your code in an isolated (unit test) program, without all the > > httpd stuff. > > First, I'm not sure if I understand you right. I guess you don't mean an > extra libtool-ish library but extra source files, right? (It wouldn't be a > problem though.) > > I think extra src/output/icy_metadata_output source files are a good place (I > guess src/icy_metadata.[c|h] is not a suitable place for the server side icy > protocol) for some functions like: > > - icy_server_metadata_header(...) --> returns the a string containing the icy > header > - icy_server_metadata_string(...) --> returns an icy string with the tag > information > > convenience: > - icy_server_metadata_page(...) --> a more mpd specific function which gets > tags and returns a page containing the icy string
Yes, that's exactly what I had in mind. Put that source in ./src/, not ./src/output/, because it's a generic library. It should not include httpd_internal.h. > > Other ideas are very welcome! :) > > > See http://git.musicpd.org/account-policy.html if you want to publish > > your work on our git server. > > I'll come back to that later. > > Hagen ------------------------------------------------------------------------------ _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
