Re: [Musicpd-dev-team] New event loop implementation

2014-01-04 Thread Max Kellermann
On 2013/12/02 11:12, Denis Krjuchkov de...@crazydev.net wrote: I've added poll based PollGroup implementation: http://git.musicpd.org/cgit/dk/mpd.git/commit/?id=1df426aa5c571d3d88ecb7bed6b8ed9b32c15e32 After quick testing connecting with client and playing http streams work, however I

Re: [Musicpd-dev-team] New event loop implementation

2013-12-02 Thread Max Kellermann
On 2013/12/02 11:12, Denis Krjuchkov de...@crazydev.net wrote: I've added poll based PollGroup implementation: http://git.musicpd.org/cgit/dk/mpd.git/commit/?id=1df426aa5c571d3d88ecb7bed6b8ed9b32c15e32 After quick testing connecting with client and playing http streams work, however I

Re: [Musicpd-dev-team] New event loop implementation

2013-11-29 Thread Denis Krjuchkov
I've added Windows select backend for event loop as well as few fixes. PollGroupEPoll.hxx: add const modifiers where applicable Clock.cxx: provide all arguments for GetProcessTimes event: implement PollGroup based on Windows select configure.ac: code style improvements New backend is enabled by

Re: [Musicpd-dev-team] New event loop implementation

2013-11-29 Thread Max Kellermann
On 2013/11/29 10:40, Denis Krjuchkov de...@crazydev.net wrote: I've added Windows select backend for event loop as well as few fixes. Merged. I like how well the incremental way of doing this works. When you've added the portable poll() implementation, we'll test it, and then we will

Re: [Musicpd-dev-team] New event loop implementation

2013-11-29 Thread Denis Krjuchkov
29.11.2013 16:00, Max Kellermann пишет: Merged. I like how well the incremental way of doing this works. When you've added the portable poll() implementation, we'll test it, and then we will eventually remove the GLib code. Hi Max, I appreciate your help in developing this. I'm wondering

Re: [Musicpd-dev-team] New event loop implementation

2013-11-29 Thread Max Kellermann
On 2013/11/29 19:18, Denis Krjuchkov de...@crazydev.net wrote: I'm wondering is there any plan for GLib removal in particular and tasks for new version in general? No, there is no grand plan. Things just happen whenever somebody chooses to spend time on the code ;-) There are quite a few

Re: [Musicpd-dev-team] New event loop implementation

2013-11-29 Thread Denis Krjuchkov
30.11.2013 0:27, Max Kellermann пишет: No, there is no grand plan. Things just happen whenever somebody chooses to spend time on the code ;-) I didn't mean plan as a schedule for any specific version. I meant plan as a list of tasks that anybody could pick and implement if they want to

Re: [Musicpd-dev-team] New event loop implementation

2013-11-28 Thread Max Kellermann
On 2013/11/28 16:30, Denis Krjuchkov de...@crazydev.net wrote: I've added one more patch. This introduces generic poll API as well as implementation for epoll. Merged. -- Rapidly troubleshoot problems before they

Re: [Musicpd-dev-team] New event loop implementation

2013-11-27 Thread Denis Krjuchkov
I've made a helper patch for simplifying futher work. It adds various configuration options to simplify dealting with different event loop implementations. Here it is: http://git.musicpd.org/cgit/dk/mpd.git/commit/?id=46bab7e4b921b79924643bacd08dcd3d1404ceb6 Also during testing I've found

Re: [Musicpd-dev-team] New event loop implementation

2013-11-27 Thread Denis Krjuchkov
27.11.2013 19:00, Max Kellermann пишет: That's not perfect but ok, because ALSA is Linux specific, and on Linux we always have epoll (there's no reason not to use it). OK. Do you have any comments on the patch itself? -- Denis

Re: [Musicpd-dev-team] New event loop implementation

2013-11-27 Thread Max Kellermann
On 2013/11/27 14:18, Denis Krjuchkov de...@crazydev.net wrote: OK. Do you have any comments on the patch itself? Just read it merged. Looks excellent! -- Rapidly troubleshoot problems before they affect your business.

Re: [Musicpd-dev-team] New event loop implementation

2013-11-24 Thread Max Kellermann
On 2013/11/19 13:12, Denis Krjuchkov de...@crazydev.net wrote: I'm trying to implement new event loop for MPD without GLib (or any other library). It's borrowed from existing epoll-based event loop. I only abstracted API differences behind general inteface (PollGroup class). Currently there

Re: [Musicpd-dev-team] New event loop implementation

2013-11-24 Thread Denis Krjuchkov
24.11.2013 21:06, Max Kellermann пишет: My few cents: Thanks for the comments! - you reordered code in event/Loop.cxx, which makes reading the diff more difficult than necessary That's my fault, probably I was addicted to Add/Modify/Remove trio in every class :-) - the