On Thu, 9 Jun 2022 11:51:13 GMT, Conor Cleary wrote:
>> test/jdk/java/net/httpclient/ExpectContinueTest.java line 264:
>>
>>> 262:
>>> 263: HttpRequest getRequest = HttpRequest.newBuilder(getUri)
>>> 264: .GET()
>>
>> Is this missing an `.expectContinue(true)` here?
>
On Thu, 9 Jun 2022 11:27:47 GMT, Conor Cleary wrote:
>> **Issue**
>> It was observed that when the httpclient sends a POST request with the
>> `Expect: 100 Continue` header set and the server replies with a response
>> code `417 Expectation Failed` that the httpclient hangs indefinitely when
On Thu, 9 Jun 2022 11:27:19 GMT, Daniel Fuchs wrote:
> We need to close the stream after the exchange has terminated, but the
> exchange will not be considered to be terminated if we have a request body
> and the request body has not been sent.
That answers it. Thank you.
-
PR:
On Thu, 9 Jun 2022 11:15:14 GMT, Jaikiran Pai wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8286171: Added teardown method and comments
>
> src/java.net.http/share/classes/jdk/inte
On Thu, 9 Jun 2022 11:23:21 GMT, Conor Cleary wrote:
>> **Issue**
>> It was observed that when the httpclient sends a POST request with the
>> `Expect: 100 Continue` header set and the server replies with a response
>> code `417 Expectation Failed` that the httpclient hangs indefinitely when
On Thu, 9 Jun 2022 11:19:04 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http1Exchange.java
>> line 862:
>>
>>> 860: // Sets a flag which closes the connection locally when
>>> 861: // onFinished() is called
>>> 862:
On Thu, 9 Jun 2022 10:31:31 GMT, Conor Cleary wrote:
>> **Issue**
>> It was observed that when the httpclient sends a POST request with the
>> `Expect: 100 Continue` header set and the server replies with a response
>> code `417 Expectation Failed` that the httpclient hangs indefinitely when
On Thu, 9 Jun 2022 10:31:31 GMT, Conor Cleary wrote:
>> **Issue**
>> It was observed that when the httpclient sends a POST request with the
>> `Expect: 100 Continue` header set and the server replies with a response
>> code `417 Expectation Failed` that the httpclient hangs indefinitely when
On Mon, 6 Jun 2022 09:43:50 GMT, Jaikiran Pai wrote:
> tier1, tier2 and tier3 tests have passed without issues.
Additionally, the reproducer attached to the JBS issue has been run locally.
The test fails regularly without this change and hasn't failed even once after
this cha
Can I please get a review of this change which proposes to fix
https://bugs.openjdk.java.net/browse/JDK-8276798?
`sun.net.www.protocol.http.HttpURLConnection` has a (private) `writeRequests`
method. This method is responsible for creating the standard HTTP request
headers (include the request
On Wed, 1 Jun 2022 13:27:27 GMT, Andrey Turbanov wrote:
>> src/java.base/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java
>> line 159:
>>
>>> 157: if (t == null || t == c) {
>>> 158: assert cached == null;
>>> 159: return cached;
>>
On Wed, 1 Jun 2022 13:32:28 GMT, Andrey Turbanov wrote:
>> `AuthenticationInfo.requestAuthentication` uses separate `HashMap`'s `get`
>> +`put` calls.
>>
>>
On Sat, 30 Apr 2022 10:17:43 GMT, Andrey Turbanov wrote:
> `AuthenticationInfo.requestAuthentication` uses separate `HashMap`'s `get`
> +`put` calls.
>
>
On Thu, 26 May 2022 07:17:12 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.java.net/browse/JDK-8287318?
>
> The `ServerImpl` has a `Dispatcher` thread which uses a `Selector` to select
> key
On Tue, 31 May 2022 15:14:22 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which addresses the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8287318?
>>
>> The `ServerImpl` has a `Dispatcher` thread which uses a `Selector` to selec
On Tue, 31 May 2022 18:29:30 GMT, Brian Burkhalter wrote:
>> Modify `sun.net.www.MimeTable.findByFileName(String)` to attempt to find the
>> file extension in the entire file name if it is not found in the portion of
>> the name preceding the optional fragment beginning with a hash (`#`).
>
>
On Tue, 31 May 2022 14:51:48 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use Collection.toArray(...) instead of creating a copy of the collection
>
> src/jdk.ht
act on the Set that is being iterated upon.
>
> No new tests have been added given the intermittent nature of this issue.
> Existing tier1, tier2 and tier3 tests passed without any related failures,
> after this change.
Jaikiran Pai has updated the pull request incrementally with
On Fri, 27 May 2022 19:09:05 GMT, Brian Burkhalter wrote:
>> Modify `sun.net.www.MimeTable.findByFileName(String)` to attempt to find the
>> file extension in the entire file name if it is not found in the portion of
>> the name preceding the optional fragment beginning with a hash (`#`).
>
>
On Thu, 26 May 2022 23:03:05 GMT, Brian Burkhalter wrote:
> Modify `sun.net.www.MimeTable.findByFileName(String)` to attempt to find the
> file extension in the entire file name if it is not found in the portion of
> the name preceding the optional fragment beginning with a hash (`#`).
On Thu, 26 May 2022 23:03:05 GMT, Brian Burkhalter wrote:
> Modify `sun.net.www.MimeTable.findByFileName(String)` to attempt to find the
> file extension in the entire file name if it is not found in the portion of
> the name preceding the optional fragment beginning with a hash (`#`).
On Sun, 22 May 2022 08:20:21 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8287104?
>
> The change in this commit now uses an `InnocuousThread` to create a thread
> with `null` context classloader
instead of the usual system wide auto-generated
> name.
>
> No new tests have been added for this change. Existing tier1, tier2 and tier3
> tests have been run and no related failures have been noticed.
Jaikiran Pai has updated the pull request incrementally with one additional
commit
On Sun, 22 May 2022 08:20:21 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8287104?
>
> The change in this commit now uses an `InnocuousThread` to create a thread
> with `null` context classloader
instead of the usual system wide auto-generated
> name.
>
> No new tests have been added for this change. Existing tier1, tier2 and tier3
> tests have been run and no related failures have been noticed.
Jaikiran Pai has updated the pull request incrementally with one additional
commit s
Can I please get a review of this change which addresses
https://bugs.openjdk.java.net/browse/JDK-8287104?
The change in this commit now uses an `InnocuousThread` to create a thread with
`null` context classloader. The `Runnable` task of this thread just invokes a
native method through JNI to
On Mon, 16 May 2022 08:59:43 GMT, Conor Cleary wrote:
>> **Issue**
>> When using the `HttpClient.send()` to send a GET request created using the
>> `HttpRequest.newBuilder()`, a `Content-length: 0` header is set. This
>> behaviour causes issues with many services as a body related header is
On Fri, 3 Dec 2021 06:15:31 GMT, Jaikiran Pai wrote:
> This change proposes to implement the enhancement noted in
> https://bugs.openjdk.java.net/browse/JDK-8209137.
>
> The change introduces a new API to allow applications to build a
> `java.net.http.HTTPClient` configured
On Sun, 15 May 2022 06:43:27 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.n
On Sun, 15 May 2022 06:43:27 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.n
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
Use the byte[] address form for testing the client address instead of relying
on hostname which
doesn't always return localhost for 12
On Thu, 12 May 2022 12:01:23 GMT, Conor Cleary wrote:
> Will await further review for a short while and then integrate if approved.
Hello Conor, looking at the latest state of the PR, I think you might have
missed Daniel's review comment
On Tue, 10 May 2022 13:51:37 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.n
On Wed, 11 May 2022 08:12:12 GMT, Michael McMahon wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix javadoc link in test
>
> src/java.net.http/share/classes/java/net/http/HttpC
On Tue, 10 May 2022 13:35:35 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Daniel's review suggestion - add a test to verify the behaviour of the
>>
On Tue, 10 May 2022 12:37:47 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.n
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
fix javadoc link in test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/6690/files
- new: https://git.openjdk.java.net/j
On Mon, 9 May 2022 13:31:38 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge latest from master branch
>> - add a @build to force
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request incrementally with two additional
commits since the last revision:
- Daniel's review suggestion - add a test to verify the behaviour of the
localAddress() default method implementation on HttpClient.Builder
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 37 commits:
- Merge latest from master branch
- add a @build to force jtreg to show consistent test results and add the
re
On Fri, 6 May 2022 09:14:53 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java
>> line 1039:
>>
>>> 1037: e.abort(selectorClosedException());
>>> 1038: } else {
>>> 1039: selector.wakeup();
>>
>>
On Fri, 6 May 2022 09:38:38 GMT, Daniel Fuchs wrote:
>> Hi, please find here a patch that solves a rare intermittent test failure
>> observed in the test `java/net/httpclient/ExecutorShutdown.java`
>>
>> A race condition coupled with some too eager synchronization was causing a
>> deadlock
On Thu, 5 May 2022 19:03:13 GMT, Daniel Fuchs wrote:
> Hi, please find here a patch that solves a rare intermittent test failure
> observed in the test `java/net/httpclient/ExecutorShutdown.java`
>
> A race condition coupled with some too eager synchronization was causing a
> deadlock between
On Thu, 5 May 2022 19:03:13 GMT, Daniel Fuchs wrote:
> Hi, please find here a patch that solves a rare intermittent test failure
> observed in the test `java/net/httpclient/ExecutorShutdown.java`
>
> A race condition coupled with some too eager synchronization was causing a
> deadlock between
On Thu, 5 May 2022 19:03:13 GMT, Daniel Fuchs wrote:
> Hi, please find here a patch that solves a rare intermittent test failure
> observed in the test `java/net/httpclient/ExecutorShutdown.java`
>
> A race condition coupled with some too eager synchronization was causing a
> deadlock between
On Thu, 5 May 2022 19:03:13 GMT, Daniel Fuchs wrote:
> Hi, please find here a patch that solves a rare intermittent test failure
> observed in the test `java/net/httpclient/ExecutorShutdown.java`
>
> A race condition coupled with some too eager synchronization was causing a
> deadlock between
On Fri, 29 Apr 2022 12:11:27 GMT, Michael Felt wrote:
>> Good catch!
>
> too much Python (no semi-colons) - great catch.
>
> Looking into how to verify proposed changes using jenkins (adoptium). When
> not in aqa-tests, more difficult (for me) too get it tested. (aka Better next
> time).
On Tue, 26 Apr 2022 00:27:43 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8285504
>>
>> JDK-8273046 is the umbrella bug for this bug. The changes were too large for
>> a single code review, so it was decided to split into smaller chunks. This
>> is one such chunk:
>>
On Thu, 14 Apr 2022 18:45:10 GMT, Daniel Fuchs wrote:
>> java/net/httpclient/http2/TLSConnection.java has been observed failing (even
>> though rarely) in test jobs.
>>
>> The issue is that the handler used on the the server sides maintains a
>> volatile `sslSession` field which it sets when
On Mon, 4 Apr 2022 09:53:02 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.n
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request incrementally with two additional
commits since the last revision:
- Implement HttpServerAdapters in test as suggested by Daniel
- fix check when security manager is enabled
-
Chang
On Fri, 8 Apr 2022 09:35:31 GMT, Jaikiran Pai wrote:
> This is unlike other methods, for example DELETE() where the body publisher
> itself is null. In the case of HEAD the body publisher is present but it
> still represents that there's no body to that request.
Please disregard
On Thu, 7 Apr 2022 13:53:35 GMT, Conor Cleary wrote:
>> **Issue**
>> When using the `HttpClient.send()` to send a GET request created using the
>> `HttpRequest.newBuilder()`, a `Content-length: 0` header is set. This
>> behaviour causes issues with many services as a body related header is
>>
On Mon, 4 Apr 2022 09:52:56 GMT, Jaikiran Pai wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientBuilderImpl.java
>> line 140:
>>
>>> 138: return this;
>>> 139: }
>>> 140:
>>
>> Either
On Mon, 28 Mar 2022 21:44:36 GMT, Aleksei Efimov wrote:
> The following fix seals `sun.net.dns.ResolverConfiguration` abstract class.
> `sun.net.dns.ResolverConfigurationImpl` is the only permitted subclass which
> has two O/S specific implementations: for `Windows` and `Unix` architectures.
>
On Tue, 15 Feb 2022 15:33:01 GMT, Conor Cleary wrote:
>> As described in the title, this is a simple change to the
>> `HttpRequest.Builder::build` method to highlight that an immutable and
>> reusable instance of an `HttpRequest` is created when this method is
>> invoked. This is done by
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 28 additional commits since the
last revision:
-
On Wed, 16 Mar 2022 17:47:15 GMT, Aleksei Efimov wrote:
>> Thanks for noticing that Jaikiran!
>>
>> Both `ipv4_available()` and `ipv6_available()` are defined to return `jint`
>> so the implementation in `Java_java_net_InetAddress_isIPv6Supported` is
>> arguably the more correct (provided
On Wed, 16 Mar 2022 17:51:17 GMT, Aleksei Efimov wrote:
>> Hi,
>>
>> This cleanup change removes `InetAddressImplFactory` class from
>> `InetAddress`. The list of changes:
>> - Remove `InetAddressImplFactory` from `InetAddress`
>> - Since `isIPv6Supported` native code is identical for Windows
On Wed, 16 Mar 2022 13:26:36 GMT, Aleksei Efimov wrote:
> Hi,
>
> This cleanup change removes `InetAddressImplFactory` class from
> `InetAddress`. The list of changes:
> - Remove `InetAddressImplFactory` from `InetAddress`
> - Since `isIPv6Supported` native code is identical for Windows and
On Wed, 16 Mar 2022 13:26:36 GMT, Aleksei Efimov wrote:
> Hi,
>
> This cleanup change removes `InetAddressImplFactory` class from
> `InetAddress`. The list of changes:
> - Remove `InetAddressImplFactory` from `InetAddress`
> - Since `isIPv6Supported` native code is identical for Windows and
On Fri, 11 Mar 2022 16:47:46 GMT, Aleksei Efimov wrote:
> The following fix seals the `java.net.InetAddress` class and permits only two
> implementations - `java.net.Inet4Address` and `java.net.Inet6Address`.
>
> No issues have been detected by regression and JCK tests.
>
> Links:
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote:
>> Please find enclosed a patch that solves an intermittent issue detected by
>> the CancelRequestTest.java
>>
>> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled
>> after the Http2Connection has been created,
On Thu, 10 Mar 2022 11:17:26 GMT, Daniel Fuchs wrote:
>> These changes make sure that pending requests are terminated if the selector
>> manager thread exits due to exceptions.
>> This includes:
>>1. completing CompletableFutures that were returned to the caller code
>>2. cancelling
On Fri, 11 Mar 2022 10:07:21 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java
>> line 162:
>>
>>> 160:
>>> 161: String key = c.key();
>>> 162: synchronized(this) {
>>
>> Hello Daniel, it's not fully clear to me why this
On Fri, 11 Mar 2022 10:12:46 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java
>> line 170:
>>
>>> 168: Http2Connection c1 = connections.putIfAbsent(key, c);
>>> 169: if (c1 != null) {
>>> 170:
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote:
>> Please find enclosed a patch that solves an intermittent issue detected by
>> the CancelRequestTest.java
>>
>> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled
>> after the Http2Connection has been created,
On Thu, 10 Mar 2022 17:05:32 GMT, Daniel Fuchs wrote:
>> Please find enclosed a patch that solves an intermittent issue detected by
>> the CancelRequestTest.java
>>
>> If during an HTTP upgrade from HTTP/1.1 to HTTP/2, the request is cancelled
>> after the Http2Connection has been created,
On Thu, 10 Mar 2022 10:41:23 GMT, Daniel Fuchs wrote:
> The acquire() method will return true the first time it's been called. And it
> is called only once. So we only need to check whether acquired is true at
> places where we are in doubt about whether the method has been called.
I see what
On Wed, 9 Mar 2022 16:54:58 GMT, Daniel Fuchs wrote:
>> These changes make sure that pending requests are terminated if the selector
>> manager thread exits due to exceptions.
>> This includes:
>>1. completing CompletableFutures that were returned to the caller code
>>2. cancelling
On Wed, 9 Mar 2022 12:09:48 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java
>> line 179:
>>
>>> 177: } catch (Throwable t) {
>>> 178: errorHandler.accept(command, t);
>>> 179:
On Wed, 9 Mar 2022 11:55:27 GMT, Daniel Fuchs wrote:
> Here we don't need to check whether it's been acquired because we know it's
> been acquired if we reach here.
Hello Daniel, may be I am misreading the diff but from what I can see, the
`acquire()` method now returns a `boolean` which we
On Mon, 24 Jan 2022 14:25:09 GMT, Daniel Fuchs wrote:
> These changes make sure that pending requests are terminated if the selector
> manager thread exits due to exceptions.
> This includes:
>1. completing CompletableFutures that were returned to the caller code
>2. cancelling requests
On Thu, 3 Mar 2022 16:13:37 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8282617?
>
> The `HttpClient` class uses a `inCache` (internal) field to keep track of
> wheth
On Thu, 3 Mar 2022 16:13:37 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8282617?
>
> The `HttpClient` class uses a `inCache` (internal) field to keep track of
> wheth
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Fri, 4 Mar 2022 14:06:14 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/doc-files/net-properties.html line 227:
>>
>>> 225: name.
>>> 226:
>>> 227:{@systemProperty http.auth.digest.reEnabledAlgs}
>>> (default: none)
>>
>> Hello Michael, from
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
On Fri, 4 Mar 2022 09:37:21 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following change reviewed please, which is to disable the MD5
> message digest algorithm by default in the HTTP Digest authentication
> mechanism? The algorithm can be opted into by setting a new system property
Can I please get a review of this change which proposes to fix the issue noted
in https://bugs.openjdk.java.net/browse/JDK-8282617?
The `HttpClient` class uses a `inCache` (internal) field to keep track of
whether a connection is in the keep-alive cache. This is a mutable field and
when
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 27 additional commits since the
last revision:
-
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 26 additional commits since the
last revision:
-
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 25 additional commits since the
last revision
On Wed, 2 Feb 2022 10:37:54 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor - rename variable in test
>
> src/java.net.http/share/classes/java/net/http/HttpC
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
fix javadoc to mention HttpClient instead of HTTPClient
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/6690/fi
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
minor - rename variable in test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/6690/files
- new: https://git.openjdk
On Tue, 7 Dec 2021 14:28:01 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor - rename variable in test
>
> Generally it would be good if the te
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 22 additional commits since the
last revision:
-
e creating `Socket`(s) for connections.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 21 additional commits since the
last revision:
-
Thank you Julia, these new changes look fine to me.
-Jaikiran
On 13/01/22 9:09 pm, Julia Boes wrote:
On Thu, 13 Jan 2022 04:52:25 GMT, Jaikiran Pai wrote:
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
address PR comments
On Wed, 12 Jan 2022 08:48:12 GMT, Jaikiran Pai wrote:
>> This change proposes to implement the enhancement noted in
>> https://bugs.openjdk.java.net/browse/JDK-8209137.
>>
>> The change introduces a new API to allow applications to build a
>> `java.n
On Fri, 17 Dec 2021 14:52:53 GMT, Jaikiran Pai wrote:
> Can I please get a review for this test only change which proposes to enable
> debug logs from the test that failed intermittently? This change addresses
> https://bugs.openjdk.java.net/browse/JDK-8278961.
>
> The change p
On Fri, 17 Dec 2021 16:35:18 GMT, Daniel Jelinski wrote:
>> Can I please get a review for this test only change which proposes to enable
>> debug logs from the test that failed intermittently? This change addresses
>> https://bugs.openjdk.java.net/browse/JDK-8278961.
>>
>> The change passes
On Wed, 12 Jan 2022 16:59:14 GMT, Julia Boes wrote:
> This new test confirms that the jwebserver does not wait indefinitely for a
> request to arrive, but instead closes the connection when the maximum request
> time is reached. To facilitate this, Exchange::run is amended to process
>
On Wed, 12 Jan 2022 14:22:14 GMT, Daniel Fuchs wrote:
>> test/jdk/java/net/DatagramSocket/SendDatagramToBadAddress.java line 27:
>>
>>> 25: * @test
>>> 26: *
>>> 27: * @bug 4204320 8278961
>>
>> Ah - can you remove 8278961 from the bug list before integrating?
>
> `@bug` is supposed to be
> Got expected exception: java.net.PortUnreachableException
> Got expected exception: java.net.PortUnreachableException
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
fix @bug in test definition and fix copyright year
--
On Mon, 20 Dec 2021 17:36:50 GMT, Mark Sheppard wrote:
>> Right. Looks like `OSsupportsFeature` was used to filter out systems that
>> don't send "port unreachable"; we could probably use it here if the failure
>> turns out to be OS-specific.
>>
>> Additional logs look fine.
>
> as I
1 - 100 of 256 matches
Mail list logo
