Can I make ipv6 module inactive at my pentaval driver?

2006-06-20 Thread SangOg Na
Hi! I'm working for pentamedia in Korea. My company makes one-way satellite receiver card whose name is pentavalue. Pentavalue cards receive DVB-S packets and extract IP packets and push them into TCP/IP stack. pentavalue driver works in linux kernel 2.4.20. I'm porting pentavalue driver to 2.6.1

Re: [PATCH 01/06] MLSXFRM: Granular IPSec associations for use in MLS environments

2006-06-20 Thread James Morris
On Tue, 20 Jun 2006, Venkat Yekkirala wrote: > The current approach to labeling Security Associations for SELinux > purposes uses a one-to-one mapping between xfrm policy rules and > security associations. This doesn?t address the needs of real world MLS > (Multi-level System, traditional Bell-

Re: [PATCH 03/06] MLSXFRM: Add security sid to sock

2006-06-20 Thread James Morris
On Wed, 21 Jun 2006, Herbert Xu wrote: > On Tue, Jun 20, 2006 at 08:50:55PM -0400, Venkat Yekkirala wrote: > > > > Nope. It would actually overwrite the pointer, so we put it away before > > memcpy > > and set it back after memcpy. > > Right, I misread it as sptr = osk->sk_security. Still, it'd

Re: + myri10ge-build-fix.patch added to -mm tree

2006-06-20 Thread Herbert Xu
On Tue, Jun 20, 2006 at 09:33:42PM -0700, [EMAIL PROTECTED] wrote: > > diff -puN drivers/net/myri10ge/myri10ge.c~myri10ge-build-fix > drivers/net/myri10ge/myri10ge.c > --- a/drivers/net/myri10ge/myri10ge.c~myri10ge-build-fix > +++ a/drivers/net/myri10ge/myri10ge.c > @@ -2120,7 +2120,7 @@ abort_lin

Re: [PATCH 03/06] MLSXFRM: Add security sid to sock

2006-06-20 Thread Herbert Xu
On Tue, Jun 20, 2006 at 08:50:55PM -0400, Venkat Yekkirala wrote: > > Nope. It would actually overwrite the pointer, so we put it away before > memcpy > and set it back after memcpy. Right, I misread it as sptr = osk->sk_security. Still, it'd be nice to optimise it away for the !SECURITY case. C

Re: [patch] ieee80211: fix not allocating IV+ICV space when usingencryption in ieee80211_tx_frame

2006-06-20 Thread Hong Liu
On Tue, 2006-06-20 at 10:26, Hong Liu wrote: > We should preallocate IV+ICV space when encrypting the frame. > Currently no problem shows up just because dev_alloc_skb aligns the > data len to SMP_CACHE_BYTES which can be used for ICV. > > Thanks, > Hong > Please apply this new patch. The previo

[no subject]

2006-06-20 Thread Anne Thrax
subscribe [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2 resend] 8139cp: fix eeprom read command length

2006-06-20 Thread Philip Craig
The read command for the 93C46/93C56 EEPROMS should be 3 bits plus the address. This doesn't appear to affect the operation of the read command, but similar errors for write commands do cause failures. Signed-off-by: Philip Craig <[EMAIL PROTECTED]> Index: linux-2.6.17-rc6/drivers/net/8139cp.c =

[PATCH 2/2 resend] 8139cp: add ethtool eeprom support

2006-06-20 Thread Philip Craig
Implement the ethtool eeprom operations for the 8139cp driver. Tested on x86 and big-endian ARM. Signed-off-by: Philip Craig <[EMAIL PROTECTED]> Index: linux-2.6.17-rc6/drivers/net/8139cp.c === --- linux-2.6.17-rc6.orig/drivers/net/8

Re: Sanitise ethtool.h and mii.h for userspace.

2006-06-20 Thread Jeff Garzik
Linux Kernel Mailing List wrote: commit c3ce7e203af5d8eab7c3390fc991a1fcb152f741 tree 43b0837c42a1deb5b0f87800bf6a5ed8eea2eafe parent 56142536868a2be34f261ed8fdca1610f8a73fbd author David Woodhouse <[EMAIL PROTECTED]> Sat, 29 Apr 2006 01:53:47 +0100 committer David Woodhouse <[EMAIL PROTECTED]> S

RE: [PATCH 03/06] MLSXFRM: Add security sid to sock

2006-06-20 Thread Venkat Yekkirala
> > +static inline void sock_copy(struct sock *nsk, const > struct sock *osk) > > +{ > > + void *sptr = nsk->sk_security; > > + > > + memcpy(nsk, osk, osk->sk_prot->obj_size); > > + nsk->sk_security = sptr; > > I don't get it. Why do you put sk_security away and then set it back. > Doesn't

Re: DF, IP ID always 0 and the reassembly protections

2006-06-20 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 20 Jun 2006 17:35:50 -0700 > I thought the ID's even in non-fragmented datagrams gave an idea of how > many IP datagrams had been sent along, and so an idea of how "unlikely" > it was that a datagram with holes could be reassembled? The code you a

Re: DF, IP ID always 0 and the reassembly protections

2006-06-20 Thread akepner
On Tue, 20 Jun 2006, Rick Jones wrote: I thought the ID's even in non-fragmented datagrams gave an idea of how many IP datagrams had been sent along, and so an idea of how "unlikely" it was that a datagram with holes could be reassembled? Only fragmented datagrams get counted. This is

Re: [PATCH 03/06] MLSXFRM: Add security sid to sock

2006-06-20 Thread Herbert Xu
On Tue, Jun 20, 2006 at 06:23:50PM +, Venkat Yekkirala wrote: > > --- linux-2.6.16.vanilla/include/net/sock.h 2006-06-19 > 17:02:23.0 -0500 > +++ linux-2.6.16/include/net/sock.h 2006-06-19 19:48:24.0 -0500 > @@ -964,6 +964,15 @@ static inline void sock_graft(struct soc >

Re: Locking validator output on DCCP

2006-06-20 Thread Herbert Xu
On Tue, Jun 20, 2006 at 11:40:05PM +, Ian McDonald wrote: > > I am getting this when I am using DCCP with 2.6.17-rc6-mm2 with Ingo's > lock dependency patch: > > Jun 21 09:38:58 localhost kernel: [ 102.068588] > Jun 21 09:38:58 localhost kernel: [ 102.068592] > =

Re: DF, IP ID always 0 and the reassembly protections

2006-06-20 Thread Rick Jones
David Miller wrote: From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 20 Jun 2006 16:44:55 -0700 Doesn't that mechanism rely on watching the IP ID's between the pair of IPs? For both fragmented and non-fragmented datagrams? If so, does always setting the IP ID to zero when DF is set affect tha

Re: DF, IP ID always 0 and the reassembly protections

2006-06-20 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 20 Jun 2006 16:44:55 -0700 > Doesn't that mechanism rely on watching the IP ID's between the pair of > IPs? For both fragmented and non-fragmented datagrams? If so, does > always setting the IP ID to zero when DF is set affect that mechanism? Onl

Re: [PKT_SCHED]: PSCHED_TADD() and PSCHED_TADD2() can result,tv_usec >= 1000000

2006-06-20 Thread Shuya MAEDA
Thank you for the comment. I made the patch that used the loop instead of the divide and modulus. Are there any comments? David Miller wrote: From: Shuya MAEDA <[EMAIL PROTECTED]> Date: Mon, 19 Jun 2006 14:36:46 +0900 #define PSCHED_TADD2(tv, delta, tv_res) \ ({ \ - int __delta = (t

Re: [NET]: Prevent multiple qdisc runs

2006-06-20 Thread Herbert Xu
On Tue, Jun 20, 2006 at 10:42:06AM -0400, jamal wrote: > > I apologize for hand-waving with % numbers above and using gut feeling > instead of experimental facts - I dont have time to chase it. I have > CCed Robert who may have time to see if this impacts forwarding > performance for one. I will h

[NET]: Make illegal_highdma more anal

2006-06-20 Thread Herbert Xu
Hi: This patch should prevent mistakes like the one I made earlier. [NET]: Make illegal_highdma more anal Rather than having illegal_highdma as a macro when HIGHMEM is off, we can turn it into an inline function that returns zero. This will catch callers that give it bad arguments. Signed-off-

Re: [2/5] [NET]: Add generic segmentation offload

2006-06-20 Thread Herbert Xu
On Tue, Jun 20, 2006 at 10:54:48AM -0700, Michael Chan wrote: > > I think you need !illegal_highdma(skb->dev, skb) Thanks for catching this. You can tell that I don't have HIGHMEM :) Here is the fixed version: [NET]: Add generic segmentation offload This patch adds the infrastructure for gener

DF, IP ID always 0 and the reassembly protections

2006-06-20 Thread Rick Jones
A while back (I cannot recall exactly when) the issue of always setting the IP datagram ID to zero when the DF bit was set was brought-up. I suggested it might not be a good idea because there are admittedly broken devices out there that "helpfully" and silently clear DF and the start to fragm

Locking validator output on DCCP

2006-06-20 Thread Ian McDonald
Folks, I am getting this when I am using DCCP with 2.6.17-rc6-mm2 with Ingo's lock dependency patch: Jun 21 09:38:58 localhost kernel: [ 102.068588] Jun 21 09:38:58 localhost kernel: [ 102.068592] = Jun 21 09:38:58 localhost kernel: [ 102.068602] [

Re: [LARTC] Re: [PATCH 0/2] Runtime configuration of HTB's HYSTERESIS option

2006-06-20 Thread Russell Stuart
On Thu, 2006-06-15 at 11:49 +0200, Martin Devera wrote: > At time of HTB implementation I needed to reach 100MBit speed on > relatively slow box. The hysteresis was a way. On other side I used > hand-made TSC based measure tool to compute exact (15%) performance > gain. Today I'd measure it usin

Re: [RFC] [patch 0/6] [Network namespace] introduction

2006-06-20 Thread Daniel Lezcano
Al Viro wrote: On Tue, Jun 20, 2006 at 11:21:43PM +0200, Daniel Lezcano wrote: Al Viro wrote: On Fri, Jun 09, 2006 at 11:02:02PM +0200, [EMAIL PROTECTED] wrote: - renaming an interface in one "namespace" affects everyone. Exact. If we ensure the interface can't be renamed if used in differe

Re: [PATCH 1/6] b44: fix manual speed/duplex/autoneg settings

2006-06-20 Thread Gary Zambrano
On Tue, 2006-06-20 at 04:42 -0400, Jeff Garzik wrote: > ACK patches 1-6, but unfortunately failed to apply against latest > linux-2.6.git: > > > [EMAIL PROTECTED] netdev-2.6]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt > > 6 patch(es) to process. > > > > Applying 'b44: fix manual speed/duplex

[PATCH 2/6 resend] b44: add wol

2006-06-20 Thread Gary Zambrano
Adds wol to the driver. This is a redo of a previous patch thanks to feedback from Francois Romieu. Signed-off-by Gary Zambrano <[EMAIL PROTECTED]> diff --git a/drivers/net/b44.c b/drivers/net/b44.c index 41b1618..81f434e 100644 --- a/drivers/net/b44.c +++ b/drivers/net/b44.c @@ -1450,6 +1450,41

[PATCH 1/6 resend] b44: fix manual speed/duplex/autoneg settings

2006-06-20 Thread Gary Zambrano
Fixes for speed/duplex/autoneg settings and driver settings info. This is a redo of a previous patch thanks to feedback from Jeff Garzik. Signed-off-by: Gary Zambrano <[EMAIL PROTECTED]> diff --git a/drivers/net/b44.c b/drivers/net/b44.c index d8233e0..41b1618 100644 --- a/drivers/net/b44.c +++ b

[PATCH 3/6 resend] b44: add parameter

2006-06-20 Thread Gary Zambrano
This patch adds a parameter to init_hw() to not completely initialize the nic for wol. Signed-off-by: Gary Zambrano <[EMAIL PROTECTED]> diff --git a/drivers/net/b44.c b/drivers/net/b44.c index 73ca729..12fc67a 100644 --- a/drivers/net/b44.c +++ b/drivers/net/b44.c @@ -101,7 +101,7 @@ MODULE_DEVI

[PATCH 6/6 resend] b44: update b44 Kconfig entry

2006-06-20 Thread Gary Zambrano
Deleted "EXPERIMENTAL" from b44 entry in Kconfig. Signed-off-by: Gary Zambrano <[EMAIL PROTECTED]> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index bdaaad8..4e57785 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -1359,8 +1359,8 @@ config APRICOT called apricot

[PATCH 5/6 resend] b44: update version to 1.01

2006-06-20 Thread Gary Zambrano
Update the driver version to 1.01 Signed-off-by: Gary Zambrano <[EMAIL PROTECTED]> diff --git a/drivers/net/b44.c b/drivers/net/b44.c index 98c0675..a7e4ba5 100644 --- a/drivers/net/b44.c +++ b/drivers/net/b44.c @@ -29,8 +29,8 @@ #define DRV_MODULE_NAME"b44" #define PFX DRV_MO

[PATCH 4/6 resend] b44: add wol for old nic

2006-06-20 Thread Gary Zambrano
This patch adds wol support for the older 440x nics that use pattern matching. This patch is a redo thanks to feedback from Michael Chan and Francois Romieu. Signed-off-by: Gary Zambrano <[EMAIL PROTECTED]> diff --git a/drivers/net/b44.c b/drivers/net/b44.c index 12fc67a..98c0675 100644 --- a/dr

Re: [FORCEDETH]: Fix xmit_lock/netif_tx_lock after merge

2006-06-20 Thread Linus Torvalds
On Tue, 20 Jun 2006, Herbert Xu wrote: > > [FORCEDETH]: Fix xmit_lock/netif_tx_lock after merge Btw, please don't use attachments in vain. Now I can't see it by default, I can reply and quote it etc etc. Linus - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [RFC] [patch 0/6] [Network namespace] introduction

2006-06-20 Thread Al Viro
On Tue, Jun 20, 2006 at 11:21:43PM +0200, Daniel Lezcano wrote: > Al Viro wrote: > >On Fri, Jun 09, 2006 at 11:02:02PM +0200, [EMAIL PROTECTED] wrote: > >- renaming an interface in one "namespace" affects everyone. > > Exact. If we ensure the interface can't be renamed if used in different > name

Re: [DOC]: generic netlink

2006-06-20 Thread Thomas Graf
Hello > > > TODO: > > > a) Add a more complete compiling kernel module with events. > > > Have Thomas put his Mashimaro example and point to it. > > > > I guess we have a legal issue here ;) > > > > change the name ;-> Ask Mr. Mashimaro has become my replacement for 8ball. Renaming it would le

Re: [GIT PATCH] TIPC updates

2006-06-20 Thread David Miller
From: Per Liden <[EMAIL PROTECTED]> Date: Tue, 20 Jun 2006 16:48:54 +0200 (CEST) > Please pull from: > > git://tipc.cslab.ericsson.net/pub/git/tipc.git Hi Per. I agree with James, you should post the patches so that people can review them. But not all in one posting! :-) Look at how oth

ipv6 source address selection in addrconf.c (2.6.17)

2006-06-20 Thread Lukasz Stelmach
Greetings. net/ipv6/addrconf.c:971 is /* Rule 2: Prefer appropriate scope */ if (hiscore.rule < 2) { hiscore.scope = __ipv6_addr_src_scope(hiscore.addr_type); hiscore.rule++; } I am afraid, that it does not make any sense for I find no place where a value is assigned to hiscore.ad

Re: Intel ixgb driver bug in linux-2.6.17-rc6-mm2

2006-06-20 Thread Jesse Brandeburg
On 6/20/06, Linas Vepstas <[EMAIL PROTECTED]> wrote: Hi, I sat down to do some testing of the ixgb driver a few days ago, and get failures within seconds. From what I can tell, I'm getting either a DMA to a bad address or some other PCI bus error, not sure which. The problem appears to happen

Re: soft lockup detected with 2.6.16 kernel + e1000 driver under load

2006-06-20 Thread Jesse Brandeburg
On 6/20/06, Massimiliano Poletto <[EMAIL PROTECTED]> wrote: Shaw Vrana asked me to resend the message below (originally posted to lkml) to this list. Note that I managed to make the problem go away by adding the boot options "pci=usepirqmask acpi=noirq". I got the hint by reading dmesg output a

Fwd: soft lockup detected with 2.6.16 kernel + e1000 driver under load

2006-06-20 Thread Massimiliano Poletto
Shaw Vrana asked me to resend the message below (originally posted to lkml) to this list. Note that I managed to make the problem go away by adding the boot options "pci=usepirqmask acpi=noirq". I got the hint by reading dmesg output and Documentation/kernel-parameters.txt. Still, maybe the inf

Re: [RFC] [patch 0/6] [Network namespace] introduction

2006-06-20 Thread Daniel Lezcano
Al Viro wrote: On Fri, Jun 09, 2006 at 11:02:02PM +0200, [EMAIL PROTECTED] wrote: - renaming an interface in one "namespace" affects everyone. Exact. If we ensure the interface can't be renamed if used in different namespace, is it really a problem ? - To unsubscribe from this list: send the

[PATCH v3 2/7] AMSO1100 WR / Event Definitions.

2006-06-20 Thread Steve Wise
2/7 gzipped & attached cuz it it gets dropped by lklm and netdev lists... Steve. amso1100_wr.gz Description: GNU Zip compressed data

Re: [PATCH v3 1/7] AMSO1100 Low Level Driver.

2006-06-20 Thread Arjan van de Ven
On Tue, 2006-06-20 at 15:30 -0500, Steve Wise wrote: > +/* > + * Allocate TX ring elements and chain them together. > + * One-to-one association of adapter descriptors with ring elements. > + */ > +static int c2_tx_ring_alloc(struct c2_ring *tx_ring, void *vaddr, > + dma_ad

[PATCH v3 1/2] iWARP Connection Manager.

2006-06-20 Thread Steve Wise
This patch provides the new files implementing the iWARP Connection Manager. This module is a logical instance of the xx_cm where xx is the transport type (ib or iw). The symbols exported are used by the transport independent rdma_cm module, and are available also for transport dependent ULPs. V

[PATCH v3 0/7][RFC] Ammasso 1100 iWARP Driver

2006-06-20 Thread Steve Wise
This patchset implements the iWARP provider driver for the Ammasso 1100 RNIC. It is dependent on the "iWARP Core Support" patch set. We're submitting it for review with the goal for inclusion in the 2.6.19 kernel. This code has gone through several reviews in the openib-general list. Now we are

[PATCH v3 0/2][RFC] iWARP Core Support

2006-06-20 Thread Steve Wise
This patchset defines the modifications to the Linux infiniband subsystem to support iWARP devices. We're submitting it for review now with the goal for inclusion in the 2.6.19 kernel. This code has gone through several reviews in the openib-general list. Now we are submitting it for external r

[PATCH v3 7/7] AMSO1100 Makefiles and Kconfig changes.

2006-06-20 Thread Steve Wise
Review Changes: - C2DEBUG -> DEBUG --- drivers/infiniband/Kconfig |1 + drivers/infiniband/Makefile|1 + drivers/infiniband/hw/amso1100/Kbuild | 10 ++ drivers/infiniband/hw/amso1100/Kconfig | 15 +++ drivers/infiniband/hw/amso1100/README

[PATCH v3 2/2] iWARP Core Changes.

2006-06-20 Thread Steve Wise
This patch contains modifications to the existing rdma header files, core files, drivers, and ulp files to support iWARP. V2 Review updates: V1 Review updates: - copy_addr() -> rdma_copy_addr() - dst_dev_addr param in rdma_copy_addr to const. - various spacing nits with recasting - include l

[PATCH v3 6/7] AMSO1100: Privileged Verbs Queues.

2006-06-20 Thread Steve Wise
Review Changes: dprintk() -> pr_debug() --- drivers/infiniband/hw/amso1100/c2_vq.c | 260 drivers/infiniband/hw/amso1100/c2_vq.h | 63 2 files changed, 323 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/amso1100/c2_vq.c b/drivers/

[PATCH v3 5/7] AMSO1100 Message Queues.

2006-06-20 Thread Steve Wise
V2 Review Changes: - correctly map host memory for DMA (don't use __pa()). V1 Review Changes: - remove useless asserts - assert() -> BUG_ON() - C2_DEBUG -> DEBUG --- drivers/infiniband/hw/amso1100/c2_mq.c | 175 drivers/infiniband/hw/amso1100/c2_mq.h | 107

[PATCH v3 4/7] AMSO1100 Memory Management.

2006-06-20 Thread Steve Wise
V2 Review Changes: - removed c2_array services and replaced them with the idr. - removed c2_alloc services and made them pd-specific. - don't use GFP_DMA. - correctly map host memory for DMA (don't use __pa()). V1 Review Changes: - sizeof -> sizeof() - cleaned up comments --- drivers/infi

Intel ixgb driver bug in linux-2.6.17-rc6-mm2

2006-06-20 Thread Linas Vepstas
Hi, I sat down to do some testing of the ixgb driver a few days ago, and get failures within seconds. From what I can tell, I'm getting either a DMA to a bad address or some other PCI bus error, not sure which. The problem appears to happen only for the driver that's in 2.6.17-rc6-mm2. As a san

[PATCH] Require CAP_NET_ADMIN to create tuntap devices.

2006-06-20 Thread David Woodhouse
The tuntap driver allows an admin to create persistent devices and assign ownership of them to individual users. Unfortunately, relaxing the permissions on the /dev/net/tun device node so that they can actually use those devices will _also_ allow those users to create arbitrary new devices of their

[PATCH 04/06] MLSXFRM: Flow based matching of xfrm policy and state

2006-06-20 Thread Venkat Yekkirala
This makes the security sid a part of the flow key and implements a seemless mechanism for xfrm policy selection and state matching based on the flow sid. This also includes the necessary SELinux enforcement pieces. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- include/linux/security.

[PATCH 01/06] MLSXFRM: Granular IPSec associations for use in MLS environments

2006-06-20 Thread Venkat Yekkirala
The current approach to labeling Security Associations for SELinux purposes uses a one-to-one mapping between xfrm policy rules and security associations. This doesn’t address the needs of real world MLS (Multi-level System, traditional Bell-LaPadula) environments where a single xfrm policy rule

[PATCH 02/06] MLSXFRM: Define new SELinux service routine

2006-06-20 Thread Venkat Yekkirala
This defines a routine that combines the Type Enforcement portion of one sid with the MLS portion from the other sid to arrive at a new sid. This is currently used to define a sid for a security association that is to be negotiated by IKE. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> ---

[PATCH 03/06] MLSXFRM: Add security sid to sock

2006-06-20 Thread Venkat Yekkirala
This adds security for IP sockets at the sock level. Security at the sock level is needed to enforce the SELinux security policy for security associations even when a sock is orphaned (such as in the TCP LAST_ACK state). Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- include/linux/secur

[PATCH 06/06] MLSXFRM: Add security context to acquire messages using PF_KEY

2006-06-20 Thread Venkat Yekkirala
This includes the security context of a security association created for use by IKE in the acquire messages sent to IKE daemons using PF_KEY. This would allow the daemons to include the security context in the negotiation, so that the resultant association is unique to that security context. Si

FOR REFERENCE ONLY: MLSXFRM: Add support to serefpolicy

2006-06-20 Thread Venkat Yekkirala
This patch has been included here just for reference. It will be submitted to the serefpolicy list later. This patch adds a polmatch avperm to arbitrate flow/state's access to a xfrm policy. It also defines MLS policy for association { sendto, recvfrom, polmatch }. NOTE: When an inbound packet i

[PATCH 05/06] MLSXFRM: Add security context to acquire messages using netlink

2006-06-20 Thread Venkat Yekkirala
From: Serge Hallyn <[EMAIL PROTECTED]> This includes the security context of a security association created for use by IKE in the acquire messages sent to IKE daemons using netlink/xfrm_user. This would allow the daemons to include the security context in the negotiation, so that the resultant

Re: [RFT] pcnet32 NAPI changes

2006-06-20 Thread Lennart Sorensen
On Tue, Jun 20, 2006 at 11:05:04AM -0500, Jon Mason wrote: > The point of my comment was CPU utilization. > > It appears that a bug is trying to be fixed by adding NAPI. This > sounds a bit hackish to me, and could hide the root cause of the > problem. So I'm not sure that is the best idea, but I

Re: [2/5] [NET]: Add generic segmentation offload

2006-06-20 Thread Michael Chan
On Tue, 2006-06-20 at 19:28 +1000, Herbert Xu wrote: > [NET]: Add generic segmentation offload > > +static int dev_gso_segment(struct sk_buff *skb) > +{ > + struct sk_buff *segs; > + > + segs = skb_gso_segment(skb, skb->dev->features & NETIF_F_SG && > +

Re: [PATCH] Fix recommended permissions for /dev/net/tun

2006-06-20 Thread David Woodhouse
On Tue, 2006-06-20 at 11:46 -0500, Chase Venters wrote: > Perhaps you lie again :) > > Are you sure you're adding a capable(CAP_SYS_ADMIN)? :P I'm going to go home now. G'night. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PRO

Re: [PATCH 2/2] NET: Accurate packet scheduling for ATM/ADSL (userspace)

2006-06-20 Thread Patrick McHardy
jamal wrote: > On Tue, 2006-20-06 at 16:45 +0200, Patrick McHardy wrote: > >>Actually in the PPPoE case Linux doesn't know about ethernet >>headers either, since shaping is usually done on the PPP device. >>But that doesn't really matter since the ethernet link is not >>the bottleneck - although i

Re: [PATCH] Fix recommended permissions for /dev/net/tun

2006-06-20 Thread Chase Venters
On Tue, 20 Jun 2006, David Woodhouse wrote: On Tue, 2006-06-20 at 16:35 +0100, David Woodhouse wrote: There's no reason to restrict unprivileged users from opening the /dev/net/tun device node -- to do anything exciting requires CAP_NET_ADMIN or a persistent device which is owned by the user in

Re: [PATCH] Fix recommended permissions for /dev/net/tun

2006-06-20 Thread David Woodhouse
On Tue, 2006-06-20 at 16:35 +0100, David Woodhouse wrote: > There's no reason to restrict unprivileged users from opening > the /dev/net/tun device node -- to do anything exciting requires > CAP_NET_ADMIN or a persistent device which is owned by the user in > question anyway. Hm, I lie. Let us al

Re: [0/5] GSO: Generic Segmentation Offload

2006-06-20 Thread Rick Jones
$ sudo ./ethtool -K lo gso on $ sudo ifconfig lo mtu 1500 $ netperf -t TCP_STREAM TCP STREAM TEST to localhost Recv SendSend Socket Socket Message Elapsed Size SizeSize Time Throughput bytes bytes bytessecs.10^6bits/sec 87380 16384 1638410.003598.17 W

Re: [RFT] pcnet32 NAPI changes

2006-06-20 Thread Jon Mason
On Tue, Jun 20, 2006 at 10:48:07AM -0400, Lennart Sorensen wrote: > On Tue, Jun 20, 2006 at 08:53:55AM -0500, Jon Mason wrote: > > The amount of polls per received packet is very low, thus removing the > > benefit of NAPI. A compile time option would allow those users who know > > better to DTRT.

Re: [PATCH 2/2] NET: Accurate packet scheduling for ATM/ADSL (userspace)

2006-06-20 Thread jamal
On Tue, 2006-20-06 at 16:45 +0200, Patrick McHardy wrote: > jamal wrote: [..] > Actually in the PPPoE case Linux doesn't know about ethernet > headers either, since shaping is usually done on the PPP device. > But that doesn't really matter since the ethernet link is not > the bottleneck - althou

Re: [Bugme-new] [Bug 6682] New: BUG: soft lockup detected on CPU#0! / ksoftirqd takse 100% CPU

2006-06-20 Thread Robert Olsson
Hello! Yes seems the system is very loaded for some reason > > sometimes a day) we get 100% usage on ksoftirqd/0 and following messages in logs: as all softirq's are run via ksoftirqd. That's still OK but why don't the watchdog get any CPU share at all? Mismatch in priorities? Herbert X

[PATCH] Fix recommended permissions for /dev/net/tun

2006-06-20 Thread David Woodhouse
There's no reason to restrict unprivileged users from opening the /dev/net/tun device node -- to do anything exciting requires CAP_NET_ADMIN or a persistent device which is owned by the user in question anyway. And if it _isn't_ openable by unprivileged users, then giving ownership of devices to th

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-20 Thread Patrick McHardy
jamal wrote: > On Tue, 2006-20-06 at 03:04 +0200, Patrick McHardy wrote: > >>It would be nice to have support for HFSC as well, which unfortunately >>needs to be done in the kernel since it doesn't use rate tables. >>What about qdiscs like SFQ (which uses the packet size in quantum >>calculations)

[PATCH 1/3] PAL: Support of the fixed PHY

2006-06-20 Thread Vitaly Bordug
This makes it possible for HW PHY-less boards to utilize PAL goodies. Generic routines to connect to fixed PHY are provided, as well as ability to specify software callback that fills up link, speed, etc. information into PHY descriptor (the latter feature not tested so far). Signed-off-by: Vital

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-20 Thread Patrick McHardy
jamal wrote: > On Tue, 2006-20-06 at 02:54 +0200, Patrick McHardy wrote: > >>jamal wrote: >> >>>- For further reflection: Have you considered the case where the rate >>>table has already been considered on some link speed in user space and >>>then somewhere post-config the physical link speed chan

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-20 Thread jamal
On Tue, 2006-20-06 at 03:04 +0200, Patrick McHardy wrote: > jamal wrote: > > You are still speaking ATM (and the above may still be valid), but: > > Could you for example look at the netdevice->type and from that figure > > out the link layer overhead and compensate for it. > > Obviously a lot mor

[PATCH 3/3] FS_ENET: phydev pointer may be dereferenced without NULL check

2006-06-20 Thread Vitaly Bordug
When interface is down, phy is "disconnected" from the bus and phydev is NULL. But ethtool may try to get/set phy regs even at that time, which results in NULL pointer dereference and OOPS hereby. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c |4 +++

Re: [DOC]: generic netlink

2006-06-20 Thread jamal
On Tue, 2006-20-06 at 10:02 +0200, Thomas Graf wrote: > * jamal <[EMAIL PROTECTED]> 2006-06-19 09:41 > One important point about attributes in generic netlink is that > their scope is per command instead of per family as in netlink. > It's not forbidden to use the same set of attribute identifiers

Re: [DOC]: generic netlink

2006-06-20 Thread jamal
On Mon, 2006-19-06 at 18:37 -0400, Shailabh Nagar wrote: > Completing the documentation on generic netlink usage will definitely be > useful. I'd be happy to help out with this since I've recently gone through > trying to understand and use genetlink for the taskstats interface. Hopefully > this w

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-20 Thread jamal
On Tue, 2006-20-06 at 02:54 +0200, Patrick McHardy wrote: > jamal wrote: > > - For further reflection: Have you considered the case where the rate > > table has already been considered on some link speed in user space and > > then somewhere post-config the physical link speed changes? This would >

Re: [RFT] pcnet32 NAPI changes

2006-06-20 Thread Lennart Sorensen
On Tue, Jun 20, 2006 at 08:53:55AM -0500, Jon Mason wrote: > The amount of polls per received packet is very low, thus removing the > benefit of NAPI. A compile time option would allow those users who know > better to DTRT. Well I know on the slow poke system I run on, with the napi polling, the

[GIT PATCH] TIPC updates

2006-06-20 Thread Per Liden
Hi Dave, Here are the latest TIPC updates. Please pull from: git://tipc.cslab.ericsson.net/pub/git/tipc.git Thanks /Per include/net/tipc/tipc_bearer.h | 12 ++ net/tipc/bcast.c | 79 --- net/tipc/bcast.h |2 net/tipc/bearer.c

Re: [NET]: Prevent multiple qdisc runs

2006-06-20 Thread jamal
Herbert, Thanks for your patience. On Tue, 2006-20-06 at 08:33 +1000, Herbert Xu wrote: > First of all you could receive an IRQ in between dropping xmit_lock > and regaining the queue lock. Indeed you could. Sorry, I overlooked that in my earlier email. This issue has been there forever though

Re: [PATCH 2/2] NET: Accurate packet scheduling for ATM/ADSL (userspace)

2006-06-20 Thread Patrick McHardy
jamal wrote: > Heres the standard setup as i understand it(at least in north america, I > know Europeans love their ATM with a little gravy on top): > > > |Linux| --ethernet-- |Modem| --DSL-- |DSLAM| --ATM-- |BRAS| > >

Re: rtl8150 usb driver, needs more vendor ids?

2006-06-20 Thread Ben Greear
Petko Manolov wrote: Hi Ben, What you have sent me is a bit of a puzzle. Looking at the device's details i can see it is not RTL8150 based device, but ADMtek's ADM8511. Both vendor and device IDs have been listed in pegasus.c for a long long time. Using rtl8150.c will not help at all s

[PATCH] 2.6.17 missing a call to ieee80211softmac_capabilities from ieee80211softmac_assoc_req

2006-06-20 Thread Larry Finger
In commit ba9b28d19a3251bb1dfe6a6f8cc89b96fb85f683, routine ieee80211softmac_capabilities was added to net/ieee80211/softmac/ieee80211softmac_io.c. As denoted by its name, it completes the capabilities IE that is needed in the associate and reassociate requests sent to the AP. For at least one A

Re: [PATCH 2/2] NET: Accurate packet scheduling for ATM/ADSL (userspace)

2006-06-20 Thread jamal
took off lartc off the list because it doesnt allow me to post and i refuse to subscribe. On Mon, 2006-19-06 at 21:31 +0200, Jesper Dangaard Brouer wrote: > > On Thu, 15 Jun 2006, jamal wrote: > > It is probably doable by just looking at netdevice->type and figuring > > the link layer technology

Re: [RFT] pcnet32 NAPI changes

2006-06-20 Thread Jon Mason
On Mon, Jun 19, 2006 at 04:49:33PM -0400, Lennart Sorensen wrote: > On Mon, Jun 19, 2006 at 03:41:40PM -0500, Jon Mason wrote: > > I believe it is preferred to be a compile option for non-gigabit > > drivers, given that it will be eating a lot of cycles for infrequent > > packets (especially for th

Re: [DOC]: generic netlink

2006-06-20 Thread jamal
On Mon, 2006-19-06 at 11:58 -0400, Shailabh Nagar wrote: > jamal wrote: [..] > But I'm not too clear about what are the advantages of trying to limit the > number of commands registered by a given exploiter of genetlink (say TIPC or > taskstats), > other than the conventional usage of netlink. >

Re: [DOC]: generic netlink

2006-06-20 Thread jamal
On Mon, 2006-19-06 at 11:54 -0400, James Morris wrote: > On Mon, 19 Jun 2006, jamal wrote: > > > Other that TIPC the two other users i have seen use it in this manner. > > But, you are right if usage tends to lean in some other way we could get > > rid of it (I think TIPC is a bad example). > > O

Re: [Bugme-new] [Bug 6682] New: BUG: soft lockup detected on CPU#0! / ksoftirqd takse 100% CPU

2006-06-20 Thread Herbert Xu
On Mon, Jun 19, 2006 at 10:20:10PM +, Andrew Morton wrote: > > > [] dev_queue_xmit+0xe0/0x203 > > [] ip_output+0x1e1/0x237 > > [] ip_forward+0x181/0x1df > > [] ip_rcv+0x40c/0x485 > > [] netif_receive_skb+0x12f/0x165 > > [] e1000_clean_rx_irq+0x389/0x410 [e1000] > > [] e1000_clean+0x94/0x

Re: [0/5] GSO: Generic Segmentation Offload

2006-06-20 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 20 Jun 2006 19:32:19 +1000 > On Tue, Jun 20, 2006 at 07:09:19PM +1000, herbert wrote: > > > > I've attached some numbers to demonstrate the savings brought on by > > doing this. The best scenario is obviously the case where the underlying > > NIC su

[PATCH 2.6.17] AT91RM9200 Ethernet #4: Suspend/Resume

2006-06-20 Thread Andrew Victor
Adds power-management (suspend/resume) support to the AT91RM9200 Ethernet driver. Patch from David Brownell. Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> diff -urN linux-2.6.17-rmk.orig/drivers/net/arm/at91_ether.c linux-2.6.17-rmk/drivers/net/arm/at91_ether.c --- linux-2.6.17-rmk.orig/dri

[PATCH 2.6.17] AT91RM9200 Ethernet #3: Cleanup

2006-06-20 Thread Andrew Victor
Moved global ether_clk variable into controller data structure. Patch from David Brownell. Davicom 9161 PHY was being incorrectly displayed as "9196". Patch from Brian Stafford. clk_get() doesn't return NULL on error, so the return value needs to be tested with IS_ERR(). Whitespace cleanup. Si

Re: rtl8150 usb driver, needs more vendor ids?

2006-06-20 Thread Petko Manolov
Hi Ben, What you have sent me is a bit of a puzzle. Looking at the device's details i can see it is not RTL8150 based device, but ADMtek's ADM8511. Both vendor and device IDs have been listed in pegasus.c for a long long time. Using rtl8150.c will not help at all since it talks to a

[PATCH 2.6.17] AT91RM9200 Ethernet #2: MII interface

2006-06-20 Thread Andrew Victor
Adds support for the MII ioctls via generic_mii_ioctl(). Patch from Brian Stafford. Set the mii.phy_id to the detected PHY address, otherwise ethtool cannot access PHYs other than 0. Patch from Roman Kolesnikov. Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> diff -urN linux-2.6.17-rmk.orig/d

Re: [IOC3] IP27: Really set PCI64_ATTR_VIRTUAL, not PCI64_ATTR_PREC.

2006-06-20 Thread Ralf Baechle
On Tue, Jun 20, 2006 at 10:15:01AM +0200, Ingo Oeser wrote: > From: Ingo Oeser <[EMAIL PROTECTED]> > To: Ralf Baechle <[EMAIL PROTECTED]> > Subject: Re: [IOC3] IP27: Really set PCI64_ATTR_VIRTUAL, not PCI64_ATTR_PREC. > Date: Tue, 20 Jun 2006 10:15:01 +0200 > Cc: netdev@vger.kernel.org, Jeff Ga

[PATCH 2.6.17] AT91RM9200 Ethernet #1: Link poll

2006-06-20 Thread Andrew Victor
For Ethernet PHYs that don't have an IRQ pin or boards that don't connect the IRQ pin to the processor, we enable a timer to poll the PHY's link state. Patch originally supplied by Eric Benard and Roman Kolesnikov. Signed-off-by: Andrew Victor <[EMAIL PROTECTED]> diff -urN linux-2.6.17.orig/dri

[3/5] [NET]: Add software TSOv4

2006-06-20 Thread Herbert Xu
Hi: [NET]: Add software TSOv4 This patch adds the GSO implementation for IPv4 TCP. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http:

[5/5] [IPSEC]: Handle GSO packets

2006-06-20 Thread Herbert Xu
Hi: [IPSEC]: Handle GSO packets This patch segments GSO packets received by the IPsec stack. This can happen when a NIC driver injects GSO packets into the stack which are then forwarded to another host. The primary application of this is going to be Xen where its backend driver may inject GSO

Re: [0/5] GSO: Generic Segmentation Offload

2006-06-20 Thread Herbert Xu
On Tue, Jun 20, 2006 at 07:09:19PM +1000, herbert wrote: > > I've attached some numbers to demonstrate the savings brought on by > doing this. The best scenario is obviously the case where the underlying > NIC supports SG. This means that we simply have to manipulate the SG > entries and place th

  1   2   >