Re: tc related lockdep warning.

2006-09-28 Thread Jarek Poplawski
On Thu, Sep 28, 2006 at 07:20:00AM -0700, Stephen Hemminger wrote: > On Thu, 28 Sep 2006 15:13:01 +0200 > Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > On Thu, Sep 28, 2006 at 02:17:51PM +0200, Patrick McHardy wrote: > > > [My mail provider is down, so responding "manually"] > > > > > > Jarek

Re: [PATCH] IPv6/DCCP: Fix memory leak in dccp_v6_do_rcv()

2006-09-28 Thread Andrew Morton
On Fri, 29 Sep 2006 02:45:33 +0200 Jesper Juhl <[EMAIL PROTECTED]> wrote: > > Coverity found what looks like a real leak in > net/dccp/ipv6.c::dccp_v6_do_rcv() > > We may leave via the return inside "if (sk->sk_state == DCCP_OPEN) {" > but at that point we may have allocated opt_skb, but we nev

Re: [PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-28 Thread Joshua Brindle
Venkat Yekkirala wrote: + + err = avc_has_perm(xfrm_sid, skb->secmark, SECCLASS_PACKET, + PACKET__FLOW_IN, NULL); + if (err) + goto out; + + if (xfrm_sid) { + err = security_transition_sid(xfrm_sid, skb->secmark,

Re: [2.6.18 backport] RTL8168 ethernet support in r8169

2006-09-28 Thread Samir Bellabes
Francois Romieu <[EMAIL PROTECTED]> writes: > Daniel Drake <[EMAIL PROTECTED]> : > [...] > static struct pci_device_id rtl8169_pci_tbl[] = { > - { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8169), }, > - { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8129), }, > - { PCI_DEVICE(PCI_VENDOR_ID_D

[PATCH 7/7] secid reconciliation-v03: Enforcement for SELinux

2006-09-28 Thread Venkat Yekkirala
This defines SELinux enforcement of the 2 new LSM hooks as well as related changes elsewhere in the SELinux code. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- security/selinux/hooks.c| 129 +++--- security/selinux/include/xfrm.h |5 + security/selin

[PATCH 4/7] secid reconciliation-v03: Invoke LSM hook for outbound traffic

2006-09-28 Thread Venkat Yekkirala
Invoke the skb_flow_out LSM hook for outbound traffic for secid reconciliation and flow control. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- net/netfilter/xt_CONNSECMARK.c | 70 +++ net/netfilter/xt_SECMARK.c | 33 +- 2 files changed, 85

[PATCH 0/7] secid reconciliation-v03: Repost patchset with updates

2006-09-28 Thread Venkat Yekkirala
This patchset is relative to davem's net-2.6.git The following are the changes included in this patchset since the previous post: - Retain secmark (from the originating socket/flow) on loopback traffic; this traffic is now flow controlled on the outbound only. - When multiple iptables labeling

[PATCH 3/7] secid reconciliation-v03: Invoke LSM hook for inbound traffic

2006-09-28 Thread Venkat Yekkirala
Invoke the skb_flow_in LSM hook for inbound traffic for secid reconciliation and flow control. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- include/net/xfrm.h | 45 +-- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/include/net

[PATCH 6/7] secid reconciliation-v03: Label locally generated IPv4 traffic

2006-09-28 Thread Venkat Yekkirala
This labels the skb(s) for locally generated IPv4 traffic. This will be used in pertinent flow control checks on the outbound later in the LSM hook. This is not as pretty as it is for IPv6, but what to do? Note that skb(s) that derive the secmark from the originating socket do so in the outbound h

[PATCH 1/7] secid reconciliation-v03

2006-09-28 Thread Venkat Yekkirala
This patchset helps one leverage secmark in defining fine-grained security check points with support for a. a default place holder domain defined using secmark for each of the check points and b. flow control and reconciliation of domains entering/leaving the system. The reconciliation steps for S

[PATCH 2/7] secid reconciliation-v03: Add LSM hooks

2006-09-28 Thread Venkat Yekkirala
Add skb_policy_check and skb_netfilter_check hooks to LSM to enable reconciliation of the various security identifiers as well as enforce flow control on inbound (PREROUTING/INPUT) and outbound (OUTPUT/FORWARD/POSTROUTING) traffic. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- include/

[PATCH 5/7] secid reconciliation-v03: Label locally generated IPv6 traffic

2006-09-28 Thread Venkat Yekkirala
This labels the skb(s) for locally generated IPv6 traffic. This will be used in pertinent flow control checks on the outbound later in the LSM hook. NOTE: Forwarded traffic is already labeled with the reconciled secmark on the inbound. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- incl

Re: [GIT PATCH] NET: Fixes for net-2.6.19

2006-09-28 Thread Masahide NAKAMURA
David Miller wrote: >> commit 0844565fb8a9418f5a860aa480c1aef70319c9a2 >> Author: Thomas Graf <[EMAIL PROTECTED]> >> Date: Fri Aug 4 23:05:56 2006 -0700 >> >> [NET]: Move netlink interface bits to linux/if.h >> >> Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> >> Signed-off-by: D

2.6.19 status

2006-09-28 Thread David Miller
I've just pushed my current net-2.6 tree to Linus. The bulk of the changes in there are endianness annotations for sparse by Al Viro, along with the patches I've been ACK'ing here on the list and elsewhere. If you want a non-bugfix change to get into 2.6.19 you must have it to me by the end of t

Re: Network problem with 2.6.18-mm1 ?

2006-09-28 Thread Sukadev Bhattiprolu
Jesse Brandeburg [EMAIL PROTECTED] wrote: | On 9/28/06, Sukadev Bhattiprolu <[EMAIL PROTECTED]> wrote: | >Thanks. See below for additional info | > | >Auke Kok [EMAIL PROTECTED] wrote: | >| Sukadev Bhattiprolu wrote: | >| > | >| >I am unable to get networking to work with 2.6.18-mm1 on my system. |

[PATCH] IPv6/DCCP: Fix memory leak in dccp_v6_do_rcv()

2006-09-28 Thread Jesper Juhl
Coverity found what looks like a real leak in net/dccp/ipv6.c::dccp_v6_do_rcv() We may leave via the return inside "if (sk->sk_state == DCCP_OPEN) {" but at that point we may have allocated opt_skb, but we never free it in that path before the return. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED

Re: [GIT PATCH] NET: Fixes for net-2.6.19

2006-09-28 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 16:27:04 -0700 > It got added by this: > > commit 0844565fb8a9418f5a860aa480c1aef70319c9a2 > Author: Thomas Graf <[EMAIL PROTECTED]> > Date: Fri Aug 4 23:05:56 2006 -0700 > > [NET]: Move netlink interface bits to linux/if.h

Re: sky2 (was Re: 2.6.18-mm2)

2006-09-28 Thread Stephen Hemminger
> > See also http://bugzilla.kernel.org/show_bug.cgi?id=7222 > > That's two reports in 18 hours, from amongst the presumably-small population > of sky2-owning -mm testers. I'll back it out if we don't get a simple resolution. It was just trying to use the pci facilities as intended. Note: I kn

Re: [GIT PATCH] NET: Fixes for net-2.6.19

2006-09-28 Thread Stephen Hemminger
On Thu, 28 Sep 2006 16:04:58 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Thu, 28 Sep 2006 15:50:52 -0700 > > > On Thu, 28 Sep 2006 14:33:04 -0700 (PDT) > > David Miller <[EMAIL PROTECTED]> wrote: > > > > > From: Stephen Hemminger <[EM

Re: sky2 (was Re: 2.6.18-mm2)

2006-09-28 Thread Andrew Morton
On Thu, 28 Sep 2006 19:07:05 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > Another customer.. > > > > Begin forwarded message: > > > > Date: Fri, 29 Sep 2006 00:44:01 +0200 > > From: Matthias Hentges <[EMAIL PROTECTED]> > > To: Andrew Morton <[EMAIL PROTECTED]> > > Cc:

Re: sky2 (was Re: 2.6.18-mm2)

2006-09-28 Thread Stephen Hemminger
On Thu, 28 Sep 2006 19:07:05 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > Another customer.. > > > > Begin forwarded message: > > > > Date: Fri, 29 Sep 2006 00:44:01 +0200 > > From: Matthias Hentges <[EMAIL PROTECTED]> > > To: Andrew Morton <[EMAIL PROTECTED]> > > Cc:

sky2 (was Re: 2.6.18-mm2)

2006-09-28 Thread Jeff Garzik
Andrew Morton wrote: Another customer.. Begin forwarded message: Date: Fri, 29 Sep 2006 00:44:01 +0200 From: Matthias Hentges <[EMAIL PROTECTED]> To: Andrew Morton <[EMAIL PROTECTED]> Cc: linux-kernel@vger.kernel.org Subject: Re: 2.6.18-mm2 Hello all, I've just tested -mm2 on my C2D system a

Re: [GIT PATCH] NET: Fixes for net-2.6.19

2006-09-28 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 15:50:52 -0700 > On Thu, 28 Sep 2006 14:33:04 -0700 (PDT) > David Miller <[EMAIL PROTECTED]> wrote: > > > From: Stephen Hemminger <[EMAIL PROTECTED]> > > Date: Thu, 28 Sep 2006 08:36:45 -0700 > > > > > Please figure out how to ke

Re: [GIT PATCH] NET: Fixes for net-2.6.19

2006-09-28 Thread Stephen Hemminger
On Thu, 28 Sep 2006 14:33:04 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Thu, 28 Sep 2006 08:36:45 -0700 > > > Please figure out how to keep rtnetlink.h useful from user space. > > I tried putting the current sanitized version of rtnet

Re: [RFC] let mortals use ethtool

2006-09-28 Thread Stephen Hemminger
On Thu, 28 Sep 2006 16:23:46 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > There is no reason to not allow non-admin users to query network > > statistics and settings. > > NAK. > > Some functions in the past didn't like getting hit rapidly in succession. > > I wou

Re: kernel: TKIP: replay detected:

2006-09-28 Thread Jouni Malinen
On Thu, Sep 28, 2006 at 04:42:10PM -0500, Larry Finger wrote: > @@ -544,6 +548,14 @@ int bcm43xx_rx(struct bcm43xx_private *b > } > > frame_ctl = le16_to_cpu(wlhdr->frame_ctl); > + seq_ctl = le16_to_cpu(wlhdr->seq_ctl); > + > + if ((frame_ctl == prev_frame) && (seq_ctl == prev

Re: 2.6.18-mm2

2006-09-28 Thread Stephen Hemminger
On Thu, 28 Sep 2006 14:01:24 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > (please always do reply-to-all) > > On Thu, 28 Sep 2006 17:50:31 + (UTC) > "Steve Fox" <[EMAIL PROTECTED]> wrote: > > > On Thu, 28 Sep 2006 01:46:23 -0700, Andrew Morton wrote: > > > > > ftp://ftp.kernel.org/pu

Re: [RFC] let mortals use ethtool

2006-09-28 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 18:25:26 -0400 > GWOL now spits out a password for all users -> security risk. Ditto > GEEPROM. GSET has been known to cause hangs if done in a tight loop, on > some 10/100 cards, which is now permitted by any user. At the very > l

Re: [RFC] let mortals use ethtool

2006-09-28 Thread Jeff Garzik
David Miller wrote: Secondarily, looping over reading all of the registers of the chip might kill performance since the IO accesses compete with the normal packet sending/receiving operations. This can be true of any ethtool sub-ioctl that beats the registers, if run in a tight loop. PHYs are

Re: Bluetooth update for 2.6

2006-09-28 Thread David Miller
From: Marcel Holtmann <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 23:14:44 +0200 > > > > here are the pending patches that didn't make it into the 2.6.18 kernel > > > > release. I have some additional fixes, but all of them need some more > > > > additional testing from my side. > > > > > > it see

Re: [RFC] let mortals use ethtool

2006-09-28 Thread Jeff Garzik
David Miller wrote: From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 13:17:04 -0700 I'm against letting normal users do ETHTOOL_GREGS and ETHTOOL_PHYS_ID. Dumping 64K worth of registers and blinking the LEDs should be restricted. But I have no problem doing these checks in the d

Re: [RFC] let mortals use ethtool

2006-09-28 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 15:03:40 -0700 > On Thu, 2006-09-28 at 14:53 -0700, David Miller wrote: > > > I've applied Stephen's patch with PHYS_ID removed from the > > allowed list, thanks for the feedback. > > Can you remove GREGS as well? Allowing users to

Re: [RFC] let mortals use ethtool

2006-09-28 Thread David Miller
From: James Morris <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 16:32:38 -0400 (EDT) > On Thu, 28 Sep 2006, Michael Chan wrote: > > > I'm against letting normal users do ETHTOOL_GREGS and ETHTOOL_PHYS_ID. > > Dumping 64K worth of registers and blinking the LEDs should be > > restricted. > > Out of

Re: [RFC] let mortals use ethtool

2006-09-28 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 16:23:46 -0400 > NAK. > > Some functions in the past didn't like getting hit rapidly in succession. > > I would agree to this, but only after an exhaustive audit of each driver > and each sub-ioctl. Right now, I only have confidence

Re: [RFC] let mortals use ethtool

2006-09-28 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 13:17:04 -0700 > I'm against letting normal users do ETHTOOL_GREGS and ETHTOOL_PHYS_ID. > Dumping 64K worth of registers and blinking the LEDs should be > restricted. But I have no problem doing these checks in the driver if > necess

Re: [RFC] let mortals use ethtool

2006-09-28 Thread Michael Chan
On Thu, 2006-09-28 at 14:53 -0700, David Miller wrote: > I've applied Stephen's patch with PHYS_ID removed from the > allowed list, thanks for the feedback. Can you remove GREGS as well? Allowing users to dump all the registers will be very problematic. - To unsubscribe from this list: send the

Re: [RFC] let mortals use ethtool

2006-09-28 Thread David Miller
From: Auke Kok <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 12:56:25 -0700 > PHYS_ID pokes in hardware and makes it jump through hoops, in the case of > some hardware > this could create a local DOS attack (e1000 suffers fromt his, probably more > if not all) > where the NIC might stop receiving

Re: [PATCH 1/1] NetLabel: add audit support for configuration changes

2006-09-28 Thread David Miller
From: James Morris <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 15:50:42 -0400 (EDT) > > > +struct audit_buffer *netlbl_audit_start_common(int type, u32 secid) > > > + if (current->mm) { > > + down_read(¤t->mm->mmap_sem); > > + vma = current->mm->mmap; > > + while (

Re: simplify microsecond rtt sampling

2006-09-28 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 09:36:50 -0700 > On Thu, 28 Sep 2006 13:47:28 +0100 > John Heffner <[EMAIL PROTECTED]> wrote: > > > Sigh. Here's one that's not corrupted. And for the record: > > > > > > This changes the microsecond RTT sampling so that sampl

Re: kernel: TKIP: replay detected:

2006-09-28 Thread Larry Finger
Jouni Malinen wrote: TKIP/CCMP are required to use incrementing TSC/PN for each frame. When a directed IEEE 802.11 frame is not acknowledged, it will be retransmitted (up to a certain limit). This retransmitted frame will use the same TSC/PN. However, the duplicate detection routine in the recei

Re: [PATCH] tcp-lp: prevent chance for oops

2006-09-28 Thread David Miller
From: "Wong Edison" <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 18:43:58 +0800 > * > - * Version: $Id: tcp_lp.c,v 1.24 2006/09/05 20:22:53 hswong3i Exp $ > + * Version: $Id: tcp_lp.c,v 1.25 2006/09/22 20:50:27 hswong3i Exp $ BTW, I'm deleting this line from the source file in the tree because ev

Re: [Patch] Remove unnecessary check in net/sunrpc/svcsock.c

2006-09-28 Thread David Miller
From: Eric Sesterhenn <[EMAIL PROTECTED]> Date: Wed, 27 Sep 2006 17:34:49 +0200 > coverity spotted this one as possible dereference in the dprintk(), > but since there is only one caller of svc_create_socket(), which always > passes a valid sin, we dont need this check. > > Signed-off-by: Eric Se

Re: [PATCH] tcp-lp: prevent chance for oops

2006-09-28 Thread David Miller
From: "Wong Edison" <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 18:43:58 +0800 > This patch fix the chance for tcp_lp_remote_hz_estimator return 0, if > 0 < rhz < 64. It also make sure the flag LP_VALID_RHZ is set > correctly. > > Signed-off-by: Wong Hoi Sing Edison <[EMAIL PROTECTED]> Applied, t

Re: [GIT PATCH] NET: Fixes for net-2.6.19

2006-09-28 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 28 Sep 2006 08:36:45 -0700 > Please figure out how to keep rtnetlink.h useful from user space. > I tried putting the current sanitized version of rtnetlink.h into > iproute2 and the build fails. Please give the error so I have a chance of fi

Re: [PATCH 1/1] NetLabel: add audit support for configuration changes

2006-09-28 Thread Paul Moore
James Morris wrote: > On Thu, 28 Sep 2006, Paul Moore wrote: > >>Agreed, in fact, as I suspect you have already noticed, this was ripped >>right from that function. It was private to kernel/auditsc.c making it >>offlimits, but I would have gladly used it instead; making >>audit_log_task_info() pu

Re: Bluetooth update for 2.6

2006-09-28 Thread Marcel Holtmann
Hi Dave, > > > here are the pending patches that didn't make it into the 2.6.18 kernel > > > release. I have some additional fixes, but all of them need some more > > > additional testing from my side. > > > > it seems that you haven't pulled in these changes so far. So I didn't > > rebase the tr

Re: Network problem with 2.6.18-mm1 ?

2006-09-28 Thread Jesse Brandeburg
On 9/28/06, Sukadev Bhattiprolu <[EMAIL PROTECTED]> wrote: Thanks. See below for additional info Auke Kok [EMAIL PROTECTED] wrote: | Sukadev Bhattiprolu wrote: | > | >I am unable to get networking to work with 2.6.18-mm1 on my system. | > | >But 2.6.18 kernel on same system works fine. Here is s

Re: 2.6.18-mm2

2006-09-28 Thread Andrew Morton
(please always do reply-to-all) On Thu, 28 Sep 2006 17:50:31 + (UTC) "Steve Fox" <[EMAIL PROTECTED]> wrote: > On Thu, 28 Sep 2006 01:46:23 -0700, Andrew Morton wrote: > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18/2.6.18-mm2/ > > Panic on boot. This machine boot

Re: [RFC] let mortals use ethtool

2006-09-28 Thread Michael Chan
On Thu, 2006-09-28 at 16:35 -0400, Jeff Garzik wrote: > James Morris wrote: > > On Thu, 28 Sep 2006, Michael Chan wrote: > > > >> I'm against letting normal users do ETHTOOL_GREGS and ETHTOOL_PHYS_ID. > >> Dumping 64K worth of registers and blinking the LEDs should be > >> restricted. > > > > Out

Re: [RFC] let mortals use ethtool

2006-09-28 Thread Jeff Garzik
Another example: registers often have sensitive information such as WoL passwords or WEP keys stored in them. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] let mortals use ethtool

2006-09-28 Thread Jeff Garzik
James Morris wrote: On Thu, 28 Sep 2006, Michael Chan wrote: I'm against letting normal users do ETHTOOL_GREGS and ETHTOOL_PHYS_ID. Dumping 64K worth of registers and blinking the LEDs should be restricted. Out of curiosity -- why? In the past, dumping certain tg3 registers has led to lock-

Re: [RFC] let mortals use ethtool

2006-09-28 Thread James Morris
On Thu, 28 Sep 2006, Michael Chan wrote: > I'm against letting normal users do ETHTOOL_GREGS and ETHTOOL_PHYS_ID. > Dumping 64K worth of registers and blinking the LEDs should be > restricted. Out of curiosity -- why? -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send t

Re: [RFC] let mortals use ethtool

2006-09-28 Thread Jeff Garzik
Michael Chan wrote: On Thu, 2006-09-28 at 12:25 -0700, Stephen Hemminger wrote: + /* Allow some commands to be done by anyone */ + switch(ethcmd) { + case ETHTOOL_GSET: + case ETHTOOL_GDRVINFO: + case ETHTOOL_GREGS: + case ETHTOOL_GWOL: + case ETHTOOL_G

Re: [RFC] let mortals use ethtool

2006-09-28 Thread Jeff Garzik
Stephen Hemminger wrote: There is no reason to not allow non-admin users to query network statistics and settings. NAK. Some functions in the past didn't like getting hit rapidly in succession. I would agree to this, but only after an exhaustive audit of each driver and each sub-ioctl. Righ

Re: [RFC] let mortals use ethtool

2006-09-28 Thread Michael Chan
On Thu, 2006-09-28 at 12:25 -0700, Stephen Hemminger wrote: > + /* Allow some commands to be done by anyone */ > + switch(ethcmd) { > + case ETHTOOL_GSET: > + case ETHTOOL_GDRVINFO: > + case ETHTOOL_GREGS: > + case ETHTOOL_GWOL: > + case ETHTOOL_GMSGLVL: > + case ET

Re: [PATCH 1/1] NetLabel: add audit support for configuration changes

2006-09-28 Thread James Morris
On Thu, 28 Sep 2006, Paul Moore wrote: > Agreed, in fact, as I suspect you have already noticed, this was ripped > right from that function. It was private to kernel/auditsc.c making it > offlimits, but I would have gladly used it instead; making > audit_log_task_info() public seemed like somethi

Re: [PATCH 1/1] NetLabel: add audit support for configuration changes

2006-09-28 Thread Paul Moore
James Morris wrote: >>+struct audit_buffer *netlbl_audit_start_common(int type, u32 secid) > > >>+ if (current->mm) { >>+ down_read(¤t->mm->mmap_sem); >>+ vma = current->mm->mmap; >>+ while (vma) { >>+ if ((vma->vm_flags & VM_EXECUTABLE)

Re: [PATCH 0/1] atl1: New driver, Attansic L1 Gigabit Ethernet

2006-09-28 Thread Francois Romieu
Jay Cliburn <[EMAIL PROTECTED]> : [...] > You will note that it's in a directory called "obsolete." That's > because it is undergoing significant rework based on shemminger's > comments and other considerations. > > A new version will be posted in the upcoming days. Nice. Whishlist: - __iomem a

Re: [RFC] let mortals use ethtool

2006-09-28 Thread Auke Kok
Stephen Hemminger wrote: There is no reason to not allow non-admin users to query network statistics and settings. --- linux-2.6.orig/net/core/ethtool.c +++ linux-2.6/net/core/ethtool.c @@ -806,13 +806,6 @@ int dev_ethtool(struct ifreq *ifr) int rc; unsigned long old_features;

Re: [RFC] let mortals use ethtool

2006-09-28 Thread James Morris
On Thu, 28 Sep 2006, Stephen Hemminger wrote: > > There is no reason to not allow non-admin users to query network > statistics and settings. Acked-by: James Morris <[EMAIL PROTECTED]> -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH 1/1] NetLabel: add audit support for configuration changes

2006-09-28 Thread James Morris
> +struct audit_buffer *netlbl_audit_start_common(int type, u32 secid) > + if (current->mm) { > + down_read(¤t->mm->mmap_sem); > + vma = current->mm->mmap; > + while (vma) { > + if ((vma->vm_flags & VM_EXECUTABLE) && > +

[RFC] let mortals use ethtool

2006-09-28 Thread Stephen Hemminger
There is no reason to not allow non-admin users to query network statistics and settings. --- linux-2.6.orig/net/core/ethtool.c +++ linux-2.6/net/core/ethtool.c @@ -806,13 +806,6 @@ int dev_ethtool(struct ifreq *ifr) int rc; unsigned long old_features; - /* -* XXX

Re: Network problem with 2.6.18-mm1 ?

2006-09-28 Thread Sukadev Bhattiprolu
Thanks. See below for additional info Auke Kok [EMAIL PROTECTED] wrote: | Sukadev Bhattiprolu wrote: | > | >I am unable to get networking to work with 2.6.18-mm1 on my system. | > | >But 2.6.18 kernel on same system works fine. Here is some info about | >the system/debug attempts. Attached are the

[PATCH] 2.6.18 atmel iwlist stats patch

2006-09-28 Thread Holden Karau
From: Holden Karau <[EMAIL PROTECTED]> http://www.holdenkarau.com I have made a small patch for the atmel driver [included in the 2.6.18 kernel] to output signal strength information as part of iwlist scan [before it did not output any signal strength related information]. Signed-off-by: Holden K

[PATCH 1/1] NetLabel: add audit support for configuration changes

2006-09-28 Thread paul . moore
This patch adds audit support to NetLabel, including six new audit message types shown below. #define AUDIT_MAC_UNLBL_ACCEPT 1406 #define AUDIT_MAC_UNLBL_DENY 1407 #define AUDIT_MAC_CIPSOV4_ADD 1408 #define AUDIT_MAC_CIPSOV4_DEL 1409 #define AUDIT_MAC_MAP_ADD 1410 #define AUDIT_MAC_

[PATH] Allow mtu bigger than 1500 for ieee80211

2006-09-28 Thread matthieu castet
Hi this patch allow to set the mtu between 1500 and 2304 (max octets in an MSDU) for devices using ieee80211 linux stack. Signed-off-by: Matthieu CASTET <[EMAIL PROTECTED]> Index: linux/net/ieee80211/ieee80211_module.c === --- lin

Re: softmac mtu

2006-09-28 Thread matthieu castet
Johannes Berg wrote: On Wed, 2006-09-27 at 19:17 +0200, matthieu castet wrote: 2304, I think, as that's synonym sMaxMsduLng Integer = 2304; /* max octets in an MSDU */ Yes but if it is bigger the frame get framented at the 802.11 layer : in theory we could put mtu (IP max packet size) a bi

Re: [RFC] [PATCH 3/3] enable IP multicast when bonding IPoIB devices

2006-09-28 Thread Jay Vosburgh
Or Gerlitz <[EMAIL PROTECTED]> wrote: >On 9/27/06, Jay Vosburgh <[EMAIL PROTECTED]> wrote: >> Or Gerlitz <[EMAIL PROTECTED]> wrote: [...] >> You almost want to have some kind of call to induce a reload >> from scratch of the multicast filter settings (along with whatever else >> might be n

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Jouni Malinen
On Thu, Sep 28, 2006 at 05:13:20PM +0200, Michael Buesch wrote: > On Thursday 28 September 2006 16:52, Dan Williams wrote: > > As a counterpoint, does every developer _really_ want to run > > wpa_supplicant just to use a WEP-encrypted connection where you may > > occasionally get kicked off? > > I

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Larry Finger
Michael Buesch wrote: On Thursday 28 September 2006 19:04, Larry Finger wrote: Jason Lunz wrote: On Thu, Sep 28, 2006 at 10:52:24AM -0500, Larry Finger wrote: I had very good luck with my first AP, a Linksys WRT54G V1, that I bought a second when the power supply failed in the first. Little di

Re: simplify microsecond rtt sampling

2006-09-28 Thread Stephen Hemminger
On Thu, 28 Sep 2006 13:47:28 +0100 John Heffner <[EMAIL PROTECTED]> wrote: > Sigh. Here's one that's not corrupted. And for the record: > > > This changes the microsecond RTT sampling so that samples are taken in > the same way that RTT samples are taken for the RTO calculator: on the > last

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Michael Buesch
On Thursday 28 September 2006 19:04, Larry Finger wrote: > Jason Lunz wrote: > > On Thu, Sep 28, 2006 at 10:52:24AM -0500, Larry Finger wrote: > >> I had very good luck with my first AP, a Linksys WRT54G V1, that I > >> bought a second when the power supply failed in the first. Little did > >> I kn

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Larry Finger
Jason Lunz wrote: On Thu, Sep 28, 2006 at 10:52:24AM -0500, Larry Finger wrote: I had very good luck with my first AP, a Linksys WRT54G V1, that I bought a second when the power supply failed in the first. Little did I know that a VxWorks license costs less than the extra memory needed to run Li

Re: [RFC][PATCH 1/3] enable bonding to enslave non ARPHRD_ETHER netdevices

2006-09-28 Thread Jay Vosburgh
Or Gerlitz <[EMAIL PROTECTED]> wrote: >On 9/26/06, Jay Vosburgh <[EMAIL PROTECTED]> wrote: >> Or Gerlitz <[EMAIL PROTECTED]> wrote: >> [...] >> + bond->dev->mtu = new_active->dev->mtu; >> >> This won't generate a NETDEV_CHANGEMTU notifier event. > >What is actually the t

Stability of various TCP protocols [CUBIC, BIC, HTCP, HSTCP, STCP]

2006-09-28 Thread Injong Rhee
Hi, I'd like to report on a measurement study regarding the stability of various TCP variant protocols. Although we can find quite a bit of work on fairness and convergence of protocols (including some theoretical studies on the topic as well), there is relatively little work on measuring the

Re: softmac mtu

2006-09-28 Thread Daniel Drake
[EMAIL PROTECTED] wrote: I have a patch for 802.11 linux stack. It works for mtu like 2000 but if the packet is fragmented (with mtu = 3000 for example) my usb dongle (zd1211) crash (doesn't work anymore until I replug it). I need to investigate a bit. zd1211rw requires explicit support for lar

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Jason Lunz
On Thu, Sep 28, 2006 at 10:52:24AM -0500, Larry Finger wrote: > I had very good luck with my first AP, a Linksys WRT54G V1, that I > bought a second when the power supply failed in the first. Little did > I know that a VxWorks license costs less than the extra memory needed > to run Linux. Or was i

Re: [e2e] performance of BIC-TCP, High-Speed-TCP, H-TCP etc

2006-09-28 Thread Injong Rhee
Sure. I don't mind doing this test. I am currently working with Doug Leith to get to the bottom of this difference. So when we get to the PFLDnet, we should have some more findings on this. But I am up for this challenge. - Original Message - From: "Lachlan Andrew" <[EMAIL PROTECTED]>

Re: [Bugme-new] [Bug 7222] New: sky2 throws a lot of "pci express error" in 2.6.18-mm2 on amd64

2006-09-28 Thread Andrew Morton
On Thu, 28 Sep 2006 05:10:43 -0700 [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=7222 > >Summary: sky2 throws a lot of "pci express error" in 2.6.18-mm2 > on amd64 > Kernel Version: 2.6.18-mm2 > Status: NEW > Severi

Re: [GIT PATCH] NET: Fixes for net-2.6.19

2006-09-28 Thread Stephen Hemminger
On Wed, 27 Sep 2006 22:44:44 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > Date: Tue, 19 Sep 2006 00:08:00 +0900 (JST) > > > [XFRM]: Do not add a state whose SPI is zero to the SPI hash. > > > > SPI=0 is used for acquired IPsec SA

Re: [PATCH] ieee80211: quiet TKIP and CCMP replay messages for identical TSCs

2006-09-28 Thread Jouni Malinen
On Mon, Sep 25, 2006 at 10:49:12AM -0500, Larry Finger wrote: > When using TKIP and CCMP for wireless encryption with ieee80211, the logs get > filled with useless > replay messages where the previous and received TSC are identical. This > change deletes > the log message for this case, but stil

Re: softmac mtu

2006-09-28 Thread Jouni Malinen
On Thu, Sep 28, 2006 at 05:47:12PM +0200, Johannes Berg wrote: > On Thu, 2006-09-28 at 17:35 +0200, Michael Buesch wrote: > > > I am pretty sure this is the maximum _fragment_ size. > > But then why does it talk of MPDU and MSDU? Maybe because your understanding is closer to what the standard sa

Re: Re the default linux tcp algorithm being changed from bic to cubic.

2006-09-28 Thread Stephen Hemminger
On Thu, 28 Sep 2006 11:07:18 +0100 Douglas Leith <[EMAIL PROTECTED]> wrote: > Content-Type: text/plain; charset=UTF-8; format=flowed > Content-Transfer-Encoding: 7bit > > Steve, > > I think we're all conscious of the fact that recent history contains > quite a number of proposals for changes to

Re: Re the default linux tcp algorithm being changed from bic to cubic.

2006-09-28 Thread Douglas Leith
Stephen Hemminger wrote: On Thu, 28 Sep 2006 11:07:18 +0100 Douglas Leith <[EMAIL PROTECTED]> wrote: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Steve, I think we're all conscious of the fact that recent history contains quite a number of proposals

Re: kernel: TKIP: replay detected:

2006-09-28 Thread Jouni Malinen
On Mon, Sep 25, 2006 at 10:50:00AM -0400, John W. Linville wrote: > On Sun, Sep 24, 2006 at 12:40:53PM +0200, Elimar Riesebieter wrote: > > My sylog is filled up with thousands of: > > Sep 21 18:18:00 aragorn kernel: TKIP: replay detected: \ > > STA=XX:XX:BB:LL:KK:00 previous TSC BLAa rece

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Larry Finger
Michael Wu wrote: On Thursday 28 September 2006 11:16, Larry Finger wrote: First of all, my problem is quite likely caused by a buggy AP. It is a Linksys WRT54G V5, which is one of those with a VxWorks kernel, not Linux. I have already reported one bug to Linksys, which they have neither acknowl

Re: softmac mtu

2006-09-28 Thread Johannes Berg
On Thu, 2006-09-28 at 17:35 +0200, Michael Buesch wrote: > I am pretty sure this is the maximum _fragment_ size. But then why does it talk of MPDU and MSDU? from 802.11: synonym sMaxMsduLng Integer = 2304; /* max octets in an MSDU */ synonym sMaxMpduLng Integer = /* max octets in an MP

Re: softmac mtu

2006-09-28 Thread Jouni Malinen
On Thu, Sep 28, 2006 at 05:35:17PM +0200, Michael Buesch wrote: > On Wednesday 27 September 2006 15:55, Johannes Berg wrote: > > On Wed, 2006-09-27 at 15:57 +0200, [EMAIL PROTECTED] wrote: > > > Also I wonder what should be the max mtu. > > > > 2304, I think, as that's > > synonym sMaxMsduLng Inte

Re: softmac mtu

2006-09-28 Thread Michael Buesch
On Wednesday 27 September 2006 15:55, Johannes Berg wrote: > On Wed, 2006-09-27 at 15:57 +0200, [EMAIL PROTECTED] wrote: > > > Also I wonder what should be the max mtu. > > 2304, I think, as that's > synonym sMaxMsduLng Integer = 2304; /* max octets in an MSDU */ > > But maybe I'm interpreting t

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Michael Wu
On Thursday 28 September 2006 11:16, Larry Finger wrote: > First of all, my problem is quite likely caused by a buggy AP. It is a > Linksys WRT54G V5, which is one of those with a VxWorks kernel, not Linux. > I have already reported one bug to Linksys, which they have neither > acknowledged nor fix

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Michael Buesch
On Thursday 28 September 2006 17:16, Larry Finger wrote: > Dan Williams wrote: > > On Thu, 2006-09-28 at 16:43 +0200, Michael Buesch wrote: > >> On Thursday 28 September 2006 16:37, Dan Williams wrote: > >>> On Thu, 2006-09-28 at 16:27 +0200, Johannes Berg wrote: > On Thu, 2006-09-28 at 10:19

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Larry Finger
Dan Williams wrote: On Thu, 2006-09-28 at 16:43 +0200, Michael Buesch wrote: On Thursday 28 September 2006 16:37, Dan Williams wrote: On Thu, 2006-09-28 at 16:27 +0200, Johannes Berg wrote: On Thu, 2006-09-28 at 10:19 -0400, Dan Williams wrote: I'd buy that argument. When the driver gets th

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Michael Buesch
On Thursday 28 September 2006 16:52, Dan Williams wrote: > On Thu, 2006-09-28 at 16:43 +0200, Michael Buesch wrote: > > On Thursday 28 September 2006 16:37, Dan Williams wrote: > > > On Thu, 2006-09-28 at 16:27 +0200, Johannes Berg wrote: > > > > On Thu, 2006-09-28 at 10:19 -0400, Dan Williams wrot

Re: tc related lockdep warning.

2006-09-28 Thread Stephen Hemminger
On Thu, 28 Sep 2006 15:13:01 +0200 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On Thu, Sep 28, 2006 at 02:17:51PM +0200, Patrick McHardy wrote: > > [My mail provider is down, so responding "manually"] > > > > Jarek Poplawski wrote: > > > > [NET_SCHED]: Fix fallout from dev->qdisc RCU change > >

Re: Re the default linux tcp algorithm being changed from bic to cubic.

2006-09-28 Thread Stephen Hemminger
On Thu, 28 Sep 2006 11:07:18 +0100 Douglas Leith <[EMAIL PROTECTED]> wrote: > Content-Type: text/plain; charset=UTF-8; format=flowed > Content-Transfer-Encoding: 7bit > > Steve, > > I think we're all conscious of the fact that recent history contains > quite a number of proposals for changes to

Re: e100 changes in git-netdev-all break reboot with netconsole

2006-09-28 Thread Auke Kok
Andrew Morton wrote: Enable netconsole-over-e100, and `reboot -f' hangs. Disabling netconsole prevents that from happening. I assume what's happening is that the driver gets shut down and then something tries to do a printk through it, and things hang. For some reason sysrq-B still reboots the

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Dan Williams
On Thu, 2006-09-28 at 16:43 +0200, Michael Buesch wrote: > On Thursday 28 September 2006 16:37, Dan Williams wrote: > > On Thu, 2006-09-28 at 16:27 +0200, Johannes Berg wrote: > > > On Thu, 2006-09-28 at 10:19 -0400, Dan Williams wrote: > > > > > > > I'd buy that argument. When the driver gets th

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Johannes Berg
On Thu, 2006-09-28 at 10:37 -0400, Dan Williams wrote: > Yes, I think I did. My point here wasn't that the driver is _not_ > sending those messages (it almost certainly is), but what's _implied_ by > those messages. Namely that, if you're using a tool like wpa_supplicant > and/or NM, when you ge

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Michael Buesch
On Thursday 28 September 2006 16:37, Dan Williams wrote: > On Thu, 2006-09-28 at 16:27 +0200, Johannes Berg wrote: > > On Thu, 2006-09-28 at 10:19 -0400, Dan Williams wrote: > > > > > I'd buy that argument. When the driver gets the deauth message, > > > shouldn't it be sending an IWAP 00:00:00:00

Re: [PATCH] softmac: Fix WX and association related races

2006-09-28 Thread Dan Williams
On Thu, 2006-09-28 at 16:27 +0200, Johannes Berg wrote: > On Thu, 2006-09-28 at 10:19 -0400, Dan Williams wrote: > > > I'd buy that argument. When the driver gets the deauth message, > > shouldn't it be sending an IWAP 00:00:00:00:00:00 wireless event to > > userspace? > > I thought we did that

  1   2   >