Re: bcm43xx-d80211 broadcast reception with WPA

2006-11-10 Thread Paul Hampson
Michael Buesch bu3sch.de> writes: > On Thursday 09 November 2006 23:23, Paul Hampson wrote: > > I've been backporting the bcm43xx-d80211 driver to whatever the released > > 2.6 kernel was using the rt2x00 project's d80211 stack (equivalent to > > current wireless-dev but with a workaround for not

Re: [NETLINK]: Do precise netlink message allocations where possible

2006-11-10 Thread Paul Moore
Thomas Graf wrote: > * Paul Moore <[EMAIL PROTECTED]> 2006-11-10 11:04 > >>I like this approach, it makes much more sense to me then the previous >>implementation which was a simple "alias" to alloc_skb(). Also, the NetLabel >>relevant sections look fine to me. > > Question is wheter to do the s

Re: [PATCH] IPv6: optimize echo reply checksum calculation

2006-11-10 Thread Al Viro
On Fri, Nov 10, 2006 at 04:06:52PM -0500, Brian Haley wrote: > Al Viro wrote: > >On Fri, Nov 10, 2006 at 02:04:32PM -0500, Brian Haley wrote: > >>Al Viro wrote: > >>>so -= 1 is broken even on ia64 and it's *always* broken on big-endian > >>>boxen. > >>It's not broken in ia64, I've tested that, just

[GIT PULL 2.6.20] IPv6 Updates

2006-11-10 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. Please consider pulling following changesets from "2.6.19-rc5-net-2.6.20-20061110-to-davem" branch at: git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git Regards, HEADLINES - [IPV6] ROUTE: Use macros to format /proc/net/ipv6_route. [IPV6] ROUT

Re: [PATCH] IPv6: only modify checksum for UDP

2006-11-10 Thread Nivedita Singhvi
David Miller wrote: From: Nivedita Singhvi <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 15:17:06 -0800 WATCH YOUR QUOTING! That explains it! Arg! Sorry, DaveM, a bit on autopilot trying to put some tests together.. thanks, Nivedita - To unsubscribe from this list: send the line "unsubscrib

Re: [NET] Update documentation of skb_linearize

2006-11-10 Thread Francois Romieu
David Miller <[EMAIL PROTECTED]> : [...] > Yes it is. > > If the non-linear SKB has data in pages, we copy that data from the > pages into the new linear skb->data area and release the paged data. Right. The documentation talks about the skb _data_ so there is no reason to imagine that the funct

Re: [PATCH] IPv6: only modify checksum for UDP

2006-11-10 Thread David Miller
From: Nivedita Singhvi <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 15:17:06 -0800 WATCH YOUR QUOTING! > David Miller wrote: > > From: Brian Haley <[EMAIL PROTECTED]> > > Date: Fri, 10 Nov 2006 11:24:45 -0500 > > > >> Only change upper-layer checksum from 0 to 0x for UDP (as RFC 768 > >> stat

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Randy Dunlap
Thomas Graf wrote: * Randy Dunlap <[EMAIL PROTECTED]> 2006-11-10 14:49 I thought I chose GENL_NAMESIZ wisely but to be sure I checked with Mr. Alignment himself, Arnaldo: Hm, looks OK to me. Am I missing something? It is OK, I was merely trying to prove it :-) struct genl_family { u

Re: [PATCH] IPv6: only modify checksum for UDP

2006-11-10 Thread Nivedita Singhvi
David Miller wrote: From: Brian Haley <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 11:24:45 -0500 Only change upper-layer checksum from 0 to 0x for UDP (as RFC 768 states), not for others as RFC 4443 doesn't require it. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> Applied, thanks Brian.

Re: [PATCH] IPv6: only modify checksum for UDP

2006-11-10 Thread David Miller
From: Brian Haley <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 11:24:45 -0500 > Only change upper-layer checksum from 0 to 0x for UDP (as RFC 768 > states), not for others as RFC 4443 doesn't require it. > > Signed-off-by: Brian Haley <[EMAIL PROTECTED]> Applied, thanks Brian. - To unsubscrib

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Thomas Graf
* Randy Dunlap <[EMAIL PROTECTED]> 2006-11-10 14:49 > >I thought I chose GENL_NAMESIZ wisely but to be sure I checked > >with Mr. Alignment himself, Arnaldo: > > Hm, looks OK to me. Am I missing something? It is OK, I was merely trying to prove it :-) > >struct genl_family { > >unsigned

Re: [NET] Update documentation of skb_linearize

2006-11-10 Thread David Miller
From: Francois Romieu <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 23:03:55 +0100 > The data is not released. Yes it is. If the non-linear SKB has data in pages, we copy that data from the pages into the new linear skb->data area and release the paged data. - To unsubscribe from this list: send th

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Randy Dunlap
Thomas Graf wrote: * Randy Dunlap <[EMAIL PROTECTED]> 2006-11-10 10:23 On Fri, 10 Nov 2006 01:08:23 -0500 Paul Moore wrote: An Introduction To Using Generic Netlink === 3.1.2. The genl_family Structure Generic Netlink

Re: [PATCH 1/3] [NET]: Supporting UDP-Lite (RFC 3828) in Linux

2006-11-10 Thread Stephen Hemminger
On Fri, 10 Nov 2006 14:38:46 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Fri, 10 Nov 2006 09:37:15 -0800 > > > On Fri, 10 Nov 2006 16:09:20 + > > Gerrit Renker <[EMAIL PROTECTED]> wrote: > > > > > [NET/IPv4]: Support for the UDP-L

Re: [PATCH 1/3] [NET]: Supporting UDP-Lite (RFC 3828) in Linux

2006-11-10 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 09:37:15 -0800 > On Fri, 10 Nov 2006 16:09:20 + > Gerrit Renker <[EMAIL PROTECTED]> wrote: > > > [NET/IPv4]: Support for the UDP-Lite protocol (RFC 3828) > > > > This adds support for UDP-Lite to the IPv4 stack, provided as a

Re: [PATCH 1/3] [NET]: Supporting UDP-Lite (RFC 3828) in Linux

2006-11-10 Thread David Miller
I can't apply any of this Gerrit. What makes net/ipv4/udplite.c get built at all? I see no changes to net/ipv4/Makefile, so you must have stuffed up the generation of your patches. Please resubmit all 3 patches once you've corrected this and actually _tested_ the patch you submitted. You know,

Re : Source address selection + multicast

2006-11-10 Thread Pierre Ynard
Excuse me if I am bothering you again, but is there something so wrong with what I point out, or is multicasting so boring, that it doesn't even deserve an answer? :) Please consider. - Message d'origine > Preferred source address selection in the routing table ("src" field) > currently

Re: [NETLINK]: Do precise netlink message allocations where possible

2006-11-10 Thread Thomas Graf
* Paul Moore <[EMAIL PROTECTED]> 2006-11-10 11:04 > I like this approach, it makes much more sense to me then the previous > implementation which was a simple "alias" to alloc_skb(). Also, the NetLabel > relevant sections look fine to me. Question is wheter to do the same for genetlink and add ge

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Thomas Graf
* Randy Dunlap <[EMAIL PROTECTED]> 2006-11-10 10:23 > On Fri, 10 Nov 2006 01:08:23 -0500 Paul Moore wrote: > > > An Introduction To Using Generic Netlink > > === > > 3.1.2. The genl_family Structure > > > > Generic Netlin

Re: [IPv6] rules: Remove bogus tos validation check

2006-11-10 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 13:28:38 +0100 > Noticed by Al Viro: > (frh->tos & ~IPV6_FLOWINFO_MASK)) > where IPV6_FLOWINFO_MASK is htonl(0xfff) and frh->tos > is u8, which makes no sense here... > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied,

Re: [NETLINK]: Do precise netlink message allocations where possible

2006-11-10 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 11:04:14 -0500 > Thomas Graf wrote: > > Account for the netlink message header size directly in nlmsg_new() > > instead of relying on the caller calculate it correctly. > > > > Replaces error handling of message construction functions wh

Re: [PATCH] [TCP]: remove dead code in init_sequence

2006-11-10 Thread David Miller
From: Gerrit Renker <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 12:04:31 + > This removes two redundancies: > > 1) The test (skb->protocol == htons(ETH_P_IPV6) in tcp_v6_init_sequence() >is always true, due to > * tcp_v6_conn_request() is the only function calling this one > *

[NET] Update documentation of skb_linearize

2006-11-10 Thread Francois Romieu
The data is not released. drivers/net/mv643xx_eth.c apart, each current caller issues kfree_skb() when required. Signed-off-by: Francois Romieu <[EMAIL PROTECTED]> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 85577a4..380e344 100644 --- a/include/linux/skbuff.h +++ b/includ

Re: [PATCH] IPv6: optimize echo reply checksum calculation

2006-11-10 Thread Brian Haley
Al Viro wrote: On Fri, Nov 10, 2006 at 02:04:32PM -0500, Brian Haley wrote: Al Viro wrote: so -= 1 is broken even on ia64 and it's *always* broken on big-endian boxen. It's not broken in ia64, I've tested that, just don't have an x86 for testing right now. Can you please apply these changes a

Re: [RFT] mv643xxx_eth_start_xmit oops

2006-11-10 Thread Stephen Hemminger
On Fri, 10 Nov 2006 22:30:43 +0100 Francois Romieu <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> : > [...] > > skb_linearize is documented to free skb on failure. > > __skb_linearize > -> __pskb_pull_tail >-> pskb_expand_head > [...] > data = kmalloc(size +

Re: [RFT] mv643xxx_eth_start_xmit oops

2006-11-10 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : [...] > skb_linearize is documented to free skb on failure. __skb_linearize -> __pskb_pull_tail -> pskb_expand_head [...] data = kmalloc(size + sizeof(struct skb_shared_info), gfp_mask); if (!data) goto nodata;

Re: [RFT] mv643xxx_eth_start_xmit oops

2006-11-10 Thread Stephen Hemminger
On Fri, 10 Nov 2006 22:03:43 +0100 Francois Romieu <[EMAIL PROTECTED]> wrote: > Dale Farnsworth <[EMAIL PROTECTED]> : > [...] > > Can you provide more detail about the leak? > > + if (has_tiny_unaligned_frags(skb) && __skb_linearize(skb)) { > + stats->tx_dropped++; > +

Re: [RFT] mv643xxx_eth_start_xmit oops

2006-11-10 Thread Francois Romieu
Dale Farnsworth <[EMAIL PROTECTED]> : [...] > Can you provide more detail about the leak? + if (has_tiny_unaligned_frags(skb) && __skb_linearize(skb)) { + stats->tx_dropped++; + if (net_ratelimit()) + printk(KERN_DEBUG "%s: failed to lineariz

Re: [RFT] mv643xxx_eth_start_xmit oops

2006-11-10 Thread Dale Farnsworth
In article <[EMAIL PROTECTED]> you write: Ueimor <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> : > [...] > > diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c > [...] > > It seems to propagate a leak from the initial codebase. Can you provide more detail abou

Re: [patch 1/9] bonding: lockdep annotation

2006-11-10 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 11:09:25 -0500 > [EMAIL PROTECTED] wrote: > > From: Peter Zijlstra <[EMAIL PROTECTED]> > > > > = > > [ INFO: possible recursive locking detected ] > > 2.6.17-1.2600.fc6 #1 > >

Re: [patch sungem] improved locking

2006-11-10 Thread David Miller
From: "Eric Lemoine" <[EMAIL PROTECTED]> Date: Fri, 10 Nov 2006 14:28:41 +0100 > On 11/10/06, David Miller <[EMAIL PROTECTED]> wrote: > > > > Please use GREG_STAT_* instead of magic constants for the > > interrupt mask and ACK register writes. In fact, there are > > some questionable values you u

Re: [patch sungem] improved locking

2006-11-10 Thread Benjamin Herrenschmidt
> Yes, the bit 4 isn't used, but I assumed clearing it shouldn't be prolem. Always leave reserved bits alone ... I agree it's very unlikely in this case that it could cause a problem but I've seen stranger things Ben. - To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: [RFT] mv643xxx_eth_start_xmit oops

2006-11-10 Thread Francois Romieu
Stephen Hemminger <[EMAIL PROTECTED]> : [...] > diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c > index 9997081..4052bfe 100644 > --- a/drivers/net/mv643xx_eth.c > +++ b/drivers/net/mv643xx_eth.c > @@ -1191,25 +1191,23 @@ static int mv643xx_eth_start_xmit(struct > struct ne

Re: bcm43xx-d80211 broadcast reception with WPA

2006-11-10 Thread Michael Buesch
On Thursday 09 November 2006 23:23, Paul Hampson wrote: > Hi, > > Long time lurker, first time poster. ^_^ > > I've been backporting the bcm43xx-d80211 driver to whatever the released > 2.6 kernel was using the rt2x00 project's d80211 stack (equivalent to > current wireless-dev but with a workaro

[RFT] mv643xxx_eth_start_xmit oops

2006-11-10 Thread Stephen Hemminger
On Fri, 10 Nov 2006 12:17:45 -0700 Erik Andersen <[EMAIL PROTECTED]> wrote: > I have a Pegasos2 powerpc system acting as my home server. With > 2.6.16.x it was 100% stable and I had months of uptime, rebooting > only to periodically apply security updates to the kernel. > > With 2.6.17 and 2.6.1

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Paul Moore
Randy Dunlap wrote: > On Fri, 10 Nov 2006 01:08:23 -0500 Paul Moore wrote: > >>An Introduction To Using Generic Netlink >>=== >>3.1.2. The genl_family Structure >> >>Generic Netlink services are defined by the genl_family

Re: [PATCH] spidernet: fix transmit routine.

2006-11-10 Thread Stephen Hemminger
On Fri, 10 Nov 2006 13:10:25 -0600 James K Lewis <[EMAIL PROTECTED]> wrote: > Stephen, > > I had already tried that previously, the fail still occurred. Note that > the skb_pad (or skb_padto) never actually fails. There is just something > about calling it that causes the hang. Note too that

Re: [PATCH] IPv6: optimize echo reply checksum calculation

2006-11-10 Thread Al Viro
On Fri, Nov 10, 2006 at 02:04:32PM -0500, Brian Haley wrote: > Al Viro wrote: > >so -= 1 is broken even on ia64 and it's *always* broken on big-endian > >boxen. > > It's not broken in ia64, I've tested that, just don't have an x86 for > testing right now. Can you please apply these changes and p

Re: [PATCH] IPv6: optimize echo reply checksum calculation

2006-11-10 Thread Brian Haley
Al Viro wrote: so -= 1 is broken even on ia64 and it's *always* broken on big-endian boxen. It's not broken in ia64, I've tested that, just don't have an x86 for testing right now. Can you please apply these changes and prove it's broken? This little trick has been done in other UNIXes for

[PATCH] spidernet: fix transmit routine.

2006-11-10 Thread Stephen Hemminger
Try this patch instead (I don't have the hardware to even build). Fix spider_net transmit routine: 1. use skb_padto properly 2. don't return -ENOMEM. Only valid returns from device transmit routine are NETDEV_TX_OK, BUSY, LOCKED Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- dri

Re: [PATCH] dccp: remove module exit functions

2006-11-10 Thread Arnaldo Carvalho de Melo
On 11/10/06, James Morris <[EMAIL PROTECTED]> wrote: On Fri, 10 Nov 2006, James Morris wrote: > I wonder if this facility can be integrated more generally into the kernel > protocol which people are developing. Ugh, editor screwup. That was meant to be I wonder if this facility can be integra

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Randy Dunlap
On Fri, 10 Nov 2006 01:08:23 -0500 Paul Moore wrote: > An Introduction To Using Generic Netlink > === > 3.1.2. The genl_family Structure > > Generic Netlink services are defined by the genl_family structure, which is > sh

Re: [PATCH] IPv6: optimize echo reply checksum calculation

2006-11-10 Thread Al Viro
On Fri, Nov 10, 2006 at 06:05:34PM +, Al Viro wrote: > On Fri, Nov 10, 2006 at 12:51:19PM -0500, Brian Haley wrote: > > Al Viro wrote: > > >On Fri, Nov 10, 2006 at 11:25:53AM -0500, Brian Haley wrote: > > >>Since the only difference between echo requests and echo replies is the > > >>ICMPv6 ty

Re: [PATCH] Spidernet - remove ETH_ZLEN check in earlier patch

2006-11-10 Thread Stephen Hemminger
On Fri, 10 Nov 2006 11:50:46 -0600 Jim Lewis <[EMAIL PROTECTED]> wrote: > Subject: Spidernet - remove ETH_ZLEN check in earlier patch > From: James K Lewis <[EMAIL PROTECTED]> > > In an earlier patch, code was added to pad packets that were less that > ETH_ZLEN (60) bytes using the skb_pad functi

Re: [PATCH] IPv6: optimize echo reply checksum calculation

2006-11-10 Thread Al Viro
On Fri, Nov 10, 2006 at 12:51:19PM -0500, Brian Haley wrote: > Al Viro wrote: > >On Fri, Nov 10, 2006 at 11:25:53AM -0500, Brian Haley wrote: > >>Since the only difference between echo requests and echo replies is the > >>ICMPv6 type value (which is a difference of 1), just subtracting one > >>fr

Re: Questions regarding network drivers

2006-11-10 Thread Stephen Hemminger
On Fri, 10 Nov 2006 09:34:33 -0800 (PST) Jonathan Day <[EMAIL PROTECTED]> wrote: > > --- Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > > On Thu, Nov 09, 2006 at 07:06:00PM -0800, Jonathan > > Day ([EMAIL PROTECTED]) wrote: > > > Hi, > > > > > > I've got an interesting problem to contend with

Re: [PATCH] IPv6: only modify checksum for UDP

2006-11-10 Thread David Stevens
Sorry, I saw this discussion a little late... The Internet checksum is defined as a 1's-complement sum, so if the alternate 0 does not have a special meaning in a protocol, then by 1's-complement arithmetic, 0 == ~0. So, it looks to me without the remapping that a valid checksum may also

Re: [PATCH] IPv6: optimize echo reply checksum calculation

2006-11-10 Thread Brian Haley
Al Viro wrote: On Fri, Nov 10, 2006 at 11:25:53AM -0500, Brian Haley wrote: Since the only difference between echo requests and echo replies is the ICMPv6 type value (which is a difference of 1), just subtracting one from the request checksum will result in the correct checksum for the reply.

[PATCH] Spidernet - remove ETH_ZLEN check in earlier patch

2006-11-10 Thread Jim Lewis
Subject: Spidernet - remove ETH_ZLEN check in earlier patch From: James K Lewis <[EMAIL PROTECTED]> In an earlier patch, code was added to pad packets that were less that ETH_ZLEN (60) bytes using the skb_pad function. This has caused hangs when accessing certain NFS mounted file systems. This pat

Re: [IPROUTE2] Add rule notification support to ip monitor

2006-11-10 Thread Stephen Hemminger
applied thanks - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] [NET]: Supporting UDP-Lite (RFC 3828) in Linux

2006-11-10 Thread Stephen Hemminger
On Fri, 10 Nov 2006 16:09:20 + Gerrit Renker <[EMAIL PROTECTED]> wrote: > [NET/IPv4]: Support for the UDP-Lite protocol (RFC 3828) > > This adds support for UDP-Lite to the IPv4 stack, provided as an extension > to the existing UDPv4 code: > * generic routines are all located in net/ipv

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Thomas Graf
* Jarek Poplawski <[EMAIL PROTECTED]> 2006-11-10 14:24 > @@ -449,7 +449,7 @@ > > The second step is to define the operations for the family, which we do by > creating at least one instance of the genl_ops structure which we explained > in > -section 3.1.2.. In this example we are only going t

Re: Questions regarding network drivers

2006-11-10 Thread Jonathan Day
--- Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > On Thu, Nov 09, 2006 at 07:06:00PM -0800, Jonathan > Day ([EMAIL PROTECTED]) wrote: > > Hi, > > > > I've got an interesting problem to contend with > and > > need some advice from the great wise ones here. > > > > First of all, is it possible (a

Re: [PATCH] IPv6: optimize echo reply checksum calculation

2006-11-10 Thread Al Viro
On Fri, Nov 10, 2006 at 11:25:53AM -0500, Brian Haley wrote: > Since the only difference between echo requests and echo replies is the > ICMPv6 type value (which is a difference of 1), just subtracting one > from the request checksum will result in the correct checksum for the reply. Um, no. Th

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Randy Dunlap
On Fri, 10 Nov 2006 11:17:11 -0500 Paul Moore wrote: > jamal wrote: > > On Fri, 2006-10-11 at 01:45 -0500, Paul Moore wrote: > > > >>James Morris wrote: > >> > An Introduction To Using Generic Netlink > === > >>>

Re: [PATCH] dccp: remove module exit functions

2006-11-10 Thread James Morris
On Fri, 10 Nov 2006, James Morris wrote: > I wonder if this facility can be integrated more generally into the kernel > protocol which people are developing. Ugh, editor screwup. That was meant to be I wonder if this facility can be integrated more generally into the kernel as a kernel hacki

[PATCH] IPv6: optimize echo reply checksum calculation

2006-11-10 Thread Brian Haley
Since the only difference between echo requests and echo replies is the ICMPv6 type value (which is a difference of 1), just subtracting one from the request checksum will result in the correct checksum for the reply. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv6/icmp.c b

Re: [PATCH] dccp: remove module exit functions

2006-11-10 Thread James Morris
On Fri, 10 Nov 2006, Arnaldo Carvalho de Melo wrote: > On 11/10/06, James Morris <[EMAIL PROTECTED]> wrote: > > The dccp ipv4 & ipv6 modules cannot be unloaded, as their control sockets > > each maintain a couple of module references. So, it seems like a good > > idea to just remove the module ex

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Paul Moore
Stephen Hemminger wrote: > Paul Moore wrote: > >>A couple of months ago I promised Jamal and Thomas I would post some comments >>to >>Jamal's original genetlink how-to. However, as I started to work on the >>document the diff from the original started to get a little ridiculous so >>instead of p

[PATCH] IPv6: only modify checksum for UDP

2006-11-10 Thread Brian Haley
Only change upper-layer checksum from 0 to 0x for UDP (as RFC 768 states), not for others as RFC 4443 doesn't require it. Signed-off-by: Brian Haley <[EMAIL PROTECTED]> diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index 81bd45b..dbb9b1f 100644 --- a/net/ipv6/icmp.c +++ b/net/ipv6/icmp.c @@

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Paul Moore
jamal wrote: > On Fri, 2006-10-11 at 01:45 -0500, Paul Moore wrote: > >>James Morris wrote: >> An Introduction To Using Generic Netlink === >>> >>> >>>Wow, this is great! >> >>Thanks. I consider it an act of penan

[git patches] net driver fixes

2006-11-10 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/arcnet/com20020.c |7 +-- drivers/net/bonding/bond_main.c |5 + drivers/net/cris

Re: Please pull 'upstream-fixes' branch of wireless-2.6

2006-11-10 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit edd106fc8ac1826dbe231b70ce0762db24133e5c: Auke Kok: e1000: Fix regression: garbled stats and irq allocation during swsusp are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.

[PATCH 1/3] [NET]: Supporting UDP-Lite (RFC 3828) in Linux

2006-11-10 Thread Gerrit Renker
[NET/IPv4]: Support for the UDP-Lite protocol (RFC 3828) This adds support for UDP-Lite to the IPv4 stack, provided as an extension to the existing UDPv4 code: * generic routines are all located in net/ipv4/udp.c * UDP-Lite specific routines are in net/ipv4/udplite.c * MIB/

Re: [patch 2/9] com20020 build fix

2006-11-10 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Randy Dunlap <[EMAIL PROTECTED]> com20020.c needs to export functions if either of the ISA or PCI modules are built as loadable modules. Or they could always be exported. WARNING: "com20020_found" [drivers/net/arcnet/com20020-pci.ko] undefined! WARNING: "com20020

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Paul Moore
Jarek Poplawski wrote: > On 10-11-2006 07:08, Paul Moore wrote: > ... > >>An Introduction To Using Generic Netlink >>=== > > ... > > Here is a proposal of small adjustments. > Maybe some of them will be useful. They al

Re: [patch 5/5] drivers cris: return on NULL dev_alloc_skb()

2006-11-10 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: David Rientjes <[EMAIL PROTECTED]> If the next descriptor array entry cannot be allocated by dev_alloc_skb(), return immediately so it is not dereferenced later. We cannot register the device with a partial descriptor list. Cc: Mikael Starvik <[EMAIL PROTECTED]>

Re: [patch 1/9] bonding: lockdep annotation

2006-11-10 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Peter Zijlstra <[EMAIL PROTECTED]> = [ INFO: possible recursive locking detected ] 2.6.17-1.2600.fc6 #1 - applied; please CC me on this drivers/net stuff - To unsubscribe f

[PATCH 3/3] [NET]: UDP-Lite misc files

2006-11-10 Thread Gerrit Renker
[NET]: UDP-Lite Documentation and basic XFRM/Netfilter support This provides * API documentation for UDP-Lite * basic xfrm support * basic netfilter support for IPv4 and IPv6 (LOG target) Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]> --

[PATCH 2/3] [NET/IPv6]: UDP-Litev6 support

2006-11-10 Thread Gerrit Renker
[NET/IPv6]: Extension for UDP-Lite over IPv6 This extends the existing UDPv6 code base with support for UDP-Lite in the same manner as per UDPv4. In particular, * UDPv6 generic and shared code is in net/ipv6/udp.c * UDP-Litev6 specific extensions are in net/ipv6/udplite.c *

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Paul Moore
Thomas Graf wrote: > * Paul Moore <[EMAIL PROTECTED]> 2006-11-10 01:08 > > Excellent! Thanks. >> - u32 snd_pid >> >> This is the PID of the client which issued the request. > > In order to avoid confusion it might be better to call it > "netlink PID" as it is not equal to the process ID.

Re: [NETLINK]: Do precise netlink message allocations where possible

2006-11-10 Thread Paul Moore
Thomas Graf wrote: > Account for the netlink message header size directly in nlmsg_new() > instead of relying on the caller calculate it correctly. > > Replaces error handling of message construction functions when > constructing notifications with bug traps since a failure implies > a bug in calc

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Stephen Hemminger
Paul Moore wrote: A couple of months ago I promised Jamal and Thomas I would post some comments to Jamal's original genetlink how-to. However, as I started to work on the document the diff from the original started to get a little ridiculous so instead of posting a patch against Jamal's original

Re: [PATCH wireless-2.6-git] prism54: WPA/RSN support for fullmac cards

2006-11-10 Thread Dan Williams
On Thu, 2006-11-09 at 18:16 -0500, Luis R. Rodriguez wrote: > On 11/9/06, Luis R. Rodriguez <[EMAIL PROTECTED]> wrote: > > On 11/9/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > Am Mittwoch, 8. November 2006 01:39 schrieben Sie: > > > > On Fri, Nov 03, 2006 at 01:41:46PM -0500, Luis R. Rodr

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread jamal
On Fri, 2006-10-11 at 01:45 -0500, Paul Moore wrote: > James Morris wrote: > >>An Introduction To Using Generic Netlink > >>=== > > > > > > Wow, this is great! > > Thanks. I consider it an act of penance for all of the

Re: [PATCHSET] packet mark & fib rules work

2006-11-10 Thread Thomas Graf
* Steven Whitehouse <[EMAIL PROTECTED]> 2006-11-09 14:55 > So here is roughly what I was thinking... this comes from having > spent a little while thinking about the best way to integrate > MPLS into the network stack. An MPLS label is 32 bits in size > which conviently matches the size of the pack

Re: [PATCH] dccp: remove module exit functions

2006-11-10 Thread Arnaldo Carvalho de Melo
On 11/10/06, James Morris <[EMAIL PROTECTED]> wrote: The dccp ipv4 & ipv6 modules cannot be unloaded, as their control sockets each maintain a couple of module references. So, it seems like a good idea to just remove the module exit functions completely. Please review. Well, I have a patch in

Re: [patch sungem] improved locking

2006-11-10 Thread Eric Lemoine
On 11/10/06, David Miller <[EMAIL PROTECTED]> wrote: Please use GREG_STAT_* instead of magic constants for the interrupt mask and ACK register writes. In fact, there are some questionable values you use, in particular this one: +static inline void gem_ack_int(struct gem *gp) +{ + writel(

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Jarek Poplawski
On 10-11-2006 07:08, Paul Moore wrote: ... > An Introduction To Using Generic Netlink > === ... Here is a proposal of small adjustments. Maybe some of them will be useful. Best regards, Jarek P. --- --- netlink.txt-

[IPv6] rules: Remove bogus tos validation check

2006-11-10 Thread Thomas Graf
Noticed by Al Viro: (frh->tos & ~IPV6_FLOWINFO_MASK)) where IPV6_FLOWINFO_MASK is htonl(0xfff) and frh->tos is u8, which makes no sense here... Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6.20/net/ipv6/fib6_rules.c =

[NETLINK]: Do precise netlink message allocations where possible

2006-11-10 Thread Thomas Graf
Account for the netlink message header size directly in nlmsg_new() instead of relying on the caller calculate it correctly. Replaces error handling of message construction functions when constructing notifications with bug traps since a failure implies a bug in calculating the size of the skb. S

Re: Intel 82559 NIC corrupted EEPROM

2006-11-10 Thread John
Jesse Brandeburg wrote: Can you send output of cat /proc/iomem -0009 : System RAM 000a-000b : Video RAM area 000f-000f : System ROM 0010-0ffe : System RAM 0010-00296a1a : Kernel code 00296a1b-0031bbe7 : Kernel data 0fff-0fff2fff : ACPI Non-volati

[PATCH] [TCP]: remove dead code in init_sequence

2006-11-10 Thread Gerrit Renker
This removes two redundancies: 1) The test (skb->protocol == htons(ETH_P_IPV6) in tcp_v6_init_sequence() is always true, due to * tcp_v6_conn_request() is the only function calling this one * tcp_v6_conn_request() redirects all skb's with ETH_P_IP protocol to tcp_v4_co

[IPROUTE2] Add rule notification support to ip monitor

2006-11-10 Thread Thomas Graf
Index: iproute2.git/ip/ip_common.h === --- iproute2.git.orig/ip/ip_common.h2006-11-10 12:22:46.0 +0100 +++ iproute2.git/ip/ip_common.h 2006-11-10 12:23:06.0 +0100 @@ -20,6 +20,8 @@ struct nlms

hostap_cs_{resume,suspend}(): inconsequent NULL checking

2006-11-10 Thread Adrian Bunk
The Coverity checker spotted the following in drivers/net/wireless/hostap/hostap_cs.c: <-- snip --> ... static int hostap_cs_suspend(struct pcmcia_device *link) { struct net_device *dev = (struct net_device *) link->priv; int dev_open = 0; struct hostap_interface *iface

Re: Questions regarding network drivers

2006-11-10 Thread Evgeniy Polyakov
On Thu, Nov 09, 2006 at 07:06:00PM -0800, Jonathan Day ([EMAIL PROTECTED]) wrote: > Hi, > > I've got an interesting problem to contend with and > need some advice from the great wise ones here. > > First of all, is it possible (and/or "reasonable > practice") when developing a network driver to

Re: Generic Netlink HOW-TO based on Jamal's original doc

2006-11-10 Thread Thomas Graf
* Paul Moore <[EMAIL PROTECTED]> 2006-11-10 01:08 Excellent! >- u32 snd_pid > > This is the PID of the client which issued the request. In order to avoid confusion it might be better to call it "netlink PID" as it is not equal to the process ID. - To unsubscribe from this list: send th

Re: bcm43xx-d80211 broadcast reception with WPA

2006-11-10 Thread Paul Hampson
Ivo Van Doorn gmail.com> writes: > > I've been backporting the bcm43xx-d80211 driver to whatever the released > > using the rt2x00 project's d80211 stack > Just a note about that stack, it should only be used on kernel 2.6.17 > and higher. Thanks, I've noted that at the berlios wiki. -- Paul "T

Re: [Bugme-new] [Bug 7483] New: Unable to handle kernel paging request for data at address 0x5a5a5a5a5a5a5a5a

2006-11-10 Thread Andrew Morton
(switching to email - please follow up via reply-to-all and not via bugzilla) On Fri, 10 Nov 2006 00:48:31 -0800 [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=7483 > >Summary: Unable to handle kernel paging request for data at > address 0x

[PATCH] dccp: remove module exit functions

2006-11-10 Thread James Morris
The dccp ipv4 & ipv6 modules cannot be unloaded, as their control sockets each maintain a couple of module references. So, it seems like a good idea to just remove the module exit functions completely. Please review. Signed-off-by: James Morris <[EMAIL PROTECTED]> --- net/dccp/ipv4.c |8

Re: bcm43xx-d80211 broadcast reception with WPA

2006-11-10 Thread Ivo Van Doorn
Hi, I've been backporting the bcm43xx-d80211 driver to whatever the released 2.6 kernel was using the rt2x00 project's d80211 stack (equivalent to current wireless-dev but with a workaround for not having a ieee80211_dev pointer and still using the _tfm interface instead of the _cypher interface