Re: [PATCH] xfrm: fix the return code when xfrm_*_register_afinfo failed

2015-04-27 Thread Steffen Klassert
On Thu, Apr 23, 2015 at 11:06:53AM +0800, roy.qing...@gmail.com wrote: From: Li RongQing roy.qing...@gmail.com If xfrm_*_register_afinfo failed since xfrm_*_afinfo[afinfo-family] had the value, return the -EEXIST, not -ENOBUFS Signed-off-by: Li RongQing roy.qing...@gmail.com Also applied

Re: [PATCH][net-next] xfrm: slightly optimise xfrm_input

2015-04-27 Thread Steffen Klassert
On Fri, Apr 24, 2015 at 04:49:31PM +0800, roy.qing...@gmail.com wrote: From: Li RongQing roy.qing...@gmail.com Check x-km.state with XFRM_STATE_ACQ only when state is not XFRM_STAT_VALID, not everytime Signed-off-by: Li RongQing roy.qing...@gmail.com Applied to ipsec-next, thanks a lot

[PATCH] net: phy: micrel: support !CONFIG_HAVE_CLK

2015-04-27 Thread Niklas Cassel
Since NULL is a valid clock, we shouldn't use IS_ERR_OR_NULL. Implemented as Russell King suggested in: http://lkml.kernel.org/r/20150207172949.ge8...@n2100.arm.linux.org.uk Signed-off-by: Niklas Cassel nikl...@axis.com --- drivers/net/phy/micrel.c | 7 +-- 1 file changed, 5 insertions(+),

Re: v3.12-stable-queue build errors

2015-04-27 Thread Jiri Slaby
On 04/25/2015, 04:16 PM, Guenter Roeck wrote: Several powerpc build fail with: drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit': drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration of function 'dev_consume_skb_any'

RE: [PATCH v3] Renesas Ethernet AVB driver

2015-04-27 Thread David Laight
From: Sergei Shtylyov Sent: 24 April 2015 19:27 ... If you have ethernet hardware that requires tx or rx buffers to be on 4n boundaries you should send it back as 'not fit for purpose'. The RX buffers can be adjusted with skb_resrerve(), it's only the TX buffers that need to be

Hello dear

2015-04-27 Thread Regina Sanchez
Hi dear, It is my pleasure to meet you , I hope all is well with you. I am Regina Sanchez, a United States army officer from the United States of America. I am supportive, loving and humble. I really need a good friend with whom I can have a genuine , meaningful and intimate relationship full

Re: [PATCH] net: phy: micrel: support !CONFIG_HAVE_CLK

2015-04-27 Thread Johan Hovold
On Mon, Apr 27, 2015 at 01:05:17PM +0200, Johan Hovold wrote: On Mon, Apr 27, 2015 at 01:00:50PM +0200, Niklas Cassel wrote: Since NULL is a valid clock, we shouldn't use IS_ERR_OR_NULL. Implemented as Russell King suggested in:

[PATCH net V1] net/mlx4_en: Prevent setting invalid RSS hash function

2015-04-27 Thread Amir Vadai
mlx4_en_check_rxfh_func() was checking for hardware support before setting a known RSS hash function, but didn't do any check before setting unknown RSS hash function. Need to make it fail on such values. In this occasion, moved the actual setting of the new value from the check function into

Re: [PATCH][net-next][v2] xfrm: optimise the use of walk list header in xfrm_policy/state_walk

2015-04-27 Thread Steffen Klassert
On Wed, Apr 22, 2015 at 05:13:18PM +0800, Herbert Xu wrote: On Wed, Apr 22, 2015 at 05:09:54PM +0800, roy.qing...@gmail.com wrote: From: Li RongQing roy.qing...@gmail.com The walk from input is the list header, and marked as dead, and will be skipped in loop. list_first_entry() can

Re: [PATCH] xfrm: remove the xfrm_queue_purge definition

2015-04-27 Thread Steffen Klassert
On Wed, Apr 22, 2015 at 03:51:16PM +0800, roy.qing...@gmail.com wrote: From: Li RongQing roy.qing...@gmail.com The task of xfrm_queue_purge is same as skb_queue_purge, so remove it Signed-off-by: Li RongQing roy.qing...@gmail.com Applied to ipsec-next, thanks! -- To unsubscribe from this

Re: [PATCH net 0/2] net/ethtool, mlx4_en: RSS hash function setting fixes

2015-04-27 Thread Amir Vadai
On 4/27/2015 6:02 AM, David Miller wrote: From: Amir Vadai am...@mellanox.com Date: Sun, 26 Apr 2015 17:36:04 +0300 Hash function is represented as an eight bit field, every bit represents a function. Currently possible values are: 1 for Toeplitz and 2 for XOR. This commit changes the

Re: [PATCH] net: phy: micrel: support !CONFIG_HAVE_CLK

2015-04-27 Thread Johan Hovold
On Mon, Apr 27, 2015 at 01:00:50PM +0200, Niklas Cassel wrote: Since NULL is a valid clock, we shouldn't use IS_ERR_OR_NULL. Implemented as Russell King suggested in: http://lkml.kernel.org/r/20150207172949.ge8...@n2100.arm.linux.org.uk Signed-off-by: Niklas Cassel nikl...@axis.com ---

[PATCH net V1] ethtool: Support for configurable RSS hash function

2015-04-27 Thread Amir Vadai
From: Eyal Perry eya...@mellanox.com This ethtool patch adds support to set and get the current RSS hash function for the device through through the new hfunc field in the ethtool_rxfh struct. Kernel supported hash function names are queried with ETHTOOL_GSTRINGS (value 0 is reserved and

[PATCH net] bpf: fix 64-bit divide

2015-04-27 Thread Alexei Starovoitov
ALU64_DIV instruction should be dividing 64-bit by 64-bit, whereas do_div() does 64-bit by 32-bit divide. x64 and arm64 JITs correctly implement 64 by 64 unsigned divide. llvm BPF backend emits code assuming that ALU64_DIV does 64 by 64. Fixes: 89aa075832b0 (net: sock: allow eBPF programs to be

[PATCH 3.12 04/83] net: ethernet: pcnet32: Setup the SRAM and NOUFLO on Am79C97{3, 5}

2015-04-27 Thread Jiri Slaby
From: Markos Chandras markos.chand...@imgtec.com 3.12-stable review patch. If anyone has any objections, please let me know. === commit 87f966d97b89774162df04d2106c6350c8fe4cb3 upstream. On a MIPS Malta board, tons of fifo underflow errors have been observed when using u-boot as

Re: [PATCH 04/16] printk: implement support for extended console drivers

2015-04-27 Thread Tejun Heo
Hello, Petr. Sorry about the delay. On Mon, Apr 20, 2015 at 05:43:07PM +0200, Petr Mladek wrote: ... * Extended message formatting for console drivers is enabled iff there s/iff/if/ if and only if I was afraid that there might be a potential buffer overflow because the user-provided

Re: [PATCH 1/2] brcmfmac: prohibit ACPI power management for brcmfmac driver

2015-04-27 Thread Arend van Spriel
On 04/27/15 07:00, Fu, Zhonghui wrote: ACPI will manage WiFi chip's power state during suspend/resume process on some tablet platforms(such as ASUS T100TA). This is not supported by brcmfmac driver now, and the context of WiFi chip will be damaged after resume. This patch disconnects the

[bisected] ICMP fragmentation needed ignored / PMTU discovery broken since 3.19-rc7

2015-04-27 Thread Gerd v. Egidy
Hi, my colleagues recently reported that they had spurious problems connecting to a specific server via ssh. Investigation showed that the kernel completely ignored the ICMP dest. unreachable / fragmentation needed packets in this case: client.45662 server.22: Flags [S], seq 3738194662, win

Re: [RFC 2/3] tc: deprecate TC_ACT_QUEUED

2015-04-27 Thread Jamal Hadi Salim
On 04/23/15 20:59, Alexei Starovoitov wrote: On 4/23/15 3:51 PM, Jamal Hadi Salim wrote: So you are planning to add queues? If you are that is a different discussion (and the use case needs some clarity). nope. I wasn't planning to do that. Then i would say, lets just keep the naming

Re: [PATCH 00/21] ARCNET: Defibrillation

2015-04-27 Thread Michael Grzeschik
Hi! On Fri, Apr 24, 2015 at 11:58:53PM -0400, David Miller wrote: From: Marc Kleine-Budde m...@pengutronix.de Date: Fri, 24 Apr 2015 23:14:41 +0200 On 04/24/2015 08:47 PM, Joe Perches wrote: On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote: Hi! Hello. This patch

Re: [PATCH 06/21] ARCNET: com20020: remove unneeded macros

2015-04-27 Thread Michael Grzeschik
On Fri, Apr 24, 2015 at 04:04:45PM -0700, Joe Perches wrote: On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote: The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK and ADIAGSTATUS are unnecessary indirections to the use of registers. This patch removes them and

[PATCH 1/2] net:treewide: Fix typo in drivers/net

2015-04-27 Thread Masanari Iida
This patch fix spelling typo in printk. Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/net/can/usb/kvaser_usb.c | 2 +- drivers/net/ethernet/8390/etherh.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/usb/kvaser_usb.c

[PATCH 2/2] net:wireless:treewide: Fix typo in drivers/net/wireless

2015-04-27 Thread Masanari Iida
This patch fix some spelling typo in drivers/net/wirless Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/net/wireless/mwifiex/tdls.c | 2 +- drivers/net/wireless/rtlwifi/rtl8192ee/fw.c | 2 +- drivers/net/wireless/rtlwifi/rtl8723be/fw.c | 2 +- 3 files changed, 3

[PATCH net-next v2 4/4] ibmveth: Add support for Large Receive Offload

2015-04-27 Thread Thomas Falcon
Enables receiving large packets from other LPARs. These packets have a -1 IP header checksum, so we must recalculate to have a valid checksum. Signed-off-by: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- v2: -Included statistics that were

Re: [Problem] broadcom tg3 network driver disconnects under high load

2015-04-27 Thread Toan Pham
Michael, Please see attach files. BTW, I have also tested this bug on at least 8 different HP 705 PCs with the 5762 NIC, so it is probably not a manufacturer defect. In addition, I can never replicate the same issue on the older chipset, BCM5761, which can be found on the HP model 6005. I

[PATCH net-next v2 2/4] ibmveth: Add support for TSO

2015-04-27 Thread Thomas Falcon
Add support for TSO. TSO is turned off by default and must be enabled and configured by the user. The driver version number is increased so that users can be sure that they are using ibmveth with TSO support. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon

[PATCH net-next v2 1/4] ibmveth: change rx buffer default allocation for CMO

2015-04-27 Thread Thomas Falcon
This patch enables 64k rx buffer pools by default. If Cooperative Memory Overcommitment (CMO) is enabled, the number of 64k buffers is reduced to save memory. Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Thomas Falcon tlfal...@linux.vnet.ibm.com --- drivers/net/ethernet/ibm/ibmveth.c

Re: [PATCH v3 iproute2] ip: Add color output option

2015-04-27 Thread Stephen Hemminger
Patch does not apply cleanly to current version in git. All patches should be based off of http://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git I suspect your mailer is corrupting whitespace. Maybe easier to send patch as an attachment. $ patch -p1

[PATCH RFC] net/macb: Fix UDPv4 checksum offload

2015-04-27 Thread Jaeden Amero
From: Jeff Westfahl jeff.westf...@ni.com Some Cadence MACB hardware generates incorrect UDP checksums for outgoing UDP packets with a payload of 2 bytes of less. If the UDP data payload is 0, 1 or 2 bytes, transmit checksum offloading can compute an incorrect UDPv4 header checksum (e.g. 0x).

Re: [PATCH net-next v2 4/4] ibmveth: Add support for Large Receive Offload

2015-04-27 Thread Eric Dumazet
On Mon, 2015-04-27 at 17:10 -0500, Thomas Falcon wrote: + if (be16_to_cpu(skb-protocol) == ETH_P_IP) { + skb_set_network_header(skb, 0); + skb_set_transport_header(skb, sizeof(struct

[PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit()

2015-04-27 Thread K. Y. Srinivasan
Commit commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory allocation in the packet send path. This commit introduced a bug since it did not account for the case if the skb was cloned. Fix this bug by using the pre-reserved head room only if the skb is not cloned. Signed-off-by: K.

RE: [PATCH v1 net-next 1/3] igb: set driver data for device entries that were missing

2015-04-27 Thread Brown, Aaron F
From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Jonathan Toppins Sent: Monday, April 27, 2015 8:42 AM To: Kirsher, Jeffrey T Cc: Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn; Skidmore, Donald C; Vick, Matthew; Ronciak, John; Williams, Mitch A;

RE: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit()

2015-04-27 Thread KY Srinivasan
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Monday, April 27, 2015 7:57 PM To: KY Srinivasan Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com Subject: Re:

iproute2 regression -- ss -u returns an empty list

2015-04-27 Thread Mihai Moldovan
Hi, Following up a bug report I received at http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=799 it looks like the current version iproute2's ss utility always returns an empty result set whenever specifying the -u flag. The problem has been bisected to 9db7bf15e22b6a1b8bc09c4a1e29571cbca55c94 and

Re: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit()

2015-04-27 Thread David Miller
From: K. Y. Srinivasan k...@microsoft.com Date: Mon, 27 Apr 2015 18:14:50 -0700 Commit commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory allocation in the packet send path. This commit introduced a bug since it did not account for the case if the skb was cloned. Fix this bug by

RE: [PATCH v1 net-next 2/3] igb: move initialization of link properties before igb_sw_init

2015-04-27 Thread Brown, Aaron F
From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Jonathan Toppins Sent: Friday, April 10, 2015 4:04 PM To: Kirsher, Jeffrey T Cc: Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn; Skidmore, Donald C; Vick, Matthew; Ronciak, John; Williams, Mitch A;

Re: iproute2 regression -- ss -u returns an empty list

2015-04-27 Thread Vadim Kochan
On Tue, Apr 28, 2015 at 06:33:18AM +0200, Mihai Moldovan wrote: On 28.04.2015 06:05 AM, Vadim Kochan wrote: So by default ss prints socket with CONNECTED state and even UDP can be in the CONNECTED state on the Linux, UDP can be in a CONNECTED state... kay. That's probably a conntrack

Re: [PATCH 0/2] Netfilter fixes for net

2015-04-27 Thread David Miller
From: Pablo Neira Ayuso pa...@netfilter.org Date: Mon, 27 Apr 2015 20:41:55 +0200 The following patchset contains Netfilter fixes for your net tree, they are: 1) Fix a crash in nf_tables when dictionaries are used from the ruleset, due to memory corruption, from Florian Westphal. 2)

Re: [PATCH net] bnx2x: really disable TPA if 'disable_tpa' option is set

2015-04-27 Thread David Miller
From: Yuval Mintz yuval.mi...@qlogic.com Date: Mon, 27 Apr 2015 18:15:44 + bnx2x's 'disable_tpa=1' module option is not respected properly and TPA (transparent packet aggregation) remains enabled. Even though the module option causes LRO to be disabled, TPA is enabled in GRO mode.

Re: [PATCH v2] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-27 Thread David Miller
From: Murali Karicheri m-kariche...@ti.com Date: Mon, 27 Apr 2015 14:12:43 -0400 Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is not needed as Phy lib already updates the carrier status to net stack. This is needed only for other interface types

Re: iproute2 regression -- ss -u returns an empty list

2015-04-27 Thread Mihai Moldovan
On 28.04.2015 06:47 AM, Vadim Kochan wrote: On Tue, Apr 28, 2015 at 06:33:18AM +0200, Mihai Moldovan wrote: On 28.04.2015 06:05 AM, Vadim Kochan wrote: So by default ss prints socket with CONNECTED state and even UDP can be in the CONNECTED state on the Linux, UDP can be in a CONNECTED

Re: [PATCH net] bpf: fix 64-bit divide

2015-04-27 Thread David Miller
From: Alexei Starovoitov a...@plumgrid.com Date: Mon, 27 Apr 2015 14:40:37 -0700 ALU64_DIV instruction should be dividing 64-bit by 64-bit, whereas do_div() does 64-bit by 32-bit divide. x64 and arm64 JITs correctly implement 64 by 64 unsigned divide. llvm BPF backend emits code assuming that

RE: [PATCH v1 net-next 3/3] igb: add PHY support for Broadcom 54616

2015-04-27 Thread Brown, Aaron F
From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Jonathan Toppins Sent: Friday, April 10, 2015 4:04 PM To: Kirsher, Jeffrey T Cc: Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn; Skidmore, Donald C; Vick, Matthew; Ronciak, John; Williams, Mitch A;

Re: [bisected] ICMP fragmentation needed ignored / PMTU discovery broken since 3.19-rc7

2015-04-27 Thread Herbert Xu
Gerd v. Egidy gerd.von.eg...@intra2net.com wrote: my colleagues recently reported that they had spurious problems connecting to a specific server via ssh. Investigation showed that the kernel completely ignored the ICMP dest. unreachable / fragmentation needed packets in this case: This

Re: iproute2 regression -- ss -u returns an empty list

2015-04-27 Thread Mihai Moldovan
On 28.04.2015 06:05 AM, Vadim Kochan wrote: So by default ss prints socket with CONNECTED state and even UDP can be in the CONNECTED state on the Linux, UDP can be in a CONNECTED state... kay. That's probably a conntrack thing. so you can specify 'ss -ua' (may be some explanation should

Re: iproute2 regression -- ss -u returns an empty list

2015-04-27 Thread Vadim Kochan
On Tue, Apr 28, 2015 at 07:07:56AM +0200, Mihai Moldovan wrote: On 28.04.2015 06:47 AM, Vadim Kochan wrote: On Tue, Apr 28, 2015 at 06:33:18AM +0200, Mihai Moldovan wrote: On 28.04.2015 06:05 AM, Vadim Kochan wrote: So by default ss prints socket with CONNECTED state and even UDP can be

Re: [PATCH RFC] net/macb: Fix UDPv4 checksum offload

2015-04-27 Thread David Miller
From: Jaeden Amero jaeden.am...@ni.com Date: Mon, 27 Apr 2015 17:43:30 -0500 If we set the checksum field in the UDP header to 0, the checksum is computed correctly. I think this is completely bogus. A UDP checksum of zero, means checksum not computed. And your device isn't computing the

RE: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit()

2015-04-27 Thread Dexuan Cui
-Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of K. Y. Srinivasan Sent: Tuesday, April 28, 2015 9:15 To: da...@davemloft.net; netdev@vger.kernel.org; linux- ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;

Re: [PATCH] mlx4: Fix tx ring affinity_mask creation

2015-04-27 Thread Benjamin Poirier
On 2015/04/13 17:22, Benjamin Poirier wrote: On 2015/04/12 10:03, Ido Shamay wrote: Hi Benjamin, On 4/10/2015 7:27 PM, Benjamin Poirier wrote: By default, the number of tx queues is limited by the number of online cpus in mlx4_en_get_profile(). However, this limit no longer holds

Re: [PATCH v1 net-next 1/2] igb: add PHY support for Broadcom 5461S

2015-04-27 Thread Jonathan Toppins
On 4/17/15 4:23 PM, Jonathan Toppins wrote: From: Alan Liebthal al...@cumulusnetworks.com The Quanta LY8 Ethernet management port uses a Broadcom 5461S chip for the PHY layer. This adds support for this PHY to the Intel igb driver. Signed-off-by: Alan Liebthal al...@cumulusnetworks.com

[PATCH net] bnx2x: really disable TPA if 'disable_tpa' option is set

2015-04-27 Thread Michal Schmidt
bnx2x's 'disable_tpa=1' module option is not respected properly and TPA (transparent packet aggregation) remains enabled. Even though the module option causes LRO to be disabled, TPA is enabled in GRO mode. Additionally, disabling GRO via ethtool then has no effect. One can still observe tpa_*

Re: Linux device driver for USB WIFI needs integrating

2015-04-27 Thread Anders Larsen
(misspelled the list address - sorry) On 2015-04-27 16:23, Chris Ward wrote: With the patch actually applied, the WiFi adapter is recognised and works, both on boot and if the adapter is plugged in later. So, all is well. glad to hear that - and thanks for testing! What mainline kernel

Re: [PATCH v1 net-next 1/3] igb: set driver data for device entries that were missing

2015-04-27 Thread Jonathan Toppins
On 4/10/15 7:03 PM, Jonathan Toppins wrote: Three of the supported PCI device entries neglected to set driver data to board_82575. This is not a problem until a new board type is defined, so avoid the potential problem all together. Signed-off-by: Jonathan Toppins jtopp...@cumulusnetworks.com

Re: v3.12-stable-queue build errors

2015-04-27 Thread Eric W. Biederman
Jiri Slaby jsl...@suse.cz writes: On 04/25/2015, 04:16 PM, Guenter Roeck wrote: Several powerpc build fail with: drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit': drivers/net/ethernet/freescale/gianfar.c:2146:3: error: implicit declaration of function

Re: [PATCH iproute2] Use PATH_MAX instead of MAXPATHLEN

2015-04-27 Thread Stephen Hemminger
On Sat, 25 Apr 2015 22:33:28 +0200 Felix Janda felix.ja...@posteo.de wrote: They are equivalent but the former is more common. PATH_MAX is specified by POSIX and needs limits.h while MAXPATHLEN has BSD origin and needs sys/param.h. PATH_MAX has already been in use in misc/lnstat.h.

Re: iproute2: Make linux/in6.h a stub?

2015-04-27 Thread Stephen Hemminger
On Sat, 25 Apr 2015 22:54:11 +0200 Felix Janda felix.ja...@posteo.de wrote: Hello. Background: Current iproute2 does not build when the libc is musl instead of glibc. This is because of redefinition of in6_addr in netinet/in.h and linux/in6.h. There are workarounds in linux/libc-compat.h

Re: v3.12-stable-queue build errors

2015-04-27 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Mon, 27 Apr 2015 10:35:51 -0500 Jiri Slaby jsl...@suse.cz writes: On 04/25/2015, 04:16 PM, Guenter Roeck wrote: Several powerpc build fail with: drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit':

RE: [PATCH net-next v7] Add support of Cavium Liquidio ethernet adapters

2015-04-27 Thread Chickles, Derek
It is extremely disappointing that you've defined your own debug logging macros, which use generic dev_*() printks, instead of using the proper netdev_*() printk logging interfaces to do this. We can make this change. I'm not sure why it was missed since we have netif_level support. Please

iproute2 BUG: linux kernel panic after ip netns exec and umount

2015-04-27 Thread Noel Burton-Krahn
We ran into a kernel panic when we mixed ip netns exec with mounted nbd devices. The problem is creating a mount namespace in ip netns exec is pretty dangerous (details below). How about we add an option to ip netns exec to *not* make a new mount namespace? Details: The problem is ip netns

Re: [stable request] mlx4 dev_kfree_skb

2015-04-27 Thread David Miller
From: Jiri Slaby jsl...@suse.cz Date: Mon, 27 Apr 2015 11:10:51 +0200 On 04/21/2015, 08:30 PM, David Miller wrote: Please queue up the following networking bug fixes for 3.12, 3.14, 3.18, 3.19, and 4.0 -stable, respectively. Hi, similar to other Call dev_kfree_skby_any instead of

Re: [PATCH net-next v7] Add support of Cavium Liquidio ethernet adapters

2015-04-27 Thread David Miller
From: Chickles, Derek derek.chick...@caviumnetworks.com Date: Mon, 27 Apr 2015 16:26:27 + It is extremely disappointing that you've defined your own debug logging macros, which use generic dev_*() printks, instead of using the proper netdev_*() printk logging interfaces to do this. We

RE: [PATCH net-next v7] Add support of Cavium Liquidio ethernet adapters

2015-04-27 Thread Chickles, Derek
It is extremely disappointing that you've defined your own debug logging macros, which use generic dev_*() printks, instead of using the proper netdev_*() printk logging interfaces to do this. We can make this change. I'm not sure why it was missed since we have netif_level support.

Re: [PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-27 Thread Murali Karicheri
On 04/25/2015 03:48 PM, David Miller wrote: From: Murali Karicherim-kariche...@ti.com Date: Fri, 24 Apr 2015 15:01:41 -0400 Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is not needed as Phy lib already updates the carrier status to net stack. This is

Re: v3.12-stable-queue build errors

2015-04-27 Thread Guenter Roeck
On Mon, Apr 27, 2015 at 10:35:51AM -0500, Eric W. Biederman wrote: Jiri Slaby jsl...@suse.cz writes: On 04/25/2015, 04:16 PM, Guenter Roeck wrote: Several powerpc build fail with: drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit':

Re: [PATCH] net: phy: micrel: support !CONFIG_HAVE_CLK

2015-04-27 Thread David Miller
From: Johan Hovold jo...@kernel.org Date: Mon, 27 Apr 2015 13:08:07 +0200 On Mon, Apr 27, 2015 at 01:05:17PM +0200, Johan Hovold wrote: On Mon, Apr 27, 2015 at 01:00:50PM +0200, Niklas Cassel wrote: Since NULL is a valid clock, we shouldn't use IS_ERR_OR_NULL. Implemented as Russell

Re: [PATCH 2/2] net:wireless:treewide: Fix typo in drivers/net/wireless

2015-04-27 Thread David Miller
From: Masanari Iida standby2...@gmail.com Date: Mon, 27 Apr 2015 23:14:58 +0900 This patch fix some spelling typo in drivers/net/wirless Signed-off-by: Masanari Iida standby2...@gmail.com I'll let the wireless folks pick this one up, thanks. -- To unsubscribe from this list: send the line

Re: [PATCH net] bnx2x: really disable TPA if 'disable_tpa' option is set

2015-04-27 Thread David Miller
From: Michal Schmidt mschm...@redhat.com Date: Mon, 27 Apr 2015 17:20:38 +0200 bnx2x's 'disable_tpa=1' module option is not respected properly and TPA (transparent packet aggregation) remains enabled. Even though the module option causes LRO to be disabled, TPA is enabled in GRO mode.

[GIT] Networking

2015-04-27 Thread David Miller
1) mlx4 doesn't check fully for supported valid RSS hash function, fix from Amir Vadai. 2) Off by one in ibmveth_change_mtu(), from David Gibson. 3) Prevent altera chip from reporting false error interrupts in some circumstances, from Chee Nouk Phoon. 4) Get rid of that stupid endless

Re: v3.12-stable-queue build errors

2015-04-27 Thread Jiri Slaby
On 04/27/2015, 06:25 PM, David Miller wrote: From: ebied...@xmission.com (Eric W. Biederman) Date: Mon, 27 Apr 2015 10:35:51 -0500 Jiri Slaby jsl...@suse.cz writes: On 04/25/2015, 04:16 PM, Guenter Roeck wrote: Several powerpc build fail with: drivers/net/ethernet/freescale/gianfar.c: In

Re: [PATCH net-next v7] Add support of Cavium Liquidio ethernet adapters

2015-04-27 Thread David Miller
From: Chickles, Derek derek.chick...@caviumnetworks.com Date: Mon, 27 Apr 2015 17:04:35 + It is extremely disappointing that you've defined your own debug logging macros, which use generic dev_*() printks, instead of using the proper netdev_*() printk logging interfaces to do this.

[RFC PATCH net-next v3 2/4] switchdev: APIs for setting physical state of the switch port.

2015-04-27 Thread anuradhak
From: Anuradha Karuppiah anurad...@cumulusnetworks.com On detecting errors an application can set IFF_PROTO_DOWN on a device. These switchdev APIs allow the switch device driver to react to IFF_PROTO_DOWN by doing a phy down on the switch port. Doing this allows the connected server to react

Re: [PATCH net V1] net/mlx4_en: Prevent setting invalid RSS hash function

2015-04-27 Thread David Miller
From: Amir Vadai am...@mellanox.com Date: Mon, 27 Apr 2015 13:40:56 +0300 mlx4_en_check_rxfh_func() was checking for hardware support before setting a known RSS hash function, but didn't do any check before setting unknown RSS hash function. Need to make it fail on such values. In this

Re: [PATCH 1/2] net:treewide: Fix typo in drivers/net

2015-04-27 Thread David Miller
From: Masanari Iida standby2...@gmail.com Date: Mon, 27 Apr 2015 23:14:57 +0900 This patch fix spelling typo in printk. Signed-off-by: Masanari Iida standby2...@gmail.com Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

[PATCH] netfilter; Add some missing default cases to switch statements in nft_reject.

2015-04-27 Thread David Miller
This fixes: net/netfilter/nft_reject.c: In function ‘nft_reject_dump’: net/netfilter/nft_reject.c:61:2: warning: enumeration value ‘NFT_REJECT_TCP_RST’ not handled in switch [-Wswitch] switch (priv-type) { ^ net/netfilter/nft_reject.c:61:2: warning: enumeration value

Re: [PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-27 Thread David Miller
From: Murali Karicheri m-kariche...@ti.com Date: Mon, 27 Apr 2015 13:07:35 -0400 On 04/25/2015 03:48 PM, David Miller wrote: From: Murali Karicherim-kariche...@ti.com Date: Fri, 24 Apr 2015 15:01:41 -0400 Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is

Re: [PATCH][RESEND] mdio-mux-gpio: use new gpiod_get_array and gpiod_put_array functions

2015-04-27 Thread David Miller
From: Rojhalat Ibrahim i...@rtschenk.de Date: Mon, 27 Apr 2015 10:37:31 +0200 Use the new gpiod_get_array and gpiod_put_array functions (added to mainline in the v4.1 merge window) for obtaining and disposing of GPIO descriptors. Cc: David Miller da...@davemloft.net Cc: Linus Walleij

[RFC PATCH iproute v3 4/4] ip link: Config and display IFF_PROTO_DOWN flag.

2015-04-27 Thread anuradhak
From: Anuradha Karuppiah anurad...@cumulusnetworks.com This patch adds support to set and display the IFF_PROTO_DOWN flag. One example user space application setting this flag is a multi-chassis LAG application to handle split-brain situation on peer-link failure. Example: root@net-next:~# ip

[RFC PATCH net-next v3 1/4] net core: Add IFF_PROTO_DOWN support.

2015-04-27 Thread anuradhak
From: Anuradha Karuppiah anurad...@cumulusnetworks.com This patch introduces an IFF_PROTO_DOWN flag that can be used by user space applications to notify drivers that errors have been detected on the device. Signed-off-by: Anuradha Karuppiah anurad...@cumulusnetworks.com Signed-off-by: Andy

[RFC PATCH net-next v3 3/4] rocker: Handle IFF_PROTODOWN by doing a PHYS-DOWN on the switch port.

2015-04-27 Thread anuradhak
From: Anuradha Karuppiah anurad...@cumulusnetworks.com IFF_PROTODOWN can be set by user space applications like MLAG on detecting errors on a switch port. This patch provides sample switch driver changes for handling IFF_PROTODOWN. Rocker PHYS disables the port in response to protodown. Note: I

Re: [PATCH] net: phy: micrel: support !CONFIG_HAVE_CLK

2015-04-27 Thread Fabio Estevam
On Mon, Apr 27, 2015 at 8:00 AM, Niklas Cassel niklas.cas...@axis.com wrote: Since NULL is a valid clock, we shouldn't use IS_ERR_OR_NULL. Yes, but this code is not using IS_ERR_OR_NULL. It seems that you are not describing the problem you are trying to solve. What is the exact issue you are

[PATCH 2/2] netfilter: bridge: fix NULL deref in physin/out ifindex helpers

2015-04-27 Thread Pablo Neira Ayuso
From: Florian Westphal f...@strlen.de Might not have an outdev yet. We'll oops when iface goes down while skbs are still nfqueue'd: RIP: 0010:[81422a2f] [81422a2f] dev_cmp+0x4f/0x80 nfqnl_rcv_dev_event+0xe2/0x150 notifier_call_chain+0x53/0xa0 Fixes: c737b7c4510026 (netfilter:

[PATCH 0/2] Netfilter fixes for net

2015-04-27 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter fixes for your net tree, they are: 1) Fix a crash in nf_tables when dictionaries are used from the ruleset, due to memory corruption, from Florian Westphal. 2) Fix another crash in nf_queue when used with br_netfilter. Also from Florian.

[PATCH 1/2] netfilter: nf_tables: fix wrong length for jump/goto verdicts

2015-04-27 Thread Pablo Neira Ayuso
From: Florian Westphal f...@strlen.de NFT_JUMP/GOTO erronously sets length to sizeof(void *). We then allocate insufficient memory when such element is added to a vmap. Suggested-by: Patrick McHardy ka...@trash.net Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Pablo Neira Ayuso

Re: [RFC PATCH net-next v3 3/4] rocker: Handle IFF_PROTODOWN by doing a PHYS-DOWN on the switch port.

2015-04-27 Thread Scott Feldman
On Mon, Apr 27, 2015 at 10:38 AM, anurad...@cumulusnetworks.com wrote: From: Anuradha Karuppiah anurad...@cumulusnetworks.com IFF_PROTODOWN can be set by user space applications like MLAG on detecting errors on a switch port. This patch provides sample switch driver changes for handling

Re: [RFC PATCH net-next v3 0/4] net: Introduce IFF_PROTO_DOWN flag.

2015-04-27 Thread Scott Feldman
On Mon, Apr 27, 2015 at 10:38 AM, anurad...@cumulusnetworks.com wrote: From: Anuradha Karuppiah anurad...@cumulusnetworks.com User space daemons can detect errors in the network that need to be notified to the switch device drivers. Drivers can react to this error state by doing a phy-down

Re: [PATCH net-next v1] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-27 Thread Murali Karicheri
On 04/27/2015 01:23 PM, David Miller wrote: From: Murali Karicherim-kariche...@ti.com Date: Mon, 27 Apr 2015 13:07:35 -0400 On 04/25/2015 03:48 PM, David Miller wrote: From: Murali Karicherim-kariche...@ti.com Date: Fri, 24 Apr 2015 15:01:41 -0400 Currently when interface type is MAC to

[PATCH v2] net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface

2015-04-27 Thread Murali Karicheri
Currently when interface type is MAC to Phy, netif_carrier_(on/off) is called which is not needed as Phy lib already updates the carrier status to net stack. This is needed only for other interface types Signed-off-by: Murali Karicheri m-kariche...@ti.com --- - v2: re-send to apply this on v4.1

RE: [PATCH net] bnx2x: really disable TPA if 'disable_tpa' option is set

2015-04-27 Thread Yuval Mintz
bnx2x's 'disable_tpa=1' module option is not respected properly and TPA (transparent packet aggregation) remains enabled. Even though the module option causes LRO to be disabled, TPA is enabled in GRO mode. Additionally, disabling GRO via ethtool then has no effect. One can still observe

Re: [PATCH next 1/3] ipvlan: Defer multicast / broadcast processing to a work-queue

2015-04-27 Thread Mahesh Bandewar
On Fri, Apr 24, 2015 at 3:59 PM, Dan Williams d...@redhat.com wrote: On Fri, 2015-04-24 at 15:40 -0700, Mahesh Bandewar wrote: On Fri, Apr 24, 2015 at 1:15 PM, Dan Williams d...@redhat.com wrote: On Thu, 2015-04-23 at 14:29 -0700, Mahesh Bandewar wrote: Processing multicast / broadcast in

igb driver randomly truncates packets

2015-04-27 Thread Cong Wang
Hi, all We saw some packet corruptions with igb driver after upgrading to 3.14 kernel, but we have no idea how to reproduce it. Below are my observations for debugging: 1) This is probably a regression from 3.10 to 3.14 as we don't see any issue with 3.10 kernel. Someone else reported similar