RE: [Intel-wired-lan] [PATCH v5] ixgbe: Add module parameter to disable VLAN filter

2015-05-27 Thread Hiroshi Shimamoto
> Subject: Re: [Intel-wired-lan] [PATCH v5] ixgbe: Add module parameter to > disable VLAN filter > > On 05/26/2015 06:11 PM, Hiroshi Shimamoto wrote: > >> On 05/21/2015 06:10 AM, Hiroshi Shimamoto wrote: > >>> From: Hiroshi Shimamoto > >>> > >>> Introduce module parameter "disable_hw_vlan_filter

[PATCH 4/7] xfrm: slightly optimise xfrm_input

2015-05-27 Thread Steffen Klassert
From: Li RongQing Check x->km.state with XFRM_STATE_ACQ only when state is not XFRM_STAT_VALID, not everytime Signed-off-by: Li RongQing Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_input.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/xfrm/xfrm_input

[PATCH 2/7] xfrm: optimise the use of walk list header in xfrm_policy/state_walk

2015-05-27 Thread Steffen Klassert
From: Li RongQing The walk from input is the list header, and marked as dead, and will be skipped in loop. list_first_entry() can be used to return the true usable value from walk if walk is not empty Signed-off-by: Li RongQing Acked-by: Herbert Xu Signed-off-by: Steffen Klassert --- net/xf

[PATCH 7/7] xfrm: optimise to search the inexact policy list

2015-05-27 Thread Steffen Klassert
From: Li RongQing The policies are organized into list by priority ascent of policy, so it is unnecessary to continue to loop the policy if the priority of current looped police is larger than or equal priority which is from the policy_bydst list. This allows to match policy with ~0U priority in

[PATCH 5/7] xfrm: remove the unnecessary checking before call xfrm_pol_hold

2015-05-27 Thread Steffen Klassert
From: Li RongQing xfrm_pol_hold will check its input with NULL Signed-off-by: Li RongQing Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_policy.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index c4c47f3..435bc0

[PATCH 6/7] xfrm: move the checking for old xfrm_policy hold_queue to beginning

2015-05-27 Thread Steffen Klassert
From: Li RongQing if hold_queue of old xfrm_policy is NULL, return directly, then not need to run other codes, especially take the spin lock Signed-off-by: Li RongQing Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_policy.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 3/7] xfrm: fix the return code when xfrm_*_register_afinfo failed

2015-05-27 Thread Steffen Klassert
From: Li RongQing If xfrm_*_register_afinfo failed since xfrm_*_afinfo[afinfo->family] had the value, return the -EEXIST, not -ENOBUFS Signed-off-by: Li RongQing Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_input.c | 2 +- net/xfrm/xfrm_policy.c | 2 +- net/xfrm/xfrm_state.c | 2 +- 3

pull request (net-next): ipsec-next 2015-05-28

2015-05-27 Thread Steffen Klassert
1) Remove xfrm_queue_purge as this is the same as skb_queue_purge. 2) Optimize policy and state walk. 3) Use a sane return code if afinfo registration fails. 4) Only check fori a acquire state if the state is not valid. 5) Remove a unnecessary NULL check before xfrm_pol_hold as it checks the

[PATCH 1/7] xfrm: remove the xfrm_queue_purge definition

2015-05-27 Thread Steffen Klassert
From: Li RongQing The task of xfrm_queue_purge is same as skb_queue_purge, so remove it Signed-off-by: Li RongQing Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_policy.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfr

Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-27 Thread Jiri Pirko
Thu, May 28, 2015 at 05:23:17AM CEST, simon.hor...@netronome.com wrote: >The rocker (switch) of a rocker_port may be trivially obtained from >the latter it seems cleaner not to pass the former to a function when >the latter is being passed anyway. I don't understand reason for this patch. I like i

Re: [ipsec PATCH 0/3] Preserve skb->mark through VTI tunnels

2015-05-27 Thread Steffen Klassert
On Wed, May 27, 2015 at 07:16:37AM -0700, Alexander Duyck wrote: > These patches are meant to try and address the fact the VTI tunnels are > currently overwriting the skb->mark value. I am generally happy with the > first two patches, however the third patch still modifies the skb->mark, > though

Re: Question: Now that we have IPv6, do we need TCP/UDP port numbers?

2015-05-27 Thread Cong Wang
(Cc'ing netdev for discussion) On Mon, May 25, 2015 at 4:17 PM, Coroutines wrote: > I have a potentially dumb question to ask, and I'm posting it here > because out of everywhere on the web I thought I would find the most > experts relating to TCP/UDP's design/handling and its history here. > > I

Re: [PATCH net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-27 Thread Pravin Shelar
On Wed, May 27, 2015 at 9:16 PM, Jesse Gross wrote: > On Wed, May 27, 2015 at 7:46 PM, Pravin Shelar wrote: >> On Wed, May 27, 2015 at 2:10 PM, Jesse Gross wrote: >>> On Fri, May 22, 2015 at 10:53 AM, Pravin Shelar wrote: On Wed, May 20, 2015 at 12:32 PM, Neil McKee wrote: > diff --gi

Re: Lost network connectivity in 4.0.x

2015-05-27 Thread Cong Wang
(Please always Cc netdev for networking bugs.) On Sat, May 23, 2015 at 8:29 PM, Ken Moffat wrote: > On Sun, May 24, 2015 at 03:43:52AM +0100, Ken Moffat wrote: >> Anybody else suffering frm lost network connectivity in 4.0.x >> kernels ? A couple of times this week, vim on an nfs-3 mount hung >>

Re: Looking for a lost patch

2015-05-27 Thread Steffen Klassert
On Wed, May 27, 2015 at 11:46:03AM -0400, David Miller wrote: > From: Steffen Klassert > Date: Wed, 27 May 2015 10:35:16 +0200 > > > We currently check if a socket is attached to a skb and do socket > > error notification in this case, otherwise we do PMTU discovery if > > the packet is too big.

Re: [PATCH] xfrm6: Do not use xfrm_local_error for path MTU issues in tunnels

2015-05-27 Thread Steffen Klassert
On Wed, May 27, 2015 at 10:40:32AM -0700, Alexander Duyck wrote: > This change makes it so that we use icmpv6_send to report PMTU issues back > into tunnels in the case that the resulting packet is larger than the MTU > of the outgoing interface. Previously xfrm_local_error was being used in > thi

[PATCH net-next] tipc: unconditionally put sock refcnt when sock timer to be deleted is pending

2015-05-27 Thread Ying Xue
As sock refcnt is taken when sock timer is started in sk_reset_timer(), the sock refcnt should be put when sock timer to be deleted is in pending state no matter what "probing_state" value of tipc sock is. Reviewed-by: Erik Hugne Reviewed-by: Jon Maloy Signed-off-by: Ying Xue --- net/tipc/sock

Re: kmalloc panic

2015-05-27 Thread Cong Wang
(Cc'ing netdev and wireless... Looks like a bug in wireless ext.) On Wed, May 27, 2015 at 6:46 AM, pavani wrote: > Hi, > > I connected to AP with the help of wpa_supplicant in linux.After connecting > to AP I am facing an issue like "kmalloc panic".can you help me > how to solve this issue.Logs

Re: [PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-27 Thread Scott Feldman
On Wed, May 27, 2015 at 8:23 PM, Simon Horman wrote: > The rocker (switch) of a rocker_port may be trivially obtained from > the latter it seems cleaner not to pass the former to a function when > the latter is being passed anyway. > > Signed-off-by: Simon Horman +1, thanks Simon. Acked-by: Sco

Re: DSA and underlying 802.1Q encapsulation

2015-05-27 Thread Guenter Roeck
On 05/27/2015 06:46 PM, Andrew Lunn wrote: On Wed, May 27, 2015 at 03:51:59PM -0700, Guenter Roeck wrote: On 05/27/2015 02:05 PM, Andrew Lunn wrote: Do you have lock debugging enabled in your code ? I am getting a recursive lock warning due to a recursive call to dev_mc_sync(). I think we may h

Re: [PATCH] xfrm6: Do not use xfrm_local_error for path MTU issues in tunnels

2015-05-27 Thread Steffen Klassert
On Thu, May 28, 2015 at 12:49:19PM +0800, Herbert Xu wrote: > On Wed, May 27, 2015 at 10:40:32AM -0700, Alexander Duyck wrote: > > This change makes it so that we use icmpv6_send to report PMTU issues back > > into tunnels in the case that the resulting packet is larger than the MTU > > of the outg

Re: [PATCH] xfrm6: Do not use xfrm_local_error for path MTU issues in tunnels

2015-05-27 Thread Herbert Xu
On Wed, May 27, 2015 at 10:40:32AM -0700, Alexander Duyck wrote: > This change makes it so that we use icmpv6_send to report PMTU issues back > into tunnels in the case that the resulting packet is larger than the MTU > of the outgoing interface. Previously xfrm_local_error was being used in > thi

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Ido Yariv
Hi Eric, On Wed, May 27, 2015 at 03:15:26PM -0400, Ido Yariv wrote: > Hi Eric, > > On Wed, May 27, 2015 at 10:24:16AM -0700, Eric Dumazet wrote: > > On Wed, 2015-05-27 at 12:54 -0400, Ido Yariv wrote: > > > Hi Eric, > > > > > That's a nice optimization ;) > > > > > > However, I think that with

linux-next: manual merge of the net-next tree with Linus' tree

2015-05-27 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/phy/amd-xgbe-phy.c between commit 983942a5eaca ("amd-xgbe-phy: Fix initial mode when autoneg is disabled") from Linus' tree and commit 7c12aa08779c ("amd-xgbe: Move the PHY support into amd-xgbe") from the net-next

Re: [PATCH net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-27 Thread Jesse Gross
On Wed, May 27, 2015 at 7:46 PM, Pravin Shelar wrote: > On Wed, May 27, 2015 at 2:10 PM, Jesse Gross wrote: >> On Fri, May 22, 2015 at 10:53 AM, Pravin Shelar wrote: >>> On Wed, May 20, 2015 at 12:32 PM, Neil McKee wrote: diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c >

Re: [PATCHv2] pktgen: Convert return type of process_ipsec to bool

2015-05-27 Thread Joe Perches
On Thu, 2015-05-28 at 00:00 -0400, Nicholas Krause wrote: > This converts the function, process_ipsec to the > return type of bool due to only returning either > one or zero. > v2 > Change incorrect patch subject and make commit message > clearer > > Signed-off-by: Nicholas Krause > --- The V2

Re: [PATCH 1/2] connector: add cgroup release event report to proc connector

2015-05-27 Thread Zefan Li
On 2015/5/27 20:37, Dimitri John Ledkov wrote: > On 27 May 2015 at 12:22, Zefan Li wrote: >> On 2015/5/27 6:07, Dimitri John Ledkov wrote: >>> Add a kernel API to send a proc connector notification that a cgroup >>> has become empty. A userspace daemon can then act upon such >>> information, and u

[PATCH/RFC net-next] rocker: remove rocker parameter from functions that have rocker_port parameter

2015-05-27 Thread Simon Horman
The rocker (switch) of a rocker_port may be trivially obtained from the latter it seems cleaner not to pass the former to a function when the latter is being passed anyway. Signed-off-by: Simon Horman --- drivers/net/ethernet/rocker/rocker.c | 122 ++- 1 file chan

Re: [PATCH net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-27 Thread Pravin Shelar
On Wed, May 27, 2015 at 2:10 PM, Jesse Gross wrote: > On Fri, May 22, 2015 at 10:53 AM, Pravin Shelar wrote: >> On Wed, May 20, 2015 at 12:32 PM, Neil McKee wrote: >>> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c >>> index b491c1c..ee5760d 100644 >>> --- a/net/openvswitch/a

Re: DSA and underlying 802.1Q encapsulation

2015-05-27 Thread Andrew Lunn
On Wed, May 27, 2015 at 03:51:59PM -0700, Guenter Roeck wrote: > On 05/27/2015 02:05 PM, Andrew Lunn wrote: > >>Do you have lock debugging enabled in your code ? I am getting a recursive > >>lock warning due to a recursive call to dev_mc_sync(). I think we may have > >>to implement lock nesting for

Re: [PATCH] core: Convert the function process_ipcsec to the, return type bool

2015-05-27 Thread Joe Perches
On Wed, 2015-05-27 at 21:14 -0400, Nicholas Krause wrote: > This makes the function,process_ipsec have a return true > of bool now due to only returning 1 or 0. In additon this > changes this function's return statements to return true > and false rather then 1 and 0 respectfully. The patch subjec

Re: stack smashing in iproute/ip

2015-05-27 Thread Stephen Hemminger
> Yes, this is a long standing problem in rtnl_talk() api has no max > length given for the answer. I changed rtnl_talk API as well. It probably will break some people who extract libnetlink as a user available library, but compatibility with internal API's was never guaranteed by iproute2. From

Re: stack smashing in iproute/ip

2015-05-27 Thread Stephen Hemminger
On Tue, 19 May 2015 10:41:32 +0200 Jetchko Jekov wrote: > Hello, > > I hope this is the right way to report a bug regarding iproute. > > While playing with gre[tap] tunnels I run in the following: I integrated your patch into upcoming release. -- To unsubscribe from this list: send the line "

[PATCH] if_vlan: fix vlaue -> value typo

2015-05-27 Thread Vivien Didelot
Fixes "vlaue" for "value" in include/linux/if_vlan.h. Signed-off-by: Vivien Didelot --- include/linux/if_vlan.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index b9ab677..a40d298 100644 --- a/include/linux/if_vlan.h

Re: [PATCH iproute2] enable transparent LFS

2015-05-27 Thread Mike Frysinger
On 27 May 2015 12:07, Stephen Hemminger wrote: > On Tue, 26 May 2015 02:51:30 -0400 > Mike Frysinger wrote: > > From: Mike Frysinger > > > > Make sure we use 64-bit filesystem functions everywhere. This applies not > > only to being able to read large files (which generally doesn't apply to > >

[PATCH] sctp: fix ASCONF list handling

2015-05-27 Thread mleitner
From: Marcelo Ricardo Leitner ->auto_asconf_splist is per namespace and mangled by functions like sctp_setsockopt_auto_asconf() which doesn't guarantee any serialization. Also, the call to inet_sk_copy_descendant() was backuping ->auto_asconf_list through the copy but was not honoring ->do_auto_

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-27 Thread Laura Abbott
On 05/21/2015 08:13 PM, Marcel Holtmann wrote: Hi Laura, Then avoiding the failed firmware is no solution, indeed. If it's a new probe, it should be never executed during resume. Can you expand this comment? What's wrong with probing during resume? The USB stack does carry out probes during

Re: [PATCH net iproute2 v2 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-05-27 Thread roopa
On 5/27/15, 1:08 PM, roopa wrote: On 5/27/15, 12:59 PM, Robert Shearman wrote: On 27/05/15 19:37, Roopa Prabhu wrote: From: Roopa Prabhu Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman Signed-off-by: Roopa Prabhu --- ip/iproute.c |5 + 1 fil

Re: DSA and underlying 802.1Q encapsulation

2015-05-27 Thread Guenter Roeck
On 05/27/2015 02:05 PM, Andrew Lunn wrote: Do you have lock debugging enabled in your code ? I am getting a recursive lock warning due to a recursive call to dev_mc_sync(). I think we may have to implement lock nesting for dsa, similar to how it id done for vlan support, but I have not been able

[PATCH net-next] bpf: allow BPF programs access skb->skb_iif and skb->dev->ifindex fields

2015-05-27 Thread Alexei Starovoitov
classic BPF already exposes skb->dev->ifindex via SKF_AD_IFINDEX extension. Allow eBPF program to access it as well. Note that classic aborts execution of the program if 'skb->dev == NULL' (which is inconvenient for program writers), whereas eBPF returns zero in such case. Also expose the 'skb_iif'

Re: [PATCH net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-27 Thread Jesse Gross
On Fri, May 22, 2015 at 10:53 AM, Pravin Shelar wrote: > On Wed, May 20, 2015 at 12:32 PM, Neil McKee wrote: >> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c >> index b491c1c..ee5760d 100644 >> --- a/net/openvswitch/actions.c >> +++ b/net/openvswitch/actions.c >> @@ -608,7 +6

Re: DSA and underlying 802.1Q encapsulation

2015-05-27 Thread Andrew Lunn
> Do you have lock debugging enabled in your code ? I am getting a recursive > lock warning due to a recursive call to dev_mc_sync(). I think we may have > to implement lock nesting for dsa, similar to how it id done for vlan > support, but I have not been able to figure out how exactly it works ye

Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 11:15 -0700, Gopakumar Choorakkot Edakkunni wrote: > Doesnt seem so. This is the output from one of the servers I have > where I periodically hit this TSval != TSecr condition. > > ubuntu@server:~$ sudo su > root@server:/home/ubuntu# sysctl net.ipv4.tcp_tw_recycle > net.ipv4.

Re: DSA and underlying 802.1Q encapsulation

2015-05-27 Thread Guenter Roeck
On 05/27/2015 01:48 PM, Vivien Didelot wrote: Hi Guenter, Interesting question. Does the underlying network device support VLAN HW acceleration (NETIF_F_HW_VLAN_CTAG_RX, NETIF_F_HW_VLAN_CTAG_TX) ? Yes, in our case, it's an IGB device. I also set the DSA slave_dev->features and slave_dev->vla

Re: DSA and underlying 802.1Q encapsulation

2015-05-27 Thread Vivien Didelot
Hi Guenter, > Interesting question. Does the underlying network device support VLAN HW > acceleration (NETIF_F_HW_VLAN_CTAG_RX, NETIF_F_HW_VLAN_CTAG_TX) ? Yes, in our case, it's an IGB device. I also set the DSA slave_dev->features and slave_dev->vlan_features to master->vlan_features | NETIF_F_

Re: [PATCH net-next] bridge: skip fdb add if the port shouldn't learn

2015-05-27 Thread Scott Feldman
On Wed, May 27, 2015 at 9:14 AM, Nikolay Aleksandrov wrote: > On Wed, May 27, 2015 at 6:01 PM, Scott Feldman wrote: >> On Wed, May 27, 2015 at 1:35 AM, Nikolay Aleksandrov >> wrote: >>> On Wed, May 27, 2015 at 9:59 AM, Scott Feldman wrote: On Wed, May 27, 2015 at 12:05 AM, Nikolay Aleksand

Re: [PATCH net iproute2 v2 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-05-27 Thread roopa
On 5/27/15, 12:59 PM, Robert Shearman wrote: On 27/05/15 19:37, Roopa Prabhu wrote: From: Roopa Prabhu Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman Signed-off-by: Roopa Prabhu --- ip/iproute.c |5 + 1 file changed, 5 insertions(+) diff --

Re: [PATCH net iproute2 v2 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-05-27 Thread Robert Shearman
On 27/05/15 19:37, Roopa Prabhu wrote: From: Roopa Prabhu Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman Signed-off-by: Roopa Prabhu --- ip/iproute.c |5 + 1 file changed, 5 insertions(+) diff --git a/ip/iproute.c b/ip/iproute.c index 670a4c

Re: [PATCH net-next V4 00/12] net/mlx5: ConnectX-4 100G Ethernet driver

2015-05-27 Thread Ben Hutchings
On Wed, 2015-05-27 at 13:36 -0400, David Miller wrote: > From: Or Gerlitz > Date: Mon, 25 May 2015 22:07:23 +0300 > > > On Wed, May 20, 2015 at 5:17 PM, Amir Vadai wrote: > >> On Tue, May 19, 2015 at 7:41 PM, David Miller wrote: > >>> From: Amir Vadai > >>> Date: Tue, 19 May 2015 12:25:12 +030

Re: [PATCH net-next] qla4xxx: add a missing include

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 11:33 -0700, James Bottomley wrote: > On Wed, 2015-05-27 at 14:21 -0400, David Miller wrote: > > Yeah it's easiest if I just apply this to net-next, which I've just done, > > thanks Eric. > > Fine with me. There's no point creating cross tree hassle for a simple > include p

Re: [PATCH net v2 2/2] mpls: fix mpls route deletes to not check for route scope

2015-05-27 Thread Robert Shearman
On 27/05/15 19:37, Roopa Prabhu wrote: From: Roopa Prabhu Ignore scope for route del messages Signed-off-by: Vivek Venkataraman Signed-off-by: Roopa Prabhu Reviewed-by: Robert Shearman --- net/mpls/af_mpls.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a

[PATCH net-next] net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN

2015-05-27 Thread Sorin Dumitru
This is similar to b1cb59cf2efe(net: sysctl_net_core: check SNDBUF and RCVBUF for min length). I don't think too small values can cause crashes in the case of udp and tcp, but I've seen this set to too small values which triggered awful performance. It also makes the setting consistent across all t

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Ido Yariv
Hi Eric, On Wed, May 27, 2015 at 10:24:16AM -0700, Eric Dumazet wrote: > On Wed, 2015-05-27 at 12:54 -0400, Ido Yariv wrote: > > Hi Eric, > > > That's a nice optimization ;) > > > > However, I think that with Nicholas Mc Guire's recent changes to > > msecs_to_jiffies (http://marc.info/?l=linux-k

Re: [PATCH] pci: Use a bus-global mutex to protect VPD operations

2015-05-27 Thread Rustad, Mark D
> On May 27, 2015, at 10:27 AM, Bjorn Helgaas wrote: > > It sounds like there are real problems here that would be fixed by changing > the mutex strategy and limiting VPD read lengths, but that we don't quite > have consensus on how to solve them yet. I have a new pair of patches that I am getti

Re: [PATCH iproute2] enable transparent LFS

2015-05-27 Thread Stephen Hemminger
On Tue, 26 May 2015 02:51:30 -0400 Mike Frysinger wrote: > From: Mike Frysinger > > Make sure we use 64-bit filesystem functions everywhere. This applies not > only to being able to read large files (which generally doesn't apply to > us), but also being able to simply stat them (as they might

[GIT] Networking

2015-05-27 Thread David Miller
1) Don't use MMIO on certain iwlwifi devices otherwise we get a firmware crash. 2) Don't corrupt the GRO lists of mac80211 contexts by doing sends via timer interrupt, from Johannes Berg. 3) SKB tailroom is miscalculated in AP_VLAN crypto code, from Michal Kazior. 4) Fix fw_status memo

[PATCH V2 net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-27 Thread K. Y. Srinivasan
The current algorithm for deciding on the number of VRSS channels is not optimal since we open up the min of number of CPUs online and the number of VRSS channels the host is offering. So on a 32 VCPU guest we could potentially open 32 VRSS subchannels. Experimentation has shown that it is best to

[PATCH RFC] 8139cp: make timeout HZ independent

2015-05-27 Thread Nicholas Mc Guire
is -next-20150527) Signed-off-by: Nicholas Mc Guire --- As there is no documentation of the intended timeout it might be wrong to convert it with msecs_to_jiffies as this can reduces the actual jiffies value by at least a factor of 10 - so someone that knows this driver needs to check on the

Re: [PATCH net-next] tcp/dccp: warn user for preferred ip_local_port_range

2015-05-27 Thread David Miller
From: Eric Dumazet Date: Wed, 27 May 2015 11:34:37 -0700 > From: Eric Dumazet > > After commit 07f4c90062f8f ("tcp/dccp: try to not exhaust > ip_local_port_range in connect()") it is advised to have an even number > of ports described in /proc/sys/net/ipv4/ip_local_port_range > > This means st

[PATCH net v2 0/2] mpls: fix route del errors on wrong scope and type

2015-05-27 Thread Roopa Prabhu
From: Roopa Prabhu This patch fixes incorrect -EINVAL errors due to invalid scope and type during mpls route deletes. $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route show 100 as to 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route del 100 as 200 via inet 10.1.1.2 d

[PATCH net v2 2/2] mpls: fix mpls route deletes to not check for route scope

2015-05-27 Thread Roopa Prabhu
From: Roopa Prabhu Ignore scope for route del messages Signed-off-by: Vivek Venkataraman Signed-off-by: Roopa Prabhu --- net/mpls/af_mpls.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index 7b3f732..f4eb0dd 100644 --- a/

[PATCH net iproute2 v2 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-05-27 Thread Roopa Prabhu
From: Roopa Prabhu Kernel expects type RTN_UNICAST for mpls route/dels Signed-off-by: Vivek Venkataraman Signed-off-by: Roopa Prabhu --- ip/iproute.c |5 + 1 file changed, 5 insertions(+) diff --git a/ip/iproute.c b/ip/iproute.c index 670a4c6..71c088b 100644 --- a/ip/iproute.c +++ b/

[PATCH net-next] tcp/dccp: warn user for preferred ip_local_port_range

2015-05-27 Thread Eric Dumazet
From: Eric Dumazet After commit 07f4c90062f8f ("tcp/dccp: try to not exhaust ip_local_port_range in connect()") it is advised to have an even number of ports described in /proc/sys/net/ipv4/ip_local_port_range This means start/end values should have a different parity. Let's warn sysadmins of t

Re: [PATCH net-next] qla4xxx: add a missing include

2015-05-27 Thread James Bottomley
On Wed, 2015-05-27 at 14:21 -0400, David Miller wrote: > From: Eric Dumazet > Date: Tue, 26 May 2015 21:43:44 -0700 > > > From: Eric Dumazet > > > > vmalloc.h used to be included from include/net/inet_hashtables.h > > but it is no longer the case. > > > > Fixes: 095dc8e0c368 ("tcp: fix/cleanup

Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan_cleanup

2015-05-27 Thread David Miller
From: Cong Wang Date: Wed, 27 May 2015 10:44:26 -0700 > On Tue, May 26, 2015 at 12:42 AM, Sorin Dumitru wrote: >> We're seeing some softlockups from this function when there >> are a lot fdb entries on a vxlan device. Taking the lock for >> each bucket instead of the whole table is enough to fix

Re: [PATCH net-next] tcp: connect() from bound sockets can be faster

2015-05-27 Thread David Miller
From: Eric Dumazet Date: Wed, 27 May 2015 10:46:02 -0700 > From: Eric Dumazet > > __inet_hash_connect() does not use its third argument (port_offset) > if socket was already bound to a source port. > > No need to perform useless but expensive md5 computations. > > Reported-by: Crestez Dan Leo

Re: [PATCH net-next 0/2] cxgb4/cxgb4vf: Adds FL starvation support and cleanup

2015-05-27 Thread David Miller
From: Hariprasad Shenai Date: Wed, 27 May 2015 22:30:22 +0530 > This patch series adds the following. > Adds debugfs entry to inject freelist starvation and some function and > argument cleanup > > This patch series has been created against net-next tree and includes > patches on cxgb4 and cxgb4

Re: [PATCH net-next] qla4xxx: add a missing include

2015-05-27 Thread David Miller
From: Eric Dumazet Date: Tue, 26 May 2015 21:43:44 -0700 > From: Eric Dumazet > > vmalloc.h used to be included from include/net/inet_hashtables.h > but it is no longer the case. > > Fixes: 095dc8e0c368 ("tcp: fix/cleanup inet_ehash_locks_alloc()") > Reported-by: kbuild test robot > Signed-of

RE: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-27 Thread KY Srinivasan
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, May 27, 2015 11:13 AM > To: KY Srinivasan > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com > Subje

Re: [PATCH net-next v6 0/2] Adding support for Cavium ThunderX network controller

2015-05-27 Thread David Miller
From: Aleksey Makarov Date: Tue, 26 May 2015 19:20:13 -0700 > This patchset adds support for the Cavium ThunderX network controller. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo i

Re: [PATCH v3] isdn: Use ktime_t instead of 'struct timeval'

2015-05-27 Thread David Miller
From: Tina Ruchandani Date: Wed, 27 May 2015 06:52:12 +0530 > 'struct timeval' uses 32-bit representation for seconds which will > overflow in year 2038 and beyond. mISDN/clock.c needs to compute and > store elapsed time in intervals of 125 microseconds. This patch replaces > the usage of 'struct

Re: [PATCH] sctp: Fix mangled IPv4 addresses on a IPv6 listening socket

2015-05-27 Thread David Miller
From: Jason Gunthorpe Date: Tue, 26 May 2015 17:30:17 -0600 > sctp_v4_map_v6 was subtly writing and reading from members > of a union in a way the clobbered data it needed to read before > it read it. > > Zeroing the v6 flowinfo overwrites the v4 sin_addr with 0, meaning > that every place that

Re: [PATCH net-next v2] test_bpf: add similarly conflicting jump test case only for classic

2015-05-27 Thread David Miller
From: Daniel Borkmann Date: Tue, 26 May 2015 22:35:43 +0200 > While 3b52960266a3 ("test_bpf: add more eBPF jump torture cases") > added the int3 bug test case only for eBPF, which needs exactly 11 > passes to converge, here's a version for classic BPF with 11 passes, > and one that would need 70

Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-27 Thread Gopakumar Choorakkot Edakkunni
Doesnt seem so. This is the output from one of the servers I have where I periodically hit this TSval != TSecr condition. ubuntu@server:~$ sudo su root@server:/home/ubuntu# sysctl net.ipv4.tcp_tw_recycle net.ipv4.tcp_tw_recycle = 0 root@server:/home/ubuntu# sysctl net.ipv4.tcp_tw_reuse net.ipv4.t

Re: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues

2015-05-27 Thread David Miller
From: "K. Y. Srinivasan" Date: Tue, 26 May 2015 16:21:09 -0700 > The current algorithm for deciding on the number of VRSS channels is > not optimal since we open up the min of number of CPUs online and the > number of VRSS channels the host is offering. So on a 32 VCPU guest > we could potentiall

Re: [Patch net] net_sched: invoke ->attach() after setting dev->qdisc

2015-05-27 Thread David Miller
From: Cong Wang Date: Tue, 26 May 2015 16:08:48 -0700 > For mq qdisc, we add per tx queue qdisc to root qdisc > for display purpose, however, that happens too early, > before the new dev->qdisc is finally set, this causes > q->list points to an old root qdisc which is going to be > freed right be

Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan_cleanup

2015-05-27 Thread Sorin Dumitru
On Wed, May 27, 2015 at 8:44 PM, Cong Wang wrote: > On Tue, May 26, 2015 at 12:42 AM, Sorin Dumitru wrote: >> We're seeing some softlockups from this function when there >> are a lot fdb entries on a vxlan device. Taking the lock for >> each bucket instead of the whole table is enough to fix that

[PATCH V2 1/5] clk: qcom: Add support for NSS/GMAC clocks and resets

2015-05-27 Thread Mathieu Olivari
From: Stephen Boyd Add the NSS/GMAC clocks and the TCM clock and NSS resets. Signed-off-by: Stephen Boyd Signed-off-by: Mathieu Olivari --- drivers/clk/qcom/gcc-ipq806x.c | 594 ++- include/dt-bindings/clock/qcom,gcc-ipq806x.h | 2 + include/dt-bindings

[PATCH V2 2/5] stmmac: add phy-handle support to the platform layer

2015-05-27 Thread Mathieu Olivari
On stmmac driver, PHY specification in device-tree was done using the non-standard property "snps,phy-addr". Specifying a PHY on a different MDIO bus that the one within the stmmac controller doesn't seem to be possible when device-tree is used. This change adds support for the phy-handle property

[PATCH V2 0/5] Add support for QCA IPQ806x Ethernet GMAC controller

2015-05-27 Thread Mathieu Olivari
This patch set adds support for the integrated Ethernet GMAC controller on QCA IPQ806x SoC. This controller is based on a Gigabit Synopsys DesignWare IP, already supported in the stmmac driver located in drivers/net/ethernet/stmicro/stmmac. This change is done as a follow-up to the following threa

[PATCH V2 3/5] stmmac: add fixed-link device-tree support

2015-05-27 Thread Mathieu Olivari
In case DT is used, this change adds the ability to the stmmac driver to detect a fixed-link PHY, instanciate it, and use it during phy_connect(). Fixed link PHYs DT usage is described in: Documentation/devicetree/bindings/net/fixed-link.txt Signed-off-by: Mathieu Olivari --- drivers/net/ethern

[PATCH V2 4/5] stmmac: add ipq806x glue layer

2015-05-27 Thread Mathieu Olivari
The ethernet controller available in IPQ806x is a Synopsys DesignWare Gigabit MAC IP core, already supported by the stmmac driver. This glue layer implements some platform specific settings required to get the controller working on an IPQ806x based platform. Signed-off-by: Mathieu Olivari --- N

Re: [PATCHv1] xen-netfront: properly destroy queues when removing device

2015-05-27 Thread David Miller
From: David Vrabel Date: Wed, 27 May 2015 15:46:10 +0100 > xennet_remove() freed the queues before freeing the netdevice which > results in a use-after-free when free_netdev() tries to delete the > napi instances that have already been freed. > > Fix this by fully destroy the queues (which inclu

[PATCH V2 5/5] net: stmmac: ipq806x: document device tree bindings

2015-05-27 Thread Mathieu Olivari
Add the device tree bindings documentation for the QCA IPQ806x variant of the Synopsys DesignWare MAC. Signed-off-by: Mathieu Olivari --- .../devicetree/bindings/net/ipq806x-dwmac.txt | 35 ++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/

Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 10:57 -0700, Eric Dumazet wrote: > On Wed, 2015-05-27 at 10:29 -0700, Gopakumar Choorakkot Edakkunni wrote: > > Thanks Eric. I will give this a spin. The issue doesnt happen all the > > time, I can keep the server running with this patch for a while and > > observe if the issu

Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 10:29 -0700, Gopakumar Choorakkot Edakkunni wrote: > Thanks Eric. I will give this a spin. The issue doesnt happen all the > time, I can keep the server running with this patch for a while and > observe if the issue resurfaces or not Note that if the traffic on the server is

Re: [PATCH net-next v4 0/3] sfc: add MCDI tracing

2015-05-27 Thread David Miller
From: Edward Cree Date: Wed, 27 May 2015 13:12:31 +0100 > This patchset adds support for logging MCDI (Management-Controller-to- > Driver Interface) interactions between the sfc driver and a bound device, > to aid in debugging. > Solarflare has a tool to decode the resulting traces and will loo

[RFC 3/6] VSOCK: Introduce virtio-vsock-common.ko

2015-05-27 Thread Stefan Hajnoczi
From: Asias He This module contains the common code and header files for the following virtio-vsock and virtio-vhost kernel modules. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- include/linux/virtio_vsock.h| 207 + include/uapi/linux/virtio_ids.h |1

Re: [PATCH net-next] tcp/dccp: try to not exhaust ip_local_port_range in connect()

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 13:31 -0400, David Miller wrote: > Looks fine, applied, thanks Eric. > > Arguably, we might want to emit a warning if the user sets the port > range sysctl non-even. But that's up to you. Right, I guess we can do that. I'll send a followup patch. Thanks ! -- To unsubs

[PATCH net-next] tcp: connect() from bound sockets can be faster

2015-05-27 Thread Eric Dumazet
From: Eric Dumazet __inet_hash_connect() does not use its third argument (port_offset) if socket was already bound to a source port. No need to perform useless but expensive md5 computations. Reported-by: Crestez Dan Leonard Signed-off-by: Eric Dumazet --- net/ipv4/inet_hashtables.c |9

Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan_cleanup

2015-05-27 Thread Cong Wang
On Tue, May 26, 2015 at 12:42 AM, Sorin Dumitru wrote: > We're seeing some softlockups from this function when there > are a lot fdb entries on a vxlan device. Taking the lock for > each bucket instead of the whole table is enough to fix that. > Hmm, then the spinlock could be moved into each buc

[PATCH] xfrm6: Do not use xfrm_local_error for path MTU issues in tunnels

2015-05-27 Thread Alexander Duyck
This change makes it so that we use icmpv6_send to report PMTU issues back into tunnels in the case that the resulting packet is larger than the MTU of the outgoing interface. Previously xfrm_local_error was being used in this case, however this was resulting in no changes, I suspect due to the fa

Re: [PATCH net-next V4 00/12] net/mlx5: ConnectX-4 100G Ethernet driver

2015-05-27 Thread David Miller
From: Or Gerlitz Date: Mon, 25 May 2015 22:07:23 +0300 > On Wed, May 20, 2015 at 5:17 PM, Amir Vadai wrote: >> On Tue, May 19, 2015 at 7:41 PM, David Miller wrote: >>> From: Amir Vadai >>> Date: Tue, 19 May 2015 12:25:12 +0300 >>> On Sun, May 17, 2015 at 8:05 PM, David Miller wrote:

Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan_cleanup

2015-05-27 Thread David Miller
From: Sorin Dumitru Date: Tue, 26 May 2015 10:42:04 +0300 > We're seeing some softlockups from this function when there > are a lot fdb entries on a vxlan device. Taking the lock for > each bucket instead of the whole table is enough to fix that. > > Signed-off-by: Sorin Dumitru Applied, thank

Re: [PATCH net-next] tcp/dccp: try to not exhaust ip_local_port_range in connect()

2015-05-27 Thread David Miller
From: Eric Dumazet Date: Sun, 24 May 2015 14:49:35 -0700 > From: Eric Dumazet > > A long standing problem on busy servers is the tiny available TCP port > range (/proc/sys/net/ipv4/ip_local_port_range) and the default > sequential allocation of source ports in connect() system call. > > If a h

Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

2015-05-27 Thread Gopakumar Choorakkot Edakkunni
Thanks Eric. I will give this a spin. The issue doesnt happen all the time, I can keep the server running with this patch for a while and observe if the issue resurfaces or not Rgds, Gopa. On Wed, May 27, 2015 at 6:45 AM, Eric Dumazet wrote: > On Wed, 2015-05-27 at 06:33 -0700, Eric Dumazet wrot

Re: [PATCH] pci: Use a bus-global mutex to protect VPD operations

2015-05-27 Thread Bjorn Helgaas
On Mon, May 18, 2015 at 05:00:37PM -0700, Mark D Rustad wrote: > Some devices have a problem with concurrent VPD access to different > functions of the same physical device, so move the protecting mutex > from the pci_vpd structure to the pci_bus structure. There are a > number of reports on suppor

Re: [PATCH] net: tcp: Fix a PTO timing granularity issue

2015-05-27 Thread Eric Dumazet
On Wed, 2015-05-27 at 12:54 -0400, Ido Yariv wrote: > Hi Eric, > That's a nice optimization ;) > > However, I think that with Nicholas Mc Guire's recent changes to > msecs_to_jiffies (http://marc.info/?l=linux-kernel&m=143195210010666), > we should get this for free, no? Well, on net and net-nex

Re: [PATCH v5 2/3] if_link: Add control trust VF

2015-05-27 Thread Edward Cree
On 20/05/15 01:04, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto > > Add netlink directives and ndo entry to trust VF user. > > This controls the special permission of VF user. > The administrator will dedicatedly trust VF user to use some features > which impacts security and/or performance.

[RFC 6/6] VSOCK: Add Makefile and Kconfig

2015-05-27 Thread Stefan Hajnoczi
From: Asias He Enable virtio-vsock and vhost-vsock. Signed-off-by: Asias He Signed-off-by: Stefan Hajnoczi --- drivers/vhost/Kconfig | 4 drivers/vhost/Kconfig.vsock | 7 +++ drivers/vhost/Makefile | 4 net/vmw_vsock/Kconfig | 18 ++ net/vmw_v

  1   2   >