[PATCH net-next] virtio-net: avoid unnecessary sg initialzation

2015-08-26 Thread Jason Wang
Usually an skb does not have up to MAX_SKB_FRAGS frags. So no need to initialize the unuse part of sg. This patch initialize the sg based on the real number it will used: - during xmit, it could be inferred from nr_frags and can_push. - for small receive buffer, it will also be 2. Cc: Michael S.

[PATCH v5 net-next 4/8] geneve: Make dst-port configurable.

2015-08-26 Thread Pravin B Shelar
Add netlink interface to configure Geneve UDP port number. So that user can configure it for a Gevene device. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf Acked-by: John W. Linville --- drivers/net/geneve.c | 25 + include/uap

[PATCH v5 net-next 3/8] tunnel: introduce udp_tun_rx_dst()

2015-08-26 Thread Pravin B Shelar
Introduce function udp_tun_rx_dst() to initialize tunnel dst on receive path. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf --- drivers/net/vxlan.c| 29 ++-- include/net/dst_metadata.h | 61

[PATCH v5 net-next 6/8] openvswitch: Use Geneve device.

2015-08-26 Thread Pravin B Shelar
With help of tunnel metadata mode OVS can directly use Geneve devices to implement Geneve tunnels. This patch removes all of the OVS specific Geneve code and make OVS use a Geneve net_device. Basic geneve vport is still there to handle compatibility with current userspace application. Signed-off-b

[PATCH v5 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-26 Thread Pravin B Shelar
geneve_core module handles send and receive functionality. This way OVS could use the Geneve API. Now with use of tunnel meatadata mode OVS can directly use Geneve netdevice. So there is no need for separate module for Geneve. Following patch consolidates Geneve protocol processing in single module

[PATCH v5 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-26 Thread Pravin B Shelar
Following patch create new tunnel flag which enable tunnel metadata collection on given device. These devices can be used by tunnel metadata based routing or by OVS. Geneve Consolidation patch get rid of collect_md_tun to simplify tunnel lookup further. Signed-off-by: Pravin B Shelar Reviewed-by:

[PATCH v5 net-next 2/8] geneve: Use skb mark and protocol to lookup route.

2015-08-26 Thread Pravin B Shelar
On packet transmit path geneve need to lookup route. Following patch improves route lookup using more parameters. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf Acked-by: John W. Linville --- drivers/net/geneve.c |3 +++ 1 files changed, 3 insertions(+), 0 d

[PATCH v5 net-next 8/8] geneve: Move device hash table to geneve socket.

2015-08-26 Thread Pravin B Shelar
This change simplifies Geneve Tunnel hash table management. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Reviewed-by: John W. Linville --- drivers/net/geneve.c | 43 +-- 1 files changed, 17 insertions(+), 26 deletions(-) diff --git a/driver

[PATCH v5 net-next 1/8] geneve: Initialize ethernet address in device setup.

2015-08-26 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf Acked-by: John W. Linville --- drivers/net/geneve.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 897e1a3..95e9da0 100644 --- a/drivers/

[PATCH v5 net-next 0/8] geneve: Add support for tunnel metadata mode

2015-08-26 Thread Pravin B Shelar
Following patches adds support for Geneve tunnel metadata mode. OVS can make use of Geneve net-device with tunnel metadata API from kernel. This also allows us to consolidate Geneve implementation from two kernel modules geneve_core and geneve to single geneve module. geneve_core module was target

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread Jiri Pirko
Thu, Aug 27, 2015 at 08:36:03AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Thu, 27 Aug 2015 08:27:04 +0200 > >> I'm not saying it is not possible, it certainly is. But I think that >> for example rocker internals have no value to default user, he >> should not care and he cannot fin

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread David Miller
From: Jiri Pirko Date: Thu, 27 Aug 2015 08:27:04 +0200 > I'm not saying it is not possible, it certainly is. But I think that > for example rocker internals have no value to default user, he > should not care and he cannot find out what is going on there > without knowledge or rocker.c code. The

[PATCH v2 net-next] bridge: Add netlink support for vlan_protocol attribute

2015-08-26 Thread Toshiaki Makita
This enables bridge vlan_protocol to be configured through netlink. When CONFIG_BRIDGE_VLAN_FILTERING is disabled, kernel behaves the same way as this feature is not implemented. Signed-off-by: Toshiaki Makita --- v2: Fix u16 to __be16 include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink

Re: [patch net-next 3/6] net: add netif_is_ovs_master helper with IFF_OPENVSWITCH private flag

2015-08-26 Thread Jiri Pirko
Thu, Aug 27, 2015 at 08:23:13AM CEST, sfel...@gmail.com wrote: >On Wed, Aug 26, 2015 at 10:43 PM, Jiri Pirko wrote: >> Wed, Aug 26, 2015 at 07:43:18PM CEST, sfel...@gmail.com wrote: >>>On Wed, Aug 26, 2015 at 9:36 AM, Jiri Pirko wrote: From: Jiri Pirko Add this helper so code can

Re: [patch net-next 3/6] net: add netif_is_ovs_master helper with IFF_OPENVSWITCH private flag

2015-08-26 Thread Jiri Pirko
Thu, Aug 27, 2015 at 08:23:13AM CEST, sfel...@gmail.com wrote: >On Wed, Aug 26, 2015 at 10:43 PM, Jiri Pirko wrote: >> Wed, Aug 26, 2015 at 07:43:18PM CEST, sfel...@gmail.com wrote: >>>On Wed, Aug 26, 2015 at 9:36 AM, Jiri Pirko wrote: From: Jiri Pirko Add this helper so code can

[PATCH net-next] bpf: add support for %s specifier to bpf_trace_printk()

2015-08-26 Thread Alexei Starovoitov
%s specifier makes bpf program and kernel debugging easier. To make sure that trace_printk won't crash the unsafe string is copied into stack and unsafe pointer is substituted. String is also sanitized for printable characters. The cost of swapping FS in probe_kernel_read is amortized over 4 chars

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread Jiri Pirko
Thu, Aug 27, 2015 at 08:01:15AM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Thu, 27 Aug 2015 07:40:04 +0200 > >> Switch object itselt would not help you to expose rocker internals. I >> don't think that you can find generic way, same for all drivers, to >> expose internal tables and

Re: [patch net-next 3/6] net: add netif_is_ovs_master helper with IFF_OPENVSWITCH private flag

2015-08-26 Thread Scott Feldman
On Wed, Aug 26, 2015 at 10:43 PM, Jiri Pirko wrote: > Wed, Aug 26, 2015 at 07:43:18PM CEST, sfel...@gmail.com wrote: >>On Wed, Aug 26, 2015 at 9:36 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Add this helper so code can easily figure out if netdev is openswitch. >>> >>> Signed-off-by: Jir

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread David Miller
From: Jiri Pirko Date: Thu, 27 Aug 2015 07:40:04 +0200 > Switch object itselt would not help you to expose rocker internals. I > don't think that you can find generic way, same for all drivers, to > expose internal tables and stuff. That is hw specific. Tables are datastructures with names and t

[PATCH net-next] bridge: Add netlink support for vlan_protocol attribute

2015-08-26 Thread Toshiaki Makita
This enables bridge vlan_protocol to be configured through netlink. When CONFIG_BRIDGE_VLAN_FILTERING is disabled, kernel behaves the same way as this feature is not implemented. Signed-off-by: Toshiaki Makita --- include/uapi/linux/if_link.h | 1 + net/bridge/br_netlink.c | 34 ++

Re: tcp: add NV congestion control

2015-08-26 Thread Lawrence Brakmo
The updated NV document with the new experiments and a table with all the experimental results are now available at (http://www.brakmo.org/networking/tcp-nv/TCPNV.html). - Lawrence On 8/25/15, 4:33 PM, "Lawrence Brakmo" wrote: >Changes from v5: cleaning of NV code, changing some default param

Re: [patch net-next 3/6] net: add netif_is_ovs_master helper with IFF_OPENVSWITCH private flag

2015-08-26 Thread Jiri Pirko
Wed, Aug 26, 2015 at 07:43:18PM CEST, sfel...@gmail.com wrote: >On Wed, Aug 26, 2015 at 9:36 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Add this helper so code can easily figure out if netdev is openswitch. >> >> Signed-off-by: Jiri Pirko >> --- >> include/linux/netdevice.h| 8

Re: [patch net-next 3/6] net: add netif_is_ovs_master helper with IFF_OPENVSWITCH private flag

2015-08-26 Thread Jiri Pirko
Wed, Aug 26, 2015 at 07:24:55PM CEST, f.faine...@gmail.com wrote: >On 26/08/15 09:36, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Add this helper so code can easily figure out if netdev is openswitch. >> >> Signed-off-by: Jiri Pirko >> --- >> include/linux/netdevice.h| 8 >

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread Jiri Pirko
Wed, Aug 26, 2015 at 08:21:59PM CEST, sfel...@gmail.com wrote: >On Wed, Aug 26, 2015 at 10:49 AM, David Miller wrote: >> From: Jiri Pirko >> Date: Wed, 26 Aug 2015 09:37:57 +0200 >> >>> I don't think that are much more cases like this. Therefore I think that >>> for this cases, debugfs might be a

[PATCH net-next] bnx2x: Add new device ids under the Qlogic vendor

2015-08-26 Thread Yuval Mintz
This adds support for 3 new PCI device combinations - 1077:16a1, 1077:16a4 and 1077:16ad. Signed-off-by: Yuval Mintz --- Hi Dave, Please consider applying this to 'net-next'. Thanks, Yuval --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans

2015-08-26 Thread roopa
On 8/26/15, 4:33 AM, Nikolay Aleksandrov wrote: On Aug 25, 2015, at 11:06 PM, David Miller wrote: From: Nikolay Aleksandrov Date: Tue, 25 Aug 2015 22:28:16 -0700 Certainly, that should be done and I will look into it, but the essence of this patch is a bit different. The problem here is not

Re: [PATCH v4 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-26 Thread Jesse Gross
On Wed, Aug 26, 2015 at 8:57 PM, Pravin Shelar wrote: > On Wed, Aug 26, 2015 at 8:08 PM, Jesse Gross wrote: >> On Wed, Aug 26, 2015 at 2:54 PM, Pravin B Shelar wrote: >>> @@ -293,15 +615,13 @@ static netdev_tx_t geneve_xmit(struct sk_buff *skb, >>> struct net_device *dev) >> [...] >>> +

Re: [PATCH v4 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-26 Thread Pravin Shelar
On Wed, Aug 26, 2015 at 8:08 PM, Jesse Gross wrote: > On Wed, Aug 26, 2015 at 2:54 PM, Pravin B Shelar wrote: >> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >> index d05150c..a36a1de 100644 >> --- a/drivers/net/geneve.c >> +++ b/drivers/net/geneve.c >> @@ -138,16 +164,18 @@ static vo

[PATCH -next v3 2/2] smsc911x: Ignore error return from device_get_phy_mode()

2015-08-26 Thread Guenter Roeck
Commit 62ee783bf1f8 ("smsc911x: Fix crash seen if neither ACPI nor OF is configured or used") introduces an error check for the return value from device_get_phy_mode() and bails out if there is an error. Unfortunately, there are configurations where no phy is configured. Those configurations now fa

[PATCH -next v3 1/2] device property: Return -ENXIO if there is no suitable FW interface

2015-08-26 Thread Guenter Roeck
Return -ENXIO if device property array access functions don't find a suitable firmware interface. This lets drivers decide if they should use available platform data instead. Cc: Rafael J. Wysocki Signed-off-by: Guenter Roeck --- v2: Added patch v3: Document that device_property_read_string_arr

Re: [PATCH v4 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-26 Thread Jesse Gross
On Wed, Aug 26, 2015 at 2:54 PM, Pravin B Shelar wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index d05150c..a36a1de 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > @@ -138,16 +164,18 @@ static void geneve_rx(struct geneve_sock *gs, struct > sk_buff *skb)

Re: [PATCH net-next] net: Check frag_lists first to prevent data out of order

2015-08-26 Thread Eric Dumazet
On Wed, 2015-08-26 at 19:12 -0700, Eric Dumazet wrote: > On Thu, 2015-08-27 at 08:56 +0800, chenweil...@huawei.com wrote: > > From: Weilong Chen > > > > When try to merge several skbs to prior one, if the frag_list is > > used and the the last one is a small packet, once the condition > > "len <=

Re: [PATCH net-next] net: Check frag_lists first to prevent data out of order

2015-08-26 Thread Eric Dumazet
On Thu, 2015-08-27 at 08:56 +0800, chenweil...@huawei.com wrote: > From: Weilong Chen > > When try to merge several skbs to prior one, if the frag_list is > used and the the last one is a small packet, once the condition > "len <= skb_tailroom(to)" is satisfied, we will get a wrong > packet! > Th

Re: [PATCH v4 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-26 Thread Jesse Gross
On Wed, Aug 26, 2015 at 2:54 PM, Pravin B Shelar wrote: > Following patch create new tunnel flag which enable > tunnel metadata collection on given device. These devices > can be used by tunnel metadata based routing or by OVS. > Geneve Consolidation patch get rid of collect_md_tun to > simplify t

RE: [Question] Usage of dev_hold()/dev_put()

2015-08-26 Thread Zhangjie (HZ)
Very clear explanation,thank you! :-) Zhangjie -Original Message- From: Eric Dumazet [mailto:eric.duma...@gmail.com] Sent: Wednesday, August 26, 2015 9:10 PM To: Zhangjie (HZ) Cc: Jason Wang; netdev@vger.kernel.org; Qinchuanyu; Yewudi; liuyongan 00175866; Wangbicheng; Yan Chen Subject:

[PATCH net-next] net: Check frag_lists first to prevent data out of order

2015-08-26 Thread chenweilong
From: Weilong Chen When try to merge several skbs to prior one, if the frag_list is used and the the last one is a small packet, once the condition "len <= skb_tailroom(to)" is satisfied, we will get a wrong packet! This patch just check frag_lists before the condtion to prevent this from happeni

Re: [PATCH -next v2 1/2] device property: Return -ENXIO if there is no suitable FW interface

2015-08-26 Thread Rafael J. Wysocki
On Wednesday, August 26, 2015 04:25:59 PM Guenter Roeck wrote: > On 08/26/2015 04:37 PM, Rafael J. Wysocki wrote: > > On Wednesday, August 26, 2015 01:20:44 PM Guenter Roeck wrote: > >> Return -ENXIO if device property array access functions don't find > >> a suitable firmware interface. > >> > >>

Re: [PATCH net-next] bpf: fix bpf_skb_set_tunnel_key() helper

2015-08-26 Thread David Miller
From: Alexei Starovoitov Date: Wed, 26 Aug 2015 15:57:38 -0700 > Make sure to indicate to tunnel driver that key.tun_id is set, > otherwise gre won't recognize the metadata. > > Fixes: d3aa45ce6b94 ("bpf: add helpers to access tunnel metadata") > Signed-off-by: Alexei Starovoitov > --- > With t

Re: [PATCH net-next] vrf: Add ethernet header for pass through VRF device

2015-08-26 Thread David Miller
From: David Ahern Date: Wed, 26 Aug 2015 12:36:15 -0700 > As such all we need is to push an eth header to the front of the skb > for 1 loop through the stack and eth_header via dev_hard_header with > NULL daddr is the simplest path to accomplish that. Any other path is > just extra overhead. And

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-26 Thread David Miller
From: Scott Feldman Date: Wed, 26 Aug 2015 11:21:59 -0700 > Using another netdev doesn't seem right. Do we need a new device > class for switches, and then create some common tool/interfaces for > switch device class? This is probably what we will need to do. There has also been a discussion l

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

2015-08-26 Thread Cong Wang
On Wed, Aug 26, 2015 at 5:08 PM, Stephen Hemminger wrote: > On Wed, 26 Aug 2015 15:41:26 -0700 > Cong Wang wrote: > >> Currently there is no check for if a qdisc is appropriate >> to be used as the default qdisc. This causes we get no >> error even we set the default qdisc to an inappropriate one

Re: [Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

2015-08-26 Thread Stephen Hemminger
On Wed, 26 Aug 2015 15:41:26 -0700 Cong Wang wrote: > Currently there is no check for if a qdisc is appropriate > to be used as the default qdisc. This causes we get no > error even we set the default qdisc to an inappropriate one > but an error will be shown up later. This is not good. > > Also

Re: [GIT PULL nf-next] Second Round of IPVS Updates for v4.3

2015-08-26 Thread Simon Horman
On Wed, Aug 26, 2015 at 08:41:50PM +0200, Pablo Neira Ayuso wrote: > On Fri, Aug 21, 2015 at 09:23:38AM -0700, Simon Horman wrote: > > Hi Pablo, > > > > please consider these IPVS Updates for v4.3. > > > > I realise these are a little late in the cycle, so if you would prefer > > me to repost the

Re: [PATCH -next v2 1/2] device property: Return -ENXIO if there is no suitable FW interface

2015-08-26 Thread Guenter Roeck
On 08/26/2015 04:37 PM, Rafael J. Wysocki wrote: On Wednesday, August 26, 2015 01:20:44 PM Guenter Roeck wrote: Return -ENXIO if device property array access functions don't find a suitable firmware interface. This lets drivers decide if they should use available platform data instead. Cc: Raf

Re: [PATCH -next v2 1/2] device property: Return -ENXIO if there is no suitable FW interface

2015-08-26 Thread Rafael J. Wysocki
On Wednesday, August 26, 2015 01:20:44 PM Guenter Roeck wrote: > Return -ENXIO if device property array access functions don't find > a suitable firmware interface. > > This lets drivers decide if they should use available platform data > instead. > > Cc: Rafael J. Wysocki > Signed-off-by: Guent

[PATCH net-next] bpf: fix bpf_skb_set_tunnel_key() helper

2015-08-26 Thread Alexei Starovoitov
Make sure to indicate to tunnel driver that key.tun_id is set, otherwise gre won't recognize the metadata. Fixes: d3aa45ce6b94 ("bpf: add helpers to access tunnel metadata") Signed-off-by: Alexei Starovoitov --- With this fix both vxlan and gretap are working with tc+bpf. net/core/filter.c |

Re: [net-next v2 01/14] i40e: don't degrade __le16

2015-08-26 Thread Joe Perches
On Wed, 2015-08-26 at 15:49 -0700, Jeff Kirsher wrote: > diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c > b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c [] > @@ -2106,11 +2106,12 @@ int i40e_ndo_set_vf_port_vlan(struct net_device > *netdev, [] > dev_err(&pf->

[net-next v2 02/14] i40e: add RX to port CRC errors label

2015-08-26 Thread Jeff Kirsher
From: Shannon Nelson The port.crc_errors is really an RX counter, so let's mark it as such. Change-ID: I179afd3f8a95d45229bb4163a6aeb01f0d2d250b Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- 1 fil

[net-next v2 07/14] i40e: Fix comment for ethtool diagnostic link test

2015-08-26 Thread Jeff Kirsher
From: Greg Rose The existing comment is incorrect. Add new comment to point out that the PF reset does not affect link but if the reset is changed to a different type that does affect link then the link test would need to be moved to before the reset. Change-ID: I28d786f46e9465860babdee61c1dba5

[net-next v2 01/14] i40e: don't degrade __le16

2015-08-26 Thread Jeff Kirsher
From: Mitch Williams Sparse cries when we compare an __le16 to a u16, almost like it cares about architectures other than x86. Weird. Use the le16_to_cpu macro to make it stop crying. Change-ID: Id068f4d7868a2d3df234a791a76d15938f37db35 Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Si

[net-next v2 08/14] i40e: correct spelling error

2015-08-26 Thread Jeff Kirsher
From: Mitch Williams Turns out that 'inavlid' is an inavlid spelling for 'invalid'. Change-ID: Ie1fe2d0f8d1ba75ab880594875ec2e4152a76f61 Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- 1 file change

[net-next v2 00/14][pull request] Intel Wired LAN Driver Updates 2015-08-26

2015-08-26 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Anjali provides a fix for i40e where the part is not receiving multicast or VLAN tagged packets when in promiscuous mode. This can occur when a software bridge is created on top of the device. Fixed the legacy and MSI interrupt mode in the dr

[net-next v2 09/14] i40evf: Use the correct defines to match the VF registers

2015-08-26 Thread Jeff Kirsher
From: Anjali Singhai Jain Use CTLN1 instead of CTLN for the VF relative register space. Change-ID: Iefba63faf0307af55fec8dbb64f26059f7d91318 Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 28 ++

[net-next v2 05/14] i40e: Fix ethtool offline diagnostic with netqueues

2015-08-26 Thread Jeff Kirsher
From: Greg Rose Treat netqueues the same way we do virtual functions when someone wants to run the ethtool offline diagnostic test. Change-ID: Id48d2b933f1fd0db7be06305a93c6ebe3dc821f5 Signed-off-by: Greg Rose Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/inte

[net-next v2 11/14] i40e: Remove redundant and unneeded messages

2015-08-26 Thread Jeff Kirsher
From: Greg Rose The kernel notifies all VXLAN capable registered drivers, i.e. any driver that implements ndo_add_vxlan_port(), of the addition of a port so that the driver can track which ports are in use. There's no need to log this - it just fills the system log with useless and irksome noise

[net-next v2 12/14] i40e/i40evf: add VIRTCHNL_VF_OFFLOAD flag

2015-08-26 Thread Jeff Kirsher
From: Anjali Singhai Jain Add virtual channel offload capability to support RX polling mode in the VF. Change-ID: Ib643ae2a7506dfc75fc489fc207493fabefa4832 Signed-off-by: Jingjing Wu Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethe

[net-next v2 04/14] i40e: Fix legacy interrupt mode in the driver

2015-08-26 Thread Jeff Kirsher
From: Anjali Singhai Jain This patch fixes the driver flow to take into account legacy interrupts. Over time we added code that assumes MSIX is the only mode that the driver runs in. It also enables a legacy workaround to trigger SWINT when the TX ring has non-cache aligned descriptors pending an

[net-next v2 03/14] i40e: Move function calls to i40e_shutdown instead of i40e_suspend

2015-08-26 Thread Jeff Kirsher
From: Catherine Sullivan We should be stopping the service task and flow director on shutdown not on suspension. Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 16 +--- 1 file changed, 13 in

[net-next v2 14/14] i40e/i40evf: Bump i40e to 1.3.9 and i40evf to 1.3.5

2015-08-26 Thread Jeff Kirsher
From: Catherine Sullivan Bump version and update the copyright year for i40evf. Change-ID: Iddb81b9dba09f0dc57ab54937b5821ecdd721ff6 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/

[net-next v2 13/14] i40e/i40evf: Cache the CEE TLV status returned from firmware

2015-08-26 Thread Jeff Kirsher
From: Neerav Parikh Store the CEE TLV status returned by firmware to allow drivers to dump that for debug purposes. Change-ID: Ie3c4cf8cebabee4f15e1e3fdc4fc8a68bbca40ee Signed-off-by: Neerav Parikh Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_

[net-next v2 06/14] i40e/i40evf: Add capability to gather VEB per TC stats

2015-08-26 Thread Jeff Kirsher
From: Neerav Parikh This patch adds capability to update per VEB per TC statistics and dump it via ethtool. It also adds a structure to hold VEB per TC statistics. The fields can be filled by reading the GLVEBTC_* counters. Change-ID: I28b4759b9ab6ad5a61f046a1bc9ef6b16fe31538 Signed-off-by: Neer

[Patch net-next 2/5] net_sched: move TCQ_F_MQROOT into qdisc ops

2015-08-26 Thread Cong Wang
It is just another static flag which can be moved. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- include/net/sch_generic.h | 2 +- net/sched/sch_api.c | 6 +++--- net/sched/sch_mq.c| 2 +- net/sched/sch_mqprio.c| 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff

[Patch net-next 1/5] net_sched: move some qdisc flag into qdisc ops

2015-08-26 Thread Cong Wang
For those static flags, that is never changed dynamically, we could just move them into qdisc->ops. This will be used by the following patches. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- include/net/sch_generic.h | 3 ++- net/sched/sch_api.c | 4 ++-- net/sched/sch_generic.c |

[Patch net-next 0/5] net_sched: introduce static flags for qdisc's

2015-08-26 Thread Cong Wang
The main goal of this patchset is to improve the behavior of setting the default qdisc. Current behavior has no error check, no check for ingress and _can_ crash the kernel with some buggy implementation. We only have flags for each instance of qdisc's, for flags like if a qdisc is a fifo qdisc, t

[Patch net-next 5/5] net_sched: move ingress flag into qdisc ops

2015-08-26 Thread Cong Wang
Cc: Jamal Hadi Salim Cc: Stephen Hemminger Signed-off-by: Cong Wang --- include/net/sch_generic.h | 2 +- net/sched/sch_api.c | 11 +-- net/sched/sch_ingress.c | 1 + 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/net/sch_generic.h b/include/net/sch_gen

[Patch net-next 4/5] net_sched: forbid setting default qdisc to inappropriate ones

2015-08-26 Thread Cong Wang
Currently there is no check for if a qdisc is appropriate to be used as the default qdisc. This causes we get no error even we set the default qdisc to an inappropriate one but an error will be shown up later. This is not good. Also, for qdisc's like HTB, kernel will just crash when we use it as d

[Patch net-next 3/5] net_sched: use a flag to indicate fifo qdiscs instead of the name

2015-08-26 Thread Cong Wang
Relying on its name is a bad practice. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- include/net/sch_generic.h | 1 + net/sched/sch_fifo.c | 6 -- net/sched/sch_generic.c | 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/include/net/sch_generic.h b/include/net

Re: [PATCH net-next] route: fix breakage after moving lwtunnel state

2015-08-26 Thread Thomas Graf
On 08/26/15 at 06:19pm, Jiri Benc wrote: > might be a noise. However, there's definitely room for performance > improvement here, the lwtunnel vxlan throughput is at about ~40% of the > non-vxlan throughput. I did not spend too much time on analyzing this, yet, > but it's clear the dst_entry layout

Re: [PATCH net-next] net: sched: consolidate tc_classify{,_compat}

2015-08-26 Thread Daniel Borkmann
On 08/26/2015 11:54 PM, Alexei Starovoitov wrote: On 8/26/15 2:00 PM, Daniel Borkmann wrote: ... +reset: +if (unlikely(limit++ >= MAX_REC_LOOP)) { +net_notice_ratelimited("%s: reclassify loop, rule prio %u, " + "protocol %02x\n", tp->q->ops->id, +

[PATCH v4 net-next 1/8] geneve: Initialize ethernet address in device setup.

2015-08-26 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf Acked-by: John W. Linville --- drivers/net/geneve.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 897e1a3..95e9da0 100644 --- a/drivers/

[PATCH v4 net-next 4/8] geneve: Make dst-port configurable.

2015-08-26 Thread Pravin B Shelar
Add netlink interface to configure Geneve UDP port number. So that user can configure it for a Gevene device. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf Acked-by: John W. Linville --- drivers/net/geneve.c | 25 + include/uap

[PATCH v4 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-26 Thread Pravin B Shelar
Following patch create new tunnel flag which enable tunnel metadata collection on given device. These devices can be used by tunnel metadata based routing or by OVS. Geneve Consolidation patch get rid of collect_md_tun to simplify tunnel lookup further. Signed-off-by: Pravin B Shelar --- v3-v4: -

[PATCH v4 net-next 2/8] geneve: Use skb mark and protocol to lookup route.

2015-08-26 Thread Pravin B Shelar
On packet transmit path geneve need to lookup route. Following patch improves route lookup using more parameters. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf Acked-by: John W. Linville --- drivers/net/geneve.c |3 +++ 1 files changed, 3 insertions(+), 0 d

[PATCH v4 net-next 6/8] openvswitch: Use Geneve device.

2015-08-26 Thread Pravin B Shelar
With help of tunnel metadata mode OVS can directly use Geneve devices to implement Geneve tunnels. This patch removes all of the OVS specific Geneve code and make OVS use a Geneve net_device. Basic geneve vport is still there to handle compatibility with current userspace application. Signed-off-b

[PATCH v4 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-26 Thread Pravin B Shelar
geneve_core module handles send and receive functionality. This way OVS could use the Geneve API. Now with use of tunnel meatadata mode OVS can directly use Geneve netdevice. So there is no need for separate module for Geneve. Following patch consolidates Geneve protocol processing in single module

[PATCH v4 net-next 0/8] Geneve: Add support for tunnel metadata mode

2015-08-26 Thread Pravin B Shelar
Following patches adds support for Geneve tunnel metadata mode. OVS can make use of Geneve net-device with tunnel metadata API from kernel. This also allows us to consolidate Geneve implementation from two kernel modules geneve_core and geneve to single geneve module. geneve_core module was target

[PATCH v4 net-next 3/8] tunnel: introduce udp_tun_rx_dst()

2015-08-26 Thread Pravin B Shelar
Introduce function udp_tun_rx_dst() to initialize tunnel dst on receive path. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf --- drivers/net/vxlan.c| 29 ++-- include/net/dst_metadata.h | 61

[PATCH v4 net-next 8/8] geneve: Move device hash table to geneve socket.

2015-08-26 Thread Pravin B Shelar
This change simplifies Geneve Tunnel hash table management. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Reviewed-by: John W. Linville --- Rebased on updated patches. --- drivers/net/geneve.c | 43 +-- 1 files changed, 17 insertions(+), 26 d

Re: [PATCH net-next] net: sched: consolidate tc_classify{,_compat}

2015-08-26 Thread Alexei Starovoitov
On 8/26/15 2:00 PM, Daniel Borkmann wrote: For classifiers getting invoked via tc_classify(), we always need an extra function call into tc_classify_compat(), as both are being exported as symbols and tc_classify() itself doesn't do much except handling of reclassifications when tp->classify() re

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

2015-08-26 Thread Tony Lindgren
* Guenter Roeck [150826 13:58]: > Hi Tony, > > On 08/26/2015 01:16 PM, Tony Lindgren wrote: > [ ... ] > > >>We may need two separate patches, one to fix up device_property_read_u32() > >>to return -ENXIO, and one to fix smsc911x_probe_config() to ignore the error > >>from device_get_phy_mode(),

Re: [PATCH -next v2 2/2] smsc911x: Ignore error return from device_get_phy_mode()

2015-08-26 Thread Tony Lindgren
* Guenter Roeck [150826 13:24]: > Commit 62ee783bf1f8 ("smsc911x: Fix crash seen if neither ACPI nor OF is > configured or used") introduces an error check for the return value from > device_get_phy_mode() and bails out if there is an error. Unfortunately, > there are configurations where no phy i

Re: [PATCH net v3] sctp: asconf's process should verify address parameter is in the beginning

2015-08-26 Thread Vlad Yasevich
On 08/26/2015 05:09 PM, lucien xin wrote: > On Thu, Aug 27, 2015 at 4:59 AM, Marcelo Ricardo Leitner > wrote: >> On Wed, Aug 26, 2015 at 04:42:21PM -0400, Vlad Yasevich wrote: >>> On 08/26/2015 04:35 PM, Xin Long wrote: in sctp_process_asconf(), we get address parameter from the beginning of

Re: [PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning

2015-08-26 Thread Vlad Yasevich
On 08/26/2015 05:03 PM, Xin Long wrote: > in sctp_process_asconf(), we get address parameter from the beginning of > the addip params. but we never check if it's really there. if the addr > param is not there, it still can pass sctp_verify_asconf(), then to be > handled by sctp_process_asconf(), it

Re: [PATCH v3 net-next 8/8] geneve: Move device hash table to geneve socket.

2015-08-26 Thread John W. Linville
On Mon, Aug 24, 2015 at 10:43:15AM -0700, Pravin B Shelar wrote: > This change simplifies Geneve Tunnel hash table management. > > Signed-off-by: Pravin B Shelar > Reviewed-by: Jesse Gross Reviewed-by: John W. Linville -- John W. LinvilleSomeday the world will need a hero, an

Re: [PATCH, net-next] r8169:Actually from r810x_pll_power_up

2015-08-26 Thread Francois Romieu
Corcodel Marian : > Actually from r810x_pll_power_up function i removed function > r810x_phy_power_up because is two situation.One run from rtl8169_phy_reset > wich already power on interface after reset MII_BMCR and two i placed > supplementary on __rtl8169_resume. r810x_phy_power_up and r

Re: [PATCH net v3] sctp: asconf's process should verify address parameter is in the beginning

2015-08-26 Thread lucien xin
On Thu, Aug 27, 2015 at 4:59 AM, Marcelo Ricardo Leitner wrote: > On Wed, Aug 26, 2015 at 04:42:21PM -0400, Vlad Yasevich wrote: >> On 08/26/2015 04:35 PM, Xin Long wrote: >> > in sctp_process_asconf(), we get address parameter from the beginning of >> > the addip params. but we never check if it'

[PATCH net v4] sctp: asconf's process should verify address parameter is in the beginning

2015-08-26 Thread Xin Long
in sctp_process_asconf(), we get address parameter from the beginning of the addip params. but we never check if it's really there. if the addr param is not there, it still can pass sctp_verify_asconf(), then to be handled by sctp_process_asconf(), it will not be safe. so add detection in sctp_ver

Re: [PATCH v3 net-next 4/8] geneve: Make dst-port configurable.

2015-08-26 Thread John W. Linville
On Mon, Aug 24, 2015 at 10:43:11AM -0700, Pravin B Shelar wrote: > Add netlink interface to configure Geneve UDP port number. > So that user can configure it for a Gevene device. > > Signed-off-by: Pravin B Shelar > Reviewed-by: Jesse Gross Acked-by: John W. Linville -- John W. Linville

Re: [PATCH v3 net-next 2/8] geneve: Use skb mark and protocol to lookup route.

2015-08-26 Thread John W. Linville
On Mon, Aug 24, 2015 at 10:43:09AM -0700, Pravin B Shelar wrote: > On packet transmit path geneve need to lookup route. Following > patch improves route lookup using more parameters. > > Signed-off-by: Pravin B Shelar > Reviewed-by: Jesse Gross > Acked-by: Thomas Graf > --- > drivers/net/genev

[PATCH net-next] net: sched: consolidate tc_classify{,_compat}

2015-08-26 Thread Daniel Borkmann
For classifiers getting invoked via tc_classify(), we always need an extra function call into tc_classify_compat(), as both are being exported as symbols and tc_classify() itself doesn't do much except handling of reclassifications when tp->classify() returned with TC_ACT_RECLASSIFY. CBQ and ATM a

Re: [PATCH net v3] sctp: asconf's process should verify address parameter is in the beginning

2015-08-26 Thread Marcelo Ricardo Leitner
On Wed, Aug 26, 2015 at 04:42:21PM -0400, Vlad Yasevich wrote: > On 08/26/2015 04:35 PM, Xin Long wrote: > > in sctp_process_asconf(), we get address parameter from the beginning of > > the addip params. but we never check if it's really there. if the addr > > param is not there, it still can pass

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

2015-08-26 Thread Guenter Roeck
Hi Tony, On 08/26/2015 01:16 PM, Tony Lindgren wrote: [ ... ] We may need two separate patches, one to fix up device_property_read_u32() to return -ENXIO, and one to fix smsc911x_probe_config() to ignore the error from device_get_phy_mode(), and to bail out if device_property_read_u32() returns

Re: ip_rcv_finish() NULL pointer and possibly related Oopses

2015-08-26 Thread Michael Marineau
On Wed, Aug 26, 2015 at 4:49 AM, Chuck Ebbert wrote: > On Wed, 26 Aug 2015 08:46:59 + > Shaun Crampton wrote: > >> Testing our app at scale on Google¹s GCE, running ~1000 CoreOS hosts: over >> approximately 1 hour, I see about 1 in 50 hosts hit one of the Oopses >> below and then reboot (I¹m

[PATCH net v3] sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state

2015-08-26 Thread Xin Long
Commit f8d960524328 ("sctp: Enforce retransmission limit during shutdown") fixed a problem with excessive retransmissions in the SHUTDOWN_PENDING by not resetting the association overall_error_count. This allowed the association to better enforce assoc.max_retrans limit. However, the same issue s

Re: [PATCH v3 net-next 1/8] geneve: Initialize ethernet address in device setup.

2015-08-26 Thread John W. Linville
On Mon, Aug 24, 2015 at 10:43:08AM -0700, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > Reviewed-by: Jesse Gross > Acked-by: Thomas Graf > --- > drivers/net/geneve.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/geneve.c b/drivers/net/

Re: [PATCH net v3] sctp: asconf's process should verify address parameter is in the beginning

2015-08-26 Thread Vlad Yasevich
On 08/26/2015 04:35 PM, Xin Long wrote: > in sctp_process_asconf(), we get address parameter from the beginning of > the addip params. but we never check if it's really there. if the addr > param is not there, it still can pass sctp_verify_asconf(), then to be > handled by sctp_process_asconf(), it

Re: [PATCHv6 net-next 05/10] openvswitch: Add conntrack action

2015-08-26 Thread Pravin Shelar
On Wed, Aug 26, 2015 at 11:31 AM, Joe Stringer wrote: > Expose the kernel connection tracker via OVS. Userspace components can > make use of the CT action to populate the connection state (ct_state) > field for a flow. This state can be subsequently matched. > > Exposed connection states are OVS_C

Re: [PATCH] mac80211: Do not use sizeof() on pointer type

2015-08-26 Thread Arend van Spriel
On 08/26/2015 10:23 PM, Arend van Spriel wrote: On 08/26/2015 12:22 PM, Thierry Reding wrote: From: Thierry Reding The rate_control_cap_mask() function takes a parameter mcs_mask, which GCC will take to be u8 * even though it was declared with a fixed size. This causes the following warning:

[PATCH net v3] sctp: asconf's process should verify address parameter is in the beginning

2015-08-26 Thread Xin Long
in sctp_process_asconf(), we get address parameter from the beginning of the addip params. but we never check if it's really there. if the addr param is not there, it still can pass sctp_verify_asconf(), then to be handled by sctp_process_asconf(), it will not be safe. so add a code in sctp_verify

Re: [PATCH] mac80211: Do not use sizeof() on pointer type

2015-08-26 Thread Arend van Spriel
On 08/26/2015 12:22 PM, Thierry Reding wrote: From: Thierry Reding The rate_control_cap_mask() function takes a parameter mcs_mask, which GCC will take to be u8 * even though it was declared with a fixed size. This causes the following warning: net/mac80211/rate.c: In function 'rate_co

  1   2   3   >