Re: [PATCH net-next] net/mlx5e: fix error return code in mlx5e_alloc_rq()

2018-06-04 Thread Tariq Toukan
On 05/06/2018 5:42 AM, Wei Yongjun wrote: Fix to return error code -ENOMEM from the kvzalloc_node() error handling case instead of 0, as done elsewhere in this function. Fixes: 069d11465a80 ("net/mlx5e: RX, Enhance legacy Receive Queue memory scheme") Signed-off-by: Wei Yongjun --- driver

Re: WARNING: CPU: 3 PID: 0 at net/sched/sch_hfsc.c:1388 hfsc_dequeue+0x319/0x350 [sch_hfsc]

2018-06-04 Thread Marco Berizzi
> Il 8 marzo 2018 alle 17.02 Marco Berizzi ha scritto: > > > Marco Berizzi wrote: > > > > Hello everyone, > > > > Yesterday I got this error on a slackware linux 4.16-rc4 system > > running as a traffic shaping gateway and netfilter nat. > > The error has been arisen after a partial ISP network

Re: [PATCH net-next 0/2] net: phy: improve PM handling of PHY/MDIO

2018-06-04 Thread Heiner Kallweit
On 04.06.2018 23:48, Andrew Lunn wrote: > On Sat, Jun 02, 2018 at 10:33:36PM +0200, Heiner Kallweit wrote: >> Current implementation of MDIO bus PM ops doesn't actually implement >> bus-specific PM ops but just calls PM ops defined on a device level >> what doesn't seem to be fully in line with the

Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures

2018-06-04 Thread Ido Schimmel
On Mon, Jun 04, 2018 at 03:15:03PM -0700, dsah...@kernel.org wrote: > From: David Ahern > > Return messages in extack for port split/unsplit errors. e.g., > $ devlink port split swp1s1 count 4 > Error: mlxsw_spectrum: Port cannot be split further. > devlink answers: Invalid argument >

Re: [PATCH net-next] net: metrics: add proper netlink validation

2018-06-04 Thread Eric Dumazet
On 06/04/2018 04:46 PM, Eric Dumazet wrote: > Before using nla_get_u32(), better make sure the attribute > is of the proper size. > > > Fixes: a919525ad832 ("net: Move fib_convert_metrics to metrics file") > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Eric Dumazet > Reported-by

Re: [RFC PATCH 0/2] net: macb: Disable TX checksum offloading on all Zynq

2018-06-04 Thread Harini Katakam
Hi Jeniffer, On Mon, Jun 4, 2018 at 8:35 PM, Nicolas Ferre wrote: > Jennifer, > > On 25/05/2018 at 23:44, Jennifer Dahm wrote: >> >> During testing, I discovered that the Zynq GEM hardware overwrites all >> outgoing UDP packet checksums, which is illegal in packet forwarding >> cases. This happen

Re: [PATCH net-next] net/mlx5e: Make function mlx5e_change_rep_mtu() static

2018-06-04 Thread Leon Romanovsky
On Tue, Jun 05, 2018 at 02:42:45AM +, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:903:5: warning: > symbol 'mlx5e_change_rep_mtu' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun > --- > drivers/net/ethern

[PATCH net] sctp: not allow transport timeout value less than HZ/5 for hb_timer

2018-06-04 Thread Xin Long
syzbot reported a rcu_sched self-detected stall on CPU which is caused by too small value set on rto_min with SCTP_RTOINFO sockopt. With this value, hb_timer will get stuck there, as in its timer handler it starts this timer again with this value, then goes to the timer handler again. This problem

[PATCH net] failover: eliminate callback hell

2018-06-04 Thread Stephen Hemminger
The net failover should be a simple library, not a virtual object with function callbacks (see callback hell). The code is simpler is smaller both for the netvsc and virtio use case. The code is restructured in many ways. I should have given these as review comments to net_failover during review b

[PATCH net-next] net/mlx5e: fix error return code in mlx5e_alloc_rq()

2018-06-04 Thread Wei Yongjun
Fix to return error code -ENOMEM from the kvzalloc_node() error handling case instead of 0, as done elsewhere in this function. Fixes: 069d11465a80 ("net/mlx5e: RX, Enhance legacy Receive Queue memory scheme") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4

[PATCH net-next] net/mlx5e: Make function mlx5e_change_rep_mtu() static

2018-06-04 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:903:5: warning: symbol 'mlx5e_change_rep_mtu' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[RFC PATCH] net: aquantia: hw_atl_utils_mpi_set_state() can be static

2018-06-04 Thread kbuild test robot
Fixes: 45c5c36aa288 ("net: aquantia: Improve adapter init/deinit logic") Signed-off-by: kbuild test robot --- hw_atl_utils.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/ethernet/aquantia/a

Re: [PATCH net-next 2/5] net: aquantia: Improve adapter init/deinit logic

2018-06-04 Thread kbuild test robot
Hi Igor, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Igor-Russkikh/net-aquantia-Ethtool-based-ring-size-configuration/20180601-05 reproduce: # apt-get install sparse make

Re: [PATCH net-next] net: phy: broadcom: Enable 125 MHz clock on LED4 pin for BCM54612E by default.

2018-06-04 Thread Florian Fainelli
Le 06/04/18 à 13:17, Kun Yi a écrit : > BCM54612E have 4 multi-functional LED pins that can be configured > through register setting; the LED4 pin can be configured to a 125MHz > reference clock output by setting the spare register. Since the dedicated > CLK125 reference clock pin is not brought ou

Re: AF_XDP. Was: [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-06-04

2018-06-04 Thread Alexander Duyck
On Mon, Jun 4, 2018 at 4:32 PM, Alexei Starovoitov wrote: > On Mon, Jun 04, 2018 at 03:02:31PM -0700, Alexander Duyck wrote: >> On Mon, Jun 4, 2018 at 2:27 PM, David Miller wrote: >> > From: Or Gerlitz >> > Date: Tue, 5 Jun 2018 00:11:35 +0300 >> > >> >> Just to make sure, is the AF_XDP ZC (Zero

[PATCH net-next v2] net: qualcomm: rmnet: Fix use after free while sending command ack

2018-06-04 Thread Subash Abhinov Kasiviswanathan
When sending an ack to a command packet, the skb is still referenced after it is sent to the real device. Since the real device could free the skb, the device pointer would be invalid. Also, remove an unnecessary variable. Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial imp

[PATCH net-next v2] net: ipv6: Generate random IID for addresses on RAWIP devices

2018-06-04 Thread Subash Abhinov Kasiviswanathan
RAWIP devices such as rmnet do not have a hardware address and instead require the kernel to generate a random IID for the IPv6 addresses. Signed-off-by: Sean Tranchetti Signed-off-by: Subash Abhinov Kasiviswanathan --- v1->v2: Yoshfuji suggested to update the I/G and G/L bit. Similar functiona

Re: [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-06-04

2018-06-04 Thread David Miller
From: Jeff Kirsher Date: Mon, 4 Jun 2018 10:56:32 -0700 > This series contains a smorgasbord of updates to documentation, e1000e, > igb, ixgbe, ixgbevf and i40e. ... > The following are changes since commit > 8284fd4cb85577eecca024fe1e7a35b39ed0f3f5: > Merge branch 'selftests-net-various' >

Re: [PATCH net-next v11 04/10] netdev: cavium: octeon: Add Octeon III BGX Ports

2018-06-04 Thread Andrew Lunn
> + if (status.link) { > + /* Always full duplex */ > + status.duplex = DUPLEX_FULL; > + > + /* Speed */ > + speed = bgx_port_get_qlm_speed(priv, priv->qlm); > + data = oct_csr_read(BGX_CMR_CONFIG(priv->node, priv->bgx, > +

Re: [PATCH net-next v11 03/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet Nexus

2018-06-04 Thread Andrew Lunn
> + /* Connect to PKI/PKO */ > + data = oct_csr_read(BGX_CMR_CONFIG(numa_node, interface, port)); > + if (is_mix) > + data |= BIT(11); > + else > + data &= ~BIT(11); > + oct_csr_write(data, BGX_CMR_C

Re: [PATCH net-next] net: metrics: add proper netlink validation

2018-06-04 Thread Eric Dumazet
On 06/04/2018 04:54 PM, David Ahern wrote: > On 6/4/18 4:46 PM, Eric Dumazet wrote: >> Before using nla_get_u32(), better make sure the attribute >> is of the proper size. >> >> Code recently was changed, but bug has been there from beginning >> of git. >> > ... >> >> Fixes: a919525ad832 ("net:

Re: [PATCH net-next] net: metrics: add proper netlink validation

2018-06-04 Thread David Ahern
On 6/4/18 4:46 PM, Eric Dumazet wrote: > Before using nla_get_u32(), better make sure the attribute > is of the proper size. > > Code recently was changed, but bug has been there from beginning > of git. > ... > > Fixes: a919525ad832 ("net: Move fib_convert_metrics to metrics file") That commit

[PATCH net-next] net: metrics: add proper netlink validation

2018-06-04 Thread Eric Dumazet
Before using nla_get_u32(), better make sure the attribute is of the proper size. Code recently was changed, but bug has been there from beginning of git. BUG: KMSAN: uninit-value in rtnetlink_put_metrics+0x553/0x960 net/core/rtnetlink.c:746 CPU: 1 PID: 14139 Comm: syz-executor6 Not tainted 4.17

Re: [PATCH bpf-next v2 2/2] samples/bpf: Add xdp_sample_pkts example

2018-06-04 Thread Daniel Borkmann
On 06/05/2018 12:32 AM, Jakub Kicinski wrote: > On Mon, 04 Jun 2018 18:33:56 +0200, Toke Høiland-Jørgensen wrote: >> +if (load_bpf_file(filename)) { > > Would you mind using libbpf instead of bpf_load.o? I converted some > samples in be5bca44aa6b ("samples: bpf: convert some XDP samples from

Re: [PATCH bpf-next v2 1/2] trace_helpers.c: Add helpers to poll multiple perf FDs for events

2018-06-04 Thread Daniel Borkmann
On 06/05/2018 12:26 AM, Jakub Kicinski wrote: > On Mon, 04 Jun 2018 18:33:56 +0200, Toke Høiland-Jørgensen wrote: >> This adds two new helper functions to trace_helpers that supports polling >> multiple perf file descriptors for events. These are used to the XDP >> perf_event_output example, which

Re: [PATCH net-next v2 1/5] net: aquantia: Ethtool based ring size configuration

2018-06-04 Thread Igor Russkikh
>> +mutex_lock(&self->aq_mutex); >> + >> if (aq_utils_obj_test(&self->flags, AQ_NIC_FLAGS_IS_NOT_READY)) >> goto err_exit; >> >> @@ -175,6 +177,7 @@ static void aq_nic_service_timer_cb(struct timer_list *t) >> ctimer = max(ctimer / 2, 1); >> >> err_exit: >>

AF_XDP. Was: [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-06-04

2018-06-04 Thread Alexei Starovoitov
On Mon, Jun 04, 2018 at 03:02:31PM -0700, Alexander Duyck wrote: > On Mon, Jun 4, 2018 at 2:27 PM, David Miller wrote: > > From: Or Gerlitz > > Date: Tue, 5 Jun 2018 00:11:35 +0300 > > > >> Just to make sure, is the AF_XDP ZC (Zero Copy) UAPI going to be > >> merged for this window -- AFAIU from

Re: [bpf-next PATCH] bpf: sockmap, fix crash when ipv6 sock is added

2018-06-04 Thread Daniel Borkmann
On 06/05/2018 01:08 AM, John Fastabend wrote: > On 06/04/2018 12:59 PM, Daniel Borkmann wrote: >> On 06/04/2018 05:21 PM, John Fastabend wrote: >>> This fixes a crash where we assign tcp_prot to IPv6 sockets instead >>> of tcpv6_prot. >>> >>> Previously we overwrote the sk->prot field with tcp_prot

Re: [PATCH net] ipmr: fix error path when mr_table_alloc fails

2018-06-04 Thread kbuild test robot
Hi Sabrina, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Sabrina-Dubroca/ipmr-fix-error-path-when-mr_table_alloc-fails/20180605-060837 config: x86_64-randconfig-x006-201822 (attached as .config) c

Re: [bpf-next PATCH] bpf: sockmap, fix crash when ipv6 sock is added

2018-06-04 Thread John Fastabend
On 06/04/2018 12:59 PM, Daniel Borkmann wrote: > On 06/04/2018 05:21 PM, John Fastabend wrote: >> This fixes a crash where we assign tcp_prot to IPv6 sockets instead >> of tcpv6_prot. >> >> Previously we overwrote the sk->prot field with tcp_prot even in the >> AF_INET6 case. This patch ensures the

Re: [PATCH net-next v11 04/10] netdev: cavium: octeon: Add Octeon III BGX Ports

2018-06-04 Thread Andrew Lunn
> +static int bgx_port_get_qlm_speed(struct bgx_port_priv *priv, int qlm) > +{ > + enum lane_mode lmode; > + u64 data; > + > + data = oct_csr_read(GSER_LANE_MODE(priv->node, qlm)); > + lmode = data & 0xf; > + > + switch (lmode) { > + case R_25G_REFCLK100: > +

Re: [PATCH net-next v2 1/5] net: aquantia: Ethtool based ring size configuration

2018-06-04 Thread Jakub Kicinski
On Tue, 5 Jun 2018 01:30:15 +0300, Igor Russkikh wrote: > @@ -158,6 +158,8 @@ static void aq_nic_service_timer_cb(struct timer_list *t) > int ctimer = AQ_CFG_SERVICE_TIMER_INTERVAL; > int err = 0; > > + mutex_lock(&self->aq_mutex); > + > if (aq_utils_obj_test(&self->flags,

Re: [PATCH net-next 2/3] netdevsim: Add extack error message for devlink reload

2018-06-04 Thread Jakub Kicinski
On Mon, 4 Jun 2018 15:15:02 -0700, dsah...@kernel.org wrote: > From: David Ahern > > devlink reset command can fail if a FIB resource limit is set to a value > lower than the current occupancy. Return a proper message indicating the > reason for the failure. > > $ devlink resource sh netdevsim/

Re: [PATCH bpf-next v3 05/11] bpf: avoid retpoline for lookup/update/delete calls on maps

2018-06-04 Thread David Ahern
On 6/4/18 11:25 AM, Jakub Kicinski wrote: > that, and others can use completions. I personally think Quentin did > an awesome job on the completions, they cover the entire syntax unlike > the iproute2 ones and we intend to keep them that way! iproute2 patches for completions would be welcomed if

Re: [PATCH bpf-next v2 2/2] samples/bpf: Add xdp_sample_pkts example

2018-06-04 Thread Jakub Kicinski
On Mon, 04 Jun 2018 18:33:56 +0200, Toke Høiland-Jørgensen wrote: > + if (load_bpf_file(filename)) { Would you mind using libbpf instead of bpf_load.o? I converted some samples in be5bca44aa6b ("samples: bpf: convert some XDP samples from bpf_load to libbpf"), it's pretty straight forward. M

[PATCH net-next v2 1/5] net: aquantia: Ethtool based ring size configuration

2018-06-04 Thread Igor Russkikh
From: Anton Mikaev Implemented ring size setup, min/max validation and reconfiguration in runtime. NIC level lock is used to prevent collisions on parallel reconfiguration and interference with periodic service timer job. Signed-off-by: Anton Mikaev Signed-off-by: Igor Russkikh --- .../net/et

[PATCH net-next v2 0/5] net: aquantia: various ethtool ops implementation

2018-06-04 Thread Igor Russkikh
In this patchset Anton Mikaev and I added some useful ethtool operations: - ring size changes - link renegotioation - flow control management The patch also improves init/deinit sequence. V2 changes: - using mutex to secure simultaneous dev close/open - using state var to store/restore dev state

[PATCH net-next v2 4/5] net: aquantia: Add renegotiate ethtool operation support

2018-06-04 Thread Igor Russkikh
From: Anton Mikaev Adds ethtool -r|--negotiate operation support. It triggers special control bit on FW interface causing FW to restart link negotiation. Signed-off-by: Igor Russkikh Signed-off-by: Anton Mikaev --- .../net/ethernet/aquantia/atlantic/aq_ethtool.c| 14 + drivers/net

[PATCH net-next v2 3/5] net: aquantia: Implement rx/tx flow control ethtools callback

2018-06-04 Thread Igor Russkikh
Runtime change of pause frame configuration (rx/tx flow control) via ethtool. Signed-off-by: Igor Russkikh --- .../net/ethernet/aquantia/atlantic/aq_ethtool.c| 42 ++ drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 6 +++- .../aquantia/atlantic/hw_atl/hw_atl_utils.c

[PATCH net-next v2 5/5] net: aquantia: bump driver version

2018-06-04 Thread Igor Russkikh
Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/ver.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h b/drivers/net/ethernet/aquantia/atlantic/ver.h index a445de6..94efc64 100644 --- a/drivers/net/ethern

[PATCH net-next v2 2/5] net: aquantia: Improve adapter init/deinit logic

2018-06-04 Thread Igor Russkikh
We now pass link drop status to FW on init/deinit. This is required to inform FW that driver took/released a control on link. FW then will manage its own state and device power profile based on this information. To improve management we remove mpi_set function which ambiguously took both state and

[PATCH net-next] tcp: refactor tcp_ecn_check_ce to remove sk type cast

2018-06-04 Thread Yousuk Seung
Refactor tcp_ecn_check_ce and __tcp_ecn_check_ce to accept struct sock* instead of tcp_sock* to clean up type casts. This is a pure refactor patch. Signed-off-by: Yousuk Seung Signed-off-by: Neal Cardwell Signed-off-by: Yuchung Cheng Signed-off-by: Eric Dumazet Acked-by: Soheil Hassas Yeganeh

Re: [PATCH bpf-next v2 1/2] trace_helpers.c: Add helpers to poll multiple perf FDs for events

2018-06-04 Thread Jakub Kicinski
On Mon, 04 Jun 2018 18:33:56 +0200, Toke Høiland-Jørgensen wrote: > This adds two new helper functions to trace_helpers that supports polling > multiple perf file descriptors for events. These are used to the XDP > perf_event_output example, which needs to work with one perf fd per CPU. > > Signed

[PATCH net-next v11 08/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet core

2018-06-04 Thread Steven J. Hill
From: Carlos Munoz This is the main core of the BGX Ethernet driver. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- drivers/net/ethernet/cavium/octeon/octeon3-core.c | 2380 + 1 file changed, 2380 insertions(+) create mode 100644 drivers/net/ethernet/cavium

[PATCH net-next v11 09/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet building

2018-06-04 Thread Steven J. Hill
From: Carlos Munoz Add the build and configuration files for the BGX Ethernet. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- drivers/net/ethernet/cavium/Kconfig | 22 +- drivers/net/ethernet/cavium/octeon/Makefile | 8 +++- 2 files changed, 28

[PATCH net-next v11 06/10] netdev: cavium: octeon: Add Octeon III PKO Support

2018-06-04 Thread Steven J. Hill
From: Carlos Munoz Add support for Octeon III PKO logic block for BGX Ethernet. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- drivers/net/ethernet/cavium/octeon/octeon3-pko.c | 1619 ++ 1 file changed, 1619 insertions(+) create mode 100644 drivers/net/ethe

[PATCH net-next v11 10/10] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2018-06-04 Thread Steven J. Hill
From: David Daney Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 70d61c2..9ab8b69 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3249,6 +3249,12 @@ W: http://www.cavium.com S: Supported F: driv

[PATCH net-next v11 03/10] netdev: cavium: octeon: Add Octeon III BGX Ethernet Nexus

2018-06-04 Thread Steven J. Hill
From: Carlos Munoz Add the BGX nexus architeture for Octeon III BGX Ethernet. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- .../net/ethernet/cavium/octeon/octeon3-bgx-nexus.c | 673 + 1 file changed, 673 insertions(+) create mode 100644 drivers/net/etherne

[PATCH net-next v11 01/10] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2018-06-04 Thread Steven J. Hill
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- .../devicetree/bindings/net/cavium-bgx.txt | 59 ++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetre

[PATCH net-next v11 04/10] netdev: cavium: octeon: Add Octeon III BGX Ports

2018-06-04 Thread Steven J. Hill
From: Carlos Munoz Add individual BGX nexus port support for Octeon III BGX Ethernet. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- .../net/ethernet/cavium/octeon/octeon3-bgx-port.c | 2196 1 file changed, 2196 insertions(+) create mode 100644 drivers/ne

[PATCH net-next v11 00/10] netdev: octeon-ethernet: Add Cavium Octeon III support.

2018-06-04 Thread Steven J. Hill
Add the Cavium OCTEON III network driver. There are some corresponding MIPS architecture support changes which will be upstreamed separately. Changes in v11: o Massive clean-up of files, split big patch into smaller pieces, and some minor rework. Carlos Munoz (9): dt-bindings: Add Cavium Oct

[PATCH net-next v11 02/10] netdev: cavium: octeon: Header for Octeon III BGX Ethernet

2018-06-04 Thread Steven J. Hill
From: Carlos Munoz Add the common header file used by the Octeon III BGX Ethernet driver. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- drivers/net/ethernet/cavium/octeon/octeon3.h | 409 +++ 1 file changed, 409 insertions(+) create mode 100644 drivers

[PATCH net-next v11 05/10] netdev: cavium: octeon: Add Octeon III PKI Support

2018-06-04 Thread Steven J. Hill
From: Carlos Munoz Add support for Octeon III PKI logic block for BGX Ethernet. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- drivers/net/ethernet/cavium/octeon/octeon3-pki.c | 781 +++ 1 file changed, 781 insertions(+) create mode 100644 drivers/net/ether

[PATCH net-next v11 07/10] netdev: cavium: octeon: Add Octeon III SSO Support

2018-06-04 Thread Steven J. Hill
From: Carlos Munoz Add support for Octeon III SSO logic block for BGX Ethernet. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill --- drivers/net/ethernet/cavium/octeon/octeon3-sso.c | 244 +++ 1 file changed, 244 insertions(+) create mode 100644 drivers/net/ether

[PATCH net-next 1/3] devlink: Add extack to reload and port_{un,}split operations

2018-06-04 Thread dsahern
From: David Ahern Add extack argument to reload, port_split and port_unsplit operations. Signed-off-by: David Ahern --- drivers/net/ethernet/mellanox/mlxsw/core.c | 9 ++--- drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 5 +++-- drivers/net/netdevsim/devlink.c

[PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures

2018-06-04 Thread dsahern
From: David Ahern Return messages in extack for port split/unsplit errors. e.g., $ devlink port split swp1s1 count 4 Error: mlxsw_spectrum: Port cannot be split further. devlink answers: Invalid argument $ devlink port unsplit swp4 Error: mlxsw_spectrum: Port was not split.

[PATCH net-next 2/3] netdevsim: Add extack error message for devlink reload

2018-06-04 Thread dsahern
From: David Ahern devlink reset command can fail if a FIB resource limit is set to a value lower than the current occupancy. Return a proper message indicating the reason for the failure. $ devlink resource sh netdevsim/netdevsim0 netdevsim/netdevsim0: name IPv4 size unlimited unit entry size_

[PATCH net-next 0/3] devlink: Add extack messages for reload and port split/unsplit

2018-06-04 Thread dsahern
From: David Ahern Patch 1 adds extack arg to reload, port_split and port_unsplit devlink operations. Patch 2 adds extack messages for reload operation in netdevsim. Patch 3 adds extack messages to port split/unsplit in mlxsw driver. David Ahern (3): devlink: Add extack to reload and port_{un

Re: [PATCH net-next 0/2] net: phy: improve PM handling of PHY/MDIO

2018-06-04 Thread Florian Fainelli
On 06/04/2018 02:48 PM, Andrew Lunn wrote: > On Sat, Jun 02, 2018 at 10:33:36PM +0200, Heiner Kallweit wrote: >> Current implementation of MDIO bus PM ops doesn't actually implement >> bus-specific PM ops but just calls PM ops defined on a device level >> what doesn't seem to be fully in line with

Re: [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-06-04

2018-06-04 Thread Alexander Duyck
On Mon, Jun 4, 2018 at 2:27 PM, David Miller wrote: > From: Or Gerlitz > Date: Tue, 5 Jun 2018 00:11:35 +0300 > >> Just to make sure, is the AF_XDP ZC (Zero Copy) UAPI going to be >> merged for this window -- AFAIU from [1], it's still under >> examination/development/research for non Intel HWs,

Re: [PATCH net-next 0/2] net: phy: improve PM handling of PHY/MDIO

2018-06-04 Thread Andrew Lunn
On Sat, Jun 02, 2018 at 10:33:36PM +0200, Heiner Kallweit wrote: > Current implementation of MDIO bus PM ops doesn't actually implement > bus-specific PM ops but just calls PM ops defined on a device level > what doesn't seem to be fully in line with the core PM model. > > When looking e.g. at __d

Re: [PATCH net-next] net: sched: return error code when tcf proto is not found

2018-06-04 Thread David Miller
From: Vlad Buslov Date: Mon, 4 Jun 2018 18:32:23 +0300 > If requested tcf proto is not found, get and del filter netlink protocol > handlers output error message to extack, but do not return actual error > code. Add check to return ENOENT when result of tp find function is NULL > pointer. > > F

Re: [PATCH 1/2 v2 net-next] net_failover: Use netdev_features_t instead of u32

2018-06-04 Thread David Miller
From: Dan Carpenter Date: Mon, 4 Jun 2018 17:43:21 +0300 > The features mask needs to be a netdev_features_t (u64) because a u32 > is not big enough. > > Fixes: cfc80d9a1163 ("net: Introduce net_failover driver") > Signed-off-by: Dan Carpenter > --- > v2: In the original patch, I thought that t

Re: [PATCH 2/2 net] team: use netdev_features_t instead of u32

2018-06-04 Thread David Miller
From: Dan Carpenter Date: Mon, 4 Jun 2018 17:46:01 +0300 > This code was introduced in 2011 around the same time that we made > netdev_features_t a u64 type. These days a u32 is not big enough to > hold all the potential features. > > Signed-off-by: Dan Carpenter Applied and queued up for -st

Re: [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-06-04

2018-06-04 Thread David Miller
From: Or Gerlitz Date: Tue, 5 Jun 2018 00:11:35 +0300 > Just to make sure, is the AF_XDP ZC (Zero Copy) UAPI going to be > merged for this window -- AFAIU from [1], it's still under > examination/development/research for non Intel HWs, am I correct or > this is going to get in now? All of the pe

Re: [PATCH net] ipmr: fix error path when mr_table_alloc fails

2018-06-04 Thread David Miller
From: Sabrina Dubroca Date: Mon, 4 Jun 2018 13:55:54 +0200 > commit 0bbbf0e7d0e7 ("ipmr, ip6mr: Unite creation of new mr_table") > refactored ipmr_new_table, so that it now returns NULL when > mr_table_alloc fails. Unfortunately, all callers of ipmr_new_table > expect an ERR_PTR. commit 66fb3325

Re: pull request: bluetooth-next 2018-06-04

2018-06-04 Thread David Miller
From: Johan Hedberg Date: Mon, 4 Jun 2018 12:15:32 +0200 > Here's one last bluetooth-next pull request for the 4.18 kernel: > > - New USB device IDs for Realtek 8822BE and 8723DE > - reset/resume fix for Dell Inspiron 5565 > - Fix HCI_UART_INIT_PENDING flag behavior > - Fix patching behavior

Re: [PATCH] docs: networking: fix minor typos in various documentation files

2018-06-04 Thread David Miller
From: Olivier Gayot Date: Mon, 4 Jun 2018 12:07:37 +0200 > This patch fixes some typos/misspelling errors in the > Documentation/networking files. > > Signed-off-by: Olivier Gayot Applied, thank you.

Re: [PATCH net] net: qualcomm: rmnet: Fix use after free while sending command ack

2018-06-04 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Sun, 3 Jun 2018 16:17:55 -0600 > When sending an ack to a command packet, the skb is still referenced > after it is sent to the real device. Since the real device could > free the skb, the device pointer would be invalid. > > Fixes: ceed73a2cf4a ("driv

Re: [PATCH iproute2 1/2] ip: display netns name instead of nsid

2018-06-04 Thread Stephen Hemminger
On Mon, 4 Jun 2018 14:12:52 +0200 Nicolas Dichtel wrote: > diff --git a/ip/ipaddress.c b/ip/ipaddress.c > index c7c7e7df4e81..aee09c7ff6df 100644 > --- a/ip/ipaddress.c > +++ b/ip/ipaddress.c > @@ -819,6 +819,9 @@ int print_linkinfo(const struct sockaddr_nl *who, > unsigned int m_flag = 0;

Re: [PATCH net-next] net: ipv6: Generate random IID for addresses on RAWIP devices

2018-06-04 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Sun, 3 Jun 2018 15:54:34 -0600 > RAWIP devices such as rmnet do not have a hardware address and > instead require the kernel to generate a random IID for the > temporary addresses. For permanent addresses, the device IID is > used along with prefix rece

Re: [PATCH] net: do not allow changing SO_REUSEADDR/SO_REUSEPORT on bound sockets

2018-06-04 Thread David Miller
From: "Maciej Żenczykowski" Date: Sun, 3 Jun 2018 10:47:05 -0700 > From: Maciej Żenczykowski > > It is not safe to do so because such sockets are already in the > hash tables and changing these options can result in invalidating > the tb->fastreuse(port) caching. > > This can have later far r

Re: [PATCH] net-tcp: extend tcp_tw_reuse sysctl to enable loopback only optimization

2018-06-04 Thread David Miller
From: "Maciej Żenczykowski" Date: Sun, 3 Jun 2018 10:41:17 -0700 > From: Maciej Żenczykowski > > This changes the /proc/sys/net/ipv4/tcp_tw_reuse from a boolean > to an integer. > > It now takes the values 0, 1 and 2, where 0 and 1 behave as before, > while 2 enables timewait socket reuse onl

Re: [PATCH net-next v2] qed: Add srq core support for RoCE and iWARP

2018-06-04 Thread David Miller
From: Yuval Bason Date: Sun, 3 Jun 2018 19:13:07 +0300 > This patch adds support for configuring SRQ and provides the necessary > APIs for rdma upper layer driver (qedr) to enable the SRQ feature. > > Signed-off-by: Michal Kalderon > Signed-off-by: Ariel Elior > Signed-off-by: Yuval Bason > -

Re: [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-06-04

2018-06-04 Thread Or Gerlitz
On Mon, Jun 4, 2018 at 11:30 PM, David Miller wrote: > It's open a day or two more to deal with the AF_XDP issues... Dave, Just to make sure, is the AF_XDP ZC (Zero Copy) UAPI going to be merged for this window -- AFAIU from [1], it's still under examination/development/research for non Intel HW

Re: [PATCH net-next V2 2/2] cls_flower: Fix comparing of old filter mask with new filter

2018-06-04 Thread David Miller
From: Paul Blakey Date: Sun, 3 Jun 2018 10:06:14 +0300 > We incorrectly compare the mask and the result is that we can't modify > an already existing rule. > > Fix that by comparing correctly. > > Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") > Reported-by: Vlad Buslo

Re: [PATCH net-next V2 1/2] cls_flower: Fix missing free of rhashtable

2018-06-04 Thread David Miller
From: Paul Blakey Date: Sun, 3 Jun 2018 10:06:13 +0300 > When destroying the instance, destroy the head rhashtable. > > Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") > Reported-by: Vlad Buslov > Reviewed-by: Roi Dayan > Reviewed-by: Jiri Pirko > Signed-off-by: Paul

Re: [PATCH bpf-next 10/11] i40e: implement AF_XDP zero-copy support for Tx

2018-06-04 Thread Alexander Duyck
On Mon, Jun 4, 2018 at 5:06 AM, Björn Töpel wrote: > From: Magnus Karlsson > > Here, ndo_xsk_async_xmit is implemented. As a shortcut, the existing > XDP Tx rings are used for zero-copy. This will result in other devices > doing XDP_REDIRECT to an AF_XDP enabled queue will have its packets > drop

Re: [PATCH net] net/ipv6: prevent use after free in ip6_route_mpath_notify

2018-06-04 Thread Eric Dumazet
On 06/04/2018 01:41 PM, dsah...@kernel.org wrote: > From: David Ahern > > syzbot reported a use-after-free: > > BUG: KASAN: use-after-free in ip6_route_mpath_notify+0xe9/0x100 > net/ipv6/route.c:4180 > Read of size 4 at addr 8801bf789cf0 by task syz-executor756/4555 > > Fix by not setti

[PATCH net] net/ipv6: prevent use after free in ip6_route_mpath_notify

2018-06-04 Thread dsahern
From: David Ahern syzbot reported a use-after-free: BUG: KASAN: use-after-free in ip6_route_mpath_notify+0xe9/0x100 net/ipv6/route.c:4180 Read of size 4 at addr 8801bf789cf0 by task syz-executor756/4555 CPU: 1 PID: 4555 Comm: syz-executor756 Not tainted 4.17.0-rc7+ #78 Hardware name: Googl

Re: [bug] cxgb4: vrf stopped working with cxgb4 card

2018-06-04 Thread David Ahern
On 6/4/18 1:14 PM, AMG Zollner Robert wrote: > Yes, I was enslaving while the interface was up. > > Just tested some of the builds that where not working earlier and they > are working if I keep the interface down when enslaving as you suggested. > > Is this the expected behavior? Not expected f

Re: [PATCH bpf-next 09/11] i40e: implement AF_XDP zero-copy support for Rx

2018-06-04 Thread Alexander Duyck
On Mon, Jun 4, 2018 at 5:05 AM, Björn Töpel wrote: > From: Björn Töpel > > This commit adds initial AF_XDP zero-copy support for i40e-based > NICs. First we add support for the new XDP_QUERY_XSK_UMEM and > XDP_SETUP_XSK_UMEM commands in ndo_bpf. This allows the AF_XDP socket > to pass a UMEM to t

Re: [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-06-04

2018-06-04 Thread David Miller
From: Or Gerlitz Date: Mon, 4 Jun 2018 23:27:57 +0300 > On Mon, Jun 4, 2018 at 8:56 PM, Jeff Kirsher > wrote: >> This series contains a smorgasbord of updates to documentation, e1000e, >> igb, ixgbe, ixgbevf and i40e. > > Dave, > > Did you forgot to flip the sign on the shop's door [1]? > > O

Re: [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-06-04

2018-06-04 Thread Or Gerlitz
On Mon, Jun 4, 2018 at 8:56 PM, Jeff Kirsher wrote: > This series contains a smorgasbord of updates to documentation, e1000e, > igb, ixgbe, ixgbevf and i40e. Dave, Did you forgot to flip the sign on the shop's door [1]? Or. [1] http://vger.kernel.org/~davem/net-next.html

Re: [Intel-wired-lan] [PATCH bpf-next 00/11] AF_XDP: introducing zero-copy support

2018-06-04 Thread Jeff Kirsher
On Mon, 2018-06-04 at 09:38 -0700, Alexei Starovoitov wrote: > On Mon, Jun 04, 2018 at 02:05:50PM +0200, Björn Töpel wrote: > > From: Björn Töpel > > > > This patch serie introduces zerocopy (ZC) support for > > AF_XDP. Programs using AF_XDP sockets will now receive RX packets > > without any cop

[PATCH net-next] net: phy: broadcom: Enable 125 MHz clock on LED4 pin for BCM54612E by default.

2018-06-04 Thread Kun Yi
BCM54612E have 4 multi-functional LED pins that can be configured through register setting; the LED4 pin can be configured to a 125MHz reference clock output by setting the spare register. Since the dedicated CLK125 reference clock pin is not brought out on the 48-Pin MLP, the LED4 pin is the only

Re: [bug] cxgb4: vrf stopped working with cxgb4 card

2018-06-04 Thread AMG Zollner Robert
Yes, I was enslaving while the interface was up. Just tested some of the builds that where not working earlier and they are working if I keep the interface down when enslaving as you suggested. Is this the expected behavior? Thank you, Zollner Robert On 04.06.2018 21:17, David Ahern wrote:

Re: [PATCH net-next] Allow ethtool to change tun link settings

2018-06-04 Thread David Miller
From: Chas Williams <3ch...@gmail.com> Date: Sat, 2 Jun 2018 17:49:53 -0400 > Let user space set whatever it would like to advertise for the > tun interface. Preserve the existing defaults. > > Signed-off-by: Chas Williams <3ch...@gmail.com> This looks fine, applied.

Re: [bpf-next PATCH] bpf: sockmap, fix crash when ipv6 sock is added

2018-06-04 Thread Daniel Borkmann
On 06/04/2018 05:21 PM, John Fastabend wrote: > This fixes a crash where we assign tcp_prot to IPv6 sockets instead > of tcpv6_prot. > > Previously we overwrote the sk->prot field with tcp_prot even in the > AF_INET6 case. This patch ensures the correct tcp_prot and tcpv6_prot > are used. Further,

Re: [PATCH bpf-next] bpf: guard bpf_get_current_cgroup_id() with CONFIG_CGROUPS

2018-06-04 Thread Daniel Borkmann
On 06/04/2018 05:53 PM, Yonghong Song wrote: > Commit bf6fa2c893c5 ("bpf: implement bpf_get_current_cgroup_id() > helper") introduced a new helper bpf_get_current_cgroup_id(). > The helper has a dependency on CONFIG_CGROUPS. > > When CONFIG_CGROUPS is not defined, using the helper will result > th

Re: [PATCH bpf-next 0/5] AF_XDP: bug fixes and descriptor changes

2018-06-04 Thread Daniel Borkmann
On 06/04/2018 06:24 PM, Alexei Starovoitov wrote: > On Mon, Jun 04, 2018 at 01:57:10PM +0200, Björn Töpel wrote: >> From: Björn Töpel >> >> An issue with the current AF_XDP uapi raised by Mykyta Iziumtsev (see >> https://www.spinics.net/lists/netdev/msg503664.html) is that it does >> not support N

Re: [PATCH bpf-next v3 05/11] bpf: avoid retpoline for lookup/update/delete calls on maps

2018-06-04 Thread Daniel Borkmann
On 06/04/2018 08:25 PM, Jakub Kicinski wrote: [...] > We prefer to have both :) Those of us who like to abbreviate can do > that, and others can use completions. I personally think Quentin did > an awesome job on the completions, they cover the entire syntax unlike > the iproute2 ones and we inte

Re: [PATCH net-next 0/2] net: phy: improve PM handling of PHY/MDIO

2018-06-04 Thread David Miller
From: Heiner Kallweit Date: Sat, 2 Jun 2018 22:33:36 +0200 > Current implementation of MDIO bus PM ops doesn't actually implement > bus-specific PM ops but just calls PM ops defined on a device level > what doesn't seem to be fully in line with the core PM model. > > When looking e.g. at __devic

Re: [PATCH net-next 0/2] mlxsw: Fixes in offloading of mirror-to-gretap

2018-06-04 Thread David Miller
From: Ido Schimmel Date: Sat, 2 Jun 2018 21:09:33 +0300 > Petr says: > > These two patches fix issues in offloading of mirror-to-gretap when > bridge is present in the underlay. > > In patch #1, reconsideration of SPAN configuration is not done right at > the point that SWITCHDEV_OBJ_ID_PORT_V

Re: [PATCH bpf-next v3 05/11] bpf: avoid retpoline for lookup/update/delete calls on maps

2018-06-04 Thread Jakub Kicinski
On Mon, 4 Jun 2018 13:02:25 +0200, Phil Sutter wrote: > On Sun, Jun 03, 2018 at 07:08:55PM +0200, Jesper Dangaard Brouer wrote: > > Secondly I personally *hate* how the 'ip' does it's short options > > parsing and especially order/precedence ambiguity. Phil Sutter > > (Fedora/RHEL iproute2 maintai

Re: [bug] cxgb4: vrf stopped working with cxgb4 card

2018-06-04 Thread David Ahern
On 6/4/18 8:03 AM, AMG Zollner Robert wrote: > I have noticed that vrf is not working with kernel v4.15.0 but was > working with v4.13.0 when using cxgb4 Chelsio driver (T520-cr) > > Setup: > Two metal servers with a T520-cr card each, directly connected without a > switch in between. > >   

[Patch net-next] netdev-FAQ: clarify DaveM's position for stable backports

2018-06-04 Thread Cong Wang
Per discussion with David at netconf 2018, let's clarify DaveM's position of handling stable backports in netdev-FAQ. This is important for people relying on upstream -stable releases. Cc: sta...@vger.kernel.org Cc: Greg Kroah-Hartman Signed-off-by: Cong Wang --- Documentation/networking/netde

[net-next 02/12] Documentation: e100: Update the Intel 10/100 driver doc

2018-06-04 Thread Jeff Kirsher
Over the years, several of the links have changed or are no longer valid so update them. In addition, the default values were incorrect for a couple of parameters. Converted the text file to the reStructuredText (RST) format, since the Linux kernel documentation now uses this format for documenta

[net-next 01/12] e1000e: Ignore TSYNCRXCTL when getting I219 clock attributes

2018-06-04 Thread Jeff Kirsher
From: Benjamin Poirier There have been multiple reports of crashes that look like kernel: RIP: 0010:[] timecounter_read+0xf/0x50 [...] kernel: Call Trace: kernel: [] e1000e_phc_gettime+0x2f/0x60 [e1000e] kernel: [] e1000e_systim_overflow_work+0x1d/0x80 [e1000e] kernel: [] process_one_work+0x15

[net-next 08/12] ixgbe: introduce a helper to simplify code

2018-06-04 Thread Jeff Kirsher
From: YueHaibing ixgbe_dbg_reg_ops_read and ixgbe_dbg_netdev_ops_read copy-pasting the same code except for ixgbe_dbg_netdev_ops_buf/ixgbe_dbg_reg_ops_buf, so introduce a helper ixgbe_dbg_common_ops_read to remove redundant code. Signed-off-by: YueHaibing Tested-by: Andrew Bowers Signed-off-by

  1   2   >