[PATCH 5/6] e1000e: error handling for pci_map_single calls.

2007-08-10 Thread Auke Kok
Add proper error handling for various callers of pci_map_single. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000e/e1000.h |2 ++ drivers/net/e1000e/ethtool.c | 16 +++--- drivers/net/e1000e/netdev.c | 49 +++--- 3 files

[PATCH] [NET] ethtool: Add LRO support

2007-08-09 Thread Auke Kok
Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/ethtool.h |8 +++ include/linux/netdevice.h |1 + net/core/ethtool.c| 53 + 3 files changed, 62 insertions(+), 0 deletions(-) diff --git a/include/linux/ethtool.h b

[PATCH] ethtool: Add LRO support

2007-08-09 Thread Auke Kok
Signed-off-by: Auke Kok [EMAIL PROTECTED] --- ethtool-copy.h |8 ethtool.8 |8 ++-- ethtool.c | 39 +-- 3 files changed, 47 insertions(+), 8 deletions(-) diff --git a/ethtool-copy.h b/ethtool-copy.h index 3a63224..ab9d688

[PATCH] e1000: Add device IDs of new 82571 board variants

2007-08-09 Thread Auke Kok
This patch adds support for 2 new board variants: - A Quad port fiber 82571 board - A blade version of the 82571 quad copper board Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_ethtool.c |2 ++ drivers/net/e1000/e1000_hw.c |5 + drivers/net/e1000

[PATCH] e1000e: remove duplicate shadowing reference to adapter-hw

2007-08-08 Thread Auke Kok
Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000e/netdev.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index dd4eca6..741965d 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drivers/net/e1000e

[PATCH] e1000e: Fix header includes

2007-08-08 Thread Auke Kok
Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000e/82571.c |4 drivers/net/e1000e/e1000.h |7 --- drivers/net/e1000e/es2lan.c |5 + drivers/net/e1000e/ethtool.c |3 ++- drivers/net/e1000e/hw.h |2 ++ drivers/net/e1000e/ich8lan.c |5

[PATCH] [NET] ethtool: Add LRO support

2007-07-31 Thread Auke Kok
Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/ethtool.h |8 +++ include/linux/netdevice.h |1 + net/core/ethtool.c| 54 - 3 files changed, 62 insertions(+), 1 deletions(-) diff --git a/include/linux/ethtool.h b

[PATCH] ethtool: Add LRO support

2007-07-31 Thread Auke Kok
Signed-off-by: Auke Kok [EMAIL PROTECTED] --- ethtool-copy.h |8 ethtool.8 |8 ++-- ethtool.c | 39 +-- 3 files changed, 47 insertions(+), 8 deletions(-) diff --git a/ethtool-copy.h b/ethtool-copy.h index 3a63224..ab9d688

[PATCH] [NET] ethtool: Add support for multiple queues

2007-07-31 Thread Auke Kok
Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/ethtool.h | 23 +++ net/core/ethtool.c | 34 ++ 2 files changed, 57 insertions(+), 0 deletions(-) diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h index ab9d688

[PATCH] ethtool: Add support for setting multiple rx/tx queues

2007-07-31 Thread Auke Kok
Signed-off-by: Auke Kok [EMAIL PROTECTED] --- ethtool-copy.h | 23 + ethtool.8 | 23 + ethtool.c | 103 3 files changed, 149 insertions(+), 0 deletions(-) diff --git a/ethtool-copy.h b/ethtool-copy.h

[PATCH] e100: Fix Tyan motherboard e100 not receiving IPMI commands

2007-07-10 Thread Auke Kok
is not initialised, and the downlaod only specifies 0x16 bytes to be sent to the NIC (thaht's bytes 00..21d). By initializing the GMRC bit, and extending the download size for D102+ MACs, the problem is resolved. Signed-off-by: David Graham [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED

[PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family

2007-06-11 Thread Auke Kok
the msg_enable member of the net_device struct. (3) Ethtool code can just modify the net_device msg_enable for drivers that do not have custom msg_enable get/set handlers so converted drivers lose some code for that as well. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/netdevice.h

[PATCH 2/2] [RFC] NET: Convert several drivers to ndev_printk

2007-06-11 Thread Auke Kok
With the generic ndev_printk macros, we can now convert network drivers to use this generic printk family for netdevices. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e100.c| 135 - drivers/net/e1000/e1000.h | 15

[PATCH] [RFC -v3] NET: Implement a standard ndev_printk family

2007-06-11 Thread Auke Kok
. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/netdevice.h | 54 + net/core/dev.c|5 net/core/ethtool.c| 14 ++-- 3 files changed, 66 insertions(+), 7 deletions(-) diff --git a/include/linux

[PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family

2007-06-08 Thread Auke Kok
the msg_enable member of the net_device struct. (3) Ethtool code can just modify the net_device msg_enable for drivers that do not have custom msg_enable get/set handlers so converted drivers lose some code for that as well. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/netdevice.h

[PATCH 2/2] [RFC] NET: Convert several drivers to ndev_printk

2007-06-08 Thread Auke Kok
With the generic ndev_printk macros, we can now convert network drivers to use this generic printk family for netdevices. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e100.c| 121 +++-- drivers/net/e1000/e1000.h | 15

[PATCH] e1000: disable polling before registering netdevice

2007-06-01 Thread Auke Kok
it to be. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: Herbert Xu [EMAIL PROTECTED] Cc: Doug Chapman [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c

[PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Auke Kok
to netif_poll_enable is in e1000_up() which is only reached after a device reset or resume. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: Herbert Xu [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b

[PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Auke Kok
to netif_poll_enable is in e1000_up() which is only reached after a device reset or resume. Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=8455 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240339 Tested by Doug Chapman [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] Acked-by: Herbert Xu

[PATCH] ixgb: don't print error if pci_enable_msi() fails, cleanup minor leak

2007-05-17 Thread Auke Kok
From: Auke Kok [EMAIL PROTECTED] pci_enable_msi calls can fail for normal operational reasons. Driver should not print an error message in that case. Fix a leak that leaves msi enabled if pci_request_irq fails. We can remove CONFIG_PCI_MSI ifdefs alltogether Signed-off-by: Auke Kok [EMAIL

[PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Auke Kok
a lot better. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: H. Peter Anvin [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c | 32 +++- 1 files changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c

[PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

2007-05-16 Thread Auke Kok
a lot better. All #ifdef CONFIG_PCI_MSI's have been removed. Compile tested with both CONFIG_PCI_MSI enabled and disabled. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: H. Peter Anvin [EMAIL PROTECTED] --- drivers/net/e1000/e1000.h |4 +--- drivers/net/e1000/e1000_main.c | 39

[PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-16 Thread Auke Kok
Our 82571 (first PCI-E hardware) causes P-Series hardware to throw issues. Disabling PCI-E completion timeouts in our NIC resolves the issue. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: Wen Xiong [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c | 10 ++ 1 files changed, 10

[PATCH] [NET] Add constant for FCS/CRC length (frame check sequence)

2007-05-15 Thread Auke Kok
From: Auke Kok [EMAIL PROTECTED] About a dozen drivers that have some form of crc checksumming or offloading use this constant, warranting a global define for it. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/if_ether.h |1 + 1 files changed, 1 insertions(+), 0 deletions

[PATCH 1/2] e1000: ROUND_UP macro cleanup in drivers/net/e1000

2007-04-27 Thread Auke Kok
From: Milind Arun Choudhary [EMAIL PROTECTED] E1000_ROUNDUP macro cleanup, use ALIGN Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000.h |3 --- drivers/net/e1000/e1000_ethtool.c |6 +++--- drivers/net

[PATCH 2/2] ixgb: ROUND_UP macro cleanup in drivers/net/ixgb

2007-04-27 Thread Auke Kok
From: Milind Arun Choudhary [EMAIL PROTECTED] IXGB_ROUNDUP macro cleanup ,use ALIGN Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/ixgb/ixgb.h |3 --- drivers/net/ixgb/ixgb_ethtool.c |4 ++-- drivers/net/ixgb

[PATCH] Seved Torstendahl [EMAIL PROTECTED] suggested to

2007-04-26 Thread Auke Kok
PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e100.c | 15 ++- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/net/e100.c b/drivers/net/e100.c index 1dd1a22..7d9984a 100644 --- a/drivers/net/e100.c +++ b/drivers/net/e100.c @@ -2597,11 +2597,16

[PATCH] It appears that some systems still like e100 better if it uses

2007-04-26 Thread Auke Kok
From: Jesse Brandeburg [EMAIL PROTECTED] I/O access mode. Setting the new parameter use_io=1 will cause all driver instances to use io mapping to access the register space on the e100 device. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED

[PATCH 01/19] e1000: introduce new driver internal hardware API

2007-03-29 Thread Auke Kok
pointer call. Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_api.c | 1174 + drivers/net/e1000/e1000_api.h | 160 ++ 2 files changed, 1334 insertions(+), 0 deletions(-) diff --git a/drivers

[PATCH 05/19] e1000: Add manageability specific hardware initialization code

2007-03-29 Thread Auke Kok
From: Jeb Cramer [EMAIL PROTECTED] This adds a device-generic layer for intializing manageability parts of e1000 hardware, such as packet filtering, dhcp setup, enable passthru mode. Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000

[PATCH 06/19] e1000: Add new register set code

2007-03-29 Thread Auke Kok
From: Jeb Cramer [EMAIL PROTECTED] Add e1000_registers.h which contains all supported register sets by e1000 devices in a single file. Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_regs.h | 261

[PATCH 04/19] e1000: NVM specific hardware initialization code

2007-03-29 Thread Auke Kok
From: Jeb Cramer [EMAIL PROTECTED] This adds NVM-generic layer code to the e1000 driver, allowing generic access to the EEPROM/NVM and abstracts much of the driver interaction with the NVM data. Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers

[PATCH 09/19] e1000: Add 82542 specific hardware code.

2007-03-29 Thread Auke Kok
From: Jeb Cramer [EMAIL PROTECTED] Adapter-specific code for the 82542. Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_82542.c | 551 +++ 1 files changed, 551 insertions(+), 0 deletions

[PATCH 10/19] e1000: Add 82543 specific hardware code.

2007-03-29 Thread Auke Kok
From: Jeb Cramer [EMAIL PROTECTED] Adapter-specific code for the 82543. Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_82543.c | 1643 +++ drivers/net/e1000/e1000_82543.h | 45 + 2 files

[PATCH 14/19] e1000: Add 80003es2lan (ESB2) specific hardware code.

2007-03-29 Thread Auke Kok
From: Jeb Cramer [EMAIL PROTECTED] Adapter-specific code for the 80003es2lan (ESB2). Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_80003es2lan.c | 1377 + drivers/net/e1000/e1000_80003es2lan.h

[PATCH 16/19] e1000: add new chipset-specific files and api files to the Makefile

2007-03-29 Thread Auke Kok
From: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/Makefile | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/Makefile b/drivers/net/e1000

[PATCH 11/19] e1000: Add 82540 specific hardware code.

2007-03-29 Thread Auke Kok
From: Jeb Cramer [EMAIL PROTECTED] Adapter-specific code for the 82540. Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_82540.c | 670 +++ 1 files changed, 670 insertions(+), 0 deletions

[PATCH 13/19] e1000: Add 82571 specific hardware code.

2007-03-29 Thread Auke Kok
From: Jeb Cramer [EMAIL PROTECTED] Adapter-specific code for the 82571. Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_82571.c | 1333 +++ drivers/net/e1000/e1000_82571.h | 42 + 2 files

[PATCH 12/19] e1000: Add 82541 specific hardware code.

2007-03-29 Thread Auke Kok
From: Jeb Cramer [EMAIL PROTECTED] Adapter-specific code for the 82541. Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_82541.c | 1305 +++ drivers/net/e1000/e1000_82541.h | 86 +++ 2 files

[PATCH 19/19] e1000: major part of the new API changes

2007-03-29 Thread Auke Kok
-device specific initialization. Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_ethtool.c | 97 ++- drivers/net/e1000/e1000_main.c| 155 - 2 files changed, 160 insertions

[-MM GIT PULL] e1000: fixes, API rewrite, cleanups

2007-03-29 Thread Auke Kok
/~sofar/patches-20070327/ Cheers, Auke --- commit a6f63e313c5a26340f52884c52492668a555c38b Author: Auke Kok [EMAIL PROTECTED] Date: Thu Mar 29 14:59:38 2007 -0700 e1000: Update version, typo fixes, date Signed-off-by: Auke Kok [EMAIL PROTECTED] :100644 100644 18a6e4b... 3fc332a... M

[PATCH 3/3] e1000: list e1000-devel mailing list in MAINTAINERS

2007-03-06 Thread Auke Kok
From: Auke Kok [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- MAINTAINERS |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1dfba85..51efc71 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1797,6 +1797,7 @@ P:Jeff

[PATCH 1/3] e1000: Use ARRAY_SIZE macro when appropriate

2007-03-06 Thread Auke Kok
From: Ahmed S. Darwish [EMAIL PROTECTED] A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_ethtool.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH 2/3] e1000: Use kcalloc()

2007-03-06 Thread Auke Kok
From: Yan Burman [EMAIL PROTECTED] Replace kmalloc+memsetout the driver. Slightly modified by Auke Kok. Signed-off-by: Yan Burman [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_ethtool.c | 26 -- drivers/net/e1000/e1000_main.c

[PATCH] ixgb: Use ARRAY_SIZE macro when appropriate.

2007-03-06 Thread Auke Kok
From: Ahmed S. Darwish [EMAIL PROTECTED] Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/ixgb/ixgb_param.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgb/ixgb_param.c b/drivers/net/ixgb

[PATCH 1/3] e1000: FIX: be ready for incoming irq at pci_request_irq

2007-03-06 Thread Auke Kok
From: Auke Kok [EMAIL PROTECTED] DEBUG_SHIRQ code exposed that e1000 was not ready for incoming interrupts after having called pci_request_irq. This obviously requires us to finish our software setup which assigns the irq handler before we request the irq. Signed-off-by: Auke Kok [EMAIL

[PATCH 3/3] e1000: FIX: Stop raw interrupts disabled nag from RT

2007-03-06 Thread Auke Kok
-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 3492f0b..7bbefca 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/drivers/net/e1000

[PATCH 2/3] e1000: FIX: firmware handover bits

2007-03-06 Thread Auke Kok
From: Bruce Allan [EMAIL PROTECTED] Upon code inspection it was spotted that the firmware handover bit get/set mismatched, which may have resulted in management issues on PCI-E adapters. Setting them correctly may fix some management issues such as arp routing etc. Signed-off-by: Auke Kok [EMAIL

Re: watchdog timeout panic in e1000 driver

2007-02-20 Thread Auke Kok
Kenzo Iwami wrote: Hi, I created a patch that uses watchdog_task but fixes the race condition that occurred in old the e1000 driver. I've obtained information about the panic caused by the old e1000 driver using e1000_watchdog_task. According to the crash dump, the panic was caused by a

Re: [PATCH 0/3] remove irq_sem cruft from e1000 and derivatives

2007-02-19 Thread Auke Kok
Chris Snook wrote: Hey folks -- While digging through the atl1 source, I was troubled by the code using irq_sem. I did some digging and found the same code in e1000 and ixgb. I'm not entirely sure what it was originally intended to do, but it doesn't seem to be doing anything useful now,

Re: [PATCH 1/3] e1000: fix shared interrupt warning message

2007-02-17 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) applied 1-3

Re: [PATCH 1/3] e1000: fix shared interrupt warning message

2007-02-17 Thread Auke Kok
Francois Romieu wrote: Auke Kok [EMAIL PROTECTED] : [...] It is suspected that workarounds in the _up() routine of e1000 can cause ^ the receive unit to be enabled before we're all done initializing the adapter data. An interrupt arriving before we're all done setting up

Re: [patch 01/11] user of the jiffies rounding code: Networking

2007-02-06 Thread Auke Kok
driver change, Jeff please suck that in, thanks. Jeff, And add my: Acked-by: Auke Kok [EMAIL PROTECTED] Thanks Auke Arjan, btw: + if (dst_gc_timer_expires 4*HZ) + mod_timer(dst_gc_timer, + round_jiffies(jiffies + dst_gc_timer_expires

Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Auke Kok
Ahmed S. Darwish wrote: On Mon, Feb 05, 2007 at 12:31:26PM -0800, Auke Kok wrote: Alexey Dobriyan wrote: On Mon, Feb 05, 2007 at 06:59:33PM +0200, Ahmed S. Darwish wrote: A patch to use ARRAY_SIZE macro already defined in kernel.h. Remove it and use ARRAY_SIZE instead. --- a/drivers/net

Re: [PATCH 2.6.20] e1000: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Auke Kok
Ahmed S. Darwish wrote: Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] Acked-by: Auke Kok [EMAIL PROTECTED] Cheers, Auke --- Patch is compile tested. diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000

Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Auke Kok
Alexey Dobriyan wrote: On Mon, Feb 05, 2007 at 06:59:33PM +0200, Ahmed S. Darwish wrote: A patch to use ARRAY_SIZE macro already defined in kernel.h. Remove it and use ARRAY_SIZE instead. --- a/drivers/net/ixgb/ixgb_param.c +++ b/drivers/net/ixgb/ixgb_param.c @@ -245,7 +245,7 @@

Re: 2.6.20-rc7: known regressions (v2) (part 1)

2007-02-03 Thread Auke Kok
Adam Kropelin wrote: Eric W. Biederman wrote: Auke Kok [EMAIL PROTECTED] writes: None of the MSI code in e1000 has changed significantly either. as far as I can see, the msi code in e1000 has not changed since 2.6.18. Nonetheless there's no way I can debug any of this without a system

Re: 2.6.20-rc7: known regressions (v2) (part 1)

2007-02-03 Thread Auke Kok
Adam Kropelin wrote: Auke Kok wrote: Adam Kropelin wrote: I've never had this device work 100% with MSI on any kernel version I've tested so far. But I'm not the original reporter of the problem, and I believe for him it was a true regression where a previous kernel wored correctly. maybe

Re: 2.6.20-rc7: known regressions (v2) (part 1)

2007-02-02 Thread Auke Kok
: Allen Parker [EMAIL PROTECTED] Adam Kropelin [EMAIL PROTECTED] Handled-By : Auke Kok [EMAIL PROTECTED] Status : problem is being debugged I probably can't fix this bug. Not only do I doubt that the e1000 driver is at fault here, I don't have a system with this particular

[PATCH -FIX] e100: fix irq leak on suspend/resume

2007-01-29 Thread Auke Kok
e100: fix irq leak on suspend/resume From: Frederik Deweerdt [EMAIL PROTECTED] The e100_resume() function should be calling netif_device_detach and free_irq. This fixes multiple irq's being allocated after resume. Signed-off-by: Frederik Deweerdt [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL

[PATCH -MM]: updated e1000 - new hardware initialization code (replacement patch)

2007-01-27 Thread Auke Kok
-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/Makefile| 19 drivers/net/e1000/e1000.h | 97 drivers/net/e1000/e1000_80003es2lan.c | 1377 + drivers/net/e1000/e1000_80003es2lan.h | 89 drivers/net/e1000/e1000_82540.c | 670 ++ drivers/net/e1000

Re: Nvidia MCP55 Machine reboots on ixgb driver load

2007-01-24 Thread Auke Kok
[added netdev to CC] Roger Heflin wrote: I have a machine (actually 2 machines) that upon loading the intel 10GBe driver (ixgb) the machine reboots, I am using a RHAS4.4 based distribution with Vanilla 2.6.19.2 (the RHAS 4.4.03 kernel also reboots with the ixgb load), I don't see any messages

Re: [git patches] net driver fixes

2007-01-22 Thread Auke Kok
Jeff Garzik wrote: Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus Jeff, is there a reason that you didn't pull the e1000 tree from us? I send you all the information 5 days ago, WITH the changes that you

Re: [git patches] net driver fixes

2007-01-22 Thread Auke Kok
Jeff Garzik wrote: Auke Kok wrote: Jeff Garzik wrote: Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus Jeff, is there a reason that you didn't pull the e1000 tree from us? I send you all the information 5 days

Re: [BUG] e100: eth0 appers many times in /proc/interrupts after resume

2007-01-22 Thread Auke Kok
Frederik Deweerdt wrote: On Sun, Jan 21, 2007 at 01:45:27PM -0800, Auke Kok wrote: Frederik Deweerdt wrote: On Sun, Jan 21, 2007 at 09:17:41PM +0200, Andrei Popa wrote: It's the 10th resume and in /proc/interrupts eth0 appers 10 times. The e100_resume() function should be calling

Re: [BUG] e100: eth0 appers many times in /proc/interrupts after resume

2007-01-21 Thread Auke Kok
Frederik Deweerdt wrote: On Sun, Jan 21, 2007 at 09:17:41PM +0200, Andrei Popa wrote: It's the 10th resume and in /proc/interrupts eth0 appers 10 times. The e100_resume() function should be calling netif_device_detach and free_irq. Could you try the following (compile tested) patch? I just

e1000: update device ID table for register dumps

2007-01-19 Thread Auke Kok
e1000: update device ID table for register dumps with new devices From: Auke Kok [EMAIL PROTECTED] The register dump routine of e1000 was missing several newer chipsets. I reimported the mac detection code from the linux e1000 driver. This fixes newer NIC's reporting that their bus type is PCI

Re: e1000: update device ID table for register dumps [Is an *ethtool* patch]

2007-01-19 Thread Auke Kok
Auke Kok wrote: e1000: update device ID table for register dumps with new devices From: Auke Kok [EMAIL PROTECTED] The register dump routine of e1000 was missing several newer chipsets. I reimported the mac detection code from the linux e1000 driver. This fixes newer NIC's reporting

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-19 Thread Auke Kok
Adam Kropelin wrote: Auke Kok wrote: Adam Kropelin wrote: I am experiencing the no-link issue on a 82572EI single port copper PCI-E card. I've only tried 2.6.20-rc5, so I cannot tell if this is a regression or not yet. Will test older kernel soon. Can provide details/logs if you want 'em

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-19 Thread Auke Kok
Adam Kropelin wrote: Auke Kok wrote: Adam Kropelin wrote: I haven't been able to test rc5-mm yet because it won't boot on this box. Applying git-e1000 directly to -rc4 or -rc5 results in a number of rejects that I'm not sure how to fix. Some are obvious, but the others I'm unsure

Re: [PATCH 0/8] partial resend: e1000 fixes and updates

2007-01-18 Thread Auke Kok
Jeff Garzik wrote: Kok, Auke wrote: Hi, This patch series contains exclusively fixes for e1000. Some of these patches were already sent in december, but didn't make it into any usptream tree yet. Most importantly, it addresses two issues in the recently merged msi interrupt handler and

Re: [BUG] 2.6.20-rc4-mm1: Panic in e1000_write_vfta_82543()

2007-01-18 Thread Auke Kok
Sukadev Bhattiprolu wrote: I get following panic on 2.6.20-rc4-mm1 on a 2-cpu AMD Opteron system. Same basic config file seems to work with 2.6.20-rc2-mm1 on this same system. Have not tried -rc3-mm1 yet. Attached are config file and lspci -vv output. Let me know if you need more info. Suka

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-17 Thread Auke Kok
Adam Kropelin wrote: Allen Parker wrote: Allen Parker wrote: From what I've been able to gather, other Intel Pro/1000 chipsets work fine in 2.6.20-rc5. If the e1000 guys need any assistance testing, I'll be more than happy to volunteer myself as a guinea pig for patches. I wasn't aware that

Re: intel 82571EB gigabit fails to see link on 2.6.20-rc5 in-tree e1000 driver (regression)

2007-01-16 Thread Auke Kok
Allen Parker wrote: Allen Parker wrote: I have a PCI-E pro/1000 MT Quad Port adapter, which works quite well under 2.6.19.2 but fails to see link under 2.6.20-rc5. Earlier today I reported this to [EMAIL PROTECTED], but thought I should get the word out in case someone else is testing this

[PATCH -MM] e1000: update new hardware init layer code with bugfixes

2007-01-16 Thread Auke Kok
-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_80003es2lan.c | 90 - drivers/net/e1000/e1000_82540.c | 86

Re: watchdog timeout panic in e1000 driver

2007-01-15 Thread Auke Kok
know if this also fixes the problem for you. I will most likely push this patch to the netdev tree in any case. Cheers, Auke --- From: Auke Kok [EMAIL PROTECTED] e1000: Don't do PHY reads in watchdog unless link status is down The watchdog runs code that every 2 seconds performs several PHY

Re: Two Dual Core processors and NICS (not handling interrupts on one CPU/assigning a Two Dual Core processors and NICS (not handling interrupts on one CPU / assigning a CPU to a NIC)

2007-01-15 Thread Auke Kok
Mark Ryden wrote: Hello, I have a machine with 2 dual core CPUs. This machine runs Fedora Core 6. I have two Intel e1000 GigaBit network cards on this machine; I use bonding so that the machine assigns the same IP address to both NICs ; It seems to me that bonding is configured OK, bacuse

Re: e100.c patch to 2.6.18 fixing Wake on Lan (WOL)

2007-01-15 Thread Auke Kok
Harry Coin wrote: Hello from Iowa. Below please find a fix to the Wake On Lan function in the e100.c (intel 10/100) driver. With the original driver distributed in kernel 2.6.18 in debian etch, wake on lan did not work. This was tested on 14 dell optiplexes with built-in ethernet chips

Re: e100.c patch to 2.6.18 fixing Wake on Lan (WOL)

2007-01-15 Thread Auke Kok
Harry Coin wrote: At 10:19 AM 1/15/2007 -0800, Auke Kok wrote: Have you tried the version in 2.6.19? I even tried copying and pasting the e100_down and the latest PM stuff from the newest e100.c version on sourceforge. I admit to being defeated as to how to join a sourceforge group. Too

[PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
quad port adapter (device 0x10a5). MTU changes on a downed interface require a phy commit to enact the new size immediately. Signed-off-by: Jeb Cramer [EMAIL PROTECTED] Signed-off-by: Jeff Kirsher [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/Makefile

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Stephen Hemminger wrote: On Tue, 09 Jan 2007 09:36:29 -0800 Auke Kok [EMAIL PROTECTED] wrote: Andrew, All, This patch contains a major rewrite to the e1000 driver that groups and separates e1000 hardware by chipset family. It abstracts the hardware specific code into an API that will allow

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Andrew Morton wrote: On Tue, 09 Jan 2007 09:36:29 -0800 Auke Kok [EMAIL PROTECTED] wrote: git-pull git://lost.foo-projects.org/~ahkok/git/linux-2.6 e1000 That tree appears to be based on the -mm git tree? That's a somewhat unusual thing to do - a tree which is based on current Linus

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Randy Dunlap wrote: On Tue, 09 Jan 2007 20:16:27 +0100 Krzysztof Halasa wrote: Auke Kok [EMAIL PROTECTED] writes: drivers/net/e1000/Makefile| 19 drivers/net/e1000/e1000.h | 95 drivers/net/e1000/e1000_80003es2lan.c | 1330 + drivers/net/e1000

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Andrew Morton wrote: On Tue, 09 Jan 2007 09:36:29 -0800 Auke Kok [EMAIL PROTECTED] wrote: git-pull git://lost.foo-projects.org/~ahkok/git/linux-2.6 e1000 That tree appears to be based on the -mm git tree? That's a somewhat unusual thing to do - a tree which is based on current Linus

[PATCH RESEND] 3 ixgb fixes, please pull

2007-01-06 Thread Auke Kok
insertions(+), 7 deletions(-) --- Auke Kok [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH 2.6.19] e100: replace kmalloc with kcalloc

2006-12-12 Thread Auke Kok
Yan Burman wrote: Replace kmalloc+memset with kcalloc ACK, fine with me. Signed-off-by: Yan Burman [EMAIL PROTECTED] diff -rubp linux-2.6.19-rc5_orig/drivers/net/e100.c linux-2.6.19-rc5_kzalloc/drivers/net/e100.c --- linux-2.6.19-rc5_orig/drivers/net/e100.c2006-11-09 12:16:21.0

2.6.19-rc6-mm2: Network device naming starts at 1 instead of 0

2006-12-05 Thread Auke Kok
[resend] Quick note: I loaded up 2.6.19-rc6-mm2 on a platform here and noticed that the onboard e1000 NIC was enumerated to eth1 instead of eth0. on 2.6.18.5 and any other kernel I used before, it was properly named eth0 after startup. eth0 itself is completely missing (-ENODEV). I'll try to

Re: watchdog timeout panic in e1000 driver

2006-12-04 Thread Auke Kok
Kenzo Iwami wrote: Hi, Doesn't this just mean that we need a spinlock or some other kind of semaphore around acquiring, using, and releasing this resource? We keep going around and around about this but I'm pretty sure spinlocks are meant to be able to solve exactly this issue. The problem

Re: e100: inappropriate handling of shared interrupt ?

2006-11-27 Thread Auke Kok
Shaw Vrana wrote: Hello All, I'm seeing some odd behavior using the e100 driver for an intel ethernet controller 82557/8/9 (revv 10). It appears as if the e100 driver is handling interrupts generated by another device, though I am not certain of this.. Using some printks, I see some odd

Re: [PATCH-2.4] e100: incorrect use of instead of

2006-11-27 Thread Auke Kok
Willy Tarreau wrote: Hi Auke, On Mon, Nov 27, 2006 at 09:31:34AM -0800, Auke Kok wrote: Willy Tarreau wrote: Hi guys, I'm about to apply this fix to 2.4. 2.6 is not affected. Do you have any objection ? Willy, you didn't CC netdev. linux-net is a users list, you didn't CC the maintainers

Re: watchdog timeout panic in e1000 driver

2006-11-15 Thread Auke Kok
, Auke Signed-off-by: Auke Kok [EMAIL PROTECTED] diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index a2f1464..0b52ded 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/drivers/net/e1000/e1000_main.c @@ -2430,8 +2430,12 @@ e1000_watchdog(unsigned long data) struct

Re: Intel 82559 NIC corrupted EEPROM

2006-11-09 Thread Auke Kok
John wrote: Auke Kok wrote: This is what I was afraid of: even though the code allows you to bypass the EEPROM checksum, the probe fails on a further check to see if the MAC address is valid. Since something with this NIC specifically made the EEPROM return all 0xff's, the MAC address

Re: Intel 82559 NIC corrupted EEPROM

2006-11-08 Thread Auke Kok
John wrote: I have a motherboard with three on-board 82559 NICs. o eepro100.ko properly initializes all three NICs o e100.ko fails to initialize one of them NOTE: With kernel 2.6.14, e100.ko fails to initialize the NIC with MAC address 00:30:64:04:E6:E4. With kernel 2.6.18 e100.ko fails to

e1000: include net/ip6_checksum.h for IA64

2006-11-08 Thread Auke Kok
/ip6_checksum.h for IA64 IA64 does not have an optimized asm version for ipv6 csum magic. Fall back to generic implementation. Signed-off-by: Auke Kok [EMAIL PROTECTED] diff --git a/drivers/net/e1000/e1000.h b/drivers/net/e1000/e1000.h index f091042..26e7506 100644 --- a/drivers/net/e1000/e1000.h

Re: e1000: include net/ip6_checksum.h for IA64

2006-11-08 Thread Auke Kok
Chen, Kenneth W wrote: Chen, Kenneth wrote on Wednesday, November 08, 2006 4:10 PM Auke Kok wrote on Wednesday, November 08, 2006 9:49 AM Of course, someone really should come up with an asm version for ia64 of the missing function ;) Sure, absolutely. Here is an implementation for ia64

Re: [PATCH] Rewrite e100_phys_id

2006-11-07 Thread Auke Kok
Matthew Wilcox wrote: The motivator for this was to fix the sparse warning: drivers/net/e100.c:2418:48: warning: cast truncates bits from constant value (83126e978d4fdf becomes 978d4fdf) drivers/net/e100.c:2419:37: warning: cast truncates bits from constant value (83126e978d4fdf becomes

Re: [PATCH] Rewrite e100_phys_id

2006-11-07 Thread Auke Kok
Matthew Wilcox wrote: On Tue, Nov 07, 2006 at 10:33:14AM -0800, Auke Kok wrote: Matthew Wilcox wrote: Tested on the internal interface of an HP Integrity rx2600. bad news, it's completely hosed. The adapter does some indistinguishable blinking for a second, then stops blinking alltogether

Re: [PATCH 00/18] e1000: features, updates, documentation

2006-11-06 Thread Auke Kok
Jeff Garzik wrote: pulled. still waiting on those changes to better modularize the feature detection, etc. that will start coming in early januari I think. We're currently validating all silicon that the code supports against the old and new code, and that is going to take quite some time

Re: Wake On Lan device semantics

2006-11-03 Thread Auke Kok
Stephen Hemminger wrote: It doesn't seem like a good idea for a network device to wake the system if it is down. before suspend existed this was the only useful case for WoL. Why does it not seem a good idea to wake up a machine that was shutdown (and thus the interface `downed`) ? Auke -

Re: Wake On Lan device semantics

2006-11-03 Thread Auke Kok
Stephen Hemminger wrote: On Fri, 03 Nov 2006 15:44:13 -0800 Auke Kok [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: It doesn't seem like a good idea for a network device to wake the system if it is down. before suspend existed this was the only useful case for WoL. Why does it not seem

<    1   2   3   4   >