[PATCH net-next v3 2/2] net sched actions: add time filter for action dumping

From: Jamal Hadi Salim <j...@mojatatu.com> This adds support for filtering based on time since last used. When we are dumping a large number of actions it is useful to have the option of filtering based on when the action was last used to reduce the amount of data crossing to user

Re: [PATCH v2 net 2/2] net sched actions: decrement module refcount earlier

On 17-04-19 04:09 AM, Wolfgang Bumiller wrote: diff --git a/net/sched/act_api.c b/net/sched/act_api.c index 8cc883c063f0..c7e5e437b847 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -555,6 +555,7 @@ struct tc_action *tcf_action_init_1(struct net *net, struct nlattr *nla,

Re: [PATCH net-next 1/2] Add Cong Wang as TC subsystem co-maintainer

On 17-04-19 02:01 AM, Cong Wang wrote: On Tue, Apr 18, 2017 at 6:23 PM, Jamal Hadi Salim <j...@mojatatu.com> wrote: From: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com> I am happy and honored to review net sched patches, Than

Re: [PATCH net-next 1/2 v2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

On 17-04-18 11:17 PM, Eric Dumazet wrote: On Tue, 2017-04-18 at 22:32 -0400, Jamal Hadi Salim wrote: On 17-04-18 09:49 PM, Eric Dumazet wrote: On Tue, 2017-04-18 at 21:14 -0400, Jamal Hadi Salim wrote: Make sense? What if we have 1024 actions, and user provides a 4KB buffer

Re: [PATCH net-next 1/2 v2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

On 17-04-19 02:12 AM, Cong Wang wrote: On Tue, Apr 18, 2017 at 7:32 PM, Jamal Hadi Salim <j...@mojatatu.com> wrote: On 17-04-18 09:49 PM, Eric Dumazet wrote: With this change I ask the kernel to fit as many actions as possible in the 32K (all these 128 will fit in one batch). Then

Re: [PATCH net-next 1/2 v2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

On 17-04-19 12:55 AM, Roopa Prabhu wrote: On 4/18/17, 6:14 PM, Jamal Hadi Salim wrote: A new top level TLV space is introduced. An attribute TCAA_ACT_FLAGS is used to carry the flags indicating the user is capable of processing these large dumps. Older user space which doesnt set this flag

Re: [PATCH net-next 1/1] net sched actions: add time filter for action dumping

On 17-04-18 11:55 PM, Jakub Kicinski wrote: On Tue, 18 Apr 2017 21:37:12 -0400, Jamal Hadi Salim wrote: On 17-04-18 06:12 PM, Jakub Kicinski wrote: [..] I see both being fine from that perspective - you dont need 100% accuracy. Just something that is within reason of a small delta of time

Re: [PATCH net-next 1/2 v2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

On 17-04-18 09:49 PM, Eric Dumazet wrote: On Tue, 2017-04-18 at 21:14 -0400, Jamal Hadi Salim wrote: From: Jamal Hadi Salim <j...@mojatatu.com> So there is no more limit ? How user is supposed to size the buffer for recvmsg() ? That part doesnt change. Ok, I believe more clarity is

Re: [PATCH v2 net 2/2] net sched actions: decrement module refcount earlier

On 17-04-18 01:03 PM, Cong Wang wrote: On Tue, Apr 18, 2017 at 3:13 AM, Wolfgang Bumiller wrote: police action...That is why I said we may need a TCA_POLICE_COOKIE. Unless it is very old user space code (which wouldnt know what a cookie is), dont think there's much

Re: [PATCH net-next 2/2 v2] net sched actions: add time filter for action dumping

On 17-04-18 09:35 PM, Eric Dumazet wrote: On Tue, 2017-04-18 at 21:14 -0400, Jamal Hadi Salim wrote: From: Jamal Hadi Salim <j...@mojatatu.com> + if (tcaa[TCAA_ACT_TIME_FILTER]) + msecs_filter = nla_get_u32(tcaa[TCAA_ACT_TIME_FILTER]); You forgot

Re: [PATCH net-next 1/1] net sched actions: add time filter for action dumping

On 17-04-18 06:12 PM, Jakub Kicinski wrote: Noob question - would it be an option to establish some form of streaming statistic updates out of the kernel? It would be more efficient, certainly. Current polling approach is not as bad though (you send one extra kernel message) and is more

[PATCH net-next 2/2] Add Jiri Pirko as TC subsystem co-maintainer

From: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 749bd84..a9df81e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12190,6 +12190,7 @@ F:

[PATCH net-next 1/2] Add Cong Wang as TC subsystem co-maintainer

From: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1973878..749bd84 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12189,6 +12189,7 @@ F:

[PATCH net-next 2/2 v2] net sched actions: add time filter for action dumping

From: Jamal Hadi Salim <j...@mojatatu.com> This adds support for filtering based on time since last used. When we are dumping a large number of actions it is useful to have the option of filtering based on when the action was last used to reduce the amount of data crossing to user

[PATCH net-next 1/2 v2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

From: Jamal Hadi Salim <j...@mojatatu.com> When you dump hundreds of thousands of actions, getting only 32 per dump batch even when the socket buffer and memory allocations allow is inefficient. With this change, the user will get as many as possibly fitting within the given const

Re: [PATCH net-next 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

Please ignore - I will resend. This is corrupt. Sorry - I will label the next one as v2 even though it is v3. cheers, jamal On 17-04-18 09:08 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim <j...@mojatatu.com> When you dump hundreds of thousands of actions, getting only 32 per dump

[PATCH net-next 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

From: Jamal Hadi Salim <j...@mojatatu.com> When you dump hundreds of thousands of actions, getting only 32 per dump batch even when the socket buffer and memory allocations allow is inefficient. With this change, the user will get as many as possibly fitting within the given const

[PATCH net-next 2/2] net sched actions: add time filter for action dumping

From: Jamal Hadi Salim <j...@mojatatu.com> This adds support for filtering based on time since last used. When we are dumping a large number of actions it is useful to have the option of filtering based on when the action was last used to reduce the amount of data crossing to user

Re: [PATCH v2 net 2/2] net sched actions: decrement module refcount earlier

com> Cc: Jamal Hadi Salim <j...@mojatatu.com> --- I did not include the Acked-bys here because I've noticed that this is still wrong. After reading a bit more and doing more tests with different filters I realized that the `name != NULL` case is specific to the police filter only. F

Re: [PATCH v2 net 1/2] net sched actions: fix access to uninitialized data

On 17-04-18 06:13 AM, Wolfgang Bumiller wrote: Signed-off-by: Wolfgang Bumiller <w.bumil...@proxmox.com> Acked-by: Cong Wang <xiyou.wangc...@gmail.com> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> --- (same as v1) net/sched/act_api.c | 2 +- 1 file changed, 1 insert

Re: [Patch net-next v3] net_sched: move the empty tp check from ->destroy() to ->delete()

Reported-by: Roi Dayan <r...@mellanox.com> Cc: Daniel Borkmann <dan...@iogearbox.net> Cc: John Fastabend <john.fastab...@gmail.com> Cc: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> Looks good to me, Daniel? Also - if

Case for reusing netlink PADs WAS(Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

On 17-04-17 01:08 PM, Eric Dumazet wrote: On Mon, 2017-04-17 at 12:46 -0400, Jamal Hadi Salim wrote: Of course it is trivial to add this as attributes and 32 bits for this case is not a big deal because it is done once. I want to talk about the pads instead ;-> What do you suggest we

Re: [patch net-next] MAINTAINERS: rename TC entry and add couple of header files

On 17-04-13 12:13 PM, Jiri Pirko wrote: From: Jiri Pirko <j...@mellanox.com> The section is not specific only to "TC classifiers", but applies to the whole TC subsystem. Also, add couple of forgotten headers. Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-b

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

On 17-04-17 11:31 AM, Jiri Pirko wrote: Mon, Apr 17, 2017 at 03:10:59PM CEST, eric.duma...@gmail.com wrote: On Mon, 2017-04-17 at 07:01 -0400, Jamal Hadi Salim wrote: Agreed. Plus the argument that attributes are "a big waste" sounds to me really silly. What is couple of bytes

Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

On 17-04-17 10:59 AM, David Miller wrote: Jamal please review this. Waiting for Wolfgang to submit a new patch. cheers, jamal

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

On 17-04-17 10:58 AM, Eric Dumazet wrote: [..] Very often, pads are there because of ABI constraints. We 'name' them to make clear to developers that they are there, and avoid security issues, because of say few bytes from kernel stack are copied to user space. struct foo { __u32 a; __u16

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

On 17-04-17 09:10 AM, Eric Dumazet wrote: [..] We can not assume user programs properly cleared the paddings anyway. Using them for 'new features' is risky, since it might break programs. So the safe way is using new attributes really. Since we agreed to have longer discussions on uapis

Re: [PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

On 17-04-17 04:19 AM, Jiri Pirko wrote: Sun, Apr 16, 2017 at 02:34:30PM CEST, j...@mojatatu.com wrote: From: Jamal Hadi Salim <j...@mojatatu.com> When you dump hundreds of thousands of actions, getting only 32 per dump batch even when the socket buffer and memory allocations

Re: second wave of netlink extended ACK reporting

On 17-04-16 10:45 AM, David Ahern wrote: On 4/16/17 8:40 AM, Jamal Hadi Salim wrote: Johannes or anybody else working on it? i.e one which sends the extack to the bowels of callees so we can return meaningful messages example: rtnetlink::doit() or equivalent seems to be a candidate for taking

second wave of netlink extended ACK reporting

Johannes or anybody else working on it? i.e one which sends the extack to the bowels of callees so we can return meaningful messages example: rtnetlink::doit() or equivalent seems to be a candidate for taking it as a param For things that call netlink_ack it may be easier if they create the

Re: [PATCH linux 2/2] net sched actions: fix refcount decrement on error

Wolfgang, can you _please_ stop cc-ing lkml? Everybody you need to deal with is on netdev. On 17-04-15 02:48 PM, Wolfgang Bumiller wrote: So I'm not sure exactly how the module and tc_action counts are related (and I usually like to understand my own patches ;-) ). Every time we add

Re: [PATCH net-next 1/1] net sched actions: add time filter for action dumping

I should say this is dependent on the earlier patch I posted. Made them separate because I think this one in particular may generate some discussions. cheers, jamal On 17-04-16 09:56 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim <j...@mojatatu.com> This adds support for filtering

[PATCH net-next 1/1] net sched actions: add time filter for action dumping

From: Jamal Hadi Salim <j...@mojatatu.com> This adds support for filtering based on time since last used. When we are dumping a large number of actions it is useful to have the option of filtering based on when the action was last used to reduce the amount of data crossing to user

Re: [RFC patch 1/1] large netlink dumps

On 17-04-15 11:08 PM, Eric Dumazet wrote: On Sat, 2017-04-15 at 13:07 -0400, Jamal Hadi Salim wrote: Eric, How does attached look instead of the 32K? I found it helps to let user space suggest something larger. cheers, jamal Looks dangerous to me, for various reasons. 1) Memory allocations

[PATCH net-next 1/1] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

From: Jamal Hadi Salim <j...@mojatatu.com> When you dump hundreds of thousands of actions, getting only 32 per dump batch even when the socket buffer and memory allocations allow is inefficient. With this change, the user will get as many as possibly fitting within the given constraint

[RFC patch 1/1] large netlink dumps

Eric, How does attached look instead of the 32K? I found it helps to let user space suggest something larger. cheers, jamal diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 7b73c7c..bc982ef 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -1849,7

Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

On 17-04-15 10:12 AM, Jamal Hadi Salim wrote: On 17-04-12 09:22 PM, Cong Wang wrote: Sorry - didnt get the full thread (the OP managed to post to CC linux kernel list but not me); trying to catch up. So the issue if i understood: Policer was created but failed and we the error code

Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

On 17-04-12 09:22 PM, Cong Wang wrote: On Wed, Apr 12, 2017 at 7:21 AM, Wolfgang Bumiller wrote: Commit 1045ba77a ("net sched actions: Add support for user cookies") added code to net/sched/act_api.c's tcf_action_init_1 using the `tb` nlattr array unconditionally, while

Wrong subject line: IS Keynote by Jesse Brandeburg WAS ( Keynote by Shrijeet Mukherjee

Apologies. Need coffee ... Corrected in previous email. cheers, jamal On 17-04-06 06:12 AM, Jamal Hadi Salim wrote: The tech committee is pleased to announce a keynote by Jesse Brandeburg titled "Linux and the Network" In this talk Jesse will cover topics such as, a bri

[Netdev conf Announce]: Keynote by Jesse Brandeburg

The tech committee is pleased to announce a keynote by Jesse Brandeburg titled "Linux and the Network" In this talk Jesse will cover topics such as, a brief history of the network in Linux, Intel’s expectations of the number of devices on the internet causing a dramatic expansion in the number

[Netdev conf Announce]: Keynote by Shrijeet Mukherjee

The tech committee is pleased to announce a keynote by Jesse Brandeburg titled "Linux and the Network" In this talk Jesse will cover topics such as, a brief history of the network in Linux, Intel’s expectations of the number of devices on the internet causing a dramatic expansion in the number

[Netdev conf Announce]: Keynote by Shrijeet Mukherjee

The tech committee is pleased to announce a keynote by Shrijeet Mukherjee titled "Journey into Enterprise Networking with Linux" Shrijeet wants to make Linux networking appealing to the Enterprise users and have it appear in the core of their critical networks. Come one, come all cheers,

[Netdev conf Announce]: Keynote by David Miller

The tech committee is pleased to announce David Miller, Netdev Maintainer. David's keynote is titled "XDP Mythbusters". Come one, come all. David will sift out the fake from real news. cheers, jamal

ANNOUNCE: netdev 2.1 conference Schedule out!

The tech committee would like to announce the schedule. There is a lot of great great content which we hope you are going to enjoy. There were also many other fantastic submissions which we were unfortunately unable to accommodate. We appreciate everyone that took the time to make a

[PATCH iproute2 v3 1/1] actions: Add support for user cookies

From: Jamal Hadi Salim <j...@mojatatu.com> Make use of 128b user cookies Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when ret

Re: [PATCH iproute2 v2 1/1] actions: Add support for user cookies

Ignore - i resent the same version again ;-> Resending .. cheers, jamal On 17-03-21 05:58 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim <j...@mojatatu.com> Make use of 128b user cookies Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking

[PATCH iproute2 v2 1/1] actions: Add support for user cookies

From: Jamal Hadi Salim <j...@mojatatu.com> Make use of 128b user cookies Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when ret

[PATCH iproute2 1/1] actions: Add support for user cookies

From: Jamal Hadi Salim <j...@mojatatu.com> Make use of 128b user cookies Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when ret

ANNOUNCE: New Platinum sponsor - Facebook

The organizing committee would like to welcome back a repeat platinum sponsor, Facebook! Facebook has been a great supporter of the netdev community, we thank them! cheers, jamal

ANNOUNCE: Netdev Conference: What you have been missing

As announced last time, we are making more frequent announcements on peo...@netdevconf.org You can subscribe via mailman here: https://lists.netdevconf.org/cgi-bin/mailman/listinfo/people We urge people to subscribe to that list to get more up to date information and conference discussions. We

ANNOUNCE: Verizon Labs New Platinum Sponsor

The organizing committee is happy to announce Verizon Labs as our second Platinum sponsor. Verizon Labs has been a solid supporter of the netdev community from the very first conference. We appreciate you! cheers, jamal

Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

On 17-03-04 07:01 PM, Alexey Khoroshilov wrote: Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> cheers, jamal

Re: net/sched: act_skbmod: rcu_read_unlock in tcf_skbmod_dump?

On 17-03-04 03:49 PM, Alexey Khoroshilov wrote: Hello! rcu_read_unlock() in tcf_skbmod_dump() looks suspicious to me. It does look suspicious. You want to send a patch or should I? cheers, jamal

ANNOUNCE: Netdev 2.1 update Feb 28

A few announcements: 1) Going forward we are going to be sending more frequent announcements to the conference discussion/announcement list: peo...@netdevconf.org You can subscribe via mailman here: https://lists.netdevconf.org/cgi-bin/mailman/listinfo/people We urge people to subscribe to

ANNOUNCE: Netdev 2.1 update Feb 27

A few announcements: 1) The CFP is now officially closed. Thanks to everyone who submitted. 2) We are extending the early registration to March 5. Register early so we can plan better (and so you can save some $$). https://onlineregistrations.ca/netdev21/ - hotel (If you can get the hotel

ANNOUNCE: Netdev 2.1 CFP extended

The tech committee has graciously extended the CFP to February 27th. Hurry o thee procastinators and submit early to avoid the hazards of last minute traffic. Refer to: https://netdevconf.org/2.1/submit-proposal.html Some reminders, again: -Registration is open. Register early so we can plan

tc workshop at netdev 2.1

I am requesting a slot for a tc workshop in netdev 2.1. I am sure that I am missing people in the to list who deserve to be there - please forward to them. If you have a topic you want to talk about please unicast me and I will add you to the agenda. cheers, jamal

ANNOUNCE: Netdev 2.1 update Feb 20

A few announcements: -Registration is open. Register early so we can plan better. https://onlineregistrations.ca/netdev21/ hotel (If you can get the hotel cheaper online than conference rates please send us email, dont book ): http://www.netdevconf.org/2.1/hotel.html - We are pleased to

Re: ANNOUNCE: Netdev 2.1 update Feb 14

On 17-02-14 08:16 AM, Jamal Hadi Salim wrote: A few announcements: -Registration is open. Register early so we can plan better. https://onlineregistrations.ca/netdev21/ hotel (If you can get the hotel cheaper online than conference rates please send us email, dont book ): http

ANNOUNCE: Netdev 2.1 update Feb 14

A few announcements: -Registration is open. Register early so we can plan better. https://onlineregistrations.ca/netdev21/ hotel (If you can get the hotel cheaper online than conference rates please send us email, dont book ): http://www.netdevconf.org/2.1/hotel.html News: - We are pleased to

[PATCH iproute2 1/2] utils: make hex2mem available to all users

From: Jamal Hadi Salim <h...@mojatatu.com> hex2mem() api is useful for parsing hexstrings which are then packed in a stream of chars. Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com> --- include/utils.h | 1 + ip/ipl2tp.c | 25 - lib/util

Re: [PATCH iproute2 2/2] actions: Add support for user cookies

On 17-02-10 06:18 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim <h...@mojatatu.com> Make use of 128b user cookies Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) th

[PATCH v2 iproute2 2/2] actions: Add support for user cookies

From: Jamal Hadi Salim <j...@mojatatu.com> Make use of 128b user cookies Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when ret

[PATCH v2 iproute2 1/2] utils: make hex2mem available to all users

From: Jamal Hadi Salim <j...@mojatatu.com> hex2mem() api is useful for parsing hexstrings which are then packed in a stream of chars. Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com> --- include/utils.h | 1 + ip/ipl2tp.c | 25 - lib/util

[PATCH iproute2 2/2] actions: Add support for user cookies

From: Jamal Hadi Salim <h...@mojatatu.com> Make use of 128b user cookies Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when ret

Re: [patch net-next 6/6] sched: check negative err value to safe one level of indent

rko <j...@mellanox.com> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> BTW: Another nice cleanup is to separate for better readability/maintainability DEL/GET/NEW into their own functions. GET/DEL are very close but sometimes are slightly different - in the action code they are already

Re: [patch net-next 3/6] sched: push TC filter protocol creation into a separate function

On 17-02-09 08:38 AM, Jiri Pirko wrote: From: Jiri Pirko <j...@mellanox.com> Make the long function tc_ctl_tfilter a little bit shorter and easier to read. Also make the creation of filter proto symmetric to destruction. Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by

Re: [patch net-next 4/6] sched: move err set right before goto errout in tc_ctl_tfilter

On 17-02-09 08:38 AM, Jiri Pirko wrote: From: Jiri Pirko <j...@mellanox.com> This makes the reader to know right away what is the error value. Signed-off-by: Jiri Pirko <j...@mellanox.com> I think you meant "makes it easier to read"? Thats how i see this change. Acke

Re: [patch net-next 2/6] sched: move tcf_proto_destroy and tcf_destroy_chain helpers into cls_api

On 17-02-09 08:38 AM, Jiri Pirko wrote: From: Jiri Pirko <j...@mellanox.com> Creation is done in this file, move destruction to be at the same place. Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> cheers, jamal

Re: [patch net-next 5/6] sched: add missing curly braces in else branch in tc_ctl_tfilter

ays that you can put braces around one line branching? ;-> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> cheers, jamal

Re: [patch net-next 1/6] sched: rename tcf_destroy to tcf_destroy_proto

On 17-02-09 08:38 AM, Jiri Pirko wrote: From: Jiri Pirko <j...@mellanox.com> This function destroys TC filter protocol, not TC filter. So name it accordingly. Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Jamal Hadi Salim <j...@mojatatu.com> cheers, jamal

ANNOUNCE: Netdev 2.1 seeking netdev conferences reporter(s)

Folks, We are seeking for qualified people who love to write to cover the netdev 2.1 conference. The idea is to attend the different sessions and describe what was discussed in a timely manner. We would like to publish the events on a daily basis. Requirements: 1) Passion about netdev 2)

ANNOUNCE: Netdev 2.1 Location and Hotel

Two important announcements 1) We are pleased to announce a location for netdev 2.1: Le Westin Montréal 270 Rue St. Antoine Ouest, Montreal, QC H2Y 0A3, Canada Le Westin will also be the conference hotel. We have a speacial arrangement for all attendees to get speacial rates at the hotel. We

ANNOUNCE: Netdev 2.1 update Feb 06

A few announcements: - We expect to open up registration and announce hotel and location this week. - We are pleased to announce the first netdev 2.1 sponsor! Many thanks to Mellanox who has been a strong supporter of the netdev community. Mellanox is first to cross the netdev2.1 sponsor line

Re: [PATCH 3/3] net/sched: act_ife: Change to use ife module

On 17-02-01 08:30 AM, Yotam Gigi wrote: Use the encode/decode functionality from the ife module instead of using implementation inside the act_ife. Reviewed-by: Jiri Pirko <j...@mellanox.com> Signed-off-by: Yotam Gigi <yot...@mellanox.com> Signed-off-by: Jamal Hadi Salim <j.

Re: [PATCH 2/3] net: Introduce ife encapsulation module

- encodes one tlv entry into the reserved ife header space. - ife_tlv_meta_decode - decodes one tlv entry from the packet - ife_tlv_meta_next - advance to the next tlv Reviewed-by: Jiri Pirko <j...@mellanox.com> Signed-off-by: Yotam Gigi <yot...@mellanox.com> Signed-off-by: Jamal H

Re: [PATCH 1/3] net/sched: act_ife: Unexport ife_tlv_meta_encode

On 17-02-01 08:30 AM, Yotam Gigi wrote: As the function ife_tlv_meta_encode is not used by any other module, unexport it and make it static for the act_ife module. Signed-off-by: Yotam Gigi <yot...@mellanox.com> Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com> cheers, jamal

Re: [PATCH net-next 0/2] Extract IFE logic to module

On 17-02-02 06:12 AM, Yotam Gigi wrote: -Original Message- I have no objection to this modularisation but I am curious to know if you have a use-case in mind. My understanding is that earlier versions of the sample action used IFE but that is not the case in the version that was

ANNOUNCE: Netdev 2.1 update

A few announcements: - We expect to open up registration and announce hotel and location next week. - We are pleased to announce the first netdev 2.1 talk has been accepted by the tech committee! The Call for Proposals is still open, submit early to avoid the hazards of last minute traffic.

[PATCH net-next v7 1/1] net sched actions: Add support for user cookies

From: Jamal Hadi Salim <j...@mojatatu.com> Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved serves as a correlator. The

Re: [PATCH net-next v6 1/1] net sched actions: Add support for user cookies

On 17-01-23 11:18 AM, Daniel Borkmann wrote: On 01/23/2017 01:58 PM, Simon Horman wrote: Hi Jamal, On Sun, Jan 22, 2017 at 03:25:50PM -0500, Jamal Hadi Salim wrote: ... diff --git a/net/sched/act_api.c b/net/sched/act_api.c index cd08df9..58cf1c5 100644 --- a/net/sched/act_api.c +++ b/net

Re: [PATCH net-next v6 1/1] net sched actions: Add support for user cookies

On 17-01-23 07:58 AM, Simon Horman wrote: Hi Jamal, On Sun, Jan 22, 2017 at 03:25:50PM -0500, Jamal Hadi Salim wrote: ... @@ -33,6 +34,8 @@ static void free_tcf(struct rcu_head *head) free_percpu(p->cpu_bstats); free_percpu(p->cpu_qstats); + kfree(p->act_coo

[PATCH net-next v6 1/1] net sched actions: Add support for user cookies

From: Jamal Hadi Salim <j...@mojatatu.com> Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved serves as a correlator. The

Re: [PATCH net-next v5 1/1] net sched actions: Add support for user cookies

On 17-01-22 02:32 PM, Jiri Pirko wrote: Sun, Jan 22, 2017 at 07:57:17PM CET, j...@mojatatu.com wrote: On 17-01-22 01:13 PM, Florian Fainelli wrote: + a->act_cookie->data = nla_memdup(tb[TCA_ACT_COOKIE], +GFP_KERNEL); +

Re: [PATCH net-next v5 1/1] net sched actions: Add support for user cookies

On 17-01-22 01:13 PM, Florian Fainelli wrote: + a->act_cookie->data = nla_memdup(tb[TCA_ACT_COOKIE], +GFP_KERNEL); + if (!a->act_cookie->data) { + err = -ENOMEM; +

Re: [patch net-next 1/4] net: Introduce psample, a new genetlink channel for packet sampling

to see the samples. Reviewed-by: Jamal Hadi Salim <j...@mojatatu.com> cheers, jamal

Re: [patch net-next 2/4] net/sched: Introduce sample tc action

hope those are cleaned up at some point). otherwise: Acked-by: Jamal Hadi Salim <j...@mojatatu.com> cheers, jamal

Re: [PATCH net-next v5 0/1] Add support for tc cookies

I removed people's reviewed/Acked because i changed the data structure per Daniel's suggestions. cheers, jamal On 17-01-22 07:51 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim <j...@mojatatu.com> Changes in V5: - kill the stylistic changes - Adopt a new structure with length-valuep

[PATCH net-next v5 1/1] net sched actions: Add support for user cookies

From: Jamal Hadi Salim <j...@mojatatu.com> Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol field, etc) the idea is to save user state that when retrieved serves as a correlator. The

[PATCH net-next v5 0/1] Add support for tc cookies

From: Jamal Hadi Salim <j...@mojatatu.com> Changes in V5: - kill the stylistic changes - Adopt a new structure with length-valuepointer representation - rename some things Changes in v4: - move stylistic changes out into a separate patch (and add more stylistic changes) Changes

Re: [PATCH net 1/1] net sched actions: fix refcnt when GETing of action after bind

On 17-01-20 01:20 AM, Cong Wang wrote: On Wed, Jan 18, 2017 at 3:33 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote: On 17-01-17 01:17 PM, Cong Wang wrote: I did. The issue there (after your original patch) was destroy() would decrement the refcount to zero and a GET was essen

Re: [PATCH net-next v4 1/2] net sched actions: Add support for user cookies

On 17-01-18 06:47 AM, Paul Blakey wrote: On 17/01/2017 13:11, Jamal Hadi Salim wrote: From: Jamal Hadi Salim <j...@mojatatu.com> Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib protocol

Re: [PATCH net-next v4 1/2] net sched actions: Add support for user cookies

On 17-01-17 01:40 PM, Cong Wang wrote: On Tue, Jan 17, 2017 at 3:11 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote: @@ -575,6 +583,23 @@ struct tc_action *tcf_action_init_1(struct net *net, struct nlattr *nla, if (err < 0) goto err_mod; + if (tb[TCA_A

Re: [PATCH net 1/1] net sched actions: fix refcnt when GETing of action after bind

On 17-01-17 01:17 PM, Cong Wang wrote: On Sun, Jan 15, 2017 at 7:14 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote: diff --git a/net/sched/act_api.c b/net/sched/act_api.c index 2095c83..e10456ef6f 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -900,8 +900,6 @@ stat

Re: [PATCH net-next v4 1/2] net sched actions: Add support for user cookies

On 17-01-17 12:05 PM, Jiri Pirko wrote: Tue, Jan 17, 2017 at 05:57:58PM CET, dan...@iogearbox.net wrote: Given this cookie is just used for correlation in user space anyway and not processed any further by the kernel, I think we can well handle these very few spots, so would be better if the

Re: [PATCH net-next] net/sched: cls_flower: Add user specified data

On 17-01-17 06:53 AM, Paul Blakey wrote: Should be "trivial" like my patch. Add a new TLV type in TCA_XXX enum in rtnetlink.h in tc_ctl_tfilter look for it and memcpy it in tcf_fill_node set it on the new TCA_XXX if the cls struct has it present. That's exactly what I did before I

Re: [PATCH net-next v4 1/2] net sched actions: Add support for user cookies

On 17-01-17 11:57 AM, Daniel Borkmann wrote: On 01/17/2017 05:50 PM, Jamal Hadi Salim wrote: struct tc_cookie cookie; Grep-ability. I was worried about when the classifier adds its cookie it would need to use something like cls_cookie etc. Given this cookie is just used for correlation

Re: [PATCH net-next v4 1/2] net sched actions: Add support for user cookies

On 17-01-17 11:50 AM, Jamal Hadi Salim wrote: On 17-01-17 09:16 AM, Daniel Borkmann wrote: I can do that if you feel strongly. I am dropping the first patch and hope Dave just applies this first patch. I meant this second patch. cheers, jamal

Re: [PATCH net-next v4 1/2] net sched actions: Add support for user cookies

On 17-01-17 09:16 AM, Daniel Borkmann wrote: On 01/17/2017 12:11 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim <j...@mojatatu.com> Introduce optional 128-bit action cookie. Like all other cookie schemes in the networking world (eg in protocols like http or existing kernel fib pr

Re: [PATCH net-next v4 2/2] net sched: Trivial whitespace and stylistic changes

Jiri, I am going to drop this patch altogether. Someday i will do the cleanup. cheers, jamal On 17-01-17 07:12 AM, Jiri Pirko wrote: Tue, Jan 17, 2017 at 12:11:49PM CET, j...@mojatatu.com wrote: From: Jamal Hadi Salim <j...@mojatatu.com> Signed-off-by: Jamal Hadi Salim <j...@moj

<    1   2   3   4   5   6   7   8   9   10   >