Re: macmace: use unsigned long flags;

2007-07-10 Thread Jeff Garzik
Alexey Dobriyan wrote: Code will do local_irq_save() on it. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- drivers/net/macmace.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/macmace.c +++ b/drivers/net/macmace.c @@ -577,7 +577,7 @@ static irqreturn_t

Re: [PATCH] atl1: remove write-only var in tx handler

2007-07-10 Thread Jeff Garzik
Alexey Dobriyan wrote: Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- drivers/net/atl1/atl1_main.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] bonding / ipv6: no addrconf for slaves separately from master

2007-07-10 Thread Jeff Garzik
Jay Vosburgh wrote: At present, when a device is enslaved to bonding, if ipv6 is active then addrconf will be initated on the slave (because it is closed then opened during the enslavement processing). This causes DAD and RS packets to be sent from the slave. These packets in turn can

Re: [PATCH] Cleanup usbnet_probe() return value handling

2007-07-10 Thread Jeff Garzik
Peter Korsgaard wrote: David == David Brownell [EMAIL PROTECTED] writes: Hi, David I'd rather see the later test updated to match this one. David (Good catch!) David The return convention is negative means error. There's David code in USB which has multiple nonnegative success codes.

Re: [2.6 patch] the scheduled sk98lin removal

2007-07-10 Thread Jeff Garzik
Adrian Bunk wrote: This patch contains the scheduled removal of the sk98lin driver. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Stephen -- ACK? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [2,6 patch] sunhme.c:quattro_pci_find() must be __devinit

2007-07-10 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes the following section mismatch: -- snip -- ... MODPOST vmlinux WARNING: drivers/built-in.o(.text+0x272f8b): Section mismatch: reference to .init.text:quattro_pci_find (between 'happy_meal_pci_probe' and 'happy_meal_pci_remove') ... -- snip --

Re: [linux-usb-devel] [PATCH]: cdc-subset to support new vendor/product ID

2007-07-10 Thread Jeff Garzik
jing xiang wrote: Hi, This patch is for cdc subset to support Mavell vendor/product ID. Jing Xiang Signed-off-by: Jing Xiang[EMAIL PROTECTED] diff -uNpr linux-2.6.21.5/driver/usb/net/cdc_subset.c linux-2.6.21.5.t/driver/usb/net/cdc_subset.c --- linux-2.6.21.5/driver/usb/net/cdc_subset.c

Re: [patch 2/7] Blackfin: on-chip ethernet MAC controller driver

2007-07-10 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Wu, Bryan [EMAIL PROTECTED] This patch implements the driver necessary use the Analog Devices Blackfin processor's on-chip ethernet MAC controller. Signed-off-by: Bryan Wu [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

Re: [PATCH 1/2] eHEA: Capability flag for DLPAR support

2007-07-10 Thread Jeff Garzik
Jan-Bernd Themann wrote: This patch introduces a capability flag that is used by the DLPAR userspace tool to check which DLPAR features are supported by the eHEA driver. Missing goto has been included. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] applied - To unsubscribe from this

Re: [PATCH 2/2] eHEA: Receive SKB Aggregation

2007-07-10 Thread Jeff Garzik
Jan-Bernd Themann wrote: This patch enables the receive side processing to aggregate TCP packets within the HEA device driver. It analyses the packets already received after an interrupt arrived and forwards these as chains of SKBs for the same TCP connection with modified header field. We have

Re: [PATCH] PHY fixed driver: rework release path and update phy_id notation

2007-07-10 Thread Jeff Garzik
Vitaly Bordug wrote: device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause Device '[EMAIL PROTECTED]:1' does not have a release() function, it

Re: [PATCH] ethtool: new ID to decode the registers of the 8101E (realtek)

2007-07-10 Thread Jeff Garzik
Francois Romieu wrote: Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Rolf Eike Beer [EMAIL PROTECTED] --- realtek.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Jeff Garzik
(just to provide my indicator of status) Andrew Morton wrote: libata-config_pm=n-compile-fix.patch that's for a branch that you don't get via libata-dev#ALL, #mv-ahci-pata. pata_acpi-restore-driver.patch see Alan's comments. I've been ignoring pata_acpi for a while, because IMO it

Re: [PATCH 0/1] ixgbe: Support for Intel(R) 10GbE PCI Express adapters - Take #2

2007-07-10 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: 7. NAPI mode uses sigle Rx queue and so fake netdev usage is removed. 8. Non-NAPI mode is added. Honestly I'm not sure about drivers that have both NAPI and non-NAPI paths. Several existing drivers do this, and in almost every case, I tend to feel the driver would

Re: [PATCH] ps3: gigabit ethernet driver for PS3, take3

2007-07-10 Thread Jeff Garzik
Masakazu Mokuno wrote: Hi, This is the third submission of the network driver for PS3. The differences from the previous one are: - renamed source file names so that their prefix can match with the module name - added [EMAIL PROTECTED] line for MAINTAINER file - changed some in

Re: [PATCH 0/1] ixgbe: Support for Intel(R) 10GbE PCI Express adapters - Take #2

2007-07-10 Thread Jeff Garzik
Veeraiyan, Ayyappan wrote: On 7/10/07, Jeff Garzik [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: Doing both tends to signal that the author hasn't bothered to measure the differences between various approaches, and pick a clear winner. I did pick NAPI in our previous submission based

Re: ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Jeff Garzik
Andrew Morton wrote: On Tue, 10 Jul 2007 13:42:16 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: (just to provide my indicator of status) Thanks. libata-add-irq_flags-to-struct-pata_platform_info-fix.patch are other pata_platform people happy with this? I don't know embedded well enough

Re: [2.6 patch] the overdue eepro100 removal

2007-07-09 Thread Jeff Garzik
Kok, Auke wrote: as discussed before we really want to avoid having (1) an unmaintained bitrotting driver for X and (2) one that should work because people are being paid to take care of it. The community has always encouraged us to work with us fixing the last issues in e100 to make it work

Re: Splitting e1000 (Was: Re: e1000: backport ich9 support from 7.5.5 ?)

2007-07-09 Thread Jeff Garzik
Andrew Grover wrote: On 7/8/07, Jeff Garzik [EMAIL PROTECTED] wrote: * e1000 gets feedback * Intel disappears for months * Intel reappears with e1000 rewrite * you ask them for another complete (simpler) rewrite * Intel fights tooth and nail when the driver is not accepted verboten I

Re: Splitting e1000 (Was: Re: e1000: backport ich9 support from 7.5.5 ?)

2007-07-09 Thread Jeff Garzik
Arjan van de Ven wrote: Jeff Garzik wrote: Is this is the attitude, what's the point of even posting the driver for review? Intel posted e1000new on June 29. Feedback was then posted. and feedback is being incorperated. Ten days later, without a single revision, Intel declares its own

Re: Splitting e1000 (Was: Re: e1000: backport ich9 support from 7.5.5 ?)

2007-07-09 Thread Jeff Garzik
Kok, Auke wrote: I would strongly vote for taking a stripped down e1000new then, mask out all the pci id's except ich9, remove all code for pre-pci-e silicon and remove the most annoying and needlessly complexing code like the semi-implemented multiqueue code that is in there. I'm fine for

Re: Splitting e1000 (Was: Re: e1000: backport ich9 support from 7.5.5 ?)

2007-07-08 Thread Jeff Garzik
Kok, Auke wrote: This is not acceptable and hardly fair to expect from us. It also exposes users to endless delays and uncertainties as to a final resolution. Not to mention that writing a driver from scratch for (just) ich9 will take significant time, is silly since it's almost identical to

Re: Splitting e1000 (Was: Re: e1000: backport ich9 support from 7.5.5 ?)

2007-07-08 Thread Jeff Garzik
Arjan van de Ven wrote: I'd second this; also lets be honest and fair about things and use a similar standard for all drivers; are we going to ask all driver submitters to remove NAPI, TSO and other stuff? I would hope not. Are That was merely a suggestion. My general meaning was small

Re: Splitting e1000 (Was: Re: e1000: backport ich9 support from 7.5.5 ?)

2007-07-08 Thread Jeff Garzik
Stephen Hemminger wrote: I think rather than having a meta-discussion, which always seems to degenerate into finger pointing. Let's look at the code. The problem with popular drivers (as I too well know) is that user's seem to find every wart. There are lots of old drivers that never seem to

Re: RFR: New e1000 driver (e1000new), was: Re: e1000: backport ich9 support from 7.5.5 ?

2007-07-08 Thread Jeff Garzik
Arjan van de Ven wrote: Kok, Auke wrote: Jeff Garzik wrote: Andrew Morton wrote: On Fri, 29 Jun 2007 14:39:20 -0700 Kok, Auke [EMAIL PROTECTED] wrote: That's why we want to introduce a second e1000 driver (named differently, pick any name) that contains the new code base, side-by-side

Re: RFR: New e1000 driver (e1000new), was: Re: e1000: backport ich9 support from 7.5.5 ?

2007-07-08 Thread Jeff Garzik
Roland Dreier wrote: one possibility would be to merge e1000new with support only for chips not supported by e1000, and semi-freeze e1000 (fixes only, new device support goes into e1000new). indeed. Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in free_shared_mem() in drivers/net/s2io.c

2007-07-08 Thread Jeff Garzik
Micah Gruber wrote: This patch fixes a potential null dereference bug where we dereference nic before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] any chance you can resend in an email

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-05 Thread Jeff Garzik
Inaky Perez-Gonzalez wrote: On Tuesday 03 July 2007, Jeff Garzik wrote: Inaky Perez-Gonzalez wrote: Access to bitfields are not atomic within the machine int in which they are stored... you need to unpack the values stored in bitfields, even if they are single-bit bitfields. Which we do

Re: Splitting e1000 (Was: Re: e1000: backport ich9 support from 7.5.5 ?)

2007-07-05 Thread Jeff Garzik
Kok, Auke wrote: 1a) We post an e1000e driver that implements support for all 8257x (ich8/9, es2lan etc) devices. 1b) We post a patch that drops support for all of these devices in the form of a pci-ID removal (no code removed) for e1000. 2) we post patches that remove code support for

Re: [PATCH] ps3: gigabit ethernet driver for PS3, take2

2007-07-03 Thread Jeff Garzik
Masakazu Mokuno wrote: --- a/drivers/net/Makefile +++ b/drivers/net/Makefile @@ -60,6 +60,8 @@ obj-$(CONFIG_TIGON3) += tg3.o obj-$(CONFIG_BNX2) += bnx2.o spidernet-y += spider_net.o spider_net_ethtool.o obj-$(CONFIG_SPIDER_NET) += spidernet.o sungem_phy.o +obj-$(CONFIG_GELIC_NET) +=

Re: [E1000-devel] e1000: backport ich9 support from 7.5.5 ?

2007-07-03 Thread Jeff Garzik
Christoph Hellwig wrote: On Mon, Jul 02, 2007 at 04:52:52PM -0700, Williams, Mitch A wrote: - We include e1000new in 2.6.23, along side e1000. We expose ICH9 device IDs in e1000new, and gate the rest of the IDs inside #ifndef CONFIG_E1000. No. Hardware support in one driver should never

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-03 Thread Jeff Garzik
Inaky Perez-Gonzalez wrote: I don't think bitfields are broken. Maybe it's the compiler what should be fixed (*) Then you do not understand bitfields. It is -axiomatic- that bitfields are more difficult for compilers to implement. Access to bitfields are not atomic within the machine int

Re: Please pull 'libertas-fixes' branch of wireless-2.6

2007-07-02 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 189548642c5962e60c3667bdb3a703fe0bed12a6: Linus Torvalds (1): Linus 2.6.22-rc6 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git libertas-fixes Dan Williams (4):

Re: Please pull from 'from_linus' branch

2007-07-02 Thread Jeff Garzik
Kumar Gala wrote: Please pull from 'for_linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for_linus to receive the following updates: drivers/net/gianfar.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Kumar Gala (1): gianfar: Fix typo

Re: [PATCH 2.6.22 2/4]S2IO: Removing MSI support from the driver

2007-07-02 Thread Jeff Garzik
Veena Parat wrote: 1.Removed MSI support from driver - unused feature 2.Removed pci_request_regions call to allocate bar2 as it is not used in driver 3.Removed pci_release_regions since pci_request_regions is not done This is wrong. pci_request_regions() grabs all the regions for the

Re: [PATCH 2.6.22 1/4]S2IO: Adding checks to check the return value of pci mapping function

2007-07-02 Thread Jeff Garzik
Veena Parat wrote: Adding checks to check the return value of pci mapping function Signed-off-by: Veena Parat [EMAIL PROTECTED] --- diff -urpN org/drivers/net/s2io.c patch_1/drivers/net/s2io.c --- org/drivers/net/s2io.c 2007-05-17 20:35:39.0 +0530 +++ patch_1/drivers/net/s2io.c

Re: [PATCH] myri10ge: SET_NETDEV_DEV()

2007-07-02 Thread Jeff Garzik
Maik Hampel wrote: SET_NETDEV_DEV() in myri10ge to create the /sys/class/net/if/device symlink. Signed-off-by: Maik Hampel [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch] starfire list alpha as 64 bit arch

2007-07-02 Thread Jeff Garzik
maximilian attems wrote: instead of: This driver has not been ported to this 64-bit architecture yet. the driver is said to work on alpha, see http://bugs.debian.org/305330 Signed-off-by: maximilian attems [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] dm9601: HW header size shouldn't be included in packet length

2007-07-02 Thread Jeff Garzik
Peter Korsgaard wrote: The dm9601 driver was including the 2 byte hardware header in the packet length, causing the HW to send 2 extra bytes of garbage on tx. Signed-off-by: Peter Korsgaard [EMAIL PROTECTED] --- drivers/net/usb/dm9601.c |5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH] usbnet: Zero padding byte if there is tail room in skb

2007-07-02 Thread Jeff Garzik
Peter Korsgaard wrote: Usbnet adds a padding byte if a 0 byte USB packet would be sent. Zero padding byte if there is tail room in skb. Signed-of-by: Peter Korsgaard [EMAIL PROTECTED] Acked-by: David Brownell [EMAIL PROTECTED] --- drivers/net/usb/usbnet.c |9 ++--- 1 file changed, 6

Re: [PATCH] Update MAINTAINERS for USB network devices

2007-07-02 Thread Jeff Garzik
Peter Korsgaard wrote: Greg == Greg KH [EMAIL PROTECTED] writes: Greg Yeah, this is the cdc_acm driver that is still in the USB drivers/ Greg directory tree as it is a USB class driver that shows up as a tty device Greg to userspace. It should not be moved to the networking list unless no

Re: [PATCH] dm9601: Return 0 from bind() on success

2007-07-02 Thread Jeff Garzik
Peter Korsgaard wrote: Fixup dm9601_bind() so it returns 0 on success rather than just a positive number, as otherwise usbnet doesn't init the status handler. Signed-off-by: Peter Korsgaard [EMAIL PROTECTED] --- drivers/net/usb/dm9601.c |6 ++ 1 file changed, 2 insertions(+), 4

Re: RESEND [PATCH 1/3] NetXen: Fix issue of MSI not working correctly

2007-07-02 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: NetXen driver uses PCI function 0 to provide the functionality of MSI. The patch makes driver check the bus master bit for function 0 and enable it after the card initialization. Signed-off-by: Dhananjay Phadke[EMAIL PROTECTED] Signed-off-by: Milan Bag [EMAIL PROTECTED]

Re: [2.6 patch] drivers/net/ns83820.c: fix a check-after-use

2007-07-02 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] ps3: gigabit ethernet driver for PS3, take2

2007-07-02 Thread Jeff Garzik
MOKUNO Masakazu wrote: Hi, This is the second submission of the network driver for PS3. This version have been updated to address issues raised in the review. Please apply for 2.6.23. From: Masakazu Mokuno [EMAIL PROTECTED] Add Gigabit Ethernet support for the PS3 game console. The module

Re: [PATCH 3/9] pasemi_mac: Abstract out register access

2007-07-02 Thread Jeff Garzik
Olof Johansson wrote: Abstract out the PCI config read/write accesses into reg read/write ones, still calling the pci accessors on the back end. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: netdev-2.6/drivers/net/pasemi_mac.c

Re: [PATCH 2/9] pasemi_mac: Clean TX ring in poll

2007-07-02 Thread Jeff Garzik
Olof Johansson wrote: Clean the TX ring in the poll call, to avoid sitting on mapped buffers for a long time. NFS doesn't seem to like it much, for example. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: netdev-2.6/drivers/net/pasemi_mac.c

Re: [PATCH] spidernet: Replace literal with const

2007-07-02 Thread Jeff Garzik
Linas Vepstas wrote: Replace literal with const; add bit definitions. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] On Wed, Jun 13, 2007 at 04:12:00PM -0400, Jeff Garzik wrote: A follow-up patch needs to remove the above magic numbers (==numeric constants), replacing them with named

Re: [PATCH 1/9] pasemi_mac: Fix TX interrupt threshold

2007-07-02 Thread Jeff Garzik
Olof Johansson wrote: It was mistakenly set to interrupt on the second packet instead of first, causing some interesting latency behaviour. Signed-off-by: Olof Johansson [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH/RESENT] ehea: Whitespace cleanup

2007-07-02 Thread Jeff Garzik
Jan-Bernd Themann wrote: This patch fixes several whitespace issues. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 2.6.21.5] 8139cp: dev-tx_timeout

2007-07-02 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: This patch implements the missing dev-tx_timeout for 8139cp driver Signed-off-by: Mika Lansirinne [EMAIL PROTECTED] does not seem to apply to current kernel. please resend against netdev-2.6.git#upstream or 2.6.22-rc7. - To unsubscribe from this list: send the

Re: [PATCH UPDATE #2] Extract chip specific code out of lasi_82596.c

2007-07-02 Thread Jeff Garzik
applied both patches. Please provide an update that does at Andrew requested -- rather than #include'ing lib82596.c, you should update the Makefile for relevant drivers to look like obj-$(CONFIG_FOO_BAR) += lib82596.o foo_bar_82596.o and make sure it exports everything to make lib82596 a

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Ayyappan Veeraiyan wrote: +#define IXGBE_TX_FLAGS_CSUM0x0001 +#define IXGBE_TX_FLAGS_VLAN0x0002 +#define IXGBE_TX_FLAGS_TSO 0x0004 +#define IXGBE_TX_FLAGS_IPV40x0008 +#define IXGBE_TX_FLAGS_VLAN_MASK 0x +#define

Re: [PATCH UPDATE #2] Extract chip specific code out of lasi_82596.c

2007-07-02 Thread Jeff Garzik
Thomas Bogendoerfer wrote: On Mon, Jul 02, 2007 at 08:43:04AM -0400, Jeff Garzik wrote: applied both patches. Please provide an update that does at Andrew requested -- rather than #include'ing lib82596.c, you should update the Makefile for relevant drivers to look like I got

Re: 2.6.22-rc6: local_bh_enable warning

2007-07-02 Thread Jeff Garzik
Patrick McHardy wrote: Russell King wrote: Having upgraded from 2.6.16 to 2.6.22-rc6, I'm now seeing the following. Looks like netfilter is calling local_bh_enable() with IRQs disabled, which would appear to be illegal. Thankfully, this is a warn-once warning. WARNING: at

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Arjan van de Ven wrote: +u32 alloc_rx_buff_failed; +struct { +unsigned int rx_csum_enabled:1; +unsigned int msi_capable:1; +unsigned int msi_enabled:1; +unsigned int msix_capable:1; +unsigned int msix_enabled:1; +

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Arjan van de Ven wrote: Jeff Garzik wrote: always avoid bitfields. They generate horrible code, and endian problems abound (though no endian problems are apparent here). they generate no worse code than open coding the checks for these feature flags... That would be the logical assumption

[info] What's in netdev-2.6.git?

2007-07-02 Thread Jeff Garzik
(2): Add 93cx6 eeprom library eeprom_93cx6: Add comment for 1us delay after pulse Jan Engelhardt (1): Use menuconfig objects II - netdev (general+100mbit) Jan-Bernd Themann (1): ehea: Whitespace cleanup Jeff Garzik (2): Merge branch 'upstream-fixes' into upstream

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Kok, Auke wrote: Maybe this is not most important for ixgbe, where we only have 8 or so flags, but the new e1000 driver that I posted this weekend currently has 63 (you wanted flags ;)) of them. Do you want me to use 63 integers or just 2 ? Don't be silly. We are talking about single-bit

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Andrew Morton wrote: On Mon, 02 Jul 2007 11:32:41 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Bitfields are to be avoided for many reasons: * more difficult, in general, for a compiler to generate optimal code * in particular, known to generate worse code on various architectures * often causes

Re: [info] What's in netdev-2.6.git?

2007-07-02 Thread Jeff Garzik
Ben Dooks wrote: On Mon, Jul 02, 2007 at 11:08:26AM -0400, Jeff Garzik wrote: This is what is currently queued for 2.6.23. There are a few patches in my mbox not yet applied to the git tree, but this is most of them. I sent driver support for the AX88796 a few weeks ago with no feedback

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Kok, Auke wrote: I suppose I can fix those, but I really don't understand what all the fuzz is about here. We're only conserving memory and staying far away from the real risks of bitmasks, so forgive me if I don't grasp the problem. Be it machine ints or bitfields, you're not conserving

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Michael Buesch wrote: On Tuesday 03 July 2007 00:02:57 Kok, Auke wrote: well, FWIW when I started looking at adding these flags I looked in various subsystems in the kernel and picked an implementation that suited. Guess what pci.h has? ...: unsigned int msi_enabled:1;

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Kok, Auke wrote: but let's stay constructive here: ~/git/linux-2.6 $ grep -r 'unsigned int.*:1;' * | wc -l 748 Is anyone going to fix those? If we don't, someone will certainly again submit patches to add more of these bitfields, after all, some very prominent parts of the kernel still use

Re: [2.6 patch] the overdue eepro100 removal

2007-07-01 Thread Jeff Garzik
Kok, Auke wrote: this needs to be resceduled for 2.6.24 (at least). We're hoping to merge the proposed changes (still being worked on) in .23. Milton Miller and David Acker are working on that. Quite agreed. Jeff - To unsubscribe from this list: send the line unsubscribe netdev in

Re: [PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's r8169 driver

2007-06-30 Thread Jeff Garzik
Francois Romieu wrote: Jeff Garzik [EMAIL PROTECTED] : Arjan van de Ven wrote: + pci_write_config_byte(tp-pci_dev, PCI_LATENCY_TIMER, 0x40); can you create a pci_set_latency_timer() for this please? [...] + if (tp-mac_version = RTL_GIGA_MAC_VER_06) + pci_write_config_byte(tp

PM policy, hotplug, power saving (was Re: [PATCH] b44: power down PHY when interface down)

2007-06-30 Thread Jeff Garzik
Arjan van de Ven wrote: Matthew Garrett wrote: Do you still get link beat detection when the phy is powered down? does that matter? If the interface is down, nic drivers aren't expected to detect link... if userspace wants to find link status it should have the interface up. Definitely

Re: Handling set_mac_address in set_rx_mode

2007-06-30 Thread Jeff Garzik
Patrick McHardy wrote: While adding support for secondary unicast addresses to 8021q and macvlan, I've tried keeping dev-dev_addr as global address on dev-uc_list and have drivers skip them to avoid having all dev_unicast_add users implement a state machine like this: [...] Something that is

Re: [PATCH 3/3] NetXen: Graceful teardown of interface and hardware upon module unload

2007-06-30 Thread Jeff Garzik
Dhananjay Phadke wrote: This stage is safe to bail out on signal. It's initializing about a hundred registers and trying to guaranty by retrying, so can get stretched too much on faulty h/w. This implies that you have -add- code to check for and handle signals at each delay point. Don't

Re: [PATCH 2/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-29 Thread Jeff Garzik
David Miller wrote: From: PJ Waskiewicz [EMAIL PROTECTED] Date: Thu, 28 Jun 2007 09:21:13 -0700 -struct net_device *alloc_netdev(int sizeof_priv, const char *name, - void (*setup)(struct net_device *)) +struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name, +

Re: Please pull from 'from_linus' branch

2007-06-29 Thread Jeff Garzik
Kumar Gala wrote: Please pull from 'for_linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for_linus to receive the following updates: drivers/net/gianfar.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Kumar Gala (1): gianfar: Fix typo

Re: [PATCH 2.6.22 1/4]S2IO: Adding checks to check the return value of pci mapping function

2007-06-29 Thread Jeff Garzik
Sivakumar Subramani wrote: Hi Jeff, Any update on these patch submission? Is it in queue? it's in my mbox queue, to be reviewed. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 00/21] r8169: pull request for 'r8169-for-jeff-20070629' branch

2007-06-29 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'r8169-for-jeff-20070629' in repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git r8169-for-jeff-20070629 to get the changes below. Following mails on netdev describe each patch. Distance from 'netdev-2.6-upstream'

Re: [PATCH 10/21] r8169: merge with version 6.001.00 of Realtek's r8169 driver

2007-06-29 Thread Jeff Garzik
Arjan van de Ven wrote: + pci_write_config_byte(tp-pci_dev, PCI_LATENCY_TIMER, 0x40); can you create a pci_set_latency_timer() for this please? + + if (tp-mac_version = RTL_GIGA_MAC_VER_06) + pci_write_config_byte(tp-pci_dev, PCI_CACHE_LINE_SIZE, 0x08); and

Re: e1000: backport ich9 support from 7.5.5 ?

2007-06-29 Thread Jeff Garzik
Kok, Auke wrote: That's why we want to introduce a second e1000 driver (named differently, pick any name) that contains the new code base, side-by-side into the kernel with the current e1000. We do not want to introduce duplicate drivers for the same hardware. We spend -years- before the

Re: e1000: backport ich9 support from 7.5.5 ?

2007-06-29 Thread Jeff Garzik
Andrew Morton wrote: On Fri, 29 Jun 2007 14:39:20 -0700 Kok, Auke [EMAIL PROTECTED] wrote: That's why we want to introduce a second e1000 driver (named differently, pick any name) that contains the new code base, side-by-side into the kernel with the current e1000. Sounds like a reasonable

Re: e1000: backport ich9 support from 7.5.5 ?

2007-06-29 Thread Jeff Garzik
Andrew Grover wrote: I think making e1000new ICH9-and-newer isn't really the best place to split it. The Windows e1000 driver got split on the PCI-PCIe transition, something that clearly delineated what nics one driver supported, and the other. There's no real technical reason for splitting now

Re: [PATCH 2/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-28 Thread Jeff Garzik
Patrick McHardy wrote: Yes, but there are users that don't go through qdiscs, like netpoll, Having them check the QDISC_RUNNING bit seems ugly. Is netpoll the only such user? netpoll tends to be a special case in every sense of the word, and I wish it was less so :/ Jeff - To

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-27 Thread Jeff Garzik
pradeep singh wrote: Hi, This is second submission for a possible NULL dereference handling in the Chelsio's 10G driver. Thanks to Jens Axboe for pointing out my mistake of ignoring subsequent dereferences in init_one routine. Thanks Signed-off-by: Pradeep Singh [EMAIL PROTECTED] ---

Re: [NET] au1000_eth: Fix warnings.

2007-06-27 Thread Jeff Garzik
Ralf Baechle wrote: Fixed by including linux/dma-mapping.h: CC drivers/net/au1000_eth.o drivers/net/au1000_eth.c: In function 'au1000_probe': drivers/net/au1000_eth.c:661: warning: implicit declaration of function 'dma_alloc_noncoherent' drivers/net/au1000_eth.c:802: warning: implicit

Re: [PATCH 2.6.22] cxgb3 - fix register to stop bc/mc traffic

2007-06-27 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] Use the right register to stop broadcast/multicast traffic. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] applied to #upstream-fixes - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: 2.6.22: ERROR: __ucmpdi2 [drivers/net/s2io.ko] undefined!

2007-06-27 Thread Jeff Garzik
Olaf Hering wrote: On Tue, Jun 19, Stephen Hemminger wrote: On Tue, 19 Jun 2007 21:02:53 +0200 Olaf Hering [EMAIL PROTECTED] wrote: What happend to __ucmpdi2 from David Woodhouse? google has a few hits about stuff like this on 32bit powerpc with gcc 4.1.2: ERROR: __ucmpdi2

Re: [PATCH] Update MAINTAINERS for USB network devices

2007-06-27 Thread Jeff Garzik
Peter Korsgaard wrote: Questions regarding the USB network drivers should now go to netdev. Signed-off-by: Peter Korsgaard [EMAIL PROTECTED] --- MAINTAINERS | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) Index: linux-2.6.22-rc6/MAINTAINERS

Re: [PATCH] 8139cp dev-tx_timeout

2007-06-27 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: Hello All, We have been experimenting a couple of interface hangs with the 8139cp driver. It appears that the tx buffer stops transmitting and never starts up again in some yet unknown conditions. To be able to circumvent this we implemented the missing dev-tx_timeout

Re: 2.6.22: ERROR: __ucmpdi2 [drivers/net/s2io.ko] undefined!

2007-06-26 Thread Jeff Garzik
Andrew Morton wrote: This fix is still not present in anyone's tree and is required for 2.6.22. Where are we up to with it? It's in my mbox queue for 2.6.22 (hopefully today). Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-25 Thread Jeff Garzik
Andrew Morton wrote: The chelsio driver is assuming that pci_device_id.driver_data has been initialised to the board index, but I am unable to locate anywhere where that initialisation actually happens. It's hidden inside the CH_DEVICE() initializer-helper macro. Jeff - To

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-25 Thread Jeff Garzik
Andrew Morton wrote: (Who maintains this driver now?) It was abandonware from the beginning of its life. Stephen H and Francois R did a bunch of cleanups most recently. Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH] atl1: disable 64bit DMA

2007-06-25 Thread Jeff Garzik
Jay Cliburn wrote: On Mon, 25 Jun 2007 17:57:20 -0400 Chris Snook [EMAIL PROTECTED] wrote: Jay L. T. Cornwall wrote: Chris Snook wrote: What boards have we seen this on? It's quite possible this is: I can reproduce on an Asus P5K with a Core 2 Duo E6600. lspci identifies the controller

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-25 Thread Jeff Garzik
Andrew Morton wrote: On Mon, 25 Jun 2007 19:14:05 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Andrew Morton wrote: The chelsio driver is assuming that pci_device_id.driver_data has been initialised to the board index, but I am unable to locate anywhere where that initialisation actually

Re: [RFD] L2 Network namespace infrastructure

2007-06-23 Thread Jeff Garzik
David Miller wrote: I don't accept that we have to add another function argument to a bunch of core routines just to support this crap, especially since you give no way to turn it off and get that function argument slot back. To be honest I think this form of virtualization is a complete waste

Re: [RFD] L2 Network namespace infrastructure

2007-06-23 Thread Jeff Garzik
Eric W. Biederman wrote: Jeff Garzik [EMAIL PROTECTED] writes: David Miller wrote: I don't accept that we have to add another function argument to a bunch of core routines just to support this crap, especially since you give no way to turn it off and get that function argument slot back

Re: [PATCH] bonding: Fix use after free in unregister path

2007-06-20 Thread Jeff Garzik
Jay Vosburgh wrote: The following patch (based on a patch from Stephen Hemminger [EMAIL PROTECTED]) removes use after free conditions in the unregister path for the bonding master. Without this patch, an operation of the form echo -bond0 /sys/class/net/bonding_masters would trigger a

Re: [PATCH 1/8] s390: print correct level for HiperSockets devices

2007-06-20 Thread Jeff Garzik
Frank Pavlic wrote: From: Ursula Braun [EMAIL PROTECTED] For real HiperSockets the EBCDIC-ASCII conversion is not necessary. This is only needed for z/VM GuestLAN devices. Signed-off-by: Ursula Braun [EMAIL PROTECTED] Signed-off-by: Frank Pavlic [EMAIL PROTECTED] ---

Re: [PATCH 1/5] cxgb3 - fix skb-dev dereference

2007-06-20 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Divy Le Ray [EMAIL PROTECTED] eth_type_trans() now sets skb-dev. References to skb-dev should happen after it is called. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/sge.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: Why is this patch not in 2.6.22-rc5?

2007-06-19 Thread Jeff Garzik
Stephen Hemminger wrote: On Wed, 13 Jun 2007 21:36:30 -0700 Jay Vosburgh [EMAIL PROTECTED] wrote: The following patch (based on a patch from Stephen Hemminger [EMAIL PROTECTED]) removes use after free conditions in the unregister path for the bonding master. Without this patch, an

Re: cxgb3 regression in 2.6.22-rc5

2007-06-18 Thread Jeff Garzik
Steve Wise wrote: I get this crash running the chelsio cxgb3 module on 2.6.22-rc5. This is regression. I believe Divy from Chelsio has already posted a fix for this. This needs to be in 2.6.22... Jeff do you have this fix queued for 2.6.22? I think Divy's patches are here:

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

2007-06-14 Thread Jeff Garzik
David Woodhouse wrote: On Wed, 2007-06-13 at 11:14 -0500, Linas Vepstas wrote: Some googling seems to show that git pull has a bug/feature of ignoring the branch that one is working in, and pulling master no matter what. I have no clue why; this seems broken to me. Branches are generally a

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

2007-06-14 Thread Jeff Garzik
David Woodhouse wrote: On Thu, 2007-06-14 at 19:01 -0400, Jeff Garzik wrote: It makes diffing between lines of development more difficult, takes up more overall space, less cache friendly, ... All of which is much less true if you're sharing object directories or even using alternates

Re: [patch 1/6] 8139too: force media setting cleanup

2007-06-13 Thread Jeff Garzik
Kyuma Ohta wrote: Hi, I was testing 2.6.22-rc4 from yesterday, but communication speed of 8139 side is very slower than 2.6.21.* (less than 10kbytes/sec at 100MBPS,FULL-DUPLEX). I was not test from 2.6.22-rc ,yesterday I started to test 2.6.22-rc. So, I *must* set HALF-DUPLEX to 8139 side

Re: [PATCH 0/15] spidernet driver bug fixes

2007-06-13 Thread Jeff Garzik
Michael Ellerman wrote: I was just keen to see the major bugfixes get into 22, rather than waiting another few months for 23. Agreed. Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

<    5   6   7   8   9   10   11   12   13   14   >