Re: [PATCH net-next 06/15] ipv4: Merge ip_local_out and ip_local_out_sk

Le 06/10/2015 20:53, Eric W. Biederman a écrit : It is confusing and silly hiding a paramater so modify all of the callers to pass in the appropriate socket or skb->sk if no socket is known. Signed-off-by: "Eric W. Biederman" --- [snip] @@ -456,7 +456,7 @@

Re: [PATCH net-next 01/15] ipv4: Fix ip_local_out_sk by passing the sk into __ip_local_out_sk

Le 06/10/2015 20:53, Eric W. Biederman a écrit : In the rare case where sk != skb->sk ip_local_out_sk arranges to call dst->output differently if the skb is queued or not. This is a bug. Fix this bug by passing the sk parameter of ip_local_out_sk through from ip_local_out_sk to

Re: [PATCH net-next 2/6] openvswitch: Pass net into ovs_fragment

Le 01/10/2015 18:03, Eric W. Biederman a écrit : Nicolas Dichtel <nicolas.dich...@6wind.com> writes: Le 30/09/2015 23:25, Eric W. Biederman a écrit : [snip] + struct net *net = read_pnet(>net); nit: add an empty line after variables de

Re: [PATCH net-next 0/6] net: Pass net through ip fragmention

, then ipv4 and ipv6 are converted and then temporary helper functions are removed. Some minors comments (see other emails). Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...

Re: [PATCH net-next 4/6] ipv6: Pass struct net through ip6_fragment

Le 30/09/2015 23:25, Eric W. Biederman a écrit : Signed-off-by: Eric W. Biederman --- [snip] diff --git a/net/ipv6/xfrm6_output.c b/net/ipv6/xfrm6_output.c index 0c3e9ffcf231..335066a64b45 100644 --- a/net/ipv6/xfrm6_output.c +++ b/net/ipv6/xfrm6_output.c @@ -131,6

Re: [PATCH net-next 1/6] openvswitch: Pass net into ovs_vport_output

Le 30/09/2015 23:25, Eric W. Biederman a écrit : When struct net starts being passed through the ipv4 and ipv6 fragment routines ovs_vport_output will need to take a net parameter. Prepare ovs_vport_output before that is needed and introduce ovs_vport_output_skk for the call sites that still

Re: [PATCH net-next 2/6] openvswitch: Pass net into ovs_fragment

Le 30/09/2015 23:25, Eric W. Biederman a écrit : In preparation for the ipv4 and ipv6 fragmentation code taking a net parameter pass a struct net into ovs_fragment where the v4 and v6 fragmentation code is called. Signed-off-by: "Eric W. Biederman" --- [snip] @@ -748,6

Re: [PATCH next 0/5] netfilter: Pass net into ip_route_me_harder

. Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net 1/2] iptunnel: make rx/tx bytes counters consistent

Le 21/09/2015 07:37, David Miller a écrit : From: David Miller Date: Sun, 20 Sep 2015 22:35:13 -0700 (PDT) After the patch: $ ping -c1 192.168.0.121 ; ip -s l ls dev gre1 PING 192.168.0.121 (192.168.0.121) 56(84) bytes of data. 64 bytes from 192.168.0.121: icmp_req=1

Re: [PATCH next 0/30] Passing net through the netfilter hooks

Le 18/09/2015 00:24, Eric W. Biederman a écrit : [snip] Thanks for review. I have added an extra patch for the missing blank lines that are still missing after the entire series. As they affect neither code correctness nor bisectability I don't think there is any point respinning the indivdual

[PATCH net 1/2] iptunnel: make rx/tx bytes counters consistent

0 0 0 0 Reported-by: Julien Meunier <julien.meun...@6wind.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/ipv4/ip_tunnel_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunn

[PATCH net 2/2] ip6tunnel: make rx/tx bytes counters consistent

84 10 0 0 0 TX: bytes packets errors dropped carrier collsns 84 10 0 0 0 Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/net/ip6_tunnel.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH next 0/14] netfilter: Stop guessing net

Le 18/09/2015 18:13, Eric W. Biederman a écrit : [snip] It appears I forgot to hit send. The patches should show up any time now. Yes, thank you. Nicolas -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH next 0/14] netfilter: Stop guessing net

GTM. Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH next 0/14] netfilter: Stop guessing net

Le 18/09/2015 17:06, Eric W. Biederman a écrit : This is the next installment of my work to pass struct net through the output path so the code does not need to guess how to figure out which network namespace it is in, and ultimately routes can have output devices in another network namespace.

Re: list of all network namespaces

Le 17/09/2015 02:54, Rick Jones a écrit : On 09/16/2015 05:46 PM, Ani Sinha wrote: Hi guys just a stupid question. Is it possible to get a list of all active network namespaces in the kernel through /proc or some other interface? Presumably you could copy what "ip netns" does, which appears

Re: [PATCH next 16/30] ipv6: Only compute net once in ip6mr_forward2_finish

Le 16/09/2015 03:04, Eric W. Biederman a écrit : Signed-off-by: "Eric W. Biederman" --- net/ipv6/ip6mr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index e95f6b6281de..3e3085b37a91 100644 ---

Re: [PATCH next 28/30] netfilter: Pass struct net into the netfilter hooks

Le 16/09/2015 03:04, Eric W. Biederman a écrit : Pass a network namespace parameter into the netfilter hooks. At the call site of the netfilter hooks the path a packet is taking through the network stack is well known which allows the network namespace to be easily and reliabily. This allows

Re: [PATCH next 22/30] ipv6: Cache net in ip6_output

Le 16/09/2015 03:04, Eric W. Biederman a écrit : Keep net in a local variable so I can use it in NF_HOOK_COND when I pass struct net to all of the netfilter hooks. Signed-off-by: "Eric W. Biederman" --- net/ipv6/ip6_output.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [PATCH next 0/30] Passing net through the netfilter hooks

available and trivially usable. LGTM (except some minor comments). Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net] ipv6: include NLM_F_REPLACE in route replace notifications

works.com> Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net v4] ipv6: fix multipath route replace error recovery

72473a ("ipv6: fix ECMP route replacement") Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> LGTM Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> v1 - v2 : fix leak v2 - v3: fix 'Fixes' tag and warn msg (feedback from nicolas) resending against net v3 - v

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

Le 08/09/2015 02:01, roopa a écrit : On 9/7/15, 5:03 AM, Nicolas Dichtel wrote: [snip] yes, i had submitted the patch you mention above to fix a slightly different problem that existed then..which was introduced by "51ebd3181572 ("ipv6: add support of equal cost multipath (ECMP)&

Re: [PATCH net v3] ipv6: fix multipath route replace error recovery

Le 08/09/2015 02:42, roopa a écrit : On 9/6/15, 1:46 PM, Roopa Prabhu wrote: From: Roopa Prabhu Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in

Re: [PATCH net v3] ipv6: fix multipath route replace error recovery

Le 06/09/2015 22:46, Roopa Prabhu a écrit : From: Roopa Prabhu I've sent you some comments about the v2, so please keep me in CC for the next versions. Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

+ Michal Kubecek Le 06/09/2015 22:46, roopa a écrit : On 9/4/15, 1:12 AM, Nicolas Dichtel wrote: Le 03/09/2015 01:44, Roopa Prabhu a écrit : [snip] Fixes: 4a287eba2de3 ("IPv6 routing, NLM_F_* flag support: REPLACE and EXCL flags support, warn about missing CREATE flag") ECMP was

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

Le 03/09/2015 01:44, Roopa Prabhu a écrit : From: Roopa Prabhu Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in installing the subsequent

Re: Issue with /etc/netns/${nsname}/hosts

Le 02/09/2015 01:23, James Loosli a écrit : I seem to have an issue with using namespace-specific hosts files. Here's an example. I have different entries for foo.com in my hosts file for the namespace and the system-wide hosts file; root@server-01 Tue Sep 01 04:15:02pm cat

Re: [PATCH net] sock, diag: fix panic in sock_diag_put_filterinfo

by: Daniel Borkmann <dan...@iogearbox.net> Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH net] ip6_gre: release cached dst on tunnel removal

...@mail.ru Fixes: c12b395a4664 (gre: Support GRE over IPv6) Signed-off-by: huaibin Wang huaibin.w...@6wind.com Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- net/ipv6/ip6_gre.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index a38d3ac0f18f

[v3.18] Fixes for ip_vti and ip6_vti

Hi, since commit ca7c7b9059e3 (skbuff: Do not scrub skb mark within the same name space, backport of upstream commit 213dd74aee76), the following three upstream commits need also to be backported in the 3.18 branch: - cd5279c194f8 (ip_vti/ip6_vti: Do not touch skb-mark on xmit) - 049f8e2e28d9

Re: [PATCH net-next] vrf: rename the framework to mrf

Le 22/08/2015 19:47, David Miller a écrit : From: Nicolas Dichtel nicolas.dich...@6wind.com Date: Sat, 22 Aug 2015 18:10:20 +0200 This patch renames the recently added vrf driver. 'VRF' term is very generic and there is no clear definition of it. For example, someone may expect more isolation

[PATCH net-next] vrf: rename the framework to mrf

enlightens the fact that this driver is not *the* way to implement VRF in linux, but *a* tool among others. CC: Shrijeet Mukherjee s...@cumulusnetworks.com CC: David Ahern d...@cumulusnetworks.com Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- drivers/net/Kconfig | 8 +- drivers

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

Le 20/08/2015 13:53, Jiri Benc a écrit : On Wed, 19 Aug 2015 18:33:14 +0200, Nicolas Dichtel wrote: Probably better to introduce veth netlink attribute then, something like IFLA_VETH_PEER and keeps IFLA_LINK_NETNSID. I'd prefer IFLA_PEER. More generic attribute will be helpful should we

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

Le 19/08/2015 14:48, Vincent Bernat a écrit : ❦ 19 août 2015 14:38 +0200, Jiri Benc jb...@redhat.com : That's the main goal of this patch: advertising the peer link as IFLA_LINK attribute triggers an infinite loop in userland software when they follow iflink to discover network devices

Re: [PATCH net-next v3] route: allow to route in a peer netns via lwt framework

Le 29/07/2015 17:20, Eric Dumazet a écrit : On Wed, 2015-07-29 at 15:16 +0200, Nicolas Dichtel wrote: This patch takes advantage of the newly added lwtunnel framework to allow the user to set routes that point to a peer netns. Packets are injected to the peer netns via the loopback device

[PATCH net-next v3] route: allow to route in a peer netns via lwt framework

lo The goal is to be scalable when the number of netns is high (10k or more). Which this patch, we can save two interfaces (veth) per netns, which helps to to reduce memory consumption and the time needed to create a netns. Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- v3: fix skb

Re: [PATCH net-next v2] route: allow to route in a peer netns via lwt framework

Le 24/07/2015 17:39, Eric Dumazet a écrit : On Fri, 2015-07-24 at 16:16 +0200, Nicolas Dichtel wrote: This patch takes advantage of the newly added lwtunnel framework to allow the user to set routes that point to a peer netns. Packets are injected to the peer netns via the loopback device

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

Le 24/07/2015 17:19, David Ahern a écrit : In this case you are knowingly dropping packets. Would be nice to have a counter showing that. Ok. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH net-next] ipv6: use lwtunnel_output6() only if flag redirect is set

This function make sense only when LWTUNNEL_STATE_OUTPUT_REDIRECT is set. The check is already done in IPv4. CC: Thomas Graf tg...@suug.ch CC: Roopa Prabhu ro...@cumulusnetworks.com Fixes: 74a0f2fe8ed5 (ipv6: rt6_info output redirect to tunnel output) Signed-off-by: Nicolas Dichtel nicolas.dich

[PATCH net-next 1/2] ipv6: copy lwtstate in ip6_rt_copy_init()

We need to copy this field (ip6_rt_cache_alloc() and ip6_rt_pcpu_alloc() use ip6_rt_copy_init() to build a dst). CC: Thomas Graf tg...@suug.ch CC: Roopa Prabhu ro...@cumulusnetworks.com Fixes: 19e42e451506 (ipv6: support for fib route lwtunnel encap attributes) Signed-off-by: Nicolas Dichtel

[PATCH net-next 2/2] lwtunnel: change prototype of lwtunnel_state_get()

: Roopa Prabhu ro...@cumulusnetworks.com Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- include/net/lwtunnel.h | 16 +++- net/ipv4/fib_semantics.c | 9 - net/ipv4/route.c | 9 ++--- net/ipv6/ip6_fib.c | 2 +- net/ipv6/route.c | 8

[PATCH net-next v2] route: allow to route in a peer netns via lwt framework

lo Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- v2: rework loopback handling part (update stats and call skb_dst_force()) fix ipv6 processing check lwtunnel type before converting data to a nsid drivers/net/loopback.c| 33 +-- include/net

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

Le 24/07/2015 16:28, David Ahern a écrit : On 7/23/15 8:22 AM, Nicolas Dichtel wrote: static netdev_tx_t loopback_xmit(struct sk_buff *skb, struct net_device *dev) { +int nsid = skb_lwt_netns_info(skb); struct pcpu_lstats *lb_stats; int len; +if (nsid

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

Le 24/07/2015 15:50, roopa a écrit : On 7/24/15, 5:24 AM, Nicolas Dichtel wrote: Sure, but my goal was to not create a new .h file just for these two helpers. It's related to lwtunnel, thus I was thinking they can go here. ok..., since your lwt namespace functions went into net_namespace.c, I

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

Le 23/07/2015 17:50, roopa a écrit : On 7/23/15, 8:25 AM, Nicolas Dichtel wrote: Le 23/07/2015 17:01, roopa a écrit : On 7/23/15, 7:22 AM, Nicolas Dichtel wrote: [snip] +static inline u32 *lwt_netns_info(struct lwtunnel_state *lwtstate) +{ +return (u32 *)lwtstate-data; +} + +static

[PATCH net-next] lwtunnel: export linux/lwtunnel.h to userspace

Note also that include/linux/lwtunnel.h is not needed. CC: Thomas Graf tg...@suug.ch CC: Roopa Prabhu ro...@cumulusnetworks.com Fixes: 499a24256862 (lwtunnel: infrastructure for handling light weight tunnels like mpls) Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- include/linux

[PATCH net-next] route: allow to route in a peer netns via lwt framework

lo Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- drivers/net/loopback.c| 16 + include/net/lwtunnel.h| 23 +++ include/uapi/linux/lwtunnel.h | 1 + net/core/net_namespace.c | 52 +++ 4 files

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

Le 23/07/2015 17:01, roopa a écrit : On 7/23/15, 7:22 AM, Nicolas Dichtel wrote: [snip] +static inline u32 *lwt_netns_info(struct lwtunnel_state *lwtstate) +{ +return (u32 *)lwtstate-data; +} + +static inline int skb_lwt_netns_info(struct sk_buff *skb) +{ +if (skb-protocol == htons

[PATCH v2 iproute2] tc: fix bpf compilation with old glibc

version of getenv, thus let's simply use getenv(). CC: Daniel Borkmann dan...@iogearbox.net Fixes: 88eea5395483 (tc: {f,m}_bpf: allow to retrieve uds path from env) Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- v2: rework the fix to use getenv() instead of secure_getenv() examples

[PATCH net-next] openvswitch: fix compilation when vxlan is a module

tg...@suug.ch Fixes: 614732eaa12d (openvswitch: Use regular VXLAN net_device device) Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- net/openvswitch/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/net/openvswitch/Kconfig b/net/openvswitch/Kconfig index 1119f46b80b4

Re: [PATCH iproute2] tc: fix bpf compilation with old glibc

Le 22/07/2015 15:05, Daniel Borkmann a écrit : On 07/22/2015 02:29 PM, Nicolas Dichtel wrote: Error was: f_bpf.o: In function `bpf_parse_opt': f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv' m_bpf.o: In function `parse_bpf': m_bpf.c:(.text+0x587): undefined reference

[PATCH iproute2] tc: fix bpf compilation with old glibc

: 88eea5395483 (tc: {f,m}_bpf: allow to retrieve uds path from env) Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- configure | 49 +++-- tc/Makefile | 6 ++ tc/tc_bpf.h | 9 + 3 files changed, 62 insertions(+), 2 deletions

Re: [PATCH net-next v3 1/5] net: don't reforward packets already forwarded by offload device

sfel...@gmail.com Acked-by: Jiri Pirko j...@resnulli.us Acked-by: Roopa Prabhu ro...@cumulusnetworks.com Acked-by: Nicolas Dichtel nicolas.dich...@6wind.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH net-next v2 1/5] net: don't reforward packets already forwarded by offload device

Le 16/07/2015 10:04, sfel...@gmail.com a écrit : From: Scott Feldman sfel...@gmail.com Just before queuing skb for xmit on port, check if skb has been marked by switchdev port driver as already fordwarded by device. If so, drop skb. A non-zero skb-offload_fwd_mark field is set by the

[PATCH linux-3.18.y] rtnl: restore notifications for deleted interfaces

...@gmail.com Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- net/core/rtnetlink.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 24d3242f0e01..c522f7a00eab 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -2229,9 +2229,6

Re: [PATCH net v4] rtnl/bond: don't send rtnl msg for unregistered iface

Le 13/07/2015 16:11, Kristian Evensen a écrit : Hello, I have a quick question about this patch. On Wed, May 13, 2015 at 2:19 PM, Nicolas Dichtel nicolas.dich...@6wind.com wrote: diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 837d30b5ffed..7b25f1ef3d75 100644 --- a/net/core

Re: [PATCH net v4] rtnl/bond: don't send rtnl msg for unregistered iface

Le 13/07/2015 16:11, Kristian Evensen a écrit : Hello, I have a quick question about this patch. On Wed, May 13, 2015 at 2:19 PM, Nicolas Dichtel nicolas.dich...@6wind.com wrote: diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 837d30b5ffed..7b25f1ef3d75 100644 --- a/net/core

Re: [RFC net-next 2/6] net: Preparation for vrf device

Le 06/07/2015 17:03, David Ahern a écrit : Add a VRF_MASTER flag for interfaces and helper functions for determining if a device is a VRF_MASTER. Also, add link attribute for passing VRF_TABLE id. Both are used in the following patch that adds a VRF device driver. Signed-off-by: Shrijeet

Re: [PATCH net-next v2] ipv4: add support for linkdown sysctl to netconf

net-next, not net. Signed-off-by: Andy Gospodarek go...@cumulusnetworks.com Suggested-by: Nicolas Dichtel nicolas.dich...@6wind.com Acked-by: Nicolas Dichtel nicolas.dich...@6wind.com --- I realize two of these changes result in lines 80 chars, but this is to keep the coding-style used

Re: [RFC net-next 0/6] Proposal for VRF-lite - v2

Le 06/07/2015 19:53, Shrijeet Mukherjee a écrit : No no problem, Just trying to get the functional aspects worked out. the global search replace will be easy. Was hoping to see some more responses on the naming suggestions here from the community. If there is not disagreement we can spin

Re: [RFC net-next 2/6] net: Preparation for vrf device

Le 08/07/2015 10:37, Nicolas Dichtel a écrit : [snip] Also, why calling this '_MASTER', is there a notion of SLAVE? Ok, just got it in the next patch ;-) -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

Le 06/07/2015 17:03, David Ahern a écrit : This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all local routes pointing to

Re: [PATCH net-next] net: add support for linkdown sysctl to netconf

Le 06/07/2015 20:21, Andy Gospodarek a écrit : This kernel patch exports the value of the new ignore_routes_with_linkdown via netconf. Signed-off-by: Andy Gospodarek go...@cumulusnetworks.com Suggested-by: Nicolas Dichtel nicolas.dich...@6wind.com --- You need also to patch devinet_conf_proc

[PATCH net v2] Revert dev: set iflink to 0 for virtual interfaces

This reverts commit e1622baf54df8cc958bf29d71de5ad545ea7d93c. The side effect of this commit is to add a '@NONE' after each virtual interface name with a 'ip link'. It may break existing scripts. Reported-by: Oliver Hartkopp socket...@hartkopp.net Signed-off-by: Nicolas Dichtel nicolas.dich

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

Le 06/07/2015 17:03, David Ahern a écrit : This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all local routes pointing to

Re: [RFC net-next 0/6] Proposal for VRF-lite - v2

Le 06/07/2015 17:03, David Ahern a écrit : In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the multi-tenancy problem where each tenant has their own unique

[PATCH net] Revert dev: set iflink to 0 for virtual interfaces

This reverts commit e1622baf54df8cc958bf29d71de5ad545ea7d93c. The side effect of this commit is to add a '@NONE' after each virtual interface name with a 'ip link'. It may break existing scripts. Reported-by: Olivier Hartkopp socket...@hartkopp.net Signed-off-by: Nicolas Dichtel nicolas.dich

Re: [PATCH] add stealth mode

Le 02/07/2015 00:53, Matteo Croce a écrit : Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Dest-Unreach for UDP. Also disables ICMP replies to echo request and timestamp. The stealth mode can be enabled selectively for a single interface. ---

Re: [PATCH] add stealth mode

Le 02/07/2015 10:38, Matteo Croce a écrit : Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Port-Unreachable for UDP. Also disables ICMP replies to echo request and timestamp. The stealth mode can be enabled selectively for a single interface.

Re: displayed name changed in ip link show for bridge- and other interfaces

Le 21/06/2015 00:58, Oliver Hartkopp a écrit : On 06/17/2015 09:26 AM, Nicolas Dichtel wrote: Le 16/06/2015 19:35, Oliver Hartkopp a écrit : On 15.06.2015 17:54, Stephen Hemminger wrote: On Mon, 15 Jun 2015 11:13:12 +0200 Nicolas Dichtel nicolas.dich...@6wind.com wrote: Theoretically

Re: [PATCH net-next 0/3 v4] changes to make ipv4 routing table aware of next-hop link status

Le 17/06/2015 21:10, Andy Gospodarek a écrit : On Wed, Jun 17, 2015 at 06:05:32PM +0200, Nicolas Dichtel wrote: Le 15/06/2015 18:33, Andy Gospodarek a écrit : This series adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status

Re: displayed name changed in ip link show for bridge- and other interfaces

Le 16/06/2015 19:35, Oliver Hartkopp a écrit : On 15.06.2015 17:54, Stephen Hemminger wrote: On Mon, 15 Jun 2015 11:13:12 +0200 Nicolas Dichtel nicolas.dich...@6wind.com wrote: Theoretically, virtual interfaces should advertise an IFLA_LINK to 0. I don't know what is the best fix

Re: [PATCH net-next 0/3 v4] changes to make ipv4 routing table aware of next-hop link status

Le 15/06/2015 18:33, Andy Gospodarek a écrit : This series adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of the interface associated with the next-hop. Before this patch any link-failure on an interface that was serving

Re: displayed name changed in ip link show for bridge- and other interfaces

Le 15/06/2015 09:23, Nicolas Dichtel a écrit : Le 14/06/2015 21:12, Oliver Hartkopp a écrit : @Nicolas: Just saw that you were not responsible for the @NONE m) Sorry. Btw. do you know why this @NONE stuff just emerged in 4.1-rc ? Yes, it comes from the iflink cleanup in kernel: http

Re: displayed name changed in ip link show for bridge- and other interfaces

Le 14/06/2015 21:12, Oliver Hartkopp a écrit : @Nicolas: Just saw that you were not responsible for the @NONE m) Sorry. Btw. do you know why this @NONE stuff just emerged in 4.1-rc ? Yes, it comes from the iflink cleanup in kernel:

Re: [RFC net-next 2/3] VRF driver and needed infrastructure

Le 08/06/2015 20:35, Shrijeet Mukherjee a écrit : From: Shrijeet Mukherjee s...@cumulusnetworks.com [snip] --- /dev/null +++ b/drivers/net/vrf.c [snip] + +static struct rtnl_link_ops vrf_link_ops __read_mostly = { + .kind = DRV_NAME, + .priv_size = sizeof(struct

Re: [RFC net-next 0/3] Proposal for VRF-lite

Le 08/06/2015 20:35, Shrijeet Mukherjee a écrit : From: Shrijeet Mukherjee s...@cumulusnetworks.com In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the

Re: [RFC net-next 0/3] Proposal for VRF-lite

Le 09/06/2015 16:21, David Ahern a écrit : Hi Nicolas: On 6/9/15 2:58 AM, Nicolas Dichtel wrote: I'm not really in favor of the name 'vrf'. This term is very controversial and having a consensus of what is/contains a 'vrf' is quite impossible. There was already a lot of discussions about

Re: [RFC net-next 0/3] Proposal for VRF-lite

Le 09/06/2015 12:15, Thomas Graf a écrit : On 06/08/15 at 11:35am, Shrijeet Mukherjee wrote: [...] model with some performance paths that need optimization. (Specifically the output route selector that Roopa, Robert, Thomas and EricB are currently discussing on the MPLS thread) Thanks for

Re: [PATCH iproute2 resend] Fix changing tunnel remote and local address to any

the tunnel, the current parameters will be read from ip_tunnel_parm, and local and remote address won't be zeroes anymore, so it needs to be explicitly set to any. Signed-off-by: Thadeu Lima de Souza Cascardo casca...@redhat.com Acked-by: Nicolas Dichtel nicolas.dich...@6wind.com

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

Le 03/06/2015 00:58, Eric W. Biederman a écrit : [snip] On the drawing board is getting cross namespace routes so with a little luck I will only need loopback devices in most of my network namespaces when the dust settles. +1 I've start to look at this, but I didn't have enough time right now.

iproute2: missing patches in branch net-next

Hi Stephen, some patches that were recently included in iproute2 branch net-next are not visible anymore on kernel.org. It seems that the branch has been overridden (note the forced update when I've fetched it): $ git fetch remote: Counting objects: 65, done. remote: Compressing objects: 100%

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

Le 26/05/2015 12:53, Alexander Holler a écrit : Am 25.05.2015 um 15:09 schrieb Nicolas Dichtel: [snip] Hmm, sounds like we're talking in different rooms about the same thing in regard to the dump. ;) I just wanted to explain why I think this series misses the (extended) dump which includes

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

Le 22/05/2015 22:50, Alexander Holler a écrit : Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: So I am dense. I have read through the patches and I don't see where you tag packets from other network namespaces with a network namespace id. Me too, I've recently written a little tool

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

Le 25/05/2015 12:55, Alexander Holler a écrit : Am 25.05.2015 um 09:45 schrieb Nicolas Dichtel: Le 22/05/2015 22:50, Alexander Holler a écrit : First I think if NETLINK_LISTEN_ALL_NSID is enabled, a dump of the interfaces through RTM_GETLINK together with NLM_F_DUMP and NLM_F_REQUEST should

Re: [PATCH 2/6] net: Add a struct net parameter to sock_create_kern

Le 12/05/2015 13:48, David Laight a écrit : From: Eric W. Biederman Sent: 12 May 2015 09:55 On May 12, 2015 3:24:11 AM CDT, David Laight david.lai...@aculab.com wrote: ... Wouldn't it involve far less churn to add a new function that uses a non-default namespace? The goal is comprehensible

Re: [PATCH net] rtnl: don't send rtnl msg for unregistered iface

Le 11/05/2015 18:04, Nicolas Dichtel a écrit : Le 11/05/2015 17:37, Jiri Pirko a écrit : [snip] I don't think this is the correct way to fix this. How ifindex can be 0 here? Ifindex is set in register_netdevice and looking at bond_create, I don't see any call to __bond_opt_set before

[RFC PATCH net 4/4] netlink: add a flags field in the cb structure

a dump sends this NLMSG_DONE message. Let's set this flag directly into the dump, hence people won't copy and paste NLM_F_MULTI. Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- include/linux/netlink.h | 1 + net/core/rtnetlink.c | 9 - net/netlink/af_netlink.c | 1 + 3 files

[PATCH net 0/3] netlink: fix wrong use of the flag NLM_F_MULTI

The first three patches fix a wrong use of this flag. Because it's not the first time that this kind of bug happens, it could be good to find something to help people. The only idea that I have is in the last patch. It's just an example, if people agrees on it, I will update all users and

[PATCH net 1/3] bridge/mdb: remove wrong use of NLM_F_MULTI

...@networkplumber.org CC: bri...@lists.linux-foundation.org Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- net/bridge/br_mdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index 409608960899..e29ad70b3000 100644 --- a/net/bridge

[PATCH net 2/3] bridge/nl: remove wrong use of NLM_F_MULTI

: Scott Feldman sfel...@gmail.com CC: Stephen Hemminger step...@networkplumber.org CC: bri...@lists.linux-foundation.org Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- drivers/net/ethernet/emulex/benet/be_main.c | 5 +++-- drivers/net/ethernet/intel/i40e/i40e_main.c | 7

[PATCH net 3/3] tipc: remove wrong use of NLM_F_MULTI

api) Fixes: 46f15c6794fb (tipc: add media get/dump to new netlink api) CC: Richard Alpe richard.a...@ericsson.com CC: Jon Maloy jon.ma...@ericsson.com CC: Ying Xue ying@windriver.com CC: tipc-discuss...@lists.sourceforge.net Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- net/tipc

[PATCH v2 iproute2 1/3] tc: fix compilation warning on 32bits arch

The warning was: m_simple.c: In function ‘parse_simple’: m_simple.c:142:4: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘size_t’ [-Wformat] Useful to be able to compile with -Werror. Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- v2: use %zu

[PATCH v2 iproute2 2/3] libnamespaces: fix warning about syscall()

The warning was: In file included from namespace.c:14:0: ../include/namespace.h: In function ‘setns’: ../include/namespace.h:37:2: warning: implicit declaration of function ‘syscall’ [-Wimplicit-function-declaration] Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- include

[PATCH v2 iproute2 3/3] mroute: remove invalid check against NLM_F_MULTI

This flag is only for the netlink protocol (multi-part messages), no reason to reject messages without it. Note that this flag was removed by the following kernel patches (v3.14) 65886f439ab0 ipmr: fix mfc notification flags f518338b1603 ip6mr: fix mfc notification flags Signed-off-by: Nicolas

[PATCH iproute2 1/3] tc: fix compilation warning on 32bits arch

The warning was: m_simple.c: In function ‘parse_simple’: m_simple.c:142:4: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘size_t’ [-Wformat] Useful to be able to compile with -Werror. Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- tc

[PATCH iproute2 2/3] libnamespaces: fix warning about syscall()

The warning was: In file included from namespace.c:14:0: ../include/namespace.h: In function ‘setns’: ../include/namespace.h:37:2: warning: implicit declaration of function ‘syscall’ [-Wimplicit-function-declaration] Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- include

[PATCH iproute2 3/3] mroute: remove invalid check against NLM_F_MULTI

This flag is only for the netlink protocol (multi-part messages), no reason to reject messages without it. Note that this flag was removed by the following kernel patches (v3.14) 65886f439ab0 ipmr: fix mfc notification flags f518338b1603 ip6mr: fix mfc notification flags Signed-off-by: Nicolas

Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

-by: Honggang Li ho...@redhat.com Signed-off-by: Erez Shitrit ere...@mellanox.com Signed-off-by: Honggang Li ho...@redhat.com Acked-by: Nicolas Dichtel nicolas.dich...@6wind.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More

<    1   2   3   4   5   6   >