Re: [PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

On Fri, Oct 6, 2017 at 11:34 AM, Roopa Prabhu <ro...@cumulusnetworks.com> wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > > This series implements arp and nd suppression in the bridge > driver for ethernet vpns. It implements rfc7432, section 10 > https://

[PATCH net-next v5 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu <ro...@cumulusnet

[PATCH net-next v5 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the ex

[PATCH net-next v5 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/bridge/br_arp_nd_proxy.c | 249 +++ net/bridge

[PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP*

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

On Thu, Oct 5, 2017 at 11:30 AM, Jakub Kicinski <kubak...@wp.pl> wrote: > On Fri, 28 Jul 2017 23:28:26 -0700, Roopa Prabhu wrote: >> On Fri, Jul 28, 2017 at 9:46 AM, Jakub Kicinski <kubak...@wp.pl> wrote: >> > On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote: &

Re: [PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

On Wed, Oct 4, 2017 at 3:52 PM, David Miller <da...@davemloft.net> wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > Date: Tue, 3 Oct 2017 22:12:31 -0700 > >> BR_ARP_PROXY flag but has a few semantic differences to conform > > This should be "BR_PRO

Re: [Bridge] [PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

On Wed, Oct 4, 2017 at 12:21 AM, Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> wrote: > On 2017/10/04 14:12, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to >> su

[PATCH net-next v4 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu <ro...@cumulusnet

[PATCH net-next v4 0/3] bridge: neigh msg proxy and flood suppression support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROX

[PATCH net-next v4 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge

[PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the ex

Re: [PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

On Tue, Oct 3, 2017 at 11:29 AM, Stephen Hemminger <step...@networkplumber.org> wrote: > On Tue, 3 Oct 2017 11:21:14 -0700 > Roopa Prabhu <ro...@cumulusnetworks.com> wrote: > >> diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c >> index 48fb174..7

[PATCH net-next v3 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the ex

[PATCH net-next v3 0/3] bridge: neigh msg proxy and flood suppression support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROX

[PATCH net-next v3 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge

[PATCH net-next v3 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu <ro...@cumulusnet

[PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the ex

[PATCH net-next v2 0/3] bridge: neigh msg proxy and flood suppression support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROX

[PATCH net-next v2 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge

[PATCH net-next v2 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu <ro...@cumulusnet

Re: [PATCH net] net: rtnetlink: fix info leak in RTM_GETSTATS call

Nikolay Aleksandrov <niko...@cumulusnetworks.com> Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com> Thanks Nikolay!.

Re: [PATCH net-next 0/3] bridge: neigh msg proxy and flood suppression support

On Sun, Oct 1, 2017 at 9:36 PM, Roopa Prabhu <ro...@cumulusnetworks.com> wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > > This series implements arp and nd suppression in the bridge > driver for ethernet vpns. It implements rfc7432, section 10 > https://

[PATCH net-next 0/3] bridge: neigh msg proxy and flood suppression support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROX

[PATCH net-next 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the ex

[PATCH net-next 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge

[PATCH net-next 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu <ro...@cumulusnet

Re: [PATCH net-next] net: bridge: add per-port group_fwd_mask with less restrictions

On Fri, Sep 29, 2017 at 3:11 PM, Nikolay Aleksandrov wrote: > On 30/09/17 00:51, Stephen Hemminger wrote: >> On Sat, 30 Sep 2017 00:01:24 +0300 >> Nikolay Aleksandrov wrote: >> >>> On 29/09/17 18:14, Stephen Hemminger wrote: On Wed,

Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation

On Wed, Sep 27, 2017 at 9:08 AM, Amine Kherbouche <amine.kherbou...@6wind.com> wrote: > > > On 09/27/2017 05:36 PM, Roopa Prabhu wrote: >> >> Amine, one small nit here.., if you define mpls_gre_rcv in gre header >> (like you had initially), you could do

Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation

mall nit here.., if you define mpls_gre_rcv in gre header (like you had initially), you could do the below... #if IS_ENABLED(CONFIG_MPLS) mpls_gre_rcv() { /* real func */ } #else mpls_gre_rcv() { kfree_skb(skb) return NET_RX_DROP } #endif and the check in gre_rcv() reduces to if (unlikely(tpi.proto == htons(ETH_P_MPLS_UC))) return mpls_gre_rcv(skb, hdr_len); Which looks much cleaner. Other than that, looks great. pls add my Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com> to your next version. thanks!

Re: [PATCH v2 2/2] ip_tunnel: add mpls over gre encapsulation

On Tue, Sep 26, 2017 at 10:58 AM, Amine Kherbouche <amine.kherbou...@6wind.com> wrote: > Hi Roopa, > > Thanks for the feedback, I have just one question: > > > On 09/26/2017 05:15 PM, Roopa Prabhu wrote: >>> >>> +static int ipgre_tunnel_encap_add_mpls_ops

Re: [PATCH v2 2/2] ip_tunnel: add mpls over gre encapsulation

On Tue, Sep 26, 2017 at 2:22 AM, Amine Kherbouche wrote: > This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel > API. > > Encap: > - Add a new iptunnel type mpls. > - Share tx path: gre type mpls loaded from skb->protocol. > > Decap: > - pull

Re: [PATCH 2/2] ip_tunnel: add mpls over gre encapsulation

On Thu, Sep 21, 2017 at 2:25 AM, Amine Kherbouche wrote: > This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel > API. > > Encap: > - Add a new iptunnel type mpls. > > Decap: > - pull gre hdr and call mpls_forward(). > > Signed-off-by: Amine

Re: [net-next v3] bridge: trigger RTM_NEWLINK when interface is modified by bridge ioctl

On Thu, Sep 21, 2017 at 9:43 AM, David Ahern wrote: > On 9/21/17 4:05 AM, Vincent Bernat wrote: >> Currently, there is a difference in netlink events received when an >> interface is modified through bridge ioctl() or through netlink. This >> patch generates additional events

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

On Thu, Sep 21, 2017 at 3:04 AM, Vincent Bernat wrote: > ❦ 20 septembre 2017 16:21 -0700, Stephen Hemminger > : > >> The one concern is that ports added or removed through ioctl should >> cause same events as doing the same thing via netlink. Some

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

On Sat, Sep 9, 2017 at 11:15 AM, Nikolay Aleksandrov <niko...@cumulusnetworks.com> wrote: > On 09/09/17 20:23, Jamal Hadi Salim wrote: >> On 17-09-09 12:24 PM, Roopa Prabhu wrote: >>> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak <m...@mojatatu.com> wrote: >&

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

On Sat, Sep 9, 2017 at 10:23 AM, Jamal Hadi Salim <j...@mojatatu.com> wrote: > On 17-09-09 12:24 PM, Roopa Prabhu wrote: >> >> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak <m...@mojatatu.com> wrote: >>> >>> Signed-off-by: Roman Mashak <m..

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > bridge/link.c | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/bridge/link.c b/bridge/link.c > index 60200f1..9e4206f 100644

Re: [PATCH v2 rfc 0/8] IGMP snooping for local traffic

On Tue, Sep 5, 2017 at 5:47 PM, Andrew Lunn wrote: >> The third and last issue will be explained in a followup email. > > Hi DSA hackers > > So there is the third issue. It affects just DSA, but it possible > affects all DSA drivers. > > This patchset broken broadcast with the

Re: [RFC net-next] net: sch_clsact: add support for global per-netns classifier mode

On Wed, Sep 6, 2017 at 12:24 AM, Jiri Pirko <j...@resnulli.us> wrote: > Wed, Sep 06, 2017 at 06:04:17AM CEST, ro...@cumulusnetworks.com wrote: >>On Tue, Sep 5, 2017 at 3:45 PM, Daniel Borkmann <dan...@iogearbox.net> wrote: >>> On 09/06/2017 12:01 AM, Roopa Prabhu

Re: [RFC net-next] net: sch_clsact: add support for global per-netns classifier mode

On Tue, Sep 5, 2017 at 3:25 PM, Jamal Hadi Salim <j...@mojatatu.com> wrote: > On 17-09-05 06:01 PM, Roopa Prabhu wrote: > >> >> yes, like Nikolay says we have been discussing this as well. Nikolay's >> patch is a cleaver and most importantly non-invasive >> way

Re: [RFC net-next] net: sch_clsact: add support for global per-netns classifier mode

On Tue, Sep 5, 2017 at 3:45 PM, Daniel Borkmann <dan...@iogearbox.net> wrote: > On 09/06/2017 12:01 AM, Roopa Prabhu wrote: >> >> On Tue, Sep 5, 2017 at 11:18 AM, Cong Wang <xiyou.wangc...@gmail.com> >> wrote: >>> >>> On Tue, Se

Re: [RFC net-next] net: sch_clsact: add support for global per-netns classifier mode

On Tue, Sep 5, 2017 at 11:18 AM, Cong Wang wrote: > On Tue, Sep 5, 2017 at 5:48 AM, Nikolay Aleksandrov > wrote: >> Hi all, >> This RFC adds a new mode for clsact which designates a device's egress >> classifier as global per netns. The

Re: [RFC net-next] net: sch_clsact: add support for global per-netns classifier mode

On Tue, Sep 5, 2017 at 7:07 AM, Jiri Pirko wrote: > Tue, Sep 05, 2017 at 02:48:21PM CEST, niko...@cumulusnetworks.com wrote: >>Hi all, >>This RFC adds a new mode for clsact which designates a device's egress >>classifier as global per netns. The packets that are not classified

Re: [PATCH net-next] bridge: add tracepoint in br_fdb_update

On Thu, Aug 31, 2017 at 5:38 AM, Jesper Dangaard Brouer <bro...@redhat.com> wrote: > On Wed, 30 Aug 2017 22:18:13 -0700 > Roopa Prabhu <ro...@cumulusnetworks.com> wrote: > >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> This extends bridge fdb t

[PATCH net-next] bridge: add tracepoint in br_fdb_update

From: Roopa Prabhu <ro...@cumulusnetworks.com> This extends bridge fdb table tracepoints to also cover learned fdb entries in the br_fdb_update path. Note that unlike other tracepoints I have moved this to when the fdb is modified because this is in the datapath and can generate a lot of

[PATCH net-next v3] bridge: fdb add and delete tracepoints

From: Roopa Prabhu <ro...@cumulusnetworks.com> A few useful tracepoints to trace bridge forwarding database updates. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- v2: address comments from florian v3: remove stray character '=' in print (pointed out by florian) i

Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints

On Tue, Aug 29, 2017 at 9:46 AM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 08/28/2017 09:22 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> A few useful tracepoints to trace bridge forwarding >> database updates

Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints

On Tue, Aug 29, 2017 at 6:36 AM, Andrew Lunn <and...@lunn.ch> wrote: > On Mon, Aug 28, 2017 at 09:22:48PM -0700, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> A few useful tracepoints to trace bridge forwarding >> database

[PATCH net-next v2] bridge: fdb add and delete tracepoints

From: Roopa Prabhu <ro...@cumulusnetworks.com> A few useful tracepoints to trace bridge forwarding database updates. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- v2 - address comments from Florian include/trace/events/bri

Re: mlxsw and rtnl lock

On Sat, Aug 26, 2017 at 10:04 AM, Ido Schimmel wrote: > On Fri, Aug 25, 2017 at 01:26:07PM -0700, David Ahern wrote: >> Jiri / Ido: >> >> [snip] > > Regarding the silent abort, that's intentional. You can look at the same > code in v4.9 - when the chain was still blocking - and

Re: [PATCH net-next] bridge: fdb add and delete tracepoints

On Sun, Aug 27, 2017 at 7:11 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 08/27/2017 02:33 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> Tracepoints to trace bridge forwarding database updates. > > Thanks for ad

Re: [PATCH net-next] bridge: fdb add and delete tracepoints

On Sun, Aug 27, 2017 at 7:11 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 08/27/2017 02:33 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> Tracepoints to trace bridge forwarding database updates. > > Thanks for ad

[PATCH net-next] bridge: fdb add and delete tracepoints

From: Roopa Prabhu <ro...@cumulusnetworks.com> Tracepoints to trace bridge forwarding database updates. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- include/trace/events/bridge.h | 98 +++ net/bridge/br_fdb.c | 7 ++

[PATCH net] bridge: check for null fdb->dst before notifying switchdev drivers

From: Roopa Prabhu <ro...@cumulusnetworks.com> current switchdev drivers dont seem to support offloading fdb entries pointing to the bridge device which have fdb->dst not set to any port. This patch adds a NULL fdb->dst check in the switchdev notifier code. This patch fixes the be

Re: [RFC net-next v2] bridge lwtunnel, VPLS & NVGRE

BSD >> VPLS support, I haven't wired that up to run against Linux / this >> patchset yet. > > Same as before (API didn't change). > >> The patchset needs a lot of polishing (yes I left my TODO notes in the >> commit messages), for now my primary concern is overall desi

[PATCH net v2] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set

From: Roopa Prabhu <ro...@cumulusnetworks.com> Syzkaller hit 'general protection fault in fib_dump_info' bug on commit 4.13-rc5.. Guilty file: net/ipv4/fib_semantics.c kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN Modules

Re: [PATCH 1/2] mpls: add handlers

On Tue, Aug 15, 2017 at 2:37 AM, David Lamparter wrote: [snip] > I think the reverse is the better option, removing the vpls device > information and just going with the route table. My approach to this > would be to add a new netlink route attribute "RTA_VPLS" which >

Re: [PATCH net] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set

On Tue, Aug 15, 2017 at 7:56 PM, David Ahern <d...@cumulusnetworks.com> wrote: > On 8/15/17 8:50 PM, Roopa Prabhu wrote: >> diff --git a/net/ipv4/route.c b/net/ipv4/route.c >> index 7effa62..49a018f 100644 >> --- a/net/ipv4/route.c >> +++ b/net/ipv4/route.c >

[PATCH net] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set

From: Roopa Prabhu <ro...@cumulusnetworks.com> Syzkaller hit 'general protection fault in fib_dump_info' bug on commit 4.13-rc5.. Guilty file: net/ipv4/fib_semantics.c kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP

Re: general protection fault in fib_dump_info

On Tue, Aug 15, 2017 at 5:05 AM, Florian Westphal <f...@strlen.de> wrote: > idaifish <idaif...@gmail.com> wrote: >> Syzkaller hit 'general protection fault in fib_dump_info' bug on >> commit 4.13-rc5.. > > CC Roopa > >> Guilty file: net/ipv4/fib_semantics.

Re: [PATCH 1/2] mpls: add handlers

On Sat, Aug 12, 2017 at 6:35 AM, Amine Kherbouche <amine.kherbou...@6wind.com> wrote: > > > On 11/08/2017 16:37, Roopa Prabhu wrote: >> >> On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter <equi...@diac24.net> >> wrote: >>> >>> On Thu,

Re: [PATCH 2/2] drivers: add vpls support

On Sat, Aug 12, 2017 at 6:40 AM, Amine Kherbouche <amine.kherbou...@6wind.com> wrote: > > > On 11/08/2017 17:14, Roopa Prabhu wrote: >> >> On Fri, Aug 11, 2017 at 5:55 AM, David Lamparter <equi...@diac24.net> >> wrote: >>> >>> On Thu,

Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting

On Fri, Aug 11, 2017 at 9:39 AM, Jiri Benc <jb...@redhat.com> wrote: > On Fri, 11 Aug 2017 09:19:34 -0700, Roopa Prabhu wrote: >> > if (tb[IFLA_ADDRESS]) { >> > if (nla_len(tb[IFLA_ADDRESS]) != ETH_ALEN) { >> > -

Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting

On Thu, Aug 10, 2017 at 2:16 PM, Girish Moodalbail wrote: > The kernel log is not where users expect error messages for netlink > requests; as we have extended acks now, we can replace pr_debug() with > NL_SET_ERR_MSG_ATTR(). > > Signed-off-by: Matthias Schiffer

Re: [PATCH 2/2] drivers: add vpls support

On Fri, Aug 11, 2017 at 5:55 AM, David Lamparter wrote: > On Thu, Aug 10, 2017 at 10:28:37PM +0200, Amine Kherbouche wrote: >> This commit introduces the support of VPLS virtual device, that allows >> performing L2VPN multipoint to multipoint communication over MPLS PSN. >>

Re: [PATCH 1/2] mpls: add handlers

On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter wrote: > On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote: >> Mpls handler allows creation/deletion of mpls routes without using >> rtnetlink. When an incoming mpls packet matches this route, the saved >>

Re: Driver profiles RFC

On Wed, Aug 9, 2017 at 4:43 AM, Arkadi Sharshevsky <arka...@mellanox.com> wrote: > > > On 08/08/2017 07:08 PM, Roopa Prabhu wrote: >> On Tue, Aug 8, 2017 at 6:15 AM, Arkadi Sharshevsky <arka...@mellanox.com> >> wrote: >>> [snip] >>> User Co

Re: Driver profiles RFC

On Tue, Aug 8, 2017 at 6:15 AM, Arkadi Sharshevsky wrote: > Drivers may require driver specific information during the init stage. > For example, memory based shared resource which should be segmented for > different ASIC processes, such as FDB and LPM lookups. > > The

[PATCH net-next v2] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL

From: Roopa Prabhu <ro...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- v2 - fixed a incorrect replace net/core/lwtunnel.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/net/core/lwtunnel.

Re: [PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL

On Fri, Aug 4, 2017 at 3:25 PM, Andrew Lunn <and...@lunn.ch> wrote: > On Fri, Aug 04, 2017 at 03:23:37PM -0700, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com&

[PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL

From: Roopa Prabhu <ro...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/core/lwtunnel.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c index d9cb353..86

Re: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

On Mon, Jul 31, 2017 at 5:40 PM, Amritha Nambiar wrote: > The Mirred/redirect action is extended to accept a traffic > class on the device in addition to the device's ifindex. > > Usage: mirred > > Example: > # tc qdisc add dev eth0 ingress > > # tc filter add dev

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

On Fri, Jul 28, 2017 at 10:29 AM, Andrew Lunn <and...@lunn.ch> wrote: > On Fri, Jul 28, 2017 at 09:46:20AM -0700, Jakub Kicinski wrote: >> On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote: >> > On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski <kubak...@wp.pl> wro

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

On Fri, Jul 28, 2017 at 9:46 AM, Jakub Kicinski <kubak...@wp.pl> wrote: > On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote: >> On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski <kubak...@wp.pl> wrote: >> > On Thu, 27 Jul 2017 16:47:25 -0700, Roopa Prabhu wrote

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Fri, Jul 28, 2017 at 10:39 AM, David Ahern <dsah...@gmail.com> wrote: > On 7/28/17 11:13 AM, Roopa Prabhu wrote: >> for fibmatch, my original intent was to return with an error code. >> This is similar >> to the ipv4 behavior. One option is to keep the check in the

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Fri, Jul 28, 2017 at 8:10 AM, David Ahern <dsah...@gmail.com> wrote: > On 7/27/17 10:56 PM, Cong Wang wrote: >> On Wed, Jul 26, 2017 at 11:49 AM, David Ahern <dsah...@gmail.com> wrote: >>> On 7/26/17 12:27 PM, Roopa Prabhu wrote: >>>> agr

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski <kubak...@wp.pl> wrote: > On Thu, 27 Jul 2017 16:47:25 -0700, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> Forward Error Correction (FEC) modes i.e Base-R >> and Reed-Solom

[PATCH net-next v2 1/3] net: ethtool: add support for forward error correction modes

-off-by: Dustin Byford <dus...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- include/linux/ethtool.h | 4 include/uapi/linux/ethtool.h | 48 +++- net/core/ethtool.c | 34 +++ 3 file

[PATCH net-next v2 3/3] cxgb4: ethtool forward error correction management support

From: Casey Leedom Signed-off-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 100 + 1 file changed, 100 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c

[PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

From: Roopa Prabhu <ro...@cumulusnetworks.com> Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage support

[PATCH net-next v2 2/3] cxgb4: core hardware/firmware support for Forward Error Correction on a link

From: Casey Leedom Signed-off-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 152 ++--- 1 file changed, 117 insertions(+), 35 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c

Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

get fibmatch 2004::1 > unreachable 2004::/64 dev lo metric 1024 error -113 pref medium > > Fixes: 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib...") > Signed-off-by: Hangbin Liu <liuhang...@gmail.com> > --- Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com>

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Wed, Jul 26, 2017 at 12:00 PM, David Ahern <dsah...@gmail.com> wrote: > On 7/26/17 12:55 PM, Roopa Prabhu wrote: >> On Wed, Jul 26, 2017 at 11:49 AM, David Ahern <dsah...@gmail.com> wrote: >>> On 7/26/17 12:27 PM, Roopa Prabhu wrote: >>>> agr

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Wed, Jul 26, 2017 at 11:49 AM, David Ahern <dsah...@gmail.com> wrote: > On 7/26/17 12:27 PM, Roopa Prabhu wrote: >> agreed...so looks like the check in v3 should be >> >> >> + if ( rt == net->ipv6.ip6_null_entry || >> +(rt->dst.err

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Wed, Jul 26, 2017 at 10:18 AM, David Ahern wrote: > On 7/25/17 1:32 AM, Hangbin Liu wrote: >> On Mon, Jul 24, 2017 at 09:28:07PM -0600, David Ahern wrote: >>> On 7/24/17 6:08 PM, Hangbin Liu wrote: That's why I think we should remove both rt->dst.error and

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

l_entry later. There is not sense > to check the dst.error after get rt. > > Fixes: 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib...") > Signed-off-by: Hangbin Liu <liuhang...@gmail.com> > --- Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com> thanks.

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Fri, Jul 21, 2017 at 2:53 PM, Roopa Prabhu <ro...@cumulusnetworks.com> wrote: > On Fri, Jul 21, 2017 at 11:42 AM, Cong Wang <xiyou.wangc...@gmail.com> wrote: >> On Thu, Jul 20, 2017 at 8:23 AM, Hangbin Liu <liuhang...@gmail.com> wrote: >>> 2017-07-20

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Fri, Jul 21, 2017 at 11:42 AM, Cong Wang wrote: > On Thu, Jul 20, 2017 at 8:23 AM, Hangbin Liu wrote: >> 2017-07-20 23:06 GMT+08:00 Hangbin Liu : +++ b/net/ipv6/route.c @@ -3637,12 +3637,6 @@ static int

[PATCH iproute2 net-next] bridge: this patch adds json support for bridge mdb show

"dev": "br0", "port": "swp2", "grp": "239.0.0.2", "state": "temp", "vid": 1, "timer": " 166.74" },{

[PATCH iproute2 net-next] iproute: extend route get for mpls routes

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch extends route get to support mpls specific route attributes like RTA_NEWDST. Input: RTA_DST - input label RTA_NEWDST - labels in packet for multipath selection By default the getroute handler returns matched nexthop label, via a

[PATCH net] mpls: fix uninitialized in_label var warning in mpls_getroute

From: Roopa Prabhu <ro...@cumulusnetworks.com> Fix the below warning generated by static checker: net/mpls/af_mpls.c:2111 mpls_getroute() error: uninitialized symbol 'in_label'." Fixes: 397fc9e5cefe ("mpls: route get support") Reported-by: Dan Carpenter <dan.carp

Re: [PATCH net] net: ipv6: Compare lwstate in detecting duplicate nexthops

vid Ahern <dsah...@gmail.com> > --- Reported-by: João Taveira Araújo <joao.tave...@gmail.com> Reported-by: Lennert Buytenhek <buyt...@wantstofly.org> Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com>

[PATCH net] mpls: fix rtm policy in mpls_getroute

From: Roopa Prabhu <ro...@cumulusnetworks.com> fix rtm policy name typo in mpls_getroute and also remove export of rtm_ipv4_policy Fixes: 397fc9e5cefe ("mpls: route get support") Reported-by: David S. Miller <da...@davemloft.net> Signed-off-by: Roopa Prabhu <ro...@cumul

Re: [PATCH] ipv4: Export rtm_ipv4_policy.

On Tue, Jul 4, 2017 at 7:18 AM, David Miller wrote: > > The MPLS code now needs it. > > Fixes: 397fc9e5cefe ("mpls: route get support") > Signed-off-by: David S. Miller > --- Sorry david. Just saw this. It was a cut-copy-paste error. It should be the

[PATCH net-next] mpls: route get support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds RTM_GETROUTE doit handler for mpls routes. Input: RTA_DST - input label RTA_NEWDST - labels in packet for multipath selection By default the getroute handler returns matched nexthop label, via and oif With RTM_F_FIB_MATC

[PATCH net-next] bridge: allow ext learned entries to change ports

learned FBD on offloaded device") Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/bridge/br_fdb.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/net/bridge/br

[PATCH net-next 3/3] cxgb4: ethtool forward error correction management support

From: Casey Leedom Signed-off-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 100 + 1 file changed, 100 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c

[PATCH net-next 1/3] net: ethtool: add support for forward error correction modes

From: Vidya Sagar Ravipati Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported

[PATCH net-next 0/3] ethtool: support for forward error correction mode setting on a link

From: Roopa Prabhu <ro...@cumulusnetworks.com> Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage support

<    1   2   3   4   5   6   7   8   9   >