[PATCH net-next v4 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 186

[PATCH net-next v4 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROXY flag but has a few semantic

[PATCH net-next v4 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge/br_device.c | 11 ++ net/bridge/br_input.c| 10

Re: [Bridge] [PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-04 Thread Roopa Prabhu
On Wed, Oct 4, 2017 at 12:21 AM, Toshiaki Makita wrote: > On 2017/10/04 14:12, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to >> suppress arp and nd flood on bridge ports. It implements >> rfc7432, sect

Re: [PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-05 Thread Roopa Prabhu
On Wed, Oct 4, 2017 at 3:52 PM, David Miller wrote: > From: Roopa Prabhu > Date: Tue, 3 Oct 2017 22:12:31 -0700 > >> BR_ARP_PROXY flag but has a few semantic differences to conform > > This should be "BR_PROXYARP". ack, will fix. > > Otherwise this ser

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-10-06 Thread Roopa Prabhu
On Thu, Oct 5, 2017 at 11:30 AM, Jakub Kicinski wrote: > On Fri, 28 Jul 2017 23:28:26 -0700, Roopa Prabhu wrote: >> On Fri, Jul 28, 2017 at 9:46 AM, Jakub Kicinski wrote: >> > On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote: >> >> On Thu, Jul 27, 2017 at

[PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few semantic

[PATCH net-next v5 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 249 +++ net/bridge/br_device.c | 11 ++ net/bridge/br_input.c| 11

[PATCH net-next v5 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 188

[PATCH net-next v5 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few

Re: [PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread Roopa Prabhu
On Fri, Oct 6, 2017 at 11:34 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This series implements arp and nd suppression in the bridge > driver for ethernet vpns. It implements rfc7432, section 10 > https://tools.ietf.org/html/rfc7432#section-10 > for ethernet VPN deployme

[PATCH net-next v6 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few

[PATCH net-next v6 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few semantic

[PATCH net-next v6 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 188

[PATCH net-next v6 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 249 +++ net/bridge/br_device.c | 11 ++ net/bridge/br_input.c| 11

[PATCH iproute2] iplink: new option to set neigh suppression on a bridge port

2017-10-09 Thread Roopa Prabhu
From: Roopa Prabhu neigh suppression can be used to suppress arp and nd flood to bridge ports. It maps to the recently added kernel support for bridge port flag IFLA_BRPORT_NEIGH_SUPPRESS. Signed-off-by: Roopa Prabhu --- bridge/link.c| 13 + ip/iplink_bridge_slave.c

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: > Adds a devlink command for getting & setting device configuration > parameters, and enumerates a bunch of those parameters as devlink > attributes. Also introduces an attribute that can be set by a > driver to indicate that the config change doe

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: >>> Adds a devlink command for getting & setting device configuration >>> parameters, and enumerates a bunch of those par

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 7:45 AM, Steve Lin wrote: > Hi Roopa, > > The attributes added in this patchset are not really the same type as > ethtool - these are more device configuration type attributes. The > speeds you saw, for example, affect the pre-OS [i.e. PXE boot time] > c

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 8:04 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 04:46:24PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: >>> Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulusnetworks.com wrote: On Thu, Oct 12, 2017 at 6:34 AM, Steve Li

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 8:43 AM, Florian Fainelli wrote: > On October 12, 2017 8:04:19 AM PDT, Jiri Pirko wrote: >>Thu, Oct 12, 2017 at 04:46:24PM CEST, ro...@cumulusnetworks.com wrote: >>>On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulus

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 12:20 PM, Florian Fainelli wrote: > On 10/12/2017 12:06 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Thu, 12 Oct 2017 08:43:59 -0700 >> >>> Once we move ethtool (or however we name its successor) over to >>> netlink there is an opportunity for accessing objec

Re: Ethtool question

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 2:45 PM, Ben Greear wrote: > On 10/11/2017 01:49 PM, David Miller wrote: >> >> From: "John W. Linville" >> Date: Wed, 11 Oct 2017 16:44:07 -0400 >> >>> On Wed, Oct 11, 2017 at 09:51:56AM -0700, Ben Greear wrote: I noticed today that setting some ethtool settings

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-13 Thread Roopa Prabhu
On Fri, Oct 13, 2017 at 12:11 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 11:53:56PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 12:20 PM, Florian Fainelli >>wrote: >>> On 10/12/2017 12:06 PM, David Miller wrote: From: Florian Fainelli Date: Thu, 12 Oct 2017 08:4

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-09 Thread Roopa Prabhu
On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote: > Signed-off-by: Roman Mashak > --- > bridge/link.c | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/bridge/link.c b/bridge/link.c > index 60200f1..9e4206f 100644 > --- a/bridge/link.c > +++ b/bridge/li

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-09 Thread Roopa Prabhu
On Sat, Sep 9, 2017 at 10:23 AM, Jamal Hadi Salim wrote: > On 17-09-09 12:24 PM, Roopa Prabhu wrote: >> >> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote: >>> >>> Signed-off-by: Roman Mashak >>> --- >>> bridge/link.c | 16 +++

Re: [PATCH iproute2 3/3] bridge: request vlans along with link information

2017-09-09 Thread Roopa Prabhu
On Sat, Sep 9, 2017 at 11:15 AM, Nikolay Aleksandrov wrote: > On 09/09/17 20:23, Jamal Hadi Salim wrote: >> On 17-09-09 12:24 PM, Roopa Prabhu wrote: >>> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote: >>>> Signed-off-by: Roman Mashak >>>> --- >

Re: [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-09-21 Thread Roopa Prabhu
On Thu, Sep 21, 2017 at 3:04 AM, Vincent Bernat wrote: > ❦ 20 septembre 2017 16:21 -0700, Stephen Hemminger > : > >> The one concern is that ports added or removed through ioctl should >> cause same events as doing the same thing via netlink. Some users use >> brctl (ioctl) and others use newer

Re: [net-next v3] bridge: trigger RTM_NEWLINK when interface is modified by bridge ioctl

2017-09-21 Thread Roopa Prabhu
On Thu, Sep 21, 2017 at 9:43 AM, David Ahern wrote: > On 9/21/17 4:05 AM, Vincent Bernat wrote: >> Currently, there is a difference in netlink events received when an >> interface is modified through bridge ioctl() or through netlink. This >> patch generates additional events when an interface is

Re: [PATCH 2/2] ip_tunnel: add mpls over gre encapsulation

2017-09-21 Thread Roopa Prabhu
On Thu, Sep 21, 2017 at 2:25 AM, Amine Kherbouche wrote: > This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel > API. > > Encap: > - Add a new iptunnel type mpls. > > Decap: > - pull gre hdr and call mpls_forward(). > > Signed-off-by: Amine Kherbouche > --- > include/net/

Re: [PATCH v2 2/2] ip_tunnel: add mpls over gre encapsulation

2017-09-26 Thread Roopa Prabhu
On Tue, Sep 26, 2017 at 2:22 AM, Amine Kherbouche wrote: > This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel > API. > > Encap: > - Add a new iptunnel type mpls. > - Share tx path: gre type mpls loaded from skb->protocol. > > Decap: > - pull gre hdr and call mpls_forward

Re: [PATCH v2 2/2] ip_tunnel: add mpls over gre encapsulation

2017-09-26 Thread Roopa Prabhu
On Tue, Sep 26, 2017 at 10:58 AM, Amine Kherbouche wrote: > Hi Roopa, > > Thanks for the feedback, I have just one question: > > > On 09/26/2017 05:15 PM, Roopa Prabhu wrote: >>> >>> +static int ipgre_tunnel_encap_add_mpls_ops(void) >>> > +

Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation

2017-09-27 Thread Roopa Prabhu
you had initially), you could do the below... #if IS_ENABLED(CONFIG_MPLS) mpls_gre_rcv() { /* real func */ } #else mpls_gre_rcv() { kfree_skb(skb) return NET_RX_DROP } #endif and the check in gre_rcv() reduces to if (unlikely(tpi.proto == htons(ETH_P_MPLS_UC))) return mpls_gre_rcv(skb, hdr_len); Which looks much cleaner. Other than that, looks great. pls add my Acked-by: Roopa Prabhu to your next version. thanks!

Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation

2017-09-27 Thread Roopa Prabhu
On Wed, Sep 27, 2017 at 9:08 AM, Amine Kherbouche wrote: > > > On 09/27/2017 05:36 PM, Roopa Prabhu wrote: >> >> Amine, one small nit here.., if you define mpls_gre_rcv in gre header >> (like you had initially), you could do the below... >> >> #if

Re: [PATCH net-next] net: bridge: add per-port group_fwd_mask with less restrictions

2017-09-29 Thread Roopa Prabhu
On Fri, Sep 29, 2017 at 3:11 PM, Nikolay Aleksandrov wrote: > On 30/09/17 00:51, Stephen Hemminger wrote: >> On Sat, 30 Sep 2017 00:01:24 +0300 >> Nikolay Aleksandrov wrote: >> >>> On 29/09/17 18:14, Stephen Hemminger wrote: On Wed, 27 Sep 2017 16:12:44 +0300 Nikolay Aleksandrov wrote:

[PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL

2017-08-04 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- net/core/lwtunnel.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c index d9cb353..8693ff8 100644 --- a/net/core/lwtunnel.c +++ b/net/core/lwtunnel.c

Re: [PATCH net-next] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL

2017-08-04 Thread Roopa Prabhu
On Fri, Aug 4, 2017 at 3:25 PM, Andrew Lunn wrote: > On Fri, Aug 04, 2017 at 03:23:37PM -0700, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Signed-off-by: Roopa Prabhu >> --- >> net/core/lwtunnel.c | 26 +- >> 1 file

[PATCH net-next v2] lwtunnel: replace EXPORT_SYMBOL with EXPORT_SYMBOL_GPL

2017-08-04 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- v2 - fixed a incorrect replace net/core/lwtunnel.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c index d9cb353..435f35f 100644 --- a/net/core

Re: Driver profiles RFC

2017-08-08 Thread Roopa Prabhu
On Tue, Aug 8, 2017 at 6:15 AM, Arkadi Sharshevsky wrote: > Drivers may require driver specific information during the init stage. > For example, memory based shared resource which should be segmented for > different ASIC processes, such as FDB and LPM lookups. > > The current mlxsw implementation

Re: Driver profiles RFC

2017-08-11 Thread Roopa Prabhu
On Wed, Aug 9, 2017 at 4:43 AM, Arkadi Sharshevsky wrote: > > > On 08/08/2017 07:08 PM, Roopa Prabhu wrote: >> On Tue, Aug 8, 2017 at 6:15 AM, Arkadi Sharshevsky >> wrote: >>> [snip] >>> User Configuration >>> -- >>> Suc

Re: [PATCH 1/2] mpls: add handlers

2017-08-11 Thread Roopa Prabhu
On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter wrote: > On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote: >> Mpls handler allows creation/deletion of mpls routes without using >> rtnetlink. When an incoming mpls packet matches this route, the saved >> function handler is called.

Re: [PATCH 2/2] drivers: add vpls support

2017-08-11 Thread Roopa Prabhu
On Fri, Aug 11, 2017 at 5:55 AM, David Lamparter wrote: > On Thu, Aug 10, 2017 at 10:28:37PM +0200, Amine Kherbouche wrote: >> This commit introduces the support of VPLS virtual device, that allows >> performing L2VPN multipoint to multipoint communication over MPLS PSN. >> >> VPLS device encap r

Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting

2017-08-11 Thread Roopa Prabhu
On Thu, Aug 10, 2017 at 2:16 PM, Girish Moodalbail wrote: > The kernel log is not where users expect error messages for netlink > requests; as we have extended acks now, we can replace pr_debug() with > NL_SET_ERR_MSG_ATTR(). > > Signed-off-by: Matthias Schiffer > Signed-off-by: Girish Moodalbail

Re: [PATCH net-next v2] vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting

2017-08-11 Thread Roopa Prabhu
On Fri, Aug 11, 2017 at 9:39 AM, Jiri Benc wrote: > On Fri, 11 Aug 2017 09:19:34 -0700, Roopa Prabhu wrote: >> > if (tb[IFLA_ADDRESS]) { >> > if (nla_len(tb[IFLA_ADDRESS]) != ETH_ALEN) { >> > - pr_debug("in

Re: [PATCH 2/2] drivers: add vpls support

2017-08-12 Thread Roopa Prabhu
On Sat, Aug 12, 2017 at 6:40 AM, Amine Kherbouche wrote: > > > On 11/08/2017 17:14, Roopa Prabhu wrote: >> >> On Fri, Aug 11, 2017 at 5:55 AM, David Lamparter >> wrote: >>> >>> On Thu, Aug 10, 2017 at 10:28:37PM +0200, Amine Kherbouche wrote: >>

Re: [PATCH 1/2] mpls: add handlers

2017-08-12 Thread Roopa Prabhu
On Sat, Aug 12, 2017 at 6:35 AM, Amine Kherbouche wrote: > > > On 11/08/2017 16:37, Roopa Prabhu wrote: >> >> On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter >> wrote: >>> >>> On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote: >&

Re: general protection fault in fib_dump_info

2017-08-15 Thread Roopa Prabhu
On Tue, Aug 15, 2017 at 5:05 AM, Florian Westphal wrote: > idaifish wrote: >> Syzkaller hit 'general protection fault in fib_dump_info' bug on >> commit 4.13-rc5.. > > CC Roopa > >> Guilty file: net/ipv4/fib_semantics.c >> >> kasan: GPF cou

[PATCH net] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set

2017-08-15 Thread Roopa Prabhu
From: Roopa Prabhu Syzkaller hit 'general protection fault in fib_dump_info' bug on commit 4.13-rc5.. Guilty file: net/ipv4/fib_semantics.c kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN Modules linked in:

Re: [PATCH net] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set

2017-08-15 Thread Roopa Prabhu
On Tue, Aug 15, 2017 at 7:56 PM, David Ahern wrote: > On 8/15/17 8:50 PM, Roopa Prabhu wrote: >> diff --git a/net/ipv4/route.c b/net/ipv4/route.c >> index 7effa62..49a018f 100644 >> --- a/net/ipv4/route.c >> +++ b/net/ipv4/route.c >> @@ -2763,14 +2763,21 @@ st

Re: [PATCH 1/2] mpls: add handlers

2017-08-15 Thread Roopa Prabhu
On Tue, Aug 15, 2017 at 2:37 AM, David Lamparter wrote: [snip] > I think the reverse is the better option, removing the vpls device > information and just going with the route table. My approach to this > would be to add a new netlink route attribute "RTA_VPLS" which > identifies the vpls devic

[PATCH net v2] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set

2017-08-16 Thread Roopa Prabhu
From: Roopa Prabhu Syzkaller hit 'general protection fault in fib_dump_info' bug on commit 4.13-rc5.. Guilty file: net/ipv4/fib_semantics.c kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN Modules linked in: CPU: 0 PID:

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-21 Thread Roopa Prabhu
On Fri, Jul 21, 2017 at 11:42 AM, Cong Wang wrote: > On Thu, Jul 20, 2017 at 8:23 AM, Hangbin Liu wrote: >> 2017-07-20 23:06 GMT+08:00 Hangbin Liu : +++ b/net/ipv6/route.c @@ -3637,12 +3637,6 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh,

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-22 Thread Roopa Prabhu
On Fri, Jul 21, 2017 at 2:53 PM, Roopa Prabhu wrote: > On Fri, Jul 21, 2017 at 11:42 AM, Cong Wang wrote: >> On Thu, Jul 20, 2017 at 8:23 AM, Hangbin Liu wrote: >>> 2017-07-20 23:06 GMT+08:00 Hangbin Liu : >>>>> +++ b/net/ipv6/route.c >>>>> @@ -

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-22 Thread Roopa Prabhu
nse > to check the dst.error after get rt. > > Fixes: 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib...") > Signed-off-by: Hangbin Liu > --- Acked-by: Roopa Prabhu thanks.

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-26 Thread Roopa Prabhu
On Wed, Jul 26, 2017 at 10:18 AM, David Ahern wrote: > On 7/25/17 1:32 AM, Hangbin Liu wrote: >> On Mon, Jul 24, 2017 at 09:28:07PM -0600, David Ahern wrote: >>> On 7/24/17 6:08 PM, Hangbin Liu wrote: That's why I think we should remove both rt->dst.error and ip6_null_entry check in inet

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-26 Thread Roopa Prabhu
On Wed, Jul 26, 2017 at 11:49 AM, David Ahern wrote: > On 7/26/17 12:27 PM, Roopa Prabhu wrote: >> agreed...so looks like the check in v3 should be >> >> >> + if ( rt == net->ipv6.ip6_null_entry || >> +(rt->dst.error &am

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-26 Thread Roopa Prabhu
On Wed, Jul 26, 2017 at 12:00 PM, David Ahern wrote: > On 7/26/17 12:55 PM, Roopa Prabhu wrote: >> On Wed, Jul 26, 2017 at 11:49 AM, David Ahern wrote: >>> On 7/26/17 12:27 PM, Roopa Prabhu wrote: >>>> agreed...so looks like the check in v3 should be >>>&

Re: [PATCHv4 net] ipv6: no need to check rt->dst.error when get route info

2017-07-27 Thread Roopa Prabhu
t; unreachable 2004::/64 dev lo metric 1024 error -113 pref medium > > Fixes: 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib...") > Signed-off-by: Hangbin Liu > --- Acked-by: Roopa Prabhu

[PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-07-27 Thread Roopa Prabhu
From: Roopa Prabhu Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported FEC modes and the lack of FEC

[PATCH net-next v2 2/3] cxgb4: core hardware/firmware support for Forward Error Correction on a link

2017-07-27 Thread Roopa Prabhu
From: Casey Leedom Signed-off-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 152 ++--- 1 file changed, 117 insertions(+), 35 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index db41

[PATCH net-next v2 3/3] cxgb4: ethtool forward error correction management support

2017-07-27 Thread Roopa Prabhu
From: Casey Leedom Signed-off-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 100 + 1 file changed, 100 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c index 26eb0

[PATCH net-next v2 1/3] net: ethtool: add support for forward error correction modes

2017-07-27 Thread Roopa Prabhu
FEC modes i.e. None (No FEC mode), RS, BaseR/FC are defined so that users can configure these fec modes for supported and advertising fields as part of link autonegotiation. Signed-off-by: Vidya Sagar Ravipati Signed-off-by: Dustin Byford Signed-off-by: Roopa Prabhu --- include/linux

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-07-28 Thread Roopa Prabhu
On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski wrote: > On Thu, 27 Jul 2017 16:47:25 -0700, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Forward Error Correction (FEC) modes i.e Base-R >> and Reed-Solomon modes are introduced in 25G/40G/100G standards >> for

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-28 Thread Roopa Prabhu
On Fri, Jul 28, 2017 at 8:10 AM, David Ahern wrote: > On 7/27/17 10:56 PM, Cong Wang wrote: >> On Wed, Jul 26, 2017 at 11:49 AM, David Ahern wrote: >>> On 7/26/17 12:27 PM, Roopa Prabhu wrote: >>>> agreed...so looks like the check in v3 should be >>>&

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

2017-07-28 Thread Roopa Prabhu
On Fri, Jul 28, 2017 at 10:39 AM, David Ahern wrote: > On 7/28/17 11:13 AM, Roopa Prabhu wrote: >> for fibmatch, my original intent was to return with an error code. >> This is similar >> to the ipv4 behavior. One option is to keep the check in there and put >> the &#x

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-07-28 Thread Roopa Prabhu
On Fri, Jul 28, 2017 at 9:46 AM, Jakub Kicinski wrote: > On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote: >> On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski wrote: >> > On Thu, 27 Jul 2017 16:47:25 -0700, Roopa Prabhu wrote: >> >> From: Roopa Prabhu >&g

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-07-28 Thread Roopa Prabhu
On Fri, Jul 28, 2017 at 10:29 AM, Andrew Lunn wrote: > On Fri, Jul 28, 2017 at 09:46:20AM -0700, Jakub Kicinski wrote: >> On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote: >> > On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski wrote: >> > > On Thu, 27 Jul 201

Re: [PATCH RFC, iproute2] tc/mirred: Extend the mirred/redirect action to accept additional traffic class parameter

2017-08-02 Thread Roopa Prabhu
On Mon, Jul 31, 2017 at 5:40 PM, Amritha Nambiar wrote: > The Mirred/redirect action is extended to accept a traffic > class on the device in addition to the device's ifindex. > > Usage: mirred > > Example: > # tc qdisc add dev eth0 ingress > > # tc filter add dev eth0 protocol ip parent :

[PATCH net-next 0/3] ethtool: support for forward error correction mode setting on a link

2017-06-24 Thread Roopa Prabhu
From: Roopa Prabhu Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported FEC modes and the lack of FEC

[PATCH net-next 2/3] cxgb4: core hardware/firmware support for Forward Error Correction on a link

2017-06-24 Thread Roopa Prabhu
From: Casey Leedom Signed-off-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 152 ++--- 1 file changed, 117 insertions(+), 35 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index d5e3

[PATCH net-next 1/3] net: ethtool: add support for forward error correction modes

2017-06-24 Thread Roopa Prabhu
From: Vidya Sagar Ravipati Forward Error Correction (FEC) modes i.e Base-R and Reed-Solomon modes are introduced in 25G/40G/100G standards for providing good BER at high speeds. Various networking devices which support 25G/40G/100G provides ability to manage supported FEC modes and the lack of FE

[PATCH net-next 3/3] cxgb4: ethtool forward error correction management support

2017-06-24 Thread Roopa Prabhu
From: Casey Leedom Signed-off-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 100 + 1 file changed, 100 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c index e9bab

[PATCH net-next] bridge: allow ext learned entries to change ports

2017-07-03 Thread Roopa Prabhu
ned-off-by: Nikolay Aleksandrov Signed-off-by: Roopa Prabhu --- net/bridge/br_fdb.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index fef7872..a5e4a73 100644 --- a/net/bridge/br_fdb.c +++ b/net/bridg

[PATCH net-next] mpls: route get support

2017-07-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds RTM_GETROUTE doit handler for mpls routes. Input: RTA_DST - input label RTA_NEWDST - labels in packet for multipath selection By default the getroute handler returns matched nexthop label, via and oif With RTM_F_FIB_MATCH flag, full matched route is returned

Re: [PATCH] ipv4: Export rtm_ipv4_policy.

2017-07-04 Thread Roopa Prabhu
On Tue, Jul 4, 2017 at 7:18 AM, David Miller wrote: > > The MPLS code now needs it. > > Fixes: 397fc9e5cefe ("mpls: route get support") > Signed-off-by: David S. Miller > --- Sorry david. Just saw this. It was a cut-copy-paste error. It should be the below. I can also submit a patch. Thanks. di

[PATCH net] mpls: fix rtm policy in mpls_getroute

2017-07-04 Thread Roopa Prabhu
From: Roopa Prabhu fix rtm policy name typo in mpls_getroute and also remove export of rtm_ipv4_policy Fixes: 397fc9e5cefe ("mpls: route get support") Reported-by: David S. Miller Signed-off-by: Roopa Prabhu --- David, since the rtm_ipv4_policy export is not in net yet and assumi

Re: [PATCH net] net: ipv6: Compare lwstate in detecting duplicate nexthops

2017-07-05 Thread Roopa Prabhu
orted-by: João Taveira Araújo Reported-by: Lennert Buytenhek Acked-by: Roopa Prabhu

[PATCH net] mpls: fix uninitialized in_label var warning in mpls_getroute

2017-07-07 Thread Roopa Prabhu
From: Roopa Prabhu Fix the below warning generated by static checker: net/mpls/af_mpls.c:2111 mpls_getroute() error: uninitialized symbol 'in_label'." Fixes: 397fc9e5cefe ("mpls: route get support") Reported-by: Dan Carpenter Signed-off-by: Roopa Prabhu ---

[PATCH iproute2 net-next] iproute: extend route get for mpls routes

2017-07-07 Thread Roopa Prabhu
From: Roopa Prabhu This patch extends route get to support mpls specific route attributes like RTA_NEWDST. Input: RTA_DST - input label RTA_NEWDST - labels in packet for multipath selection By default the getroute handler returns matched nexthop label, via and oif With fibmatch keyword

[PATCH iproute2 net-next] bridge: this patch adds json support for bridge mdb show

2017-07-07 Thread Roopa Prabhu
", "port": "swp2", "grp": "239.0.0.2", "state": "temp", "vid": 1, "timer": " 166.74" },{

Re: [PATCH] net: bridge: add max_fdb_count

2017-11-15 Thread Roopa Prabhu
On Wed, Nov 15, 2017 at 10:13 PM, Toshiaki Makita wrote: > On 2017/11/16 13:54, Sarah Newman wrote: >> On 11/15/2017 08:05 PM, Toshiaki Makita wrote: >>> On 2017/11/16 11:25, Andrew Lunn wrote: > Also what do the vendors using bridge for L2 offload to switch think? The Marvell L2 swi

Re: [PATCH net] net: bridge: fix returning of vlan range op errors

2017-10-19 Thread Roopa Prabhu
er vlan dst_metadata netlink support") > Signed-off-by: Nikolay Aleksandrov > --- Acked-by: Roopa Prabhu thanks

[PATCH iproute2] bridge: fdb: print NDA_SRC_VNI if available

2017-10-26 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- bridge/fdb.c | 9 + 1 file changed, 9 insertions(+) diff --git a/bridge/fdb.c b/bridge/fdb.c index e5cebf9..081233a 100644 --- a/bridge/fdb.c +++ b/bridge/fdb.c @@ -204,6 +204,15 @@ int print_fdb(const struct sockaddr_nl *who, struct

[PATCH iproute2 net-next 0/2] bridge: support for vlan to tunnel mapping

2017-10-26 Thread Roopa Prabhu
From: Roopa Prabhu This series adds the required options to iplink and bridge commands to enable per vlan tunnel info on a bridge port provided by netlink attributes IFLA_BRPORT_VLAN_TUNNEL (flag) and IFLA_BRIDGE_VLAN_TUNNEL_INFO enable vlan-tunnel mapping on a bridge port: $ip link set dev

[PATCH iproute2 net-next 2/2] bridge: vlan: support for per vlan tunnel info

2017-10-26 Thread Roopa Prabhu
From: Roopa Prabhu This patch uses kernel bridge vlan attribute IFLA_BRIDGE_VLAN_TUNNEL_INFO to set/delete/show per vlan tunnel info. $bridge vlan add dev vxlan0 vid 2000 tunnel_info id 2000 $bridge vlan add dev vxlan0 vid 1000-1001 tunnel_info id 2000-2001 $bridge vlan tunnelshow portvlan

[PATCH iproute2 net-next 1/2] iplink: bridge: support bridge port vlan_tunnel attribute

2017-10-26 Thread Roopa Prabhu
From: Roopa Prabhu This config maps to IFLA_BRPORT_VLAN_TUNNEL bridge port netlink flag attribute. This flag enables vlan to tunnel mapping on a bridge port. It is off by default. set vlan_tunnel attribute on bridge port vxlan0: $ip link set dev vxlan0 type bridge_slave vlan_tunnel on $ip link

[PATCH iproute2 net-next v2 0/2] bridge: support for vlan to tunnel mapping

2017-10-27 Thread Roopa Prabhu
From: Roopa Prabhu This series adds the required options to iplink and bridge commands to enable per vlan tunnel info on a bridge port provided by netlink attributes IFLA_BRPORT_VLAN_TUNNEL (flag) and IFLA_BRIDGE_VLAN_TUNNEL_INFO enable vlan-tunnel mapping on a bridge port: $ip link set dev

[PATCH iproute2 net-next v2 1/2] iplink: bridge: support bridge port vlan_tunnel attribute

2017-10-27 Thread Roopa Prabhu
From: Roopa Prabhu This config maps to IFLA_BRPORT_VLAN_TUNNEL bridge port netlink flag attribute. This flag enables vlan to tunnel mapping on a bridge port. It is off by default. set vlan_tunnel attribute on bridge port vxlan0: $ip link set dev vxlan0 type bridge_slave vlan_tunnel on $ip link

[PATCH iproute2 net-next v2 2/2] bridge: vlan: support for per vlan tunnel info

2017-10-27 Thread Roopa Prabhu
From: Roopa Prabhu This patch uses kernel bridge vlan attribute IFLA_BRIDGE_VLAN_TUNNEL_INFO to set/delete/show per vlan tunnel info. $bridge vlan add dev vxlan0 vid 2000 tunnel_info id 2000 $bridge vlan add dev vxlan0 vid 1000-1001 tunnel_info id 2000-2001 $bridge vlan tunnelshow portvlan

Re: [PATCH net-next] net: bridge: add neigh_suppress to bridge port policies

2017-10-30 Thread Roopa Prabhu
On Mon, Oct 30, 2017 at 3:56 AM, Nikolay Aleksandrov wrote: > Add an entry for IFLA_BRPORT_NEIGH_SUPPRESS to bridge port policies. > > Fixes: 821f1b21cabb ("bridge: add new BR_NEIGH_SUPPRESS port flag to suppress > arp and nd flood") > Signed-off-by: Nikolay Aleksandrov

Re: VPLS in Linux

2017-10-31 Thread Roopa Prabhu
On Tue, Oct 31, 2017 at 6:42 AM, Алексей Болдырев wrote: > When will support for VPLS appear in Linux? 08/21/2017 David Lamparter has > already sent these patches, but they are not in the kernel for some reason, > not populi. Such question, when all the same these patches will get to a > kernel

Re: [RFC net-next v2] bridge lwtunnel, VPLS & NVGRE

2017-08-21 Thread Roopa Prabhu
S support, I haven't wired that up to run against Linux / this >> patchset yet. > > Same as before (API didn't change). > >> The patchset needs a lot of polishing (yes I left my TODO notes in the >> commit messages), for now my primary concern is overall design

[PATCH net] bridge: check for null fdb->dst before notifying switchdev drivers

2017-08-26 Thread Roopa Prabhu
From: Roopa Prabhu current switchdev drivers dont seem to support offloading fdb entries pointing to the bridge device which have fdb->dst not set to any port. This patch adds a NULL fdb->dst check in the switchdev notifier code. This patch fixes the below NULL ptr dereference: $bridge f

[PATCH net-next] bridge: fdb add and delete tracepoints

2017-08-27 Thread Roopa Prabhu
From: Roopa Prabhu Tracepoints to trace bridge forwarding database updates. Signed-off-by: Roopa Prabhu --- include/trace/events/bridge.h | 98 +++ net/bridge/br_fdb.c | 7 net/core/net-traces.c | 6 +++ 3 files changed, 111

Re: [PATCH net-next] bridge: fdb add and delete tracepoints

2017-08-28 Thread Roopa Prabhu
On Sun, Aug 27, 2017 at 7:11 PM, Florian Fainelli wrote: > On 08/27/2017 02:33 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Tracepoints to trace bridge forwarding database updates. > > Thanks for adding this! > >> >> Signed-off-by: Roopa Prabhu

Re: [PATCH net-next] bridge: fdb add and delete tracepoints

2017-08-28 Thread Roopa Prabhu
On Sun, Aug 27, 2017 at 7:11 PM, Florian Fainelli wrote: > On 08/27/2017 02:33 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Tracepoints to trace bridge forwarding database updates. > > Thanks for adding this! > >> >> Signed-off-by: Roopa Prabhu

Re: mlxsw and rtnl lock

2017-08-28 Thread Roopa Prabhu
On Sat, Aug 26, 2017 at 10:04 AM, Ido Schimmel wrote: > On Fri, Aug 25, 2017 at 01:26:07PM -0700, David Ahern wrote: >> Jiri / Ido: >> >> [snip] > > Regarding the silent abort, that's intentional. You can look at the same > code in v4.9 - when the chain was still blocking - and you'll see that > w

[PATCH net-next v2] bridge: fdb add and delete tracepoints

2017-08-28 Thread Roopa Prabhu
From: Roopa Prabhu A few useful tracepoints to trace bridge forwarding database updates. Signed-off-by: Roopa Prabhu --- v2 - address comments from Florian include/trace/events/bridge.h | 98 + net/bridge/br_fdb.c |7 +++ net/core/net

Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints

2017-08-29 Thread Roopa Prabhu
On Tue, Aug 29, 2017 at 6:36 AM, Andrew Lunn wrote: > On Mon, Aug 28, 2017 at 09:22:48PM -0700, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> A few useful tracepoints to trace bridge forwarding >> database updates. > > Hi Roopa > > Once accepted, it would

Re: [PATCH net-next v2] bridge: fdb add and delete tracepoints

2017-08-29 Thread Roopa Prabhu
On Tue, Aug 29, 2017 at 9:46 AM, Florian Fainelli wrote: > On 08/28/2017 09:22 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> A few useful tracepoints to trace bridge forwarding >> database updates. >> >> Signed-off-by: Roopa Prabhu > > Revie

<    2   3   4   5   6   7   8   9   10   11   >