On 02/04/2016 04:47 AM, Michael S. Tsirkin wrote:
On Wed, Feb 03, 2016 at 03:49:04PM -0800, Rick Jones wrote:
And even for not-quite-virtual devices - such as a VC/FlexNIC in an HPE
blade server there can be just about any speed set. I think we went down a
path of patching some things to addres
On Wed, Feb 03, 2016 at 03:49:04PM -0800, Rick Jones wrote:
> On 02/03/2016 03:32 PM, Stephen Hemminger wrote:
>
> >But why check for valid value at all. At some point in the
> >future, there will be yet another speed adopted by some standard body
> >and the switch statement would need another val
On Thu, Feb 04, 2016 at 10:32:26AM +1100, Stephen Hemminger wrote:
> On Wed, 3 Feb 2016 04:04:36 +0100
> Nikolay Aleksandrov wrote:
>
> >
> > +static inline int ethtool_validate_speed(__u32 speed)
> > +{
>
>
> No need for inline.
>
> But why check for valid value at all. At some point in th
On 02/04/2016 12:32 AM, Stephen Hemminger wrote:
> On Wed, 3 Feb 2016 04:04:36 +0100
> Nikolay Aleksandrov wrote:
>
>>
>> +static inline int ethtool_validate_speed(__u32 speed)
>> +{
>
>
> No need for inline.
>
This is defined in a header, if it's not inline you start getting
"defined but n
On 02/03/2016 03:32 PM, Stephen Hemminger wrote:
But why check for valid value at all. At some point in the
future, there will be yet another speed adopted by some standard body
and the switch statement would need another value.
Why not accept any value? This is a virtual device.
And even fo
On Wed, 3 Feb 2016 04:04:36 +0100
Nikolay Aleksandrov wrote:
>
> +static inline int ethtool_validate_speed(__u32 speed)
> +{
No need for inline.
But why check for valid value at all. At some point in the
future, there will be yet another speed adopted by some standard body
and the switch st
From: Nikolay Aleksandrov
Add functions which check if the speed/duplex are defined.
Signed-off-by: Nikolay Aleksandrov
Acked-by: Michael S. Tsirkin
---
v2: new patch
v3: added Michael's ack
v4, v5: no change
include/uapi/linux/ethtool.h | 34 ++
1 file change
