Re: fib_trie initialzation fix [PATCH]

2006-02-24 Thread David S. Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Wed, 22 Feb 2006 14:23:35 +0100 In some kernel configs /proc functions seems to be accessed before the trie is initialized. The patch below checks for this. Signed-off-by: Robert Olsson [EMAIL PROTECTED] Applied, thanks Robert. - To unsubscribe

Re: [PATCH] [IPV6]: Ensure to join all-routers multicast address.

2006-02-24 Thread David S. Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Thu, 23 Feb 2006 03:18:26 +0900 (JST) If net.ipv6.conf.default.forwarding is !0 when bringing up the interface, we failed to join all routers multicast address, while we join/leave if we enable/disable net.ipv6.conf.ethX.forwarding later. This

Re: fib_trie stats fix [PATCH]

2006-02-24 Thread David S. Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Wed, 22 Feb 2006 14:32:43 +0100 fib_triestats has been buggy and caused oopses some platforms as openwrt. The patch below should cure those problems. Signed-off-by: Robert Olsson [EMAIL PROTECTED] Also applied, thanks Robert. - To unsubscribe from

Re: [PATCH 0/3][LLC]: Cleanups Fix

2006-02-24 Thread David S. Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Fri, 24 Feb 2006 18:31:35 -0300 Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.17.git Looks good, pulled, thanks Arnaldo. - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH][REQSK] Don't reset rskq_defer_accept in reqsk_queue_alloc

2006-02-27 Thread David S. Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Mon, 27 Feb 2006 18:28:29 -0300 In 295f7324ff8d9ea58b4d3ec93b1aaa1d80e048a9 I moved defer_accept from tcp_sock to request_queue and mistakingly reset it at reqsl_queue_alloc, causing calls to setsockopt(TCP_DEFER_ACCEPT ) to be lost

Re: [PATCH 0/6] pktgen: refinements and small fixes (V3).

2006-02-28 Thread David S. Miller
From: Luiz Fernando Capitulino [EMAIL PROTECTED] Date: Sat, 25 Feb 2006 16:07:34 -0300 As you've asked, I'm sending again my patches for pktgen: [PATCH 1/6] pktgen: Lindent run. [PATCH 2/6] pktgen: Ports thread list to Kernel list implementation. [PATCH 3/6] pktgen: Fix kernel_thread()

Re: [PATCH] pktgen: Convert thread lock to mutexes.

2006-03-01 Thread David S. Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Wed, 1 Mar 2006 11:22:25 -0300 On 3/1/06, Luiz Fernando Capitulino [EMAIL PROTECTED] wrote: Hi! pktgen's thread semaphores are strict mutexes, convert them to the mutex implementation. Signed-off-by: Luiz Capitulino [EMAIL

tree states

2006-03-01 Thread David S. Miller
Some notes: 1) I am only going to consider 1 or 2 liner simple, obvious, and important bug fixes for 2.6.16, treat it like a patch submission for -stable. Basically the same rules. 2) If you have anything you want seriously considered for net-2.6.17 you should submit it soon, very

Re: verify_sec_ctx_len() warning

2006-03-03 Thread David S. Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Fri, 3 Mar 2006 02:52:18 -0800 net/xfrm/xfrm_user.c: In function `verify_sec_ctx_len': net/xfrm/xfrm_user.c:104: warning: comparison is always false due to limited range of data type if (sec_ctx-sadb_x_ctx_len PAGE_SIZE) PAGE_SIZE is

Re: [PATCH 2/3] bridge: port timer initialization

2006-03-03 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 3 Mar 2006 10:23:29 -0800 Initialize the STP timers for a port when it is created, rather than when it is enabled. This will prevent future race conditions where timer gets started before port is enabled. Signed-off-by: Stephen Hemminger

Re: [PATCH 3/3] bridge: generate kobject remove event

2006-03-03 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 3 Mar 2006 10:24:14 -0800 The earlier round of kobject/sysfs changes to bridge caused it not to generate a uevent on removal. Don't think any application cares (not sure about Xen) but since it generates add uevent it should generate remove

Re: [PATCH 1/3] H-TCP: Use msecs_to_jiffies

2006-03-03 Thread David S. Miller
From: Baruch Even [EMAIL PROTECTED] Date: Fri, 3 Mar 2006 17:34:37 +0200 (IST) Use functions to calculate jiffies from milliseconds and not the old, crude method of dividing HZ by a value. Ensures more accurate values even in the face of strange HZ values. Signed-Off-By: Baruch Even

Re: [PATCH 2/3] H-TCP: Account for delayed-ACKs

2006-03-03 Thread David S. Miller
From: Baruch Even [EMAIL PROTECTED] Date: Fri, 3 Mar 2006 17:35:39 +0200 (IST) Account for delayed-ACKs in H-TCP. Delayed-ACKs cause H-TCP to be less aggressive than its design calls for. It is especially true when the receiver is a Linux machine where the average delayed ack is over 3

Re: [PATCH 3/3] H-TCP: Better time accounting

2006-03-03 Thread David S. Miller
From: Baruch Even [EMAIL PROTECTED] Date: Fri, 3 Mar 2006 17:36:40 +0200 (IST) Instead of estimating the time since the last congestion event, count it directly. Signed-Off-By: Baruch Even [EMAIL PROTECTED] Cc: Doug Leith [EMAIL PROTECTED] Also applied to net-2.6.17, thanks a lot. - To

Re: [PATCH] convert rtnl to mutex

2006-03-03 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 3 Mar 2006 15:48:17 -0800 This patch turns the RTNL from a semaphore to a new 2.6.16 mutex and gets rid of some of the leftover legacy. Please queue for 2.6.17 Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied, thanks. - To

Re: [PATCH 1/2][ATM]: keep atmsvc failure messages quiet

2006-03-03 Thread David S. Miller
From: chas williams - CONTRACTOR [EMAIL PROTECTED] Date: Thu, 02 Mar 2006 15:07:48 -0500 please apply to 2.6.16 tree -- thanks! [ATM]: keep atmsvc failure messages quiet Signed-off-by: Chas Williams [EMAIL PROTECTED] Applied, thanks Chas. - To unsubscribe from this list: send the line

Re: [PATCH 2/2][ATM]: [fore200e] fix section mismatch warnings

2006-03-03 Thread David S. Miller
From: chas williams - CONTRACTOR [EMAIL PROTECTED] Date: Thu, 02 Mar 2006 15:08:54 -0500 please apply to 2.6.16 tree -- thanks! [ATM]: [fore200e] fix section mismatch warnings Signed-off-by: Sam Ravnborg [EMAIL PROTECTED] Signed-off-by: Chas Williams [EMAIL PROTECTED] Also applied,

Re: [PKTGEN 1/3]: Convert thread lock to mutexes.

2006-03-03 Thread David S. Miller
From: Luiz Fernando Capitulino [EMAIL PROTECTED] Date: Wed, 1 Mar 2006 23:05:43 -0300 pktgen's thread semaphores are strict mutexes, convert them to the mutex implementation. Signed-off-by: Luiz Capitulino [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line

Re: [PKTGEN 2/3]: Removes thread_{un,}lock() macros.

2006-03-03 Thread David S. Miller
From: Luiz Fernando Capitulino [EMAIL PROTECTED] Date: Wed, 1 Mar 2006 23:05:48 -0300 As suggested by Arnaldo, this patch replaces the thread_lock()/thread_unlock() by directly calls to mutex_lock()/mutex_unlock(). This change makes the code a bit more readable, and the direct calls

Re: [PKTGEN 3/3]: Updates version.

2006-03-03 Thread David S. Miller
From: Luiz Fernando Capitulino [EMAIL PROTECTED] Date: Wed, 1 Mar 2006 23:05:54 -0300 Due to the thread's lock changes, we're at a new version now. Signed-off-by: Luiz Capitulino [EMAIL PROTECTED] Applied, thanks a lot. - To unsubscribe from this list: send the line unsubscribe netdev in

Re: [PATCH 1/8] [I/OAT] DMA memcpy subsystem

2006-03-03 Thread David S. Miller
From: Chris Leech [EMAIL PROTECTED] Date: Fri, 03 Mar 2006 13:42:20 -0800 +static spinlock_t dma_list_lock; Please use DEFINE_SPINLOCK(). +static void dma_chan_free_rcu(struct rcu_head *rcu) { Newline before the brace please. +static void dma_async_device_cleanup(struct kref *kref) {

Re: net-2.6.17 rebased...

2006-03-03 Thread David S. Miller
From: Ian McDonald [EMAIL PROTECTED] Date: Thu, 2 Mar 2006 13:48:18 +1300 If you get a chance can you push the ccid3 divide by zero fix upstream to Linus for 2.6.16 as it has no functionality changed and eliminates a nasty little bug... The commit for this is

Re: [PATCH] RTPROT addition in rtnetlink.h

2006-03-03 Thread David S. Miller
From: Alpt [EMAIL PROTECTED] Date: Sat, 4 Mar 2006 02:58:52 +0100 This patch defines the Netsukuku protocol (RTPROT_NTK) by the number 15 in rtnetlink.h. The Netsukuku daemon is using the same number to mark its routes, you can see it here:

Re: [PATCH 0/8] Intel I/O Acceleration Technology (I/OAT)

2006-03-04 Thread David S. Miller
From: Jan Engelhardt [EMAIL PROTECTED] Date: Sat, 4 Mar 2006 19:46:22 +0100 (MET) Does this buy the normal standard desktop user anything? Absolutely, it optimizes end-node performance. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 0/8] Intel I/O Acceleration Technology (I/OAT)

2006-03-04 Thread David S. Miller
From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Sun, 5 Mar 2006 04:43:25 +0300 According to investigation made for kevent based FS AIO reading, get_user_pages() performange graph looks like sqrt() function with plato starting on about 64-80 pages on Xeon 2.4Ghz with 1Gb of ram, while memcopy()

Re: [PATCH 8/8] [I/OAT] TCP recv offload to I/OAT

2006-03-05 Thread David S. Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Sun, 5 Mar 2006 00:45:34 -0800 The __get_cpu_var() here will run smp_processor_id() from preemptible context. You'll get a big warning if the correct debug options are set. The reason for this is that preemption could cause this code to hop

Re: [EMAIL PROTECTED]: [PATCH] use fget_light() in net/socket.c]

2006-03-06 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 13:59:39 -0800 Here's an updated copy of the patch to use fget_light in net/socket.c. I like this patch a lot, applied to net-2.6.17 I fixed this up by hand: Adds trailing whitespace. diff:286: fput_light(sock_file,

Re: [PATCH] minor net_rx_action optimization

2006-03-06 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 14:24:35 -0800 The functions list_del followed by list_add_tail is equivalent to the existing inline list_move_tail. list_move_tail avoids unnecessary _LIST_POISON. Trivial for 2.6.17. Signed-off-by: Stephen Hemminger [EMAIL

Re: [RFC/PATCH] rcuification of ipv4 established and timewait connections

2006-03-06 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 14:01:11 -0800 This patch introduces the use of rcu for the ipv4 established connections hashtable, as well as the timewait table since they are closely intertwined. Thanks for doing this work, I'll try study it seriously very

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread David S. Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:58:32 -0800 Sean Unless I miss counted, they should be aligned. Sean ib_user_path_rec is defined near the end of patch 1/6. You're right. struct sockaddr_in6 is 28 bytes long (not a multiple of 8) but gcc seems to lay

Re: TSO and IPoIB performance degradation

2006-03-06 Thread David S. Miller
From: Michael S. Tsirkin [EMAIL PROTECTED] Date: Tue, 7 Mar 2006 00:34:38 +0200 So I'm trying to get a handle on it: could a solution be to simply look at the frame size, and call tcp_send_delayed_ack from if the frame size is no larger than 1/8? Does this make sense? The comment you

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread David S. Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 14:32:28 -0800 The fundamental question seems to be whether things like struct foo { struct sockaddr_in6 src; struct sockaddr_in6 dst; }; and struct bar { struct

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread David S. Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 14:41:21 -0800 I should look into getting some niagara machines to test with -- with PCIe slots they should actually be good for IB testing. You'll be cpu limited until we have Van Jacobson net channels. Also, since our existing

Re: [PATCH] avoid memory barrier bitops in hot paths

2006-03-06 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 15:06:41 -0800 This patch removes a couple of memory barriers from atomic bitops that showed up on profiles of netperf. A little ugly, we should have a nicer way to do this generically. - To unsubscribe from this list: send the

Re: [PATCH] avoid memory barrier bitops in hot paths

2006-03-06 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 15:40:31 -0800 On Mon, Mar 06, 2006 at 08:29:30PM -0300, Arnaldo Carvalho de Melo wrote: - clear_bit(SOCK_ASYNC_NOSPACE, sk-sk_socket-flags); + if (test_bit(SOCK_ASYNC_NOSPACE, sk-sk_socket-flags)) +

Re: [PATCH] avoid memory barrier bitops in hot paths

2006-03-06 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 16:09:07 -0800 I'll respin it with the fast_clear_bit() suggestion. Please see my other email first, we may be able to do something even better via test_and_*_bit(). - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2.6.17 1/9] tg3: Add 5787 and 5754 basic support

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:49:54 -0800 Add basic support for 2 new chips 5787 and 5754. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: [PATCH 2.6.17 2/9] tg3: Add 5787 nvram support

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:50:22 -0800 Support additional nvrams and new nvram format for 5787 and 5754. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied, but I had to remove trailing whitespace in the patch by hand, as GIT warns about that now, it

Re: [PATCH 2.6.17 3/9] tg3: Add new hard_start_xmit

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:50:51 -0800 Support 5787 hardware TSO using a new flag TG3_FLG2_HW_TSO_2. Since the TSO interface is slightly different and these chips have finally fixed the 4GB DMA problem and do not have the 40-bit DMA problem, a new

Re: [PATCH 2.6.17 4/9] tg3: Add ipv6 checksum support

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:51:22 -0800 Support ipv6 tx csum on 5787 by setting NETIF_F_HW_CSUM. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH 2.6.17 5/9] tg3: Add new one-shot MSI handler

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:51:54 -0800 Support one-shot MSI on 5787. This one-shot MSI idea is credited to David Miller. In this mode, MSI disables itself automatically after it is generated, saving the driver a register access to disable it for NAPI.

Re: [PATCH 2.6.17 8/9] tg3: Add firmware version info

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:53:18 -0800 Add fw_version information to ethtool -i. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 2.6.17 9/9] tg3: update version and reldate

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 13:53:51 -0800 Update version to 3.52. Signed-off-by: Michael Chan [EMAIL PROTECTED] Also applied, thanks a lot Michael. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: [PATCH 2.6.17 3/9] tg3: Add new hard_start_xmit

2006-03-06 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 15:07:50 -0800 On Mon, 2006-03-06 at 16:39 -0800, David S. Miller wrote: Also, you should probably fixup the DMA masks we use if this chip really doesn't have the 40-bit limitation. Or did you take care of that and I missed

Re: [PATCH 2.6.17 3/9] tg3: Add new hard_start_xmit

2006-03-06 Thread David S. Miller
From: David S. Miller [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 16:52:41 -0800 (PST) I did put that patch in already. Actually, no I didn't, it's still in my queue sorry. I'll try to get to it tonight, it belongs in 2.6.16 for sure. - To unsubscribe from this list: send the line unsubscribe

Re: [openib-general] Re: [PATCH 6/6] IB: userspace support for RDMA connection manager

2006-03-06 Thread David S. Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 15:40:56 -0800 and 32 threads are probably good for flushing out SMP races. Indeed, guess what I've been spending most of my time working on lately? :) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH] net: Move destructor from neigh-ops to neigh_params

2006-03-06 Thread David S. Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 21:44:50 -0800 Roland struct neigh_ops currently has a destructor field, which Roland no in-kernel drivers outside of infiniband use. Andrew net/atm/clip.c begs to disagree. err... my fault for trusting the patch

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-07 Thread David S. Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Tue, 07 Mar 2006 19:45:42 +0900 (JST) In article [EMAIL PROTECTED] (at Tue, 7 Mar 2006 11:26:13 +0100), Ingo Oeser [EMAIL PROTECTED] says: What about sth. like this simple defensive patch instead (against Linux 2.6.16-rc4)? I disagree

Re: [EXPERIMENTAL] HT aware loopback device (hack, x86-64 only atm)

2006-03-07 Thread David S. Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 7 Mar 2006 23:47:11 +0100 In particular I liked the concept of using arrays of pointers as queues instead of double linked lists to be more cache friendly. Why doesn't someone work on a generic data-structure framework in some generic header file

Re: [PATCH] [NETFILTER] ip_queue: Fix wrong skb-len == nlmsg_len assumption

2006-03-07 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 07 Mar 2006 13:58:53 +0100 Thomas Graf wrote: The size of the skb carrying the netlink message is not equivalent to the length of the actual netlink message due to padding. ip_queue matches the length of the payload against the original

Re: [EXPERIMENTAL] HT aware loopback device (hack, x86-64 only atm)

2006-03-07 Thread David S. Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Tue, 7 Mar 2006 16:39:58 +0100 Also the locking requirements would need to be defined. The originals didn't have any locking at all. You don't need any locking, just a producer and consumer index in seperate cache lines, and a wakeup protocol that makes

Re: [PATCH] IPoIB: Fix build now that destructor is in neigh_params

2006-03-07 Thread David S. Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Tue, 07 Mar 2006 11:21:08 -0800 Dave, here's an incremental patch that fixes the IPoIB build (which is broken in net-2.6.17 because of my screw-up, which left out the chunk below). I'll also send a full patch that can replace the Move destructor

Re: [openib-general] Re: TSO and IPoIB performance degradation

2006-03-07 Thread David S. Miller
From: Matt Leininger [EMAIL PROTECTED] Date: Tue, 07 Mar 2006 16:11:37 -0800 I used the standard setting for tcp_rmem and tcp_wmem. Here are a few other runs that change those variables. I was able to improve performance by ~30MB/s to 403 MB/s, but this is still a ways from the 474 MB/s

Re: [openib-general] Re: TSO and IPoIB performance degradation

2006-03-07 Thread David S. Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Tue, 07 Mar 2006 17:17:30 -0800 The reason TSO comes up is that reverting the patch described below helps (or helped at some point at least) IPoIB throughput quite a bit. I wish you had started the thread by mentioning this specific patch, we wasted

Re: [GIT PATCH] TIPC updates

2006-03-08 Thread David S. Miller
From: Per Liden [EMAIL PROTECTED] Date: Wed, 8 Mar 2006 11:18:15 +0100 (CET) Here is a set of patches for net-2.6.17. Please pull from: git://tipc.cslab.ericsson.net/pub/git/tipc.git Looks good, but I can't pull it cleanly. Please fix this up, thanks. [EMAIL

Re: TSO and IPoIB performance degradation

2006-03-08 Thread David S. Miller
From: Michael S. Tsirkin [EMAIL PROTECTED] Date: Wed, 8 Mar 2006 14:53:11 +0200 What I was trying to figure out was, how can we re-enable the trick without hurting TSO? Could a solution be to simply look at the frame size, and call tcp_send_delayed_ack if the frame size is small? The problem

Re: [Patch 1/1] updated: TCP/UDP getpeersec

2006-03-08 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 09 Mar 2006 11:33:19 +1100 Catherine Zhang [EMAIL PROTECTED] wrote: From: [EMAIL PROTECTED] This patch implements an application of the LSM-IPSec networking controls whereby an application can determine the label of the security

Re: [PATCH] compat. ifconf: fix limits

2006-03-08 Thread David S. Miller
From: Randy.Dunlap [EMAIL PROTECTED] Date: Wed, 8 Mar 2006 09:16:08 -0800 From: Randy Dunlap [EMAIL PROTECTED] A recent change to compat. dev_ifconf() in fs/compat_ioctl.c causes ifconf data to be truncated 1 entry too early when copying it to userspace. The correct amount of data (length)

Re: [PATCH] compat. ifconf: fix limits

2006-03-08 Thread David S. Miller
From: Randy.Dunlap [EMAIL PROTECTED] Date: Wed, 8 Mar 2006 17:41:16 -0800 On Wed, 08 Mar 2006 16:46:27 -0800 (PST) David S. Miller wrote: Is this one relevant for -stable? Yes, IMO. Have to wait for it to be merged upstream, right? I'll take care of everything, thanks Randy

Re: [GIT PATCH] TIPC updates

2006-03-08 Thread David S. Miller
From: Per Liden [EMAIL PROTECTED] Date: Wed, 8 Mar 2006 17:05:08 +0100 (CET) On Wed, 8 Mar 2006, David S. Miller wrote: From: Per Liden [EMAIL PROTECTED] Date: Wed, 8 Mar 2006 11:18:15 +0100 (CET) Here is a set of patches for net-2.6.17. Please pull from: git

Re: [PATCH 1/3] bridge-netfilter: whitespace fix

2006-03-08 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 6 Feb 2006 14:39:18 -0800 This applies after the RCU fix patches; it can be held until 2.6.17. Run br_netfilter through Lindent to fix whitespace. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] This patch set doesn't apply cleanly,

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-08 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 08 Mar 2006 23:24:22 -0800 I have gotten massive strace's and the java VM is: 1) Turning on TCP_NODELAY 2) Sending small packets. Java is doing the wrong thing, obviously. 4) Fix java And this is the only reasonable recourse.

Re: potential leak in tun_get_user

2006-03-09 Thread David S. Miller
From: Dave Jones [EMAIL PROTECTED] Date: Wed, 8 Mar 2006 22:50:00 -0500 We're leaking an skb in a failure path in this function. Coverity #632 Signed-off-by: Dave Jones [EMAIL PROTECTED] I'll apply this, thanks a lot Dave. - To unsubscribe from this list: send the line unsubscribe netdev in

Re: [EXPERIMENTAL] HT aware loopback device (hack, x86-64 only atm)

2006-03-09 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Tue, 7 Mar 2006 13:19:10 -0800 At this point I'd just like to stir up some discussion, so please comment away with any ideas and concerns. I don't like this :-) Not because you put x86_64 stuff in there, I know we can abstract all of that stuff

Re: [PATCH 1/1] sysctl to allow TCP window 32767 sans wscale

2006-03-09 Thread David S. Miller
From: Rick Jones [EMAIL PROTECTED] Date: Tue, 7 Mar 2006 13:50:59 -0800 (PST) Since such stacks are rapidly fading into the mists of time, and since it is perfectly legal and not entirely uncommon to use a TCP window up to 65535 bytes when window scaling is not in use, we want to allow an

Re: [Bugme-new] [Bug 6177] New: Java remote debugging is slow due to apparent networking bug

2006-03-09 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 9 Mar 2006 08:33:15 -0800 A possible solution would be to set cwnd bigger for loopback. If there was a clean way to know that connection was over loopback, then doing something in tcp_init_metrics() to set INIT_CWND if

Re: [RFC/PATCH] rcuification of ipv4 established and timewait connections

2006-03-09 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Thu, 9 Mar 2006 12:50:44 -0800 Hrm, maybe use cmpxchg? That gets rid of the lock and automatically provides us with hashed spinlocks on archs without a cmpxchg implementation. I don't think we even need to go there, here's why. Once we have RCU

Re: [RFC/PATCH] rcuification of ipv4 established and timewait connections

2006-03-09 Thread David S. Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Thu, 09 Mar 2006 20:32:16 +0100 #define PTRS_PER_CACHELINE ((L1_CACHE_BYTES - sizeof(rwlock_t))/sizeof(struct hlist_head)) struct hash_agg_bucket { rwlock_t wlock; struct hlist_head chains[PTRS_PER_CACHELINE]; }; A division by a

Re: [Bugme-new] [Bug 6197] New: unregister_netdevice: waiting for ppp9 to become free. Usage count = 658

2006-03-09 Thread David S. Miller
From: Baruch Even [EMAIL PROTECTED] Date: Thu, 9 Mar 2006 23:56:39 +0200 We need to remove all references to the device when we receive the NETDEV_UNREGISTER notification. Signed-off-by: Baruch Even [EMAIL PROTECTED] Good spotting Baruch. Once this gets a positive test result I'll apply

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-09 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 9 Mar 2006 14:56:43 -0800 This patch is changes the initial TCP congestion window for connections that are over the loopback device. This gives better for performance for applications that do lots of small writes. It might also help for

Re: [RFC/PATCH] rcuification of ipv4 established and timewait connections

2006-03-09 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Thu, 9 Mar 2006 13:35:16 -0800 On Thu, Mar 09, 2006 at 01:12:20PM -0800, David S. Miller wrote: So Ben can you work to figure out what the bind(0.0.0.0) problem was? Once that is fully resolved, I think I'll apply your RCU patch to net-2.6.17

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-09 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 9 Mar 2006 15:11:47 -0800 Then the dst would get changed, no breakage. Not with a TC action rewrite on input, that would happen after loopback does the netif_rx(). Interface specific hard-coded metrics are wrong from every single possible

Re: [PATCH 1/1] sysctl to allow TCP window 32767 sans wscale

2006-03-09 Thread David S. Miller
I had to do some minor fixups, and kill some trailing whitespace added by this patch, but looks good, applied. Thanks a lot Rick. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [2.6 patch] tg3.c:tg3_bus_string(): remove dead code

2006-03-09 Thread David S. Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Fri, 10 Mar 2006 00:06:50 +0100 The Coverity checker spotted this dead code (note that (clock_ctrl == 7) is already handled above). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Applied, thanks Adrian. - To unsubscribe from this list: send the line

Re: [Patch 1/1] updated: TCP/UDP getpeersec

2006-03-09 Thread David S. Miller
From: Xiaolan Zhang [EMAIL PROTECTED] Date: Wed, 8 Mar 2006 22:02:31 -0500 I am working on a separate patch for Unix datagram, instead of mixing the two into one patch. James, is this Ok with you? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [XFRM]: Fix aevent related crash

2006-03-09 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 14:20:06 +0100 Sorry, thats just as broken as before. Better patch attached. Applied, thanks Patrick. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 1/1] sysctl to allow TCP window 32767 sans wscale

2006-03-09 Thread David S. Miller
From: Rick Jones [EMAIL PROTECTED] Date: Thu, 09 Mar 2006 15:34:33 -0800 David S. Miller wrote: I had to do some minor fixups, and kill some trailing whitespace added by this patch, but looks good, applied. Thanks a lot Rick. You're welcome. If the fixups were related to things I

Re: [PATCH] use wait queue spinlock for the socket spinlock

2006-03-09 Thread David S. Miller
From: Benjamin LaHaise [EMAIL PROTECTED] Date: Tue, 7 Mar 2006 14:59:10 -0800 The patch below merges the use of the wait queue lock and socket spinlock into one. This gains us ~100-150Mbit/s on netperf, mostly due to the fact that because we know how the spinlock is used, we can avoid the

Re: TSO and IPoIB performance degradation

2006-03-09 Thread David S. Miller
From: Michael S. Tsirkin [EMAIL PROTECTED] Date: Wed, 8 Mar 2006 14:53:11 +0200 What I was trying to figure out was, how can we re-enable the trick without hurting TSO? Could a solution be to simply look at the frame size, and call tcp_send_delayed_ack if the frame size is small? The change

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-09 Thread David S. Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Thu, 9 Mar 2006 15:45:05 -0800 Maybe Solaris (and Windows?) have special-case handling for local TCP. It seems a bit odd to me that loopback would use normal handling for things like slow-start and congestion, but I'm sure there's a good reason ;)

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-09 Thread David S. Miller
From: Rick Jones [EMAIL PROTECTED] Date: Thu, 09 Mar 2006 15:51:14 -0800 Doesn't X semi-legitimately set TCP_NODELAY and then start sending lots of small packets? What happens to it with this ABC stuff going? X wants the packets to go out immediately, in fact as Jim Getty's mentioned during

Re: TSO and IPoIB performance degradation

2006-03-09 Thread David S. Miller
From: Michael S. Tsirkin [EMAIL PROTECTED] Date: Fri, 10 Mar 2006 02:10:31 +0200 But with the change we are discussing, could an ack now be sent even sooner than we have at least two full sized segments? Or does __tcp_ack_snd_check delay until we have at least two full sized segments? David,

Re: TSO and IPoIB performance degradation

2006-03-09 Thread David S. Miller
From: Rick Jones [EMAIL PROTECTED] Date: Thu, 09 Mar 2006 16:21:05 -0800 well, there are stacks which do stretch acks (after a fashion) that make sure when they see packet loss to do the right thing wrt sending enough acks to allow cwnds to open again in a timely fashion. Once a loss

Re: [PATCH] tcp: bigger congestion window for loopback

2006-03-09 Thread David S. Miller
From: Eric Molitor [EMAIL PROTECTED] Date: Thu, 9 Mar 2006 22:39:16 -0600 Its pretty bad on both. But most Java developers debug via localhost. The slowdowns don't occur on Windows, Solaris, or the unoficial JDK port to BSD. But I dont know what kernels support ABC. For now I will see what

Re: [Patch 1/1] updated: TCP/UDP getpeersec

2006-03-10 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 09 Mar 2006 11:33:19 +1100 Acked-by: Herbert Xu [EMAIL PROTECTED] Dave, perhaps we should queue this for 2.6.17? Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: RFC [Patch 1/1] Unix Datagram getpeersec

2006-03-10 Thread David S. Miller
From: James Morris [EMAIL PROTECTED] Date: Thu, 9 Mar 2006 22:40:09 -0500 (EST) On Thu, 9 Mar 2006, Catherine Zhang wrote: As per request from Stephen, I have enclosed the patch for Unix Datagram getpeersec. As always, comments are welcome! Looks fine to me. Acked-by: James

Re: [GIT] DECnet: Fix for big-endian machines

2006-03-10 Thread David S. Miller
From: Patrick Caulfield [EMAIL PROTECTED] Date: Fri, 10 Feb 2006 10:26:45 + The git repository is still correct at git://git.kernel.org/pub/scm/linux/kernel/git/steve/decnet-2.6.17 I pulled these patches into my net-2.6.17 tree, sorry for taking so long :-/ - To unsubscribe from this

Re: [PATCH] snap: needs hardware checksum fix

2006-03-10 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 7 Feb 2006 22:21:37 +1100 [NET]: Replace skb_pull/skb_postpull_rcsum with skb_pull_rcsum We're now starting to have quite a number of places that do skb_pull followed immediately by an skb_postpull_rcsum. We can merge these two operations into

Re: KERNEL: assertion (!sk-sk_forward_alloc) failed

2006-03-10 Thread David S. Miller
From: Ian McDonald [EMAIL PROTECTED] Date: Fri, 10 Feb 2006 08:37:48 +1300 On 2/10/06, Boris B. Zhmurov [EMAIL PROTECTED] wrote: Hello, Ian McDonald. On 09.02.2006 22:25 you said the following: Is it possible for you to download 2.6.16-rc2 or similar and see if it goes away?

Re: [PATCH] IPv6: Cleanups for net/ipv6/addrconf.c (kzalloc, early exit) v2

2006-03-10 Thread David S. Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Sun, 12 Feb 2006 02:11:03 +0900 (JST) In article [EMAIL PROTECTED] (at Sat, 11 Feb 2006 17:37:18 +0100), Ingo Oeser [EMAIL PROTECTED] says: From: Ingo Oeser [EMAIL PROTECTED] Here are some possible (and trivial) cleanups. - use

Re: KERNEL: assertion (!sk-sk_forward_alloc) failed

2006-03-10 Thread David S. Miller
From: Jesse Brandeburg [EMAIL PROTECTED] Date: Wed, 8 Feb 2006 18:10:21 -0800 I think the commit id that is missing from 2.6.14.X is fb5f5e6e0cebd574be737334671d1aa8f170d5f3 It's in 2.6.14.x I just double checked. - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH] [IPV6]: fix ipv6_saddr_score struct element

2006-03-10 Thread David S. Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Sun, 05 Mar 2006 21:07:19 +0900 (JST) In article [EMAIL PROTECTED] (at Tue, 28 Feb 2006 15:03:31 -0500), Brian Haley [EMAIL PROTECTED] says: The scope element in the ipv6_saddr_score struct used in ipv6_dev_get_saddr() is an unsigned

Re: patch to MAINTAINERS for net-2.6.git path

2006-03-10 Thread David S. Miller
From: G. Allen Morris III [EMAIL PROTECTED] Date: Fri, 03 Mar 2006 23:24:00 -0500 incorrect git path in MAINTAINERS. Patch doesn't apply cleanly to 2.6.16-rc5, please regenerate, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: ipip.c to work as module with CONFIG_INET_TUNNEL

2006-03-10 Thread David S. Miller
From: G. Allen Morris III [EMAIL PROTECTED] Date: Fri, 03 Mar 2006 23:24:03 -0500 -#ifdef CONFIG_INET_TUNNEL +#if defined(CONFIG_INET_TUNNEL) || defined(CONFIG_INET_TUNNEL_MODULE) + static struct xfrm_tunnel ipip_handler = { .handler= ipip_rcv, .err_handler

Re: remove useless test in ip6_append_data

2006-03-10 Thread David S. Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 16:42:05 +0900 (JST) In article [EMAIL PROTECTED] (at Mon, 6 Mar 2006 02:34:16 -0500), Dave Jones [EMAIL PROTECTED] says: We've already dereferenced 'np' a dozen times at this point, so it's safe to say it's not null.

Re: move br_nf_post_routing null skb check

2006-03-10 Thread David S. Miller
From: Dave Jones [EMAIL PROTECTED] Date: Mon, 6 Mar 2006 03:24:19 -0500 Coverity bug #980 If skb-dev can be null, we should check it before dereferencing. Signed-off-by: Dave Jones [EMAIL PROTECTED] This code looks different now and I think the skb-dev cannot be NULL so better to remove

Re: CWND underused when TSO on

2006-03-10 Thread David S. Miller
From: Lachlan Andrew [EMAIL PROTECTED] Date: Tue, 7 Mar 2006 18:44:50 -0800 The reason for tcp_tso_should_defer appears to be to allow enough space for a full-sized 64k socket buffer to be created. I propose checking that condition explicitly, as in the attached patch, reproduced below,

Re: [RFC: 2.6 patch] let NET_CLS_ACT no longer depend on EXPERIMENTAL

2006-03-10 Thread David S. Miller
From: jamal [EMAIL PROTECTED] Date: Sat, 04 Mar 2006 13:52:21 -0500 So on Adrian's patch and above reasoning: ACKed-by: Jamal Hadi Salim [EMAIL PROTECTED] Applied, thanks Adrian. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: [PATCH 0/9] Build Fixes, cleanups and some DCCP trivial patches

2006-03-10 Thread David S. Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Fri, 10 Mar 2006 18:22:17 -0300 Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.17.git Thanks for fixing all of this stuff up, pulled. - To unsubscribe from this list: send the line unsubscribe

net-2.6.17 build still broken due to getpeersec

2006-03-10 Thread David S. Miller
The Unix getpeersec changes added calls to security_sid_to_context(), but there is no implementation available when CONFIG_SECURITY is not enabled. In file included from net/unix/af_unix.c:112: include/net/scm.h: In function 'scm_recv': include/net/scm.h:74: warning: implicit declaration of

<    5   6   7   8   9   10   11   12   >