[PATCH v2 net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
ii-txid | TDM Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- v2 [Simon Horman] * As suggested by Sergei Shtylyov - Add a comment to indicate that APSR_DM appears to be undocumented. - Move chip_id chec

Re: [PATCH v2 net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 10:05:58PM +0300, Sergei Shtylyov wrote: > On 01/27/2017 09:35 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> > > > >This patch enables tx and rx clock internal delay modes (TDM and RDM). >

[PATCH v3 net-next 2/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
glider.be> Signed-off-by: Simon Horman <horms+rene...@verge.net.au> Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- drivers/net/ethernet/renesas/ravb_main.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/renesas/ra

[PATCH v3 net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
ii-txid | TDM Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> Signed-off-by: Simon Horman <horms+rene...@verge.net.au> Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- v3 [Simon Horman] * Move comment to above ravb_set_delay_mode() v2 [S

[PATCH v3 net-next 0/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
Hi, this series adds support for gigabit communication to the Renesas EthernetAVB controller when used in conjunction with R-Car Gen3 H3 ES1.1+ and M3-W SoCs. Gigabit is already supported with R-Car Gen 2 SoCs. The patch from Geert was previously posted for inclusion in v4.10 and acked by Dave

[PATCH net] net/sched: cls_flower: Correct matching on ICMPv6 code

2017-01-30 Thread Simon Horman
action drop Without this change the code parameter above is effectively ignored. Fixes: 7b684884fbfa ("net/sched: cls_flower: Support matching on ICMP type and code") Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- net/sched/cls_flower.c | 4 ++-- 1 file changed, 2

Re: [PATCH/RFC v3 net] ravb: unmap descriptors when freeing rings

2017-01-25 Thread Simon Horman
On Wed, Jan 25, 2017 at 07:18:15PM +0300, Sergei Shtylyov wrote: > On 01/24/2017 09:21 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> > > > >"swiotlb buffer is full" errors occur after repeated initialisation of a &g

Re: [PATCH/RFC v3 net] ravb: unmap descriptors when freeing rings

2017-01-25 Thread Simon Horman
On Wed, Jan 25, 2017 at 07:05:08PM +0300, Sergei Shtylyov wrote: > Hello. > > On 01/24/2017 09:21 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> > > > >"swiotlb buffer is full" errors occur after repeated initi

Re: [PATCH v2 net] net: free ip_vs_dest structs when refcnt=0

2017-01-27 Thread Simon Horman
t; Signed-off-by: Julian Anastasov <j...@ssi.bg> > > Simon and Pablo, this is more appropriate for > ipvs-next/nf-next. Please apply! Pablo, would you mind taking this one directly into nf-next? Signed-off-by: Simon Horman <ho...@verge.net.au> > > > --- &g

[PATCH net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
ii-txid | TDM Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- v1 [Simon Horman] - Combined patches - Reworded changelog v0 [Kazuya Mizuguchi] --- drivers/net/ethernet/renesas/ravb.h | 10 +

[PATCH net-next 0/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
Hi, this series adds support for gigabit communication to the Renesas EthernetAVB controller when used in conjunction with R-Car Gen3 H3 ES1.1+ and M3-W SoCs. Gigabit is already supported with R-Car Gen 2 SoCs. The patch from Geert was previously posted for inclusion in v4.10 and acked by Dave

[PATCH net-next 2/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
glider.be> Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- drivers/net/ethernet/renesas/ravb_main.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 9fb4c04c

Re: [PATCH net-next 0/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 01:16:43PM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Jan 27, 2017 at 12:04 PM, Simon Horman > <horms+rene...@verge.net.au> wrote: > > The path from Mizuguchi-san is to address timing problems observed with > > gigabit transfe

Re: [PATCH net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 03:42:05PM +0300, Sergei Shtylyov wrote: > Hello! > > On 01/27/2017 02:04 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> > > > >This patch enables tx and rx clock internal delay modes (TDM

Re: [PATCH net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 04:00:27PM +0300, Sergei Shtylyov wrote: > On 01/27/2017 02:04 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> > > > >This patch enables tx and rx clock internal delay modes (TDM and RDM). >

Re: [patch net-next RFC 1/2] flow_dissecror: Move ARP dissection into a separate function

2017-02-22 Thread Simon Horman
flow dissection user requires it. > > Signed-off-by: Jiri Pirko <j...@mellanox.com> This looks good to me. Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [patch net-next RFC 1/2] flow_dissecror: Move ARP dissection into a separate function

2017-02-22 Thread Simon Horman
On Tue, Feb 21, 2017 at 01:32:35PM -0500, David Miller wrote: > From: Jiri Pirko > Date: Tue, 21 Feb 2017 15:33:18 +0100 > > > From: Jiri Pirko > > > > Make the main flow_dissect function a bit smaller and move the ARP > > dissection into a separate

Re: [patch net-next RFC 2/2] flow_dissecror: Move MPLS dissection into a separate function

2017-02-22 Thread Simon Horman
flow dissection user requires it. > > Signed-off-by: Jiri Pirko <j...@mellanox.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [patch net-next RFC 1/8] devlink: Support for pipeline debug (dpipe)

2017-02-20 Thread Simon Horman
On Sat, Feb 18, 2017 at 08:38:51AM +0100, Jiri Pirko wrote: > Fri, Feb 17, 2017 at 09:49:07AM CET, simon.hor...@netronome.com wrote: > >Hi Jiri, > > > >On Thu, Feb 16, 2017 at 04:22:37PM +0100, Jiri Pirko wrote: > >> From: Arkadi Sharshevsky > >> > >> The pipeline debug is

Re: [PATCH iproute2] tc: flower: Fix parsing ip address

2017-02-22 Thread Simon Horman
<pa...@mellanox.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- > tc/f_flower.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tc/f_flower.c b/tc/f_flower.c > index 6bd03f2..5aac4a0 100644 > --- a/tc/f_flower.c > +++ b/

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-09 Thread Simon Horman
On Wed, Feb 08, 2017 at 09:09:17PM +0100, Jiri Pirko wrote: > Wed, Feb 08, 2017 at 07:54:15PM CET, da...@davemloft.net wrote: > >From: Tom Herbert <t...@herbertland.com> > >Date: Wed, 8 Feb 2017 10:33:46 -0800 > > > >> On Wed, Feb 8, 2017 at 1:28 AM, Simo

Re: [PATCH/RFC v3 net] ravb: unmap descriptors when freeing rings

2017-02-13 Thread Simon Horman
On Fri, Feb 10, 2017 at 02:52:50PM +0100, Geert Uytterhoeven wrote: > On Wed, Jan 25, 2017 at 5:18 PM, Sergei Shtylyov > <sergei.shtyl...@cogentembedded.com> wrote: > > On 01/24/2017 09:21 PM, Simon Horman wrote: > > > >> From: Kazuya Mizuguchi <kazuya.mizuguch

[PATCH iproute2/net-next repost 1/3] tc: flower: provide generic masked u8 parser helper

2017-02-09 Thread Simon Horman
Provide generic masked u8 paser helper and use it to parse arp operations. Also consistently use __u8 rather than uint8_t, in keeping with the pervasive style in the file. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- tc/f_flower.

[PATCH iproute2/net-next repost 3/3] tc: flower: support masked ICMP code and type match

2017-02-09 Thread Simon Horman
Extend ICMP code and type match to support masks. Also add missing documentation to synopsis in manpage. tc qdisc add dev eth0 ingress tc filter add dev eth0 protocol ipv6 parent : flower \ indev eth0 ip_proto icmpv6 type 128/240 code 0 action drop Signed-off-by: Simon Horman

[PATCH iproute2/net-next repost 2/3] tc: flower: provide generic masked u8 print helper

2017-02-09 Thread Simon Horman
Provide generic masked u8 print helper and use it to print arp operations. Also: * Make name parameter of arp op print helper const. * Consistently use __u8 rather than uint8_t, in keeping with the pervasive style in the file. Signed-off-by: Simon Horman <simon.hor...@netronome.com> -

[PATCH iproute2/net-next repost 0/3] tc: flower: support masked ICMP code and type match

2017-02-09 Thread Simon Horman
: tc qdisc add dev eth0 ingress tc filter add dev eth0 protocol ipv6 parent : flower \ indev eth0 ip_proto icmpv6 type 128/240 code 0 action drop Reposting after breaking out of a larger patchset. Simon Horman (3): tc: flower: provide generic masked u8 parser helper tc: flower

Re: [PATCH iproute] tc: matchall: Print skip flags when dumping a filter

2017-02-10 Thread Simon Horman
t these flags. Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- > tc/f_matchall.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/tc/f_matchall.c b/tc/f_matchall.c > index 04e524e..ac48630 100644 > --- a/tc/f_matchall.c > +

Re: [patch net-next RFC 1/8] devlink: Support for pipeline debug (dpipe)

2017-02-17 Thread Simon Horman
Hi Jiri, On Thu, Feb 16, 2017 at 04:22:37PM +0100, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > The pipeline debug is used to export the pipeline abstractions > for the main objects - tables, headers and entries. The only support for > set is for changing the counter

Re: [PATCH iproute2 1/1] man page: add page for skbmod action

2017-02-17 Thread Simon Horman
devlink-sb.8 \ > ifstat.8 FWIW the above does not seem to apply cleanly against the net-next branch. The above not withstanding I am very pleased to see this documentation and in particular the presence of examples in it. Reviewed-by: Simon Horman <simon.hor...@netronome.com> Do you

[PATCH net-next (repost)] nfp: Use PCI_DEVICE_ID_NETRONOME_NFP* defines

2017-02-17 Thread Simon Horman
Use PCI_DEVICE_ID_NETRONOME_NFP*, defined in linux/pci_ids.h, rather than replicating the same values in the NFP driver. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- * Reposted with subject and changelog adjusted to be less likely to be flagged as spam --- drivers/net/et

Re: [PATCH net-next v4 1/2] net sched actions: Add support for user cookies

2017-01-17 Thread Simon Horman
e some worthwhile comments regarding the implementation but schematically I like what I see: Reviewed-by: Simon Horman <simon.hor...@netronome.com>

[PATCH net v3] ravb: do not use zero-length alignment DMA descriptor

2017-01-16 Thread Simon Horman
109073] Memory Limit: none [ 21.112126] ---[ end Kernel panic - not syncing: Fatal exception in interrupt Fixes: 2f45d1902acf ("ravb: minimize TX data copying") Signed-off-by: Masaru Nagai <masaru.nagai...@renesas.com Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- v3 [

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-08-22 Thread Simon Horman
On Mon, Aug 22, 2016 at 07:11:27AM -0600, David Ahern wrote: > On 8/22/16 6:21 AM, Simon Horman wrote: > >> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c > >> index 1ecbd7715f6d..6d78f162a88b 100644 > >> --- a/net/openvswitch/actions.c > &

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-08-22 Thread Simon Horman
On Fri, Aug 19, 2016 at 10:09:01AM -0700, David Ahern wrote: > As reported by Lennert the MPLS GSO code is failing to properly segment > large packets. There are a couple of problems: > > 1. the inner protocol is not set so the gso segment functions for inner >protocol layers are not getting

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-08-22 Thread Simon Horman
On Wed, Aug 10, 2016 at 10:17:30AM -0700, Joe Stringer wrote: > On 10 August 2016 at 03:20, Simon Horman <simon.hor...@netronome.com> wrote: > > On Tue, Aug 09, 2016 at 08:47:40AM -0700, pravin shelar wrote: > >> On Mon, Aug 8, 2016 at 8:17 AM, Simon Horman <simon.hor...

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-08-25 Thread Simon Horman
On Tue, Aug 23, 2016 at 10:51:47AM +0200, Simon Horman wrote: > On Mon, Aug 22, 2016 at 02:47:42PM -0700, Joe Stringer wrote: > > On 22 August 2016 at 04:04, Simon Horman <simon.hor...@netronome.com> wrote: > > > On Wed, Aug 10, 2016 at 10:17:30AM -0700, Joe Stringer wr

Re: [PATCH][RESEND] dt-bindings: net: renesas-ravb: Add support for R8A7796 RAVB

2016-10-06 Thread Simon Horman
On Tue, Oct 04, 2016 at 07:45:46PM +0300, Laurent Pinchart wrote: > Add a new compatible string for the R8A7796 (M3-W) RAVB. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-08-26 Thread Simon Horman
On Thu, Aug 25, 2016 at 05:33:57PM -0700, Joe Stringer wrote: > On 25 August 2016 at 03:08, Simon Horman <simon.hor...@netronome.com> wrote: > > Please find my working patch below. > > > > From: Simon Horman <ho...@verge.net.au> > > Subject: [PATCH] system

Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO

2016-08-24 Thread Simon Horman
Hi David, On Tue, Aug 23, 2016 at 01:24:51PM -0600, David Ahern wrote: > On 8/22/16 8:51 AM, Simon Horman wrote: > > > > The scheme that OvS uses so far is that mac_len denotes the number of bytes > > from the start of the MAC header until its end. I

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-08-23 Thread Simon Horman
On Mon, Aug 22, 2016 at 02:47:42PM -0700, Joe Stringer wrote: > On 22 August 2016 at 04:04, Simon Horman <simon.hor...@netronome.com> wrote: > > On Wed, Aug 10, 2016 at 10:17:30AM -0700, Joe Stringer wrote: > >> On 10 August 2016 at 03:20, Simon Horman <simon.hor...

Re: [PATCH net-next v4 0/3] net: mpls: fragmentation and gso fixes for locally originated traffic

2016-08-29 Thread Simon Horman
On Fri, Aug 26, 2016 at 11:41:37AM -0700, David Miller wrote: > From: David Ahern > Date: Wed, 24 Aug 2016 20:10:42 -0700 > > > This series fixes mtu and fragmentation for tunnels using lwtunnel > > output redirect, and fixes GSO for MPLS for locally originated traffic

Re: [PATCH net-next v4 0/3] net: mpls: fragmentation and gso fixes for locally originated traffic

2016-08-29 Thread Simon Horman
On Mon, Aug 29, 2016 at 02:07:30PM +0200, Simon Horman wrote: > On Fri, Aug 26, 2016 at 11:41:37AM -0700, David Miller wrote: > > From: David Ahern <d...@cumulusnetworks.com> > > Date: Wed, 24 Aug 2016 20:10:42 -0700 > > > > > This series fixes mtu and frag

Re: [PATCH/RFC 00/12] Programming Open vSwitch (-like) flows into hardware using SwitchDev

2016-09-29 Thread Simon Horman
Hi Or, On Wed, Sep 28, 2016 at 04:54:40PM +0300, Or Gerlitz wrote: > On Wed, Sep 28, 2016 at 3:42 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > > A different approach, not implemented by this patch-set, is for user-space > > to program flows into h

[PATCH/RFC 04/12] rocker: Add Open vSwitch (-like) flow support

2016-09-28 Thread Simon Horman
Prototype programming of Open vSwitch (-like) flows into hardware by implementing SWITCHDEV_OBJ_OVS_FLOW type objects in the rocker_port_obj_{add,del} SDO, a new object type that was added by an earlier patch in that forms part of this prototype. Signed-off-by: Simon Horman <simon.

[PATCH/RFC 03/12] switchdev: Add support for getting port object details

2016-09-28 Thread Simon Horman
in with sufficient detail to allow it to be looked up and the driver may then fill in other details of the object. A follow up patch will prototype using this new SDO to retrieve statistics for Open vSwitch (-like) flows that have been programmed into hardware. Signed-off-by: Simon Horman

[PATCH/RFC 05/12] rocker: Support Open vSwitch (-like) flow stats

2016-09-28 Thread Simon Horman
Prototype an implementation of the new switchdev_port_obj_get SDO for the SWITCHDEV_OBJ_OVS_FLOW object type. This allows retrieval of statistics for Open vSwitch (-like) flows which have been programmed into hardware. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drive

[PATCH/RFC 11/12] openvswitch: Support programming of flows into hardware

2016-09-28 Thread Simon Horman
a) supports tracking tcp_flags and b) by implication parses L4 headers. If that is a requirement of allowing Open vSwitch flows to be programmed into hardware, then so be it. But if it is a hard requirement then it may eliminate some hardware options. Signed-off-by: Simon Horman <simon.

[PATCH/RFC 06/12] rocker: Add helper to check ports belong to the same rocker switch

2016-09-28 Thread Simon Horman
This will be used by a follow-up patch to add Add Open vSwitch (-like) flow support to the OF-DPA rocker world. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/rocker/rocker.h | 4 drivers/net/ethernet/rocker/rocker_main.c | 15

[PATCH/RFC 08/12] rocker: Support Open vSwitch (-like) flow stats in OF-DPA world

2016-09-28 Thread Simon Horman
Prototype an implementation of the new switchdev_port_obj_get SDO for the SWITCHDEV_OBJ_OVS_FLOW object type. This allows retrieval of statistics for Open vSwitch (-like) flows which have been programmed into hardware. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drive

[PATCH/RFC 07/12] rocker: switchdev Add Open vSwitch (-like) flow support to OF-DPA world

2016-09-28 Thread Simon Horman
. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/rocker/rocker_ofdpa.c | 261 + 1 file changed, 261 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c index fcad90

[PATCH/RFC 09/12] openvswitch: Add key_attrs to struct sw_flow_match

2016-09-28 Thread Simon Horman
This is in preparation for using key_attrs outside of their current context to allow quickly checking which attributes are set. This is in turn in preparation for prototyping programming Open vSwitch (-like) flows into hardware. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --

[PATCH/RFC 12/12] hack: rocker: no ip frag match

2016-09-28 Thread Simon Horman
-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/rocker/rocker_ofdpa.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c index 3b441359a3a7..2f20f1ded5bf 100644 --- a/drive

[PATCH/RFC 02/12] switchdev: Add Open vSwitch (-like) flow object support

2016-09-28 Thread Simon Horman
if switchdev is an appropriate mechanism for programming Open vSwitch (-like) flows into hardware. The data structures can be tweaked/reworked as needed. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- include/net/switchdev.h | 39 +++ net/switchdev/switc

[PATCH/RFC 01/12] sw_flow: make struct sw_flow_key available outside of net/openvswitch/

2016-09-28 Thread Simon Horman
in struct sw_flow_key which have ovs in their name. Some consideration could be given to: * Renaming them to make them more generic * Providing a trimmed-down structure. * Using an alternate structure Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- include/linux/sw_flow.h

[PATCH/RFC 00/12] Programming Open vSwitch (-like) flows into hardware using SwitchDev

2016-09-28 Thread Simon Horman
. And there is some scope to share infrastructure in the kernel. Simon Horman (12): sw_flow: make struct sw_flow_key available outside of net/openvswitch/ switchdev: Add Open vSwitch (-like) flow object support switchdev: Add support for getting port object details rocker: Add Open vSwitch

[PATCH/RFC net-next] ravb: Add dma_unmap_single in ravb_ring_free

2016-11-07 Thread Simon Horman
_free, and fixes its problem. Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- Sergei, this is a patch from the Gen3 3.3.2 BSP. Please consider if it is appropriate for mainline. --- drivers/net/ether

Re: [patch net-next 5/8] Introduce sample tc action

2016-11-11 Thread Simon Horman
On Fri, Nov 11, 2016 at 08:28:50AM +, Yotam Gigi wrote: ... > John, as a result of your question I realized that our hardware does do > randomized sampling that I was not aware of. I will use the extensibility of > the API and implement a random keyword, that will be offloaded in our >

[PATCH nf-next 2/2] ipvs: Decrement ttl

2016-11-15 Thread Simon Horman
out_rt() and in __ip_vs_get_out_rt_v6(), for the IPv6 case. decrement_ttl() implements the actual functionality for the two cases. Signed-off-by: Dwip Banerjee <d...@linux.vnet.ibm.com> Acked-by: Julian Anastasov <j...@ssi.bg> Signed-off-by: Simon Horman <ho...@verge.net.au>

[PATCH nf-next 1/2] ipvs: Use IS_ERR_OR_NULL(svc) instead of IS_ERR(svc) || svc == NULL

2016-11-15 Thread Simon Horman
From: Gao Feng <f...@ikuai8.com> This minor refactoring does not change the logic of function ip_vs_genl_dump_dests. Signed-off-by: Gao Feng <f...@ikuai8.com> Acked-by: Julian Anastasov <j...@ssi.bg> Signed-off-by: Simon Horman <ho...@verge.net.au> --- net/netfilter/ip

[GIT PULL nf-next 0/2] IPVS Updates for v4.10

2016-11-15 Thread Simon Horman
Hi Pablo, please consider these enhancements to the IPVS for v4.10. * Decrement the IP ttl in all the modes in order to prevent infinite route loops. Thanks to Dwip Banerjee. * Use IS_ERR_OR_NULL macro. Clean-up from Gao Feng. The following changes since commit

Re: [PATCH/RFC] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2016-11-15 Thread Simon Horman
On Tue, Nov 01, 2016 at 10:32:17AM +0100, Simon Horman wrote: > On Mon, Oct 31, 2016 at 01:24:31PM -0400, David Miller wrote: > > From: Geert Uytterhoeven <geert+rene...@glider.be> > > Date: Mon, 31 Oct 2016 18:13:38 +0100 > > > > > The limitation to 10/100Mbit

Re: [PATCH iproute2 0/2] tc: flower: Support matching on SCTP ports

2016-11-18 Thread Simon Horman
On Sat, Nov 12, 2016 at 10:32:09AM +0300, Stephen Hemminger wrote: > On Thu, 3 Nov 2016 13:26:39 +0100 > Simon Horman <simon.hor...@netronome.com> wrote: > > > Hi, > > > > this short series adds support for matching on SCTP ports in the same way > > that m

Re: [PATCH/RFC] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2016-11-01 Thread Simon Horman
On Mon, Oct 31, 2016 at 01:24:31PM -0400, David Miller wrote: > From: Geert Uytterhoeven > Date: Mon, 31 Oct 2016 18:13:38 +0100 > > > The limitation to 10/100Mbit speeds on R-Car Gen3 is valid for R-Car H3 > > ES1.0 only. Check for the exact SoC model to allow 1Gbps on

Re: [PATCH] netfilter: ip_vs_sync: fix bogus maybe-uninitialized warning

2016-10-28 Thread Simon Horman
is identical, but seems error-prone, so I'm changing > > > this in the process to directly copy the two members. This change > > > seemed to have no effect on the object code or the warning, but > > > it deals with the same data, so I kept the two changes together. > > > > > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > > > > OK, > > > > Acked-by: Julian Anastasov <j...@ssi.bg> > > > > I guess, Simon will take the patch for ipvs-next. > > @Simon: If you have no more pending updates, I can save you one pull > request for this small fix by placing this. Thanks Pablo, please do. Signed-off-by: Simon Horman <ho...@verge.net.au>

Re: [PATCH iproute2] tc: flower: Fix usage message

2016-11-03 Thread Simon Horman
On Wed, Nov 02, 2016 at 05:09:58PM +0200, Paul Blakey wrote: > Remove left over usage from removal of eth_type argument. > > Fixes: 488b41d020fb ('tc: flower no need to specify the ethertype') > Signed-off-by: Paul Blakey <pa...@mellanox.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

[PATCH net-next] net/sched: cls_flower: Support matching on SCTP ports

2016-11-03 Thread Simon Horman
Support matching on SCTP ports in the same way that matching on TCP and UDP ports is already supported. Example usage: tc qdisc add dev eth0 ingress tc filter add dev eth0 protocol ip parent : \ flower indev eth0 ip_proto sctp dst_port 80 \ action drop Signed-off-by: Simon

[PATCH] net/sched: cls_flower: Support matching on SCTP ports

2016-11-03 Thread Simon Horman
Support matching on SCTP ports in the same way that matching on TCP and UDP ports is already supported. Example usage: tc qdisc add dev eth0 ingress tc filter add dev eth0 protocol ip parent : \ flower indev eth0 ip_proto sctp dst_port 80 \ action drop Signed-off-by: Simon

Re: [PATCH] net/sched: cls_flower: Support matching on SCTP ports

2016-11-03 Thread Simon Horman
On Thu, Nov 03, 2016 at 01:24:22PM +0100, Simon Horman wrote: > Support matching on SCTP ports in the same way that matching > on TCP and UDP ports is already supported. Sorry for this duplicate, I was having network troubles and it seems to have suck out somehow.

[PATCH iproute2 2/2] tc: flower: Support matching on SCTP ports

2016-11-03 Thread Simon Horman
Support matching on SCTP ports in the same way that matching on TCP and UDP ports is already supported. Example usage: tc qdisc add dev eth0 ingress tc filter add dev eth0 protocol ip parent : \ flower indev eth0 ip_proto sctp dst_port 80 \ action drop Signed-off-by: Simon

[PATCH iproute2 1/2] tc: update headers for TCA_FLOWER_KEY_SCTP_*

2016-11-03 Thread Simon Horman
These are proposed changes for net-next. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- include/linux/pkt_cls.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h index b47ed3af22b6..974155a67d2d 100644 --- a/include

[PATCH iproute2 0/2] tc: flower: Support matching on SCTP ports

2016-11-03 Thread Simon Horman
parent : \ flower indev eth0 ip_proto sctp dst_port 80 \ action drop Simon Horman (2): tc: update headers for TCA_FLOWER_KEY_SCTP_* tc: flower: Support matching on SCTP ports include/linux/pkt_cls.h | 5 tc/f_flower.c | 65

Re: [Patch net] ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr

2016-11-04 Thread Simon Horman
gt; > Cc: Pablo Neira Ayuso <pa...@netfilter.org> > Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> Signed-off-by: Simon Horman <ho...@verge.net.au> Pablo, can you take this one into nf? > --- > net/netfilter/ipvs/ip_vs_ctl.c | 2 +- > 1 file changed, 1 inse

Re: [PATCH iproute2] tc: cls_bpf: handle skip_sw and skip_hw flags

2016-10-13 Thread Simon Horman
t;jakub.kicin...@netronome.com> > > Acked-by: Daniel Borkmann <dan...@iogearbox.net> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [PATCH] sh_eth: add wake-on-lan support via magic packet

2016-12-08 Thread Simon Horman
On do, dec 08, 2016 at 08:16:20 +0100, Niklas Söderlund wrote: > Hi Geert, > > Thanks for testing and your feedback. > > On 2016-12-07 19:14:40 +0100, Geert Uytterhoeven wrote: > > Hi Niklas, > > > > On Wed, Dec 7, 2016 at 5:28 PM, Niklas Söderlund > >

Re: [PATCH] sh_eth: add wake-on-lan support via magic packet

2016-12-08 Thread Simon Horman
On Thu, Dec 08, 2016 at 04:01:05PM +0100, Niklas Söderlund wrote: > Hi Simon, > > Thanks for your feedback. > > On 2016-12-08 14:22:44 +0100, Simon Horman wrote: > > > > > > > > > > > > --- a/drivers/net/ethernet/renesas/sh_eth.h &g

Re: [PATCH v2 net-next 1/2] flow dissector: ICMP support

2016-12-06 Thread Simon Horman
On Tue, Dec 06, 2016 at 01:26:34PM +0100, Jiri Pirko wrote: > Tue, Dec 06, 2016 at 11:51:46AM CET, simon.hor...@netronome.com wrote: > >On Mon, Dec 05, 2016 at 09:29:45AM -0800, Tom Herbert wrote: > >> On Mon, Dec 5, 2016 at 6:23 AM, Simon Horman <simon.hor...@netro

Re: [PATCH net-next v6 0/2] net/sched: cls_flower: Support matching on ICMP

2016-12-08 Thread Simon Horman
Hi Dave, Hi Or, On Thu, Dec 08, 2016 at 11:58:10AM -0500, David Miller wrote: > From: Simon Horman <simon.hor...@netronome.com> > Date: Wed, 7 Dec 2016 13:48:26 +0100 > > > this series adds support for matching on ICMP type and code to > > cls_flower. > > Serie

Re: [Patch net-next] ipvs: remove an annoying printk in netns init

2016-12-11 Thread Simon Horman
On vr, dec 09, 2016 at 09:09:59 -0800, Cong Wang wrote: > At most it is used for debugging purpose, but I don't think > it is even useful for debugging, just remove it. > > Cc: Simon Horman <ho...@verge.net.au> > Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> Thanks, applied.

Re: [PATCH iproute2 1/2] tc: flower: Fix typo in the flower man page

2016-12-15 Thread Simon Horman
On Tue, Dec 13, 2016 at 07:33:51AM +0200, Roi Dayan wrote: > Replace vlan_eth_type with vlan_ethtype. > > Fixes: 745d91726006 ("tc: flower: Introduce vlan support") > Signed-off-by: Roi Dayan <r...@mellanox.com> > Reviewed-by: Hadar Hen Zion <had...@mellan

Re: [PATCH net 2/2] net/sched: cls_flower: Use masked key when calling HW offloads

2016-12-15 Thread Simon Horman
Hi Paul, On Wed, Dec 14, 2016 at 07:00:58PM +0200, Paul Blakey wrote: > Zero bits on the mask signify a "don't care" on the corresponding bits > in key. Some HWs require those bits on the key to be zero. Since these > bits are masked anyway, it's okay to provide the masked key to all > drivers. >

Re: [PATCH iproute2 2/2] tc/m_tunnel_key: Add dest UDP port to tunnel key action

2016-12-15 Thread Simon Horman
On Thu, Dec 15, 2016 at 02:03:36PM +0100, Simon Horman wrote: > On Tue, Dec 13, 2016 at 10:07:47AM +0200, Hadar Hen Zion wrote: > > Enhance tunnel key action parameters by adding destination UDP port. > > > > Signed-off-by: Hadar Hen Zion <had...@mellanox.com> &g

[PATCH iproute2/net-next 0/2] tc: flower: enhance mask support

2016-12-16 Thread Simon Horman
eters" Simon Horman (2): tc: flower: document that *_ip parameters take a PREFIX as an argument. tc: flower: Allow *_mac options to accept a mask man/man8/tc-flower.8 | 41 +++-- tc/f_flower.c| 51

[PATCH iproute2/net-next 1/2] tc: flower: document that *_ip parameters take a PREFIX as an argument.

2016-12-16 Thread Simon Horman
action drop tc filter add dev eth0 protocol ipv6 parent : flower \ indev eth0 dst_ip 2001:DB8::1 action drop Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- man/man8/tc-flower.8 | 28 ++-- tc/f_flower.c| 8 2 files chang

[PATCH iproute2/net-next 2/2] tc: flower: Allow *_mac options to accept a mask

2016-12-16 Thread Simon Horman
drop tc filter add dev eth0 protocol ip parent : flower indev eth0 \ src_mac 52:54:00:00:00:00 action drop Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- man/man8/tc-flower.8 | 13 + tc/f_flower.c| 43 --- 2

Re: [PATCH net 2/2] net/sched: cls_flower: Use masked key when calling HW offloads

2016-12-15 Thread Simon Horman
On Thu, Dec 15, 2016 at 04:12:05PM +0200, Or Gerlitz wrote: > On 12/15/2016 3:50 PM, Simon Horman wrote: > >>Zero bits on the mask signify a "don't care" on the corresponding bits > >>in key. Some HWs require those bits on the key to be zero. Since these > &

[PATCH net-next v3 2/2] net/sched: cls_flower: Support matching on ICMP type and code

2016-12-07 Thread Simon Horman
type 128 code 0 action drop Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- v3 * Use separate dissector key FLOW_DISSECTOR_KEY_ICMP * Use separate structure to hold icmp fields, this does not share storage with ports v2 * Move helpers to another patch --- include/uapi

[PATCH net-next v3 0/2] net/sched: cls_flower: Support matching on ICMP

2016-12-07 Thread Simon Horman
Hi, this series adds support for matching on ICMP type and code to cls_flower. Changes v2->v3: * Add FLOW_DISSECTOR_KEY_ICMP and use separate structure for ICMP Changes v1->v2: * Include all dissector helpers in first patch Simon Horman (2): flow dissector: ICMP support net

[PATCH net-next v3 1/2] flow dissector: ICMP support

2016-12-07 Thread Simon Horman
Allow dissection of ICMP(V6) type and code. This should only occur if a packet is ICMP(V6) and the dissector has FLOW_DISSECTOR_KEY_ICMP set. There are currently no users of FLOW_DISSECTOR_KEY_ICMP. A follow-up patch will allow FLOW_DISSECTOR_KEY_ICMP to be used by the flower classifier. --- v3 *

[PATCH v2 iproute2/net-next 1/3] tc: flower: update headers for TCA_FLOWER_KEY_ICMP*

2016-12-07 Thread Simon Horman
These are proposed changes for net-next. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- include/linux/pkt_cls.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h index a3d8a4f17d8e..fa435ea8ad21 100644 --- a/i

[PATCH v2 iproute2/net-next 3/3] tc: flower: support matching on ICMP type and code

2016-12-07 Thread Simon Horman
type 128 code 0 action drop Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- v2 * Rebase * Do not run noths() on u8 entity --- man/man8/tc-flower.8 | 20 --- tc/f_flower.c| 96 +--- 2 files changed, 106 insertions(

[PATCH v2 iproute2/net-next 0/3] tc: flower: Support matching on ICMP

2016-12-07 Thread Simon Horman
to the corresponding kernel patches. Changes since v1: * Rebase * Do not run noths() on u8 entity Simon Horman (3): tc: flower: update headers for TCA_FLOWER_KEY_ICMP* tc: flower: introduce enum flower_endpoint tc: flower: support matching on ICMP type and code include/linux/pkt_cls.h | 10 man

[PATCH v2 iproute2/net-next 2/3] tc: flower: introduce enum flower_endpoint

2016-12-07 Thread Simon Horman
Introduce enum flower_endpoint and use it instead of a bool as the type for paramatising source and destination. This is intended to improve read-ability and provide some type checking of endpoint parameters. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- tc/f_flower.

Re: [PATCH net-next v3 1/2] flow dissector: ICMP support

2016-12-07 Thread Simon Horman
On Wed, Dec 07, 2016 at 11:01:48AM +0100, Jiri Pirko wrote: > Wed, Dec 07, 2016 at 10:41:36AM CET, simon.hor...@netronome.com wrote: > >Allow dissection of ICMP(V6) type and code. This should only occur > >if a packet is ICMP(V6) and the dissector has FLOW_DISSECTOR_KEY_ICMP set. > > > >There are

[PATCH net-next v4 1/2] flow dissector: ICMP support

2016-12-07 Thread Simon Horman
Allow dissection of ICMP(V6) type and code. This should only occur if a packet is ICMP(V6) and the dissector has FLOW_DISSECTOR_KEY_ICMP set. There are currently no users of FLOW_DISSECTOR_KEY_ICMP. A follow-up patch will allow FLOW_DISSECTOR_KEY_ICMP to be used by the flower classifier. --- v4 *

[PATCH net-next v4 2/2] net/sched: cls_flower: Support matching on ICMP type and code

2016-12-07 Thread Simon Horman
type 128 code 0 action drop Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- v3 * Use separate dissector key FLOW_DISSECTOR_KEY_ICMP * Use separate structure to hold icmp fields, this does not share storage with ports v2 * Move helpers to another patch --- include/uapi

[PATCH net-next v4 0/2] net/sched: cls_flower: Support matching on ICMP

2016-12-07 Thread Simon Horman
Y_ICMP and use separate structure for ICMP Changes v1->v2: * Include all dissector helpers in first patch Simon Horman (2): flow dissector: ICMP support net/sched: cls_flower: Support matching on ICMP type and code include/net/flow_dissector.h | 30 +++ include/u

[PATCH net-next v6 2/2] net/sched: cls_flower: Support matching on ICMP type and code

2016-12-07 Thread Simon Horman
type 128 code 0 action drop Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- v5 * Open-code checking for icmp protocols rather than using helpers v4 * No change v3 * Use separate dissector key FLOW_DISSECTOR_KEY_ICMP * Use separate structure to hold icmp fields, this does not

[PATCH net-next v6 1/2] flow dissector: ICMP support

2016-12-07 Thread Simon Horman
-off-by: Simon Horman <simon.hor...@netronome.com> --- v6 * Add signed-off-by line which went missing at some point v5 * Drop remaining helpers v4 * Do not add icmp to struct flow_keys, it is not needed * Do not test for ICMP protocols in packet in __skb_flow_dissect, this is also not

[PATCH net-next v6 0/2] net/sched: cls_flower: Support matching on ICMP

2016-12-07 Thread Simon Horman
in packet in __skb_flow_dissect, this is also not needed Changes v2->v3: * Add FLOW_DISSECTOR_KEY_ICMP and use separate structure for ICMP Changes v1->v2: * Include all dissector helpers in first patch Simon Horman (2): flow dissector: ICMP support net/sched: cls_flower: Support matching on ICM

[PATCH net-next v5 0/2] net/sched: cls_flower: Support matching on ICMP

2016-12-07 Thread Simon Horman
v2->v3: * Add FLOW_DISSECTOR_KEY_ICMP and use separate structure for ICMP Changes v1->v2: * Include all dissector helpers in first patch Simon Horman (2): flow dissector: ICMP support net/sched: cls_flower: Support matching on ICMP type and code include/net/flow_diss

<    1   2   3   4   5   6   7   8   9   10   >