Re: [oss-drivers] [PATCH net-next 8/9] nfp: add a helper for wrapping descriptor index

net; > struct nfp_net_r_vector; > > +/* Convenience macro for wrapping descriptor index on ring size */ > +#define D_IDX(ring, idx) ((idx) & ((ring)->cnt - 1)) Any reason not to make this a function? That notwithstanding: Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [oss-drivers] [PATCH net-next 8/9] nfp: add a helper for wrapping descriptor index

On Tue, May 16, 2017 at 12:38:57AM -0700, Jakub Kicinski wrote: > On Tue, 16 May 2017 09:08:08 +0200, Simon Horman wrote: > > On Mon, May 15, 2017 at 05:55:22PM -0700, Jakub Kicinski wrote: > > > We have a number of places where we calculate the descriptor > > > index

Re: Advice on user space application integration with tc

On Mon, May 15, 2017 at 01:39:27PM -0700, Morgan Yang wrote: > I tried on both stock CentOS 7.3 and Ubuntu 16.04 and tc-skbmod was > not support (I built tc from the latest versions of iproute2). For > tc-pedit, examples from man tc-pedit such as "pedit ex munge" were not > supported, but "pedit

[PATCH net-next 06/12] nfp: add stats and xmit helpers for representors

Provide helpers for stats and xmit on representor netdevs. Parts based on work by Bert van Leeuwen, Benjamin LaHaise and Jakub Kicinski. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/ethernet/n

[PATCH net-next 01/12] net: store port/representator id in metadata_dst

Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Sridhar Samudrala <sridhar.samudr...@intel.com> Signed-off-by: Simon Horman <ho...@verge.net.au> --- include/net/dst_metadata.h | 41 - net/core/dst.c | 15 +

[PATCH net-next 00/12] nfp: add flower app with representors

may be attached. Jakub Kicinski (3): net: store port/representator id in metadata_dst nfp: devlink add support for getting eswitch mode nfp: move physical port init into a helper Simon Horman (9): nfp: map mac_stats and vf_cfg BARs nfp: general representor implementation nfp: add stats

[PATCH net-next 09/12] nfp: add support for tx/rx with metadata portid

Allow tx/rx with metadata port id. This will be used for tx/rx of representor netdevs acting as upper-devices while a pf netdev acts as a lower-device. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/

[PATCH net-next 08/12] nfp: provide nfp_port to of nfp_net_get_mac_addr()

Provide port rather than vNIC as parameter of nfp_net_get_mac_addr. This is to allow this function to be used by representor netdevs where a vNIC may have more than one physical port none of which are associated with the vNIC. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Re

[PATCH net-next 10/12] nfp: add support for control messages for flower app

In preparation for adding a new flower app - targeted at offloading the flower classifier - provide support for control message that it will use to communicate with the NFP. Based in part on work by Bert van Leeuwen. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by:

[PATCH net-next 05/12] nfp: general representor implementation

Provide infrastructure to create and destroy representors of a given type. Parts based on work by Bert van Leeuwen, Benjamin LaHaise, and Jakub Kicinski. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/

[PATCH net-next 04/12] nfp: map mac_stats and vf_cfg BARs

Kicinski. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/ethernet/netronome/nfp/nfp_main.h | 8 ++ drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 116 +++-- drivers/net/ethern

[PATCH net-next 02/12] nfp: devlink add support for getting eswitch mode

From: Jakub Kicinski <jakub.kicin...@netronome.com> Add app callback for reporting eswitch mode. Non-SRIOV apps should not implement this callback, nfp_app code will then respond with -EOPNOTSUPP. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by:

[PATCH net-next 11/12] nfp: add flower app

-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile | 1 + drivers/net/ethernet/netronome/nfp/flower/main.c | 294 +++ drivers/net/ethernet/netronome/nfp/nfp_app

[PATCH net-next 03/12] nfp: move physical port init into a helper

From: Jakub Kicinski <jakub.kicin...@netronome.com> Move MAC/PHY port init into a helper to make it easier to reuse it in the representor code. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- dr

[PATCH net-next 12/12] nfp: add VF and PF representors to flower app

Initialise VF and PF representors in flower app. Based in part on work by Benjamin LaHaise, Bert van Leeuwen and Jakub Kicinski. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/ethernet/netronom

[PATCH net-next 07/12] nfp: app callbacks for SRIOV

Add app-callbacks for app-specific initialisation of SRIOV. Disabling SRIOV is brought forward in nfp_pci_remove() so that nfp_app_sriov_disable is called while the app still exists. This is intended to be used to implement representor netdevs for virtual ports. Signed-off-by: Simon Horman

Re: [PATCH net-next v2 11/12] nfp: add flower app

On Wed, Jun 21, 2017 at 12:04:17PM +0300, Or Gerlitz wrote: > On Wed, Jun 21, 2017 at 12:36 AM, Simon Horman > <simon.hor...@netronome.com> wrote: > > Add app for flower offload. At this point the PF netdev and phys port > > representor netdevs are initialised. Follow-

Re: [oss-drivers] Re: [PATCH net-next 00/12] nfp: add flower app with representors

On Wed, Jun 21, 2017 at 12:00:50PM +0300, Or Gerlitz wrote: > On Tue, Jun 20, 2017 at 10:24 PM, Jakub Kicinski > wrote: > > On Tue, 20 Jun 2017 19:13:43 +0300, Or Gerlitz wrote: > > >>> Control queues are used to send and receive control messages which are > >>>

Re: [PATCH net-next 00/12] nfp: add flower app with representors

On Tue, Jun 20, 2017 at 07:13:43PM +0300, Or Gerlitz wrote: > On Tue, Jun 20, 2017 at 8:51 AM, Simon Horman > <simon.hor...@netronome.com> wrote: > > this series adds a flower app to the NFP driver. > > It initialises four types of netdevs: > > > > * PF net

[PATCH net-next v2 05/12] nfp: general representor implementation

Provide infrastructure to create and destroy representors of a given type. Parts based on work by Bert van Leeuwen, Benjamin LaHaise, and Jakub Kicinski. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/

[PATCH net-next v2 04/12] nfp: map mac_stats and vf_cfg BARs

Kicinski. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/ethernet/netronome/nfp/nfp_main.h | 8 ++ drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 116 +++-- drivers/net/ethern

[PATCH net-next v2 03/12] nfp: move physical port init into a helper

From: Jakub Kicinski <jakub.kicin...@netronome.com> Move MAC/PHY port init into a helper to make it easier to reuse it in the representor code. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- dr

[PATCH net-next v2 02/12] nfp: devlink add support for getting eswitch mode

From: Jakub Kicinski <jakub.kicin...@netronome.com> Add app callback for reporting eswitch mode. Non-SRIOV apps should not implement this callback, nfp_app code will then respond with -EOPNOTSUPP. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by:

[PATCH net-next v2 09/12] nfp: add support for tx/rx with metadata portid

Allow tx/rx with metadata port id. This will be used for tx/rx of representor netdevs acting as upper-devices while a pf netdev acts as a lower-device. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/

[PATCH net-next v2 07/12] nfp: app callbacks for SRIOV

Add app-callbacks for app-specific initialisation of SRIOV. Disabling SRIOV is brought forward in nfp_pci_remove() so that nfp_app_sriov_disable is called while the app still exists. This is intended to be used to implement representor netdevs for virtual ports. Signed-off-by: Simon Horman

[PATCH net-next v2 00/12] nfp: add flower app with representors

physical port init into a helper Simon Horman (9): nfp: map mac_stats and vf_cfg BARs nfp: general representor implementation nfp: add stats and xmit helpers for representors nfp: app callbacks for SRIOV nfp: provide nfp_port to of nfp_net_get_mac_addr() nfp: add support for tx/rx

[PATCH net-next v2 08/12] nfp: provide nfp_port to of nfp_net_get_mac_addr()

Provide port rather than vNIC as parameter of nfp_net_get_mac_addr. This is to allow this function to be used by representor netdevs where a vNIC may have more than one physical port none of which are associated with the vNIC. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Re

[PATCH net-next v2 10/12] nfp: add support for control messages for flower app

In preparation for adding a new flower app - targeted at offloading the flower classifier - provide support for control message that it will use to communicate with the NFP. Based in part on work by Bert van Leeuwen. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by:

[PATCH net-next v2 12/12] nfp: add VF and PF representors to flower app

Initialise VF and PF representors in flower app. Based in part on work by Benjamin LaHaise, Bert van Leeuwen and Jakub Kicinski. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/ethernet/netronom

[PATCH net-next v2 11/12] nfp: add flower app

-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile | 1 + drivers/net/ethernet/netronome/nfp/flower/main.c | 294 +++ drivers/net/ethernet/netronome/nfp/nfp_app

[PATCH net-next v2 06/12] nfp: add stats and xmit helpers for representors

Provide helpers for stats and xmit on representor netdevs. Parts based on work by Bert van Leeuwen, Benjamin LaHaise and Jakub Kicinski. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/ethernet/n

[PATCH net-next v2 01/12] net: store port/representator id in metadata_dst

Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Sridhar Samudrala <sridhar.samudr...@intel.com> Signed-off-by: Simon Horman <ho...@verge.net.au> --- include/net/dst_metadata.h | 41 - net/core/dst.c | 15 +

Re: [PATCH net-next 06/12] nfp: add stats and xmit helpers for representors

On Wed, Jun 21, 2017 at 01:15:05AM +0800, kbuild test robot wrote: > Hi Simon, > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Simon-Horman/nfp-add-flower-app-with-representors/20170620-233831 > config: arm-allmodconfig

Re: [oss-drivers] Re: [PATCH net-next 00/12] nfp: add flower app with representors

On Thu, Jun 22, 2017 at 05:39:09PM +0300, Or Gerlitz wrote: > On Wed, Jun 21, 2017 at 12:32 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > > This patchset is in two parts. > > > > The first 9 patches add code to allow representors to be instantiated

Re: [PATCH net-next v2 12/12] nfp: add VF and PF representors to flower app

On Thu, Jun 22, 2017 at 05:50:29PM +0300, Or Gerlitz wrote: > On Wed, Jun 21, 2017 at 12:36 AM, Simon Horman > <simon.hor...@netronome.com> wrote: > > Initialise VF and PF representors in flower app. > > > > Based in part on work by Benjamin LaHaise, Bert van

[PATCH net-next v3 05/12] nfp: general representor implementation

Provide infrastructure to create and destroy representors of a given type. Parts based on work by Bert van Leeuwen, Benjamin LaHaise, and Jakub Kicinski. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/

[PATCH net-next v3 06/12] nfp: add stats and xmit helpers for representors

Provide helpers for stats and xmit on representor netdevs. Parts based on work by Bert van Leeuwen, Benjamin LaHaise and Jakub Kicinski. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/ethernet/n

[PATCH net-next v3 12/12] nfp: add VF and PF representors to flower app

Initialise VF and PF representors in flower app. Based in part on work by Benjamin LaHaise, Bert van Leeuwen and Jakub Kicinski. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- v3 * Do not associate VF represen

[PATCH net-next v3 11/12] nfp: add flower app

-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile | 1 + drivers/net/ethernet/netronome/nfp/flower/main.c | 294 +++ drivers/net/ethernet/netronome/nfp/nfp_app

[PATCH net-next v3 08/12] nfp: provide nfp_port to of nfp_net_get_mac_addr()

Provide port rather than vNIC as parameter of nfp_net_get_mac_addr. This is to allow this function to be used by representor netdevs where a vNIC may have more than one physical port none of which are associated with the vNIC. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Re

[PATCH net-next v3 09/12] nfp: add support for tx/rx with metadata portid

Allow tx/rx with metadata port id. This will be used for tx/rx of representor netdevs acting as upper-devices while a pf netdev acts as a lower-device. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- drivers/

[PATCH net-next v3 10/12] nfp: add support for control messages for flower app

In preparation for adding a new flower app - targeted at offloading the flower classifier - provide support for control message that it will use to communicate with the NFP. Based in part on work by Bert van Leeuwen. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by:

[PATCH net-next v3 04/12] nfp: map mac_stats and vf_cfg BARs

Kicinski. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- v3 * Do not log an error if optional symbols are not found --- drivers/net/ethernet/netronome/nfp/nfp_main.h | 8 ++ drivers/net/ethernet/n

[PATCH net-next v3 01/12] net: store port/representator id in metadata_dst

Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Sridhar Samudrala <sridhar.samudr...@intel.com> Signed-off-by: Simon Horman <ho...@verge.net.au> --- include/net/dst_metadata.h | 41 - net/core/dst.c | 15 +

[PATCH net-next v3 07/12] nfp: app callbacks for SRIOV

Add app-callbacks for app-specific initialisation of SRIOV. Disabling SRIOV is brought forward in nfp_pci_remove() so that nfp_app_sriov_disable is called while the app still exists. This is intended to be used to implement representor netdevs for virtual ports. Signed-off-by: Simon Horman

[PATCH net-next v3 03/12] nfp: move physical port init into a helper

From: Jakub Kicinski <jakub.kicin...@netronome.com> Move MAC/PHY port init into a helper to make it easier to reuse it in the representor code. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- dr

[PATCH net-next v3 02/12] nfp: devlink add support for getting eswitch mode

From: Jakub Kicinski <jakub.kicin...@netronome.com> Add app callback for reporting eswitch mode. Non-SRIOV apps should not implement this callback, nfp_app code will then respond with -EOPNOTSUPP. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by:

[PATCH net-next v3 00/12] nfp: add flower app with representors

. Review of v1 and v2 of this patchset have been addressed either through discussion on-list or changes in this patchset. Jakub Kicinski (3): net: store port/representator id in metadata_dst nfp: devlink add support for getting eswitch mode nfp: move physical port init into a helper Simon

Re: [PATCH] ravb: add wake-on-lan support via magic packet

On Tue, May 16, 2017 at 02:16:04PM +0200, Niklas Söderlund wrote: > Hi, > > On 2017-05-16 13:36:21 +0200, Geert Uytterhoeven wrote: > > Hi Simon, > > > > On Tue, May 16, 2017 at 1:01 PM, Simon Horman <ho...@verge.net.au> wrote: > > > On Tue, May 16, 20

Re: [patch net-next] net: sched: cls_api: make reclassify return all the way back to the original tp

iterate starting from the original tp - start > of chain 0. > > Signed-off-by: Jiri Pirko <j...@mellanox.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com> > --- > net/sched/cls_api.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > &g

[PATCH] ipvs: SNAT packet replies only for NATed connections

ector. So, better to be more precise for the reply traffic. As replies are not expected for DR/TUN connections, better to not touch them. Reported-by: Nick Moriarty <nick.moria...@york.ac.uk> Tested-by: Nick Moriarty <nick.moria...@york.ac.uk> Signed-off-by: Julian Anastasov <j...@ss

[GIT PULL 0/1] IPVS Fixes for v4.12

Hi Pablo, please consider this fix to IPVS for v4.12. * It is a fix from Julian Anastasov to only SNAT SNAT packet replies only for NATed connections My understanding is that this fix is appropriate for 4.9.25, 4.10.13, 4.11 as well as the nf tree. Julian has separately posted backports for

Re: [PATCH/RFC net-next v2 4/4] net/sched: cls_flower: allow control of tree traversal on packet parse errors

On Mon, May 08, 2017 at 07:32:02AM -0400, Jamal Hadi Salim wrote: > On 17-05-05 08:47 AM, Simon Horman wrote: > >Allow control how the tree of qdisc, classes and filters is further > >traversed if an error is encountered when parsing the packet in order to > >match t

Re: [oss-drivers] [PATCH net-next 0/4] xdp: use netlink extended ACK reporting

don't print the error to logs in patch 1. > > Jakub Kicinski (4): > netlink: add NULL-friendly helper for setting extended ACK message > xdp: propagate extended ack to XDP setup > nfp: make use of extended ack message reporting > virtio_net: make use of extended ack message reporting Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [PATCH/RFC net-next 0/4] net/sched: cls_flower: avoid false matching of truncated packets

On Sun, Apr 30, 2017 at 09:51:30AM -0400, Jamal Hadi Salim wrote: > On 17-04-28 10:14 AM, Simon Horman wrote: > >On Fri, Apr 28, 2017 at 09:41:00AM -0400, Jamal Hadi Salim wrote: > >>On 17-04-28 09:11 AM, Simon Horman wrote: > [..] > >>A default lower prio match

Re: [PATCH] flower: check unused bits in MPLS fields

sed, check those bits to ensure that they are actually 0 as suggested > >by Jamal. > > > >Signed-off-by: Benjamin LaHaise <benjamin.laha...@netronome.com> > >Cc: David Miller <da...@davemloft.net> > >Cc: Jamal Hadi Salim <j...@mojatatu.com> > >

Re: [oss-drivers] Re: [PATCH/RFC net-next 0/4] net/sched: cls_flower: avoid false matching of truncated packets

On Mon, May 01, 2017 at 09:35:47PM -0400, Jamal Hadi Salim wrote: > On 17-05-01 06:36 AM, Simon Horman wrote: > >On Sun, Apr 30, 2017 at 09:51:30AM -0400, Jamal Hadi Salim wrote: > >>On 17-04-28 10:14 AM, Simon Horman wrote: > > [..] > > >>minimal some

[PATCH/RFC net-next v2 4/4] net/sched: cls_flower: allow control of tree traversal on packet parse errors

be parsed. # tc qdisc del dev eth0 ingress; tc qdisc add dev eth0 ingress # tc filter add dev eth0 protocol ip parent : flower \ indev eth0 ip_proto udp dst_port 80 truncated drop action continue Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Benjamin L

[PATCH/RFC net-next v2 3/4] net/sched: cls_flower: do not match if dissection fails

as packets with zero ICMP code and type. Separate patches to the flow dissector are required in order for it to return errors in the above cases. Fixes: 77b9900ef53a ("tc: introduce Flower classifier") Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by:

[PATCH/RFC net-next v2 2/4] flow dissector: return error on icmp dissection under-run

. The behavioural update for flower only takes effect with a separate patch to have it refuse to match if dissection fails. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Benjamin LaHaise <benjamin.laha...@netronome.com> --- rfc2 * Update changelog --- net/core/flow_diss

[PATCH/RFC net-next v2 0/4] net/sched: cls_flower: avoid false matching of truncated packets

TCA_FLOWER_META_TRUNCATED after discussion with Jamal. * Update changelog for "flow dissector" patches to make it clearer what the before and after behaviours are. Simon Horman (4): flow dissector: return error on port dissection under-run flow dissector: return error on icmp

[PATCH/RFC iproute2/net-next v2 1/2] tc: flower: update headers for TCA_FLOWER_META_TRUNCATED

This change is proposed for net-next. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- include/linux/pkt_cls.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h index f1129e383b2a..dfbd5137e275 100644 --- a/include/linux/pkt

[PATCH/RFC iproute2/net-next v2 2/2] tc: flower: allow control of tree traversal on packet parse errors

be parsed. # tc qdisc del dev eth0 ingress; tc qdisc add dev eth0 ingress # tc filter add dev eth0 protocol ip parent : flower \ indev eth0 ip_proto udp dst_port 80 truncated drop action continue Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- man/man8/tc-flower.

[PATCH/RFC net-next v2 1/4] flow dissector: return error on port dissection under-run

will should only be for truncated packets. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Benjamin LaHaise <benjamin.laha...@netronome.com> --- rfc2 * Update changelog --- include/linux/skbuff.h| 11 --- net/core/flow_diss

[PATCH/RFC iproute2/net-next v2 0/2] tc: flower: allow control of tree traversal on packet parse errors

detailed description. Changes between RFCv1 and RFCv2: * Rename new attribute in last path TCA_FLOWER_META_TRUNCATED * Drop patch to add TCA_FLOWER_KEY_MPLS*: it is in net-next now Simon Horman (2): tc: flower: update headers for TCA_FLOWER_META_TRUNCATED tc: flower: allow control of tree

Re: [PATCH iproute] tc: Reflect HW offload status

nning > over older kernel. > > Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> > Reviewed-by: Jiri Pirko <j...@mellanox.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

[PATCH/RFC net-next 3/9] nfp: provide infrastructure for offloading flower based TC filters

flower app enables tc offloads on representors by default. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile| 3 +- drivers/net/ethernet/ne

[PATCH/RFC net-next 5/9] nfp: extend flower matching capabilities

senvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/Makefile| 1 + drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 4 + drivers/net/ethernet/netronome/nfp/flower/main.h | 6 + drivers/net/ethernet/ne

[PATCH/RFC net-next 1/9] net: switchdev: add SET_SWITCHDEV_OPS helper

Add a helper to allow switchdev ops to be set if NET_SWITCHDEV is configured and do nothing otherwise. This allows for slightly cleaner code which uses switchdev but does not select NET_SWITCHDEV. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- include/net/switchdev.h | 4 +

Re: [oss-drivers] Re: [PATCH/RFC net-next 4/9] nfp: extend flower add flow offload

On Tue, Jun 27, 2017 at 11:13:30PM -0700, Jakub Kicinski wrote: > On Wed, 28 Jun 2017 01:21:44 +0200, Simon Horman wrote: > > diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c > > b/drivers/net/ethernet/netronome/nfp/flower/offload.c > > index 9127c28ea9c3

Re: [PATCH/RFC net-next 3/9] nfp: provide infrastructure for offloading flower based TC filters

On Tue, Jun 27, 2017 at 11:13:06PM -0700, Jakub Kicinski wrote: > On Wed, 28 Jun 2017 01:21:43 +0200, Simon Horman wrote: > > From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> > > > > Adds a flower based TC offload handler for representor devic

[PATCH/RFC net-next 6/9] nfp: add basic action capabilities to flower offloads

From: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Adds push vlan, pop vlan, output and drop action capabilities to flower offloads. Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor..

[PATCH/RFC net-next 2/9] nfp: add phys_switch_id support

is the representor for the PF. And eth5 is the PF netdev. Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_common.c| 3 +++ drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 2 ++ drivers/net/ethernet/netronome/nfp/nfp_port.c

Re: [PATCH] dt-bindings: net: renesas-ravb: Add support for R8A77995 RAVB

n r8a77970 patch. > >https://marc.info/?l=linux-renesas-soc=150524655515476 > >So this is against net-next, right? The net.git repo now has a patch > making me a reviewer for the Renesas bindings too. Acked-by: Simon Horman <horms+rene...@verge.net.au>

Re: [oss-drivers] Re: [PATCH net-next 2/2] flow_dissector: dissect tunnel info

On Mon, Oct 02, 2017 at 12:36:33PM -0700, Tom Herbert wrote: > On Mon, Oct 2, 2017 at 1:41 AM, Simon Horman <simon.hor...@netronome.com> > wrote: > > Move dissection of tunnel info from the flower classifier to the flow > > dissector where all other dissection occurs.

Re: [PATCH net-next 2/2] flow_dissector: dissect tunnel info

On Tue, Oct 03, 2017 at 11:17:46AM -0700, Tom Herbert wrote: > On Tue, Oct 3, 2017 at 2:40 AM, Simon Horman <simon.hor...@netronome.com> > wrote: > > On Mon, Oct 02, 2017 at 01:37:55PM -0700, Tom Herbert wrote: > >> On Mon, Oct 2, 2017 at 1:41 AM, Simon Horman

[PATCH v2 net-next] ravb: RX checksum offload

-off-by: Simon Horman <horms+rene...@verge.net.au> --- v2 Address review of v1 by Sergei Shtylyov * set features rather than oring them with (zero) existing values: * Set/unset using a single call to ravb_modify() --- drivers/net/ethernet/renesas/ravb_main.c | 55 +

Re: [oss-drivers] Re: [PATCH net-next 0/7] nfp: extend match and action for flower offload

On Mon, Oct 09, 2017 at 08:45:41AM -0700, Tom Herbert wrote: > On Mon, Oct 9, 2017 at 1:05 AM, Simon Horman <simon.hor...@netronome.com> > wrote: > > On Fri, Oct 06, 2017 at 08:34:59AM -0700, Tom Herbert wrote: > >> Simon, > >> > >> Maybe a bit off to

[PATCH net-next 7/7] nfp: add set tcp and udp header action flower offload

onome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/action.c | 42 ++ drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 9 + 2 file

[PATCH net-next 5/7] nfp: add set ipv4 header action flower offload

onome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/action.c | 46 ++ drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 10 + 2 file

[PATCH net-next 2/7] nfp: add IPv4 ttl and tos match offloading support

gt; Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/match.c | 11 ++- drivers/net/ethernet/netronome/nfp/flower/offload.c | 4 2 files changed, 10 insertions(+), 5

[PATCH net-next 3/7] nfp: add IPv6 ttl and tos match offloading support

gt; Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/match.c | 11 ++- drivers/net/ethernet/netronome/nfp/flower/offload.c | 10 -- 2 files changed, 10 insertions(+

[PATCH net-next 6/7] nfp: add set ipv6 source and destination address

onome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/action.c | 72 ++ drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 11 2 file

[PATCH net-next 1/7] nfp: add mpls match offloading support

gt; Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h| 5 + drivers/net/ethernet/netronome/nfp/flower/match.c | 17 +++-- drivers/net/ethernet/netron

[PATCH net-next 4/7] nfp: add set ethernet header action flower offload

gt; Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/action.c | 85 ++ drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 8 ++ 2 files changed, 93 i

[PATCH net-next 0/7] nfp: extend match and action for flower offload

Pieter says: This series extends flower offload match and action capabilities. It specifically adds offload capabilities for matching on MPLS, TTL, TOS and flow label. Furthermore offload capabilities for action have been expanded to include set ethernet, ipv4, ipv6, tcp and udp headers. Pieter

[PATCH net-next 1/3] dt-bindings: net: sh_eth: add R-Car Gen[12] fallback compatibility strings

is to name common code, compatibility strings and so on after Rcar Gen2. Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- Documentation/devicetree/bindings/net/sh_eth.txt | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindin

[PATCH net-next 3/3] net: sh_eth: implement R-Car Gen[12] fallback compatibility strings

is to name common code, compatibility strings and so on after Rcar Gen2. Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- drivers/net/ethernet/renesas/sh_eth.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/r

[PATCH net-next 2/3] net: sh_eth: rename name structures as rcar_gen[12]_*

-time effect and is compile-tested only. Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- drivers/net/ethernet/renesas/sh_eth.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drive

[PATCH net-next 0/3] net: sh_eth: add R-Car Gen[12] fallback compatibility strings

. For the above reasons and convenience when enabling new SoCs a per-generation fallback compatibility string scheme being adopted for drivers for Renesas SoCs. Simon Horman (3): dt-bindings: net: sh_eth: add R-Car Gen[12] fallback compatibility strings net: sh_eth: rename name structures

Re: [PATCH] ravb: Consolidate clock handling

On Thu, Oct 12, 2017 at 10:24:53AM +0200, Geert Uytterhoeven wrote: > The module clock is used for two purposes: > - Wake-on-LAN (WoL), which is optional, > - gPTP Timer Increment (GTI) configuration, which is mandatory. > > As the clock is needed for GTI configuration anyway, WoL is always >

Re: [PATCH] ravb: Consolidate clock handling

On Thu, Oct 12, 2017 at 02:20:45PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Thu, Oct 12, 2017 at 11:55 AM, Simon Horman <ho...@verge.net.au> wrote: > > On Thu, Oct 12, 2017 at 10:24:53AM +0200, Geert Uytterhoeven wrote: > >> The module clock is used f

Re: [patch net-next 2/3] net/sched: Change cls_flower to use IDR

On Tue, Aug 29, 2017 at 03:25:35AM +, Chris Mi wrote: > > > > -Original Message- > > From: Simon Horman [mailto:simon.hor...@netronome.com] > > Sent: Monday, August 28, 2017 7:37 PM > > To: Chris Mi <chr...@mellanox.com> > > Cc:

Re: [oss-drivers] Re: [PATCH/RFC net-next 2/2] net/sched: allow flower to match tunnel options

On Tue, Sep 12, 2017 at 11:23:55PM +0300, Or Gerlitz wrote: > On Tue, Sep 12, 2017 at 5:20 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > Allow matching on options in tunnel headers. > > This makes use of existing tunnel metadata support. > > Simon, >

Re: [PATCH] ravb: document R8A77970 bindings

On Tue, Sep 12, 2017 at 11:02:08PM +0300, Sergei Shtylyov wrote: > R-Car V3M (R8A77970) SoC also has the R-Car gen3 compatible EtherAVB > device, so document the SoC specific bindings. > > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Acked-by: Simon

Re: [oss-drivers] Re: [PATCH/RFC net-next 2/2] net/sched: allow flower to match tunnel options

On Wed, Sep 13, 2017 at 03:38:01PM +0300, Or Gerlitz wrote: > On Wed, Sep 13, 2017 at 2:59 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > On Wed, Sep 13, 2017 at 01:03:43PM +0300, Or Gerlitz wrote: > >> On Wed, Sep 13, 2017 at 12:25 PM, Simon Horman >

Re: [oss-drivers] Re: [PATCH/RFC net-next 2/2] net/sched: allow flower to match tunnel options

On Wed, Sep 13, 2017 at 01:03:43PM +0300, Or Gerlitz wrote: > On Wed, Sep 13, 2017 at 12:25 PM, Simon Horman > <simon.hor...@netronome.com> wrote: > > On Tue, Sep 12, 2017 at 11:23:55PM +0300, Or Gerlitz wrote: > >> On Tue, Sep 12, 2017 at 5:20 PM, Simon Horman >

[PATCH/RFC net-next] ravb: RX checksum offload

results collected on an R-Car Gen 3 Salvator-X/r8a7796 ES1.0. Also tested on a R-Car Gen 3 Salvator-X/r8a7795 ES1.0. By inspection this also appears to be compatible with the ravb found on R-Car Gen 2 SoCs, however, this patch is currently untested on such hardware. Signed-off-by: Simon Horman <ho

[PATCH iproute2/net-next] tc: flower: support for matching MPLS labels

filter. e.g.: tc filter add dev eth0 protocol 0x8847 parent : \ flower mpls_label 1 mpls_tc 2 mpls_ttl 3 mpls_bos 0 \ action drop Signed-off-by: Benjamin LaHaise <benjamin.laha...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-

[PATCH/RFC net-next 0/2] net/sched: support tunnel options in cls_flower and act_tunnel_key

Allow the flower classifier to match on tunnel options and the tunnel key action to set them. Tunnel options are a bytestring of up to 256 bytes. The flower classifier matching with an optional bitwise mask. Tunnel implementations may support more or less options, or none at all. Simon Horman (2

<    4   5   6   7   8   9   10   11   >