[PATCH net-next 2/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
From: Geert Uytterhoeven The limitation to 10/100Mbit speeds on R-Car Gen3 is valid for R-Car H3 ES1.0 only. Check for the exact SoC model to allow 1Gbps on newer revisions of R-Car H3, and on R-Car M3-W. Signed-off-by: Geert Uytterhoeven Signed-off-by: Simon Horman --- drivers/net/ethernet

Re: [PATCH net-next 0/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 01:16:43PM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Jan 27, 2017 at 12:04 PM, Simon Horman > wrote: > > The path from Mizuguchi-san is to address timing problems observed with > > gigabit transfers. I would like it considered al

Re: [PATCH net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 03:42:05PM +0300, Sergei Shtylyov wrote: > Hello! > > On 01/27/2017 02:04 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi > > > >This patch enables tx and rx clock internal delay modes (TDM and RDM). > > > >This is

Re: [PATCH net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 04:00:27PM +0300, Sergei Shtylyov wrote: > On 01/27/2017 02:04 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi > > > >This patch enables tx and rx clock internal delay modes (TDM and RDM). > > > >This is to address a failure in t

Re: [PATCH net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 07:55:25PM +0300, Sergei Shtylyov wrote: > On 01/27/2017 07:49 PM, Simon Horman wrote: > > >>>From: Kazuya Mizuguchi > >>> > >>>This patch enables tx and rx clock internal delay modes (TDM and RDM). > >>>

Re: [PATCH net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 09:11:35PM +0300, Sergei Shtylyov wrote: > On 01/27/2017 09:07 PM, Simon Horman wrote: > > >>>>>From: Kazuya Mizuguchi > >>>>> > >>>>>This patch enables tx and rx clock internal delay modes (TDM and RDM). >

[PATCH v2 net-next 0/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
Hi, this series adds support for gigabit communication to the Renesas EthernetAVB controller when used in conjunction with R-Car Gen3 H3 ES1.1+ and M3-W SoCs. Gigabit is already supported with R-Car Gen 2 SoCs. The patch from Geert was previously posted for inclusion in v4.10 and acked by Dave f

[PATCH v2 net-next 2/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
From: Geert Uytterhoeven The limitation to 10/100Mbit speeds on R-Car Gen3 is valid for R-Car H3 ES1.0 only. Check for the exact SoC model to allow 1Gbps on newer revisions of R-Car H3, and on R-Car M3-W. Signed-off-by: Geert Uytterhoeven Signed-off-by: Simon Horman Acked-by: Sergei Shtylyov

[PATCH v2 net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
izuguchi Signed-off-by: Simon Horman --- v2 [Simon Horman] * As suggested by Sergei Shtylyov - Add a comment to indicate that APSR_DM appears to be undocumented. - Move chip_id check outside of ravb_set_delay_mode for consistency - Call ravb_modify() once in ravb_set_delay_mode() * E

Re: [PATCH v2 net] net: free ip_vs_dest structs when refcnt=0

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 01:21:11PM +0100, Pablo Neira Ayuso wrote: > On Fri, Jan 27, 2017 at 09:07:38AM +0100, Simon Horman wrote: > > On Thu, Jan 26, 2017 at 10:49:10PM +0200, Julian Anastasov wrote: > > > > > > Hello, > > > > >

Re: [PATCH v2 net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
On Fri, Jan 27, 2017 at 10:05:58PM +0300, Sergei Shtylyov wrote: > On 01/27/2017 09:35 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi > > > >This patch enables tx and rx clock internal delay modes (TDM and RDM). > > > >This is to address a failure in t

[PATCH v3 net-next 0/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
Hi, this series adds support for gigabit communication to the Renesas EthernetAVB controller when used in conjunction with R-Car Gen3 H3 ES1.1+ and M3-W SoCs. Gigabit is already supported with R-Car Gen 2 SoCs. The patch from Geert was previously posted for inclusion in v4.10 and acked by Dave f

[PATCH v3 net-next 1/2] ravb: Add tx and rx clock internal delays mode of APSR

2017-01-27 Thread Simon Horman
izuguchi Signed-off-by: Simon Horman Acked-by: Sergei Shtylyov --- v3 [Simon Horman] * Move comment to above ravb_set_delay_mode() v2 [Simon Horman] * As suggested by Sergei Shtylyov - Add a comment to indicate that APSR_DM appears to be undocumented. - Move chip_id check outside of ravb_

[PATCH v3 net-next 2/2] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2017-01-27 Thread Simon Horman
From: Geert Uytterhoeven The limitation to 10/100Mbit speeds on R-Car Gen3 is valid for R-Car H3 ES1.0 only. Check for the exact SoC model to allow 1Gbps on newer revisions of R-Car H3, and on R-Car M3-W. Signed-off-by: Geert Uytterhoeven Signed-off-by: Simon Horman Acked-by: Sergei Shtylyov

[PATCH net] net/sched: cls_flower: Correct matching on ICMPv6 code

2017-01-30 Thread Simon Horman
action drop Without this change the code parameter above is effectively ignored. Fixes: 7b684884fbfa ("net/sched: cls_flower: Support matching on ICMP type and code") Signed-off-by: Simon Horman --- net/sched/cls_flower.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

Re: [PATCH net-next 0/2] Extract IFE logic to module

2017-02-02 Thread Simon Horman
Hi Yotam, On Tue, Jan 31, 2017 at 03:57:02PM +0200, Yotam Gigi wrote: > Extract ife logic from the tc_ife action into an independent module, and > make the tc_ife action use it. This way, the ife encapsulation can be used > by other modules other than tc_ife action. I have no objection to this mo

[PATCH/RFC net-next 2/2] net/sched: cls_flower: Support matching on ND

2017-02-02 Thread Simon Horman
136 code 0 \ nd_target 2001:470:7eb3:403:201:8eff:fe22:8fea \ nd_tll 00:01:8e:22:8f:ea action drop Signed-off-by: Simon Horman --- include/uapi/linux/pkt_cls.h | 7 +++ net/core/flow_dissector.c| 6 +++--- net/sched/cls_flower.c | 42

[PATCH/RFC net-next 0/2] net/sched: cls_flower: Support matching on ND

2017-02-02 Thread Simon Horman
rrect matching on ICMPv6 code") Simon Horman (2): flow dissector: ND support net/sched: cls_flower: Support matching on ND include/net/flow_dissector.h | 14 include/uapi/linux/pkt_cls.h | 7 net/core/flow_dissector.c| 83 +++-

[PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-02 Thread Simon Horman
Allow dissection of Neighbour Discovery target IP, and source and destination link-layer addresses for neighbour solicitation and advertisement messages. Signed-off-by: Simon Horman --- include/net/flow_dissector.h | 14 net/core/flow_dissector.c| 83

[PATCH iproute2/net-next 2/7] tc: flower: use correct type when calling flower_icmp_attr_type

2017-02-02 Thread Simon Horman
Use enum flower_icmp_field rather than bool as type of third parameter when calling flower_icmp_attr_type. Fixes: eb3b5696f163 ("tc: flower: support matching on ICMP type and code") Signed-off-by: Simon Horman -- This should not have a run-time affect assuming both

[PATCH iproute2/net-next 1/7] tc: flower: Update documentation to indicate ARP takes IPv4 prefixes

2017-02-02 Thread Simon Horman
Unlike other PREFIXES documented in the usage for tc flower, arp_sip and arp_tip take only IPV4 prefixes. Signed-off-by: Simon Horman --- man/man8/tc-flower.8 | 8 tc/f_flower.c| 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/man/man8/tc-flower.8 b/man

[PATCH iproute2/net-next 3/7] tc: flower: provide generic masked u8 parser helper

2017-02-02 Thread Simon Horman
Provide generic masked u8 paser helper and use it to parse arp operations. Also consistently use __u8 rather than uint8_t, in keeping with the pervasive style in the file. Signed-off-by: Simon Horman --- tc/f_flower.c | 55 --- 1 file changed

[PATCH iproute2/net-next 7/7] tc: flower: Support matching on ND

2017-02-02 Thread Simon Horman
136 code 0 \ nd_target 2001:470:7eb3:403:201:8eff:fe22:8fea \ nd_tll 00:01:8e:22:8f:ea action drop Signed-off-by: Simon Horman --- man/man8/tc-flower.8 | 34 -- tc/f_flower.c| 100 +++ 2 files changed, 126

[PATCH iproute2/net-next 5/7] tc: flower: support masked ICMP code and type match

2017-02-02 Thread Simon Horman
Extend ICMP code and type match to support masks. Also add missing documentation to synopsis in manpage. tc qdisc add dev eth0 ingress tc filter add dev eth0 protocol ipv6 parent : flower \ indev eth0 ip_proto icmpv6 type 128/240 code 0 action drop Signed-off-by: Simon Horman

[PATCH iproute2/net-next 6/7] tc: flower: Add TCA_FLOWER_KEY_ND_*

2017-02-02 Thread Simon Horman
Changes proposed for net-next. Signed-off-by: Simon Horman --- include/linux/pkt_cls.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h index 345551e71410..fc9e9bef726e 100644 --- a/include/linux/pkt_cls.h +++ b/include/linux/pkt_cls.h

[PATCH iproute2/net-next 4/7] tc: flower: provide generic masked u8 print helper

2017-02-02 Thread Simon Horman
Provide generic masked u8 print helper and use it to print arp operations. Also: * Make name parameter of arp op print helper const. * Consistently use __u8 rather than uint8_t, in keeping with the pervasive style in the file. Signed-off-by: Simon Horman --- tc/f_flower.c | 44

[PATCH iproute2/net-next 0/7] tc: flower: Masked ICMP match and ND match

2017-02-02 Thread Simon Horman
not yet present in the kernel. Simon Horman (7): tc: flower: Update documentation to indicate ARP takes IPv4 prefixes tc: flower: use correct type when calling flower_icmp_attr_type tc: flower: provide generic masked u8 parser helper tc: flower: provide generic masked u8 print helper tc

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-02 Thread Simon Horman
[Repost due to gmail account problem] On Thu, Feb 02, 2017 at 04:31:33AM -0800, Eric Dumazet wrote: > On Thu, 2017-02-02 at 11:37 +0100, Simon Horman wrote: > > Allow dissection of Neighbour Discovery target IP, and source and > > destination link-layer addresses for neighbour s

Re: [PATCH net-next 0/2] Extract IFE logic to module

2017-02-03 Thread Simon Horman
No objections here. On Fri, Feb 3, 2017 at 2:02 PM, Jamal Hadi Salim wrote: > On 17-02-02 06:12 AM, Yotam Gigi wrote: >>> >>> -Original Message- > > >>> >>> I have no objection to this modularisation but I am curious to know >>> if you have a use-case in mind. My understanding is that ear

Re: [PATCH iproute2/net-next 7/7] tc: flower: Support matching on ND

2017-02-06 Thread Simon Horman
a \ > > nd_tll 00:01:8e:22:8f:ea action drop > > > >Signed-off-by: Simon Horman > > > Why you are adding this to iproute2? You only poster RFC for kernel. > > Please push to kernel first, let it merge, then send iproute2 support. Hi Jiri, I think there is a val

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-06 Thread Simon Horman
On Thu, Feb 02, 2017 at 10:36:31AM -0800, Tom Herbert wrote: > On Thu, Feb 2, 2017 at 9:48 AM, Jiri Pirko wrote: > > Thu, Feb 02, 2017 at 06:24:40PM CET, t...@herbertland.com wrote: > >>On Thu, Feb 2, 2017 at 7:58 AM, Simon Horman > >>wrote: > >>&g

Re: [oss-drivers] Re: [PATCH iproute2/net-next 7/7] tc: flower: Support matching on ND

2017-02-06 Thread Simon Horman
dev eth0 ingress > >> > > >> >tc filter add dev eth0 protocol ipv6 parent : flower \ > >> > indev eth0 ip_proto icmpv6 type 136 code 0 \ > >> > nd_target 2001:470:7eb3:403:201:8eff:fe22:8fea \ > >> > nd_tll 00:01:8e:22:8f:ea act

Re: [PATCH iproute2/net-next 0/7] tc: flower: Masked ICMP match and ND match

2017-02-06 Thread Simon Horman
On Mon, Feb 6, 2017 at 11:28 PM, Stephen Hemminger wrote: > On Thu, 2 Feb 2017 11:38:33 +0100 > Simon Horman wrote: > >> Hi, >> >> this series have several related parts. >> >> * tc: flower: Update documentation to indicate ARP takes IPv4 prefixes >&g

Re: [patch net-next RFC 1/2] flow_dissecror: Move ARP dissection into a separate function

2017-02-22 Thread Simon Horman
ser requires it. > > Signed-off-by: Jiri Pirko This looks good to me. Reviewed-by: Simon Horman

Re: [patch net-next RFC 2/2] flow_dissecror: Move MPLS dissection into a separate function

2017-02-22 Thread Simon Horman
ser requires it. > > Signed-off-by: Jiri Pirko Reviewed-by: Simon Horman

Re: [patch net-next RFC 1/2] flow_dissecror: Move ARP dissection into a separate function

2017-02-22 Thread Simon Horman
On Tue, Feb 21, 2017 at 01:32:35PM -0500, David Miller wrote: > From: Jiri Pirko > Date: Tue, 21 Feb 2017 15:33:18 +0100 > > > From: Jiri Pirko > > > > Make the main flow_dissect function a bit smaller and move the ARP > > dissection into a separate function. Along with that, do the ARP header

Re: [PATCH iproute2] tc: flower: Fix parsing ip address

2017-02-22 Thread Simon Horman
On Wed, Feb 22, 2017 at 04:05:01PM +0200, Roi Dayan wrote: > Fix order of arguments when passed to __flower_parse_ip_addr. > > Fixes: ("f888f4e20534 tc: flower: Support matching ARP") > Signed-off-by: Roi Dayan > Reviewed-by: Paul Blakey Reviewed-by: Simon Horman &

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-10 Thread Simon Horman
dvertisement messages. > > > >Signed-off-by: Simon Horman > >--- > > [...] > > >@@ -633,6 +702,18 @@ bool __skb_flow_dissect(const struct sk_buff *skb, > > FLOW_DISSECTOR_KEY_ICMP, > >

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-10 Thread Simon Horman
t;> >Allow dissection of Neighbour Discovery target IP, and source and > >> >destination link-layer addresses for neighbour solicitation and > >> >advertisement messages. > >> > > >> >Signed-off-by: Simon Horman > >> >--- > >

Re: [PATCHv2 net-next 0/4] update ipvs sysctl document

2017-03-13 Thread Simon Horman
On Tue, Feb 21, 2017 at 10:01:44PM +0200, Julian Anastasov wrote: > > Hello, > > On Mon, 20 Feb 2017, Hangbin Liu wrote: > > > Fix and add some new ipvs sysctl options. Also use tab instead of > > whitespaces to indent the descriptions. > > > > V2: Fix some descriptions based on Julian's

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-13 Thread Simon Horman
t;> >Allow dissection of Neighbour Discovery target IP, and source and > >> >destination link-layer addresses for neighbour solicitation and > >> >advertisement messages. > >> > > >> >Signed-off-by: Simon Horman > >> >--- > >

[PATCH/RFC net-next 0/2] net/sched: cls_flower: Support matching ARP

2017-01-11 Thread Simon Horman
Add support for support matching on ARP operation, and hardware and protocol addresses for Ethernet hardware and IPv4 protocol addresses. Simon Horman (2): flow disector: ARP support net/sched: cls_flower: Support matching on ARP include/net/flow_dissector.h | 19 +++ include

[PATCH/RFC net-next 2/2] net/sched: cls_flower: Support matching on ARP

2017-01-11 Thread Simon Horman
filter add dev eth0 protocol rarp parent : flower indev eth0 \ arp_op reply arp_tha 52:54:3f:00:00:00/24 action drop Signed-off-by: Simon Horman --- include/uapi/linux/pkt_cls.h | 11 ++ net/sched/cls_flower.c | 51 2 files

[PATCH/RFC iproute2/net-next 1/2] tc: flower: update headers for TCA_FLOWER_KEY_ARP*

2017-01-11 Thread Simon Horman
These are proposed changes for net-next. Signed-off-by: Simon Horman --- include/linux/pkt_cls.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h index a081efbd61a2..1e5e1ddfdaca 100644 --- a/include/linux/pkt_cls.h +++ b/include

[PATCH/RFC net-next 1/2] flow disector: ARP support

2017-01-11 Thread Simon Horman
Allow dissection of (R)ARP operation hardware and protocol addresses for Ethernet hardware and IPv4 protocol addresses. There are currently no users of FLOW_DISSECTOR_KEY_ARP. A follow-up patch will allow FLOW_DISSECTOR_KEY_ARP to be used by the flower classifier. Signed-off-by: Simon Horman

[PATCH/RFC iproute2/net-next 2/2] tc: flower: Support matching ARP

2017-01-11 Thread Simon Horman
drop tc filter add dev eth0 protocol rarp parent : flower indev eth0 \ arp_op reply arp_tha 52:54:3f:00:00:00/24 action drop Signed-off-by: Simon Horman --- man/man8/tc-flower.8 | 41 +- tc/f_flower.c| 208

[PATCH/RFC iproute2/net-next 0/2] net/sched: cls_flower: Support matching ARP

2017-01-11 Thread Simon Horman
Add support for support matching on ARP operation, and hardware and protocol addresses for Ethernet hardware and IPv4 protocol addresses. Simon Horman (2): tc: flower: update headers for TCA_FLOWER_KEY_ARP* tc: flower: Support matching ARP include/linux/pkt_cls.h | 11 +++ man/man8/tc

[PATCH net-next 1/2] flow disector: ARP support

2017-01-11 Thread Simon Horman
Allow dissection of (R)ARP operation hardware and protocol addresses for Ethernet hardware and IPv4 protocol addresses. There are currently no users of FLOW_DISSECTOR_KEY_ARP. A follow-up patch will allow FLOW_DISSECTOR_KEY_ARP to be used by the flower classifier. Signed-off-by: Simon Horman

[PATCH net-next 0/2] net/sched: cls_flower: Support matching ARP

2017-01-11 Thread Simon Horman
Add support for support matching on ARP operation, and hardware and protocol addresses for Ethernet hardware and IPv4 protocol addresses. Changes since RFC: * None other than dropping RFC designation after positive feedback from Jiri Simon Horman (2): flow disector: ARP support net/sched

[PATCH net-next 2/2] net/sched: cls_flower: Support matching on ARP

2017-01-11 Thread Simon Horman
filter add dev eth0 protocol rarp parent : flower indev eth0 \ arp_op reply arp_tha 52:54:3f:00:00:00/24 action drop Signed-off-by: Simon Horman --- include/uapi/linux/pkt_cls.h | 11 ++ net/sched/cls_flower.c | 51 2 files

Re: [PATCH/RFC net-next 0/2] net/sched: cls_flower: Support matching ARP

2017-01-11 Thread Simon Horman
On Wed, Jan 11, 2017 at 11:27:07AM +0100, Jiri Pirko wrote: > Wed, Jan 11, 2017 at 11:02:20AM CET, simon.hor...@netronome.com wrote: > >Add support for support matching on ARP operation, and hardware and > >protocol addresses for Ethernet hardware and IPv4 protocol addresses. > > This patchset loo

[PATCH iproute2/net-next] tc: ife: correct spelling of prio in example

2017-01-11 Thread Simon Horman
Correct typo in example in ife man page. Fixes: 06f9a59170c0 ("man: tc-ife.8: man page for ife action") Cc: Lucas Bates Signed-off-by: Simon Horman --- man/man8/tc-ife.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/tc-ife.8 b/man/man8/tc-ife.8 index aa

[PATCH iproute2/net-next 2/2] tc: flower: Support matching ARP

2017-01-12 Thread Simon Horman
drop tc filter add dev eth0 protocol rarp parent : flower indev eth0 \ arp_op reply arp_tha 52:54:3f:00:00:00/24 action drop Signed-off-by: Simon Horman --- man/man8/tc-flower.8 | 41 +- tc/f_flower.c| 208

[PATCH iproute2/net-next 1/2] tc: flower: update headers for TCA_FLOWER_KEY_ARP*

2017-01-12 Thread Simon Horman
Present in net-next. Signed-off-by: Simon Horman --- include/linux/pkt_cls.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h index a081efbd61a2..1e5e1ddfdaca 100644 --- a/include/linux/pkt_cls.h +++ b/include/linux/pkt_cls.h

[PATCH iproute2/net-next 0/2] net/sched: cls_flower: Support matching ARP

2017-01-12 Thread Simon Horman
Add support for support matching on ARP operation, and hardware and protocol addresses for Ethernet hardware and IPv4 protocol addresses. Changes since RFC: * Drop RFC designation; kernel patches are present in net-next Simon Horman (2): tc: flower: update headers for TCA_FLOWER_KEY_ARP* tc

[PATCH/RFC net] ravb: Remove Rx overflow log messages

2017-01-12 Thread Simon Horman
From: Kazuya Mizuguchi Remove Rx overflow log messages as in an environment where logging results in network traffic logging may cause further overflows. Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") Signed-off-by: Kazuya Mizuguchi [simon: reworked changelog] Signed-off

Re: [PATCH/RFC v2 net-next] ravb: unmap descriptors when freeing rings

2017-01-12 Thread Simon Horman
On Fri, Jan 06, 2017 at 10:02:36PM +0300, Sergei Shtylyov wrote: > Hello! > > On 01/05/2017 01:43 PM, Simon Horman wrote: > > >From: Kazuya Mizuguchi > > > >"swiotlb buffer is full" errors occur after repeated initialisation of a > >device - f.e.

[PATCH net] ravb: Remove Rx overflow log messages

2017-01-12 Thread Simon Horman
From: Kazuya Mizuguchi Remove Rx overflow log messages as in an environment where logging results in network traffic logging may cause further overflows. Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") Signed-off-by: Kazuya Mizuguchi [simon: reworked changelog] Signed-off

Re: [PATCH/RFC v2 net-next] ravb: unmap descriptors when freeing rings

2017-01-12 Thread Simon Horman
On Thu, Jan 12, 2017 at 03:03:05PM +0300, Sergei Shtylyov wrote: > On 01/12/2017 12:11 PM, Simon Horman wrote: ... > >> Here, it stop once an untransmitted buffer is encountered... > > > >Yes, I see that now. > > > >I wonder if we should: > > > &

[PATCH/RFC net] ravb: do not use zero-length alighment DMA request

2017-01-12 Thread Simon Horman
Kernel panic - not syncing: Fatal exception in interrupt Fixes: 2f45d1902acf ("ravb: minimize TX data copying") Signed-off-by: Kazuya Mizuguchi Signed-off-by: Simon Horman --- v1 [Simon Horman] * rewrote changelog * handle skb->len < 4 v0 [Kazuya Mizuguchi] --- drivers/net/

Re: [PATCH/RFC net] ravb: do not use zero-length alighment DMA request

2017-01-12 Thread Simon Horman
On Thu, Jan 12, 2017 at 10:21:02AM -0500, David Miller wrote: > From: Simon Horman > Date: Thu, 12 Jan 2017 14:53:37 +0100 > > > diff --git a/drivers/net/ethernet/renesas/ravb_main.c > > b/drivers/net/ethernet/renesas/ravb_main.c > > index 92d7692c840d..3b4d2504285e 1

Re: [PATCH/RFC v2 net-next] ravb: unmap descriptors when freeing rings

2017-01-13 Thread Simon Horman
On Thu, Jan 12, 2017 at 07:33:51PM +0300, Sergei Shtylyov wrote: > On 01/12/2017 04:18 PM, Simon Horman wrote: > > >... > > > >>>> Here, it stop once an untransmitted buffer is encountered... > >>> > >>>Yes, I see that now. > >>&

[PATCH net] ravb: do not use zero-length alighment DMA request

2017-01-13 Thread Simon Horman
] ---[ end Kernel panic - not syncing: Fatal exception in interrupt Fixes: 2f45d1902acf ("ravb: minimize TX data copying") Signed-off-by: Masaru Nagai --- v1 [Simon Horman] * don't handle skb->len < 4; it is always at least 60 * add comment * dropped RFC designation v1 [Si

Re: [PATCH net] ravb: do not use zero-length alighment DMA request

2017-01-13 Thread Simon Horman
On Fri, Jan 13, 2017 at 02:09:00PM +0100, Simon Horman wrote: > From: Masaru Nagai > > Due to alignment requirements of the hardware transmissions are split into > two DMA descriptors, a small padding descriptor of 0 - 3 bytes in length > followed by a descriptor for rest of the

[PATCH net v3] ravb: do not use zero-length alignment DMA descriptor

2017-01-16 Thread Simon Horman
] ---[ end Kernel panic - not syncing: Fatal exception in interrupt Fixes: 2f45d1902acf ("ravb: minimize TX data copying") Signed-off-by: Masaru Nagai --- v3 [Simon Horman] * changelog and comment enhancements v2 [Simon Horman] * don't handle skb->len < 4; it is always at l

Re: [PATCH net-next v4 1/2] net sched actions: Add support for user cookies

2017-01-17 Thread Simon Horman
garding the implementation but schematically I like what I see: Reviewed-by: Simon Horman

Re: [PATCH/RFC v2 net-next] ravb: unmap descriptors when freeing rings

2017-01-23 Thread Simon Horman
On Mon, Jan 16, 2017 at 11:41:51PM +0300, Sergei Shtylyov wrote: > Hello! > > On 01/12/2017 04:18 PM, Simon Horman wrote: > > >... > > >>>> Here, it stop once an untransmitted buffer is encountered... > >>> > >>>Yes, I see that now

Re: [PATCH net-next v6 1/1] net sched actions: Add support for user cookies

2017-01-23 Thread Simon Horman
Hi Jamal, On Sun, Jan 22, 2017 at 03:25:50PM -0500, Jamal Hadi Salim wrote: ... > diff --git a/net/sched/act_api.c b/net/sched/act_api.c > index cd08df9..58cf1c5 100644 > --- a/net/sched/act_api.c > +++ b/net/sched/act_api.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include

Re: [patch net-next v2 1/4] net: Introduce psample, a new genetlink channel for packet sampling

2017-01-24 Thread Simon Horman
only netlink dump mode. > > Signed-off-by: Yotam Gigi > Signed-off-by: Jiri Pirko > Reviewed-by: Jamal Hadi Salim Hi Jiri, Hi Yotam, this looks good to me. Reviewed-by: Simon Horman I do, however, have one question: what is your feeling about allowing the per-action cooking wh

Re: [patch net-next v2 2/4] net/sched: Introduce sample tc action

2017-01-24 Thread Simon Horman
igned-off-by: Jiri Pirko > Acked-by: Jamal Hadi Salim Reviewed-by: Simon Horman Is the tc user-space (iproute2) code available yet?

Re: [PATCH iproute2] tc: flower: Fix flower output for src and dst ports

2017-01-24 Thread Simon Horman
s, sorry for missing that: Reviewed-by: Simon Horman > --- > tc/f_flower.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tc/f_flower.c b/tc/f_flower.c > index 71e9515..1dbc532 100644 > --- a/tc/f_flower.c > +++ b/tc/f_flower.c > @@ -

Re: [PATCH net-next] net/sched: cls_flower: Add user specified data

2017-01-04 Thread Simon Horman
On Tue, Jan 03, 2017 at 02:22:05PM +0200, Paul Blakey wrote: > > > On 03/01/2017 13:44, Jamal Hadi Salim wrote: > >On 17-01-02 11:33 PM, John Fastabend wrote: > >>On 17-01-02 05:22 PM, Jamal Hadi Salim wrote: > > > >[..] > >>>Like all cookie semantics it is for storing state. The receiver > >>>(k

Re: [PATCH iproute2 net-next] tc: flower: support matching flags

2017-01-04 Thread Simon Horman
On Tue, Jan 03, 2017 at 01:54:34PM +0200, Paul Blakey wrote: ... Hi Paul, > Matching name was from the idea that we are doing is matching. > And regarding documentation/flag names I didn't want tc tool to be need of a > update each time a new flag is introduced, > But I guess I can add two optio

Re: [patch net-next v2 5/8] Introduce sample tc action

2017-01-04 Thread Simon Horman
On Wed, Nov 16, 2016 at 04:26:44PM +, Yotam Gigi wrote: > >-Original Message- > >From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] > >Sent: Wednesday, November 16, 2016 6:15 PM > >To: Jiri Pirko > >Cc: netdev@vger.kernel.org; da...@davemloft.net; Yotam Gigi > >; Ido Schimmel ; Elad

Re: [patch net-next v2 5/8] Introduce sample tc action

2017-01-04 Thread Simon Horman
On Wed, Jan 04, 2017 at 11:01:46AM +, Yotam Gigi wrote: > >-Original Message- > >From: Simon Horman [mailto:simon.hor...@netronome.com] > >Sent: Wednesday, January 04, 2017 12:43 PM > >To: Yotam Gigi > >Cc: Roopa Prabhu ; Jiri Pirko ; > >netdev@

[PATCH iproute2/net-next] tc: flower: Update dest UDP port documentation

2017-01-04 Thread Simon Horman
d by b2a1f740aa4d ("tc: flower: document that *_ip parameters take a PREFIX as an argument.") Cc: Hadar Hen Zion Signed-off-by: Simon Horman --- man/man8/tc-flower.8 | 4 +++- tc/f_flower.c| 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/man/man8/tc-flower.8 b

Re: [PATCH net-next] net/sched: cls_flower: Add user specified data

2017-01-05 Thread Simon Horman
On Wed, Jan 04, 2017 at 01:45:28PM +0200, Paul Blakey wrote: > On 04/01/2017 12:14, Simon Horman wrote: > >On Tue, Jan 03, 2017 at 02:22:05PM +0200, Paul Blakey wrote: > >> > >>On 03/01/2017 13:44, Jamal Hadi Salim wrote: > >>>On 17-01-02 11:33 PM, John Fast

[PATCH/RFC v2 net-next] ravb: unmap descriptors when freeing rings

2017-01-05 Thread Simon Horman
problem by unmapping descriptors when freeing rings. Note, ravb_tx_free() is moved but not otherwise modified by this patch. Signed-off-by: Kazuya Mizuguchi [simon: reworked] Signed-off-by: Simon Horman -- v1 [Kazuya Mizuguchi] v2 [Simon Horman] * As suggested by Sergei Shtylyov - Use dma_mapping_e

[PATCH iproute2/net-next repost] tc: flower: Update documentation to indicate ARP takes IPv4 prefixes

2017-02-08 Thread Simon Horman
Unlike other PREFIXes documented in the usage for tc flower, which accept both IPv4 and IPv6 prefixes, arp_sip and arp_tip only accepts IPv4 prefixes. Signed-off-by: Simon Horman --- * Repost after breaking out of a larger patchset --- man/man8/tc-flower.8 | 8 tc/f_flower.c| 4

[PATCH iproute2/net-next repost] tc: flower: use correct type when calling flower_icmp_attr_type

2017-02-08 Thread Simon Horman
Use enum flower_icmp_field rather than bool as type of third parameter when calling flower_icmp_attr_type. Fixes: eb3b5696f163 ("tc: flower: support matching on ICMP type and code") Signed-off-by: Simon Horman --- * Reposted after breaking out of a larger patch-set * This should not

[PATCH iproute2/net-next repost2] tc: flower: use correct type when calling flower_icmp_attr_type

2017-02-08 Thread Simon Horman
Use enum flower_icmp_field rather than bool as type of third parameter when calling flower_icmp_attr_type. Fixes: eb3b5696f163 ("tc: flower: support matching on ICMP type and code") Signed-off-by: Simon Horman --- * Reposted a second time due to send-mail set-up error * Reposted afte

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-08 Thread Simon Horman
On Tue, Feb 07, 2017 at 12:38:31PM -0500, David Miller wrote: > From: Tom Herbert > Date: Tue, 7 Feb 2017 09:36:20 -0800 > > > Okay, but can you give us an idea of how many more of these protocols > > are going to be added to flow_dissector. TBH I'm not very enthused > > about making more flow_di

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-08 Thread Simon Horman
Responding to myself as my previous post doesn't seem to have hit netdev for some reason. On Wed, Feb 08, 2017 at 10:28:24AM +0100, Simon Horman wrote: > On Tue, Feb 07, 2017 at 12:38:31PM -0500, David Miller wrote: > > From: Tom Herbert > > Date: Tue, 7 Feb 2017 09:36:20 -

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-09 Thread Simon Horman
On Wed, Feb 08, 2017 at 09:09:17PM +0100, Jiri Pirko wrote: > Wed, Feb 08, 2017 at 07:54:15PM CET, da...@davemloft.net wrote: > >From: Tom Herbert > >Date: Wed, 8 Feb 2017 10:33:46 -0800 > > > >> On Wed, Feb 8, 2017 at 1:28 AM, Simon Horman > >> wrote:

[PATCH iproute2/net-next repost 1/3] tc: flower: provide generic masked u8 parser helper

2017-02-09 Thread Simon Horman
Provide generic masked u8 paser helper and use it to parse arp operations. Also consistently use __u8 rather than uint8_t, in keeping with the pervasive style in the file. Signed-off-by: Simon Horman --- tc/f_flower.c | 55 --- 1 file changed

[PATCH iproute2/net-next repost 3/3] tc: flower: support masked ICMP code and type match

2017-02-09 Thread Simon Horman
Extend ICMP code and type match to support masks. Also add missing documentation to synopsis in manpage. tc qdisc add dev eth0 ingress tc filter add dev eth0 protocol ipv6 parent : flower \ indev eth0 ip_proto icmpv6 type 128/240 code 0 action drop Signed-off-by: Simon Horman

[PATCH iproute2/net-next repost 2/3] tc: flower: provide generic masked u8 print helper

2017-02-09 Thread Simon Horman
Provide generic masked u8 print helper and use it to print arp operations. Also: * Make name parameter of arp op print helper const. * Consistently use __u8 rather than uint8_t, in keeping with the pervasive style in the file. Signed-off-by: Simon Horman --- tc/f_flower.c | 44

[PATCH iproute2/net-next repost 0/3] tc: flower: support masked ICMP code and type match

2017-02-09 Thread Simon Horman
: tc qdisc add dev eth0 ingress tc filter add dev eth0 protocol ipv6 parent : flower \ indev eth0 ip_proto icmpv6 type 128/240 code 0 action drop Reposting after breaking out of a larger patchset. Simon Horman (3): tc: flower: provide generic masked u8 parser helper tc: flower

Re: [PATCH iproute] tc: matchall: Print skip flags when dumping a filter

2017-02-10 Thread Simon Horman
On Thu, Feb 09, 2017 at 03:10:14PM +0200, Or Gerlitz wrote: > Print the skip flags when we dump a filter. > > Signed-off-by: Or Gerlitz > Acked by: Yotam Gigi This appears to be consistent with other classifiers that support these flags. Reviewed-by: Simon Horman > --- >

Re: [PATCH/RFC v3 net] ravb: unmap descriptors when freeing rings

2017-02-13 Thread Simon Horman
On Fri, Feb 10, 2017 at 02:52:50PM +0100, Geert Uytterhoeven wrote: > On Wed, Jan 25, 2017 at 5:18 PM, Sergei Shtylyov > wrote: > > On 01/24/2017 09:21 PM, Simon Horman wrote: > > > >> From: Kazuya Mizuguchi > >> > >> "swiotlb buffer is ful

[PATCH net-next (repost)] nfp: Use PCI_DEVICE_ID_NETRONOME_NFP* defines

2017-02-17 Thread Simon Horman
Use PCI_DEVICE_ID_NETRONOME_NFP*, defined in linux/pci_ids.h, rather than replicating the same values in the NFP driver. Signed-off-by: Simon Horman --- * Reposted with subject and changelog adjusted to be less likely to be flagged as spam --- drivers/net/ethernet/netronome/nfp/nfp_main.c

Re: [PATCH iproute2 1/1] man page: add page for skbmod action

2017-02-17 Thread Simon Horman
eanly against the net-next branch. The above not withstanding I am very pleased to see this documentation and in particular the presence of examples in it. Reviewed-by: Simon Horman Do you know if there are any plans to extend the number of fields supported by skmod? I think it would be useful to

Re: [patch net-next RFC 1/8] devlink: Support for pipeline debug (dpipe)

2017-02-17 Thread Simon Horman
Hi Jiri, On Thu, Feb 16, 2017 at 04:22:37PM +0100, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > The pipeline debug is used to export the pipeline abstractions > for the main objects - tables, headers and entries. The only support for > set is for changing the counter parameter on specific ta

Re: [patch net-next RFC 1/8] devlink: Support for pipeline debug (dpipe)

2017-02-20 Thread Simon Horman
On Sat, Feb 18, 2017 at 08:38:51AM +0100, Jiri Pirko wrote: > Fri, Feb 17, 2017 at 09:49:07AM CET, simon.hor...@netronome.com wrote: > >Hi Jiri, > > > >On Thu, Feb 16, 2017 at 04:22:37PM +0100, Jiri Pirko wrote: > >> From: Arkadi Sharshevsky > >> > >> The pipeline debug is used to export the pipe

Re: [PATCH net-next v5 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-24 Thread Simon Horman
On Thu, Apr 20, 2017 at 04:24:53PM +0200, Jiri Pirko wrote: > Thu, Apr 20, 2017 at 04:18:50PM CEST, j...@mojatatu.com wrote: > >On 17-04-20 09:59 AM, Jiri Pirko wrote: > >> Thu, Apr 20, 2017 at 03:06:21PM CEST, j...@mojatatu.com wrote: > >> > From: Jamal Hadi Salim ... > >> > +if (tcaa[T

Re: [PATCH net-next v4 1/2] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-04-24 Thread Simon Horman
On Fri, Apr 21, 2017 at 02:11:00PM -0400, Jamal Hadi Salim wrote: > On 17-04-21 12:12 PM, David Miller wrote: > > >Yes for existing attributes we are stuck in the mud because of how > >we've handled things in the past. I'm not saying we should change > >behavior for existing attributes. > > > >I'

Re: [PATCH v2 net-next] net: ipv6: send unsolicited NA if enabled for all interfaces

2017-04-24 Thread Simon Horman
ND on link-layer > address change") > Signed-off-by: David Ahern Reviewed-by: Simon Horman > --- > v2 > - update commit message with subject of commit 4a6e3c5def13 per comment > from Sergei > > net/ipv6/ndisc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 de

Re: [PATCH] ipvs: explicitly forbid ipv6 service/dest creation if ipv6 mod is disabled

2017-04-24 Thread Simon Horman
On Mon, Apr 24, 2017 at 10:21:30AM +0300, Julian Anastasov wrote: > > Hello, > > On Mon, 24 Apr 2017, Paolo Abeni wrote: > > > Hi, > > > > The problem with the patched code is that it tries to resolve ipv6 > > addresses that are not created/validated by the kernel. > > OK. Simon, p

Re: [PATCH net-next 0/2] flower: add MPLS matching support

2017-04-25 Thread Simon Horman
On Mon, Apr 24, 2017 at 07:07:43PM -0700, Jakub Kicinski wrote: > On Mon, 24 Apr 2017 22:06:08 -0400, Jamal Hadi Salim wrote: > > On 17-04-24 10:00 PM, Jamal Hadi Salim wrote: > > > On 17-04-24 09:48 PM, Jamal Hadi Salim wrote: > > > > > > > > Hrm. maybe I am wrong. > > > Lets say user sets all

Re: [PATCH net-next v8 1/3] net sched actions: Use proper root attribute table for actions

2017-04-25 Thread Simon Horman
]: Convert actions from rtnetlink to new > netlink API") > Suggested-by: Jiri Pirko > Signed-off-by: Jamal Hadi Salim Reviewed-by: Simon Horman

<    4   5   6   7   8   9   10   11   12   13   >