Re: [Nfs-ganesha-devel] Correct initialization sequence

2018-01-30 Thread Malahal Naineni
Looking at the code, dupreq2_pkginit() only depends on Ganesha config processing to initialize few things, so it should be OK to call anytime after Ganesha config processing. Regards, Malahal. On Wed, Jan 31, 2018 at 8:00 AM, Pradeep wrote: > Hi Bill, > > Is it ok to move dupreq2_pkginit() befo

Re: [Nfs-ganesha-devel] Correct initialization sequence

2018-01-30 Thread Pradeep
Hi Bill, Is it ok to move dupreq2_pkginit() before nfs_Init_svc() so that we won't hit the crash below? #0 0x7fb54dd7923b in raise () from /lib64/libpthread.so.0 #1 0x00442ebd in crash_handler (signo=11, info=0x7fb546efc430, ctx=0x7fb546efc300) at /usr/src/debug/nfs-ganesha-2.6-rc2/

Re: [Nfs-ganesha-devel] Correct initialization sequence

2018-01-30 Thread Matt Benjamin
reordering, I hope Matt On Tue, Jan 30, 2018 at 1:40 PM, Pradeep wrote: > Hello, > > It is possible to receive requests anytime after nfs_Init_svc() is > completed. We initialize several things in nfs_Init() after this. This could > lead to processing of incoming requests racing with the rest of

Re: [Nfs-ganesha-devel] Is there a field in the SVCXPRT Ganesha can use

2018-01-30 Thread Matt Benjamin
Restating this, the code is unified for tcp v4 and v3. It consults xid and the checksum, which I think is a correct intent. The slot-reply cache in 4.1+ is, we hope, the improved mechanism. Matt On Tue, Jan 30, 2018 at 9:45 AM, Matt Benjamin wrote: > I don't think that's the case. the behavio

Re: [Nfs-ganesha-devel] Correct initialization sequence

2018-01-30 Thread Frank Filz
We have done some re-ordering, unfortunately I think moving the worker thread stuff out of the fridge and into libntirpc threads undid the moving of starting the fridge as the very last thing before nfs_init_complete. Bill, do you have any thoughts, can we just move nfs_Init_svc? Frank F

[Nfs-ganesha-devel] FW: Announcing Bake-a-thon for Spring 2018

2018-01-30 Thread Frank Filz
-Original Message- From: linux-nfs-ow...@vger.kernel.org [mailto:linux-nfs-ow...@vger.kernel.org] On Behalf Of Bill Baker Sent: Monday, January 29, 2018 2:18 PM To: nf...@ietf.org; linux-...@vger.kernel.org Subject: Announcing Bake-a-thon for Spring 2018 Greetings, I am pleased to anno

[Nfs-ganesha-devel] Correct initialization sequence

2018-01-30 Thread Pradeep
Hello, It is possible to receive requests anytime after nfs_Init_svc() is completed. We initialize several things in nfs_Init() after this. This could lead to processing of incoming requests racing with the rest of initialization (ex: dupreq2_pkginit()). Is it possible to re-order nfs_Init_svc() s

[Nfs-ganesha-devel] Features board list

2018-01-30 Thread Supriti Singh
Hello all, As discussed in community call, I am sharing the feature board list: https://github.com/nfs-ganesha/nfs-ganesha/projects for nfs-ganesha 2.6 and 2.7. The aim is to use these boards to track the planned features for major release. The hope is that it will help community members to foll

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Moving NFSv4 to POSIX ACL mapping code to a common code base

2018-01-30 Thread GerritHub
>From Sriram Patil : Sriram Patil has uploaded this change for review. ( https://review.gerrithub.io/397183 Change subject: Moving NFSv4 to POSIX ACL mapping code to a common code base .. Moving NFSv4 to POSIX ACL mapping code

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: SAL: consolidate rados cluster connect code

2018-01-30 Thread GerritHub
>From Jeff Layton : Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/397171 Change subject: SAL: consolidate rados cluster connect code .. SAL: consolidate rados cluster connect code Change-Id: I

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: rados_ng: make a bunch of symbols static

2018-01-30 Thread GerritHub
>From Jeff Layton : Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/397169 Change subject: rados_ng: make a bunch of symbols static .. rados_ng: make a bunch of symbols static Change-Id: I2f4fbb

Re: [Nfs-ganesha-devel] Is there a field in the SVCXPRT Ganesha can use

2018-01-30 Thread Matt Benjamin
innovations? ok. there's other innovation needed in the gss impl, that would be welcome as well Matt On Tue, Jan 30, 2018 at 9:50 AM, William Allen Simpson wrote: > On 1/30/18 9:36 AM, William Allen Simpson wrote: >> >> But the code is obscure, so I could be missing something. > > > Also, it b

Re: [Nfs-ganesha-devel] Is there a field in the SVCXPRT Ganesha can use

2018-01-30 Thread William Allen Simpson
On 1/30/18 9:36 AM, William Allen Simpson wrote: But the code is obscure, so I could be missing something. Also, it bears repeating that the dupreq cache wasn't working for secure connections. Pre-V2.6 checksummed the ciphertext, which is by definition different on every request. We'd never s

Re: [Nfs-ganesha-devel] Is there a field in the SVCXPRT Ganesha can use

2018-01-30 Thread Matt Benjamin
I don't think that's the case. the behavior is distinct for v4 and v3 (which does not have clientids). DRC is bypassed for v4.1+ Matt On Tue, Jan 30, 2018 at 9:36 AM, William Allen Simpson wrote: > On 1/30/18 9:22 AM, William Allen Simpson wrote: >> >> On 1/29/18 3:32 PM, Frank Filz wrote: >>>

Re: [Nfs-ganesha-devel] Is there a field in the SVCXPRT Ganesha can use

2018-01-30 Thread William Allen Simpson
On 1/30/18 9:22 AM, William Allen Simpson wrote: On 1/29/18 3:32 PM, Frank Filz wrote: I haven't looked at how the SVCXPRT structure has changed, but if there's a field in there we can attach a Ganesha structure to that would be cool, or if not, if we could add one. There are two: xp_u1, and x

Re: [Nfs-ganesha-devel] Is there a field in the SVCXPRT Ganesha can use

2018-01-30 Thread Matt Benjamin
That sounds right, I figured we could reclaim xp_u1. Matt On Tue, Jan 30, 2018 at 9:22 AM, William Allen Simpson wrote: > On 1/29/18 3:32 PM, Frank Filz wrote: >> >> I haven't looked at how the SVCXPRT structure has changed, but if there's >> a >> field in there we can attach a Ganesha structure

Re: [Nfs-ganesha-devel] Is there a field in the SVCXPRT Ganesha can use

2018-01-30 Thread William Allen Simpson
On 1/29/18 3:32 PM, Frank Filz wrote: I haven't looked at how the SVCXPRT structure has changed, but if there's a field in there we can attach a Ganesha structure to that would be cool, or if not, if we could add one. There are two: xp_u1, and xp_u2. Right now, Ganesha is using xp_u2 for dup r

Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Pullup ntirpc 1.6

2018-01-30 Thread Daniel Gryniewicz
On 01/30/2018 09:11 AM, William Allen Simpson wrote: On 1/29/18 2:27 PM, Daniel Gryniewicz wrote: On 01/29/2018 02:09 PM, William Allen Simpson wrote: On 1/29/18 1:13 PM, GerritHub wrote: Daniel Gryniewicz has uploaded this change for *review*. View Change

Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Pullup ntirpc 1.6

2018-01-30 Thread William Allen Simpson
On 1/29/18 2:27 PM, Daniel Gryniewicz wrote: On 01/29/2018 02:09 PM, William Allen Simpson wrote: On 1/29/18 1:13 PM, GerritHub wrote: Daniel Gryniewicz has uploaded this change for *review*. View Change Pullup ntirpc 1.6 (svc_vc) rearm after EAGAIN and E