Re: [Nfs-ganesha-devel] ACL support

Hi, Kernel nfs reorders the ACE in ACL and i think it puts more restrictive ACEs first in the list. But i see NFS Ganesha is not doing it,is reordering the responsibility of FSAL ? Is there any plans to support reordering ? Thanks, Sagar. On Mon, Feb 19, 2018 at 11:43 AM, Sagar M D wrote: > S

Re: [Nfs-ganesha-devel] inconsistent '*' spacing

On 2/21/18 11:35 AM, Frank Filz wrote: There's a -n or --no-verify option that will bypass the commit hooks. I suggest trying to commit without that first to make sure the only checkpatch errors/warnings are for the spacing around * and then commit again with -n to bypass checkpatch to actuall

Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MainNFSD: invert _NO_PORTMAPPER option

> On Wed, 2018-02-21 at 13:40 -0800, Frank Filz wrote: > > > On 2/21/18 1:59 PM, GerritHub wrote: > > > > Jeff Layton has uploaded this change for *review*. > > > > > > > > View Change > > > > > > > > MainNFSD: invert _NO_PORTMAPPER option > > > > > > > > The fa

Re: [Nfs-ganesha-devel] inconsistent '*' spacing

Thanks for the efforts. In general I like the checks we have enabled. Occasionally one creates annoyance and my decision is to live with an occasional annoyance. This particular file shouldn't see too much changes and now that it's 99% fixed, we can easily move past the one or two annoyances tha

Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MainNFSD: invert _NO_PORTMAPPER option

On Wed, 2018-02-21 at 18:24 -0500, William Allen Simpson wrote: > On 2/21/18 4:51 PM, Jeff Layton wrote: > > On Wed, 2018-02-21 at 13:40 -0800, Frank Filz wrote: > > > We could take this opportunity to change the option to RPCBIND... > > > > > > > Fair enough. > > > > I'd support this. > Cool

Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MainNFSD: invert _NO_PORTMAPPER option

On 2/21/18 4:51 PM, Jeff Layton wrote: On Wed, 2018-02-21 at 13:40 -0800, Frank Filz wrote: We could take this opportunity to change the option to RPCBIND... Fair enough. I'd support this. I actually disagree with the "no udp" statement above too. UDP is great for single-shot request pro

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: (nfs41.h) unindent

>From : william.allen.simp...@gmail.com has uploaded this change for review. ( https://review.gerrithub.io/400889 Change subject: (nfs41.h) unindent .. (nfs41.h) unindent Change-Id: I0c4504ed3cc1c5478dac7dcdc825a1257164880d S

Re: [Nfs-ganesha-devel] inconsistent '*' spacing

On 2/21/18 8:28 AM, William Allen Simpson wrote: Anyway, I'll try to push a patch for those 2 files by tomorrow. ERROR: "foo * bar" should be "foo *bar" #18656: FILE: src/include/nfsv41.h:9900: +static inline bool xdr_CB_COMPOUND4res(XDR * xdrs, total: 450 errors, 14 warnings, 18658 lines chec

Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MainNFSD: invert _NO_PORTMAPPER option

On Wed, 2018-02-21 at 13:40 -0800, Frank Filz wrote: > > On 2/21/18 1:59 PM, GerritHub wrote: > > > Jeff Layton has uploaded this change for *review*. > > > > > > View Change > > > > > > MainNFSD: invert _NO_PORTMAPPER option > > > > > > The fact that this is

Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MainNFSD: invert _NO_PORTMAPPER option

> On 2/21/18 1:59 PM, GerritHub wrote: > > Jeff Layton has uploaded this change for *review*. > > > > View Change > > > > MainNFSD: invert _NO_PORTMAPPER option > > > > The fact that this is a "negative" option is confusing. Change it to a > > "PORTMAPPER" optio

Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MainNFSD: invert _NO_PORTMAPPER option

On Wed, 2018-02-21 at 16:22 -0500, William Allen Simpson wrote: > On 2/21/18 1:59 PM, GerritHub wrote: > > Jeff Layton has uploaded this change for *review*. > > > > View Change > > > > MainNFSD: invert _NO_PORTMAPPER option > > > > The fact that this is a "n

Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MainNFSD: invert _NO_PORTMAPPER option

On 2/21/18 1:59 PM, GerritHub wrote: Jeff Layton has uploaded this change for *review*. View Change MainNFSD: invert _NO_PORTMAPPER option The fact that this is a "negative" option is confusing. Change it to a "PORTMAPPER" option, and have it default to ON.

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Pullup NTIRPC through #106

>From : william.allen.simp...@gmail.com has uploaded this change for review. ( https://review.gerrithub.io/400875 Change subject: Pullup NTIRPC through #106 .. Pullup NTIRPC through #106 (was16backport) * Remove xdr_array.c

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MainNFSD: invert _NO_PORTMAPPER option

>From Jeff Layton : Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/400871 Change subject: MainNFSD: invert _NO_PORTMAPPER option .. MainNFSD: invert _NO_PORTMAPPER option The fact that this is

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: spec: allow packagers to remove dependency on rpcbind

>From Jeff Layton : Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/400860 Change subject: spec: allow packagers to remove dependency on rpcbind .. spec: allow packagers to remove dependency on r

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fixing the fslocations tests failures as seen in pynfs

>From Sriram Patil : Sriram Patil has uploaded this change for review. ( https://review.gerrithub.io/400805 Change subject: Fixing the fslocations tests failures as seen in pynfs .. Fixing the fslocations tests failures as see

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: build: replace archaic caddr_t with modern void *

>From : ka...@redhat.com has uploaded this change for review. ( https://review.gerrithub.io/400806 Change subject: build: replace archaic caddr_t with modern void * .. build: replace archaic caddr_t with modern void * Build f

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: RADOS_URLS: enable them by default

>From Jeff Layton : Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/400818 Change subject: RADOS_URLS: enable them by default .. RADOS_URLS: enable them by default We'll already enable RADOS_KV

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: RADOS_URLS: allow the RADOS_URLS config block to be optional

>From Jeff Layton : Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/400817 Change subject: RADOS_URLS: allow the RADOS_URLS config block to be optional .. RADOS_URLS: allow the RADOS_URLS config

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Add a new field "fsal_name" in fsal_staticfsinfo_t. In case of multip...

>From : supriti.si...@suse.com has uploaded this change for review. ( https://review.gerrithub.io/400832 Change subject: Add a new field "fsal_name" in fsal_staticfsinfo_t. In case of multiple exports this should help in identifying the right fsal. Also, call display_fsinfo for FSAL_RGW and F

Re: [Nfs-ganesha-devel] inconsistent '*' spacing

On 2/20/18 1:06 PM, Frank Filz wrote: As I'm trying to update nfs41.h, I've run into the problem that the commit check is complaining that the pointer '*' on parameters is sometimes " * v" and others " *v" -- usually the same function definition. Presumably the generator made these. They ar

Re: [Nfs-ganesha-devel] nfs ganesha vs nfs kernel performance

Hi Bill, Let's just talk about the rpc-ping-mt/request minimal latency. On Wed, Feb 21, 2018 at 8:24 AM, William Allen Simpson wrote: >> >> It measures minimal request latency all the way to nfs-ganesha's, or >> the Linux kernel's, rpcnull handler--the "top" of the request handling >> stack, in

Re: [Nfs-ganesha-devel] nfs ganesha vs nfs kernel performance

I really don't have time today to respond to every one-liner throw-away comment here, so I'll try to stick to the most cogent. On 2/20/18 8:33 AM, Matt Benjamin wrote: On Tue, Feb 20, 2018 at 8:12 AM, William Allen Simpson wrote: On 2/18/18 2:47 PM, Matt Benjamin wrote: On Fri, Feb 16, 2018

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: specfile: fix libcephfs-devel and librgw-devel BuildRequires

>From Jeff Layton : Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/400827 Change subject: specfile: fix libcephfs-devel and librgw-devel BuildRequires .. specfile: fix libcephfs-devel and librgw

Re: [Nfs-ganesha-devel] inconsistent '*' spacing

> On 2/20/18 1:06 PM, Frank Filz wrote: > >> As I'm trying to update nfs41.h, I've run into the problem that the > >> commit > > check > >> is complaining that the pointer '*' on parameters is sometimes " * v" > >> and > > others > >> " *v" -- usually the same function definition. > >> > >> Presuma

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: doc: fix typo in ganesha-config manpage

>From Jeff Layton : Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/400826 Change subject: doc: fix typo in ganesha-config manpage .. doc: fix typo in ganesha-config manpage Change-Id: I3c4ee0cf

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Set op_ctx when reverting exports

>From Daniel Gryniewicz : Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/400846 Change subject: Set op_ctx when reverting exports .. Set op_ctx when reverting exports Change-Id: Id50f1d2c