Re: [PR] IGNITE-20861 P2P prevent to load already deployed class from different node on SHARED mode [ignite]

2024-07-09 Thread via GitHub
zstan commented on code in PR #11041: URL: https://github.com/apache/ignite/pull/11041#discussion_r1671633470 ## modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentPerVersionStore.java: ## @@ -322,13 +322,33 @@ else if (log.isDebugEnabled())

[PR] IGNITE-22557 Create system view for SQL query plans history [ignite]

2024-07-09 Thread via GitHub
oleg-vlsk opened a new pull request, #11425: URL: https://github.com/apache/ignite/pull/11425 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

Re: [PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sashapolo commented on code in PR #4065: URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1671034172 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -2231,6 +2232,27 @@ public

Re: [PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sashapolo commented on code in PR #4065: URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1671033319 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItEstimatedSizeTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sashapolo commented on code in PR #4065: URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1671032467 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -517,6 +522,10 @@ private

Re: [PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4065: URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1671018873 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -2231,6 +2232,27 @@ public ScheduledExecutorService

Re: [PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4065: URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1671009329 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItEstimatedSizeTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4065: URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1671007487 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItEstimatedSizeTest.java: ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4065: URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1671004848 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -517,6 +522,10 @@ private CompletableFuture

Re: [PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4065: URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1671000478 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/network/replication/GetEstimatedSizeRequest.java: ## @@ -0,0 +1,29 @@ +/*

Re: [PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4065: URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1671000478 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/network/replication/GetEstimatedSizeRequest.java: ## @@ -0,0 +1,29 @@ +/*

Re: [PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4065: URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1670995838 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -2231,6 +2232,27 @@ public ScheduledExecutorService

Re: [PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sashapolo commented on code in PR #4065: URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1670983364 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/network/replication/GetEstimatedSizeRequest.java: ## @@ -0,0 +1,29 @@

Re: [PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4065: URL: https://github.com/apache/ignite-3/pull/4065#discussion_r1670979920 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/network/replication/GetEstimatedSizeRequest.java: ## @@ -0,0 +1,29 @@ +/*

[PR] IGNITE-22619 Add `InternalTable#estimatedSize` method [ignite-3]

2024-07-09 Thread via GitHub
sashapolo opened a new pull request, #4065: URL: https://github.com/apache/ignite-3/pull/4065 https://issues.apache.org/jira/browse/IGNITE-22619 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask

Re: [PR] IGNITE-22150 .NET: Add PartitionManager API [ignite-3]

2024-07-09 Thread via GitHub
ptupitsyn commented on code in PR #4062: URL: https://github.com/apache/ignite-3/pull/4062#discussion_r1670888294 ## modules/platforms/dotnet/Apache.Ignite/Table/IPartition.cs: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] IGNITE-20861 P2P prevent to load already deployed class from different node on SHARED mode [ignite]

2024-07-09 Thread via GitHub
zstan commented on code in PR #11041: URL: https://github.com/apache/ignite/pull/11041#discussion_r1670843012 ## modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentPerVersionStore.java: ## @@ -376,7 +396,10 @@ else if

Re: [PR] IGNITE-20861 P2P prevent to load already deployed class from different node on SHARED mode [ignite]

2024-07-09 Thread via GitHub
zstan commented on code in PR #11041: URL: https://github.com/apache/ignite/pull/11041#discussion_r1670843759 ## modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentPerVersionStore.java: ## @@ -322,13 +322,33 @@ else if (log.isDebugEnabled())

Re: [PR] IGNITE-22150 .NET: Add PartitionManager API [ignite-3]

2024-07-09 Thread via GitHub
isapego commented on code in PR #4062: URL: https://github.com/apache/ignite-3/pull/4062#discussion_r1670834151 ## modules/platforms/dotnet/Apache.Ignite/Table/IPartition.cs: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] IGNITE-20861 P2P prevent to load already deployed class from different node on SHARED mode [ignite]

2024-07-09 Thread via GitHub
zstan commented on code in PR #11041: URL: https://github.com/apache/ignite/pull/11041#discussion_r1670841969 ## modules/core/src/main/java/org/apache/ignite/internal/managers/deployment/GridDeploymentPerVersionStore.java: ## @@ -322,13 +322,33 @@ else if (log.isDebugEnabled())

[PR] Bump net.bytebuddy:byte-buddy from 1.14.17 to 1.14.18 [ignite-3]

2024-07-09 Thread via GitHub
dependabot[bot] opened a new pull request, #4064: URL: https://github.com/apache/ignite-3/pull/4064 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.14.17 to 1.14.18. Release notes Sourced from

[PR] IGNITE-22698 Sql. Extend test coverage for numeric comparison with literal wider than numeric type [ignite-3]

2024-07-09 Thread via GitHub
zstan opened a new pull request, #4063: URL: https://github.com/apache/ignite-3/pull/4063 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ###

Re: [PR] IGNITE-22629 Fixed the test ItReplicaStateManagerTest.testReplicaStatesManagement [ignite-3]

2024-07-09 Thread via GitHub
sanpwc merged PR #4040: URL: https://github.com/apache/ignite-3/pull/4040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] IGNITE-22676 Add protection against internal thread hijacking to IgniteCatalog [ignite-3]

2024-07-09 Thread via GitHub
rpuch merged PR #4060: URL: https://github.com/apache/ignite-3/pull/4060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Dedicated Snapshot Checker [ignite]

2024-07-09 Thread via GitHub
Vladsz83 commented on code in PR #11423: URL: https://github.com/apache/ignite/pull/11423#discussion_r1670540246 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotChecker.java: ## @@ -0,0 +1,698 @@ +/* + * Licensed to the

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1670522701 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -103,6 +135,17 @@ private boolean

Re: [PR] IGNITE-22693 Add protection against internal thread hijacking to PartitionManager [ignite-3]

2024-07-09 Thread via GitHub
rpuch merged PR #4061: URL: https://github.com/apache/ignite-3/pull/4061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] IGNITE-22693 Add protection against internal thread hijacking to PartitionManager [ignite-3]

2024-07-09 Thread via GitHub
rpuch commented on code in PR #4061: URL: https://github.com/apache/ignite-3/pull/4061#discussion_r1670512486 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/threading/ItPartitionManagerApiThreadingTest.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the

Re: [PR] IGNITE-22693 Add protection against internal thread hijacking to PartitionManager [ignite-3]

2024-07-09 Thread via GitHub
rpuch commented on code in PR #4061: URL: https://github.com/apache/ignite-3/pull/4061#discussion_r1670512486 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/threading/ItPartitionManagerApiThreadingTest.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

2024-07-09 Thread via GitHub
zstan commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1670511320 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -103,6 +135,17 @@ private boolean

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

2024-07-09 Thread via GitHub
zstan commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1670510066 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -91,6 +95,34 @@ public boolean

Re: [PR] IGNITE-22465 Recover zones' replicas and pending/stable events on a node restart [ignite-3]

2024-07-09 Thread via GitHub
sanpwc merged PR #4043: URL: https://github.com/apache/ignite-3/pull/4043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] IGNITE-22150 .NET: Add partition API [ignite-3]

2024-07-09 Thread via GitHub
ptupitsyn opened a new pull request, #4062: URL: https://github.com/apache/ignite-3/pull/4062 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] IGNITE-22693 Add protection against internal thread hijacking to PartitionManager [ignite-3]

2024-07-09 Thread via GitHub
sashapolo commented on code in PR #4061: URL: https://github.com/apache/ignite-3/pull/4061#discussion_r1670463833 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/threading/ItPartitionManagerApiThreadingTest.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the

Re: [PR] IGNITE-22676 Add protection against internal thread hijacking to IgniteCatalog [ignite-3]

2024-07-09 Thread via GitHub
Phillippko commented on code in PR #4060: URL: https://github.com/apache/ignite-3/pull/4060#discussion_r1670375962 ## modules/catalog-dsl/src/integrationTest/java/org/apache/ignite/internal/catalog/PojoValue.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-22465 Recover zones' replicas and pending/stable events on a node restart [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4043: URL: https://github.com/apache/ignite-3/pull/4043#discussion_r1670321124 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -203,22 +225,115 @@ public

Re: [PR] IGNITE-22465 Recover zones' replicas and pending/stable events on a node restart [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4043: URL: https://github.com/apache/ignite-3/pull/4043#discussion_r1670312365 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -203,22 +225,115 @@ public

Re: [PR] IGNITE-22465 Recover zones' replicas and pending/stable events on a node restart [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4043: URL: https://github.com/apache/ignite-3/pull/4043#discussion_r1670312365 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -203,22 +225,115 @@ public

Re: [PR] IGNITE-22465 Recover zones' replicas and pending/stable events on a node restart [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4043: URL: https://github.com/apache/ignite-3/pull/4043#discussion_r1670297708 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -203,22 +225,115 @@ public

Re: [PR] IGNITE-15624: Calcite. Support different connections in logical tests. [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich merged PR #4028: URL: https://github.com/apache/ignite-3/pull/4028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] IGNITE-22465 Recover zones' replicas and pending/stable events on a node restart [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4043: URL: https://github.com/apache/ignite-3/pull/4043#discussion_r1670272089 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -203,22 +225,115 @@ public

Re: [PR] IGNITE-22465 Recover zones' replicas and pending/stable events on a node restart [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4043: URL: https://github.com/apache/ignite-3/pull/4043#discussion_r1670268247 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -192,6 +202,18 @@ public

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

2024-07-09 Thread via GitHub
zstan commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1670260310 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java: ## @@ -91,6 +95,34 @@ public boolean

Re: [PR] IGNITE-22465 Recover zones' replicas and pending/stable events on a node restart [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4043: URL: https://github.com/apache/ignite-3/pull/4043#discussion_r1670251896 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -203,22 +225,115 @@ public

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1670247930 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-21303 Fix the way we save new assignments for "resetPartitions" command [ignite-3]

2024-07-09 Thread via GitHub
tkalkirill merged PR #4038: URL: https://github.com/apache/ignite-3/pull/4038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] IGNITE-22444 Sql. Assign CHARACTER or CHARACTER VARYING to the other type [ignite-3]

2024-07-09 Thread via GitHub
zstan commented on code in PR #4034: URL: https://github.com/apache/ignite-3/pull/4034#discussion_r1670222303 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/IndexSearchBoundsPlannerTest.java: ## @@ -314,14 +314,14 @@ public void

[PR] IGNITE-22683 Update Ignite dependency: PostgreSQL JDBC [ignite]

2024-07-09 Thread via GitHub
lordgarrish opened a new pull request, #11424: URL: https://github.com/apache/ignite/pull/11424 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

Re: [PR] IGNITE-22521 ItIgniteNodeRestartTest.testSequentialAsyncTableCreationThenAlterZoneThenRestartOnMsSnapshot is flaky [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on PR #4027: URL: https://github.com/apache/ignite-3/pull/4027#issuecomment-2216890861 Approved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] IGNITE-22521 ItIgniteNodeRestartTest.testSequentialAsyncTableCreationThenAlterZoneThenRestartOnMsSnapshot is flaky [ignite-3]

2024-07-09 Thread via GitHub
sanpwc merged PR #4027: URL: https://github.com/apache/ignite-3/pull/4027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r166993 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/InsertSourcesCoercionTest.java: ## @@ -0,0 +1,665 @@ +/* + *

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669916020 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22633 Catalog compaction. Implement choosing of coordinator [ignite-3]

2024-07-09 Thread via GitHub
korlov42 merged PR #4042: URL: https://github.com/apache/ignite-3/pull/4042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Dedicated Snapshot Checker [ignite]

2024-07-09 Thread via GitHub
timoninmaxim commented on code in PR #11423: URL: https://github.com/apache/ignite/pull/11423#discussion_r1668565684 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/dump/Dump.java: ## @@ -392,7 +392,7 @@ public GridKernalContext

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669912429 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669912429 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669899583 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669893119 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/InsertSourcesCoercionTest.java: ## @@ -0,0 +1,665 @@ +/* + * Licensed to the

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669883521 ## modules/sql-engine/src/testFixtures/java/org/apache/ignite/internal/sql/engine/util/SqlTestUtils.java: ## @@ -351,4 +355,50 @@ public static RexNode

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669878184 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669878184 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669873741 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningPredicateSelfTest.java: ## @@ -118,12 +120,20 @@

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669871584 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669846842 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669844300 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningPredicateSelfTest.java: ## @@ -118,12 +120,20 @@ public void

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669842572 ## modules/sql-engine/src/testFixtures/java/org/apache/ignite/internal/sql/engine/util/SqlTestUtils.java: ## @@ -351,4 +355,50 @@ public static RexNode

Re: [PR] IGNITE-22465 Recover zones' replicas and pending/stable events on a node restart [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4043: URL: https://github.com/apache/ignite-3/pull/4043#discussion_r1669804437 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -203,22 +225,115 @@ public

Re: [PR] IGNITE-22465 Recover zones' replicas and pending/stable events on a node restart [ignite-3]

2024-07-09 Thread via GitHub
sanpwc commented on code in PR #4043: URL: https://github.com/apache/ignite-3/pull/4043#discussion_r1669803933 ## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ## @@ -203,22 +225,115 @@ public

[PR] IGNITE-22636 [ignite-3]

2024-07-09 Thread via GitHub
xtern opened a new pull request, #4059: URL: https://github.com/apache/ignite-3/pull/4059 https://issues.apache.org/jira/browse/IGNITE-22636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the