[GitHub] [skywalking] codecov-io edited a comment on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+

2020-01-18 Thread GitBox
codecov-io edited a comment on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575956045 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4264?src=pr=h1) Report >

[GitHub] [skywalking] codecov-io edited a comment on issue #4268: merge e2e profile test project

2020-01-18 Thread GitBox
codecov-io edited a comment on issue #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#issuecomment-575968756 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=h1) Report > Merging

[GitHub] [skywalking] geektcp opened a new pull request #4270: bug fix

2020-01-18 Thread GitBox
geektcp opened a new pull request #4270: bug fix URL: https://github.com/apache/skywalking/pull/4270 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix ___ ### Bug fix - Bug description. ``` Skywalking

[GitHub] [skywalking] geektcp closed pull request #4270: bug fix

2020-01-18 Thread GitBox
geektcp closed pull request #4270: bug fix URL: https://github.com/apache/skywalking/pull/4270 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking] geektcp opened a new pull request #4270: bug fix

2020-01-18 Thread GitBox
geektcp opened a new pull request #4270: bug fix URL: https://github.com/apache/skywalking/pull/4270 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix ___ ### Bug fix - Bug description. ``` Skywalking

[GitHub] [skywalking] codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-18 Thread GitBox
codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575109679 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=h1) Report > Merging

[GitHub] [skywalking] mrproliu commented on issue #4268: merge e2e profile test project

2020-01-18 Thread GitBox
mrproliu commented on issue #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#issuecomment-575972277 /run CI This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] mrproliu removed a comment on issue #4268: merge e2e profile test project

2020-01-18 Thread GitBox
mrproliu removed a comment on issue #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#issuecomment-575972277 /run CI This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] wu-sheng closed issue #4269: ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception

2020-01-18 Thread GitBox
wu-sheng closed issue #4269: ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception URL: https://github.com/apache/skywalking/issues/4269

[GitHub] [skywalking] xasnow commented on issue #4269: ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception

2020-01-18 Thread GitBox
xasnow commented on issue #4269: ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception URL: https://github.com/apache/skywalking/issues/4269#issuecomment-575971084 environment:

[GitHub] [skywalking] xasnow opened a new issue #4269: ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception

2020-01-18 Thread GitBox
xasnow opened a new issue #4269: ServiceAndEndpointRegisterClient execute fail. org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: UNAVAILABLE: io exception URL: https://github.com/apache/skywalking/issues/4269 Please answer these questions before submitting your

[GitHub] [skywalking] wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-18 Thread GitBox
wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575970485 The PR could be accepted when you make all CI passed. Please fix them.

[GitHub] [skywalking] wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-18 Thread GitBox
wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575970444 > Actually, I think that #moveTo when doing #in is redundant I think you have removed it.

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#discussion_r368268133 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#discussion_r368267810 ## File path:

[GitHub] [skywalking] liuhaoXD commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-18 Thread GitBox
liuhaoXD commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575969960 > Any update? Actually, I think that `#moveTo` when doing `#in` is redundant, which can be covered by `#add`

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#discussion_r368267823 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#discussion_r368267794 ## File path:

[GitHub] [skywalking] xasnow commented on issue #1689: got a problem

2020-01-18 Thread GitBox
xasnow commented on issue #1689: got a problem URL: https://github.com/apache/skywalking/issues/1689#issuecomment-575969746 Hello, has this problem been solved? I also had this problem when running on windows This is an

[GitHub] [skywalking] codecov-io commented on issue #4268: merge e2e profile test project

2020-01-18 Thread GitBox
codecov-io commented on issue #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#issuecomment-575968756 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4268?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project

2020-01-18 Thread GitBox
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265731 ## File path: test/e2e/e2e-profile/e2e-profile-test-runner/pom.xml ## @@ -46,5 +46,254 @@ + +

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project

2020-01-18 Thread GitBox
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265708 ## File path: test/e2e/e2e-profile/e2e-profile-test-runner/pom.xml ## @@ -46,5 +46,254 @@ + +

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project

2020-01-18 Thread GitBox
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#discussion_r368266217 ## File path: test/e2e/e2e-profile/e2e-profile-test-runner/src/docker/clusterize.awk ## @@ -0,0 +1,64 @@ +#

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project

2020-01-18 Thread GitBox
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265675 ## File path: .github/workflows/e2e.yaml ## @@ -111,10 +111,10 @@ jobs: ./mvnw -Dcheckstyle.skip

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project

2020-01-18 Thread GitBox
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265760 ## File path: test/e2e/run.sh ## @@ -70,6 +73,7 @@ do -De2e.container.version="${E2E_VERSION}" \

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project

2020-01-18 Thread GitBox
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265752 ## File path: test/e2e/run.sh ## @@ -36,6 +36,9 @@ while [[ $# -gt 0 ]]; do --profiles=*)

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project

2020-01-18 Thread GitBox
kezhenxu94 commented on a change in pull request #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#discussion_r368265716 ## File path: test/e2e/e2e-profile/e2e-profile-test-runner/pom.xml ## @@ -46,5 +46,254 @@ + +

[GitHub] [skywalking] wu-sheng commented on issue #4268: merge e2e profile test project

2020-01-18 Thread GitBox
wu-sheng commented on issue #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#issuecomment-575967357 @dmsolr please compare this with your PR too. This is an automated message from the

[GitHub] [skywalking] mrproliu commented on issue #4268: merge e2e profile test project

2020-01-18 Thread GitBox
mrproliu commented on issue #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268#issuecomment-575966420 @kezhenxu94 This is a modification of the e2e test case, please help check it. This

[GitHub] [skywalking] mrproliu opened a new pull request #4268: merge e2e profile test project

2020-01-18 Thread GitBox
mrproliu opened a new pull request #4268: merge e2e profile test project URL: https://github.com/apache/skywalking/pull/4268 …orage types Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided

[GitHub] [skywalking] codecov-io commented on issue #4239: [WIP] Provide influxdb as a new storage plugin

2020-01-18 Thread GitBox
codecov-io commented on issue #4239: [WIP] Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-575965825 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr=h1) Report > :exclamation: No coverage uploaded for pull

[GitHub] [skywalking] wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-18 Thread GitBox
wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575964891 CI fails, please recheck. This is an automated message

[GitHub] [skywalking] wu-sheng opened a new issue #4267: Add document about time condition in GraphQL

2020-01-18 Thread GitBox
wu-sheng opened a new issue #4267: Add document about time condition in GraphQL URL: https://github.com/apache/skywalking/issues/4267 Based on #4266, we should add this kind of documents in here, https://github.com/apache/skywalking/blob/master/docs/en/protocols/query-protocol.md, as a

[GitHub] [skywalking] wu-sheng commented on issue #4267: Add document about time condition in GraphQL

2020-01-18 Thread GitBox
wu-sheng commented on issue #4267: Add document about time condition in GraphQL URL: https://github.com/apache/skywalking/issues/4267#issuecomment-575964864 FYI @longdevops332, after codes read, you want to help about this, please send a pull request.

[GitHub] [skywalking] wu-sheng commented on issue #4266: Rocketbot time range and interface condition correspondence

2020-01-18 Thread GitBox
wu-sheng commented on issue #4266: Rocketbot time range and interface condition correspondence URL: https://github.com/apache/skywalking/issues/4266#issuecomment-575964741 Read MetricQuery#getValues. There are time format converts about start and end time. You will have the clue about

[GitHub] [skywalking] wu-sheng closed issue #4266: Rocketbot time range and interface condition correspondence

2020-01-18 Thread GitBox
wu-sheng closed issue #4266: Rocketbot time range and interface condition correspondence URL: https://github.com/apache/skywalking/issues/4266 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] longdevops332 opened a new issue #4266: Rocketbot time range and interface condition correspondence

2020-01-18 Thread GitBox
longdevops332 opened a new issue #4266: Rocketbot time range and interface condition correspondence URL: https://github.com/apache/skywalking/issues/4266 Everyone, please consult. At present, I need to get the statistics in skywalking to make a report. In the rocketbot tracking

[GitHub] [skywalking] wu-sheng closed issue #4265: Rocketbot 访问skywalking接口时间筛选相关问题

2020-01-18 Thread GitBox
wu-sheng closed issue #4265: Rocketbot 访问skywalking接口时间筛选相关问题 URL: https://github.com/apache/skywalking/issues/4265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] wu-sheng commented on issue #4265: Rocketbot 访问skywalking接口时间筛选相关问题

2020-01-18 Thread GitBox
wu-sheng commented on issue #4265: Rocketbot 访问skywalking接口时间筛选相关问题 URL: https://github.com/apache/skywalking/issues/4265#issuecomment-575964031 English only. This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] longdevops332 opened a new issue #4265: Rocketbot 访问skywalking接口时间筛选相关问题

2020-01-18 Thread GitBox
longdevops332 opened a new issue #4265: Rocketbot 访问skywalking接口时间筛选相关问题 URL: https://github.com/apache/skywalking/issues/4265 各位大佬,请教一下,目前需要获取Skywalking中的统计信息制作报表。 Rocketbot追踪模块中 时间范围:2020-01-17 01:00:00 ~ 2020-01-17 02:00:00选择的是这样的, 怎么浏览器调试中接口访问,条件是"start":"2020-01-17

[GitHub] [skywalking] dmsolr commented on a change in pull request #4239: [WIP] Provide influxdb as a new storage plugin

2020-01-18 Thread GitBox
dmsolr commented on a change in pull request #4239: [WIP] Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r368263056 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+

2020-01-18 Thread GitBox
wu-sheng commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575960326 > Yeah, this PR doesn't contain any new feature(for skywalking), just a refactor with the new

[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
wu-sheng commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575959311 > Agree, users modify only the OAL files they need. I mean, using two separate OAL files. If the receiver is being active, the provider could

[GitHub] [skywalking] JohnNiang commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+

2020-01-18 Thread GitBox
JohnNiang commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575959138 ## 1: > the Blank cost more resources, what is the benefit? In many cases,

[GitHub] [skywalking] arugal commented on issue #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
arugal commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575958653 > If those are in another OAL file, then OAL engine could provide an API to activate some OAL files, such as from browser-receiver provider.

[GitHub] [skywalking] codecov-io edited a comment on issue #4177: Enhance gRPC plugin

2020-01-18 Thread GitBox
codecov-io edited a comment on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-575098453 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[GitHub] [skywalking] wu-sheng commented on issue #4259: i want to know the meaning of the filed "mapping_service_id"

2020-01-18 Thread GitBox
wu-sheng commented on issue #4259: i want to know the meaning of the filed "mapping_service_id" URL: https://github.com/apache/skywalking/issues/4259#issuecomment-575956118 I will do that for sure, if I could make it passed.

[GitHub] [skywalking] coki230 edited a comment on issue #4259: i want to know the meaning of the filed "mapping_service_id"

2020-01-18 Thread GitBox
coki230 edited a comment on issue #4259: i want to know the meaning of the filed "mapping_service_id" URL: https://github.com/apache/skywalking/issues/4259#issuecomment-575956060 @wu-sheng thanks, if you publish a paper. please send the message to the home page. i will focus it.

[GitHub] [skywalking] codecov-io commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+

2020-01-18 Thread GitBox
codecov-io commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575956045 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4264?src=pr=h1) Report >

[GitHub] [skywalking] coki230 commented on issue #4259: i want to know the meaning of the filed "mapping_service_id"

2020-01-18 Thread GitBox
coki230 commented on issue #4259: i want to know the meaning of the filed "mapping_service_id" URL: https://github.com/apache/skywalking/issues/4259#issuecomment-575956060 thanks, if you publish a paper. please send the message to the home page. i will focus it.

[GitHub] [skywalking] wu-sheng commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+

2020-01-18 Thread GitBox
wu-sheng commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575953773 > Empty means that the string contains nothing or is null, while Blank is not only Empty string,

[skywalking-website] branch c200 updated: Update blog text.

2020-01-18 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch c200 in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/c200 by this push: new 718c818 Update blog text. 718c818 is

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4239: [WIP] Provide influxdb as a new storage plugin

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4239: [WIP] Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r368257153 ## File path:

[GitHub] [skywalking] ElderJames commented on issue #4257: Receiver implementation in Http protocol

2020-01-18 Thread GitBox
ElderJames commented on issue #4257: Receiver implementation in Http protocol URL: https://github.com/apache/skywalking/issues/4257#issuecomment-575948504 I know that grpc must use http2 but grpc-web use http1.We maybe can support gpc-web.

[GitHub] [skywalking] codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230)

2020-01-18 Thread GitBox
codecov-io edited a comment on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575109679 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4247?src=pr=h1) Report > Merging

[GitHub] [skywalking-query-protocol] wu-sheng commented on issue #30: Support query browser error log

2020-01-18 Thread GitBox
wu-sheng commented on issue #30: Support query browser error log URL: https://github.com/apache/skywalking-query-protocol/pull/30#issuecomment-575906990 Let's hold this PR until @Fine0830 is back from the vacation. This is

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230959 ## File path: oap-server/server-bootstrap/src/main/resources/official_analysis.oal ## @@ -102,3 +102,77 @@

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230585 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DefaultScopeDefine.java

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230350 ## File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4 ## @@

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230313 ## File path: docs/en/setup/backend/backend-alarm.md ## @@ -85,7 +85,7 @@ Webhook requires the peer is a web

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230582 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DefaultScopeDefine.java

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230521 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230444 ## File path: docs/en/setup/backend/backend-alarm.md ## @@ -85,7 +85,7 @@ Webhook requires the peer is a web

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230459 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230557 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DefaultScopeDefine.java

[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
codecov-io edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging

[skywalking] branch master updated: Sniffer processing profile task and report status and snapshot (#4220)

2020-01-18 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 90f3c4d Sniffer processing profile

[GitHub] [skywalking] kezhenxu94 merged pull request #4220: sniffer processing profile task and report status and snapshot

2020-01-18 Thread GitBox
kezhenxu94 merged pull request #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220 This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] codecov-io edited a comment on issue #4220: sniffer processing profile task and report status and snapshot

2020-01-18 Thread GitBox
codecov-io edited a comment on issue #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-573421072 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=h1) Report > Merging

[GitHub] [skywalking] JohnNiang commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+

2020-01-18 Thread GitBox
JohnNiang commented on issue #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#issuecomment-575884819 > > we may have to differentiate the meaning between Empty and Blank > > What is the

[GitHub] [skywalking-query-protocol] arugal opened a new pull request #30: Support query browser error log

2020-01-18 Thread GitBox
arugal opened a new pull request #30: Support query browser error log URL: https://github.com/apache/skywalking-query-protocol/pull/30 ref: [skywalking#4166](https://github.com/apache/skywalking/issues/4166) This is an

[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
codecov-io edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request

[GitHub] [skywalking] codecov-io edited a comment on issue #4220: sniffer processing profile task and report status and snapshot

2020-01-18 Thread GitBox
codecov-io edited a comment on issue #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-573421072 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4220?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
codecov-io edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot

2020-01-18 Thread GitBox
kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#discussion_r368215552 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot

2020-01-18 Thread GitBox
wu-sheng commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#discussion_r368215435 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #4220: sniffer processing profile task and report status and snapshot

2020-01-18 Thread GitBox
wu-sheng commented on issue #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#issuecomment-575879392 > You have only ES DAO for ES6, ProfileTaskQueryEsDAO, ProfileTaskLogEsDAO, and you use them in ES7, they're not

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot

2020-01-18 Thread GitBox
kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#discussion_r368213672 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot

2020-01-18 Thread GitBox
kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#discussion_r368214095 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot

2020-01-18 Thread GitBox
kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#discussion_r368214282 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot

2020-01-18 Thread GitBox
kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#discussion_r368214112 ## File path:

[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP

2020-01-18 Thread GitBox
arugal commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r368214206 ## File path: