[gprs-provision PATCHv4 0/8] plugin API for provisioning of GPRS context settings

Hello Here is a new patchset about implementing automatic provisioning of GPRS context settings. ("Internet Access Provider database" TODO item). Compared to last one, this makes gprs-provision a "pseudo" atom similar to nettime. And possible races caused by a removed gprs-atom, while it is run

[PATCH 4/8] gprs-provision: probe gprs_provision drivers

--- src/modem.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index f587766..a835775 100644 --- a/src/modem.c +++ b/src/modem.c @@ -424,6 +424,7 @@ static void modem_change_state(struct ofono_modem *modem, driver-

[PATCH 2/8] gprs-provision: add new atom type

--- src/ofono.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 77567c2..873b688 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -127,6 +127,7 @@ enum ofono_atom_type { OFONO_ATOM_TYPE_NETTIME = 21, OFONO_ATOM_TYPE_CTM

[PATCH 5/8] gprs: add gprs context provisioning

--- src/gprs.c | 147 ++-- 1 files changed, 133 insertions(+), 14 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index 0e86bdf..b0d58f6 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -43,6 +43,7 @@ #include "common.h" #include "storage.h"

[PATCH 3/8] gprs-provision: add driver API sources

--- Makefile.am |2 +- src/gprs-provision.c | 236 ++ 2 files changed, 237 insertions(+), 1 deletions(-) create mode 100644 src/gprs-provision.c diff --git a/Makefile.am b/Makefile.am index 22ec95d..e792851 100644 --- a/Makefile.am ++

[PATCH 1/8] gprs-provision: add driver API header

--- Makefile.am |2 +- include/gprs-provision.h | 80 ++ 2 files changed, 81 insertions(+), 1 deletions(-) create mode 100644 include/gprs-provision.h diff --git a/Makefile.am b/Makefile.am index da59be7..22ec95d 100644 --- a/Makefil

[PATCH 6/8] sim: getters for mcc and mnc definition

--- include/sim.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/sim.h b/include/sim.h index 830322a..81df60e 100644 --- a/include/sim.h +++ b/include/sim.h @@ -178,6 +178,8 @@ void ofono_sim_set_data(struct ofono_sim *sim, void *data); void *ofono_sim_get_data(

[PATCH 7/8] sim: getters for mcc and mnc implementation

--- src/sim.c | 50 +++--- 1 files changed, 31 insertions(+), 19 deletions(-) diff --git a/src/sim.c b/src/sim.c index d627647..86c3f13 100644 --- a/src/sim.c +++ b/src/sim.c @@ -78,6 +78,8 @@ struct ofono_sim { gboolean barred_dialing;

[PATCH 8/8] gprs-provision: add example context provisioning driver

--- Makefile.am |3 + examples/provision.c | 206 ++ 2 files changed, 209 insertions(+), 0 deletions(-) create mode 100644 examples/provision.c diff --git a/Makefile.am b/Makefile.am index e792851..a74f75e 100644 --- a/Makefile.am +++

Re: [RFC PATCH 0/3] Long phone numbers

On Mon, Jan 17, 2011 at 11:18:51PM +0200, Pekka Pessi wrote: > Hi Rafael, > > 2011/1/17 Rafael Ignacio Zurita : > > This is a proposal for the "long phone number" task (80 digits max length). > > It changes OFONO_MAX_PHONE_NUMBER_LENGTH and splits > > common:valid_phone_number_format(), to make su

[PATCH] [PATCH v2] doc: Add Bluetooth Dial-up Networking Profile specs

--- doc/bluetooth-cmd-set.txt | 45 + doc/standards.txt |4 2 files changed, 49 insertions(+), 0 deletions(-) create mode 100644 doc/bluetooth-cmd-set.txt diff --git a/doc/bluetooth-cmd-set.txt b/doc/bluetooth-cmd-set.txt new file mo

RE: Band selection issue

Hi Lucas, >What frequency are you trying to set? Could you verify if it works by >setting both GSM and UMTS frequencies to 'any' ? I tried all value and got same result: call back error. >It might be a problem that this modem does not accept several >frequencies together (currently we keep the

Re: Ofono CF states not always correct

Hi Denis, On Fri, 2011-01-14 at 17:59 +0200, Denis Kenzior wrote: > Hi Jarko, > > Both are active and the modem should be reporting both. At least that > is how I understood the specifications. > Well that is a bit debatable. As 27.007 states: command: +CCFC=,[,[,[,[,[,[,]] : integer type

[PATCH 1/2] simutil: M9, M11, Minor style fixes and indentation

--- src/simutil.h | 68 1 files changed, 34 insertions(+), 34 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index ad84907..cda9d55 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -19,36 +19,39 @@ * */ +#define SIM_EFSPN_

[PATCH 2/2] simutil: sim_fileid sorted in numerical order

--- src/simutil.h | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index cda9d55..fb87c3a 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -33,14 +33,18 @@ enum sim_fileid { SIM_EF_CPHS_MBDN_FILEID = 0x6f17,

[PATCH v2 1/1] atmodem: add ifx support for pin retries query

Adds ifx support for the remaining pin retries query --- drivers/atmodem/sim.c | 84 +++-- 1 files changed, 67 insertions(+), 17 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index c5f4a44..2219e88 100644 --- a/drivers/atmode

[PATCH v2 0/1] ifx support for querying remaining pin entries

Hi, Following patch adds ifx support for querying remaining pin entries Regards, Jeevaka Jeevaka Badrappan (1): atmodem: add ifx support for pin retries query drivers/atmodem/sim.c | 84 +++-- 1 files changed, 67 insertions(+), 17 deletions(-)

Re: [PATCH 1/2] atmodem: move USSD quirk to probe and use it also for STE modems

Hi Denis, On Mon, 2011-01-17 at 17:58 +0200, Denis Kenzior wrote: > Hi Lasse, > > On 01/17/2011 02:42 AM, Lasse Kunnasluoto wrote: > > Hi Marcel, > > > Supporting IRA character set is not really an option since IRA and GSM > 7bit have disjoint sets of characters. The best you can really do is:

[PATCH 1/5] simutil: Add EFcsp file and service group IDs

--- src/simutil.h | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index 7e386fa..61440a5 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -26,6 +26,7 @@ enum sim_fileid { SIM_EFLI_FILEID = 0x6F05,

[PATCH 0/5] Implement CPHS CSP support

Hi All, This patch set implements support for the PLMN mode bit found in the CPHS EFcsp file. Based on the PLMN mode setting, the netreg atom enables or disables manual network registration. There is a new Mode property value of 'forced-auto' for indicating the case when manual selection is disab

[PATCH 2/5] netreg: Add CPHS CSP PLMN mode implementation

--- src/network.c | 85 - 1 files changed, 84 insertions(+), 1 deletions(-) diff --git a/src/network.c b/src/network.c index ae0f334..927f7ce 100644 --- a/src/network.c +++ b/src/network.c @@ -66,6 +66,7 @@ struct ofono_netreg { in

[PATCH 4/5] doc: Add short mention of CPHS under standards

--- doc/standards.txt |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/doc/standards.txt b/doc/standards.txt index 2b85cb0..35f2a3a 100644 --- a/doc/standards.txt +++ b/doc/standards.txt @@ -166,3 +166,12 @@ Describes the general background and assumption of wirele

[PATCH 5/5] TODO: Remove completed CPHS CSP task

--- TODO | 13 - 1 files changed, 0 insertions(+), 13 deletions(-) diff --git a/TODO b/TODO index 1acae81..345952e 100644 --- a/TODO +++ b/TODO @@ -97,19 +97,6 @@ SIM / SIM File system Complexity: C1 Owner: Marit Henriksen -- Add support for CPHS Customer Service Profile (C

[PATCH 3/5] doc: Add documentation for 'forced-mode'

--- doc/network-api.txt | 24 ++-- 1 files changed, 14 insertions(+), 10 deletions(-) diff --git a/doc/network-api.txt b/doc/network-api.txt index c252988..c46e81b 100644 --- a/doc/network-api.txt +++ b/doc/network-api.txt @@ -75,21 +75,25 @@ Properties string Mode [readonl

[PATCH] ste: Use UTF-8 as a default character set

--- plugins/ste.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 7bb7232..cc01f7b 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -247,7 +247,7 @@ static int ste_enable(struct ofono_modem *modem) return -EIO;

[PATCH 1/1] TODO: claim IPv6 task

--- TODO |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/TODO b/TODO index dec43fd..7fe2d8e 100644 --- a/TODO +++ b/TODO @@ -212,7 +212,8 @@ GPRS - Add support for IPv6 GPRS contexts. Priority: Medium - Complexity: C1 + Complexity: C2 + Owner: Mika Liljeberg

IPv6 support

Hi all, I plan to start working on IPv6 support. Br, MikaL [PATCH 1/1] TODO: claim IPv6 task ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] [PATCH v2] doc: Add Bluetooth Dial-up Networking Profile specs

Hi Olivier, > doc/bluetooth-cmd-set.txt | 45 > + > doc/standards.txt |4 > 2 files changed, 49 insertions(+), 0 deletions(-) > create mode 100644 doc/bluetooth-cmd-set.txt please create two separate patches for this. Also I would

Re: [PATCH 1/2] simutil: M9, M11, Minor style fixes and indentation

Hi Jessica, > enum ber_tlv_data_type ber_tlv_iter_get_class(struct ber_tlv_iter *iter); > -enum ber_tlv_data_encoding_type > - ber_tlv_iter_get_encoding(struct ber_tlv_iter *iter); > +enum ber_tlv_data_encoding_type ber_tlv_iter_get_encoding( > +

Re: [PATCH v2 1/1] atmodem: add ifx support for pin retries query

Hi Jeevaka, > Adds ifx support for the remaining pin retries query since the commit message is essentially the same as the subject line, you can leave it out. Or better expend the commit message with further details or example of the command. > --- > drivers/atmodem/sim.c | 84 >

Re: [PATCH 4/5] doc: Add short mention of CPHS under standards

Hi Aki, > doc/standards.txt |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'

Hi Aki, > + "auto" Network registration is performed > +automatically. > + "forced-auto" Network registration is performed > +automatically whi

Re: [PATCH 2/5] netreg: Add CPHS CSP PLMN mode implementation

Hi Aki, > + if (netreg->settings) { > + g_key_file_set_boolean(netreg->settings, SETTINGS_GROUP, > + "ForcedAuto", netreg->forced_auto); > + storage_sync(netreg->imsi, SETTINGS_STORE, netreg->settings); > + } why are we botheri

Re: [PATCH] ste: Use UTF-8 as a default character set

Hi Lasse, > plugins/ste.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/plugins/ste.c b/plugins/ste.c > index 7bb7232..cc01f7b 100644 > --- a/plugins/ste.c > +++ b/plugins/ste.c > @@ -247,7 +247,7 @@ static int ste_enable(struct ofono_modem *modem) >

Re: [PATCH 1/1] TODO: claim IPv6 task

Hi Mika, > TODO |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 7/8] sim: getters for mcc and mnc implementation

Hi Jukka, > src/sim.c | 50 +++--- > 1 files changed, 31 insertions(+), 19 deletions(-) > > diff --git a/src/sim.c b/src/sim.c > index d627647..86c3f13 100644 > --- a/src/sim.c > +++ b/src/sim.c > @@ -78,6 +78,8 @@ struct ofono_sim { > gboolean

[PATCH] atmodem: coding style fix

--- drivers/atmodem/sim.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index c5f4a44..8d89d53 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c @@ -508,7 +508,7 @@ static void huawei_cpin_cb(gboolean ok, GAtRes

Re: [PATCH 1/8] gprs-provision: add driver API header

Hi Jukka, > +/* > + * Callback from provisioning plugin. > + * settings: list of struct ofono_gprs_provision_data > + * > + * It is responsibility of callback function to free settings-list > + * settings-list elements must be freed with ofono_gprs_provision_data_free() > + */ > +typedef void (*

Re: [PATCH 3/8] gprs-provision: add driver API sources

Hi Jukka, I am just making some minor style comments right now. > +struct gprs_provision_request { > + GSList *drivers; /* Provisioning drivers to be called */ > + struct ofono_modem *modem; > + ofono_gprs_provision_cb_t cb; > + void *user_data; > +}; > + > +static void settings

Re: [PATCH] atmodem: coding style fix

Hi Jeevaka, > drivers/atmodem/sim.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 3/5 v3] nettime: DBUS and compilation configuration

Hi Aki, > >> So these are redundant, unless the whole thing is rewritten as: > >> > >>>> send_interface="org.ofono.SimToolkitAgent"/> > >>>> send_interface="org.ofono.PushNotificationAgent"/> > >>>> send_interface="org.ofono.SmartMessagingAgent"/> > >> > > > > The agents ar

[PATCHv3 0/2] doc: Bluetooth Dial-up networking specs

Hi, Following Marcel's suggestion ;) ,the submitted patches add some text information regarding the bluetooth dialup networking profile. doc/dialup-command-set.txt | 45 doc/standards.txt |4 +++ 2 files changed, 49 insertions(+), 0 de

[PATCHv3 1/2] doc:Add Bluetooth Dial-up Networking Profile specs

--- doc/standards.txt |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/doc/standards.txt b/doc/standards.txt index 35f2a3a..b7b68f3 100644 --- a/doc/standards.txt +++ b/doc/standards.txt @@ -175,3 +175,7 @@ standards. oFono implements some of the features found in the P

[PATCHv3 2/2] doc: Add AT command set for Dialup Networking

--- doc/dialup-command-set.txt | 45 1 files changed, 45 insertions(+), 0 deletions(-) create mode 100644 doc/dialup-command-set.txt diff --git a/doc/dialup-command-set.txt b/doc/dialup-command-set.txt new file mode 100644 index 000..a7a1df3 ---

[PATCH] atmodem: fix signal strength issue with ifx

--- drivers/atmodem/network-registration.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c index 0c77ba8..e11c974 100644 --- a/drivers/atmodem/network-registration.c +++ b/drivers/atmodem/n

Re: [PATCHv3 1/2] doc:Add Bluetooth Dial-up Networking Profile specs

Hi Olivier, > doc/standards.txt |4 > 1 files changed, 4 insertions(+), 0 deletions(-) patch has been applied. However please ensure doc: in the subject. It was easy to fix so did it for you. Regards Marcel ___ ofono mailing list ofono@ofo

Re: [PATCHv3 2/2] doc: Add AT command set for Dialup Networking

Hi Olivier, > doc/dialup-command-set.txt | 45 > > 1 files changed, 45 insertions(+), 0 deletions(-) > create mode 100644 doc/dialup-command-set.txt patch has been applied. Thanks. Regards Marcel ___

Re: [PATCH] atmodem: fix signal strength issue with ifx

Hi Jeevaka, > drivers/atmodem/network-registration.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/atmodem/network-registration.c > b/drivers/atmodem/network-registration.c > index 0c77ba8..e11c974 100644 > --- a/drivers/atmodem/network-registration.c

Re: [PATCH] ste: Use UTF-8 as a default character set

Hi Marcel, On Tue, 2011-01-18 at 16:32 +0200, Marcel Holtmann wrote: > Hi Lasse, > > > plugins/ste.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/plugins/ste.c b/plugins/ste.c > > index 7bb7232..cc01f7b 100644 > > --- a/plugins/ste.c > > +++ b/plugins/ste

Re: [PATCH v3] gatserver: ATS6 command handler added

Hi Olivier, > Use integer to be compliant with existing function prototypes. patch has been applied, but I did remove this comment from the commit message. If you see it within git log it made no sense and was only relevant for the review. > --- So such a comment for review belongs between ---

Re: [PATCH] ste: Use UTF-8 as a default character set

Hi Laase, > > is it guaranteed that every single STE modem supports UTF-8 character > > set? > > > Based on information I have, yes, every single ste modem support UTF-8. > > > I would rather see a new command checking for supported character sets > > and then picking the default. And intermixin

[PATCH] bluetooth: Add bluetooth server support (based on Zhenhua code)

It watches Bluetooth adapter property changes and adds SDP record to listen client connection request (refactored to support both DUN and HFP GW servers). Add bluetooth_ref()/bluetooth_unref() to support reference count in bluetooth utils. --- Makefile.am |2 +- plugins/bluetooth.c |

[PATCH v2] ste: Use UTF-8 as a default character set

--- plugins/ste.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/ste.c b/plugins/ste.c index 7bb7232..44cfc14 100644 --- a/plugins/ste.c +++ b/plugins/ste.c @@ -250,6 +250,10 @@ static int ste_enable(struct ofono_modem *modem) g_at_chat_send(data->chat,

Re: [PATCH 1/2] simutil: M9, M11, Minor style fixes and indentation

Hi Jessica, On 01/18/2011 06:32 AM, Jessica Nilsson wrote: > --- > src/simutil.h | 68 > 1 files changed, 34 insertions(+), 34 deletions(-) > This patch has been applied, but I had to merge it with some code cleanups that were made in t

Re: [PATCH 2/2] simutil: sim_fileid sorted in numerical order

Hi Jessica, On 01/18/2011 06:32 AM, Jessica Nilsson wrote: > --- > src/simutil.h | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > This patch no longer applied, so I pushed my own version of the fix. Regards, -Denis ___ ofono ma

Re: [PATCH] bluetooth: Add bluetooth server support (based on Zhenhua code)

Hi Fred, > Add bluetooth_ref()/bluetooth_unref() to support reference count in > bluetooth utils. didn't you had this as separate patch already? I think we should keep that as a separate patch. > --- > Makefile.am |2 +- > plugins/bluetooth.c | 396 +

Re: [PATCH v2] ste: Use UTF-8 as a default character set

Hi Lasse, > plugins/ste.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) patch has been applied. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: Ofono CF states not always correct

Hi Jarko, > So actually they aren't both "active" at same time as the logs show but > personally I don't really care as long as the results are consistent > regardless which API you use which is not the case at the moment as > querying through org.ofono.CallForwarding can give you different result

[PATCH] bluetooth: Add reference count for bluetooth utils

Add bluetooth_ref()/bluetooth_unref() to support reference count in bluetooth utils. --- plugins/bluetooth.c | 62 +- 1 files changed, 46 insertions(+), 16 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 602c6da..a82cc64

Re: [PATCH] bluetooth: Add reference count for bluetooth utils

Hi Frédéric, * Frédéric Danis [2011-01-18 17:29:59 +0100]: > Add bluetooth_ref()/bluetooth_unref() to support reference count in > bluetooth utils. > --- > plugins/bluetooth.c | 62 +- > 1 files changed, 46 insertions(+), 16 deletions(-) > > di

[PATCH v2] bluetooth: Add reference count for bluetooth utils

Add bluetooth_ref()/bluetooth_unref() to support reference count in bluetooth utils. --- plugins/bluetooth.c | 60 ++ 1 files changed, 45 insertions(+), 15 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 602c6da..d641d18

Re: [PATCH v2] bluetooth: Add reference count for bluetooth utils

Hi Frédéric, * Frédéric Danis [2011-01-18 18:05:03 +0100]: > Add bluetooth_ref()/bluetooth_unref() to support reference count in > bluetooth utils. > --- > plugins/bluetooth.c | 60 ++ > 1 files changed, 45 insertions(+), 15 deletions(-) > > di

[PATCH] gatchat: Fix issue after removing deprecated functions

--- gatchat/gatio.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/gatchat/gatio.c b/gatchat/gatio.c index 9cfc998..53896df 100644 --- a/gatchat/gatio.c +++ b/gatchat/gatio.c @@ -145,6 +145,7 @@ gsize g_at_io_write(GAtIO *io, const gchar *data, gsize count)

Re: [PATCH 2/5] netreg: Add CPHS CSP PLMN mode implementation

Hi Marcel, 2011/1/18 Marcel Holtmann : >> +     if (netreg->settings) { >> +             g_key_file_set_boolean(netreg->settings, SETTINGS_GROUP, >> +                                     "ForcedAuto", netreg->forced_auto); >> +             storage_sync(netreg->imsi, SETTINGS_STORE, netreg->setting

Re: [PATCH 2/5] netreg: Add CPHS CSP PLMN mode implementation

Hi Aki, On 01/18/2011 12:44 PM, Aki Niemi wrote: > Hi Marcel, > > 2011/1/18 Marcel Holtmann : >>> + if (netreg->settings) { >>> + g_key_file_set_boolean(netreg->settings, SETTINGS_GROUP, >>> + "ForcedAuto", netreg->forced_auto); >>> +

Re: [PATCH 2/5] netreg: Add CPHS CSP PLMN mode implementation

Hi Denis, 2011/1/18 Denis Kenzior : >> We read the value always, yes, but storing the last known value rids >> us of a superfluous PropertyChanged signal in the case when last value >> of forced_auto was true, and after reading is still true. This is >> because forced_auto is by default set to fal

Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'

Hi Marcel, 2011/1/18 Marcel Holtmann : >> +                             "auto"         Network registration is >> performed >> +                                            automatically. >> +                             "forced-auto"  Network registration is >> performed >> +                    

Re: [PATCH 1/5] Add SIM authentication atom's driver definitions.

Hi Andrew, > +typedef void (*ofono_sim_list_apps_cb_t)(const struct ofono_error *error, > + struct ofono_sim_app_record *list, > + int count, void *data); So I've been thinking about this one. Was there a reason why you want

Re: [PATCH 2/5] simutil: SIM applications directory decoding utils.

Hi Andrew, On 01/17/2011 11:38 AM, Andrzej Zaborowski wrote: > --- > src/simutil.c | 57 > + > src/simutil.h |2 ++ > 2 files changed, 59 insertions(+), 0 deletions(-) > > diff --git a/src/simutil.c b/src/simutil.c > index 8abf3d5..b

Re: [PATCH 5/5] atmodem: sim-auth atom driver.

Hi Andrew, > +static void at_discover_apps_cb(gboolean ok, GAtResult *result, > + gpointer user_data) > +{ > + struct cb_data *cbd = user_data; > + GAtResultIter iter; > + ofono_sim_list_apps_cb_t cb = cbd->cb; > + struct ofono_error error; > + GSLis

Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'

Hi Aki, > >> + "auto" Network registration is > >> performed > >> +automatically. > >> + "forced-auto" Network registration is > >> performed > >> +

Re: [gisi-notify-fix PATCH 1/4] gisi: remove before notify

Hi Pekka, 2011/1/12 : > @@ -192,24 +223,18 @@ static void service_dispatch(GIsiServiceMux *mux, > GIsiMessage *msg, >                        pending_dispatch(pend, msg); > >                } else if (pend->type == GISI_MESSAGE_TYPE_RESP && > -                               !is_indication && pend

Re: [gisi-notify-fix PATCH 4/4] isimodem: fix crash in gprs

Hi Pekka, 2011/1/12 : > From: Pekka Pessi > > There was a crash if gprs was removed while creating context. > --- >  drivers/isimodem/gprs.c |    3 +++ >  1 files changed, 3 insertions(+), 0 deletions(-) Patch was pushed, thanks. Cheers, Aki ___ ofon

Re: [gisi-notify-fix PATCH 2/4] gisi: simplify handling of pending

Hi Pekka, 2011/1/12 : > diff --git a/gisi/modem.h b/gisi/modem.h > index fff1338..91fe3d0 100644 > --- a/gisi/modem.h > +++ b/gisi/modem.h > @@ -109,7 +109,9 @@ int g_isi_response_vsend(GIsiModem *modem, const > GIsiMessage *req, > >  GIsiPending *g_isi_pending_from_msg(const GIsiMessage *msg);

Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'

Hi Marcel, 2011/1/18 Marcel Holtmann : > And while thinking about this, now I have another question. If this flag > is set on the SIM card, are you allowed to deregister from the network? I suppose so. However, you know how I feel about Deregister() to begin with. I think with the Online property

Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'

Hi Aki, > > And while thinking about this, now I have another question. If this flag > > is set on the SIM card, are you allowed to deregister from the network? > > I suppose so. However, you know how I feel about Deregister() to begin > with. I think with the Online property, it simply serves no

Re: [gisi-notify-fix PATCH 2/4] gisi: simplify handling of pending

Hi, 2011/1/18 Aki Niemi : >> -void g_isi_pending_remove(GIsiPending *operation); >> +void g_isi_pending_own(GIsiPending *op, gpointer owner); >> +void g_isi_remove_all_my_pending(GIsiModem *modem, uint8_t resource, >> +                                       gpointer owner); > > Overall, I like the

Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'

Hi Marcel, >> The reason I ended up extending the Mode property was that once >> forced_auto is true, no other Mode than auto is anyway possible. So in >> a sense it is another type of Mode, which isn't to say a separate >> property wouldn't work equally well. >> >> I'm really open to either optio

Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'

Hi Aki, On 01/18/2011 02:35 PM, Aki Niemi wrote: > Hi Marcel, > > 2011/1/18 Marcel Holtmann : >> And while thinking about this, now I have another question. If this flag >> is set on the SIM card, are you allowed to deregister from the network? > > I suppose so. However, you know how I feel abou

Re: [PATCH 1/9] include: add cdip field in ofono_call

Hi Lucas, On 01/12/2011 05:27 AM, Lucas De Marchi wrote: > --- > include/types.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > I applied all 9 patches in this series but made some minor modifications afterwards. Can you review and make sure things are still working as intended

Re: Ofono CF states not always correct

HI Denis, 2011/1/18 Denis Kenzior : > Ok, so I'm convinced we're not handling this properly.  Based on your > testing and my own independent testing setting the Unconditional CF rule > does indeed 'hide' all other rules so they appear inactive. > > So do you care to come up with a patch fixing thi

Re: Ofono CF states not always correct

Hi Pekka, On 01/18/2011 03:08 PM, Pekka Pessi wrote: > HI Denis, > > 2011/1/18 Denis Kenzior : >> Ok, so I'm convinced we're not handling this properly. Based on your >> testing and my own independent testing setting the Unconditional CF rule >> does indeed 'hide' all other rules so they appear

[gisi-notify-fix PATCHv2 1/2] gisi: simplify pending management

From: Pekka Pessi Client or server mark their pending objects with the function g_isi_pending_set_owner(). When client or server get destroyed or reset the pending objects are removed with the function g_isi_remove_pending_by_owner(). As a client or server always uses only a particular resource,

[gisi-notify-fix PATCHv2 2/2] gisi: remove g_isi_pending_from_msg()

From: Pekka Pessi --- gisi/modem.c |9 - gisi/modem.h |2 -- 2 files changed, 0 insertions(+), 11 deletions(-) diff --git a/gisi/modem.c b/gisi/modem.c index f80d671..8750367 100644 --- a/gisi/modem.c +++ b/gisi/modem.c @@ -156,8 +156,6 @@ static void pending_dispatch(GIsiPendin

Re: Ofono CF states not always correct

Hi Denis, 2011/1/18 Denis Kenzior : > I think we can track the cached flag for conditional CFs independently > from CFU.  The question is really whether the networks allow us to > modify conditional CFs when CFU is active.  In my testing the answer is No. You can erase (##67#) or deactivate (#67#

Re: [gisi-notify-fix PATCHv2 1/2] gisi: simplify pending management

Hi Pekka, 2011/1/18 : > From: Pekka Pessi > > Client or server mark their pending objects with > the function g_isi_pending_set_owner(). > > When client or server get destroyed or reset the pending objects are > removed with the function g_isi_remove_pending_by_owner(). As a client > or server a

Re: [gisi-notify-fix PATCHv2 2/2] gisi: remove g_isi_pending_from_msg()

Hi Pekka, 2011/1/18 : > From: Pekka Pessi > > --- >  gisi/modem.c |    9 - >  gisi/modem.h |    2 -- >  2 files changed, 0 insertions(+), 11 deletions(-) Pushed, thanks! Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.or

Re: Ofono CF states not always correct

Hi Pekka, On 01/18/2011 03:32 PM, Pekka Pessi wrote: > Hi Denis, > > 2011/1/18 Denis Kenzior : >> I think we can track the cached flag for conditional CFs independently >> from CFU. The question is really whether the networks allow us to >> modify conditional CFs when CFU is active. In my testi

Re: Ofono CF states not always correct

Hi Denis, 2011/1/18 Denis Kenzior : >> 2011/1/18 Denis Kenzior : >>> I think we can track the cached flag for conditional CFs independently >>> from CFU.  The question is really whether the networks allow us to >>> modify conditional CFs when CFU is active.  In my testing the answer is No. >> >> Y

[PATCH v4, 3/7] cdma-sms: Add CDMA SMS Support

--- Makefile.am|3 +- src/cdma-smsutil.c | 735 src/cdma-smsutil.h | 299 + 3 files changed, 1036 insertions(+), 1 deletions(-) create mode 100644 src/cdma-smsutil.c create mode 100644 src/cdma-smsutil.h diff

[PATCH v4, 5/7] cdmamodem: Add CDMA SMS driver support

--- Makefile.am |3 +- drivers/atmodem/atutil.c | 21 +++ drivers/atmodem/atutil.h |3 + drivers/atmodem/sms.c | 21 --- drivers/cdmamodem/cdmamodem.c |2 + drivers/cdmamodem/cdmamodem.h |2 + drivers/cdmamodem/sms.c | 125

[PATCH v4, 4/7] cdma-sms: Add CDMA SMS Support

--- Makefile.am|2 +- src/cdma-sms.c | 330 src/ofono.h|3 + 3 files changed, 334 insertions(+), 1 deletions(-) create mode 100644 src/cdma-sms.c diff --git a/Makefile.am b/Makefile.am index bd8c058..dff5553 100644 --- a/M

[PATCH v4, 6/7] test: Add CDMA SMS Support

--- Makefile.am |6 ++- unit/test-cdmasms.c | 116 +++ 2 files changed, 121 insertions(+), 1 deletions(-) create mode 100644 unit/test-cdmasms.c diff --git a/Makefile.am b/Makefile.am index 7548942..11fc274 100644 --- a/Makefile.am +++

[PATCH v4, 7/7] cdmaphonesim: Add CDMA SMS Support

--- Makefile.am|3 + plugins/cdmaphonesim.c | 334 plugins/phonesim.c |6 + plugins/phonesim.conf | 10 ++ 4 files changed, 353 insertions(+), 0 deletions(-) create mode 100644 plugins/cdmaphonesim.c diff --git a/Makefi

Re: [PATCH] TODO: mark CDIP task as done

Hi Lucas, On 01/18/2011 05:49 PM, Lucas De Marchi wrote: > --- > TODO |7 --- > doc/features.txt |6 ++ > 2 files changed, 6 insertions(+), 7 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing

Re: [PATCH] doc: use right description for CallSettings

Hi Lucas, On 01/18/2011 06:14 PM, Lucas De Marchi wrote: > --- > doc/features.txt |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofon

Re: [sim-auth RFCv2 1/4] TODO: add SIM authentication

Hi Pekka, > +- Support SIM authentication: SIM, AKA, and GBA suites. > + > + Priority: Medium > + Complexity: C3 Please don't invent new complexity levels. We explicitly use an exponential system, so it is either a C2 or a C4, there's no inbetween ;) > + Owner: Pekka Pessi > + > Modem Emul

Re: [sim-auth RFCv2 2/4] Added doc/sim-authentication-api.txt.

Hi Pekka, On 01/12/2011 05:08 PM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > The authentication mechanisms include SIM authentication (basic A8 > authentication used with GSM), AKA authentication and UICC-based GBA > authentication. > > The SIM and AKA can be used to implement EAP and

Re: [sim-auth RFCv2 3/4] Add GBA documents to doc/standards.txt

Hi Pekka, On 01/12/2011 05:08 PM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > doc/standards.txt | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > This patch has been applied, thanks. Regards, -Denis ___ ofon

Re: [PATCH 1/3] stk: Handle Launch Browser proactive command

Hi Jeevaka, On 01/14/2011 03:38 AM, Jeevaka Badrappan wrote: > --- > src/stk.c | 90 > > src/stkagent.c | 68 ++ > src/stkagent.h |7 > 3 files changed, 165 insertions(+), 0 deletio

  1   2   >