Re: [PATCH] sim800: fix typo in model check code

On 02/04/2019 02:16 PM, CRImier wrote: Fixing a copy-paste error in SIM800 code that results in a SIM900 modem being detected as a SIM800 modem. --- plugins/sim900.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Regards, -Denis

Re: [PATCH] qmimodem: Notify when SIM is initialized

Hi Nicolas, On 01/25/2019 07:15 AM, Nicolas Serafini wrote: Since the commit that introduced the notification API of a SIM inserted and initialized I can not unlock the SIM card on a WP7607 modem. The previously mentioned commit: 54d56d763e40bc44c99a9b24aa0477bd373ea085 Signed-off-by: Nicolas

Re: Reliable SMS receive

Hi Pavel, On 02/01/2019 04:05 PM, Pavel Machek wrote: Hi! I see that great care is taken not to lose outgoing message: " Persisting of outgoing SMS messages. Whenever oFono is asked to send an SMS message, it adds it to an internal queue and persists it on disk. The queue is persistent

Re: Better help text for dial-number

Hi Pavel, On 02/01/2019 03:00 PM, Pavel Machek wrote: Better help text for "dial-number". Without details, user may be tempted to pass 0|1 (as send-sms uses) or true|false. Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 2/2] xmm7modem: chnage to assign datapath for activated PDP context

Hi Antara, On 01/31/2019 12:19 AM, Antara Borwankar wrote: Changed the handling of CGCONTRDP AT command reply in ifxmodem modem driver for XMM7MODEM vendor for assigning network interface to context settings and routing data over the selected path. --- drivers/ifxmodem/gprs-context.c | 15

Re: [PATCH 1/2] xmm7modem: Change in xmm7mode plugin for multi PDP handling

Hi Antara, On 01/31/2019 12:18 AM, Antara Borwankar wrote: Made changes in xmm7modem plugin to allow mutiple PDP context activation and to assign correct network interface to the activated PDP context. --- plugins/udevng.c | 2 ++ plugins/xmm7xxx.c | 12 2 files changed, 14

Re: [PATCH] modem: add support to clear cached pins.

Hi Nandini, On 01/16/2019 12:45 AM, Nandini Rebello wrote: Adding support to clear cached pins when modem is powered off. --- src/modem.c | 3 +++ 1 file changed, 3 insertions(+) Applied, thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH] sim: Sim PIN1 cache upon modem reset/crash

On 01/16/2019 12:37 AM, Nandini Rebello wrote: Adding SIM PIN caching feature to oFono. oFono now caches the SIM PIN1 type against the ICCID throughout its lifetime in a link list and enters implicitly upon modem reset/crash. Violates 3GPP spec 21.111, section 5.3 - User Data stored in ME.

Re: [PATCH] fix compilation on gcc-6.3

Hi Pavel, On 12/29/2018 04:24 PM, Pavel Machek wrote: gcc-6 fails to compile ofono due to #pragma directives. Limit them to gcc versions where they are needed. Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] provision: allow duplicate apn's from mbpi

Hi Martin, I can send the mbpi name diff as a regular patch if you will take it, > and drop my original patch. Sure, I can take it as long as it doesn't mess with the duplicate handling behavior. Regards, -Denis ___ ofono mailing list

Re: [PATCH] provision: allow duplicate apn's from mbpi

Hi Martin, On 01/04/2019 08:03 AM, Martin Hundebøll wrote: Hi Denis, On 02/01/2019 19.36, Denis Kenzior wrote: On 01/02/2019 05:50 AM, Martin Hundebøll wrote: Let the user/connection-manager decide what to do with duplicate apn entries instead of bailing out with an error. ---   plugins

Re: [PATCHv2] gprs: fix allocation of context id

Hi Martin, On 01/04/2019 09:44 AM, Martin Hundebøll wrote: After the convertion to l_uintset, the creation of new contexts fails due to a range error being returned from l_uintset_find_unused(). The error happens because the uinset is created with a min-value of 1, but the start-value passed

Re: PPP broken by 6fc119d9eaee5f9cc37a5a7198d1c55ef98fd645

Hi Martin, It doesn't work, because the early return skips the call to ppp_set_auth() in the last switch block. Calling the function before returning works though: This is still wrong. lcp_rcr processes many options, AUTH_PROTO being only a small subset. So you can't simply return

Re: [PATCH] sim: Sim PIN1 cache upon modem reset/crash

Hi Nandini, On 01/03/2019 05:01 AM, Nandini Rebello wrote: Adding SIM PIN caching feature to oFono. oFono now caches the SIM PIN1 type against the ICCID throughout its lifetime in a link list and enters implicitly upon modem reset/crash. Violates 3GPP spec 21.111, section 5.3 - User Data

Re: [PATCH] Fix voice call initialization problem

Hi Khaled, On 01/03/2019 10:05 AM, khaled romdhani wrote: when the voice call driver is probing, I noticed sometimes a CME Error with the code = 4 (operation not supported) related to AT commands "AT+CSSN=1,1" and "AT^SLCC=1". In the current voice call implementation for Gemalto modems the

Re: sd-bus

Hi Pavel, On 01/03/2019 02:34 PM, Pavel Machek wrote: Hi! would it be interesting to port ofono from GDBus, which comes with the huge GLib dependency, to sd-bus? It is a lot of work, but the main question is whether we can assume that systemd is deployed enough to allow the switch. As

Re: [PATCH v0] Fix voice call initialization problem

Hi Khaled, On 01/02/2019 09:49 AM, Khaled ROMDHANI wrote: when the voice call driver is probing, I noticed sometimes a CME Error with the code = 4 (operation not supported) related to AT commands "AT+CSSN=1,1" and "AT^SLCC=1". In the current voice call implementation for Gemalto modems the

Re: [PATCH] provision: allow duplicate apn's from mbpi

Hi Martin, On 01/02/2019 05:50 AM, Martin Hundebøll wrote: Let the user/connection-manager decide what to do with duplicate apn entries instead of bailing out with an error. --- plugins/provision.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) While seemingly trivial, this actually

Re: [PATCH] gprs: fix allocation of context id

Hi Martin, On 01/02/2019 05:50 AM, Martin Hundebøll wrote: After the convertion to l_uintset, the creation of new contexts fails due to a range error being returned from l_uintset_find_unused(). The error happens because the uinset is created with a min-value of 1, but the start-value passed

Re: Motorola motmdm support

Hi Tony, How are you handling data connections? PPP? Or is there some other protocol to transfer packets back and forth? All the data connections in this case are done using QMI over USB. And that probably explains why I have not seen any data related stuff on ts 27.010. Ew. So is

Re: Motorola motmdm support

Hi Pavel, Kernel 27.010 multiplexer or something else entirely? Kernel 27.010 multiplexer, AFAICT. Some of the endpoints are handled in kernel (gps, audio mixer control). Who sets up the multiplexer? Kernel? It might make your job easier if the oFono driver itself invoked the necessary

Re: Motorola motmdm support

Hi Pavel, On 12/29/2018 03:49 AM, Pavel Machek wrote: Hi! Motorola phones use "interesting" setup. There's qmi and "normal" (but very buggy) AT interface on them. Unfortunately that uses USB and uses too much power (which is a problem on phone). Plus there's /dev/motmdm1, motmdm3 and

Re: Trouble compiling ... Re: ofono fails to compile on gcc-6.3

Hi Pavel, On 12/29/2018 02:30 PM, Pavel Machek wrote: Hi! CC drivers/rilmodem/network-registration.o drivers/rilmodem/network-registration.c:40:32: error: unknown option after ‘#pragma GCC diagnostic’ kind [-Werror=pragmas] #pragma GCC diagnostic ignored "-Wrestrict" cc1:

Re: Trouble compiling ... Re: ofono fails to compile on gcc-6.3

Hi Pavel, CC drivers/rilmodem/network-registration.o drivers/rilmodem/network-registration.c:40:32: error: unknown option after ‘#pragma GCC diagnostic’ kind [-Werror=pragmas] #pragma GCC diagnostic ignored "-Wrestrict" cc1: error: unrecognized command line option

Re: [PATCH] sim: Sim PIN1 cache upon modem reset/crash

Hi Giacinto, on the other hand, the sessions will be lost anyway, downloads and streaming interrupted, due to the change of mobile IP, even if the reboot would be fast. Hey, I'm not fully convinced this is a good idea either ;) But then to play devil's advocate: - TCP can already deal with

Re: [PATCH] sim: Sim PIN1 cache upon modem reset/crash

Hi Giacinto, Can you cite the 3GPP specification number and section that this would be violating?> > 21.111 (USIM and IC card requirements), or predecessors/successors.> I have taken the rel.7, whose paragraph 5.3 (User Data Stored in ME) mentions:> > "User related security codes such as

Re: [PATCH 1/2] xmm7modem: implemnetation of coexistence functionality

Hi Antara, On 12/13/2018 02:39 AM, Antara Borwankar wrote: Added coex implementation in xmm7modem plugin --- plugins/xmm7xxx.c | 927 ++ 1 file changed, 927 insertions(+) Applied, thanks. Regards, -Denis

Re: [PATCH 2/2] xmm7modem: modified ofono.conf for coex agent

Hi Antara, On 12/13/2018 02:40 AM, Antara Borwankar wrote: Added coex agent interface to ofono.conf --- src/ofono.conf | 1 + 1 file changed, 1 insertion(+) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] sim: Sim PIN1 cache upon modem reset/crash

Hi Giacinto, Can you cite the 3GPP specification number and section that this would be violating? I will check this, but I remember that it is forbidden for at least two reasons: FYI, I have seen modems from Nokia & Intel do this. They would store the PIN in the NVRAM and if the firmware

Re: CAT-M1 and NB-IoT features support in ofono

Hi Lauri, On 12/12/2018 05:46 AM, Lauri Piikivi wrote: Hi, I wanted to verify whether ofono has implementation, or has plans, to support the 3GPP CAT-M1 and NB-IoT features? I could not find this on a quick browse of the API. Especially the power-save-mode, adjusting active time and eDRX

Re: [PATCH] sim: Sim PIN1 cache upon modem reset/crash

Hi Giacinto, No top-posting on this mailing list please. On 12/12/2018 01:59 AM, Giacinto Cifelli wrote: No, absolutely not! It is forbidden to do this by the 3GPP! Can you cite the 3GPP specification number and section that this would be violating? Regards, -Denis

Re: [PATCH] qmi: Fix Secondary DNS overwriting Primary DNS

Hi Pau, On 12/11/2018 01:58 PM, Pau Espin Pedrol wrote: inet_ntoa was called twice in a row and as a result both primay and secondary DNS were pointing to same static buffer containing last value (secondary DNS). As a result, ofono always advertised the secondary DNS twice through DBus

Re: [PATCH 1/2] xmm7modem: implemnetation of coexistence functionality

Hi Antara, On 12/11/2018 05:53 AM, Antara Borwankar wrote: From: Antara Author info is still incomplete, we need something like: FirstName LastName Added coex implementation in xmm7modem plugin --- plugins/xmm7xxx.c | 922 ++ 1

Re: GPIO power management

Hi Martin, it might make sense to add GPIO helper in a common object, and use libgpiod in there? We will not be adding any further dependencies on GLib based libraries for oFono as GLib use is going to be deprecated over time (in favor of ell).  This is especially true for a small library

Re: [PATCH 1/2] xmm7xxx: implementation of coex functionality

Hi Antara, On 12/09/2018 07:26 AM, Antara Borwankar wrote: From: Antara Added implementation for coex functionality for xmm7xxx modem --- plugins/xmm7xxx.c | 936 +- 1 file changed, 935 insertions(+), 1 deletion(-) diff --git

Re: GPIO power management

Hi Martin, On 12/10/2018 08:14 AM, Martin Hundebøll wrote: Hi, I previously submitted pacthes[1] for the Quectel M95 modem, and now finally have the time needed to address the review comments. In the meantime, my hardware has changed (modem chip remains the same though), and so I would

Re: [PATCH 1/3] coex: Adding documetation for coex interface

On 12/03/2018 03:19 AM, Antara Borwankar wrote: From: Antara Added coex-api.txt which defines coex interface for intel modems --- doc/coex-api.txt | 126 +++ 1 file changed, 126 insertions(+) create mode 100644 doc/coex-api.txt I

Re: [PATCH 2/3] coex: coex agent implementation

Hi Antara, On 12/03/2018 03:20 AM, Antara Borwankar wrote: From: Antara Added implementation for coex agent --- plugins/xmm7xxx.c | 972 ++ 1 file changed, 972 insertions(+) A couple of other things: + +enum coex_agent_result { +

Re: [PATCH 2/3] coex: coex agent implementation

Hi Antara, On 12/03/2018 03:20 AM, Antara Borwankar wrote: From: Antara Please make sure your Author information is set properly. Added implementation for coex agent --- plugins/xmm7xxx.c | 972 ++ 1 file changed, 972 insertions(+)

Re: [PATCH] test: Fix number of arguments check in change-pin

Hi Nandini, On 11/27/2018 03:52 AM, Nandini Rebello wrote: Fix the number of arguments checked in second case of change-pin. --- test/change-pin | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Regards, -Denis ___ ofono

Re: [PATCH] xmm7xxx: Adding case for SIM PIN locked state

Hi Nandini, On 11/27/2018 03:38 AM, Nandini Rebello wrote: Handling the case when SIM PIN is enabled for xmm7xxx modem. --- plugins/xmm7xxx.c | 6 ++ 1 file changed, 6 insertions(+) Applied, thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH 2/3] coex: implementation of coex functionality for xmm7xxx modem

Hi Antara, On 11/26/2018 04:18 AM, Antara Borwankar wrote: From: Antara Added implementation for coex functionality for xmm7xxx modem --- plugins/xmm7xxx.c | 1097 + 1 file changed, 1097 insertions(+) mode change 100644 => 100755

Re: [PATCH 1/3] coex: Adding documetation for coex interface

Hi Antara, On 11/26/2018 04:17 AM, Antara Borwankar wrote: From: Antara Added coex-api.txt which defines coex interface for intel modems --- doc/coex-api.txt | 122 +++ 1 file changed, 122 insertions(+) create mode 100644

Re: [PATCH 1/3] sim800: add sim800 support

Hi Clement, On 11/13/2018 11:19 AM, Clement Viel wrote: --- plugins/sim900.c | 77 ++-- 1 file changed, 69 insertions(+), 8 deletions(-) Patch has been applied, thanks. I did fix up a bunch of style issues though. Regards, -Denis

Re: [PATCH 2/3] sim800: merge sim800 and sim900 documentation.

Hi Clement, On 11/12/2018 02:32 PM, Clement Viel wrote: --- doc/sim900-modem.txt | 12 doc/simcom-modem.txt | 22 ++ 2 files changed, 22 insertions(+), 12 deletions(-) delete mode 100644 doc/sim900-modem.txt create mode 100644 doc/simcom-modem.txt

Re: [PATCH 3/3] sim800: add udev detection.

Hi Clement, Just tell me whether I should add mention of sim800 in sim900.txt or rename sim900.txt in simcom.txt to mention the two drivers. Then I'll upload the patchset with doc in it. I don't feel strongly either way, but if I had to pick, I say lets rename sim900.txt into simcom.txt

Re: [PATCH 3/3] sim800: add udev detection.

Hi Clement, + { "sim800", setup_serial_modem }, > I think I must keep this line because the udev rule added by the user will specify that modem is "OFONO_DRIVER=sim800" so udevng.c must know what to do with that. This is kind of weird that we have a driver line for a modem driver that doesn't

Re: [PATCH 1/3] sim800: add support for sim800 modem.

Hi Clement, On 10/15/2018 12:27 PM, Clement Viel wrote: --- plugins/sim900.c | 89 ++-- 1 file changed, 80 insertions(+), 9 deletions(-) diff --git a/plugins/sim900.c b/plugins/sim900.c index a7728cd..9f3f334 100644 --- a/plugins/sim900.c

Re: [PATCH 2/3] sim800: add documentation and modify AUTHORS file

Hi Clement, On 10/15/2018 12:27 PM, Clement Viel wrote: --- AUTHORS | 1 + Please don't include AUTHORS changes. One of the maintainers will take care of it. doc/sim800-modem.txt | 11 +++ 2 files changed, 12 insertions(+) create mode 100644

Re: [RFC PATCH] new gemalto plugin

Hi Giacinto, Thank you for the explanation. Is the glib going to be removed completely then, or both will coexist? oFono is a large project, so eradicating use of glib cannot happen overnight. For the foreseeable future we will have both coexist. I will start 'encouraging' people to

Re: [RFC PATCH] new gemalto plugin

Hi Giacinto, MBIM is not even supported through the glib, but through the ell library that is itself quite fresh (and for which there is little advantage instead of the glib. Maybe because using glib you have to listen to someone else's opinion for pushing changes). Look, I understand you're

Re: [PATCH] udev: enhance udev detection for intel 7xxx modems

Hi Nandini, On 10/31/2018 05:43 AM, Nandini Rebello wrote: Handle newer 7xxx modem enumeration based on ProductId. Preserving the previous gen support too. --- plugins/udevng.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) I fixed up some style issues and

Re: [RFC PATCH] new gemalto plugin

Hi Marcel, I think that MBIM (and even QMI) have AT passthrough options. So by all means, the main transport suppose to be MBIM here. I always prefer if only one hardware port is opened and there is no need to open more. I've seen QMI over MBIM some vendor extended service UIDs. Not sure

Re: [RFC PATCH] new gemalto plugin

Hi Giacinto, So you might need to expand on this some more. What is QMI+AT or MBIM+AT actually doing? Is there a single AT port? Multiple? What is the AT port being used for, just vendor specific APIs or something more? MBIM and QMI are actually used only for the gprs-context atom. The

Re: [RFC PATCH] new gemalto plugin

Hi Giacinto, So just a cursory look through this, but overall my impression is that this code would be utterly unmaintainable. You need to split this up into something without a bazillion if conditions and #ifdefs in it. Notice how none of our existing driver code uses #ifdefs. In your

Re: [PATCH 0/6] Driver registration rework

Hi Jonas, Sort of.  They're still drivers and can be removed at will from the core.  The only thing that having them in tree helps with is access to some private headers.  And even these are not really that numerous. Essentially all the drivers send AT commands, QMI commands, etc. which

Re: [PATCH 0/6] Driver registration rework

Hi Jonas, On 10/26/2018 04:54 AM, Jonas Bonn wrote: Hi Denis, Since I don't know if you'd even be interested in a series like this, here's a draft that touches just a few places to give you an idea of where this would take us... take a look and let me know what you think. /Jonas **

Re: [PATCH 1/5] plugins/gemalto: vendor Gemalto on LTE atom

Hi Giacinto, On 10/26/2018 12:11 AM, Giacinto Cifelli wrote: --- plugins/gemalto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) All 5 applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [RFC PATCH] new gemalto plugin

Hi Giacinto, On 10/26/2018 01:10 AM, Giacinto Cifelli wrote: I would like to submit to your attention the new version of the Gemalto plugin. It is not ready, but would already benefit from some feedback. The purpose of this new plugin is to address most of the Gemalto modules (excluding perhaps

Re: [PATCH 9/9] modem: global data is pre-zeroed

Hi Jonas, On 10/26/2018 05:13 AM, Jonas Bonn wrote: Module-local and global data are BSS symbols and don't require zero-initialization. --- src/modem.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Applied, thanks. Regards, -Denis

Re: [PATCH 8/9] atmodem: prevent use of uninitialized value

Hi Jonas, On 10/26/2018 05:13 AM, Jonas Bonn wrote: From: Jonas Bonn Move initialization of 'dcs' ahead of 'content' fetch to prevent using uninitialized 'dcs' in ofono_ussd_notify. --- drivers/atmodem/ussd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 6/9] stkutil: remove test for impossible condition

Hi Jonas, On 10/26/2018 05:13 AM, Jonas Bonn wrote: From: Jonas Bonn 'string' is an array and therefore never NULL so this test always fails. --- src/stkutil.c | 3 --- 1 file changed, 3 deletions(-) Applied, thanks. Regards, -Denis ___

Re: [PATCH 5/9] simutil: remove check for impossible condition

Hi Jonas, On 10/26/2018 05:13 AM, Jonas Bonn wrote: From: Jonas Bonn Addresses following warning: src/simutil.c:1546:12: error: comparison of constant 8 with expression of type 'enum sim_cphs_service' is always false [-Werror,-Wtautological-constant-out-of-range-compare]

Re: [PATCH 1/9] test: use python3 for set-ddr

Hi Jonas, On 10/26/2018 05:13 AM, Jonas Bonn wrote: --- test/set-ddr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Patches 1-4 applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] doc/common-patterns.txt: initial version

Hi Giacinto, On 10/25/2018 12:22 PM, Giacinto Cifelli wrote: --- doc/common-patterns.txt | 165 1 file changed, 165 insertions(+) create mode 100644 doc/common-patterns.txt Applied with some minor edits. I also changed the use of tabs into

Re: [PATCH v2] atmodem/atutil.h: cb_data ref/unref possibility

Hi Giacinto, On 10/25/2018 12:46 AM, Giacinto Cifelli wrote: the cb_data can be used by creating the structure with cb_data_new, and then there are two possibilities: - use it in a single callback function, and destroy it with a call to g_free. Example: - calling function: struct

Re: [PATCH] atmodem/atutil.h: cb_data ref/unref possibility

Hi Jonas, On 10/25/2018 01:55 AM, Jonas Bonn wrote: Hi Giacinto, On 25/10/2018 07:03, Giacinto Cifelli wrote: +static inline struct cb_data *cb_data_ref(struct cb_data *cbd) +{ +    if (cbd == NULL) +    return NULL; + +    g_atomic_int_inc(>ref_count); + Let me just vent my

Re: [PATCH 1/1] gprs: detach from PS domain only if needed

Hi Giacinto, On 10/24/2018 09:58 PM, Giacinto Cifelli wrote: Hi Denis, So the ideal situation would be to turn all this off for LTE based dongles, have the ability to tell the modem not to auto-attach on 3G/2G, and maybe even attach only controlling 3G/2G PS domain only, not LTE. this is

Re: [PATCH] atmodem/lte: proto and authentication handling

Hi Giacinto, There is very strict separation between driver managed memory / structures and ones owned by the core. Thank you for the clarification, now I understand. And yes, it is indeed the 3rd time you point it out. I hope it is the last one, but it is easy to fall for this, there should

Re: [PATCH] atmodem/lte: proto and authentication handling

Hi Giacinto, + const struct ofono_lte_default_attach_info *info; And honestly, I'd just put this into lte_driver_data as well. Nope you can't do this. This is the third time I nak-ed this part I can't do what? I don't see what you are referring to. There are two comments here.

Re: [PATCH 1/1] gprs: detach from PS domain only if needed

Hi Christophe, On 10/24/2018 10:09 AM, Christophe Ronco wrote: With some huawei USB keys (E3372, MS2372h), when switching from WCDMA to LTE network, a network attachment loss is reported during a short time. Forcing data detach in this case is a bad idea. Consequences can be a loop like that:

Re: [PATCH] atmodem/lte: proto and authentication handling

Hi Giacinto, On 10/22/2018 10:00 PM, Giacinto Cifelli wrote: The ofono_lte_default_attach_info now handles also the protocol and the authentication method, username and password. Co-authored-by: Martin Baschin --- drivers/atmodem/lte.c | 118 -- 1

Re: [PATCH] src/modem.c/call_watches null pointer check

Hi Giacinto, On 10/23/2018 12:30 PM, Giacinto Cifelli wrote: Hi Denis, I didn't know this was a surprise interrogation! That's how we roll around here. Keeps you on your toes. On Tue, Oct 23, 2018 at 6:50 PM Denis Kenzior wrote: Hi Giacinto, 0 0x563b1842b735 in call_watches

Re: [PATCH] src/modem.c/call_watches null pointer check

Hi Giacinto, 0 0x563b1842b735 in call_watches (atom=atom@entry=0x563b1a3f07d0, cond=cond@entry=OFONO_ATOM_WATCH_CONDITION_UNREGISTERED) at src/modem.c:265 1 0x563b1842c32e in __ofono_atom_unregister (atom=atom@entry=0x563b1a3f07d0) at src/modem.c:299 2 0x563b1842c3ff

Re: [PATCH] src/modem: connection timeout to 60 seconds

Hi Giacinto, On 10/23/2018 03:40 AM, Giacinto Cifelli wrote: Hi, On Tue, Oct 23, 2018 at 10:34 AM Jonas Bonn wrote: Hi, Do the USB interfaces show up long before the modem is ready to accept AT commands? Or do the AT commands take a long time to complete? The USB shows up long before

Re: rename of vendor-specific interface?

Hi Giacinto, On 10/23/2018 03:19 AM, Giacinto Cifelli wrote: Dear all, is it possible to rename the .cinterion.HardwareMonitor interface to .gemalto.HardwareMonitor ? We have no formal policy about the stability of vendor specific APIs. So there's nothing preventing you from changing this.

Re: [PATCH] atmodem/sms: added Gemalto vendor for CNMI command

Hi Giacinto, On 10/23/2018 03:21 AM, Giacinto Cifelli wrote: --- drivers/atmodem/sms.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) Applied, thanks. Regards, -denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] src/modem.c/call_watches null pointer check

Hi Giacinto, you mean something like the following or more? Yes, but something that is actually useful and not a bunch of memory locations. e.g. git show a99c0be535410a92773ffdfbebb766bec66b66fe Regards, -Denis ___ ofono mailing list

Re: [PATCH] src/modem.c/call_watches null pointer check

Hi Giacinto, On 10/23/2018 02:50 AM, Giacinto Cifelli wrote: check the pointer modem->atom_watches, that can be null when the function is called during the disable/remove of the device, for example when it is unplugged or switched off. If this caused a crash, a full stack trace would be

Re: [PATCH 2/2] atmodem/atutil: at_util_get_cgdcont_command

Hi Giacinto, On 10/22/2018 01:56 PM, Giacinto Cifelli wrote: The function at_util_get_cgdcont_command computes the AT+CGDCONT string, as per 3GPP 27.007. It uses a second function, at_util_gprs_proto_to_pdp_type, that returns the pdp_type string for the command --- drivers/atmodem/atutil.c |

Re: [PATCH 1/2] atmodem/atutil: at_util_gprs_proto_to_pdp_type

Hi Giacinto, On 10/22/2018 01:56 PM, Giacinto Cifelli wrote: This function converts the ofono enum ofono_gprs_auth_method into the value of the 3GPP 27.007 to pass to the AT command --- drivers/atmodem/atutil.c | 16 drivers/atmodem/atutil.h | 3 +++ 2 files changed, 19

Re: airplane mode

Hi Giacinto, On 10/22/2018 12:17 PM, Giacinto Cifelli wrote: Hi Denis, On Mon, Oct 22, 2018 at 7:02 PM Denis Kenzior wrote: Hi Giacinto, And it is fully possible to make emergency calls. Just set Online=True first. ahh, like that yes but then, wouldn't be better to create

Re: airplane mode

Hi Giacinto, And it is fully possible to make emergency calls. Just set Online=True first. ahh, like that yes but then, wouldn't be better to create the voicecall atom where it belongs, in post_online ? Or this stage is never reached without a SIM? If not, what handle we have that is

Re: [PATCH v8 4/5] atmodem/atutil: shared functions for cgdcont

Hi Giacinto, On 10/19/2018 06:31 AM, Giacinto Cifelli wrote: included two new functions: at_auth_type_from_method: converts the ofono enum ofono_gprs_auth_method into the value of the 3GPP 27.007 to pass to the AT command at_get_cgdcont_command: computes the AT+CGDCONT string,

Re: [PATCH v8 0/5] lte atom auth and IP protocol

Hi Giacinto, On 10/19/2018 06:31 AM, Giacinto Cifelli wrote: I would like to submit this patch for the lte atom This patch adds in core atom: - the protocol for the default LTE APN, ip, ipv6 and both - the authentication handling, with 3 properties: method, username, password then

Re: airplane mode

Hi Giacinto, On 10/22/2018 12:19 AM, Giacinto Cifelli wrote: Dear all, I have a series of problems with the ofono structure. When setting Powered=TRUE, it sets the module in airplane mode (AT+CFUN=4). This prevents the use of calls, even emergency, so there would be no point in creating the

Re: [PATCH] gatchat: export gatchat at_chat_finish_command

Hi Giacinto, some chipsets have a single interpreter, even if accessible from multiple ports, but they allow aborting. Gemalto modules abort long-running commands simply sending any character on the line while waiting for a response, the module returns ERROR, and the flow can be resumed

Re: commit d37c22be20c83cf370638a9bad243bc5219c5509

Hi Giacinto, On 10/20/2018 05:13 AM, Giacinto Cifelli wrote: Hi Denis, On Mon, Sep 24, 2018 at 11:25 PM Denis Kenzior wrote: Hi Giacinto, Besides, several modules use the option linux driver, which blocks in case the port doesn't answer. This single call: g_at_chat_unref(port); blocks

Re: [PATCH] gatchat: export gatchat at_chat_finish_command

Hi Giacinto, But it is not a reason to close the door entirely: there are strict requirements for starting emergency calls, especially ERA/GLONASS and panEuropean eCall. I'm not though. I'm just saying that exposing at_finish_command is not actually doing what you want in this particular

Re: [PATCH] gatchat: export gatchat at_chat_finish_command

Hi Giacinto, On 10/20/2018 11:28 AM, Giacinto Cifelli wrote: Hi Denis, On Sat, Oct 20, 2018 at 6:23 PM Denis Kenzior wrote: Hi Giacinto, I need to probe with 'AT' once per second the modem and the application port, one after the other. It needs to be repeated a few times, because

Re: [PATCH v7 6/7] gemalto/lte: Gemalto vendor lte atom

Hi Giacinto, On 10/20/2018 11:24 AM, Giacinto Cifelli wrote: Hi Denis, I still don't get this explanation. You have a gemalto specific function, which is being passed the CID directly by the caller. Why is there weird logic here to mess with the CID, just have the caller pass in the proper

Re: [PATCH v7 6/7] gemalto/lte: Gemalto vendor lte atom

Hi Giacinto, +char *gemalto_get_cgdcont_command(struct ofono_modem *modem, guint cid, + enum ofono_gprs_proto proto, const char *apn) +{ + /* + * For future extension: verify if the module supports automatic + * context provisioning and if so, also if

Re: [PATCH v7 6/7] gemalto/lte: Gemalto vendor lte atom

Hi Jonas, Using an enumeration to name flags feels awkward.  I would #define these: #define AUTH_F_USE_SGATH (1<<0) #define AUTH_F_SWAP_CREDENTIALS (1<<1) #define AUTH_F_ALWAYS_ALL_PARAMS (1<<2) Actually we prefer enums for enumerations with multiple related values or ones that can be

Re: [PATCH] gatchat: export gatchat at_chat_finish_command

Hi Giacinto, On 10/20/2018 05:26 AM, Giacinto Cifelli wrote: added the function g_at_chat_finish_command, in order to be able to interrupt a pending command. The function is useful in special cases, for example to implement a custom g_at_chat_set_wakeup_command. This command will never return

Re: Stuck in modem driver enable

Hi Mattias, On 10/18/2018 05:52 AM, Mattias Månsson wrote: We have implemented a driver for the Gemalto modem we are using and today I noticed that it got stuck in initialization (during enable). The problem is that the AT+CFUN=4 (which is the last step of our init) now returned a CME error.

Re: [PATCH v2 1/2] Gemalto: voicecall atom

On 10/17/2018 03:24 PM, Giacinto Cifelli wrote: Added voicecall atom specific for Gemalto modems. This atom uses the URC ^SLCC to monitor the call status, as well as incoming calls. Note the use in the atom of the variable GemaltoVtsQuotes: this is needed to support future modules, as of today

Re: [PATCH v4 1/2] Gemalto: voicecall atom

Hi Jonas, On 10/17/2018 11:30 AM, Jonas Bonn wrote: On 17/10/18 17:18, Denis Kenzior wrote: Hi Jonas, + +extern void gemalto_voicecall_init(); +extern void gemalto_voicecall_exit(); + Why are these "extern"? Okay, I haven't had my coffee yet, but what is the actual prob

Re: [PATCH v4 1/2] Gemalto: voicecall atom

Hi Jonas, + +extern void gemalto_voicecall_init(); +extern void gemalto_voicecall_exit(); + Why are these "extern"? Okay, I haven't had my coffee yet, but what is the actual problem? All functions defined in the header are extern anyway, whether they're labeled extern or not. So,

Re: [PATCH 1/1] Remove superfluous definitions of _GNU_SOURCE

Hi Jonas, On 10/17/2018 05:23 AM, Jonas Bonn wrote: There are a large number of files in the tree that define _GNU_SOURCE despite not actually using features hidden behind this flag. This patch removes all these definitions in one fell swoop... --- I realize that it's not quite kosher in

Re: [PATCH 1/1] drivers: constify vtables

Hi Jonas, On 10/17/2018 08:36 AM, Jonas Bonn wrote: The driver vtables are read-only structures. This patch declares them as 'const' allowing the compiler to (optionally) put them in the RELRO section. RELRO pages may be marked as read-only by the linker after the relocations have been done

<    1   2   3   4   5   6   7   8   9   10   >