all the zoom levels shown in the toolbar and custom zoom level (
example 123.23% ).
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
ui/presentationwidget.cpp 4aaec2a
Diff: https://git.reviewboard.kde.org/r/115532/diff/
Testing
---
It works fine on my system accept for the first time in case of fade out
transition.
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
ui/presentationwidget.h a99b8ce
ui/presentationwidget.cpp 4aaec2a
Diff: https://git.reviewboard.kde.org/r/115532/diff/
Testing (updated)
---
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org
://git.reviewboard.kde.org/r/115532/diff/
Testing
---
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
ny other better way
of doing it??
- Saheb
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/#review62357
---
On July 16, 20
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115283/#review64131
-------
On June 9, 2014, 3:50 p.m., Saheb Preet Singh wrote:
>
> -
okular.
Diffs (updated)
-
conf/dlgpresentationbase.ui 31db693
conf/okular.kcfg f980989
ui/presentationwidget.h a99b8ce
ui/presentationwidget.cpp 4aaec2a
Diff: https://git.reviewboard.kde.org/r/115532/diff/
Testing
---
Thanks,
Saheb Preet Singh
ehaviour?
>
> Albert Astals Cid wrote:
> Saheb?
>
> Saheb Preet Singh wrote:
> Sorry for late reply. The previous mail got bounced somewhere.
>
> Yes I can reproduce the same thing. I tried to fix it initially but
> couldn't get it. I will try to fix it agai
ui/presentationwidget.cpp 4aaec2a
Diff: https://git.reviewboard.kde.org/r/115532/diff/
Testing
---
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
ui/presentationwidget.cpp d994647
Diff: https://git.reviewboard.kde.org/r/115532/diff/
Testing
---
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
> various toolbars are shown and hidden.
==> for all the zoom levels shown in the toolbar and custom zoom level (
example 123.23% ).
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
ui/presentationwidget.cpp d676069
Diff: https://git.reviewboard.kde.org/r/115532/diff/
Testing
---
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115283/#review72005
---
On Nov. 25, 2014, 12:47 p.m., Saheb Preet Singh wrote:
>
> -
; > the menus at all and give it a shortcut so people can use it (Since i think
> > this is a pretty "advanced/notcommon" option) B) Put it at the end of the
> > View menu in it's own "group" (i.e. with a separator). What do you think?
>
>
; > the menus at all and give it a shortcut so people can use it (Since i think
> > this is a pretty "advanced/notcommon" option) B) Put it at the end of the
> > View menu in it's own "group" (i.e. with a separator). What do you think?
>
>
; > the menus at all and give it a shortcut so people can use it (Since i think
> > this is a pretty "advanced/notcommon" option) B) Put it at the end of the
> > View menu in it's own "group" (i.e. with a separator). What do you think?
>
>
conf/okular.kcfg f980989
ui/presentationwidget.h a99b8ce
ui/presentationwidget.cpp d676069
Diff: https://git.reviewboard.kde.org/r/115532/diff/
Testing
---
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
; > the menus at all and give it a shortcut so people can use it (Since i think
> > this is a pretty "advanced/notcommon" option) B) Put it at the end of the
> > View menu in it's own "group" (i.e. with a separator). What do you think?
>
>
; > the menus at all and give it a shortcut so people can use it (Since i think
> > this is a pretty "advanced/notcommon" option) B) Put it at the end of the
> > View menu in it's own "group" (i.e. with a separator). What do you think?
>
>
.
==> various toolbars are shown and hidden.
==> for all the zoom levels shown in the toolbar and custom zoom level (
example 123.23% ).
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
marked as submitted.
Review request for Okular and Albert Astals Cid.
Changes
---
Submitted with commit 1eafe4feb151c713e8f7747164348c25886480bf by Albert Astals
Cid on behalf of Saheb Preet Singh to branch master.
Bugs: 326844
http://bugs.kde.org/show_bug.cgi?id=326844
Repository
ui/presentationwidget.cpp d676069
Diff: https://git.reviewboard.kde.org/r/115532/diff/
Testing
---
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
https://bugs.kde.org/show_bug.cgi?id=317073
--- Comment #14 from Saheb Preet Singh ---
(In reply to sahil from comment #13)
Hi,
> I reviewed your review-board patch and it was really cool. Can you please
> tell if there is something left in this bug so that i can also contribute?
The pa
environment is ready and I have been working on the okular
code.
I would like to know how should I proceed further and what should be my
first steps in GSOC program?
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https
On Mon, May 4, 2015 at 3:52 AM, Albert Astals Cid wrote:
> El Dijous, 30 d'abril de 2015, a les 15:11:45, saheb preet singh va
> escriure:
> > Hello Everyone,
>
> Hi!
>
> > Thank you for accepting my proposal in GSOC 2015.
>
> Congrats, now let's mak
nclude my proposal there. I will
post the link of the blog in this thread.
Thanks,
Saheb
> Best Wishes
> Sahil
>
> On Thu, Apr 30, 2015 at 3:11 PM, saheb preet singh
> wrote:
>
>> Hello Everyone,
>>
>> Thank you for accepting my proposal in GSOC 2015.
>&g
Hello Everyone,
I have just started writing my blog for my working experience with kde this
summer.
You can find the blog at http://sahebpreet-kde.blogspot.in/
Thanks,
Saheb Preet Singh
On Tue, May 5, 2015 at 12:04 AM, Albert Astals Cid wrote:
> El Dilluns, 4 de maig de 2015, a les 16:42
Preet Singh
On Fri, May 8, 2015 at 11:02 PM, Albert Astals Cid wrote:
> El Divendres, 8 de maig de 2015, a les 13:46:52, saheb preet singh va
> escriure:
> > Hello Everyone,
> >
> > I have just started writing my blog for my working experience with kde
> this
> >
Hi,
Today, I added a search bar on the layers list. The searchbar is not
searching appropriate results. I was stuck at this.
I hope I will figure it out by tomorrow.
Best,
Saheb Preet Singh
On 5/10/15, Albert Astals Cid wrote:
> El Dissabte, 9 de maig de 2015, a les 21:48:32, saheb pr
marked as submitted.
Review request for Okular.
Changes
---
Submitted with commit 48905cf16b3186ce813d766a77905c8260493480 by Albert Astals
Cid on behalf of Saheb Preet Singh to branch master.
Bugs: 317073
http://bugs.kde.org/show_bug.cgi?id=317073
Repository: okular
Description
https://bugs.kde.org/show_bug.cgi?id=350366
Bug ID: 350366
Summary: Tree view search bar in left side bar is not searching
root items of the tree view.
Product: okular
Version: unspecified
Platform: Kubuntu Packages
://git.reviewboard.kde.org/r/125623/diff/
Testing
---
Manually tested for some files.
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
t.reviewboard.kde.org/r/125623/#review86812
-------
On Oct. 13, 2015, 9 p.m., Saheb Preet Singh wrote:
>
> ---
> This is an automatically generated e-mail. To repl
nfirm it works without the patch?
yes, it works fine.
- Saheb
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125623/#review86812
-------
, bookmarks section.
Diffs
-
ui/ktreeviewsearchline.cpp 4a987ec
Diff: https://git.reviewboard.kde.org/r/125623/diff/
Testing
---
Manually tested for some files.
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
age on the button, instead of text the content
is hidden behind the button.
Can we have transparent buttons as shown in adobe reader, or some
translucent effect as in pdf reader embedded with chrome.
I tried making buttons transparent and it works fine.
Best,
Saheb Preet
On 19 October 2015 at 23:48, Albert Astals Cid wrote:
> El Monday 19 October 2015, a les 17:03:38, saheb preet singh va escriure:
> > Hi,
>
> Hi
>
>
Hi,
> Some of the files in okular with form buttons do not open correctly.
> >
> > For example, in this
>
increasing the border width to high values, it covers the text
inside inline note. It would look nice if text is adjusted according to borders.
- Saheb Preet Singh
On Oct. 29, 2015, 9:09 p.m., Sumit Sahrawat wrote:
>
> ---
> T
https://bugs.kde.org/show_bug.cgi?id=328576
--- Comment #2 from Saheb Preet Singh ---
Created attachment 84341
--> https://bugs.kde.org/attachment.cgi?id=84341&action=edit
proposed patch
The attached patch applies to the file ui/searchlineedit.cpp and
ui/searchlineedit.h
Added a ke
https://bugs.kde.org/show_bug.cgi?id=327376
Saheb Preet Singh changed:
What|Removed |Added
CC||saheb.pr...@gmail.com
--- Comment #1 from
/searchlineedit.cpp 31be8fb
Diff: https://git.reviewboard.kde.org/r/114754/diff/
Testing
---
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
.org/r/114754/#review46501
---
On Dec. 31, 2013, 2:19 p.m., Saheb Preet Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
https://bugs.kde.org/show_bug.cgi?id=326844
Saheb Preet Singh changed:
What|Removed |Added
CC||saheb.pr...@gmail.com
--- Comment #5 from
shift + enter
Added a key event listener to the SearchLineEdit class for shift+return.
Diffs (updated)
-
ui/searchlineedit.cpp 31be8fb
Diff: https://git.reviewboard.kde.org/r/114754/diff/
Testing
---
Thanks,
Saheb Preet Singh
> On Dec. 31, 2013, 2:53 p.m., Albert Astals Cid wrote:
> > any reason you've implemented the custom key event handler instead of
> > implementing it in slotReturnPressed (as it seems to me that shit+return
> > also invokes it?)
>
> Saheb Preet Singh wrote:
&g
https://bugs.kde.org/show_bug.cgi?id=326844
--- Comment #7 from Saheb Preet Singh ---
(In reply to comment #6)
> (In reply to comment #5)
> > i need to know which files or classes are related to adjusting the size of
> > the main window or more precisely how to resize the win
nter
Added a key event listener to the SearchLineEdit class for shift+return.
Diffs (updated)
-
ui/searchlineedit.cpp 31be8fb
Diff: https://git.reviewboard.kde.org/r/114754/diff/
Testing
---
Thanks,
Saheb Preet Singh
___
Okular-devel mai
t.reviewboard.kde.org/r/114754/#review47191
---
On Jan. 12, 2014, 12:30 p.m., Saheb Preet Singh wrote:
>
> ---
> This is an automatically generated e-mail. To repl
the SearchLineEdit class for shift+return.
Diffs
-
ui/searchlineedit.cpp 31be8fb
Diff: https://git.reviewboard.kde.org/r/114754/diff/
Testing
---
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https
d.kde.org/r/114754/#review47260
---
On Jan. 12, 2014, 5:29 p.m., Saheb Preet Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&g
https://bugs.kde.org/show_bug.cgi?id=326844
--- Comment #9 from Saheb Preet Singh ---
hi,
I am able to resize the window now. I did some further work and stuck in a
problem.
First of all i created a new action in part.cpp and part.rc for fit window
option in view menu and connected it to a
https://bugs.kde.org/show_bug.cgi?id=328125
Saheb Preet Singh changed:
What|Removed |Added
CC||saheb.pr...@gmail.com
--- Comment #3 from
https://bugs.kde.org/show_bug.cgi?id=328125
--- Comment #4 from Saheb Preet Singh ---
(In reply to comment #3)
> hi,
>
> i just tried to implement the button and its working now. Here is a short
> explanation of what i did :-
>
> Added a new action in part.cpp for play pause
https://bugs.kde.org/show_bug.cgi?id=326844
--- Comment #11 from Saheb Preet Singh ---
(In reply to comment #10)
> The shell knows the current size of the part and also knows the total size
> of the window, so knowing the size the part wants to have should be able to
> determine what
e.org/r/115072/diff/
Testing
---
tested on local machine, working as desired.
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
. The icon is changed to the play button.
Diffs (updated)
-
part.cpp 88e2c41
ui/presentationwidget.h c63e119
ui/presentationwidget.cpp 1b63e2f
Diff: https://git.reviewboard.kde.org/r/115072/diff/
Testing
---
tested on local machine, working as desired.
Thanks,
Saheb Preet
custom zoom level (
example 123.23% ).
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
ok i uploaded the diff to review board :-
https://git.reviewboard.kde.org/r/115283/
On Fri, Jan 24, 2014 at 5:10 AM, Albert Astals Cid wrote:
> El Dimecres, 22 de gener de 2014, a les 19:04:40, saheb preet singh va
> escriure:
> > hi,
>
> Hi
>
> > I was w
https://bugs.kde.org/show_bug.cgi?id=317073
Saheb Preet Singh changed:
What|Removed |Added
CC||saheb.pr...@gmail.com
--- Comment #8 from
us toolbars are shown and hidden.
==> for all the zoom levels shown in the toolbar and custom zoom level (
example 123.23% ).
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
or the
window is maximized.
- Saheb
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115283/#review48238
---
On Jan. 27, 2014, 8
or the
window is maximized.
- Saheb
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115283/#review48238
---
On Jan. 27, 2014, 8
the zoom levels shown in the toolbar and custom zoom level (
example 123.23% ).
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
/diff/
Testing
---
tested on local machine, working as desired.
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
sorry i didn't noticed that
- Saheb
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115072/#review48302
---
On Jan. 27, 2014, 9:41 a.m., Saheb Preet Singh wrote:
>
> -
en
==> window is maximized and restored.
==> thumbnails, table of content are opened and closed.
==> various toolbars are shown and hidden.
==> for all the zoom levels shown in the toolbar and custom zoom level (
example 123.23% ).
Thanks,
Saheb Preet Singh
__
local machine, working as desired.
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
https://bugs.kde.org/show_bug.cgi?id=317073
--- Comment #12 from Saheb Preet Singh ---
(In reply to comment #11)
> Saheb can you confirm you're still working on trying to implement this?
Yes I am working on this bug but gagan you are also invited to solve the bug
--
You are receiv
works fine on my system accept for the first time in case of fade out
transition.
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
sired.
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
.
==> various toolbars are shown and hidden.
==> for all the zoom levels shown in the toolbar and custom zoom level (
example 123.23% ).
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
ed e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/#review49311
---
On Feb. 7, 2014, 8:55 a.m., Saheb Preet Singh wrote:
>
> ---
> This is an automatically
ed on local machine, working as desired.
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
https://git.reviewboard.kde.org/r/115072/diff/
Testing
---
tested on local machine, working as desired.
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
ails, table of content are opened and closed.
==> various toolbars are shown and hidden.
==> for all the zoom levels shown in the toolbar and custom zoom level (
example 123.23% ).
Thanks,
Saheb Preet Singh
___
Okular-devel mailing lis
://git.reviewboard.kde.org/r/115532/diff/
Testing
---
It works fine on my system accept for the first time in case of fade out
transition.
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular
/git.reviewboard.kde.org/r/115283/#review52845
---
On Feb. 25, 2014, 7:02 a.m., Saheb Preet Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
all the zoom levels shown in the toolbar and custom zoom level (
example 123.23% ).
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
://git.reviewboard.kde.org/r/115532/diff/
Testing
---
It works fine on my system accept for the first time in case of fade out
transition.
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular
79 matches
Mail list logo