Cannot select a different icon set

2012-04-09 Thread Andrea Pescetti
While trying to verify if an old problem (i.e., Crystal still listed in the icon sets, see http://s.apache.org/eI ) was still around - and honestly I expected it was, because my investigation at the time seemed to show that localizing names in icon sets depended on the order, i.e., you didn't t

Re: Cannot select a different icon set

2012-04-09 Thread RGB ES
El día 10 de abril de 2012 00:59, Andrea Pescetti escribió: > While trying to verify if an old problem (i.e., Crystal still listed in the > icon sets, see http://s.apache.org/eI ) was still around - and honestly I > expected it was, because my investigation at the time seemed to show that > locali

Re: Cannot select a different icon set

2012-04-09 Thread Rob Weir
On Mon, Apr 9, 2012 at 6:59 PM, Andrea Pescetti wrote: > While trying to verify if an old problem (i.e., Crystal still listed in the > icon sets, see http://s.apache.org/eI ) was still around - and honestly I > expected it was, because my investigation at the time seemed to show that > localizing

Re: Cannot select a different icon set

2012-04-09 Thread Andrea Pescetti
RGB ES wrote: El día 10 de abril de 2012 00:59, Andrea Pescetti escribió: On my latest dev build (Ariel's r1310206, 64-bit RPM, Italian) I cannot change the icon set used. Whatever I choose in Tools - Options - View, the default icon style is set to "Automatico ()" and while 4 options to change

Re: Cannot select a different icon set

2012-04-10 Thread Andrea Pescetti
Rob Weir wrote: You should enter a defect in BZ for this. It would be better to do that first, and then post a note to the list linking to the issue. It's at https://issues.apache.org/ooo/show_bug.cgi?id=119208 as I posted; but since I open issues as CONFIRMED, I typically ask for a quick co

Re: Cannot select a different icon set

2012-04-15 Thread Andrea Pescetti
On 10/04/2012 Andrea Pescetti wrote: reported as https://issues.apache.org/ooo/show_bug.cgi?id=119208 I assumed that this bug (you cannot change the icon set in Tools - Options - View) would be fixed before release even though I hadn't set it as a Release Blocker. And I had also assumed that,

Re: Cannot select a different icon set

2012-04-15 Thread Rob Weir
On Sun, Apr 15, 2012 at 11:49 AM, Andrea Pescetti wrote: > On 10/04/2012 Andrea Pescetti wrote: >> >> reported as >> https://issues.apache.org/ooo/show_bug.cgi?id=119208 > > > I assumed that this bug (you cannot change the icon set in Tools - Options - > View) would be fixed before release even th

Re: Cannot select a different icon set

2012-04-15 Thread Andrea Pescetti
Il 15/04/2012 18:16, Rob Weir wrote: On Sun, Apr 15, 2012 at 11:49 AM, Andrea Pescetti wrote: Follow the process. If you want to propose it as a release blocker then edit the BZ issue and set the 3.4 release blocker flag to "?". But I had followed the process, right? Just before posting here

Re: Cannot select a different icon set

2012-04-15 Thread Rob Weir
On Sun, Apr 15, 2012 at 12:37 PM, Andrea Pescetti wrote: > Il 15/04/2012 18:16, Rob Weir wrote: >> >> On Sun, Apr 15, 2012 at 11:49 AM, Andrea Pescetti  wrote: >> >> Follow the process.  If you want to >> propose it as a release blocker then edit the BZ issue and set the 3.4 >> release blocker fla

Re: Cannot select a different icon set

2012-04-15 Thread Ariel Constenla-Haile
Hi Andrea, On Tue, Apr 10, 2012 at 12:59:29AM +0200, Andrea Pescetti wrote: > While trying to verify if an old problem (i.e., Crystal still listed > in the icon sets, see http://s.apache.org/eI ) was still around - > and honestly I expected it was, because my investigation at the time > seemed to

Re: Cannot select a different icon set

2012-04-15 Thread Pedro Giffuni
On 04/15/12 13:33, Ariel Constenla-Haile wrote: Hi Andrea, On Tue, Apr 10, 2012 at 12:59:29AM +0200, Andrea Pescetti wrote: While trying to verify if an old problem (i.e., Crystal still listed in the icon sets, see http://s.apache.org/eI ) was still around - and honestly I expected it was, beca

Re: Cannot select a different icon set

2012-04-15 Thread Ariel Constenla-Haile
On Sun, Apr 15, 2012 at 04:56:46PM -0500, Pedro Giffuni wrote: > On 04/15/12 13:33, Ariel Constenla-Haile wrote: > >Hi Andrea, > > > >On Tue, Apr 10, 2012 at 12:59:29AM +0200, Andrea Pescetti wrote: > >>While trying to verify if an old problem (i.e., Crystal still listed > >>in the icon sets, see h

Re: Cannot select a different icon set

2012-04-15 Thread Pedro Giffuni
On 04/15/12 21:06, Ariel Constenla-Haile wrote: ... I committed the fix (I had a blackout between the commit and the moment I did the followup on BZ). Hope you don't mind As far as you built and tested the fix before committing it, I don't mind :) Actually .. the fix that I committed (removin

Re: Cannot select a different icon set

2012-04-15 Thread Ariel Constenla-Haile
Hi Pedro, On Sun, Apr 15, 2012 at 09:47:30PM -0500, Pedro Giffuni wrote: > On 04/15/12 21:06, Ariel Constenla-Haile wrote: > >>... > >>I committed the fix (I had a blackout between the commit and the moment > >>I did the followup on BZ). Hope you don't mind > >As far as you built and tested the fi

Re: Cannot select a different icon set

2012-04-15 Thread Pedro Giffuni
On 04/15/12 23:08, Ariel Constenla-Haile wrote: Hi Pedro, On Sun, Apr 15, 2012 at 09:47:30PM -0500, Pedro Giffuni wrote: On 04/15/12 21:06, Ariel Constenla-Haile wrote: ... I committed the fix (I had a blackout between the commit and the moment I did the followup on BZ). Hope you don't mind A

Re: Cannot select a different icon set

2012-04-16 Thread Ariel Constenla-Haile
Hi Pedro, On Mon, Apr 16, 2012 at 12:18:13AM -0500, Pedro Giffuni wrote: > >IMHO we shouldn't remove anything, on the contrary we should revert all > >changes: the list of icon styles is filled in the constructor of > >OfaViewTabPage. Ultimately, the existence of an icon set is checked on > >bool

Re: Cannot select a different icon set

2012-04-16 Thread Jürgen Schmidt
On 4/15/12 6:37 PM, Andrea Pescetti wrote: Il 15/04/2012 18:16, Rob Weir wrote: On Sun, Apr 15, 2012 at 11:49 AM, Andrea Pescetti wrote: Follow the process. If you want to propose it as a release blocker then edit the BZ issue and set the 3.4 release blocker flag to "?". But I had followed the

Re: Cannot select a different icon set

2012-04-16 Thread Jürgen Schmidt
On 4/16/12 12:06 PM, Ariel Constenla-Haile wrote: Hi Pedro, On Mon, Apr 16, 2012 at 12:18:13AM -0500, Pedro Giffuni wrote: IMHO we shouldn't remove anything, on the contrary we should revert all changes: the list of icon styles is filled in the constructor of OfaViewTabPage. Ultimately, the exi

Re: Cannot select a different icon set

2012-04-16 Thread Pedro Giffuni
On 04/16/12 05:06, Ariel Constenla-Haile wrote: Hi Pedro, On Mon, Apr 16, 2012 at 12:18:13AM -0500, Pedro Giffuni wrote: IMHO we shouldn't remove anything, on the contrary we should revert all changes: the list of icon styles is filled in the constructor of OfaViewTabPage. Ultimately, the exist