On 12/20/19, 7:04 PM, Scott Palmer wrote:
I'm not sure if I'me supposed to try to integrate now that I've made that 10 ->
0 change, or if the new change resets the need for review...
It shows ready, which surprises me.
Still learning skara .. I'd expect any change to reset as how can it
On Sat, 21 Dec 2019 02:50:54 GMT, Scott Palmer wrote:
>> The fix looks good now. There is one problem in the test (in
>> `StubTextLayout`) that needs to be fixed.
>
> Interesting. I was only running the tests in graphics (gradle
> :graphics:test) as when I run all the tests I always get this
> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to
> both. TextFlow's tab size overrides that of contained Text nodes.
The pull request has been updated with 1 additional commit.
-
Added commits:
- 78ddf12e: 8130738: Fixed test issue with
On Fri, 20 Dec 2019 23:43:53 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> The fix looks good now. There is one problem in the test (in
> `StubTextLayout`) that needs to be fixed.
Interesting. I was only running the tests in graphics (gradle
On Fri, 20 Dec 2019 23:44:07 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
The fix looks good now.
On Wed, 18 Dec 2019 01:04:42 GMT, Alexander Matveev
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8232589
>
> - Removed CoreAudio Utility classes.
> - Spectrum which was depended on CoreAudio Utility classes for doing
> computations will now run GStreamer spectrum element to do spectrum.
On Fri, 20 Dec 2019 22:18:29 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
-
Marked
On Wed, 20 Nov 2019 00:32:36 GMT, Nir Lisker wrote:
>> Kevin, Ambarish,
>>
>> You can start the review, especially the API. I will hunt that specific
>> values bug this week.
>>
>> I'll need to know what kind of tests are needed in terms of functionality
>> and performance.
>
> The bug I
Changeset: 69e4ef35
Author:Frederic Thevenet
Committer: Kevin Rushforth
Date: 2019-12-20 20:19:25 +
URL: https://git.openjdk.java.net/jfx/commit/69e4ef35
8235627: Blank stages when running JavaFX app in a macOS virtual machine
Reviewed-by: arapte, kcr
!
On Fri, 20 Dec 2019 19:20:56 GMT, Frederic Thevenet
wrote:
>> This is a PR for
>> [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627).
>>
>> When running a JavaFX application in macOS guest VM, the main stage is
>> completely blank, with the following errors: CGLChoosePixelFormat
Changeset: 5e0fb91c
Author:Kevin Rushforth
Date: 2019-12-20 19:08:27 +
URL: https://git.openjdk.java.net/jfx/commit/5e0fb91c
8235364: Update copyright header for files modified in 2019
Reviewed-by: arapte
!
On Fri, 20 Dec 2019 17:37:36 GMT, Kevin Rushforth wrote:
>> This PR aims to address the following issue: JDK-8088198 Exception thrown
>> from snapshot if dimensions are larger than max texture size
>>
>> In order to do that, it simply captures snapshots in multiple tiles of
>>
On Fri, 20 Dec 2019 17:41:00 GMT, Frederic Thevenet
wrote:
>> This is a PR for
>> [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627).
>>
>> When running a JavaFX application in macOS guest VM, the main stage is
>> completely blank, with the following errors: CGLChoosePixelFormat
On Tue, 17 Dec 2019 13:47:50 GMT, Frederic Thevenet
wrote:
> This PR aims to address the following issue: JDK-8088198 Exception thrown
> from snapshot if dimensions are larger than max texture size
>
> In order to do that, it simply captures snapshots in multiple tiles of
> maxTextureSize^2
> This is a PR for
> [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627).
>
> When running a JavaFX application in macOS guest VM, the main stage is
> completely blank, with the following errors: CGLChoosePixelFormat error:
> 10002, CGLCreateContext error: 10002
> This behavior was
On Fri, 20 Dec 2019 10:05:48 GMT, Ambarish Rapte wrote:
>> As mentioned in the description of
>> [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627), following
>> error is printed
>> CGLChoosePixelFormat error: 10002
>>
>> According to the documentation at [CGL Error
>>
On Fri, 20 Dec 2019 00:19:43 GMT, Kevin Rushforth wrote:
>> I was thinking of deferring the `apps/toys` demo to avoid any delays in
>> getting the new API into JavaFX 14. I have something for it, I just don't
>> want any feedback on it to hold up the review of this issue. Is there
>>
> This is a PR for
> [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627).
>
> When running a JavaFX application in macOS guest VM, the main stage is
> completely blank, with the following errors: CGLChoosePixelFormat error:
> 10002, CGLCreateContext error: 10002
> This behavior was
On Fri, 20 Dec 2019 14:06:30 GMT, Kevin Rushforth wrote:
>> It looks good then, please update PR without `err != kCGLNoError`
>
> Something like this, maybe?
>
> if (pix == NULL) {
> NSLog(@"CGLChoosePixelFormat: unable to find a pixel format, trying
> again with reduced
On Fri, 20 Dec 2019 14:03:02 GMT, Ambarish Rapte wrote:
>> OK, so we're in agreement on the fix itself. Good.
>>
>> The existing logging done right before the function returns will indeed log
>> a complete failure to find a valid pixel format. It won't, however, log the
>> fact that the
On Fri, 20 Dec 2019 13:53:38 GMT, Frederic Thevenet
wrote:
>> Actually, the existing check uses `err == kCGLNoError` which seems backwards
>> (and likely is a big part of why this bug is happening). My recommendation
>> is to not add in the check for `err != kCGLNoError`, and just use `if
On Fri, 20 Dec 2019 14:01:44 GMT, Kevin Rushforth wrote:
>> Actually, `err == kCGLNoError` was used before and not `err != kCGLNoError`
>> (i.e. equals and not different) and that is in fact the reason for the bug
>> (in conjunction with the AND).
>> As you note, it's unfortunate that the
On Fri, 20 Dec 2019 13:54:14 GMT, Thiago Milczarek Sayao
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8232811
>>
>> This one was hard to tackle.
>>
>> ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
>> test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest
>
>
On Thu, 19 Dec 2019 22:47:07 GMT, Kevin Rushforth wrote:
> Update the last-modified year in the copyright header to 2019 for files that
> were modified this year without updating the year in the copyright header.
The change looks good.
-
Marked as reviewed by arapte (Reviewer).
On Fri, 20 Dec 2019 13:50:16 GMT, Kevin Rushforth wrote:
>> From the documentation, the check `pix == NULL` seems sufficient, but the
>> `err != kCGLNoError` was used before, so I just want to keep it safe. If the
>> issue occurs without error getting printed it will be difficult to trace. As
On Fri, 20 Dec 2019 10:23:36 GMT, Frederic Thevenet
wrote:
>> Additionally the if condition at line 105 can be changed to match with the
>> change. as,
>> `if (pix == NULL || err != kCGLNoError)`
>
> Could you please be more specific on why you suggest the check be expended
> with `|| err
On Fri, 20 Dec 2019 09:53:56 GMT, Florian Kirmaier
wrote:
>> @dsgrieve
>> It's worth mentioning that JavaFX already has many tests based on
>> System.gc().
>> An advantage of having a testsuit as an library (or copyied from an library)
>> is, that its stability is regulary verified by the
On Fri, 20 Dec 2019 13:13:55 GMT, Thiago Milczarek Sayao
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8232811
>>
>> This one was hard to tackle.
>>
>> ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
>> test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest
>
>
Please ignore that; I just RTFM, its all good now ;)
- Mail original -
De: "Frederic Thevenet"
À: "openjfx-dev"
Envoyé: Vendredi 20 Décembre 2019 11:31:45
Objet: Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS
virtual machine
On Fri, 20 Dec 2019 10:05:48 GMT,
On Fri, 20 Dec 2019 10:05:48 GMT, Ambarish Rapte wrote:
>> As mentioned in the description of
>> [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627), following
>> error is printed
>> CGLChoosePixelFormat error: 10002
>>
>> According to the documentation at [CGL Error
>>
On Fri, 20 Dec 2019 09:55:18 GMT, Ambarish Rapte wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassView3D.m line 97:
>>
>>> 96: if (pix == NULL)
>>> 97: {
>>> 98: const CGLPixelFormatAttribute attributes2[] =
>>
>> The change looks good.
>> I would
On Fri, 20 Dec 2019 10:02:16 GMT, Ambarish Rapte wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8235627
>
> As mentioned in the description of
> [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627), following
> error is printed
> CGLChoosePixelFormat error: 10002
>
>
On Tue, 10 Dec 2019 13:12:37 GMT, Frederic Thevenet
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8235627
As mentioned in the description of
[JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627), following
error is printed
CGLChoosePixelFormat error: 10002
According to the
On Fri, 20 Dec 2019 09:50:35 GMT, Ambarish Rapte wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8235627
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassView3D.m line 97:
>
>> 96: if (pix == NULL)
>> 97: {
>> 98: const CGLPixelFormatAttribute
On Thu, 19 Dec 2019 22:22:55 GMT, Florian Kirmaier
wrote:
>> I would urge caution about incorporating JMemoryBuddy without seeking out
>> advice from GC experts. I have my doubts that it will work reliably given
>> its reliance on System.gc(). (Opinion is my own, not my employer's).
>
>
35 matches
Mail list logo
