On Thu, 19 Dec 2019 22:22:55 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> I would urge caution about incorporating JMemoryBuddy without seeking out >> advice from GC experts. I have my doubts that it will work reliably given >> its reliance on System.gc(). (Opinion is my own, not my employer's). > > @dsgrieve > It's worth mentioning that JavaFX already has many tests based on System.gc(). > An advantage of having a testsuit as an library (or copyied from an library) > is, that its stability is regulary verified by the travis builds for > different JVMs. > The alternative would be to not test for memory-leaks at all which is much > worse than having slightly unstable tests. > Maybe it can make sense to seperate these tests for leaks in an own testgroup. > > I'm introducing this library in more and more projects. I never had problems > with unstable tests. > I only had this kind of problem when I wrote the > WeakReference/System.gc/sleep-logic for every single test. I highly doubt that a code analysis tool will find such memoryleaks. ------------- PR: https://git.openjdk.java.net/jfx/pull/71
