Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-07-29 Thread Ambarish Rapte
On Tue, 28 Jul 2020 13:28:38 GMT, Nir Lisker wrote: > I'd like to know how you did that. Compiled hlsl shader binaries are stored in folder `rt\modules\javafx.graphics\build\headers\PrismD3D\hlsl`. The `fxc` command that generates these files is in `build.gradle`. We can just make a copy and d

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-07-29 Thread Ambarish Rapte
On Tue, 28 Jul 2020 12:44:18 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/main3Lights.frag >> line 92: >> >>> 91: d += clamp(dot(n,l), 0.0, 1.0) * (lights[0].color).rgb * att; >>> 92: s += pow(clamp(dot(-refl, l), 0.0, 1.0), power)

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-07-29 Thread Nir Lisker
On Fri, 24 Jul 2020 21:25:06 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now >> contains 11 commits: >> - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight >> - Attenuation and ran

Re: [jfx15] RFR: 8246343: Fix mistakes in FX API docs [v5]

2020-07-29 Thread Ajit Ghaisas
On Tue, 28 Jul 2020 18:53:14 GMT, Nir Lisker wrote: >> Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some additional >> fixes in the vicinity. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Addressed review com

[jfx15] Integrated: 8246343: Fix mistakes in FX API docs

2020-07-29 Thread Nir Lisker
On Sat, 25 Jul 2020 17:16:25 GMT, Nir Lisker wrote: > Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some additional > fixes in the vicinity. This pull request has now been integrated. Changeset: 487854cb Author:Nir Lisker URL: https://git.openjdk.java.net/jfx/commit/487

REMINDER: JavaFX 15 RDP2 starts tomorrow [was: Proposed schedule for JavaFX 15]

2020-07-29 Thread Kevin Rushforth
As a reminder, RDP2 for JavaFX 15 starts tomorrow, July 30, 2020 at 16:00 UTC (09:00 Pacific time). P1-P2 bugs can still be fixed during RDP2 with explicit approval, although the bar will be appropriately high. Test or doc bugs of any priority can still be fixed without explicit approval (beyo

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus [v6]

2020-07-29 Thread Johan Vos
On Thu, 25 Jun 2020 18:20:55 GMT, Abhinay Agarwal wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard. This

Re: [jfx15] RFR: 8228570: Add various documentation clarifications [v2]

2020-07-29 Thread Ambarish Rapte
On Tue, 28 Jul 2020 18:42:46 GMT, Nir Lisker wrote: >> Adds clarifications to the documentation in various places. Some notes: >> >> * Point 6 should probably be deferred until it is verified that the >> tutorials are correct enough, seeing as they were >> updated to Java 8 only. >> * Point 8

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-07-29 Thread Thiago Milczarek Sayao
On Wed, 29 Jul 2020 02:39:31 GMT, Tor (torbuntu) wrote: >>> If you want these commits to be preserved when you integrate, you will need >>> to make a 'merge-style' pull request. >> >> Please ignore this information from Skara. I don't know what caused it, but >> I've pinged the Skara folks ab

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-07-29 Thread torbuntu
On Wed, 29 Jul 2020 20:46:16 GMT, Thiago Milczarek Sayao wrote: >> Would it be possible and related to add the gtk touch events to this PR as >> part of the Glass GTK3 update? Or would >> follow up update PR adding that be more appropriate? >> Currently linux desktop does not have touch support

Re: RFR: 8217472: Add attenuation for PointLight [v7]

2020-07-29 Thread Nir Lisker
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Added performance test - Changes: - all: https://git.openjdk.java.net/jfx/pull/43/files - new: https://git.openjdk

Re: RFR: 8217472: Add attenuation for PointLight [v8]

2020-07-29 Thread Nir Lisker
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Fixed whitespaces - Changes: - all: https://git.openjdk.java.net/jfx/pull/43/files - new: https://git.openjdk.java

Re: RFR: 8217472: Add attenuation for PointLight [v9]

2020-07-29 Thread Nir Lisker
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Fixed whitespace - Changes: - all: https://git.openjdk.java.net/jfx/pull/43/files - new: https://git.openjdk.java.

Deadlock: JFXPanel, ContextMenu, macOS

2020-07-29 Thread Steven Yi
Hi All, I'm not sure if this is the place to report this, but hopefully so. (I did not see a way to create an account or report issues on JBS.) I am using JavaFX embedded within a Swing application and had found intermittent deadlocks on macOS that I wasn't sure why it was happening. I was finall

Re: RFR: 8217472: Add attenuation for PointLight [v5]

2020-07-29 Thread Nir Lisker
On Fri, 24 Jul 2020 21:41:04 GMT, Kevin Rushforth wrote: > 1. The API docs look good. If you change the public API to `@since 16` then > you can also update the CSR and move it to > the "Submitted" state. I moved it to the PROPOSED state. > 2. I think it would be good to cleanup the performanc

Re: RFR: 8217472: Add attenuation for PointLight [v10]

2020-07-29 Thread Nir Lisker
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Moved test folder - Changes: - all: https://git.openjdk.java.net/jfx/pull/43/files - new: https://git.openjdk.java

[jfx15] RFR: 8250799: NumberStringConverter and its subclasses are missing documentation for all their constructors

2020-07-29 Thread Nir Lisker
This was missed the in Javadoc fixes for 15. Added documentation for all the constructors, did a bit of formatting, and removed redundant comments. - Commit messages: - Initial commit of 8250799 Changes: https://git.openjdk.java.net/jfx/pull/277/files Webrev: https://webrevs.open