Re: RFR: 8255337: [TestBug] Controls unit tests - ButtonTest and ComboBoxTest - log ClassCastException

2020-10-26 Thread Ajit Ghaisas
On Fri, 23 Oct 2020 15:44:43 GMT, Jeanette Winzenburg wrote: >> This is a test fix. >> >> Root cause: >> - For ButtonTest - Incorrect use of MouseEventFirer - which puts Button on >> to the stage and shows it before firing mouse event >> - For ComboBoxTest - adding ComboBox to a Stage, not

Re: RFR: 8254049: Update WebView to public suffix list 2020-04-24

2020-10-26 Thread Kevin Rushforth
On Mon, 19 Oct 2020 04:29:13 GMT, Arun Joseph wrote: > We should use the public_suffix_list.dat file in the JDK instead. Reading the > public_suffix_list.dat file is modified to be similar to >

Re: RFR: 8255415: Nested calls to snap methods in Region give different results

2020-10-26 Thread Kevin Rushforth
On Fri, 23 Oct 2020 08:32:59 GMT, Jose Pereda wrote: > As discussed in the [JBS > issue](https://bugs.openjdk.java.net/browse/JDK-8199592), when snapping an > already snapped value (either intentionally or by mistake), the result > should be the same, otherwise we'll be jumping unnecessary

Re: RFR: 8244297: Provide utility for testing for memory leaks [v10]

2020-10-26 Thread Kevin Rushforth
On Sun, 25 Oct 2020 13:24:44 GMT, Florian Kirmaier wrote: >> It's based on the discussion of my previous PR: >> https://github.com/openjdk/jfx/pull/71 >> >> I Added test utility class copied from JMemoryBuddy and used it to simplify >> 4 of the existing unit tests. >> >> It's a direct copy

Re: RFR: 8255415: Nested calls to snap methods in Region give different results

2020-10-26 Thread Jose Pereda
On Mon, 26 Oct 2020 10:03:20 GMT, Jeanette Winzenburg wrote: >> @kleopatra Thanks for checking. >> >> As discussed in the JBS issue, there is a call in >> `CheckBoxSkin::layoutChildren` that, probably by mistake, calls `snapSizeX` >> twice, and that gives different results when a different

Re: RFR: 8254691: Enable GitHub actions for jfx repo

2020-10-26 Thread Kevin Rushforth
On Sat, 24 Oct 2020 16:56:46 GMT, Johan Vos wrote: >> @rwestberg I was pleasantly surprised to see the Skara bot add this: >> >>>  | Linux x64 | Windows x64 | macOS x64 >>> -- | -- | -- | -- >>> Build / test | ✔️ (1/1 passed) | ✔️ (1/1 passed) | ✔️ (1/1 passed) >> >> I was going to ask you

Re: RFR: 8254691: Enable GitHub actions for jfx repo

2020-10-26 Thread Kevin Rushforth
On Sat, 24 Oct 2020 14:41:08 GMT, Kevin Rushforth wrote: > This is a proposed fix for > [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable > GitHub actions for the jfx repo. It is similar in purpose to what was done > for the jdk repo. > > Once this is integrated, and

Re: RFR: 8254691: Enable GitHub actions for jfx repo

2020-10-26 Thread Robin Westberg
On Sat, 24 Oct 2020 18:26:29 GMT, Kevin Rushforth wrote: >>> @rwestberg I was pleasantly surprised to see the Skara bot add this: >>> >>> > Linux x64 >>> > Windows x64 >>> > macOS x64 >>> > >>> > >>> > >>> > >>> > Build / test >>> > heavy_check_mark (1/1 passed) >>> > heavy_check_mark (1/1

Re: RFR: 8254691: Enable GitHub actions for jfx repo

2020-10-26 Thread Kevin Rushforth
On Sat, 24 Oct 2020 16:28:28 GMT, Kevin Rushforth wrote: >> This is a proposed fix for >> [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable >> GitHub actions for the jfx repo. It is similar in purpose to what was done >> for the jdk repo. >> >> Once this is

RFR: 8254691: Enable GitHub actions for jfx repo

2020-10-26 Thread Kevin Rushforth
This is a proposed fix for [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable GitHub actions for the jfx repo. It is similar in purpose to what was done for the jdk repo. Once this is integrated, and subsequently merged into your personal fork, a GitHub Actions workflow

Re: RFR: 8254691: Enable GitHub actions for jfx repo

2020-10-26 Thread Johan Vos
On Sat, 24 Oct 2020 14:49:37 GMT, Kevin Rushforth wrote: >> This is a proposed fix for >> [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable >> GitHub actions for the jfx repo. It is similar in purpose to what was done >> for the jdk repo. >> >> Once this is

Re: RFR: 8199592: Control labels truncated at certain DPI scaling levels

2020-10-26 Thread Jeanette Winzenburg
On Sun, 25 Oct 2020 19:27:30 GMT, Jose Pereda wrote: >> curious: it this expected to fix the ellipsed checkBox texts? Can verify >> that the test fails/passes before/after the fix, but the example in the >> report looks still is eclipsed: same for 1.5, slightly better (in that only >> the