Re: Mnemonic Parsing doesn't appear to work properly

Ah, great. It would be nice to see progress on JDK-8088370 (it’s been 6 years since it was reported) for the mnemonic not toggling a checkbox. Scott > On Oct 29, 2021, at 6:20 PM, John Hendrikx wrote: > > The fix is in progress here: https:/

Re: RFR: 8276179 removing unused font code - isInstalledFont

On Fri, 29 Oct 2021 15:37:24 GMT, Florian Kirmaier wrote: > I've also seen many places in the font code, which just catch Exceptions > without handling them, nor logging them. This is really frightening when > investigating issues with fonts. It seems like some Exceptions are expected, > but

Re: RFR: 8276179 removing unused font code - isInstalledFont

On Fri, 29 Oct 2021 15:10:35 GMT, Florian Kirmaier wrote: > removing dead code. > When looking into the font code, I've noticed that this code is no longer > used, so I thought I should make a PR with a minor cleanup. Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.ja

Re: RFR: 8274854: Mnemonics for menu containing numeric text not working [v3]

On Fri, 29 Oct 2021 20:19:02 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changed javadoc > > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/LabelSkinTest.java > line

Re: RFR: WIP: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v5]

> Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(activeWindows.size() - 1); > window.setIconified(false); >

Re: RFR: 8274854: Mnemonics for menu containing numeric text not working [v3]

On Fri, 29 Oct 2021 20:54:04 GMT, Michael Strauß wrote: >> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextBinding.java >> line 188: >> >>> 186: int i = 0; >>> 187: >>> 188: // Parse the input string and stop after the first mnemonic. >> >> This

Re: Mnemonic Parsing doesn't appear to work properly

The fix is in progress here: https://github.com/openjdk/jfx/pull/647 On 29/10/2021 22:12, John Hendrikx wrote: Looking a bit further, and I noticed this code has recently been rewritten. The old code used StringBuffer and wasn't that easy to read, but the new code although easier to read seems t

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v4]

> Found the problem thru this path: > > **WindowStage.java** > > final void handleFocusDisabled() { > if (activeWindows.isEmpty()) { > return; > } > WindowStage window = activeWindows.get(activeWindows.size() - 1); > window.setIconified(false); >

Re: RFR: 8274854: Mnemonics for menu containing numeric text not working [v3]

On Fri, 29 Oct 2021 20:26:56 GMT, John Hendrikx wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> changed javadoc > > modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextBinding.java >

Re: RFR: 8274854: Mnemonics for menu containing numeric text not working [v3]

On Fri, 29 Oct 2021 13:58:35 GMT, Michael Strauß wrote: >> This PR fixes an issue with mnemonic parsing by removing the restriction >> that a mnemonic symbol must be a letter. Now, it can be any character except >> whitespace. > > Michael Strauß has updated the pull request incrementally with o

Re: RFR: 8274854: Mnemonics for menu containing numeric text not working [v3]

On Fri, 29 Oct 2021 13:58:35 GMT, Michael Strauß wrote: >> This PR fixes an issue with mnemonic parsing by removing the restriction >> that a mnemonic symbol must be a letter. Now, it can be any character except >> whitespace. > > Michael Strauß has updated the pull request incrementally with o

Re: Mnemonic Parsing doesn't appear to work properly

Looking a bit further, and I noticed this code has recently been rewritten. The old code used StringBuffer and wasn't that easy to read, but the new code although easier to read seems to contain several changes in how things used to work. The most noticable is that it doesn't stop after it fin

Re: Mnemonic Parsing doesn't appear to work properly

Hm, I can confirm it appears under the "e", also under Windows, but I suspect the platform will make no difference. I tested a bit further, and I found the following: 1) The mnemonic key seems to be "m", and it appears under the "e" because it deleted two more underscores (index is off by 2).

Re: RFR: 8276179 removing unused font code - isInstalledFont

On Fri, 29 Oct 2021 15:10:35 GMT, Florian Kirmaier wrote: > removing dead code. > When looking into the font code, I've noticed that this code is no longer > used, so I thought I should make a PR with a minor cleanup. Marked as reviewed by prr (Reviewer). I'm quite confident the build will be

Mnemonic Parsing doesn't appear to work properly

I looked in the bug database and while there are lots of bugs reported against the mnemonic parsing, they claim to be fixed. After noticing something peculiar on a control in my app (it was showing a file path and I hadn't disabled the mnemonic parsing) I did some tests. The documentation is uncl

Re: RFR: 8276179 removing unused font code - isInstalledFont

On Fri, 29 Oct 2021 15:10:35 GMT, Florian Kirmaier wrote: > removing dead code. > When looking into the font code, I've noticed that this code is no longer > used, so I thought I should make a PR with a minor cleanup. Marked as reviewed by prr (Reviewer). - PR: https://git.openjd

Re: RFR: 8274699: Certain blend modes cannot be set from CSS [v2]

On Fri, 29 Oct 2021 15:37:36 GMT, Marius Hanl wrote: > > Looks good, although the solution in itself remains fishy. Maybe create a > > ticket to implement a better solution in the future? > > yes, the css code is sometimes very ... interesting. I have not looked > closely but it's weird that t

Integrated: 8274699: Certain blend modes cannot be set from CSS

On Wed, 6 Oct 2021 07:43:15 GMT, Marius Hanl wrote: > This PR fixes a bug where the blend mode will be falsely recognized as a > color and therefore won't be set. > Also a ClassCastException is thrown (The converter expects a String, but gets > a Color). > > Note: There is another similar bug

Re: RFR: 8274699: Certain blend modes cannot be set from CSS [v2]

On Fri, 29 Oct 2021 14:34:39 GMT, Michael Strauß wrote: > Looks good, although the solution in itself remains fishy. Maybe create a > ticket to implement a better solution in the future? yes, the css code is sometimes very ... interesting. I didn't had a deep look but it's weird that there are

Re: RFR: 8276179 removing unused font code - isInstalledFont

On Fri, 29 Oct 2021 15:10:35 GMT, Florian Kirmaier wrote: > removing dead code. > When looking into the font code, I've noticed that this code is no longer > used, so I thought I should make a PR with a minor cleanup. I've also seen many places in the font code, which just catch Exceptions wi

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v7]

On Mon, 18 Oct 2021 08:20:22 GMT, Florian Kirmaier wrote: >> When using Swing it's possible to generate a Deadlock. >> It's related to the nested eventloop started in enterFullScreenExitingLoop >> - and the RenderLock aquired when using setView in Scene. >> Sample Programm and Threaddump are

Re: RFR: 8276179 removing unused font code - isInstalledFont

On Fri, 29 Oct 2021 15:10:35 GMT, Florian Kirmaier wrote: > removing dead code. > When looking into the font code, I've noticed that this code is no longer > used, so I thought I should make a PR with a minor cleanup. A quick look suggests that this is, in fact, unused. I would like Phil to r

RFR: 8276179 removing unused font code - isInstalledFont

removing dead code. When looking into the font code, I've noticed that this code is no longer used, so I thought I should make a PR with a minor cleanup. - Commit messages: - JDK-8276179 Changes: https://git.openjdk.java.net/jfx/pull/658/files Webrev: https://webrevs.openjdk.java.

Re: RFR: 8274699: Certain blend modes cannot be set from CSS [v2]

On Thu, 14 Oct 2021 21:47:16 GMT, Marius Hanl wrote: >> This PR fixes a bug where the blend mode will be falsely recognized as a >> color and therefore won't be set. >> Also a ClassCastException is thrown (The converter expects a String, but >> gets a Color). >> >> Note: There is another simi

Re: RFR: 8222455: JavaFX error loading glass.dll from cache

On Tue, 26 Oct 2021 12:09:19 GMT, Marius Hanl wrote: > This problem can happen when using multiple instances with different jfx > early access (ea) versions. > > Example: > Instance 1 uses 18-ea+4 and Instance 2 uses 18-ea+1. > Instance 1 is started (and will cache and use libraries), then in

Integrated: 8275848: Deprecate for removal mistakenly exposed field from class javafx.scene.shape.Box

On Fri, 29 Oct 2021 07:31:05 GMT, Ajit Ghaisas wrote: > This PR deprecates mistakenly exposed field from class javafx.scene.shape.Box. This pull request has now been integrated. Changeset: d9e1ad97 Author:Ajit Ghaisas URL: https://git.openjdk.java.net/jfx/commit/d9e1ad97687379912887

Re: RFR: 8274854: Mnemonics for menu containing numeric text not working [v3]

On Fri, 29 Oct 2021 13:58:35 GMT, Michael Strauß wrote: >> This PR fixes an issue with mnemonic parsing by removing the restriction >> that a mnemonic symbol must be a letter. Now, it can be any character except >> whitespace. > > Michael Strauß has updated the pull request incrementally with o

Integrated: 8255015: Inconsistent illumination of 3D shape by PointLight

On Wed, 9 Jun 2021 18:22:31 GMT, Andreas Heger wrote: > The inconsistent illumination happens on Macs with retina displays only if > the 3D shape is placed in a SubScene. The light sources are located with > wrong coordinates in sub scenes and this causes a different illumination. The > wrong

Re: RFR: 8274854: Mnemonics for menu containing numeric text not working [v3]

On Fri, 29 Oct 2021 13:45:24 GMT, Ajit Ghaisas wrote: >> Done. > > The corresponding comment for the method isSimpleMnemonic() also needs > correction. > You can limit it to - > > /** > * Determines whether the string contains a simple mnemonic at the > specified position. > * A

Re: RFR: 8274854: Mnemonics for menu containing numeric text not working [v3]

> This PR fixes an issue with mnemonic parsing by removing the restriction that > a mnemonic symbol must be a letter. Now, it can be any character except > whitespace. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: changed javado

Re: RFR: 8274854: Mnemonics for menu containing numeric text not working [v2]

On Fri, 29 Oct 2021 12:34:50 GMT, Michael Strauß wrote: >> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextBinding.java >> line 238: >> >>> 236: } >>> 237: >>> 238: return !isExtendedMnemonic(s, position); >> >> I am not sure why do we need to c

Re: RFR: 8274854: Mnemonics for menu containing numeric text not working [v2]

On Fri, 29 Oct 2021 11:23:50 GMT, Ajit Ghaisas wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removed isExtendedMnemonic check from isSimpleMnemonic > > modules/javafx.controls/src/main/java/com/sun/javafx/scene

Integrated: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit

On Tue, 5 Oct 2021 13:18:07 GMT, Jeanette Winzenburg wrote: > cell startEdit is supposed to update the editing location on its associated > control - was done in ListCell, not in Tree-/TableCell nor TreeCell. > > Fix was to add control.edit(..). Note that ListCell was also touched to use > th

Re: RFR: 8274854: Mnemonics for menu containing numeric text not working [v2]

> This PR fixes an issue with mnemonic parsing by removing the restriction that > a mnemonic symbol must be a letter. Now, it can be any character except > whitespace. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: Removed isExte

Re: RFR: 8275848: Deprecate for removal mistakenly exposed field from class javafx.scene.shape.Box [v2]

On Fri, 29 Oct 2021 11:42:38 GMT, Ajit Ghaisas wrote: >> This PR deprecates mistakenly exposed field from class >> javafx.scene.shape.Box. > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > review fix Marked as reviewed by n

Re: RFR: 8275848: Deprecate for removal mistakenly exposed field from class javafx.scene.shape.Box [v2]

On Fri, 29 Oct 2021 11:42:38 GMT, Ajit Ghaisas wrote: >> This PR deprecates mistakenly exposed field from class >> javafx.scene.shape.Box. > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > review fix Looks good. --

Re: RFR: 8275848: Deprecate for removal mistakenly exposed field from class javafx.scene.shape.Box [v2]

> This PR deprecates mistakenly exposed field from class javafx.scene.shape.Box. Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision: review fix - Changes: - all: https://git.openjdk.java.net/jfx/pull/655/files - new: htt

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v7]

On Mon, 18 Oct 2021 08:20:22 GMT, Florian Kirmaier wrote: >> When using Swing it's possible to generate a Deadlock. >> It's related to the nested eventloop started in enterFullScreenExitingLoop >> - and the RenderLock aquired when using setView in Scene. >> Sample Programm and Threaddump are

Re: RFR: 8275848: Deprecate mistakenly exposed field from class javafx.scene.shape.Box

On Fri, 29 Oct 2021 07:31:05 GMT, Ajit Ghaisas wrote: > This PR deprecates mistakenly exposed field from class javafx.scene.shape.Box. This looks good with one minor comment. Please also change the title of the JBS issues (both the bug and the CSR) and this PR to add "for removal" after "Depre

Re: RFR: 8274854: Mnemonics for menu containing numeric text not working

On Wed, 20 Oct 2021 16:54:35 GMT, Michael Strauß wrote: > This PR fixes an issue with mnemonic parsing by removing the restriction that > a mnemonic symbol must be a letter. Now, it can be any character except > whitespace. modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/beh

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v2]

On Thu, 14 Oct 2021 14:29:55 GMT, Kevin Rushforth wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8269907 >> The bug is now fixed in a new way. Toolkit now supports registering >> CleanupListeners, which

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v7]

On Mon, 18 Oct 2021 08:20:22 GMT, Florian Kirmaier wrote: >> When using Swing it's possible to generate a Deadlock. >> It's related to the nested eventloop started in enterFullScreenExitingLoop >> - and the RenderLock aquired when using setView in Scene. >> Sample Programm and Threaddump are

Re: RFR: 8187474: Tree-/TableCell, TreeCell: editingCell/Item not updated in cell.startEdit [v3]

On Fri, 22 Oct 2021 10:36:24 GMT, Jeanette Winzenburg wrote: >> cell startEdit is supposed to update the editing location on its associated >> control - was done in ListCell, not in Tree-/TableCell nor TreeCell. >> >> Fix was to add control.edit(..). Note that ListCell was also touched to use

RFR: 8275848: Deprecate mistakenly exposed field from class javafx.scene.shape.Box

This PR deprecates mistakenly exposed field from class javafx.scene.shape.Box. - Commit messages: - Deprecate DEFAULT_SIZE constant field Changes: https://git.openjdk.java.net/jfx/pull/655/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=655&range=00 Issue: https://bug