On Mon, 1 Aug 2022 18:42:46 GMT, Michael Strauß wrote:
>> The `focusVisible` flag is only set on a node when it acquires input focus
>> using a keyboard interaction, and it is cleared by mouse and touch
>> interactions.
>>
>> It is not necessary for a node to lose input focus in order to lose
On Mon, 1 Aug 2022 18:42:46 GMT, Michael Strauß wrote:
>> The `focusVisible` flag is only set on a node when it acquires input focus
>> using a keyboard interaction, and it is cleared by mouse and touch
>> interactions.
>>
>> It is not necessary for a node to lose input focus in order to lose
On Fri, 29 Jul 2022 21:11:53 GMT, Andy Goryachev wrote:
> - moving mouse pointer to stage lower right corner in order to avoid
> interference with the Robot screen capture.
This pull request has now been integrated.
Changeset: 08ec9c87
Author:Andy Goryachev
Committer: Kevin Rushforth
URL
On Mon, 1 Aug 2022 20:08:18 GMT, Andy Goryachev wrote:
> VisualTestBase is a base class to the whole gallery of tests, some of which
> have more than one stage (IconifyTest). I've limited the changes to
> RegionBackgroundImageUITest because I did not want to expand the scope
> unnecessarily.
On Fri, 29 Jul 2022 21:40:40 GMT, Andy Goryachev wrote:
>> - moving mouse pointer to stage lower right corner in order to avoid
>> interference with the Robot screen capture.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 1 Aug 2022 18:55:29 GMT, Michael Strauß wrote:
> I've reverted most of the changes around `KeyHandler`.
Thank you. That will make this much easier to review.
-
PR: https://git.openjdk.org/jfx/pull/852
On Fri, 29 Jul 2022 23:01:27 GMT, Kevin Rushforth wrote:
> The fix works on my M1 system for the two failing tests. So my only feedback
> is the suggestion to move the `before` method from
> `RegionBackgroundImageUITest` to `VisualTestBase`.
VisualTestBase is a base class to the whole gallery
On Mon, 1 Aug 2022 18:47:14 GMT, Nir Lisker wrote:
>> - updated .classpath entries in apps/
>> - added utf-8 prefs in .settings/
>
> buildSrc/.classpath line 10:
>
>> 8: > path="../build/libs/antlr-runtime-3.1.3.jar"/>
>> 9: > path="../build/libs/stringtemplate-3.2.jar"/>
>> 10: > path="..
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
One quick comment. Compiling or running the apps should not need any additional
`--add-exports`, `--add-reads`, or `--add-opens` arguments, and they should not
nee
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
@nlisker :
could you please take a look at this draft PR?
with these changes, I get no errors in eclipse, I can run tests and standalone
applications.
I still cann
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
I'm don't think that this is the right approach with the apps. I think that
each app should be its own project. See the branch I linked in the previous PR.
I don't
- updated .classpath entries in apps/
- added utf-8 prefs in .settings/
-
Commit messages:
- 8290473: added ColorCube project
- 8290473: eclipse config for apps
Changes: https://git.openjdk.org/jfx/pull/858/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=858&range=00
Issu
On Mon, 1 Aug 2022 18:06:15 GMT, Kevin Rushforth wrote:
> Be that as it may, this sort of refactoring is discouraged, especially in the
> case of a fix you want to get in late in the release (we have 3 days left
> before the RDP2 deadline of JavaFX 19). This will cause extra time for the
> rev
> The `focusVisible` flag is only set on a node when it acquires input focus
> using a keyboard interaction, and it is cleared by mouse and touch
> interactions.
>
> It is not necessary for a node to lose input focus in order to lose
> `focusVisible`. Currently, clicking on a region of the scen
> The `focusVisible` flag is only set on a node when it acquires input focus
> using a keyboard interaction, and it is cleared by mouse and touch
> interactions.
>
> It is not necessary for a node to lose input focus in order to lose
> `focusVisible`. Currently, clicking on a region of the scen
On Thu, 28 Jul 2022 14:59:06 GMT, Michael Strauß wrote:
> The changes around KeyHandler might seem to be excessive for the scope of
> this PR.
They do indeed.
> I think that moving the focus-related functionality next to the other focus
> functions in the Scene class is a safe and straightfo
On Thu, 28 Jul 2022 14:59:06 GMT, Michael Strauß wrote:
> The `focusVisible` flag is only set on a node when it acquires input focus
> using a keyboard interaction, and it is cleared by mouse and touch
> interactions.
>
> It is not necessary for a node to lose input focus in order to lose
> `
On Mon, 1 Aug 2022 12:06:31 GMT, Ambarish Rapte wrote:
> Update Boot JDK to 18.0.2.
> Tested build on all platforms and full test run on MacOS Catalina.
This pull request has now been integrated.
Changeset: 8fa89199
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx/commit/8fa89
Sounds good to me.
-andy
From: Kevin Rushforth
Date: Monday, 2022/08/01 at 08:32
To: Nir Lisker , Andy Goryachev
Cc: Jeanette Winzenburg , openjfx-dev@openjdk.org
Subject: Re: [External] : Re: Eclipse: ClassNotFoundException:
com.sun.prism.shader.FillPgram_Color_Loader
I was going to ask the
I was going to ask the same question.
Let's just fix this in the mainline jfx release. Developers are only
going to care about jfx19 for another 4 days.
-- Kevin
On 8/1/2022 8:20 AM, Nir Lisker wrote:
What's the value of backporting a build change?
On Mon, Aug 1, 2022 at 6:16 PM Andy Gorya
But that has no effect on previous JavaFX builds, I don't see a retroactive
value here.
>
On Mon, 1 Aug 2022 12:06:31 GMT, Ambarish Rapte wrote:
> Update Boot JDK to 18.0.2.
> Tested build on all platforms and full test run on MacOS Catalina.
Looks good.
-
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.org/jfx/pull/857
Update Boot JDK to 18.0.2.
Tested build on all platforms and full test run on MacOS Catalina.
-
Commit messages:
- 8291588: Update boot JDK to 18.0.2
Changes: https://git.openjdk.org/jfx/pull/857/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=857&range=00
Issue: https://b
23 matches
Mail list logo
