On Thu, 8 Dec 2022 18:53:48 GMT, Kevin Rushforth wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/DatePickerUpdateOnAlertCloseTest.java
>
> Cause: On hiding the DatePicker dropdown, value selected was not getting
> updated to the text editor. Hence old value from the text editor was getting
> committed to DatePicker on focus loss. This issue was seen only when
> DatePicker is used in Alert dialog and Alert dialog is closed on maki
On Thu, 8 Dec 2022 18:04:24 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/DatePickerUpdateOnAlertCloseTest.java
>
On Thu, 8 Dec 2022 19:21:14 GMT, Marius Hanl wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/DatePickerSkin.java
> line 14
On Thu, 17 Nov 2022 06:16:34 GMT, Hima Bindu Meda wrote:
> Updated sqlite to v3.39.4
> Verified build on windows, linux and mac.
> Sanity testing looks fine.
+ looks ok to me
-
Marked as reviewed by jbhaskar (Author).
PR: https://git.openjdk.org/jfx/pull/953
On Thu, 17 Nov 2022 06:16:34 GMT, Hima Bindu Meda wrote:
> Updated sqlite to v3.39.4
> Verified build on windows, linux and mac.
> Sanity testing looks fine.
Marked as reviewed by jvos (Reviewer).
Looks good on darwin-x86_64, linux and windows. Didn't test darwin-aarch64.
-
PR: ht
On Mon, 28 Nov 2022 12:42:15 GMT, Karthik P K wrote:
> Cause: On hiding the DatePicker dropdown, value selected was not getting
> updated to the text editor. Hence old value from the text editor was getting
> committed to DatePicker on focus loss. This issue was seen only when
> DatePicker is
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on t
On Tue, 28 Jun 2022 17:06:39 GMT, Marius Hanl wrote:
> Initialize the `(Tree)TableView` when creating the measure row.
> This will guarantee, that we can access the `(Tree)TableView` in the
> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
> is always set otherwise)
On Thu, 8 Dec 2022 18:29:48 GMT, Marius Hanl wrote:
>> The problem here is, that the `AnchorPane` does not use its snapped insets.
>> Therefore, the fix is to replace all `getInsets().getXXX` calls with their
>> corresponding `snappedXXXInset()` methods.
>>
>> Note: The reason the `AnchorPane`
On Mon, 28 Nov 2022 12:42:15 GMT, Karthik P K wrote:
> Cause: On hiding the DatePicker dropdown, value selected was not getting
> updated to the text editor. Hence old value from the text editor was getting
> committed to DatePicker on focus loss. This issue was seen only when
> DatePicker is
On Thu, 8 Dec 2022 14:20:22 GMT, Johan Vos wrote:
> If it is only on Ubuntu 16.04, I am ok with not doing an ugly work-around.
> There is no crash or similar critical issue, and if we get this PR in the
> next OpenJFX release, it will be 7 years after 16.04.
I agree.
> However, from the remar
> The problem here is, that the `AnchorPane` does not use its snapped insets.
> Therefore, the fix is to replace all `getInsets().getXXX` calls with their
> corresponding `snappedXXXInset()` methods.
>
> Note: The reason the `AnchorPane` inside a `TitledPane` is blurry in the
> first place is b
On Thu, 17 Nov 2022 06:16:34 GMT, Hima Bindu Meda wrote:
> Updated sqlite to v3.39.4
> Verified build on windows, linux and mac.
> Sanity testing looks fine.
Doing a test build + sanity tests
-
PR: https://git.openjdk.org/jfx/pull/953
On Thu, 8 Dec 2022 16:16:58 GMT, Andy Goryachev wrote:
>> Setting a null selection model in TableView and TreeTableView produce NPE on
>> sorting (and probably in some other situations) because the check for null
>> is missing in several places.
>>
>> Setting a null selection model is a valid
On Thu, 8 Dec 2022 17:50:15 GMT, Marius Hanl wrote:
>> Initialize the `(Tree)TableView` when creating the measure row.
>> This will guarantee, that we can access the `(Tree)TableView` in the
>> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
>> is always set otherwi
On Mon, 28 Nov 2022 12:42:15 GMT, Karthik P K wrote:
> Cause: On hiding the DatePicker dropdown, value selected was not getting
> updated to the text editor. Hence old value from the text editor was getting
> committed to DatePicker on focus loss. This issue was seen only when
> DatePicker is
On Thu, 8 Dec 2022 17:50:15 GMT, Marius Hanl wrote:
>> Initialize the `(Tree)TableView` when creating the measure row.
>> This will guarantee, that we can access the `(Tree)TableView` in the
>> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
>> is always set otherwi
> Initialize the `(Tree)TableView` when creating the measure row.
> This will guarantee, that we can access the `(Tree)TableView` in the
> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
> is always set otherwise).
>
> With this change, a NPE is happening as the `(Tr
> Setting a null selection model in TableView and TreeTableView produce NPE on
> sorting (and probably in some other situations) because the check for null is
> missing in several places.
>
> Setting a null selection model is a valid way to disable selection in a
> (tree)table.
>
> There is a
On Thu, 8 Dec 2022 09:45:52 GMT, Marius Hanl wrote:
>> Initialize the `(Tree)TableView` when creating the measure row.
>> This will guarantee, that we can access the `(Tree)TableView` in the
>> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
>> is always set otherwi
On Mon, 24 Oct 2022 19:06:26 GMT, Andy Goryachev wrote:
> as determined by SkinMemoryLeakTest (remove line 180) and a leak tester
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>
> caused by:
> - adding and not removing listeners
> - adding and not rem
On Wed, 7 Dec 2022 17:54:55 GMT, Andy Goryachev wrote:
>> as determined by SkinMemoryLeakTest (remove line 180) and a leak tester
>> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>>
>> caused by:
>> - adding and not removing listeners
>> - adding and no
On Thu, 8 Dec 2022 09:45:52 GMT, Marius Hanl wrote:
>> Initialize the `(Tree)TableView` when creating the measure row.
>> This will guarantee, that we can access the `(Tree)TableView` in the
>> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
>> is always set otherwi
On Thu, 8 Dec 2022 14:21:45 GMT, John Hendrikx wrote:
>> - Added generics (to package private or internal classes only)
>> - Minor clean-ups of code I touched (naming)
>> - Fixed incorrect use of generics
>> - Fixed raw type warnings
>>
>> Note: some raw types have leaked into public API. These
On Tue, 22 Nov 2022 01:40:02 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any si
On Wed, 7 Dec 2022 15:08:00 GMT, Nir Lisker wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/property/adapter/Disposer.java
>> line 47:
>>
>>> 45: public class Disposer implements Runnable {
>>> 46: private static final ReferenceQueue QUEUE = new
>>> ReferenceQueue<>();
>>> 47:
> - Added generics (to package private or internal classes only)
> - Minor clean-ups of code I touched (naming)
> - Fixed incorrect use of generics
> - Fixed raw type warnings
>
> Note: some raw types have leaked into public API. These could be fixed
> without incompatibilities. For specifics s
On Thu, 17 Nov 2022 06:16:34 GMT, Hima Bindu Meda wrote:
> Updated sqlite to v3.39.4
> Verified build on windows, linux and mac.
> Sanity testing looks fine.
@jaybhaskar Please review
@johanvos @tiainen Do you want to do a test build?
-
PR: https://git.openjdk.org/jfx/pull/953
On Thu, 8 Dec 2022 09:45:52 GMT, Marius Hanl wrote:
>> Initialize the `(Tree)TableView` when creating the measure row.
>> This will guarantee, that we can access the `(Tree)TableView` in the
>> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
>> is always set otherwi
On Tue, 22 Nov 2022 01:40:02 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any si
On Thu, 8 Dec 2022 03:10:06 GMT, Kevin Rushforth wrote:
>> Perhaps we can introduce another property - either public or internal to
>> suppress consumption of auto-hiding events?
>>
>> The other aspect of this problem, as we discussed earlier, is that, in my
>> opinion, the tooltips should rea
> Cause: When slider is dragged for first time after tooltip appears,
> setOnMousePressed event was not invoked, hence dragStart was null in the
> subsequently invoked event handler (setOnMouseDragged).
>
> Fix: Initialized dragStart in initialize method.
>
> Test: Added system test to validate
On Thu, 8 Dec 2022 09:45:52 GMT, Marius Hanl wrote:
>> Initialize the `(Tree)TableView` when creating the measure row.
>> This will guarantee, that we can access the `(Tree)TableView` in the
>> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
>> is always set otherwi
> Initialize the `(Tree)TableView` when creating the measure row.
> This will guarantee, that we can access the `(Tree)TableView` in the
> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
> is always set otherwise).
>
> With this change, a NPE is happening as the `(Tr
35 matches
Mail list logo
