Clean backport for 8277853
Reviewed-by: kcr, mhanl
-
Commit messages:
- 8277853: With Touch enabled devices scrollbar disappears and the table is
scrolled to the beginning
Changes: https://git.openjdk.org/jfx17u/pull/106/files
Webrev:
On Thu, 2 Feb 2023 16:54:28 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use width while calling prefHeight method. Use graphicHeight instead of
>> multiple calls to prefHeight
>
>
On Thu, 2 Feb 2023 06:44:01 GMT, Ambarish Rapte wrote:
> Almost clean backport, with a difference in copyright year. Otherwise clean.
This pull request has now been integrated.
Changeset: 509d6cf3
Author:Ambarish Rapte
URL:
On Thu, 2 Feb 2023 06:32:23 GMT, Ambarish Rapte wrote:
> Update copyright year in files modified in year 2022.
This pull request has now been integrated.
Changeset: a9c4ce0f
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx17u/commit/a9c4ce0f233d54b4864427eb67f4ce5e568c2f3a
On Thu, 2 Feb 2023 06:32:58 GMT, Ambarish Rapte wrote:
> Update copyright year in files modified in year 2022.
This pull request has now been integrated.
Changeset: a78d6a96
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx11u/commit/a78d6a968b29cba7addb2bbf0337e95e0257bcfd
On Thu, 2 Feb 2023 21:14:14 GMT, Alexander Zuev wrote:
>> Still, I would recommend adding a comment (since now is the time when we
>> know all the context, and in the future we might forget or lose the
>> context), may be something like
>>
>>
>> # {seriesName} {xAxisName} is {currentX}
A longer answer will take more time than I have at the moment, but here
is a quick reply.
1. We don't have a lot of scene graph performance tests, so before
making any changes here we would need to do some targeted testing.
2. FX scene graph node --> NGNode peer is intended to be be one-way
On Thu, 2 Feb 2023 21:23:14 GMT, Alexander Zuev wrote:
>> Change the underlying class XYChart to take into account labels for axes.
>> Make label patterns and default axes labels localized.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the
On Thu, 2 Feb 2023 17:26:32 GMT, Alexander Zuev wrote:
>> Change the underlying class XYChart to take into account labels for axes.
>> Make label patterns and default axes labels localized.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the
On Thu, 2 Feb 2023 00:22:53 GMT, Kevin Rushforth wrote:
> Can you enable GitHub actions for your repo? If you click on the "Checks" tab
> you 'll see a message from Skara with a pointer as to how to do that (the
> short answer is you go to "Actions" for your personal fork and click the big
>
(I made a mistake and only replied to you, resending this email to the
mailing list and you)
> I've thought a bit about how we could have such a feature without
> introducing Stage appearance to the StyleTheme interface (I think the
> two concepts should remain separate).
> Here's the updated
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Trigger test jobs
-
Changes:
-
On Thu, 2 Feb 2023 18:14:08 GMT, Andy Goryachev wrote:
> Still, I would recommend adding a comment (since now is the time when we know
> all the context, and in the future we might forget or lose the context), may
> be something like
Good idea, let me do it for both strings with parameters
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Added commentary explaining fields ised in
> **Note:** please also read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) to
> learn about how the platform preferences API interacts with the proposed
> `StyleTheme` and `Stage.appearance` features.
>
> Platform preferences are the preferred UI settings of
I have experimented with blurred window backgrounds as well as
blur-behind materials within the JavaFX scene graph.
Here's a screenshot of a JavaFX application using the effect that you
probably want:
On Thu, 2 Feb 2023 18:09:23 GMT, Andy Goryachev wrote:
>>> one way to do it is to describe the expected result in the comment
>>> immediately preceding the string.
>>> ...
>>>
>>> Also, for testing purposes, we could consider pseudolocalization
>>
>> These are good suggestions that should be
On Thu, 2 Feb 2023 18:06:51 GMT, Kevin Rushforth wrote:
>> Sorry for accidentally editing your comment. I think I restored it correctly.
>
>> one way to do it is to describe the expected result in the comment
>> immediately preceding the string.
>> ...
>>
>> Also, for testing purposes, we
On Thu, 2 Feb 2023 17:41:28 GMT, Andy Goryachev wrote:
>>> Do we provide a hint to the translators on how these strings need to be
>>> translated, like giving an example of rendered text?
>>
>> And that is why i did not do any "Google translate" translation in this PR -
>> i will raise a new
On Thu, 2 Feb 2023 18:05:10 GMT, Kevin Rushforth wrote:
>> one way to do it is to describe the expected result in the comment
>> immediately preceding the string. For example:
>>
>>
>> # "the current execution is complete"
>> Class.runText=The run is run.
>>
>> Also, for testing purposes, we
On Thu, 2 Feb 2023 17:28:22 GMT, Alexander Zuev wrote:
>> modules/javafx.controls/src/main/resources/com/sun/javafx/scene/control/skin/resources/controls.properties
>> line 149:
>>
>>> 147:
>>> 148: ### Charts ###
>>> 149: XYChart.series.accessibleText={0} {1} is {2} {3} is {4}
>>
>> Do we
On Thu, 2 Feb 2023 06:32:58 GMT, Ambarish Rapte wrote:
> Update copyright year in files modified in year 2022.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.org/jfx11u/pull/126
On Thu, 2 Feb 2023 06:44:01 GMT, Ambarish Rapte wrote:
> Almost clean backport, with a difference in copyright year. Otherwise clean.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.org/jfx11u/pull/127
Hi,
This is the current status of the experiment:
https://www.youtube.com/watch?v=EJbDVlAp-gA
Not looking as I intend yet.
To check it out (move/resize currently Linux only):
1) clone https://github.com/tsayao/jfx/tree/toolkit_decoration
2) build
3) java @build/run.args
On Thu, 2 Feb 2023 17:00:04 GMT, Andy Goryachev wrote:
> Do we provide a hint to the translators on how these strings need to be
> translated, like giving an example of rendered text?
And that is why i did not do any "Google translate" translation in this PR - i
will raise a new bug to
On Thu, 2 Feb 2023 00:46:31 GMT, Kevin Rushforth wrote:
> Since you added new i18n resource strings have you verified that it works for
> other locales to ensure no regression?
I did - tested with Japanese VoiceOver on Mac, it correctly constructs the
string.
> You'll need to remove this
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Removed debug output.
-
Changes:
On Thu, 2 Feb 2023 06:32:23 GMT, Ambarish Rapte wrote:
> Update copyright year in files modified in year 2022.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.org/jfx17u/pull/105
On Mon, 9 Jan 2023 13:29:27 GMT, Ao Qi wrote:
> Clean backport. Verified on (after #102):
> - Linux/LoongArch64 (`USE_SYSTEM_MALLOC` is `on`, the platform triggering
> this problem)
> - Linux/x64 (`USE_SYSTEM_MALLOC` is `off`)
> - Linux/aarch64 (`USE_SYSTEM_MALLOC` is `off`)
Marked as reviewed
I have a few questions that maybe some Prism/SceneGraph experts could
help me with.
1) Are there any performance tests related to syncing the NGNode peers?
Specifically, I'm interested if there are tests that compare the
performance of "fresh" FX graphs that have never been displayed before,
On Mon, 30 Jan 2023 21:56:45 GMT, Alexander Zuev wrote:
> Change the underlying class XYChart to take into account labels for axes.
> Make label patterns and default axes labels localized.
On Wed, 18 Jan 2023 06:56:57 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present
> Windows implementation of GlassClipboard.cpp uses IStorage interface in
> `PopImage()` to allocate a temporary file, which is then used to capture
> Image data from system clipboard and move it to JVM side. In order for
> temporary file to be removed automatically on `IStorage::Release()`,
>
On Thu, 12 Jan 2023 11:11:23 GMT, Lukasz Kostyra wrote:
> Windows implementation of GlassClipboard.cpp uses IStorage interface in
> `PopImage()` to allocate a temporary file, which is then used to capture
> Image data from system clipboard and move it to JVM side. In order for
> temporary
On Thu, 2 Feb 2023 16:07:26 GMT, Kevin Rushforth wrote:
> Merge `jfx20` into `master`.
This pull request has now been integrated.
Changeset: e1f7d0c4
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx/commit/e1f7d0c42be3839df7679ae45d74907ef33edfbe
Stats: 360 lines in 9
> Merge `jfx20` into `master`.
Kevin Rushforth has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains 10 additional commits
since the last revision:
-
Merge `jfx20` into `master`.
-
Commit messages:
- Merge jfx20
- 8300705: Update boot JDK to 19.0.2
- 8290863: Update the documentation of Virtualized controls to include the
best practice of not using Nodes directly in the item list
- 8300013: Node.focusWithin doesn't account
To: JavaFX Developers
As a reminder, JavaFX 20 is now in Rampdown Phase Two (RDP2). [1]
P1-P2 bugs, and test or doc bugs of any priority, can be fixed during
RDP2. Explicit approval is needed for bug fixes (except for doc and test
fixes), and all enhancements to go in to the jfx20 branch [2].
On Wed, 18 Jan 2023 06:56:57 GMT, Karthik P K wrote:
>> Ignore text condition was not considered in `computePrefHeight` method while
>> calculating the Label height.
>>
>> Added `isIgnoreText` condition in `computePrefHeight` method while
>> calculating Label height.
>>
>> Tests are present
On Wed, 1 Feb 2023 17:39:55 GMT, Ambarish Rapte wrote:
> Updating boot JDK to 19.0.2.
This pull request has now been integrated.
Changeset: 8f2fac06
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx/commit/8f2fac06152d3332e169f5b5389ac2ba84d18bc2
Stats: 11 lines in 2 files
On Mon, 23 Jan 2023 03:51:33 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any
On Thu, 2 Feb 2023 02:41:17 GMT, Ambarish Rapte wrote:
>> Updating boot JDK to 19.0.2.
>
> Ambarish Rapte has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains one commit:
>
> boot jdk 19.0.2b7
Marked as reviewed by jvos (Reviewer).
Vote: yes
Regards
Prasanta
On 01-Feb-23 7:15 PM, Kevin Rushforth wrote:
I hereby nominate Hima Bindu Meda [1] to OpenJFX Committer.
Hima is a member of the JavaFX team at Oracle who has contributed 10
commits [2] to OpenJFX.
Votes are due by February 15, 2023 at 14:00 UTC.
Only current
Vote: yes
Regards
Prasanta
On 01-Feb-23 7:15 PM, Kevin Rushforth wrote:
I hereby nominate Jay Bhaskar [1] to OpenJFX Committer.
Jay is a member of the JavaFX team at Oracle who has contributed 11
commits [2] to OpenJFX.
Votes are due by February 15, 2023 at 14:00 UTC.
Only current OpenJFX
Vote: Yes
Regards,
Ajit
> On 01-Feb-2023, at 7:15 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Jay Bhaskar [1] to OpenJFX Committer.
>
> Jay is a member of the JavaFX team at Oracle who has contributed 11 commits
> [2] to OpenJFX.
>
> Votes are due by February 15, 2023 at 14:00 UTC.
Vote: Yes
Regards,
Ajit
> On 01-Feb-2023, at 7:15 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Hima Bindu Meda [1] to OpenJFX Committer.
>
> Hima is a member of the JavaFX team at Oracle who has contributed 10 commits
> [2] to OpenJFX.
>
> Votes are due by February 15, 2023 at 14:00
On Thu, 26 Jan 2023 05:30:56 GMT, Glavo wrote:
> `List.of` is cleaner, and can slightly reduce the memory footprint for lists
> of one or two elements.
>
> Because `List.of` can only store non-null elements, I have only replaced a
> few usage.
>
> Can someone open an Issue on JBS for me?
On Thu, Feb 2, 2023 at 12:14 AM Pedro Duque Vieira
wrote:
> The fact that a theme is either dark or light is strongly correlated to
> whether you as a developer want all window decorations to be light or dark.
> I'd say that very few use cases will want to have some windows to be light
> and
On Tue, 31 Jan 2023 13:19:56 GMT, Ao Qi wrote:
>> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
>
> RFC and RFR. Thanks. Should I take this PR out of Draft?
@theaoqi Yes, if you take it out of draft, I'll review it.
-
PR:
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote:
> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
RFC and RFR. Thanks. Should I take this PR out of Draft?
-
PR: https://git.openjdk.org/jfx17u/pull/102
On Mon, 9 Jan 2023 13:41:49 GMT, Kevin Rushforth wrote:
>> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
>
> Backports to `jfx17u` require prior approval. You will need to seek such
> approval from one of the project leads before taking this PR out of Draft.
>
>
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote:
> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
Backports to `jfx17u` require prior approval. You will need to seek such
approval from one of the project leads before taking this PR out of Draft.
If it is approved,
Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
-
Commit messages:
- 8293214: Add support for Linux/LoongArch64
Changes: https://git.openjdk.org/jfx17u/pull/102/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=102=00
Issue:
> After thinking about this issue for some time, I've now got a solution.
> I know put the scene in the state it is, before is was shown, when the
> dirtyNodes are unset, the whole scene is basically considered dirty.
> This has the drawback of rerendering, whenever a window is "reshown", but it
54 matches
Mail list logo
