On Thu, 20 Apr 2023 13:41:15 GMT, Kevin Rushforth wrote:
> The change from using the mouse to using the keyboard might change the nature
> of the test. Have you verified that it would still catch the original bug for
> which the test was created?
Yes it still catches the original bug.
> I'd
On Wed, 19 Apr 2023 13:25:07 GMT, Jay Bhaskar wrote:
> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data
> dirs"
> Solution:
> 1. All data directories must only be created under the "build" dir. In
> addition to being a best practice, at least they will be cleaned up
On Thu, 20 Apr 2023 23:49:40 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as
> expected by more accurately mapping from a Mac key code to a Java key code
> based on the user’s active keyboard layout (the existing code assumes a US
> QWERTY layout). The new code first identifies a set of Mac keys
On Thu, 20 Apr 2023 23:33:03 GMT, Martin Fox wrote:
>> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as
>> expected by more accurately mapping from a Mac key code to a Java key code
>> based on the user’s active keyboard layout (the existing code assumes a US
>> QWERTY
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote:
>> This PR adds the following methods to the `EventTarget` interface:
>> 1. `addEventHandler`
>> 2. `removeEventHandler`
>> 3. `addEventFilter`
>> 4. `removeEventFilter`
>
> Michael Strauß has updated the pull request incrementally with one
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as
> expected by more accurately mapping from a Mac key code to a Java key code
> based on the user’s active keyboard layout (the existing code assumes a US
> QWERTY layout). The new code first identifies a set of Mac keys
I haven't waded into this discussion yet, but now that it's settling
down a bit, I will offer a couple very brief thoughts.
I am unconvinced that a content graph should be part of the JavaFX core.
I can see how it might be useful to some apps, but it would be a large
change with fairly
On Wed, 12 Apr 2023 20:10:54 GMT, Martin Fox wrote:
>> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as
>> expected by more accurately mapping from a Mac key code to a Java key code
>> based on the user’s active keyboard layout (the existing code assumes a US
>> QWERTY
Hi Michael,
My current understanding is that yes, FX differs from let's say Swing in that
certain things are not even Nodes (MenuItem, Window, etc.), but once the
initial shock passes, one could certainly write code that constructs the
logical structure using Node.getChildrenUnmodifiable().
I haven't looked, but this seems like it could be useful, as long as it
doesn't require us to add a taglet that would break compilation on JDK
17. If, for example, it can be enabled via a command line option, then
it would be easy to add that conditional on checking that the current
boot JDK
> Monkey Tester - a JavaFX application designed to support manual ad-hoc
> testing of individual JavaFX controls.
>
> Feedback and suggestions are always welcome.
>
> 
Andy
> Monkey Tester - a JavaFX application designed to support manual ad-hoc
> testing of individual JavaFX controls.
>
> Feedback and suggestions are always welcome.
>
> 
Andy
> Monkey Tester - a JavaFX application designed to support manual ad-hoc
> testing of individual JavaFX controls.
>
> Feedback and suggestions are always welcome.
>
> 
Andy
On Thu, 20 Apr 2023 13:28:23 GMT, Karthik P K wrote:
> Test was failing because `CountDownLatch` was not used to make sure that new
> date is selected and the delay present was not sufficient.
> If the current date is on the left edge of the date picker, this test would
> fail because of the
On Thu, 20 Apr 2023 13:28:23 GMT, Karthik P K wrote:
> Test was failing because `CountDownLatch` was not used to make sure that new
> date is selected and the delay present was not sufficient.
> If the current date is on the left edge of the date picker, this test would
> fail because of the
On Tue, 18 Apr 2023 16:17:52 GMT, John Hendrikx wrote:
> Focused only on raw type problems, and removing casts that were no longer
> needed because of the changes.
I see a couple changes to public methods in public classes. I suspect they are
fine, but want to take a slightly closer look.
On Thu, 20 Apr 2023 17:09:52 GMT, Jay Bhaskar wrote:
>> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data
>> dirs"
>> Solution:
>> 1. All data directories must only be created under the "build" dir. In
>> addition to being a best practice, at least they will be
> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data
> dirs"
> Solution:
> 1. All data directories must only be created under the "build" dir. In
> addition to being a best practice, at least they will be cleaned up by
> "gradle clean"
> 2. There should be an
On Wed, 19 Apr 2023 16:41:51 GMT, Andy Goryachev wrote:
>> Monkey Tester - a JavaFX application designed to support manual ad-hoc
>> testing of individual JavaFX controls.
>>
>> Feedback and suggestions are always welcome.
>>
>>
On Thu, 20 Apr 2023 15:31:10 GMT, Andy Goryachev wrote:
> Skipping some checks in Tree/TableViewResizeColumnToFitContentTest on
> platforms with fractional screen scale, until JDK-8299753 gets implemented.
This pull request has now been integrated.
Changeset: cf1e991c
Author:Andy
On Thu, 20 Apr 2023 15:31:10 GMT, Andy Goryachev wrote:
> Skipping some checks in Tree/TableViewResizeColumnToFitContentTest on
> platforms with fractional screen scale, until JDK-8299753 gets implemented.
Looks good.
As an aside, now that I see you are pointing to
On Wed, 19 Apr 2023 18:15:40 GMT, Lukasz Kostyra wrote:
> Changes added to this commit resolve cases where `System.exit()` was used to
> leave tests abruptly. These tests, if System.exit() is hit, could potentially
> create some unwanted behavior from JTest (ex. silently skipping these tests
On Thu, 20 Apr 2023 11:17:26 GMT, Lukasz Kostyra wrote:
>> Changes added to this commit resolve cases where `System.exit()` was used to
>> leave tests abruptly. These tests, if System.exit() is hit, could
>> potentially create some unwanted behavior from JTest (ex. silently skipping
>> these
Skipping some checks in Tree/TableViewResizeColumnToFitContentTest on platforms
with fractional screen scale, until JDK-8299753 gets implemented.
-
Commit messages:
- 8306571: using scalex
- 8306571: skip tests with fractional screen scale
- 8305709: skip when fractional scale
On Thu, 20 Apr 2023 14:32:58 GMT, Karthik P K wrote:
>> tests/system/src/test/java/test/robot/helloworld/CustomSecurityManagerTest.java
>> line 208:
>>
>>> 206:
>>> 207: for (int col = 0; col < 2; col++) {
>>> 208: int x = col == 0 ? 1 : screenWidth.get() -
On Thu, 20 Apr 2023 14:32:07 GMT, Karthik P K wrote:
>> tests/system/src/test/java/test/robot/helloworld/CustomSecurityManagerTest.java
>> line 202:
>>
>>> 200: if (row == 0) {
>>> 201: // avoid the top area as it might contain
>>> OS-specific UI (Macs with
On Wed, 19 Apr 2023 22:50:45 GMT, Andy Goryachev wrote:
> Skipping the test until
> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753) is implemented.
closing this PR per Kevin's instructions, will resubmit under a different JBS
ticket.
-
PR Comment:
On Wed, 19 Apr 2023 22:50:45 GMT, Andy Goryachev wrote:
> Skipping the test until
> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753) is implemented.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jfx/pull/1102
On Thu, 20 Apr 2023 12:22:54 GMT, Kevin Rushforth wrote:
>> Usage of `getBounds()` method instead `getVisualBounds()` was giving
>> unreliable screen bound values and color value was read very close to the
>> edge of the window.
>>
>> Updated the code to use `getVisualBounds()` instead of
Any info on this?
On Tue, Apr 11, 2023 at 4:43 AM Nir Lisker wrote:
> Hi,
>
> I noticed that the JDK's javadoc contains a 'NEW' section [1], but
> JavaFX's docs don't have it. Do we need to update the javadoc tool?
>
> [1] https://docs.oracle.com/en/java/javase/19/docs/api/new-list.html
>
> -
On Thu, 20 Apr 2023 13:28:23 GMT, Karthik P K wrote:
> Test was failing because `CountDownLatch` was not used to make sure that new
> date is selected and the delay present was not sufficient.
> If the current date is on the left edge of the date picker, this test would
> fail because of the
On Thu, 20 Apr 2023 12:33:27 GMT, Jay Bhaskar wrote:
>> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data
>> dirs"
>> Solution:
>> 1. All data directories must only be created under the "build" dir. In
>> addition to being a best practice, at least they will be
On Wed, 19 Apr 2023 15:12:52 GMT, Jay Bhaskar wrote:
>> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data
>> dirs"
>> Solution:
>> 1. All data directories must only be created under the "build" dir. In
>> addition to being a best practice, at least they will be
Test was failing because `CountDownLatch` was not used to make sure that new
date is selected and the delay present was not sufficient.
If the current date is on the left edge of the date picker, this test would
fail because of the way new date was selected using mouse click.
Added
On Thu, 20 Apr 2023 12:33:27 GMT, Jay Bhaskar wrote:
>> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data
>> dirs"
>> Solution:
>> 1. All data directories must only be created under the "build" dir. In
>> addition to being a best practice, at least they will be
> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data
> dirs"
> Solution:
> 1. All data directories must only be created under the "build" dir. In
> addition to being a best practice, at least they will be cleaned up by
> "gradle clean"
> 2. There should be an
On Thu, 20 Apr 2023 08:36:59 GMT, Karthik P K wrote:
> Usage of `getBounds()` method instead `getVisualBounds()` was giving
> unreliable screen bound values and color value was read very close to the
> edge of the window.
>
> Updated the code to use `getVisualBounds()` instead of
On Wed, 19 Apr 2023 15:12:52 GMT, Jay Bhaskar wrote:
>> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data
>> dirs"
>> Solution:
>> 1. All data directories must only be created under the "build" dir. In
>> addition to being a best practice, at least they will be
On Wed, 19 Apr 2023 15:12:52 GMT, Jay Bhaskar wrote:
>> Issue: "LocalStorageTest and UserDataDirectoryTest don't always cleanup data
>> dirs"
>> Solution:
>> 1. All data directories must only be created under the "build" dir. In
>> addition to being a best practice, at least they will be
On Wed, 19 Apr 2023 22:50:45 GMT, Andy Goryachev wrote:
> Skipping the test until
> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753) is implemented.
The check for whether or not this is a fractional scale looks fine. However,
you need to file a new JBS Bug and use that new bug to
Focused only on raw type problems, and removing casts that were no longer
needed because of the changes.
-
Commit messages:
- Fix raw type warnings in graphics project
Changes: https://git.openjdk.org/jfx/pull/1095/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1095=00
> Changes added to this commit resolve cases where `System.exit()` was used to
> leave tests abruptly. These tests, if System.exit() is hit, could potentially
> create some unwanted behavior from JTest (ex. silently skipping these tests
> instead of failing them).
>
> There were some files
On Wed, 19 Apr 2023 18:15:40 GMT, Lukasz Kostyra wrote:
> Changes added to this commit resolve cases where `System.exit()` was used to
> leave tests abruptly. These tests, if System.exit() is hit, could potentially
> create some unwanted behavior from JTest (ex. silently skipping these tests
On Wed, 19 Apr 2023 19:24:09 GMT, Andy Goryachev wrote:
>> Changes added to this commit resolve cases where `System.exit()` was used to
>> leave tests abruptly. These tests, if System.exit() is hit, could
>> potentially create some unwanted behavior from JTest (ex. silently skipping
>> these
On Thu, 20 Apr 2023 08:36:59 GMT, Karthik P K wrote:
> Usage of `getBounds()` method instead `getVisualBounds()` was giving
> unreliable screen bound values and color value was read very close to the
> edge of the window.
>
> Updated the code to use `getVisualBounds()` instead of
> Looking at the PR, there is one thing I have a 'bad feeling' with.
> And that is that everything is done in an eager way.
> E.g. we now maintain another list, the contentModel, even if you don't need
> it.
> I see why this API can be useful. And I even needed something like this, just
> not
Usage of `getBounds()` method instead `getVisualBounds()` was giving unreliable
screen bound values and color value was read very close to the edge of the
window.
Updated the code to use `getVisualBounds()` instead of `getBounds()` and moved
the coordinates inside the window from where the
On Tue, 18 Apr 2023 00:54:53 GMT, Michael Strauß wrote:
>> This would depend I think how you want to approach this. I added three
>> variants, invalidations, changes and values. Using the same name
>> `subscribe`, you need to make sure the lambda's used all have a different
>> arity, or
Looking at the PR, there is one thing I have a 'bad feeling' with.
And that is that everything is done in an eager way.
E.g. we now maintain another list, the contentModel, even if you don't need it.
I see why this API can be useful. And I even needed something like this, just not very often.
On Thu, 20 Apr 2023 07:17:39 GMT, Johan Vos wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
>> line 858:
>>
>>> 856:
>>> 857: @Override protected void invalidated() {
>>> 858: int oldIndex = computeCurrentIndex();
>>
>> I wonder
On Wed, 19 Apr 2023 22:50:45 GMT, Andy Goryachev wrote:
> Skipping the test until
> [JDK-8299753](https://bugs.openjdk.org/browse/JDK-8299753) is implemented.
Looks good to me!
-
Marked as reviewed by aghaisas (Reviewer).
PR Review:
On Wed, 19 Apr 2023 17:49:06 GMT, Abhinay Agarwal wrote:
> Add release notes for JavaFX 20.0.1
This pull request has now been integrated.
Changeset: 65c4f355
Author:Abhinay Agarwal
Committer: Johan Vos
URL:
On Wed, 19 Apr 2023 16:33:37 GMT, Marius Hanl wrote:
>> Calculate position of first visible element before propagating changes.
>> Make sure to restore the position of said element after the changes are done.
>>
>> Fix JDK-8306447
>
>
54 matches
Mail list logo
