On Thu, 7 Dec 2023 17:28:25 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line
>> 611:
>>
>>> 609:
>>> 610: /**
>>> 611: * The accent color.
>>
>> I think that this needs to explanation on what the accent color is.
>
> I'
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
Gradle 8.5.0 released on Nov 29, 2023, supports JDK 21.
We need to update Gradle to 8.5 in order to update the boot JDK.
There are not API level changes in Gradle that we need to work on, hence the
change is only Gradle version update.
Also, merging the PR with boot jdk update to 21.0.1 b12
Could it be done with annotations alone?
CssMetaData requires the following:
- property name
- object type
- converter
- initial value
- inherits
- list of sub-properties (of type List>)
see Region
But, if it is indeed possible, it would be a very good solution.
-andy
From: openjfx-dev on b
We could also use reflection in combination with annotations. You'd
need to annotate every CSS-styleable property (a simple @Styleable
annotation would suffice), and at runtime we can discover the
annotated methods and reflect their metadata.
This solves the problem that automatic styleable proper
On Wed, 6 Dec 2023 21:48:46 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed bug in test application
>
> The value does indeed change:
> macOS.NSColor.alternatingContentBackgroundColors =
On Sun, 29 Jan 2023 01:33:48 GMT, Michael Strauß wrote:
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Th
Dear Martin:
It's hard to say. How does it work in Swing?
There is also
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/radio_role
I always felt that the focus management in JavaFX is underdeveloped: multiple
focused nodes, nodes getting simultaneous input, lack of coher
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Thu, 7 Dec 2023 18:30:24 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/WindowsHighContrastScheme.java
>> line 43:
>>
>>> 41: * The high contrast feature may not be available on all platforms.
>>> 42: */
>>> 43: enum WindowsHighContrastScheme
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Thu, 7 Dec 2023 18:17:58 GMT, Jose Pereda wrote:
>> Michael Strauß has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - removed unused import
>> - javadoc
>> - query resource bundles for high-contrast schemes only on Windows
>
> modu
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Thu, 7 Dec 2023 08:04:45 GMT, Nir Lisker wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renamed Windows.SPI.HighContrastOn to Windows.SPI.HighContrast
>
> modules/javafx.graphics/src/main/java/javafx/applicat
On Thu, 7 Dec 2023 08:45:43 GMT, Nir Lisker wrote:
> There are classes such as `PlatformPreferences`, `PreferenceProperties`, and
> `ColorSchemeProperty` that are effectively singletons. Does it makes sense to
> just write them in a singleton pattern to avoid misuse?
If we add user-modifiable
On Thu, 7 Dec 2023 15:24:11 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renamed Windows.SPI.HighContrastOn to Windows.SPI.HighContrast
>
> modules/javafx.graphics/src/main/java/com/sun/ja
On Thu, 7 Dec 2023 16:12:21 GMT, Jose Pereda wrote:
> Windows high contrast seems to work fine now.
>
> However, I'm building your PR (./gradlew sdk) and running the test on Mac,
> but I get:
>
> ```
> Exception in Application start method
> java.lang.reflect.InvocationTargetException
> ...
On Thu, 7 Dec 2023 15:43:48 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/ColorScheme.java
>> line 35:
>>
>>> 33: * @since 22
>>> 34: */
>>> 35: public enum ColorScheme {
>>
>> Can there be future additions to this enum, or is its purpose to be limit
On Thu, 7 Dec 2023 05:49:07 GMT, Nir Lisker wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renamed Windows.SPI.HighContrastOn to Windows.SPI.HighContrast
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally wi
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
>
> Surely, you don't suggest we should change the CSS ref?
>
A lot of that reference is derived from the source code. As an example,
look at all the Available CSS Properties tables. They contain the name,
values, defaults that are specified in the code, and the superclass they
inherit from.
It's
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
I haven't looked at this proposal yet, but there are some interesting
ideas here worth further discussion.
I just wanted to weigh in on the cssref piece. As Andy indicated,
cssref.html is the normative specification for JavaFX CSS properties.
And no, it can't be (fully) auto-generated.
The o
On Thu, 7 Dec 2023 07:57:01 GMT, Nir Lisker wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renamed Windows.SPI.HighContrastOn to Windows.SPI.HighContrast
>
> modules/javafx.graphics/src/main/java/javafx/applicat
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
> I think that the CSS reference should be generated from the source code,
> which is something the annotation processor can do.
Surely, you don't suggest we should change the CSS ref?
https://openjfx.io/javadoc/21/javafx.graphics/javafx/scene/doc-files/cssref.html
I subscribe to a school of th
Thank you, Johan.
Just to clarify, the "eclipse" is used by the umbrella task
https://bugs.openjdk.org/browse/JDK-8297300, the actual changes come under
their own specific titles. Very low priority.
-andy
From: Johan Vos
Date: Thursday, December 7, 2023 at 02:37
To: Andy Goryachev
Cc: Kev
That's a good question. I guess it's a compromise.
>From a backport-point-of-view, 1 PR (hence 1 JBS issue) per file is ideal.
But that is not realistic of course, as it would clutter the JBS issues and
the github PR's.
I think package-based PR's would be a good compromise. That would also make
it
>
> - I would recommend against the scanner figuring out the property name:
> the property > names are codified by the CSS reference which serves as a
> normative document in this case
>
I think that the CSS reference should be generated from the source code,
which is something the annotation pro
>
> I also like this route, perhaps slightly more, depending on how far this
> can be taken
>
Yes, how far is the initial question I had when initially proposing the
alternative Andy asked for.
A few points:
@Styleable(name = "-fx-label-padding", defaultValue = "(0, 0, 0, 0)")
...
The required
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
35 matches
Mail list logo
