On Thu, 20 Jun 2024 23:55:16 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typos
>
> tests/manual/web/WebSocketTestApp.java line 62:
>
>> 60: failButton.setOnAction(e -> {
>> 61:
On Fri, 21 Jun 2024 00:01:21 GMT, Jay Bhaskar wrote:
>> tests/manual/web/WebSocketTestApp.java line 62:
>>
>>> 60: failButton.setOnAction(e -> {
>>> 61: Platform.exit();
>>> 62: throw new AssertionError("!Unable to receive meesgae data
>>> from server, something
On Fri, 21 Jun 2024 00:04:42 GMT, Jay Bhaskar wrote:
>> Issue: The Websocket Channel is broken
>> Solution: The socket Provider needs a web page pointer, since the web socket
>> channel source code is moved to WebkitLegacy in 617.1 for the web process
>> model, it is invalid for JavaFx
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for JavaFx Webkit.
Jay Bhaskar has updated the pull request incrementally
On Thu, 20 Jun 2024 23:55:53 GMT, Jay Bhaskar wrote:
>> Issue: The Websocket Channel is broken
>> Solution: The socket Provider needs a web page pointer, since the web socket
>> channel source code is moved to WebkitLegacy in 617.1 for the web process
>> model, it is invalid for JavaFx
On Thu, 20 Jun 2024 23:48:32 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adding review comments
>
> tests/manual/web/WebSocketTestApp.java line 62:
>
>> 60:
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for JavaFx Webkit.
Jay Bhaskar has updated the pull request incrementally
On Thu, 20 Jun 2024 23:21:48 GMT, Jay Bhaskar wrote:
>> Issue: The Websocket Channel is broken
>> Solution: The socket Provider needs a web page pointer, since the web socket
>> channel source code is moved to WebkitLegacy in 617.1 for the web process
>> model, it is invalid for JavaFx
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for JavaFx Webkit.
Jay Bhaskar has updated the pull request incrementally
On Thu, 20 Jun 2024 15:30:03 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> adding review comments
>
> tests/manual/web/WebSocketTestApp.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2022,
On Thu, 20 Jun 2024 19:11:48 GMT, Markus Mack wrote:
> adding empty series
ah, right!
> the tick marks on the axis are in incorrect
this might be [JDK-8314754](https://bugs.openjdk.org/browse/JDK-8314754)
-
PR Comment:
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a comment to `BarChart`s javadoc,
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a comment to `BarChart`s javadoc,
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a comment to `BarChart`s javadoc,
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a comment to `BarChart`s javadoc,
On Thu, 20 Jun 2024 17:59:13 GMT, Andy Goryachev wrote:
>> You'll need to add an additional point after adding the one with duplicate
>> categories to see the exception in the console. Using the "Add Point" button
>> in the monkey tester after using the context menu entry should reproduce the
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a comment to `BarChart`s javadoc,
On Thu, 20 Jun 2024 17:50:20 GMT, Markus Mack wrote:
>> I've added a popup menu on the BarChart page in the Monkey Tester to test
>> the case ...
>> https://github.com/andy-goryachev-oracle/MonkeyTest
>
> You'll need to add an additional point after adding the one with duplicate
> categories
On Thu, 20 Jun 2024 16:52:49 GMT, Andy Goryachev wrote:
>> However, I don't see the issue if I just add a duplicate data point after
>> the chart is rendered (the code jumps to line 218 (edit: 216, sorry) in the
>> master branch).
>>
>> This makes me think that perhaps the fix should include
> This PR provides the test case given in the JBS issue, and a simple fix for
> the index calculation when inserting data after previous data with duplicate
> categories.
>
> Also, I've added a comment to `BarChart`s javadoc, clarifying the behavior
> that was apparently assumed (but broken)
On Thu, 20 Jun 2024 16:34:23 GMT, Andy Goryachev wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a comment to `BarChart`s javadoc,
On Wed, 19 Jun 2024 10:21:52 GMT, Markus Mack wrote:
> This PR provides the test case given in the JBS issue, and a simple fix for
> the index calculation when inserting data after previous data with duplicate
> categories.
>
> Also, I've added a comment to `BarChart`s javadoc, clarifying the
On Thu, 20 Jun 2024 16:50:23 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/chart/BarChart.java line
>> 215:
>>
>>> 213: if (!categoryAxis.getCategories().contains(category)) {
>>> 214: // find category index in case data contains duplicate
On Wed, 19 Jun 2024 10:21:52 GMT, Markus Mack wrote:
> This PR provides the test case given in the JBS issue, and a simple fix for
> the index calculation when inserting data after previous data with duplicate
> categories.
>
> Also, I've added a comment to `BarChart`s javadoc, clarifying the
On Wed, 19 Jun 2024 10:21:52 GMT, Markus Mack wrote:
> This PR provides the test case given in the JBS issue, and a simple fix for
> the index calculation when inserting data after previous data with duplicate
> categories.
>
> Also, I've added a comment to `BarChart`s javadoc, clarifying the
On Thu, 20 Jun 2024 02:25:54 GMT, Jay Bhaskar wrote:
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for JavaFx Webkit.
On Thu, 20 Jun 2024 02:25:54 GMT, Jay Bhaskar wrote:
> Issue: The Websocket Channel is broken
> Solution: The socket Provider needs a web page pointer, since the web socket
> channel source code is moved to WebkitLegacy in 617.1 for the web process
> model, it is invalid for JavaFx Webkit.
27 matches
Mail list logo
